[13:04:19] (PS4) Mepps: Updated donation interface for orphan_slayer and module update Bug: T172202 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384077 (https://phabricator.wikimedia.org/T172202) [16:06:23] Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: adyen cookie error after entering information on Safari - https://phabricator.wikimedia.org/T176913#3687998 (DStrine) @P... [16:24:56] (CR) Anomie: [C: 2] "I was initially concerned that the core ApiStructureTest didn't flag this issue before I593366d4 was merged." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/384297 (owner: Umherirrender) [16:34:03] (Merged) jenkins-bot: Add apihelp-logPaymentsFormError-summary to en.json/qqq.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/384297 (owner: Umherirrender) [17:00:56] Fundraising-Backlog: Civi: recent Ingenico transactions missing country data - https://phabricator.wikimedia.org/T178316#3688104 (MBeat33) [17:46:30] Wikimedia-Fundraising: Update WMF logo on Square Cash donation page - https://phabricator.wikimedia.org/T168663#3688259 (Varnent) [17:46:33] Wikimedia-Fundraising: Update WMF logo on Coinbase donation page - https://phabricator.wikimedia.org/T168662#3688260 (Varnent) [18:11:07] (PS1) Ejegg: Fix country-only address imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384572 (https://phabricator.wikimedia.org/T178316) [18:20:22] (CR) jerkins-bot: [V: -1] Fix country-only address imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384572 (https://phabricator.wikimedia.org/T178316) (owner: Ejegg) [19:23:29] Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: adyen cookie error after entering information on Safari - https://phabricator.wikimedia.org/T176913#3688610 (Pcoombe) Te... [19:35:44] Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review: Civi: recent Ingenico transactions missing country data - https://phabricator.wikimedia.org/T178316#3688656 (DStrine) [19:52:49] Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Implement concept of 'load' action to dedupe (& api in general) - https://phabricator.wikimedia.org/T177882#3673697 (Eileenmcna... [20:17:10] (CR) Eileen: "Just a note to say this got merged upstream" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/383501 (https://phabricator.wikimedia.org/T177873) (owner: Eileen) [20:17:35] (Abandoned) Eileen: purely for testing purposes - do not merge [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/383711 (owner: Eileen) [20:22:18] (PS5) Ejegg: Updated donation interface for orphan_slayer and module update Bug: T172202 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384077 (https://phabricator.wikimedia.org/T172202) (owner: Mepps) [20:23:22] (CR) Ejegg: [C: 2] Updated donation interface for orphan_slayer and module update Bug: T172202 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384077 (https://phabricator.wikimedia.org/T172202) (owner: Mepps) [20:27:14] (Merged) jenkins-bot: Updated donation interface for orphan_slayer and module update Bug: T172202 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384077 (https://phabricator.wikimedia.org/T172202) (owner: Mepps) [20:29:40] Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: adyen cookie error after entering information on Safari - https://phabricator.wikimedia.org/T176913#3688836 (mepps) a:... [21:18:54] ejegg: I'm just looking to create a civicrm_omnimail_job_progress table to track jobs (no logging table) - there isn't anything else you would think I should consider instead is there? I suppose if I made it civicrm_job_progress it could be used by dedupe as well (would need to be a separate extension then) [21:19:20] single-use table for the omnimail job sounds fine to me [21:19:51] (PS2) Ejegg: Fix country-only address imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384572 (https://phabricator.wikimedia.org/T178316) [21:19:59] ok - I'll do that [21:20:53] I'll have to figure out how to delete the rows from log_civicrm_setting - will need batching but might need to run over time rather than an upgrade script [21:21:22] oh, you think it's worth cleaning those up? [21:21:37] well there will be rather a lot of them [21:21:49] millions of rows I think [21:22:04] heh, k, sounds good [21:22:13] I keep thinking about that temp table drop then create [21:22:18] hopefully a delete won't take too much time! [21:22:26] that is weird that it does that [21:22:34] very weird [21:22:57] I feel like we should log it as a mysql bug - except I worry that not being able to write it as pure sql reproducable they would reject it as a bug [21:23:20] heck, that could apply to anything replication-related [21:23:26] :-) [21:23:47] I feel like they have seemed quite 'rejecty' when I've looked at their issues before [21:23:57] but, that would affect restore from backup too [21:24:16] restore from bin not backup [21:24:27] sigh [21:26:13] (CR) jerkins-bot: [V: -1] Fix country-only address imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384572 (https://phabricator.wikimedia.org/T178316) (owner: Ejegg) [21:40:02] (PS3) Ejegg: Fix country-only address imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384572 (https://phabricator.wikimedia.org/T178316) [21:43:53] (CR) jerkins-bot: [V: -1] Fix country-only address imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384572 (https://phabricator.wikimedia.org/T178316) (owner: Ejegg) [21:51:58] (PS4) Ejegg: Fix country-only address imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384572 (https://phabricator.wikimedia.org/T178316) [22:05:25] ok, that's passing tests. Fr-tech, anyone have time to look at it? ^^ [22:05:31] (PS5) Ejegg: Fix country-only address imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384572 (https://phabricator.wikimedia.org/T178316) [22:05:43] Yea, can do. [22:06:47] Thanks! [22:11:41] (CR) XenoRyet: [C: 2] Fix country-only address imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384572 (https://phabricator.wikimedia.org/T178316) (owner: Ejegg) [22:15:39] (Merged) jenkins-bot: Fix country-only address imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384572 (https://phabricator.wikimedia.org/T178316) (owner: Ejegg) [22:41:19] ejegg: from memory we used to have a problem with country only addresses overwriting addresses with more data [22:42:02] ah, that would still be a problem [22:42:35] the latest snafu was caused by PayPal giving us addresses in the netherlands antilles, which is no longer a country [22:42:42] ug [22:43:09] so we were trying to insert addresses with no country code (since they DID have street information) [22:43:27] and hitting a constraint violation, which Civi had no idea how to handle [22:43:36] and ended up calling exit() [22:48:36] so we didn't even get a chance to drop the messages in the damaged DB [23:04:57] (PS1) Ejegg: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384626 [23:05:02] (CR) Ejegg: [C: 2] Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384626 (owner: Ejegg) [23:06:37] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/384627 (https://phabricator.wikimedia.org/T172202) [23:06:45] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/384627 (https://phabricator.wikimedia.org/T172202) (owner: Ejegg) [23:06:58] eileen1: deploying your 'proactively delete temp tables' patch [23:07:57] ejegg: ah ok - hopefully that doesn't cause another round of drop then create :-) Can't think how it would but…. [23:11:38] (Merged) jenkins-bot: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384626 (owner: Ejegg) [23:11:40] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/384627 (https://phabricator.wikimedia.org/T172202) (owner: Ejegg) [23:15:38] shoot, missed the vendor update [23:27:17] (PS1) Ejegg: Update DonationInterface library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/384630 [23:27:29] (CR) Ejegg: [C: 2] Update DonationInterface library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/384630 (owner: Ejegg) [23:28:15] (PS1) Ejegg: Update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/384631 [23:28:34] (CR) Ejegg: [C: 2] Update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/384631 (owner: Ejegg) [23:33:56] (Merged) jenkins-bot: Update DonationInterface library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/384630 (owner: Ejegg) [23:33:58] (Merged) jenkins-bot: Update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/384631 (owner: Ejegg) [23:39:24] !log updated civicrm from b953064ec27228f158c3d0e5aa9cdf043cb20256 to 824c2d8d9b63b64cf61d2ebf71e385f46bb4b7a3 [23:39:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log