[09:35:36] <wikibugs>	 Fundraising-Backlog: Bahrain & Oman donation forms - minimum amount error - https://phabricator.wikimedia.org/T178402#3699028 (Pcoombe) Looks like donatewiki is correctly sending `amount=5` in the URL, so it seems the problem is on the payments end.
[13:17:26] <wikibugs>	 Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Back-fill missing pgehres data - https://phabricator.wikimedia.org/T178009#3699586 (Jgreen) >>! In...
[14:58:43] <wikibugs>	 (PS2) Mepps: Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913)
[15:00:53] <wikibugs>	 (CR) jerkins-bot: [V: -1] Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913) (owner: Mepps)
[15:01:34] <wikibugs>	 (PS3) Mepps: Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913)
[15:04:25] <wikibugs>	 (CR) jerkins-bot: [V: -1] Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913) (owner: Mepps)
[15:08:53] <mepps>	 ejegg|away cwd looking at the failmail for the adyen listener--do we know of any planned outage?
[15:26:28] <wikibugs>	 (PS4) Mepps: Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913)
[15:28:13] <wikibugs>	 (CR) jerkins-bot: [V: -1] Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913) (owner: Mepps)
[15:29:42] <wikibugs>	 (PS5) Mepps: Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913)
[15:32:28] <wikibugs>	 (CR) jerkins-bot: [V: -1] Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913) (owner: Mepps)
[15:57:07] <ejegg>	 fr-tech anyone have a minute to review this? https://gerrit.wikimedia.org/r/385307
[15:57:45] <ejegg>	 the format it's got to match is in civi1001:/srv/archive/banner_logs/2017_recovered
[16:08:42] <mepps>	 i'll take a look at that ejegg
[16:08:49] <ejegg>	 thanks!
[16:09:05] <ejegg>	 re: adyen, I don't know of any scheduled outages
[16:15:58] <mepps>	 it looked like a request was timing out
[16:25:50] <ejegg>	 mepps shoot, we really need to get that thing re-trying
[16:26:20] <ejegg>	 I'll put up a patch for the easy solution, just retrying with the same soap_call
[16:26:37] <ejegg>	 but it would be spiffy to be able to do that soap_call via our CurlWrapper
[16:56:31] <mepps>	 hey ejegg so regex isn't my super specialty but is xff supposed to be optional now?
[16:56:36] <mepps>	 the service time fix looks fine
[16:56:42] <mepps>	 the comment confuses me which is why i ask
[16:56:47] <ejegg>	 mepps it looked like it was supposed to be optional before
[16:56:58] <ejegg>	 but the ? only affected the field itself
[16:57:04] <ejegg>	 and not the following tab
[16:57:17] <mepps>	 ahh, that makes sense
[16:57:21] <mepps>	 so it's sitll optional?
[16:57:27] <ejegg>	 yep!
[16:57:35] <ejegg>	 lemme see if we even use that field...
[16:57:40] <mepps>	 that's what i was confused about--the way the comment is phrased i thought maybe i twasn't supposed to be
[16:58:28] <ejegg>	 ooh, I think we DO use it. I should add another check
[16:58:35] <ejegg>	 good catch!
[16:59:09] <ejegg>	 or will .group('xff') just return null ?
[17:01:26] <ejegg>	 ok, looks like m.group('xff') will just return null for the case where that field is missing
[17:01:37] <ejegg>	 mepps, the patch should be cool as is
[17:01:43] <mepps>	 okay cool i'm okay to +2 it then
[17:01:47] <ejegg>	 thanks!
[17:01:52] <wikibugs>	 (PS2) Mepps: Loosen squidline regex format [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/385307 (https://phabricator.wikimedia.org/T178009) (owner: Ejegg)
[17:01:56] <wikibugs>	 (CR) Mepps: [C: 2] Loosen squidline regex format [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/385307 (https://phabricator.wikimedia.org/T178009) (owner: Ejegg)
[17:02:01] <ejegg>	 I'll do a friday deploy so we can get those stats backfilled
[17:02:13] <wikibugs>	 (Merged) jenkins-bot: Loosen squidline regex format [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/385307 (https://phabricator.wikimedia.org/T178009) (owner: Ejegg)
[17:04:18] <ejegg>	 ah right, no deploy branch there
[17:11:48] <ejegg>	 great, that's looking much better!
[17:21:19] <wikibugs>	 Fundraising-Backlog, FR-Adyen: Adyen form error message: cookies/cache - https://phabricator.wikimedia.org/T140109#3700114 (Ejegg)
[17:21:21] <wikibugs>	 Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: adyen cookie error after entering information on S... - https://phabricator.wikimedia.org/T176913#3700117
[18:27:02] <ejegg|food>	 nick ejegg
[18:29:05] <wikibugs>	 (PS6) Mepps: Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913)
[18:30:03] <wikibugs>	 (PS7) Mepps: Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913)
[18:34:57] <mepps>	 okay passing build passing ^^ ejegg
[18:35:05] <ejegg|food>	 awesome!
[18:37:47] <ejegg>	 mepps what do you think of changing 'skinName' to something that more clearly indicates it relates to the processor page?
[18:38:03] <ejegg>	 processor_skin or something?
[18:38:21] <ejegg>	 ooh, I see.. you have processor_form
[18:38:24] <ejegg>	 sorry!
[18:39:21] <mepps>	 yeah skinName is the mapped name although i'm open to trying something else
[18:40:15] <ejegg>	 oh, I was just confused - we have to use skinName for the Adyen API, right?
[18:49:34] <mepps>	 no ejegg that's internal
[18:50:11] <mepps>	 we could i guess just use processor_form?
[18:50:13] <ejegg>	 ah hmm, think we shouldn't send that to adyen or include it in signing params... will reply in gerrit
[18:50:42] <mepps>	 we don't include it in signing params but i did need to access it various places
[18:51:41] <mepps>	 basically i need to be able to get the value both in hostedsig and in the transaction
[18:52:02] <ejegg>	 right... the unstaged variables ought to be available in the hostedSig
[18:54:08] <mepps>	 hmm is there a good way to set a default value for processor_form?
[18:55:05] <ejegg>	 mepps oh shoot, there's one more wrinkle - when the donor comes back from adyen, we use the signature calculation to verify the returned params
[18:55:25] <ejegg>	 and they send us back the skinCode so we know which HMAC to use
[18:55:25] <mepps>	 ahh
[18:56:16] <mepps>	 hmm
[18:58:54] <wikibugs>	 (CR) Ejegg: "This mostly looks great! A couple caveats - we don't want to send any more parameters to Adyen, or add anything to the list of signed para" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913) (owner: Mepps)
[19:00:04] <ejegg>	 Here's the doc on verifying the returned parameters: https://docs.adyen.com/developers/products-and-subscriptions/hosted-payment-pages/hpp-payment-response/payment-response-merchantsig-sha-256
[19:39:59] <wikibugs>	 Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Back-fill missing pgehres data - https://phabricator.wikimedia.org/T178009#3700573 (Ejegg) OK, the...
[20:12:03] <wikibugs>	 Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Update librdkafka on banner log boxen - https://phabricator.wikimedia.org/T178432#3700611 (Jgre...
[20:47:33] <wikibugs>	 Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Update librdkafka on banner log boxen - https://phabricator.wikimedia.org/T178432#3700692 (Jgre...
[21:06:21] <wikibugs>	 Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Update librdkafka on banner log boxen - https://phabricator.wikimedia.org/T178432#3700703 (Jgre...
[21:16:48] <wikibugs>	 (PS8) Mepps: Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913)
[21:17:14] <mepps>	 ejegg ^^ this might need a little cleanup, but i think it's looking like a better direction, what do you think?
[21:17:22] <ejegg>	 looking!
[21:18:36] <wikibugs>	 (CR) jerkins-bot: [V: -1] Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913) (owner: Mepps)
[21:21:50] <wikibugs>	 (PS9) Mepps: Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913)
[21:23:03] <wikibugs>	 (CR) jerkins-bot: [V: -1] Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913) (owner: Mepps)
[21:23:09] <wikibugs>	 (PS10) Mepps: Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913)
[21:25:01] <wikibugs>	 (CR) Ejegg: "Definitely looking like the right direction! I'd love to see unit tests with the skin swapping, both for API call prep and for return proc" (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913) (owner: Mepps)
[21:25:13] <wikibugs>	 (CR) jerkins-bot: [V: -1] Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913) (owner: Mepps)
[21:25:35] <ejegg>	 Mepps I can toss together a sketch of the unit tests I'd want
[21:29:08] <wikibugs>	 (PS11) Mepps: Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913)
[21:30:55] <wikibugs>	 (CR) jerkins-bot: [V: -1] Redirect for Safari + multiskins [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385253 (https://phabricator.wikimedia.org/T176913) (owner: Mepps)
[21:36:12] <ejegg>	 mepps: d'oh! default being a js keyword came up before somewhere
[21:38:00] <ejegg>	 might have to call it 'iframe' ?
[21:40:57] <wikibugs>	 (CR) Ejegg: [C: 2] "Looks good! Would be nice to rename job_suffix field / keys to match job_identifier" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384953 (https://phabricator.wikimedia.org/T177451) (owner: Eileen)
[21:42:14] <wikibugs>	 (CR) Ejegg: [C: -2] "Ah, ok, we'll need to hold off on this patch for now. Fundraising is still on the long-term-support version of Mediawiki" [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/307044 (https://phabricator.wikimedia.org/T142392) (owner: Paladox)
[21:44:57] <wikibugs>	 (Merged) jenkins-bot: Switch over to new table & entity to track omnimail job progress [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384953 (https://phabricator.wikimedia.org/T177451) (owner: Eileen)
[21:53:10] <wikibugs>	 (PS4) Ejegg: Upgrader for switching omnimail job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/385034 (https://phabricator.wikimedia.org/T177451) (owner: Eileen)
[21:53:31] <wikibugs>	 (CR) Ejegg: [C: 2] "matches the DAO definition, works on my machine" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/385034 (https://phabricator.wikimedia.org/T177451) (owner: Eileen)
[21:56:53] <wikibugs>	 (PS2) Ejegg: Drush command to delete extraneous log_setting entries. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/385114 (https://phabricator.wikimedia.org/T177451) (owner: Eileen)
[21:57:17] <wikibugs>	 (CR) Ejegg: [C: 2] "Looks good, one nitpick on loop condition." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/385114 (https://phabricator.wikimedia.org/T177451) (owner: Eileen)
[21:57:33] <wikibugs>	 (Merged) jenkins-bot: Upgrader for switching omnimail job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/385034 (https://phabricator.wikimedia.org/T177451) (owner: Eileen)
[22:01:04] <wikibugs>	 (Merged) jenkins-bot: Drush command to delete extraneous log_setting entries. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/385114 (https://phabricator.wikimedia.org/T177451) (owner: Eileen)
[22:16:19] <wikibugs>	 (PS1) Ejegg: Unit tests for Adyen multi-skin switching [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385483
[22:21:40] <wikibugs>	 (CR) jerkins-bot: [V: -1] Unit tests for Adyen multi-skin switching [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385483 (owner: Ejegg)
[22:30:14] <icinga-wm>	 PROBLEM - check_puppetrun on americium is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[kafkatee]
[22:35:14] <icinga-wm>	 PROBLEM - check_puppetrun on americium is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 11 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[kafkatee]
[22:40:14] <icinga-wm>	 PROBLEM - check_puppetrun on americium is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 48 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[kafkatee]
[22:45:05] <icinga-wm>	 PROBLEM - check_puppetrun on americium is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[kafkatee]
[22:50:14] <icinga-wm>	 PROBLEM - check_puppetrun on americium is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 19 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[kafkatee]
[22:55:14] <icinga-wm>	 RECOVERY - check_puppetrun on americium is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures
[23:51:15] <wikibugs>	 Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Thank you letter from civi mangles non-$ currencies - https://phabricator.wikimedia.org/T151957#3700917 (MBeat33) Resolved>Open...