[01:32:06] MediaWiki-extensions-FundraisingChart, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingChart extension - https://phabricator.wikimedia.org/T178762#3705366 (MacFan4000) [08:39:39] Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: Email stats may be off (possible link to missing data in pgehres) - https://phabricator.wikimedia.org/T178819#3705758 (CCogdill_WMF) We've decided to stop sending emai... [12:55:56] hello all o/ [13:54:18] Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: Email stats may be off (possible link to missing data in pgehres) - https://phabricator.wikimedia.org/T178819#3706463 (Pcoombe) @CCogdill_WMF I think we do need to co... [15:24:36] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Registering test in... - https://phabricator.wikimedia.org/T176334#3706870 [15:56:22] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Registering test in... - https://phabricator.wikimedia.org/T176334#3707008 [15:59:57] Best sprint names evar. [16:00:19] :) [16:14:19] (PS1) Ejegg: Don't require API read rights to report client-side errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386215 (https://phabricator.wikimedia.org/T121800) [16:14:39] Oops, client-side error reporting is being stymied by permissions ^^^ [16:14:52] I guess I shouldn't test logged-in locally! [16:15:29] fr-tech that one's nice and trivial if anyone has a moment to review [16:15:44] ejegg i can take a look [16:15:48] thanks mepps! [16:16:21] (CR) jerkins-bot: [V: -1] Don't require API read rights to report client-side errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386215 (https://phabricator.wikimedia.org/T121800) (owner: Ejegg) [16:16:32] d'oh, what's up with that? [16:16:41] yeah was just going to ask [16:17:25] hmm weird it's from my pr but it didn't fail before [16:17:28] oh weird, it's failing b/c of the process_form? [16:17:36] *processor_form [16:17:46] and I thought you'd added that doc too [16:18:03] me too... [16:18:16] ohhh, it's not in the qqq.json [16:18:29] that's the i18n explanation file [16:19:15] awight: it was the brainchild of Eileen's child [16:19:39] fr-tech jgleeson morning! [16:19:46] (PS2) Ejegg: Don't require API read rights to report client-side errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386215 (https://phabricator.wikimedia.org/T121800) [16:19:48] (PS1) Ejegg: Add processor_form to qqq.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386218 [16:19:50] Hi AndyRussG ! [16:19:59] mepps: ok, those oughtta pass now [16:20:45] :) [16:23:18] cool waiting on a passing build ejegg and will +2 [16:23:25] thanks! [16:24:37] AndyRussG: Brain child of a brainy child, I’m sure [16:25:37] awight: heh fer sure :) [16:26:53] fr-tech mepps anyone looking to dip their toes in a bit of CentralNotice, here's a slightly longer list of open changes for review: https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/CentralNotice+status:open [16:27:45] Here's one that pcoombe mentioned community is interested in, and is pretty small: https://gerrit.wikimedia.org/r/#/c/380891/ [16:34:22] AndyRussG: oh hey. A volunteer dev was hoping to propose a small CentralNotice project for mentorship, the discussion so far is in T108736. [16:34:23] T108736: Deleting a banner should delete everything related to such banner - https://phabricator.wikimedia.org/T108736 [16:36:14] mepps looks like both those builds pass now [16:37:03] awight: ah K thanks! :) [16:41:08] awight: how's ores been treating you? [16:41:55] (CR) Mepps: [C: 2] Add processor_form to qqq.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386218 (owner: Ejegg) [16:42:03] (CR) Mepps: [C: 2] Don't require API read rights to report client-side errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386215 (https://phabricator.wikimedia.org/T121800) (owner: Ejegg) [16:43:41] AndyRussG: ORES is fun work, and the change of pace is much appreciated. It’s mostly tech debt service and munging large amounts of data, but it includes some interesting su side projects such as figuring out how this might work: https://www.mediawiki.org/wiki/JADE [16:43:48] (Merged) jenkins-bot: Add processor_form to qqq.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386218 (owner: Ejegg) [16:44:54] (Merged) jenkins-bot: Don't require API read rights to report client-side errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386215 (https://phabricator.wikimedia.org/T121800) (owner: Ejegg) [16:50:28] hey AndyRussG, just finished reading through https://phabricator.wikimedia.org/T176802, can you tell me what's needed for review (if anything) it looks like the new query solved the problem from my reading [16:52:55] Fundraising-Backlog: CentralNotice: Consolidate typical analytics queries (for example, for impression rates) into a library - https://phabricator.wikimedia.org/T178930#3707338 (AndyRussG) [16:53:15] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Consolidate typical analytics queries (for example, for impression rates) into a library - https://phabricator.wikimedia.org/T178930#3707353 (AndyRussG) [16:53:41] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: [Epic] Analytics, graphs and monitoring for banners and CentralNotice - https://phabricator.wikimedia.org/T124132#1946773 (AndyRussG) [16:53:43] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Consolidate typical analytics queries (for example, for impression rates) into a library - https://phabricator.wikimedia.org/T178930#3707338 (AndyRussG) [16:56:33] mepps: thanks!! Just hoping for a check that the i's are crossed and the t's are dotted... Does the query have errors? Does it say what we think it does? Any possible issues that we may be missing? Basically the same kinda criticism we do in CR, just not git/gerrit-y [16:57:26] awight: woot! :D [16:57:35] Looks really cool [16:59:08] mepps: here's the doc for the Hive table the queries are on: https://wikitech.wikimedia.org/wiki/Analytics/Data_Lake/Traffic/Webrequest [16:59:25] how did pick the number 10 out of curiousity? [16:59:41] I imagine it's not easy to do this with stuff you're not able to access and fiddle with on your own, btw https://wikitech.wikimedia.org/wiki/Analytics/Data_Lake/Traffic/Webrequest [16:59:47] mepps: ah yes good question [17:01:28] It's somewhat arbitrary... Just that in the graph referenced in this commit https://phabricator.wikimedia.org/T176802#3697729 I bucketed clients by number of requests made with nocookies [17:01:33] Into buckets of multiples of 10 [17:01:59] ah okay that makes sense to me [17:02:32] I think a more detailed investigation might come up with a more exact cutoff point [17:03:51] But that bucket has a ton of clients but relatively few total requests. Looks most likely like legit requests, i.e. clients going to the site for the first time in a while, or with cookies turned off, or several similar clients behind the same IP address, that appear to us as a single client [17:05:32] (PS1) Ejegg: Fix contacts with multiple primary addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386228 (https://phabricator.wikimedia.org/T178819) [17:05:36] is this process easily reproducible in the future? [17:05:57] nuria had suggested >1 nocookie requests as the cutoff. That would probably give a similar result, this just bets a little more on the side of a bunch of nocookie responses still not being a bot [17:06:34] hmm maybe i'm confused [17:06:39] mepps: yes! really happy for nuria's suggestion there. I'd like us to integrate it into a library infact https://phabricator.wikimedia.org/T178930 [17:06:52] i thought nocookies>10 was the bots to delete from the data? [17:06:59] yes [17:07:14] but like you noticed it's kinda arbitrary. We don't really know that that's a good cutoff [17:07:15] but they're not the bots? [17:07:30] We can't always tell 'cause these are bots pretending they're nots [17:07:56] So the most telltale botness indication is that they keep coming back to the site but don't hold on to the cookies we set [17:07:59] great about the library plan! [17:08:32] Most repeat clients that just always have no cookies are almost surely bots [17:08:37] But there are cases when nots [17:08:44] okay so i think see what you're saying, you set the bar a litlte higher in case there are some non-bot users coming back 2x/3x [17:08:44] Such as someone with cookies off [17:08:51] yep [17:08:58] that makes sense to me [17:09:41] :) [17:10:08] i think overall this looks good especially with the library plan , do you need sign off from fr-online? Also maybe link that issue you showed me in this so that it's clear that's the next step? [17:10:31] Ah good idea! [17:11:11] Another case is many clients behind a single public IP address, that also happen to have the same UA and language [17:11:22] about to run out for lunch break but if there are others you want review on, can you send them my way [17:11:25] oh good point [17:11:35] mepps: thanks so much!!!!! :D [17:13:01] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Consolidate typical analytics queries (for example, for impression rates) into a library - https://phabricator.wikimedia.org/T178930#3707397 (AndyRussG) Here's the sort of situation where a library for this will come in handy: T177653 [17:20:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Add link to contact summary to assist in finding & deduping the contact - https://phabricator.wikimedia.org/T177999#3707418 (DStrine) [17:20:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Improve major gifts email links when a contact has already been merged so there is not a findy-game - https://phabricator.wikimedia.org/T178000#3707419 (DStrine) [17:20:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Make it easier to move from contact deleted by merge to the contact they were merged to - https://phabricator.wikimedia.org/T178003#3707420 (DStrine) [17:30:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Improve major gifts email links when a contact has already been merged so there is not a findy-game - https://phabricator.wikimedia.org/T178000#3677490 (Ejegg) Oh hey, links without contact ID seem to work just fine. Thi... [17:31:19] Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Email stats may be off (possible link to missing data in pgehres) - https://phabricator.wikimedia.org/T178819#3707454 (Ejegg) The multiple-primar... [17:41:22] Fundraising-Backlog: Paypal / Paypal EC issue in en6C? - https://phabricator.wikimedia.org/T178931#3707497 (spatton) [17:50:48] (PS6) Ejegg: Unit tests for Adyen multi-skin switching [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385483 [17:51:02] mepps want to cross-check that one ^^^ ? [17:51:49] oops, needs one more whitespace fix [17:52:18] (PS7) Ejegg: Unit tests for Adyen multi-skin switching [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385483 (https://phabricator.wikimedia.org/T176913) [17:52:26] Fundraising-Backlog: Paypal / Paypal EC issue in en6C? - https://phabricator.wikimedia.org/T178931#3707524 (DStrine) @Ppena and @MBeat33 as FYI [17:53:10] (PS1) Ejegg: Add processor_form to qqq.json [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386238 [17:53:13] (PS1) Ejegg: Don't require API read rights to report client-side errors [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386239 (https://phabricator.wikimedia.org/T121800) [17:53:14] (CR) Ejegg: [C: 2] Don't require API read rights to report client-side errors [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386239 (https://phabricator.wikimedia.org/T121800) (owner: Ejegg) [17:53:21] (CR) Ejegg: [C: 2] Add processor_form to qqq.json [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386238 (owner: Ejegg) [17:54:13] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/386240 [17:54:18] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/386240 (owner: Ejegg) [17:58:15] (CR) jerkins-bot: [V: -1] Add processor_form to qqq.json [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386238 (owner: Ejegg) [17:58:17] (CR) jerkins-bot: [V: -1] Don't require API read rights to report client-side errors [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386239 (https://phabricator.wikimedia.org/T121800) (owner: Ejegg) [17:59:50] oops, didn't need to cherry-pick the qqq patch [18:00:01] (Abandoned) Ejegg: Add processor_form to qqq.json [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386238 (owner: Ejegg) [18:00:25] (PS2) Ejegg: Don't require API read rights to report client-side errors [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386239 (https://phabricator.wikimedia.org/T121800) [18:00:54] Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Email stats may be off (possible link to missing data in pgehres) - https://phabricator.wikimedia.org/T178819#3707539 (CCogdill_WMF) Thanks so mu... [18:02:39] Fundraising-Backlog: Paypal / Paypal EC issue in en6C? - https://phabricator.wikimedia.org/T178931#3707547 (Pcoombe) We've not had any outage notifications from PayPal. I just tried and was able to make a donation via PayPal EC, but haven't received a TY email yet. [18:05:50] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/386240 (owner: Ejegg) [18:09:00] Fundraising-Backlog: Paypal / Paypal EC issue in en6C? - https://phabricator.wikimedia.org/T178931#3707579 (DStrine) from @spatton in IRC I see approx. 8000 clicks on paypal but zero completed donations [18:13:58] (PS2) Ejegg: blacklist polyfill-php54, update donation-interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384896 [18:14:28] (CR) Ejegg: [C: 2] blacklist polyfill-php54, update donation-interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384896 (owner: Ejegg) [18:14:55] mepps I'm going to deploy that one in the hopes we can push some of those paypal_ec payments through with the orphan rectifier [18:19:04] (Merged) jenkins-bot: blacklist polyfill-php54, update donation-interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/384896 (owner: Ejegg) [18:19:06] (PS1) Ejegg: blacklist polyfill-php54, update donation-interface [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/386245 [18:20:14] (PS1) Ejegg: Update DonationInterface lib [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386246 [18:20:19] (CR) Mepps: [C: 2] Unit tests for Adyen multi-skin switching [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385483 (https://phabricator.wikimedia.org/T176913) (owner: Ejegg) [18:20:21] (CR) Ejegg: [C: 2] Update DonationInterface lib [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386246 (owner: Ejegg) [18:20:23] (CR) jerkins-bot: [V: -1] Update DonationInterface lib [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386246 (owner: Ejegg) [18:20:28] (CR) jerkins-bot: [V: -1] Update DonationInterface lib [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386246 (owner: Ejegg) [18:22:09] (PS2) Ejegg: Update DonationInterface lib [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386246 [18:22:16] (CR) Ejegg: [C: 2] Update DonationInterface lib [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386246 (owner: Ejegg) [18:22:37] (PS2) Ejegg: blacklist polyfill-php54, update donation-interface [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/386245 [18:22:48] (CR) Ejegg: [C: 2] blacklist polyfill-php54, update donation-interface [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/386245 (owner: Ejegg) [18:24:25] (Merged) jenkins-bot: Unit tests for Adyen multi-skin switching [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/385483 (https://phabricator.wikimedia.org/T176913) (owner: Ejegg) [18:27:56] (Merged) jenkins-bot: Update DonationInterface lib [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386246 (owner: Ejegg) [18:27:58] (Merged) jenkins-bot: blacklist polyfill-php54, update donation-interface [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/386245 (owner: Ejegg) [18:37:14] (PS1) Ejegg: Revert "Handle payment not initiated" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386248 [18:37:53] (PS2) Mepps: Revert "Handle payment not initiated" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386248 (owner: Ejegg) [18:38:03] (CR) Mepps: [C: 2] Revert "Handle payment not initiated" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386248 (owner: Ejegg) [18:39:37] (PS1) Ejegg: Skeezy donation-interface update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386249 [18:39:46] (CR) Ejegg: [C: 2] Skeezy donation-interface update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386249 (owner: Ejegg) [18:40:08] (PS1) Ejegg: Quickfix vendor update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/386250 [18:40:12] (CR) Ejegg: [C: 2] Quickfix vendor update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/386250 (owner: Ejegg) [18:45:45] (CR) Ejegg: [V: 2 C: 2] Quickfix vendor update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/386250 (owner: Ejegg) [18:47:00] !log updated civicrm from b9d2067671dd68e1c3466863ffd10ab2748c7eaf to 18edce1c58d5f71e7a8eed6ec18724fef834859e [18:47:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:49:28] (Merged) jenkins-bot: Revert "Handle payment not initiated" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386248 (owner: Ejegg) [18:51:22] MediaWiki-extensions-FundraisingChart, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingChart extension - https://phabricator.wikimedia.org/T178762#3707783 (Umherirrender) [19:04:10] please see https://phabricator.wikimedia.org/T178940, I filed it as UBN [19:31:35] (PS1) Mepps: Revert "Handle payment not initiated" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386256 [19:34:19] Engage secret IRC override: fr-tech ^ [19:35:02] fr-tech are we meeting? [19:35:12] mepps: Yea [19:35:25] mepps it's a different hangout [19:35:30] riiight [19:35:36] haha [19:35:45] It's like the only meeting that isn't in that normal hangout [19:45:10] PROBLEM - check_disk on americium is CRITICAL: DISK CRITICAL - free space: / 0 MB (0% inode=95%): /sys/fs/cgroup 0 MB (100% inode=99%): /dev 32184 MB (99% inode=99%): /run 6438 MB (99% inode=99%): /run/lock 5 MB (100% inode=99%): /run/shm 32196 MB (100% inode=99%): /run/user 100 MB (100% inode=99%): /srv 1490865 MB (32% inode=99%) [19:45:35] (CR) Ejegg: [C: -1] "Weird, this doesn't look like it reverts the whole thing" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386256 (owner: Mepps) [19:47:29] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Registering test in... - https://phabricator.wikimedia.org/T176334#3707931 [19:50:10] RECOVERY - check_disk on americium is OK: DISK OK - free space: / 29671 MB (83% inode=96%): /sys/fs/cgroup 0 MB (100% inode=99%): /dev 32184 MB (99% inode=99%): /run 6438 MB (99% inode=99%): /run/lock 5 MB (100% inode=99%): /run/shm 32196 MB (100% inode=99%): /run/user 100 MB (100% inode=99%): /srv 1479242 MB (31% inode=99%) [19:50:12] thanks legoktm , we'll get to that asap [19:51:59] (CR) Mepps: "Locally I'm seeing some weird merge conflicts but none of this seems to even have to do with this original change." [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386256 (owner: Mepps) [19:53:28] (PS2) Mepps: Revert "Handle payment not initiated" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386256 [19:53:38] legoktm: thanks! [19:54:11] (CR) Mepps: "This is what's showing up locally when I cherry-pick this commit" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386256 (owner: Mepps) [19:58:26] Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Overlong gateway_txn_id made it to QC - https://phabricator.wikimedia.org/T178086#3707966 (XenoRyet) Open>Resolved [20:03:52] Fundraising-Backlog, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-FundraiserLandingPage: ContributionTracking and FundraiserLandingPage both set the same config variables - https://phabricator.wikimedia.org/T178940#3707988 (DStrine) [20:04:48] Fundraising-Backlog: Paypal / Paypal EC issue in en6C? - https://phabricator.wikimedia.org/T178931#3707990 (DStrine) p:Triage>Unbreak! [20:07:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Separate 'donations' and 'drupal' db connection strings mean txn overhead - https://phabricator.wikimedia.org/T178639#3698403 (DStrine) [20:14:54] Fundraising-Backlog: Civi: create unsubscribe email address for 90 days option - https://phabricator.wikimedia.org/T178948#3708039 (MBeat33) [20:15:28] (PS3) Mepps: Revert "Handle payment not initiated" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386256 [20:15:45] (CR) Mepps: "ejegg got it this time" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386256 (owner: Mepps) [20:16:09] Fundraising-Backlog: Ask GlobalCollect to let us cancel status 600 transactions - https://phabricator.wikimedia.org/T114205#3708068 (DStrine) Our previous tests from their recommendations didn't actually cancel these. This is probably going to be a back and forth conversation with them [20:19:05] (CR) Ejegg: [C: 2] Revert "Handle payment not initiated" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386256 (owner: Mepps) [20:21:07] Fundraising Sprint U 2017, Fundraising-Backlog, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-FundraiserLandingPage: ContributionTracking and FundraiserLandingPage both set the same config variables - https://phabricator.wikimedia.org/T178940#3708088 (DStrine) [20:21:09] Fundraising Sprint U 2017, Fundraising-Backlog: Paypal / Paypal EC issue in en6C? - https://phabricator.wikimedia.org/T178931#3708089 (DStrine) [20:21:11] Fundraising Sprint U 2017, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Consolidate typical analytics queries (for example, for impression rates) into a library - https://phabricator.wikimedia.org/T178930#3708090 (DStrine) [20:21:14] Fundraising Sprint U 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Separate 'donations' and 'drupal' db connection strings mean txn overhead - https://phabricator.wikimedia.org/T178639#3708092 (DStrine) [20:21:16] Fundraising Sprint U 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Email stats may be off (possible link to missing data in pgehres) - https://phabricator.wikimedia.org/T178819#3708091... [20:21:18] Fundraising Sprint U 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, fundraising-tech-ops, and 2 others: Eliminate creating of temp tables from Omnimailing.load task - https://phabricator.wikimedia.org/T178020#3708094 (DStrine) [20:21:20] Fundraising Sprint Synchronized Screaming, Fundraising Sprint U 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, and 3 others: Update librdkafka on banner log boxen - https://phabricator.wikimedia.org/T178432#3708093 (DStrine) [20:21:22] Fundraising Sprint U 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Improve major gifts email links when a contact has already been merged so there is not a findy-game - https://phabricator.wikimedia.org/T178000#3708097 (DStrine) [20:21:24] Fundraising Sprint U 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Make it easier to move from contact deleted by merge to the contact they were merged to - https://phabricator.wikimedia.org/T178003#3708096 (DStrine) [20:21:26] Fundraising Sprint Synchronized Screaming, Fundraising Sprint U 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, and 2 others: Back-fill missing pgehres data - https://phabricator.wikimedia.org/T178009#3708095 (DStrine) [20:21:28] Fundraising Sprint U 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Add link to contact summary to assist in finding & deduping the contact - https://phabricator.wikimedia.org/T177999#3708098 (DStrine) [20:21:30] Fundraising Sprint U 2017, Fundraising-Backlog, FR-Adyen, FR-Smashpig: Adyen jobs should retry at least once on connect failure - https://phabricator.wikimedia.org/T177893#3708099 (DStrine) [20:21:32] Fundraising Sprint U 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Implement concept of 'load' action to dedupe (&... - https://phabricator.wikimedia.org/T177882#3708100 [20:21:34] Fundraising Sprint U 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review: New thank you email for big english 2017 - https://phabricator.wikimedia.org/T177878#3708101 (DStrine) [20:21:36] Fundraising Sprint U 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review: Still an issue in merge screen display -not showing all contacts after UI batch merge dedupe - https://phabricator.wikimedia.org/T177873#3708102... [20:21:38] Fundraising Sprint U 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Epic: Don't duplicate contact for email donations - https://phabricator.wikimedia.org/T177663#3708104 (DStrine) [20:21:41] Fundraising Sprint Synchronized Screaming, Fundraising Sprint U 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, and 3 others: Improve conflict handling by doing postal-suffix only ... - https://phabricator.wikimedia.org/T177807#3708103 [20:21:43] Fundraising Sprint U 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review: Move tracking of silverpop out of settings table - https://phabricator.wikimedia.org/T177451#3708105 (DStrine) [20:21:45] Fundraising Sprint Synchronized Screaming, Fundraising Sprint U 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: donatewiki_counts and banner impressions ... - https://phabricator.wikimedia.org/T177331#3708106 [20:21:47] Fundraising Sprint Synchronized Screaming, Fundraising Sprint U 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Validation not clearing ... - https://phabricator.wikimedia.org/T176501#3708110 [20:21:50] Fundraising Sprint U 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, Patch-For-Review: Generic orphan rectifier needs to handle contribution tracking - https://phabricator.wikimedia.org/T176376#3708111 (DStrine) [20:21:53] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint U 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, and 2 others: Registering test in impressions - https://phabricator.wikimedia.org/T176334#3708112 (DSt... [20:21:56] Fundraising Sprint Synchronized Screaming, Fundraising Sprint U 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, and 3 others: adyen cookie error after entering information on Safar... - https://phabricator.wikimedia.org/T176913#3708109 [20:21:58] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint U 2017, and 6 others: CN Campaign Suppression prior to scheduled start time - https://phabricator.wikimedia.org/T175358#3708114 (DStrine) [20:22:01] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint U 2017, and 4 others: Create lists of CiviCRM groups to allow MG & DS to review with a view to tidy up - https://phabricator.wikimedia.org/T174407#3708115 (DStrine) [20:22:03] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint U 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, and 3 others: CiviCRM dedupe jobs should gracefully t... - https://phabricator.wikimedia.org/T172303#3708117 [20:22:05] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint U 2017, and 5 others: Investigate email: BH data storage/transfer issue for iPad donations - https://phabricator.wikimedia.org/T174719#3708116 (DStrine) [20:22:08] Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, and 9 others: Create orphan rectifier for PayPal Express Checkout - https://phabricator.wikimedia.org/T172202#3708118 (DStrine) [20:22:11] Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, and 7 others: Populate country column when creating c_t rows during offline import - https://phabricator.wikimedia.org/T171658#3708119 (DStrine) [20:36:12] Fundraising-Backlog, fundraising-tech-ops: Overhaul /srv/br - https://phabricator.wikimedia.org/T178953#3708168 (cwdent) [20:40:34] ejegg i'm going to bike home now but will be back super soon [20:42:16] ok, cool [20:46:19] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/386269 [20:47:52] jgleeson: want to meet for a few min? [20:48:09] I'll pop into the queenmary chat [20:48:39] sure [20:59:38] Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: donatewiki_counts and banner impre... - https://phabricator.wikimedia.org/T177331#3708223 [20:59:41] Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, and 3 others: Update librdkafka on banner log boxen - https://phabricator.wikimedia.org/T178432#3708220 (Jgree... [21:06:41] hey ejegg i'm back [21:06:55] hi mepps! [21:07:21] so, let's get that DonationInterface update out [21:07:23] i have another 20 minutes, should i start the deploy for the revertion? [21:07:25] cool :) [21:08:56] (CR) Ejegg: [V: 2 C: 2] Revert "Handle payment not initiated" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/386256 (owner: Mepps) [21:09:57] (Abandoned) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/386269 (owner: Ejegg) [21:10:55] (PS1) Mepps: Update DI with revertion of PaymentNotIntiated [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/386283 [21:11:24] (CR) Mepps: [C: 2] Update DI with revertion of PaymentNotIntiated [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/386283 (owner: Mepps) [21:15:06] (PS1) Ejegg: Debugging for orphan rectifier [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386289 [21:15:07] mepps I' [21:15:22] m messing with the vendor submodule some more to get debugging ^^^ [21:15:34] gotcha ejegg want me to +2? [21:15:55] eh, I was going to push it through myself [21:16:00] (CR) Ejegg: [C: 2] Debugging for orphan rectifier [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386289 (owner: Ejegg) [21:16:02] (Merged) jenkins-bot: Update DI with revertion of PaymentNotIntiated [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/386283 (owner: Mepps) [21:17:00] (PS1) Ejegg: Debugging for orphan rectifier [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/386291 [21:17:05] (CR) Ejegg: [C: 2] Debugging for orphan rectifier [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/386291 (owner: Ejegg) [21:19:19] !updated payments-wiki from 101143408f744b4bc053b12bea413769bb14d427 to b88b805c3b223404578c3ef8bb675e710611aa2d [21:21:09] oops [21:21:16] !log updated payments-wiki from 101143408f744b4bc053b12bea413769bb14d427 to b88b805c3b223404578c3ef8bb675e710611aa2d [21:21:23] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:21:23] heh [21:21:39] (Merged) jenkins-bot: Debugging for orphan rectifier [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386289 (owner: Ejegg) [21:21:39] the first message looks like i was just really excited about it :) [21:21:42] logs look fine so far [21:21:42] (Merged) jenkins-bot: Debugging for orphan rectifier [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/386291 (owner: Ejegg) [21:22:04] ok, I'll deploy the CRM bit and try running again [21:24:24] !log updated civicrm from 18edce1c58d5f71e7a8eed6ec18724fef834859e to 0546446640c8b7485c78b4f3836a38630248b44e [21:24:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:26:34] hmm, the requests look reasonable, and they have the TOKEN parameter [21:26:44] are they going to the wrong URL somehow? [21:27:07] is there a way to see the url ejegg? [21:27:17] Add more logging :) [21:35:45] (PS1) Ejegg: More debugging [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386302 [21:35:52] (CR) Ejegg: [C: 2] More debugging [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386302 (owner: Ejegg) [21:36:22] (PS1) Ejegg: More debugging for orphan rectifier [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/386303 [21:36:27] (CR) Ejegg: [C: 2] More debugging for orphan rectifier [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/386303 (owner: Ejegg) [21:42:54] Fundraising Sprint Uptight Piano, Fundraising-Backlog: Paypal / Paypal EC issue in en6C? - https://phabricator.wikimedia.org/T178931#3707497 (Ejegg) Sorry, this was a coding error on our side where we weren't making the final call to capture. We've deployed a fix for the the code on the payments site, bu... [21:44:14] mepps I can see some successful paypal EC transactions in the logs [21:45:25] (Merged) jenkins-bot: More debugging [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/386302 (owner: Ejegg) [21:45:27] (Merged) jenkins-bot: More debugging for orphan rectifier [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/386303 (owner: Ejegg) [21:45:46] ok, I'm going to relocate. back in 20 min-ish [22:45:01] Fundraising Sprint Uptight Piano, Fundraising-Backlog: Paypal / Paypal EC issue in en6C? - https://phabricator.wikimedia.org/T178931#3708440 (Ejegg) @MBeat33 So for almost a day, donors who tried to give via EC got all the way to the thank you page seemingly-successfully, but we never actually captured t... [22:53:21] Fundraising Sprint Uptight Piano, Fundraising-Backlog: Paypal / Paypal EC issue in en6C? - https://phabricator.wikimedia.org/T178931#3708460 (MBeat33) thanks @Ejegg do you know the number of affected donors? As this was larger than the set of donors during the one-hour test, I'd be game to reach out to... [22:54:56] !log updated civicrm from from 0546446640c8b7485c78b4f3836a38630248b44e to 25c7a33e3e3e9b8a5020d826982b3dbb64057614 [22:55:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log