[10:41:53] Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Email stats may be off (possible link to missing data in pg... - https://phabricator.wikimedia.org/T178819#3712066 [13:48:26] hey jgleeson! [13:48:33] hey hey :) [13:49:07] hows your day treating you so far mepps [13:49:28] it's not so bad except James woke me up early :( [13:50:23] ah sorry to hear that, hope he is okay. We had a difficult night with Oscar also, didn't get much sleep ~_~ [13:51:17] running on coffee as a result [13:51:59] haha yeah, that's essential [13:55:59] how's your day going? [13:56:54] AndyRussG is this something XenoRyet and I could collaborate on and help you with? might be good learning [13:56:55] https://phabricator.wikimedia.org/T178930 [13:58:12] it's good so far, I am working on adding some reporting output on the time difference between a donation being at wire level and it being saved into civi [13:59:38] wire level isn't accurate as we're not using mq, so a more accurate description would be when the donation hits the queue vs when it gets saved [14:00:54] to hopefully show how fast the throughput is during traffic peaks and troughs [14:03:28] ah nice! that will be useful [14:04:32] what you planned for today? [14:04:40] still battling paypal ? [14:06:30] well i don't want to test the orphan slayer until my patch above is merged, so currently reading some documentation and looking at the sprint board [14:07:26] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Make it easier to move from contact deleted by merge to the contact they were merged to - https://phabricator.wikimedia.org/T178003#3712360 (mepps) a:mepps [14:12:38] orphan slayer?? [14:17:03] Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Email stats may be off (possible link to missing data in pg... - https://phabricator.wikimedia.org/T178819#3712368 [14:18:48] jgleeson it's what i've been working on, it takes messages that have been left in the pending queue and finds out what happened to them [14:21:34] ah [14:40:23] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Make it easier to move from contact deleted by merge to the contact they were merged to - https://phabricator.wikimedia.org/T178003#3712415 (mepps) @Eileenmcnaughton @ejegg I'm wonde... [14:41:56] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Make it easier to move from contact deleted by merge to the contact they were merged to - https://phabricator.wikimedia.org/T178003#3712430 (mepps) However, when I merge in a clean c... [15:02:50] back in about 20 minutes, just gonna pick up a prescription for my son [15:14:36] hi mepps and jgleeson [15:15:47] heh, so you've met our most provocatively named component [15:16:00] (PS1) Mepps: With undelete true, make only one activity with new contact as assignee [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/386624 (https://phabricator.wikimedia.org/T178003) [15:17:14] wow, ejegg i can't believe this but i didn't even think of how that oculd be taken wrong [15:17:19] my head was too deep in [15:17:31] should i be renaming that? [15:18:48] hehe, no need [15:34:58] back [15:35:22] hey ejegg [15:35:33] hi jgleeson ! [15:35:36] strange my IRC shows [16:14:08] → ejegg|away is now known as ejegg [15:35:38] how's it going today? [15:35:44] but tab does ejegg|away [15:35:54] ^_^ [15:36:01] hmm, something's a bit buggy [15:36:11] yup, no doubt due my chromebook irc client [15:47:42] ejegg i think i could pick up this task: https://phabricator.wikimedia.org/T178000 but i don't know where the bot email gets generated [15:48:07] mepps it's in the large_donation module [15:48:20] go for it! [15:53:17] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Improve major gifts email links when a contact has already been merged so there is not a findy-game - https://phabricator.wikimedia.org/T178000#3712673 (mepps) a:mepps [15:53:19] Fundraising Sprint Uptight Piano, Fundraising-Backlog: Paypal / Paypal EC issue in en6C? - https://phabricator.wikimedia.org/T178931#3712674 (Ejegg) OK, the script finished last night, and rescued 5,747 of the 6,312 non-recurring donation attempts. The failed ones were mostly funding problems with the Pa... [16:03:29] (PS1) Ejegg: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386634 [16:16:37] (PS1) Mepps: Add link directly to contribution Need to test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386638 (https://phabricator.wikimedia.org/T178000) [16:18:33] (CR) jerkins-bot: [V: -1] Add link directly to contribution Need to test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386638 (https://phabricator.wikimedia.org/T178000) (owner: Mepps) [16:20:42] (PS2) Mepps: Add link directly to contribution Need to test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386638 (https://phabricator.wikimedia.org/T178000) [16:41:06] Fundraising-Backlog, fundraising-tech-ops: fundraising database replication lag master thread - https://phabricator.wikimedia.org/T173472#3712846 (cwdent) [16:41:10] Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, fundraising-tech-ops, and 2 others: Eliminate creating of temp tables from Omnimailing.load task - https://phabricator.wikimedia.org/T178020#3712844 (cwd... [16:46:25] mepps can you help me understand your merged contact link patch? [16:47:04] sure, ejegg, on hangouts or here? [16:47:06] So the new single activity will show up for both contacts? [16:47:35] yes ejegg because the new contact is the assignee while it belongs to the old contact [16:47:51] i tried perm deleting the old contact too and it still showed up [16:47:59] although, we could make the old contact the assignee [16:48:10] but that seems wrong to me somehow [16:48:23] hmm, seems like the 'stronger' link should be to the new contact [16:48:24] i'm open that that idea though [16:48:30] okay sure [16:49:20] (PS2) Mepps: With undelete true, make only one activity with new contact as assignee [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/386624 (https://phabricator.wikimedia.org/T178003) [16:49:22] ok, so what was the original reason for the different behavior with 'undelete' turned on? [16:49:56] ah, right, there's no need to make anything for the old contact if you're deleting them completely [16:49:59] nvm [16:50:11] thanks for the explanation! [16:51:15] mepps one other thing I was thinking would be cool, is a utility function under Merger or thereabouts [16:51:26] that would take a (merged/deleted) contact ID [16:51:48] and follow a potential chain of merges to get the active contact ID that they were merged into [16:52:53] hmm ejegg that seems outside the scope of this issue but something i could work on separately [16:53:11] how do you think that would be used ejegg? [16:53:59] an import or a link from email with contact_id [16:54:07] that's trying to add a new donation to an existing contact [16:58:51] gotcha [17:20:23] hmm so thikning about that makes me realize i should also do something to make the old data compatible which is trickier [17:29:24] hey ejegg, for my other patch, do you know why the View text isn't itself a link? [17:30:57] (PS3) Mepps: Add link directly to contribution Need to test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386638 (https://phabricator.wikimedia.org/T178000) [17:32:34] mepps no idea! [17:33:48] (PS4) Mepps: Add link directly to contribution Need to test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386638 (https://phabricator.wikimedia.org/T178000) [17:33:55] Maybe for ppl with text-only email readers? But I'd hope we're rendering the html format down to something compatible... [17:34:55] also, that module seems like it would be a great candidate for turning into a real civi extension! [17:35:45] hmm good point ejegg! [17:36:31] One of these days I really mean to learn that stuff [17:37:08] civix is a great headstart, just not sure how to build that settings form in angular and save the settings correctly [17:38:38] yeah just did some googling and there isn't anything like this [17:40:04] generally i think that notification email could be cleaned up--when was it first created ejegg? [17:40:13] before my time [17:40:32] (PS5) Mepps: Add link directly to contribution [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386638 (https://phabricator.wikimedia.org/T178000) [17:41:13] i'm kind of wondering if they care about getting the contact_id and contribution_id [17:41:20] versus the link to the contact [17:41:36] dstrine i guess i can ask that ^^ at ciiv fortnightly? [17:42:52] mepps I think they usually want to get to the contact record [17:43:04] yeah ejegg there's a link to the contact record [17:43:10] and now a link directly to the contirbution [17:43:20] seems like the best solution [17:43:22] and hten it lists out the contact_id and contribution _id [17:43:42] which i can leave for now, just thinking it clutters it up [17:44:10] Hmm, right, I think they generally don't care about those IDs unless they're manually making a link [17:44:23] and since you're giving them the link, it probably is redundant [17:45:20] mepps: which task are we talking about? the email T178000 or the already-merged-contact T178003 ? [17:45:25] T178003: Make it easier to move from contact deleted by merge to the contact they were merged to - https://phabricator.wikimedia.org/T178003 [17:45:26] T178000: Improve major gifts email links when a contact has already been merged so there is not a findy-game - https://phabricator.wikimedia.org/T178000 [17:45:28] the email dstrine [17:45:39] T187000 [17:48:35] When we watched Leanne click through on an email to a contact that had already been merged it's basically a dead end. you land in civi and have to search for the contact it got merged into. [17:49:11] you have to get a copy of an old email to really experience this [17:50:10] we want to reduce the number of clicks to get to the final, real contact [17:51:59] yeah ejegg i shadowed her too--so i'm adding a link to the contribution itself [17:52:19] and separately i changed how you get to the new contact from the deleted contact [17:52:38] but in the email itself it includes the data in plain text, like the contact_id and contribution_id [17:53:04] which seems unhelpful to me, but i want to make sure i'm not taking out something she uses! [17:53:08] oops, i meant dstrine! :) [17:53:11] sorry I forgot you were in that call. [17:53:23] haha i think i was in stealth mode :) [17:53:43] ok I think i'm on the same page then [17:53:50] I didn't catch all that in backscroll [17:54:58] I think the plain text in the email is ok as is. She just needs to glance at that. Most of her work is about getting to the accurate and final contact inside civi [17:55:28] There are still a decent amount of times where those email still lead to real, relevant contacts. [17:55:47] yeah we're leaving the link to the contact in [17:56:01] and then adding a link to the contribution below it [17:56:17] ok that sounds fine [17:56:35] this was more of a style thing with the email in general [17:59:29] (PS6) Mepps: Add link directly to contribution [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386638 (https://phabricator.wikimedia.org/T178000) [18:01:39] mepps: the email doesn't have to be amazing or anything. If you have a new version you can show, can you share a screen shot in phab or email? We don't want to put actual PII on a task if we can avoid it (and if we dowe should make it private. but seeing an intermediate version might help the conversation. [18:02:00] dowe =do [18:02:05] and we [18:02:24] yeah it will be with test data anyways [18:10:52] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Improve major gifts email links when a contact has already been merged so there is not a findy-game - https://phabricator.wikimedia.org/T178000#3713349 (mepps) {F10454296} This is w... [18:20:36] Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Email stats may be off (possible link to missing data in pg... - https://phabricator.wikimedia.org/T178819#3713367 [18:31:13] (PS1) Ejegg: WIP MergeTest detects double is_primary [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) [19:23:57] (PS2) Ejegg: WIP MergeTest detects double is_primary [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) [19:30:17] (CR) jerkins-bot: [V: -1] WIP MergeTest detects double is_primary [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg) [19:43:12] (PS3) Ejegg: WIP MergeTest detects double is_primary [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) [19:47:08] (CR) jerkins-bot: [V: -1] WIP MergeTest detects double is_primary [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg) [19:47:59] (PS4) Ejegg: Always delete 'worse' address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) [19:48:30] fr-tech ^^^ should fix an issue that's holding up CCogdill's email campaigns [19:48:55] Would be great if you had a chance to test locally [19:51:48] (CR) jerkins-bot: [V: -1] Always delete 'worse' address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg) [19:52:08] darn, why didn't that pass tests? [19:58:29] jgleeson: hello? [19:58:48] jgleeson: want to try meeting in the queenmary hangout? [20:00:33] wow ejegg, trying to recreate this bug has led me to a weird civi bug [20:00:44] that's not the same as the one you were solving [20:11:38] mepps oh? [20:11:41] what's that one? [20:11:58] so if you only put it a country in the address field it saves a new address [20:12:05] ...unless that country is the United States [20:12:05] right [20:12:12] whaaa [20:12:22] because US is the default country? [20:12:32] and if there is a previously saved address with only country [20:12:38] and you change it to US [20:12:44] it deletes the address... [20:12:50] i assume so [20:12:54] but that is problematic... [20:12:59] ooh, nasty! [20:14:51] yaaa [20:24:02] (PS1) Ejegg: Revert "Log a stack trace for all dedupe queries" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386706 [20:24:20] fr-tech just cleaning up some debugging we don't need any more ^^^ [20:24:59] (PS5) Ejegg: Always delete 'worse' address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) [20:30:00] 'Creating default object from empty value'??? [20:31:30] (CR) jerkins-bot: [V: -1] Always delete 'worse' address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg) [20:33:26] (PS6) Ejegg: Always delete 'worse' address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) [20:33:44] woah weird ejegg [20:33:51] what's that? [20:34:06] you're nick is fixed! [20:34:09] your* [20:34:17] so ejegg what is the actual bug--i had to deal with some issues to get there but i'm finally on the merge screen! [20:34:26] jgleeson: heh, your client caught up! [20:34:54] mepps the bug is that in certain circumstances the merged client ends up with two is_primary addresses [20:35:12] so should i not click the box to overwrite then? [20:35:26] ah, you need to do a batch merge [20:35:36] ah, that's part of the issue--i can't get there [20:35:42] that hook doesn't run for individual stuff [20:35:44] it won't find my dupe in the normal screen for some reason [20:36:00] it's finding other duplicates! just not the one i set up [20:36:03] mepps oh darn, even if you just use the 'email' rule? [20:36:09] yup ejegg [20:36:31] the email rule is only finding 'email@phony.com" for some reason [20:36:31] ah, I just edit whatever contacts the rule finds [20:36:39] okay will do [20:36:58] so, the lower-numbered contact should have a full address [20:37:15] the higher-numbered contact should have a newer donation, and an address that's just the country code [20:37:44] (assuming the higher-numbered contact is the one that will be merged in as a duplicate) [20:40:04] woohoo, passing tests! [20:42:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Can't link to a contact with no name in dedupe screen - https://phabricator.wikimedia.org/T179118#3713769 (mepps) [20:48:39] yay ejegg! unfortunately i'm having a lot of weird errors getting set up to test this [20:49:13] dang, anything that'd be helpful to walk through via screenchare? [20:49:50] no it's weird things that keep happing locally--and now i have to figure out if they're bugs [20:50:10] like the phab issue i created above--pretty sure that's a bug that needs fixing ^^ [20:50:21] might be stuff i've run into... [20:50:43] but i edited two contacts that were matching on the dedupe screen and made thier names easier to find [20:50:47] and they disappeared! [20:50:55] from dedupe i mean [20:50:59] so i couldn't batch update them :( [20:51:01] oh man [20:51:30] hmm, might have to do with how the dedupe uses caches? [20:52:13] So here's how I do it: do the dedupe search, then open each of the top pair for editing in new windows, leaving the search results up [20:52:36] err, opening them one at a time, saving, then closing the window before opening the next [20:52:43] to avoid that other bug [20:52:56] ah okay [20:54:08] hmm so i finally got it set up but i couldn't reproduce the bug [20:55:00] shoot, really? [20:55:03] maybe i need a contribution? are they both supposed to have contributions ejegg? [20:55:08] (CR) XenoRyet: [C: 2] Revert "Log a stack trace for all dedupe queries" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386706 (owner: Ejegg) [20:55:15] oh yeah, I think they both need contributions [20:55:17] i got confused by the phfrasing [20:55:18] okay [20:56:59] can i turn the caching off? [20:57:27] I don't think so [20:58:05] ah sigh [20:58:20] now it's not finidng any dupes even though i purposely didn't select them all for batch merge... [20:59:24] grr [20:59:30] try running unit tests a few times [20:59:48] sorry ejegg! time for baby time but i can keep working on this tomorrow morning [20:59:52] I think they still leave a bunch of Test Es around [20:59:56] thanks mepps! [21:00:55] (PS2) Ejegg: Fix contacts with multiple primary addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386228 (https://phabricator.wikimedia.org/T178819) [21:01:31] (Merged) jenkins-bot: Revert "Log a stack trace for all dedupe queries" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386706 (owner: Ejegg) [21:01:31] XenoReyt: want to go over this stuff in a video chat? Would be awesome to get this merged this week [21:01:40] I mean deployed [21:03:41] jgleeson: just thought of another interesting statistic: # of civicrm contacts merged [21:04:22] cool [21:04:42] might be worth setting a thread up somewhere with suggestions [21:05:01] or a phab ticket! [21:05:01] I'll create one tomorrow on phab [21:05:06] heh, nice [21:05:19] then each individual task can get a sub-ticket [21:05:29] and we can add suggestion with path-to-file:(line number) so I can find it :) [21:06:05] I'm already thinking about a slightly more agnostic prometheus metric reporter tool [21:06:18] oh hey, XenoRyet your nick is odd today. I just pinged your typo-ed doppelganger [21:06:38] jgleeson: cool, I'd love to hear your ideas [21:06:51] with a common interface similar to what we have at the moment, component|metric-type|name|value[s] [21:07:08] but I wanna see what libraries are available so I don't reinvent the wheel [21:07:24] so will read up on them tomorrow [21:07:39] I was just doing my audio note sign off [21:07:47] so I have a clue what I was doing today, tomorrow :) [21:11:10] I still need to create the phab ticket and gerrit branch today to start sharing this and get feedback, I will do that first thing tomorrow [21:11:22] discussed today** [21:11:47] ejegg: let me see if my local civi is even working. I seem to recall vagrant did something weird to it last time I did a destroy and provision. [21:12:18] jgleeson: cool! [21:12:38] XenoRyet: there's at least one patch you'll need forvagrant [21:12:54] https://gerrit.wikimedia.org/r/384891 [21:13:05] (also, do you have +2 in that repo?) [21:13:34] Yea, let me make sure I have that patch and try a reprovision. [21:13:43] Thanks! [21:13:44] And no, unfortunately I don't have +2 there. [21:14:06] ooh, There's another patch for the smashPig config: https://gerrit.wikimedia.org/r/386037 [21:14:52] Who does have +2 for vagrant? Would be nice to have those merged. [21:15:13] lesseenow [21:15:30] Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Email stats may be off (possible link to missing data in pg... - https://phabricator.wikimedia.org/T178819#3713828 [21:17:13] XenoRyet: oh hey, looks like I might have +2 there. LMK if the re-provision looks good and I'll self-merge [21:17:30] will do [21:19:17] (PS7) Ejegg: Add link directly to contribution [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386638 (https://phabricator.wikimedia.org/T178000) (owner: Mepps) [21:19:25] (CR) Ejegg: [C: 2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386638 (https://phabricator.wikimedia.org/T178000) (owner: Mepps) [21:23:16] (Merged) jenkins-bot: Add link directly to contribution [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386638 (https://phabricator.wikimedia.org/T178000) (owner: Mepps) [21:26:53] night all o/ [21:36:58] ejegg: I'm getting "could not find depenency file /etc/fundraising/SmashPig.yaml..." error [21:37:17] XenoRyet: oops, let me fix that [21:37:38] Did Jack run into that one? He just did this the other day, didn't he? [21:38:03] He had to fix that one manually, I wrote the patch after he set up [21:38:31] Ah, cool [21:39:32] XenoRyet: ok, just updated the patch [21:39:51] cool, trying it again. [21:46:17] (PS3) Ejegg: Fix contacts with multiple primary addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386228 (https://phabricator.wikimedia.org/T178819) [21:46:18] huh, didn't like that one either. [21:47:12] XenoRyet: what was the problem that time? [21:47:30] same error, just with mail.yaml this time. [21:47:38] argh, typo-ed! [21:47:48] sorry, should have been 'main.yaml' [21:48:00] oh, heh. I hate when typos end up in other real words. [21:48:25] ok, should be good for real this time [21:49:22] Well, it's getting further this time anyway. I'll let you know how it goes. [21:49:35] nice! [22:02:31] XenoRyet: I'mma relocate but I'll be back in half an hr [22:02:38] 10-4 [22:36:54] XenoRyet: how did it go that time? [22:37:27] Different errors. I'm in the middle of trying just starting from scratch. [22:40:52] ah, is it the mediawiki setup? I know that complains mightily when it tries to re-import the front page contents [22:43:04] No, it was something specific to civi. I've lost the backscroll now, but there was one error, then a bunch of failed dependencies. [22:46:00] At this point I'm doubting that I'll be able to test anything locally today, but I could look through some patches if you want. [22:51:29] XenoRyet: shoot, i can debug thru via screenshare [22:51:43] but are you leaving in 10 min? [22:52:26] Na, in an hour and 10. [22:52:44] It's right in the middle of a long provision though, I'll let it finish and see what's what after that. [22:53:16] ok, want me to walk you through the issue in the meantime? [22:53:22] Sure [22:53:28] queenmary chat? [22:53:33] brt [23:09:33] Seddon: Any chance you could help me with a banner translation issue? [23:09:54] kaldari: sure sir whats up? [23:13:54] Seddon: I cloned last year's Wishlist Survey banner to make a new one for this year.... [23:14:03] https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/2017WishlistSurvey [23:14:35] kaldari: Right... [23:14:47] One of the translatable messages needs to be changed in all the languages... [23:15:21] gotcha... [23:15:54] so is the best way to handle getting that retranslated to just create a totally new message key for it? [23:22:42] kaldari, depending on what the message is. Yes starting anew would be best [23:22:49] kaldari: when is this banner due to start? [23:42:46] Seddon: a couple weeks [23:44:40] Seddon: also is the "Preview all approved translations" feature broken? [23:46:21] kaldari: yep [23:49:04] Seddon: I forget, what's the way to preview the banner on a wiki? "?forcebanner=bannername" or something like that? [23:49:32] kaldari: you can click the little preview banner button at the top of the interface [23:49:51] awesom!