[12:43:17] hello all [13:23:43] Fundraising-Backlog: Prometheus: Add seconds diff metric report [donation message enqueued => donation saved to civi] - https://phabricator.wikimedia.org/T179173#3715702 (jgleeson) [13:30:12] Fundraising-Backlog: Prometheus Metric Suggestions - https://phabricator.wikimedia.org/T179179#3715791 (jgleeson) [13:34:02] Fundraising-Backlog: Prometheus: Add seconds diff metric report [donation message enqueued => donation saved to civi] - https://phabricator.wikimedia.org/T179173#3715834 (jgleeson) p:Triage>Normal [13:35:51] Fundraising Sprint Uptight Piano, Fundraising-Backlog: Prometheus: Add seconds diff metric report [donation message enqueued => donation saved to civi] - https://phabricator.wikimedia.org/T179173#3715702 (jgleeson) [13:38:46] Fundraising-Backlog: Metric: Donation Duplicates - https://phabricator.wikimedia.org/T179184#3715893 (jgleeson) [13:39:46] Fundraising-Backlog: Metric: Damaged Donations Message - https://phabricator.wikimedia.org/T179185#3715911 (jgleeson) [13:41:11] Fundraising-Backlog: Metric: Duplicate Donations - https://phabricator.wikimedia.org/T179184#3715928 (jgleeson) [14:33:23] hello jglesson! [14:36:12] hey there mepps :) [14:36:24] how goes it jgleeson? [14:36:32] good good, just reading up on gerrit [14:36:52] I figure it's time to get some feedback! :) [14:37:07] I've managed to create a few phab tickets [14:37:17] nice! [14:37:19] so now trying to link them up to branches [14:37:35] how about you? [14:37:50] so the way to link them is not through branches (for gerritt) [14:37:55] but through your commit message [14:38:16] add Bug: T12344 on the last line of your commit message [14:38:16] T12344: MW shouldn't redirect after protecting a redirect - https://phabricator.wikimedia.org/T12344 [14:38:16] ah I see [14:38:18] and it will connect [14:38:30] haha that was a sample number [14:38:38] :) [14:38:59] can we just on a call quickly so I can ask a few questions? [14:39:17] sure! [14:39:39] awesome, will call you now! [15:32:49] did you any of that mepps ? [15:32:53] I think I got disconnected [15:33:18] Any of what jgleeson? [15:33:42] ‹jgleeson› so mepps I think (hope) I've worked out my mic issues [15:33:48] ‹jgleeson› my usb to ethernet adaptor, that's hooked up to ethernet over power socket was going through another 4 way usb splitter. Once I plugged it in direct, the voice seems to have become more consistent [15:33:55] ‹jgleeson› chromebooks don't scale [15:34:08] I think I got disconnected and was talking to myself [15:35:04] ahh yeah that's happened to me [15:54:52] jgleeson: you still waiting on the work computer? [16:00:25] (PS1) AndyRussG: Add API to delay call to record impression [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 [16:00:57] (PS2) AndyRussG: Add API to delay call to record impression [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) [16:04:37] (CR) jerkins-bot: [V: -1] Add API to delay call to record impression [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) (owner: AndyRussG) [16:08:33] yes cwd [16:09:06] hopefully arrive soon [16:11:23] you'll have a lot more fun once you get some prod access :) [16:24:30] (CR) Mepps: "I still cannot reproduce this bug." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg) [16:25:24] Hmmm qunit tests need fixing on that patch... [16:58:49] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, and 3 others: Registering test in impressions - https://phabricator.wikimedia.org/T176334#3716446... [16:59:13] jgleeson mepps finally commented on the task with the example in-banner JS code ^ [17:04:53] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Improve major gifts email links when a contact has already been merged so there is not a findy-game - https://phabricator.wikimedia.org/T178000#3716471 (DStrine) @LeanneS as FYI [17:06:55] hey AndyRussG, code looks good to me. The Promise should hopefully give more confidence that it will be run correctly [18:18:02] (CR) AndyRussG: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319003 (https://phabricator.wikimedia.org/T121178) (owner: Ejegg) [18:19:55] (CR) jerkins-bot: [V: -1] Rename some impressionDiet variables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319003 (https://phabricator.wikimedia.org/T121178) (owner: Ejegg) [18:21:51] hi all! [18:28:56] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Upgrade to QUnit 2 - https://phabricator.wikimedia.org/T179198#3716673 (AndyRussG) [18:30:31] (CR) AndyRussG: "Test failures are because core now uses QUnit 2, and CentralNotice hasn't been upgraded yet. See T170515 and T179198. Thanks!!! :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) (owner: AndyRussG) [18:31:17] ejegg: hey! how's stuff? [18:31:42] fr-tech dstrine T179198, CN will now fail all CI until this [18:31:43] T179198: CentralNotice: Upgrade to QUnit 2 - https://phabricator.wikimedia.org/T179198 [18:31:58] da, da-da, da! [18:32:09] AndyRussG: I just saw. do you want to just pull that into the sprint? [18:32:38] hi AndyRussG ! [18:34:04] Things are pretty good. Had a smooth flight to Cusco and the neighborhood I'm staying in seems friendly [18:35:04] Found an internet cafe, might scout out libraries over the weekend [18:43:31] (CR) Ejegg: "Huh mepps, when I was showing it to XenoRyet last night it took me two tries to demonstrate it - there may be an additional factor." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg) [18:44:38] XenoRyet: how did things end up with Civi in vagrant? [18:48:17] (CR) Ejegg: "Ah, and it has to be in batch mode to even run our alterLocation hook" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg) [18:48:43] ejegg: ¡excelente! [18:48:58] dstrine-lunch: yeah, might as well [18:48:59] Might be reqlly quick [18:49:02] really [18:49:20] I could at least dive in briefly [18:49:36] jgleeson: thanks! [18:54:42] ejegg: Wasn't a clean provision, but I *think* civi came up ok. [18:55:07] Might be running into another known bug now, so I'm trying that workaround. [19:03:44] thanks XenoRyet. Sounds like those vagrant patches are merge-able [19:04:08] XenoRyet: is your current issue something with the unit tests needing to run 'cv' ? [19:04:34] XenoRyet: jgleeson ran into that one and had to make a wrapper script as a workaround [19:05:09] basically, normal usage is just running the cv phar package as 'cv' [19:05:12] the .phar extension issue [19:05:38] but for whatever reason, it won't run under vagrant unless renamed to 'cv.phar' [19:07:27] since we don't want to change our unit tests to accomodate that quirk, jgleeson renamed cv -> cv.phar and put a single-line shell script named 'cv' on his path that just passes its args to the phar [19:08:36] Na, though I'm sure I'll run in to that one in a minute. This one is that it wouldn't clone REL1_27 into mediawiki-fr, then a bunch of failed dependancies after that. I'm just pulling down the repo manually, see if that sorts it out. [19:08:46] hmm ejegg do you want to screenshare? [19:09:39] sure mepps, let's see how good this cafe's wifi is [19:10:28] (PS3) Mepps: With undelete true, make only one activity with new contact as assignee [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/386624 (https://phabricator.wikimedia.org/T178003) [19:11:22] cool i'm in the hangout [19:11:37] except i can't hear [19:11:38] you [19:11:44] which is why i didn't know you were there [19:12:12] rejoining [19:13:07] hey people, when modifying smash-pig, I am guessing we have a separate checkout as it's currently a vendor lib on the civi project...? [19:13:36] jgleeson: yep! [19:14:29] Project wikimedia/fundraising/crm/vendor [19:14:30] ? [19:14:39] is that the repo/project? [19:14:52] nope, one sec [19:15:02] https://gerrit.wikimedia.org/r/#/admin/projects/wikimedia/fundraising/SmashPig [19:15:14] great [19:15:16] thanks [19:17:59] Would you typically modifying the vendor library as part of the combined project/workijng copy for testing and apply separately the changes as a new branch on the specific vendor project? [19:18:14] when you're happy [19:19:25] ejegg our call froze for me [19:23:00] window [19:23:23] and that's how you type your desktop password into irc [19:23:31] ... [19:23:42] been there [19:27:42] i still remember the pw, it was rh1n0pl4sty [19:27:48] i was sad to lose it cause it's fun to type [19:27:51] Good old chrome multi profile, I can actually see my remote desktop window on my other gmail user session to my desktop downstairs while on my wikimedia session. it's like screen sharing between two user profiles, which would be great... if it was actually intended but it's not so ignores my input [19:28:53] so I think I am typing into my ubuntu password box when I'm typing in irc on the other monitor :) [19:29:15] that's a good password [19:33:09] mine was cause the monitor had gone to sleep and i assumed the screen lock was on, but it was not [19:33:20] lol [19:33:28] that's harsh [19:33:35] but easily done [19:34:02] live and learn [19:34:03] or something [19:38:49] https://www3.lenovo.com/us/en/laptops/thinkpad/thinkpad-t-series/ThinkPad-25/p/22TP2TTTP25 [19:41:01] hey AndyRussG I like those renaming of variables but it looks like we're still waiting on getting build working again? [19:41:36] oh wiat [19:41:43] i don't think that's the right patch [19:42:24] mepps: yeah I just triggered CI on that one to see if the issue wit h CI on the other patch was the QUnit update or something else [19:42:44] gotta run for a bit (kid pick-up + main lunch meal) back soon!! [19:42:49] cool [19:42:52] :) [19:51:42] (CR) Ejegg: [C: 1] "Looks good, could make test a little robust-er" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386537 (owner: Mepps) [19:53:10] (PS7) Mepps: Always delete 'worse' address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg) [19:53:14] (CR) Mepps: [C: 2] Always delete 'worse' address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg) [19:54:50] hehe, just reading the backscroll. I've definitely seen a password mistakenly IRC'ed by someone we know [19:56:20] :) [19:56:35] are you guys getting much coverage of what is going on in Catalonia where you are? [19:56:59] things are escalating really quick [19:57:04] (Merged) jenkins-bot: Always delete 'worse' address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386675 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg) [20:04:51] (CR) Mepps: Fix contacts with multiple primary addresses (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386228 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg) [20:08:31] (PS2) Mepps: Handle PaymentActionCompleted in batch mode [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386537 [20:11:59] hot damn cwd, that anniversary edition has a real ethernet port! [20:12:45] pretty boss huh? [20:13:24] expensive as hell but i guess all thinkpads are [20:14:06] i take that back, there are legions of crappy corporate fleet thinkpads [20:14:12] but the good ones have always been expensive [20:14:27] heh, I've been damn satisfied with mine [20:15:34] i think my last thinkpad was a T40 that i had for about 10 years [20:15:35] T40: Set up redirects from old bugzilla.wikimedia.org URLs - https://phabricator.wikimedia.org/T40 [20:15:45] thanks stashbot [20:16:20] haha, what's T24 ? [20:16:21] T24: Decide whether project reporting should be moved to Phabricator as well - https://phabricator.wikimedia.org/T24 [20:16:26] I think that was my model [20:16:35] that is one greedy regex [20:16:47] then I got a W520 not too long ago [20:17:04] what if i was talking about terminator 2 and i wanted to mention T1000 [20:17:05] T1000: Update Beta Cluster status documentation (re Q3 intradepartamental priority) - https://phabricator.wikimedia.org/T1000 [20:17:19] shoot, that's a totally capable machine going unused - I oughtta loan it to somebody [20:17:51] or a TIG welding exercise where we used T6 aluminum [20:17:51] T6: Get !log entries from #-operations into logstash - https://phabricator.wikimedia.org/T6 [20:18:07] Or T9 predictive text? [20:18:07] T9: Make a robot icon - https://phabricator.wikimedia.org/T9 [20:18:12] haha [20:18:22] nice [20:18:41] phew, glad to see that one's resolved [20:20:13] ejegg do we have any commands set up to clear queues ? [20:20:30] damn just missing you :) [20:20:30] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Improve major gifts email links when a contact has already been merged so there is not a findy-game - https://phabricator.wikimedia.org/T178000#3716888 (LeanneS) Love this change! It... [20:20:34] missed*** [20:23:10] there should be something in the SmashPig Maintenance folder [20:25:47] EmptyQueueToDump looks good [20:25:48] thanks [20:31:20] jgleeson: you can also use the redis command line tool [20:31:37] redis-cli [20:32:59] to show which queues have any contents at all, type [20:33:01] was guessing we've got some authentication going on [20:33:01] keys * [20:33:16] jgleeson: I think in vagrant it's set up without a password [20:33:20] lemme see [20:34:07] yeah you're right [20:34:11] thanks! [20:34:15] sure thing! [20:34:22] are you familiar with it already? [20:34:58] the other commands i end up using are [20:35:04] lrange donation 0 10 [20:35:13] yeah I've used redis, not hugely familiar but enough to get around it [20:35:21] ok, cool [20:35:45] it has so many commands [20:36:06] anyway, 'del donations' would be an easy way to get rid of the whole thing [20:36:18] the phpqueue backend treats a missing key like an empty queue [20:40:00] will that not cause any issues during the repopulating with the list not being present? [20:40:17] nope, it'll create the key on the first insert [20:41:27] great, just what I needed. Thanks [20:51:29] cwd hey, do you have things set up so building a new process-control package is less of a hassle? [20:52:32] yeah hopefully should be easier [20:52:42] cool! [20:52:48] i'd be hesitant to do it late on a friday :) [20:53:00] unless there is a compelling reason [20:53:04] Heh, yeah, definitely not saying we should deploy it now! [20:53:09] maybe monday [20:53:24] yeah shouldn't be a problem [20:53:39] I think I got the failspam (aborting...) thing sorted, so that would be cool [20:53:54] groovy [20:54:02] also, I might have the debian bit for adding the bash completion script [20:54:26] https://github.com/ejegg/process-control-debian/commit/cb6989dfacd0a167b41499523350c369c8521447 [20:54:55] though I haven't actually managed to build the package with that yet [20:55:43] oh hey, we've since added other options. fixing [21:02:36] gee, deleting two months worth of bad banner impression data sure takes a few minutes [21:02:49] oh hey, it finished as soon as I complained :) [21:05:15] hmm seems indiscriminately importing donations locally falls over when you rerun them with different data due to duplicates [21:05:33] jgleeson: ooh, yeah, that can happen [21:05:45] I guess I could just left trim a few [21:05:48] in redis-cli [21:06:03] sounds like the way to go [21:34:59] buying a sim card, back in a bit [22:05:16] I'm running away. Have a good weekend [22:28:58] ejegg when working across smashpig and civi on the same task is it enough to create branches in each respective checkout with the single phab task ID [22:33:54] jgleeson: so, you'd make one commit in the main smashpig repo [22:34:08] and one in the main crm repo [22:34:33] don't bother with the vendor repo just yet [22:35:12] instead, when the smashpig part merges to master, [22:35:26] we'll update the packagist listing [22:36:20] then in the crm commit you can update the smashpig version in composer.json and/or composer.lock [22:37:00] got it [22:37:03] (we're committing composer.lock because we still depend on dev-master versions of a couple packages) [22:38:19] I had fun earlier, I was editing the smashpig vendor checkout files but then running the *actual* smashpig /src/SmashPig checkout when trying to import messages, and wondering why the changes were not taking effect [22:38:40] two different locations :) [22:38:54] xdebug saves me from myself sometimes [22:39:42] - /srv/SmashPig* [22:42:13] oh man [22:42:59] yeah, sometims i just symlink one to the other, like when i'm doing that kind of cross-repo dev [22:43:11] although it feel like good learning, it's getting me looking over the code for unicorns [22:43:15] feels* [23:00:57] Awfully late British time... Have yourself a weekend! [23:02:43] Fundraising-Backlog: Track rate of new donations added to divicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3717061 (K4-713) [23:04:06] Fundraising-Backlog: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3717061 (K4-713) [23:06:00] Fundraising-Backlog: Track rate of new successful donations created at the payments cluster, in prometheus - https://phabricator.wikimedia.org/T179215#3717077 (K4-713) [23:15:54] :) ejegg my family fell asleep and tv is not too good so just chilling on the computer [23:17:17] heh, books? [23:19:01] still playing with Prometheus [23:19:18] books are good [23:19:24] but at 12:19am [23:19:36] not sure if I'd take much in [23:21:21] I do miss reading. I had a 1h30m commute each day when I used to work in the city that was useful for reading [23:26:28] hey, whatever floats your boat :) I agree, learning new tools is fun [23:28:08] Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, and 7 others: Populate country column when creating c_t rows during offline import - https://phabricator.wikimedia.org/T171658#3717112 (Ejegg) Open>Resol... [23:42:22] (CR) Ejegg: "looks great! Just going to refresh my memory on exactly how finalizing here stops the next txn from happening, then I'll merge it." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386537 (owner: Mepps) [23:48:24] (PS3) Ejegg: Handle PaymentActionCompleted in batch mode [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386537 (owner: Mepps) [23:49:03] (CR) Ejegg: [C: 2] "Oh look, it's super clear how that works. Nice!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386537 (owner: Mepps) [23:49:22] well, I'm heading out for the night. Have a great weekend all! [23:52:23] (Merged) jenkins-bot: Handle PaymentActionCompleted in batch mode [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/386537 (owner: Mepps)