[04:31:00] <wikibugs>	 (PS1) AndyRussG: Upgrade to QUnit 2 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/387162 (https://phabricator.wikimedia.org/T179198)
[04:31:33] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Upgrade to QUnit 2 - https://phabricator.wikimedia.org/T179198#3718518 (AndyRussG)
[04:33:23] <wikibugs>	 (CR) jerkins-bot: [V: -1] Upgrade to QUnit 2 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/387162 (https://phabricator.wikimedia.org/T179198) (owner: AndyRussG)
[04:36:46] <wikibugs>	 (CR) AndyRussG: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/387162 (https://phabricator.wikimedia.org/T179198) (owner: AndyRussG)
[04:40:05] <wikibugs>	 (CR) AndyRussG: "The change fixes usages of the old signature of QUnit.test(), which allowed the number of expected assertions as an optional argument. Now" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/387162 (https://phabricator.wikimedia.org/T179198) (owner: AndyRussG)
[04:41:02] <wikibugs>	 (CR) AndyRussG: "TODO: Investigate flapping test (see first CI result)." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/387162 (https://phabricator.wikimedia.org/T179198) (owner: AndyRussG)
[10:02:57] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner Editting History Integrated within CentralNotice - https://phabricator.wikimedia.org/T174787#3718767 (Liuxinyu970226)
[12:45:49] <mepps>	 morning jgleeson!
[12:59:25] <jgleeson>	 morning mepps :)
[12:59:28] <jgleeson>	 good weekend?
[12:59:35] <mepps>	 pretty good!
[12:59:58] <mepps>	 i'll have to share pictures of james in his elephant costume in standup :)
[13:00:36] <mepps>	 how about you?
[13:01:10] <jgleeson>	 lol awesome!!! we took Oscar pumpkin picking on a local farm over the weekend, that was good fun and all kinds of muddy :)
[13:03:14] <mepps>	 aww fun!
[13:07:18] <mepps>	 did you sleep better last night? James slept in until 7:45 this morning!
[13:15:47] <jgleeson>	 I got 6 hours, which is about the minimum I need to function properly. He is recovering now so we are hoping that as his illness diminishes he'll be more settled during the night, and we can all sleep :)
[13:30:17] <mepps>	 fingers crossed!
[13:53:35] <jgleeson>	 mepps can I get your view on something on hangouts? I'm at the point of needing a second opinion
[13:57:02] <mepps>	 sure jgleeson! let's meet in the usual hangout for meetings
[13:57:35] <mepps>	 i'm in there now
[14:22:16] <wikibugs>	 fundraising-tech-ops, Operations, netops, ops-eqiad: rack/setup/wire/deploy msw2-c1-eqiad - https://phabricator.wikimedia.org/T166171#3719635 (Cmjohnson) Open>Resolved Completed.
[15:54:10] <wikibugs>	 (PS1) Jgleeson: add inital StatsCollector stub class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387244
[15:54:12] <wikibugs>	 (PS1) Jgleeson: Added documentaton to WIP Statistics Collector object and added stubs for its dependencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387245
[15:57:32] <jgleeson>	 mepps, I've added some updates to my thoughts on the proposed Stats Collector component. Would be glad to hear your feedback so far https://gerrit.wikimedia.org/r/#/c/387245/1/sites/all/modules/metrics_reporting/Statistics/Collector.php
[15:58:30] <jgleeson>	 part of: https://gerrit.wikimedia.org/r/#/c/387245/
[15:58:40] <wikibugs>	 (CR) jerkins-bot: [V: -1] Added documentaton to WIP Statistics Collector object and added stubs for its dependencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387245 (owner: Jgleeson)
[16:01:57] <wikibugs>	 (CR) jerkins-bot: [V: -1] add inital StatsCollector stub class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387244 (owner: Jgleeson)
[16:31:23] <mepps>	 jgleeson what's the idea behind the instances array if you're not going to specify instances for different components?
[16:33:57] <jgleeson>	 does the comment above the getInstance() method help answer that?
[16:36:26] <jgleeson>	 mepps currently I'm playing with setting a default component namespace, removing the requirement to specify one in other methods
[16:37:47] <jgleeson>	 so the api would look like: $Collector->setNS("component.count")->incrementStat()
[16:54:05] <mepps>	 hmm jgleeson, maybe after the fr-online standup we can talk about it?
[16:54:11] <jgleeson>	 sure
[17:13:51] <wikibugs>	 (PS4) Mepps: When undelete is true, add new contact as assignee for merged contact activity record [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/386624 (https://phabricator.wikimedia.org/T178003)
[17:28:22] <ejegg>	 hi fr-tech!
[17:28:29] <mepps>	 hi ejegg!
[17:28:34] <jgleeson>	 hey ejegg o/
[17:28:38] <ejegg>	 jgleeson i'm in a silent room at a library so I can't vidchat right now
[17:28:48] <jgleeson>	 np
[17:29:03] <ejegg>	 but if you want to walk me through the code in textmode I'm available for that
[17:29:28] <jgleeson>	 sure I'll message you now
[17:31:05] <ejegg>	 also, if anyone has time to review this data fix for the contacts with multiple primary addresses, I'd love to run it today: https://gerrit.wikimedia.org/r/386228
[17:34:36] <wikibugs>	 (PS1) Jgleeson: added some minor updates around namespace container getters and setters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387300
[17:39:07] <wikibugs>	 (CR) jerkins-bot: [V: -1] added some minor updates around namespace container getters and setters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387300 (owner: Jgleeson)
[17:40:21] <wikibugs>	 (CR) XenoRyet: [C: 1] "Agree with Mepps.  Looks good functionally but would be more readable with a better name for 'bestAddress'.  Maybe alternateAddress or com" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386228 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg)
[17:40:35] <jgleeson>	 Hey ft-tech, I've added you all as reviewers to my work-in-progress branch for a potential new statistics collector component. Full discourse...as it stands now, it will no doubt not work, but I am sharing it to get early feedback on the overall approach
[17:42:26] <jgleeson>	 the current code is proposal only, so feel free to suggest changes / improvements as you see them. You will be way more familiar with the stack than me so I will definitely consider any ideas you have
[17:42:40] <wikibugs>	 (CR) Ejegg: "mepps / XenoRyet: the var is 'bestAddress' because it's the best we have so far. Would it be better to rename the loop variable 'potential" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386228 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg)
[17:44:29] <jgleeson>	 fr-tech***
[17:48:57] <wikibugs>	 Fundraising-Backlog, FR-Paypal, FR-Smashpig: Paypal-jobs entry missing php-message-class - https://phabricator.wikimedia.org/T179318#3720416 (Ejegg)
[17:54:58] <wikibugs>	 (CR) Ejegg: [C: 2] "Looks good to me! A couple places don't have the new assert.expect() but it doesn't look super-necessary there." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/387162 (https://phabricator.wikimedia.org/T179198) (owner: AndyRussG)
[17:56:58] <wikibugs>	 (CR) XenoRyet: [C: 2] "Oh, oh!  Yea, I wasn't looking at it that way.  I get it now, and bestAddress makes sense." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386228 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg)
[17:57:23] <ejegg>	 thanks XenoRyet1 !
[17:59:09] <XenoRyet1>	 Yea, no worries.  I was just thinking too much about the first comparison, and not the subsequent ones.
[17:59:23] <wikibugs>	 (PS4) Ejegg: Fix contacts with multiple primary addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386228 (https://phabricator.wikimedia.org/T178819)
[17:59:25] <wikibugs>	 (PS2) Ejegg: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386634
[17:59:30] <wikibugs>	 (Merged) jenkins-bot: Upgrade to QUnit 2 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/387162 (https://phabricator.wikimedia.org/T179198) (owner: AndyRussG)
[18:01:03] <ejegg>	 d'oh, that rebase is gonna confuse zuul
[18:02:47] <XenoRyet1>	 Doesn't look like zuul has it in the gate-and-submit queue.  Just reapply the +2 should sort it out, yea?
[18:02:57] <ejegg>	 I think so. Thanks!
[18:07:38] <wikibugs>	 (CR) XenoRyet: Fix contacts with multiple primary addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386228 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg)
[18:07:42] <wikibugs>	 (CR) XenoRyet: [C: 2] Fix contacts with multiple primary addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386228 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg)
[18:10:09] <wikibugs>	 (PS1) Mepps: WIP Script to update old activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003)
[18:10:17] <wikibugs>	 (CR) jerkins-bot: [V: -1] WIP Script to update old activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003) (owner: Mepps)
[18:12:15] <wikibugs>	 (PS2) Mepps: WIP Script to update old activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003)
[18:12:27] <wikibugs>	 (PS1) Jgleeson: added initial implementation of methods to bring design to life [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387312
[18:13:21] <mepps>	 ejegg after doing some historical research, i changed my approach on the activities after merge patch ^
[18:14:02] <wikibugs>	 (Merged) jenkins-bot: Fix contacts with multiple primary addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386228 (https://phabricator.wikimedia.org/T178819) (owner: Ejegg)
[18:16:38] <wikibugs>	 (CR) jerkins-bot: [V: -1] WIP Script to update old activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003) (owner: Mepps)
[18:18:00] <ejegg>	 mepps oh? Will take a look
[18:18:10] <cwd>	 running an errand, back soon!
[18:19:52] <wikibugs>	 (PS1) Jgleeson: fixed some obvious wiring up problems / added exceptions to phase two behaviour [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387319
[18:20:31] <ejegg>	 hmm, actually, going to get a bite to eat. back soon!
[18:21:13] <wikibugs>	 (CR) jerkins-bot: [V: -1] added initial implementation of methods to bring design to life [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387312 (owner: Jgleeson)
[18:23:17] <jgleeson>	  hey ejegg|food, the Statistics Collector class is now fully pseudo'd and pushed https://gerrit.wikimedia.org/r/#/c/387319/1, I am gonna grab some food myself now :) so catch up with you when we're both back
[18:30:51] <wikibugs>	 (CR) jerkins-bot: [V: -1] fixed some obvious wiring up problems / added exceptions to phase two behaviour [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387319 (owner: Jgleeson)
[18:53:31] <wikibugs>	 Fundraising-Backlog, Epic: EPIC: Prometheus Metric Suggestions - https://phabricator.wikimedia.org/T179179#3720636 (DStrine)
[19:16:53] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Overhaul /srv/br - https://phabricator.wikimedia.org/T178953#3720729 (CCogdill_WMF) I don't have a great answer to your question, only that I basically only run a version of the same query when in this folder:  ./ecom -s 20170701000000 -e 20171031000000 --substr...
[19:24:56] <wikibugs>	 (PS1) Jgleeson: Added exception for is_incrementable() failure / updated docblocks [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387346
[19:30:26] <wikibugs>	 (PS1) Jgleeson: clean up is_incrementable() arguements and docbloc [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387347
[19:34:42] <dstrine>	 ejegg|food:  mepps  AndyRussG|afk meeting?
[19:39:58] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising-Backlog: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3717061 (DStrine)
[19:40:34] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Can't link to a contact with no name in dedupe screen - https://phabricator.wikimedia.org/T179118#3720856 (DStrine)
[19:43:36] <wikibugs>	 (CR) jerkins-bot: [V: -1] Added exception for is_incrementable() failure / updated docblocks [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387346 (owner: Jgleeson)
[19:43:41] <wikibugs>	 (CR) jerkins-bot: [V: -1] clean up is_incrementable() arguements and docbloc [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387347 (owner: Jgleeson)
[19:43:48] <wikibugs>	 Fundraising-Backlog: Civi: create unsubscribe email address for 90 days option - https://phabricator.wikimedia.org/T178948#3720862 (DStrine)
[19:51:23] <wikibugs>	 Fundraising-Backlog: Civi: create unsubscribe email address for 90 days option - https://phabricator.wikimedia.org/T178948#3708039 (Ejegg) Sounds like a nice feature! FR-tech just chatted briefly about this. So we're thinking a contact custom field in Civi 'Emails paused until'. That would be pretty easy to...
[19:54:45] <wikibugs>	 (CR) Eileen: "I think there is much more misery ahead on this :-) There will be too many to do in one pass so this will need to be a long running job. N" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003) (owner: Mepps)
[20:01:07] <wikibugs>	 (PS1) Jgleeson: Rename componentNS property to StatsNS as component doesn't really fit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387351
[20:05:29] <ejegg>	 cwd / Jeff_Green anything you'd like to discuss live with fr-tech?
[20:05:53] <XenoRyet>	 Heh, I was just about to ask the same thing.
[20:06:29] <Jeff_Green>	 ejegg: nope!
[20:07:11] <cwd>	 nothing i can think of
[20:07:36] <cwd>	 i'm going to have a lot of questions about /srv/br
[20:07:41] <cwd>	 but i'm still developing them
[20:08:41] <wikibugs>	 (CR) jerkins-bot: [V: -1] Rename componentNS property to StatsNS as component doesn't really fit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387351 (owner: Jgleeson)
[20:22:23] <wikibugs>	 (PS1) Eileen: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387360
[20:23:01] <wikibugs>	 (CR) Eileen: [C: 2] Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387360 (owner: Eileen)
[20:26:44] <wikibugs>	 (Merged) jenkins-bot: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387360 (owner: Eileen)
[20:30:29] <wikibugs>	 (CR) Jforrester: [C: 2] Remove i18n php shim [extensions/ContributionReporting] - https://gerrit.wikimedia.org/r/387003 (https://phabricator.wikimedia.org/T168353) (owner: Umherirrender)
[20:31:58] <wikibugs>	 fundraising-tech-ops, Operations, netops, ops-codfw: connect second ethernet interface for fundraising codfw hosts - https://phabricator.wikimedia.org/T176175#3720997 (ayounsi) Switch ports activated, some interfaces still show as down, most likely not activated on the server side: ``` ge-0/0/3...
[20:35:31] <wikibugs>	 (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/387365
[20:35:52] <eileen1>	 ejegg: ^^ = deployment commit
[20:36:06] <ejegg>	 eileen1: ah, thanks!
[20:36:34] <ejegg>	 the updb will likely take at least an hour
[20:36:34] <eileen1>	 It all looks pretty familiar - excited you got that php54 file out of composer
[20:36:48] <eileen1>	 ejegg: which is the slow one
[20:36:56] <eileen1>	 the primary email fix?
[20:37:00] <ejegg>	 yep!
[20:37:10] <ejegg>	 well, this one is mailing addresses
[20:37:11] <eileen1>	 ok - do we need to warn Jeff_Green & cwd ?
[20:37:20] <ejegg>	 I don't think so, it's not one big txn
[20:37:23] <wikibugs>	 (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/387365 (owner: Eileen)
[20:37:36] <ejegg>	 eh, no harm in a heads-up
[20:37:52] <eileen1>	 ok - I'll deploy now - looks like you will be talking to K4-713
[20:38:00] <ejegg>	 it'll update about 100k contacts, deleting almost that many addresses
[20:38:21] <eileen1>	 & that is just because of a short-lived bug?
[20:38:25] <ejegg>	 cwd / Jeff_Green maintenance script about to run, updating contacts one at a time
[20:38:28] <ejegg>	 eileen1: yep
[20:38:31] <eileen1>	 wow
[20:38:45] <ejegg>	 there were a lot of pent up merges!
[20:38:51] <eileen1>	 lol
[20:39:38] <eileen1>	 I will try the log_settings delete but I suspect I will wind up only running to get the smaller ones & the having to think if I can nuance it more
[20:39:58] <cwd>	 sounds fun, i'll watch the graphs
[20:41:47] <jgleeson>	 good night all o/
[20:41:57] <jgleeson>	 bye for now
[20:43:05] <eileen1>	 night
[20:44:17] <wikibugs>	 Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, and 2 others: Back-fill missing pgehres data - https://phabricator.wikimedia.org/T178009#3721048 (Ejegg) OK,...
[20:46:06] <eileen1>	 sigh - waiting on verify
[20:49:37] <eileen1>	 go zuul go
[20:50:38] <wikibugs>	 (CR) Eileen: [C: 2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/387365 (owner: Eileen)
[20:50:47] <eileen1>	 trying to speed it up
[20:53:02] <wikibugs>	 (Merged) jenkins-bot: Remove i18n php shim [extensions/ContributionReporting] - https://gerrit.wikimedia.org/r/387003 (https://phabricator.wikimedia.org/T168353) (owner: Umherirrender)
[20:54:02] <eileen1>	 yeah right zuul - do that one & not mine!
[20:54:15] <eileen1>	 (never mine me - I'm just talking to zuul….)
[20:54:18] <wikibugs>	 (CR) Mepps: "That same typo is everywhere you use module_invoke." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/385297 (owner: Ejegg)
[20:54:49] <mepps>	 but is zuul talking back eileen1?
[20:55:01] <eileen1>	 Zuul is giving me the cold shoulder :-)
[20:55:04] <eileen1>	 :-(
[20:55:44] <mepps>	 how rude!
[20:56:21] <wikibugs>	 (CR) Eileen: Use module_invoke for metrics (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/385297 (owner: Ejegg)
[20:56:27] <eileen1>	 :-)
[20:57:56] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/387365 (owner: Eileen)
[20:59:42] <eileen1>	 ejegg: I think I'd better leave the rsync until after civi mtg now
[21:01:21] <wikibugs>	 (PS2) Ejegg: Use module_invoke for metrics [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/385297
[21:01:30] <wikibugs>	 (PS3) Ejegg: Use module_invoke for metrics [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/385297
[21:06:04] <wikibugs>	 (CR) Ejegg: "Good catch mepps, thanks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/385297 (owner: Ejegg)
[21:20:37] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create a way to view the history of address records (dedupe follow up task) - https://phabricator.wikimedia.org/T142549#2538923 (DStrine)
[21:28:50] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Epic: Don't duplicate contact for email donations - https://phabricator.wikimedia.org/T177663#3721251 (Ejegg) @CCogdill_WMF I can start exporting the contact...
[21:35:51] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising-Backlog: Paypal / Paypal EC issue in en6C? - https://phabricator.wikimedia.org/T178931#3721294 (Ejegg) Open>Resolved a:Ejegg @PCoombe / @spatton / @CCogdill_WMF , I'm closing this task as resolved - we stopped the bug and rescued all the non-recur...
[21:36:06] <eileen1>	 !log update CiviCRM from 25c7a33e3e3e9b8a5020d826982b3dbb64057614 to a34a9c64828c24f3a4a78bcc1250a9c77bebe41a
[21:36:11] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[21:37:04] <eileen1>	 script on addresses started
[21:37:11] <ejegg>	 thanks eileen1
[21:38:33] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising-Backlog: Paypal / Paypal EC issue in en6C? - https://phabricator.wikimedia.org/T178931#3721320 (spatton) Thank you @Ejegg, really awesome that you got all the non-recurring. Just about doubled the donation counts in our 10/24 tests. If 1000 affected donations...
[21:39:33] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising-Backlog: Paypal / Paypal EC issue in en6C? - https://phabricator.wikimedia.org/T178931#3721326 (Ejegg) heh, yeah, didn't know if 91 recurring x 12 months rose to the actionable level.
[21:53:53] <eileen1>	 ejegg: I've just put another commit into process-control to add a job to do mailing_recipient backfill now things seem to be all a bit better T175394 (hopefully I got all the syntax right this time - I'm not quite sure how to test those)
[21:53:54] <stashbot>	 T175394: Omnimail recipient load (silently) broken - https://phabricator.wikimedia.org/T175394
[21:55:09] <ejegg>	 eileen1: ok, I'll take a look!
[21:56:22] <eileen1>	 it's a bit less often & a bit shorter than the mail job but the real change is just the job_identifier
[21:57:28] <ejegg>	 eileen1: sure, that looks good to me!
[21:58:48] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising-Backlog: Paypal / Paypal EC issue in en6C? - https://phabricator.wikimedia.org/T178931#3721449 (spatton) Well, @CCogdill_WMF, what do you think? Perhaps I'm underestimating the efficacy of our **Oops** message.
[22:01:35] <eileen1>	 ejegg: ok I'll deploy
[22:03:24] <eileen1>	 !log update process-control to revision is 2392ddfb5c37afd60dc11673dc09d447a7706aaa
[22:03:29] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[22:10:10] <ejegg>	 cool, let's see how it goes!
[22:10:30] <ejegg>	 yeah, it would be nice to have some basic linting on the deploy server
[22:12:41] <wikibugs>	 fundraising-tech-ops: Lint settings* before deploy - https://phabricator.wikimedia.org/T179340#3721522 (Ejegg)
[22:13:01] <eileen1>	 ejegg: no obvious break yet - but don't think it has run yet
[22:33:08] <eileen1>	 hmm I've found some timezone funkiness looking through the log. Trying to get my head around it. Looks like drush catches & hides errors
[22:36:27] <eileen1>	 ok not quite right
[22:38:33] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Geolocation - https://phabricator.wikimedia.org/T179344#3721694 (jkim_wikimedia)
[22:41:56] <eileen1>	 man I can't see it
[22:42:02] <ejegg>	 lemme see...
[22:44:51] <ejegg>	 seems to be parsing the yaml just fine
[22:45:09] <ejegg>	 eileen1: i'm going to try run-job from the command line
[22:45:29] <eileen1>	 ok - just on with K4-713 now
[22:45:53] <ejegg>	 k. huh, ValueError: no closing quotation
[22:46:10] <ejegg>	 oh weird, did a newline creep in there?
[22:47:52] <ejegg>	 orrrr - the space after the colon seems to be confusing something somewhere
[22:48:12] <eileen1>	 hmm
[22:48:17] <ejegg>	 woot, the duplicate primary addresses are gone!
[22:48:51] <ejegg>	 fixing the yaml...
[22:49:11] <eileen1>	 yay
[22:50:28] <ejegg>	 ok, I'll try running it via command-line again
[22:51:42] <ejegg>	 eileen it almost worked! Ran, but had a php error
[22:51:49] <eileen1>	 sigh
[22:52:45] <ejegg>	 ah drat, CiviCRM_API3_Exception constructor needs a code
[22:52:51] <eileen1>	 ug
[22:53:01] <eileen1>	 I'll look at that
[22:53:22] <ejegg>	 and if we hit that line, somehow this was true: $this->endTimeStamp < $startTimestamp
[22:56:06] <eileen1>	 yep - it's something to do with php timezone - I'll take a look after talking to Katie
[22:59:57] <ejegg>	 huh, time to swap that drupal default timezone back to UTC
[23:00:20] <eileen1>	 yeah I was thinking about that - at least for user 1
[23:00:25] <ejegg>	 guessing if we do that while jobs are off it should be fine
[23:00:42] <eileen1>	 so civi should set the tz in sql to match php
[23:00:47] <eileen1>	 & make that a non issue
[23:00:50] <ejegg>	 yep yep
[23:01:27] <eileen1>	 there is a line in civi initialise that sets tz in mysql to match php
[23:01:38] <eileen1>	 so that seems to not be working / happening somehow
[23:01:43] <ejegg>	 oh weird, I wonder where that's being overridden?
[23:01:53] <ejegg>	 oh, in mysql?
[23:03:10] <eileen1>	 it's CRM_Utils_System_Base::setMySQLTImezone called from civicrm_initialize
[23:04:09] <eileen1>	 so some boot order thing maybe
[23:07:37] <eileen1>	 ejegg: I moved some from pending deploy to done - not sure if I deployed any of the remaining ones
[23:09:03] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Email stats may be off (possible link to missing data in pg... - https://phabricator.wikimedia.org/T178819#3721862
[23:09:23] <ejegg>	 looking
[23:10:23] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Separate 'donations' and 'drupal' db connection strings mean txn overhead - https://phabricator.wikimedia.org/T178639#3721866 (Ejegg) p:Triage>Normal a:Ejegg
[23:20:25] <wikibugs>	 (PS1) VolkerE: Align colors to WikimediaUI color palette [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/387494 (https://phabricator.wikimedia.org/T179352)
[23:20:53] <wikibugs>	 (PS2) VolkerE: Align colors to WikimediaUI color palette [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/387494 (https://phabricator.wikimedia.org/T179352)
[23:27:11] <wikibugs>	 (PS3) VolkerE: Align colors to WikimediaUI color palette [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/387494 (https://phabricator.wikimedia.org/T178867)
[23:54:18] <wikibugs>	 (PS1) Ejegg: Get rid of duplicate database connection [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387498 (https://phabricator.wikimedia.org/T178639)
[23:56:51] <ejegg>	 well, think I'll call it a day...