[00:02:02] night [00:06:16] (CR) Eileen: "I wonder if we would be better switching back afterwards in any function that does a DB push to a different DB & just removing the db->pus" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387498 (https://phabricator.wikimedia.org/T178639) (owner: Ejegg) [00:19:41] Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Email stats may be off (possible link to missing data in pg... - https://phabricator.wikimedia.org/T178819#3722035 [00:19:47] (CR) Ejegg: "We could drop this magic db class altogether and just use drupal db_selects for that db and CRM_DAO::execute for civicrm tables." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387498 (https://phabricator.wikimedia.org/T178639) (owner: Ejegg) [00:30:45] (CR) Eileen: "Yep - I did wonder about that! I didn't suggest it because I was worried it might be too much scope creep" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387498 (https://phabricator.wikimedia.org/T178639) (owner: Ejegg) [01:43:09] (CR) jerkins-bot: [V: -1] Get rid of duplicate database connection [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387498 (https://phabricator.wikimedia.org/T178639) (owner: Ejegg) [02:09:02] (PS4) AndyRussG: Add API to delay call to record impression [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) [02:12:26] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: PHP & mysql timezones are not aligned when running cron, resulting in some job fails - https://phabricator.wikimedia.org/T179357#3722173 (Eileenmcnaughton) [02:13:43] Fundraising Sprint Uptight Piano, Unplanned-Sprint-Work: Fix 'the silence of the crons' - https://phabricator.wikimedia.org/T179358#3722185 (Eileenmcnaughton) [02:13:57] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Fix 'the silence of the crons' - https://phabricator.wikimedia.org/T179358#3722198 (Eileenmcnaughton) [02:16:46] (PS1) Eileen: Backport of formatting cleanup. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/387507 [02:16:48] (PS1) Eileen: CRM-21371 - An api error when calling drush cvapi should be treated as a drush error [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/387508 [02:21:07] (CR) jerkins-bot: [V: -1] Add API to delay call to record impression [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) (owner: AndyRussG) [03:54:58] (PS1) Eileen: Rename job_suffix to job_identifier. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387512 (https://phabricator.wikimedia.org/T175394) [04:02:25] (PS1) Eileen: Fix thrown exception in Omnimail. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387515 (https://phabricator.wikimedia.org/T175394) [11:48:48] Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Email stats may be off (possible link to missing data in pg... - https://phabricator.wikimedia.org/T178819#3722749 [12:23:33] (CR) Ladsgroup: [C: 2] Align colors to WikimediaUI color palette [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/387494 (https://phabricator.wikimedia.org/T178867) (owner: VolkerE) [12:25:30] (Merged) jenkins-bot: Align colors to WikimediaUI color palette [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/387494 (https://phabricator.wikimedia.org/T178867) (owner: VolkerE) [12:43:17] Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, and 2 others: Back-fill missing pgehres data - https://phabricator.wikimedia.org/T178009#3722891 (Pcoombe) @E... [13:59:06] (Restored) Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/81470 (owner: Hashar) [13:59:10] (PS3) Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/81470 [13:59:14] (CR) Hashar: "check experimental" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/81470 (owner: Hashar) [14:01:16] Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, and 2 others: Back-fill missing pgehres data - https://phabricator.wikimedia.org/T178009#3723214 (Jgreen) [15:05:58] Fundraising-Backlog: Civi: create unsubscribe email address for 90 days option - https://phabricator.wikimedia.org/T178948#3723561 (MBeat33) Thank you, @Ejegg! I was thinking of just a Civi option (not a donor-facing link). If the 'paused until' date could default to 90 days from the current date that would... [15:07:07] hi ejegg! hi jgleeson! [15:07:19] hi mepps! [15:10:15] fr-tech anyone wlse interested in the selenium tech talk starting in an hour? [15:11:03] would be great to get some automated browser tests for donation interface [15:15:22] i'm interested! but i haven't seen any info on it [15:15:44] oh i see it now [15:15:51] cool! [15:22:58] ejegg do you know anything about this chargeback adyen failmail? [15:25:55] mepps we don't get many of those notifications [15:26:07] so we just haven't implemented it yet [15:26:23] would need a civi mechanism to undo refunds [15:26:34] probably not much work [15:28:56] okay cool [15:52:22] (CR) Mepps: [C: 2] Backport of formatting cleanup. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/387507 (owner: Eileen) [15:58:00] (Merged) jenkins-bot: Backport of formatting cleanup. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/387507 (owner: Eileen) [16:01:22] (PS3) Mepps: WIP Script to update old activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003) [16:01:29] (CR) jerkins-bot: [V: -1] WIP Script to update old activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003) (owner: Mepps) [16:04:44] (PS4) Mepps: WIP Script to update old activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003) [16:06:00] hey mepps, hey ejegg [16:06:03] :) [16:22:26] hi jgleeson ! [16:24:00] hope you enjoy the selenium session, I've used it before for acceptance testing stuff and thought it was good overall. [16:24:42] I had to use some funky firefox plugin to help generate the test targets on page [16:24:57] jgleeson have you used it in ruby or js? [16:24:58] I found trying to write them blind a bit more difficult [16:25:07] it was php [16:25:19] ah gotcha, this was on the js version [16:26:16] it was pretty introductory though, always fun to see browser tests in action though! [16:26:32] my favorite civi sprint was one where all we did was work on the web tests [16:27:05] http://www.yiiframework.com/doc/guide/1.1/en/test.functional [16:27:11] that was the implementation I used it with [16:28:24] which uses PHPUnit_Extensions_SeleniumTestCase behind the scenes [16:31:22] what version of PHP are we using in production? [16:42:22] i think 5.6 ejegg? [16:42:50] (CR) Mepps: [C: 2] CRM-21371 - An api error when calling drush cvapi should be treated as a drush error [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/387508 (owner: Eileen) [16:43:36] yep, 5.6 [16:45:56] (PS5) Mepps: WIP Script to update old activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003) [16:46:27] thanks [16:49:02] (Merged) jenkins-bot: CRM-21371 - An api error when calling drush cvapi should be treated as a drush error [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/387508 (owner: Eileen) [16:54:21] (CR) Mepps: [C: 2] Use module_invoke for metrics [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/385297 (owner: Ejegg) [16:57:18] drat, I was totally mistaken about the 'target' option for drupal's db functions. [16:57:52] it's just for main/replica copies of the same db, not for swapping to e.g. civicrm [17:00:40] (Merged) jenkins-bot: Use module_invoke for metrics [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/385297 (owner: Ejegg) [17:01:17] (PS2) Ejegg: Get rid of duplicate database connection [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387498 (https://phabricator.wikimedia.org/T178639) [17:08:14] nice, that works at least! [17:13:24] (PS5) AndyRussG: Add API to delay call to record impression [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) [17:14:16] (CR) AndyRussG: "This patch set adds QUnit tests." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) (owner: AndyRussG) [17:15:10] (CR) jerkins-bot: [V: -1] Add API to delay call to record impression [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) (owner: AndyRussG) [17:18:24] (PS6) AndyRussG: Add API to delay call to record impression [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) [17:21:58] (PS3) Ejegg: Get rid of duplicate database connection [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387498 (https://phabricator.wikimedia.org/T178639) [17:22:28] fr-tech that's a relatively simple change that might help performance ^^^ [17:22:46] looking now ejegg [17:22:49] would be awesome if we could put it up today and get some performance data in tomorrow's test! [17:22:51] aren't two connections better than one? [17:22:54] thank you mepps! [17:23:15] AndyRussG: not if you're opening multiple transactions onto the same db, i don't think! [17:23:21] You do two updates to linked tables simultaneously and watch them race [17:23:28] hehe [17:23:31] ;p [17:24:02] ejegg so we no longer need the ct_transaction? [17:24:52] mepps correct [17:25:08] (CR) Mepps: [C: 2] Get rid of duplicate database connection [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387498 (https://phabricator.wikimedia.org/T178639) (owner: Ejegg) [17:25:17] maybe at the beginning, contribution_tracking wasn't in the drupal db [17:25:25] but it's been there for years [17:25:39] rockin! [17:27:53] thanks again mepps. I'll deploy that after I grab some lunch [17:28:02] cool ejegg [17:28:37] ejegg, so far I've been shadowing the peer requests but reluctant to +2 any until I am more familiar with the overall codebase [17:29:33] sounds like a good cautious way to start out [17:29:38] back in a bit! [17:31:20] (Merged) jenkins-bot: Get rid of duplicate database connection [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387498 (https://phabricator.wikimedia.org/T178639) (owner: Ejegg) [17:38:58] sitting here patiently waiting for either, my laptop to arrive or our first trick-or-treaters to knock :) [18:10:37] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/387627 [18:18:28] got some good candy to give out jgleeson ? [18:19:10] well, I have been picking at it when going down for coffee so if they don't hurry up the good stuff will be gone! [18:19:18] winegums! [18:19:18] hehe [18:20:13] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/387632 [18:20:30] ok, going to deploy that db connection consolidation and see if it breaks everything :) [18:20:48] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/387632 (owner: Ejegg) [18:21:05] (CR) AndyRussG: [C: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/387627 (owner: AndyRussG) [18:21:40] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/387632 (owner: Ejegg) [18:22:21] (PS2) Ejegg: (trivial) Fix index value for overall message age [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/385080 [18:23:53] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/387627 (owner: AndyRussG) [18:25:29] fr-tech ^ merging assorted mostly no-op CN changes into wmf_deploy for riding the train today [18:25:41] https://wikitech.wikimedia.org/wiki/Deployments#Tuesday.2C.C2.A0October.C2.A031 [18:26:41] (See https://wikitech.wikimedia.org/wiki/Heterogeneous_deployment/Train_deploys for how it works... all smoothly handled by our friends in ops) [18:27:16] !log updated CiviCRM from a34a9c64828c24f3a4a78bcc1250a9c77bebe41a to 415fde15262905c683e68826cf033264d5c31581 [18:27:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:27:37] Summary: standard weekly updates to mediawiki on the main cluster. Tuesday goes to some test wikis, Wednesday to some smaller wikis, then Thursday to all the rest [18:28:31] jgleeson: somewhat interesting info on how we deploy code to the main wikis ^^^ [18:29:43] Just as soon as you get your 2 factor auth usb thing we can show you how to deploy code to our own little cluster [18:32:14] looks like there's quite a bit going on [18:34:25] Setting Wikis Ablaze Team [18:34:26] nice [18:39:14] cool, that last deploy seems to be working smoothly [18:40:58] mepps: how do you feel about deploying that Adyen / safari stuff today? [18:41:20] ejegg does everyone has a 2fa usb stick for deployments? [18:41:27] pretty secure stuff [18:41:29] yeah [18:41:42] (and needed for PCI compliance) [18:42:04] Ooh, shoot, I hope OIT is sending you one! [18:42:19] drat, rain... [18:43:44] I spoke to OIT today. The ETA for my laptop was today but they tracked it and think the order is still being processed with Lenovo [18:44:21] ejegg did we ever test that out on staging? i thought that was part of the plan.. [18:44:30] we also need to do a settings update if we do that [18:45:31] but otherwise, sure we can do that [18:51:58] ejegg / jgleeson want to be my shadows on this deploy? [18:52:20] sure [18:52:40] okay i'll be in the chat [18:52:43] hangouts? [18:52:47] yup [18:53:03] ok wil join in 1 minute [18:54:12] ejegg|brb join us when you return [19:00:29] (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/387636 [19:02:08] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/387636 (owner: Mepps) [19:02:13] fundraising-tech-ops: samarium/rsyslog - too many open files - https://phabricator.wikimedia.org/T179431#3724453 (cwdent) [19:03:10] (PS2) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/387636 [19:04:14] sorry, that took longer than I thought it would! [19:04:15] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/387636 (owner: Mepps) [19:07:56] (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387638 [19:11:27] fundraising-tech-ops: samarium/rsyslog - too many open files - https://phabricator.wikimedia.org/T179431#3724475 (cwdent) I have deployed a new config with keepalive turned on, so in a week or so we should be able to tell if it helps 😿 [19:18:24] (Abandoned) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387638 (owner: Mepps) [19:18:32] (Abandoned) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/387636 (owner: Mepps) [19:23:34] (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/387643 [19:27:25] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/387643 (owner: Mepps) [19:28:29] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/387643 (owner: Mepps) [19:35:43] ejegg: are we doing an email comparison when someone uses contact_id & hash? Just thinking about i someone forwards the email [19:53:22] freaking google... waited for me to start talking to ask me to re-authenticate [20:26:45] (PS1) Mepps: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/387657 [20:27:09] (CR) Mepps: [C: 2] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/387657 (owner: Mepps) [20:34:56] (Merged) jenkins-bot: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/387657 (owner: Mepps) [20:43:54] !log updated payments-wiki from b88b805c3b223404578c3ef8bb675e710611aa2d to 5303a8e66338f84218dfbfe9ba2ca736fa06331a [20:44:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:45:35] !log rolledback payments-wiki from 5303a8e66338f84218dfbfe9ba2ca736fa06331a to b88b805c3b223404578c3ef8bb675e710611aa2d [20:45:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:46:06] ejegg i was getting an error in prod so i rolled back ^ [20:48:37] mepps signature problem? [20:48:53] trying to find out but it looked the same as you had locally [20:49:03] oh weird [20:49:19] ohhhhh... lemme see if the redirect urls are all set up [20:54:54] !log updated payments-wiki from b88b805c3b223404578c3ef8bb675e710611aa2d to 5303a8e66338f84218dfbfe9ba2ca736fa06331a [20:54:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:57:26] !log rollback payments-wiki from 5303a8e66338f84218dfbfe9ba2ca736fa06331a to b88b805c3b223404578c3ef8bb675e710611aa2d [20:57:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:22:10] (PS1) Ejegg: Don't include 'debug' in signature fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387697 [21:25:32] Wikimedia-Fundraising-Campaigns (FY Q2 Oct-Dec 2017), Wikimedia-CentralNotice-Administration (Q4-2017): WMF Fundraising 2017-18 - France (3 October - 31 October) - https://phabricator.wikimedia.org/T170259#3724761 (Pcoombe) Open>Resolved [21:28:17] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Make Adyen default gateway for Ukraine - https://phabricator.wikimedia.org/T140086#3724765 (Pcoombe) a:Pcoombe>None [21:36:31] (PS1) Ejegg: Adyen: deal with non-iframe return [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387717 (https://phabricator.wikimedia.org/T176913) [21:36:42] fr-tech I think that's the last thing missing for the full-redirect to work ^^^ [21:40:32] (PS1) Ejegg: Fix exception signature [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387727 (https://phabricator.wikimedia.org/T176913) [21:42:41] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, and 3 others: Registering test in impressions - https://phabricator.wikimedia.org/T176334#3724831... [22:09:15] hey dstrine, you free for a minute? [22:25:19] (PS1) Ejegg: Adyen transitional code - revert a day after deployment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387740 (https://phabricator.wikimedia.org/T176913) [23:14:38] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, and 4 others: Create lists of CiviCRM groups to allow MG & DS to review with a view to tidy up - https://phabricator.wikimedia.org/T174407#3560690 (Eile... [23:17:02] (PS1) Eileen: Fix for overwriting of start_time. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387748 (https://phabricator.wikimedia.org/T179357) [23:23:22] (CR) jerkins-bot: [V: -1] Fix for overwriting of start_time. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387748 (https://phabricator.wikimedia.org/T179357) (owner: Eileen)