[00:47:20] (Abandoned) Eileen: Fix test to meet php standard. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/380668 (owner: Eileen) [01:19:59] (PS2) Eileen: Fix for overwriting of start_time. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387748 (https://phabricator.wikimedia.org/T179357) [03:32:18] (PS1) Eileen: Remove a trailing space [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387764 [03:32:20] (PS1) Eileen: Make tests more readable by using dates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387765 (https://phabricator.wikimedia.org/T179357) [03:33:31] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Start date being overwritten on recipient retrieval cron, resulting in some job fails - https://phabricator.wikimedia.org/T179357#3722173 (Eileenmcnaughton) [03:38:56] (CR) jerkins-bot: [V: -1] Make tests more readable by using dates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387765 (https://phabricator.wikimedia.org/T179357) (owner: Eileen) [03:48:26] (PS2) Eileen: Make tests more readable by using dates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387765 (https://phabricator.wikimedia.org/T179357) [03:54:26] (CR) jerkins-bot: [V: -1] Make tests more readable by using dates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387765 (https://phabricator.wikimedia.org/T179357) (owner: Eileen) [04:05:10] (PS3) Eileen: Make tests more readable by using dates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387765 (https://phabricator.wikimedia.org/T179357) [04:11:31] (CR) jerkins-bot: [V: -1] Make tests more readable by using dates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387765 (https://phabricator.wikimedia.org/T179357) (owner: Eileen) [04:40:27] (PS4) Eileen: Make tests more readable by using dates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387765 (https://phabricator.wikimedia.org/T179357) [05:22:26] (PS1) Eileen: Hack proximity search to support entering lat& long directly [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/387770 (https://phabricator.wikimedia.org/T179344) [05:47:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Geolocation - https://phabricator.wikimedia.org/T179344#3721694 (Eileenmcnaughton) We actually store geocoding data for contacts using a WMF table. The problem that form has is without a geocoder plugin it doesn't know how to look... [10:43:06] good morning everyone [11:50:01] Morning jgleeson! [11:50:07] jgleeson: where are you based? [11:51:05] Seddon: Liverpool, UK :) [11:51:11] how about yourself? [11:51:24] Manchester right? [11:51:26] Ahhh so you are pretty much welsh then :P [11:51:29] Cardiff [11:51:47] ah apologies I mistaken you for someone else [11:51:53] yes, close enough to wales :) [11:53:01] jgleeson: There totally needs to be a UK staff meetup... [11:53:06] There are growing numbers of us [11:54:10] yes that would be cool [11:54:26] I am hoping to attend the wikimedia UK meetup in manchester this month [11:54:33] the 26th [11:54:59] https://meta.wikimedia.org/wiki/Meetup/Manchester/34 [13:44:57] (CR) Mepps: [C: 2] Adyen: deal with non-iframe return [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387717 (https://phabricator.wikimedia.org/T176913) (owner: Ejegg) [13:45:08] morning mepps [13:45:18] afternoon jgleeson! [13:45:23] :) [13:49:35] (Merged) jenkins-bot: Adyen: deal with non-iframe return [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387717 (https://phabricator.wikimedia.org/T176913) (owner: Ejegg) [13:57:12] (CR) Mepps: [C: 2] Fix exception signature [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387727 (https://phabricator.wikimedia.org/T176913) (owner: Ejegg) [13:59:05] (Merged) jenkins-bot: Fix exception signature [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387727 (https://phabricator.wikimedia.org/T176913) (owner: Ejegg) [14:22:27] (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/387797 [14:23:10] (CR) Mepps: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/387797 (owner: Mepps) [14:24:03] (PS1) Mepps: Update with latest commits in DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/387798 [14:25:58] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/387797 (owner: Mepps) [14:26:19] (CR) Mepps: [C: 2] Update with latest commits in DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/387798 (owner: Mepps) [14:30:41] (Merged) jenkins-bot: Update with latest commits in DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/387798 (owner: Mepps) [14:32:08] ejegg|away, i'm all set to deploy again but since the test starts in half an hour it feels too risky to deploy now [14:41:27] ok mepps, sounds fine to me [15:22:44] how's your work going jgleeson? [15:27:00] so far so good. I have something working now, I've taken the module out of the drupal project so it was easier to test and work on in isolation. I've just waiting on the green light from Elliott to push it to github and then I am hoping to get jump on a call with anyone who is free and get feedback [15:27:18] I'm* [15:30:37] how about you mepps [15:34:48] got some stuff ready to deploy and looking at how to approach another issue [15:44:55] (PS2) Ejegg: Rename job_suffix to job_identifier. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387512 (https://phabricator.wikimedia.org/T175394) (owner: Eileen) [15:45:02] (CR) Ejegg: [C: 2] Rename job_suffix to job_identifier. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387512 (https://phabricator.wikimedia.org/T175394) (owner: Eileen) [15:46:34] (PS2) Ejegg: Fix thrown exception in Omnimail. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387515 (https://phabricator.wikimedia.org/T175394) (owner: Eileen) [15:46:45] (CR) Ejegg: [C: 2] Fix thrown exception in Omnimail. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387515 (https://phabricator.wikimedia.org/T175394) (owner: Eileen) [15:48:29] (PS3) Ejegg: Fix for overwriting of start_time. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387748 (https://phabricator.wikimedia.org/T179357) (owner: Eileen) [15:48:39] (CR) Ejegg: [C: 2] Fix for overwriting of start_time. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387748 (https://phabricator.wikimedia.org/T179357) (owner: Eileen) [15:48:59] (Merged) jenkins-bot: Rename job_suffix to job_identifier. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387512 (https://phabricator.wikimedia.org/T175394) (owner: Eileen) [15:49:14] (PS2) Ejegg: Remove a trailing space [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387764 (owner: Eileen) [15:49:39] (CR) Ejegg: [C: 2] "Or the whole blank @var... :P" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387764 (owner: Eileen) [15:51:11] hey ejegg! [15:55:39] (PS5) Ejegg: Make tests more readable by using dates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387765 (https://phabricator.wikimedia.org/T179357) (owner: Eileen) [15:55:52] (Merged) jenkins-bot: Fix thrown exception in Omnimail. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387515 (https://phabricator.wikimedia.org/T175394) (owner: Eileen) [15:56:02] hi mepps! [15:56:36] ejegg do you think your patches will resolve the errors we were seeing with adyen on prod? [15:57:46] mepps maybe... I think we still need this temporary thing https://gerrit.wikimedia.org/r/387740 unless we want to shut off adyen for a day to deploy [15:58:29] I think people who had the old JS loaded (which didn't set the processor_form) [15:58:38] were triggering that exception [15:58:43] (Merged) jenkins-bot: Fix for overwriting of start_time. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387748 (https://phabricator.wikimedia.org/T179357) (owner: Eileen) [15:59:12] and maybe we were even getting that same thing due to caching (it's somewhere between 5-15 min to get new js) [16:01:47] hey fr-tech [16:01:59] oh hey, standup time... one sec! [16:02:11] i'm in a coffee shop and brought my iphones but can't find the connector cord [16:02:25] (Merged) jenkins-bot: Remove a trailing space [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387764 (owner: Eileen) [16:02:56] nevermind, borrowed some [16:03:37] I think I have my 1:1 with Katie now so I will be along to standup shortly [16:04:12] scratch that [16:04:15] standup first! [16:06:19] (CR) Ejegg: "Is this mostly being used to search US addresses? If so, we could use the wmf_zip_geo table in place of the googs and make things a little" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/387770 (https://phabricator.wikimedia.org/T179344) (owner: Eileen) [16:06:23] ugh google hangouts is having issues connect fr-tech [16:22:16] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Unplanned-Sprint-Work: test task sadkfjsadkfja - https://phabricator.wikimedia.org/T179504#3726899 (DStrine) [16:23:13] hmm ejegg even if the new js isn't live i'm not sure we should see this error [16:23:28] because i'm not testing on safari, just regular adyen flow [16:24:28] Fundraising Sprint Uptight Piano, Fundraising-Backlog: Prometheus: Add seconds diff metric report [donation message enqueued => donation saved to civi] - https://phabricator.wikimedia.org/T179173#3726920 (DStrine) [16:25:48] Fundraising Sprint Uptight Piano, Fundraising-Backlog: Prometheus: Add seconds diff metric report [donation message enqueued => donation saved to civi] - https://phabricator.wikimedia.org/T179173#3715702 (DStrine) [16:25:50] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Unplanned-Sprint-Work: test task sadkfjsadkfja - https://phabricator.wikimedia.org/T179504#3726899 (DStrine) [16:25:58] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Unplanned-Sprint-Work: test task sadkfjsadkfja - https://phabricator.wikimedia.org/T179504#3726899 (DStrine) Open>Resolved [16:27:10] or wait, yes that would be it, but is there a way to set a default value for a field? [16:32:04] or to clear the caches on deploy? [16:41:29] mepps sorry, just saw your comments! [16:42:22] mepps yeah, there should be a way to set the default, that might be better than the temporary hack [16:42:52] lessee now, the hidden field already has a 'value' attribute [16:43:48] mepps I think setGatewayDefaults would be the place to do it [16:45:08] yeah, looks like that would replace both the bits in that temp hack! [16:47:38] cool ejegg! [16:49:46] (Abandoned) Ejegg: Adyen transitional code - revert a day after deployment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387740 (https://phabricator.wikimedia.org/T176913) (owner: Ejegg) [16:54:39] (CR) Addshore: [C: 2] Make CentralNotice work on sqlite [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/377775 (owner: Brian Wolff) [16:57:30] (Merged) jenkins-bot: Make CentralNotice work on sqlite [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/377775 (owner: Brian Wolff) [17:15:30] (CR) Hashar: "check experimental" [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/242572 (https://phabricator.wikimedia.org/T114250) (owner: Hashar) [17:16:03] (CR) jenkins-bot: Introduce tox entry point and run flake8 [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/242572 (https://phabricator.wikimedia.org/T114250) (owner: Hashar) [17:16:05] (CR) Hashar: "check experimental" [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/385307 (https://phabricator.wikimedia.org/T178009) (owner: Ejegg) [17:16:19] (CR) Hashar: "check experimental" [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/383284 (https://phabricator.wikimedia.org/T172303) (owner: Ejegg) [17:16:21] (CR) jenkins-bot: Loosen squidline regex format [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/385307 (https://phabricator.wikimedia.org/T178009) (owner: Ejegg) [17:16:43] (CR) jenkins-bot: Fix failmail suppression [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/383284 (https://phabricator.wikimedia.org/T172303) (owner: Ejegg) [17:21:08] jgleeson: I've got a meeting in 10 min, but it usually only lasts 20 min or so [17:21:15] fr-tech any news for scrum of scrums? [17:21:37] jgleeson: it's a meeting of representatives from each of the engineering teams [17:21:52] to resolve inter-team dependencies etc [17:22:10] usually our team doesn't have that sort of blockers [17:22:31] sometimes we'll use that meeting to ask for help from e.g. analytics [17:22:50] and sometimes we'll be blocked by changes to continuous integration [17:24:24] sorry ejegg was in 1:! [17:24:28] 1:1 even [17:24:40] can I grab you for 5 now [17:24:47] just get the headline [17:24:59] if not, I can wait until afterwards [17:32:57] ejegg: nothing here ,thanks! [17:47:18] jgleeson: free for a chat when you are! [17:48:41] shall we use the usual room? [17:48:58] sure, hopping in now [18:36:21] fundraising-tech-ops: blockers for migrating fundraising to stretch - https://phabricator.wikimedia.org/T176655#3727566 (Jgreen) [18:37:14] fundraising-tech-ops: blockers for migrating fundraising to stretch - https://phabricator.wikimedia.org/T176655#3632828 (Jgreen) #2 yubikey auth is fixed here: commit 5efcff8eacbf3bc17e7083a37f33871ae0326adf Author: Jeff Green Date: Wed Nov 1 14:22:11 2017 -0400 switch from pam... [18:37:33] fundraising-tech-ops: blockers for migrating fundraising to stretch - https://phabricator.wikimedia.org/T176655#3727571 (Jgreen) Open>Resolved [18:37:37] have a good day people, see you tomorrow o/ [18:56:10] fundraising-tech-ops: frdb1002 swap use spike associated with mysql dump run - https://phabricator.wikimedia.org/T177982#3727640 (Jgreen) Open>declined kernel memory management seems to be handling this better since we fixed the mysql temporary tables bloat issue in T178020 [19:52:09] (PS1) Mepps: Add default value for processor_form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387858 (https://phabricator.wikimedia.org/T177893) [19:52:29] ejegg this is my fix using setGatewayDefaults ^^ [19:53:08] PROBLEM - Host alnitak is DOWN: PING CRITICAL - Packet loss = 100% [19:59:39] thanks mepps, looking! [20:00:28] Fundraising-Backlog, Gerrit, Release-Engineering-Team (Kanban): Determine status of fundraising-related branches and tags - https://phabricator.wikimedia.org/T177334#3727783 (awight) From what I remember, it should be safe to delete all branches except the last two. @Ejegg can confirm that. I don't... [20:03:14] Fundraising-Backlog, Gerrit, Release-Engineering-Team (Kanban): Determine status of fundraising-related branches and tags - https://phabricator.wikimedia.org/T177334#3727792 (Ejegg) Hi @demon, fundraising is on the long term support 1_27 tag. branches 1_22 through 1_26 and tags 1.20 and 1.22 can be d... [20:08:58] RECOVERY - Host alnitak is UP: PING OK - Packet loss = 0%, RTA = 36.13 ms [20:10:21] (CR) Ejegg: [C: -1] "Think you need to do the test more like the paypal express adapter" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387858 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [20:10:33] Fundraising-Backlog, Gerrit, Release-Engineering-Team (Kanban): Determine status of fundraising-related branches and tags - https://phabricator.wikimedia.org/T177334#3727820 (demon) Open>Resolved a:demon Awesome thanks! Pruned all the old ones from the repo [20:11:02] (CR) Eileen: "yeah I thought about that - I was mostly after something quick to meet a specific need from Jerry. I think the 'right' answer is to change" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/387770 (https://phabricator.wikimedia.org/T179344) (owner: Eileen) [20:18:04] (CR) Eileen: "good point! I was just focussed on the difference between what was committed in the extension & in our code" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387764 (owner: Eileen) [20:21:40] ejegg: Im going to deploy those job patches- is it worth trying to get the proximity search in this deploy or leave for later [20:25:50] Wikimedia-Fundraising-CiviCRM: New Civi Import - https://phabricator.wikimedia.org/T172423#3727846 (jkim_wikimedia) Hey all, just wanted to check back in on this. I've been using the Trilogy import, but we'd like to have an import created for Stripe specifically. Let me know if you have any questions. Thank... [20:26:24] (PS1) Eileen: CiviCRM submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387868 [20:27:29] eileen1: sorry, just saw your comment. looking! [20:27:39] Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review: Move tracking of silverpop out of settings table - https://phabricator.wikimedia.org/T177451#3727848 (Eileenmcnaughton) Open>Re... [20:28:03] fundraising-tech-ops, Operations, netops: bonded/redundant network connections for fundraising hosts - https://phabricator.wikimedia.org/T171962#3727851 (Jgreen) [20:28:07] fundraising-tech-ops, Operations, netops, ops-eqiad: connect second interface for each frack to opposite switch for each eqiad host - https://phabricator.wikimedia.org/T176975#3727849 (Jgreen) Open>Resolved a:Jgreen [20:28:15] (CR) Eileen: [C: 2] CiviCRM submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387868 (owner: Eileen) [20:28:40] ejegg: it doesn't have to go through now - it can wait [20:29:47] fundraising-tech-ops: Lint settings* before deploy - https://phabricator.wikimedia.org/T179340#3727853 (Jgreen) a:Jgreen [20:31:05] (CR) Ejegg: [C: 2] "If the users asked for it this way, who am I to argue?" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/387770 (https://phabricator.wikimedia.org/T179344) (owner: Eileen) [20:32:54] cwd what's your busy-ness level today? [20:33:28] ejegg: just smashing my head against virtualbox [20:33:38] but it's not super urgent...want to build p-c? [20:33:44] cwd sure! [20:34:14] want to do this on a call? I'd love to try to follow along locally [20:34:52] i am in a coffee shop that is not super quiet but i can hop on if you want [20:34:54] (Merged) jenkins-bot: CiviCRM submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387868 (owner: Eileen) [20:34:56] (Merged) jenkins-bot: Hack proximity search to support entering lat& long directly [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/387770 (https://phabricator.wikimedia.org/T179344) (owner: Eileen) [20:35:10] the whole first part is building the package in VB [20:35:29] (PS1) Ejegg: Only update contact on email match too [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387870 [20:35:35] ah, will your current woes prevent that? [20:35:51] nah i think i can fix it pretty easy [20:36:08] systemd has broken init 1 [20:36:11] cool, I'll get to installing all the debhelper things in my vb [20:36:18] i have this box i don't know the root pass for [20:36:25] have been trying to root it for like 2 days [20:36:34] heh, sounds fun! [20:36:40] so frustrating [20:37:22] anyway i shouldn't need root for this [20:37:42] so basically what i do is get it to build in vb, then export that patch to the live repo [20:38:06] ok, cool [20:38:47] cwd want to try with this bash completion stuff? https://github.com/ejegg/process-control-debian [20:41:11] ugh looks like i hosed that VB instance after all [20:41:25] well shoot [20:41:35] i can probably just do it live [20:42:21] https://media.tenor.co/images/6ac220e7d7e9cba9af043abe82c75ac1/raw [20:42:42] hehe, I knew what that would be before I clicked [20:43:30] (PS1) Eileen: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387874 [20:43:52] hmm so i have a whole different debian dir than this [20:44:28] Fundraising-Backlog: Include apache2 errors in payments.error - https://phabricator.wikimedia.org/T128820#3727873 (Ejegg) Open>declined [20:44:42] cwd oh? [20:44:51] (CR) Eileen: [C: 2] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387874 (owner: Eileen) [20:45:14] yeah the majority of the hacking that takes place with each build is in the debian metadata [20:45:34] (PS2) Mepps: Add default value for processor_form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387858 (https://phabricator.wikimedia.org/T177893) [20:45:58] cwd is it easy enough to just add the new file and the two new lines to 'control' ? [20:47:26] yeah that is what i'll try [20:50:53] (Merged) jenkins-bot: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387874 (owner: Eileen) [20:53:22] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/387876 [20:54:08] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/387876 (owner: Eileen) [20:55:00] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/387876 (owner: Eileen) [21:04:39] (CR) Ejegg: [C: 2] "Looks good!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387858 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [21:09:13] (Merged) jenkins-bot: Add default value for processor_form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/387858 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [21:15:43] this is quite a nice little story https://civicrm.org/blog/marko/civicrm-comes-to-serbia [21:16:57] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Unexpected side-effect of? CentralNotice wmf_deploy branch strategy - https://phabricator.wikimedia.org/T179536#3727953 (awight) [21:17:02] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Unexpected side-effect of CentralNotice wmf_deploy branch strategy - https://phabricator.wikimedia.org/T179536#3727965 (awight) [21:31:36] eileen1: do you know what happened with the silverpop unsubscribe job? [21:32:44] ejegg: we didn't set it running because of the lag - I think we should now [21:33:55] there was a failmail, with this in the log: Mandatory key(s) missing from params array: source_contact_id [21:35:29] oh right - I see the job is running :-) [21:35:57] perhaps without —user=admin? [21:36:08] (I'm not back in yet) [21:36:12] hrm, would that do it? [21:36:18] oh, I can look [21:36:41] well it needs to get a source contact id from somewhere - I assume the user who runs it [21:36:57] ohhh, that's what the source_contact_id is! [21:37:06] yeah [21:37:16] so this is a new failmail from that drush patch [21:37:21] I guess [21:37:30] ie - it was hidden before [21:37:32] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Unexpected side-effect of CentralNotice wmf_deploy branch strategy - https://phabricator.wikimedia.org/T179536#3728008 (demon) > The only alternative I can think of is something we've discussed and dismissed a few times, that new development is mer... [21:37:52] the command line does have --user=1 [21:38:46] hmm - I wonder if that is working [21:39:14] hmm - I'm still not back in business with yubikey [21:39:36] perhaps it's actually because it's trying to unsubscribe a deleted contact [21:39:48] ohhh, might be the case! [21:40:02] the code seems to set the target and source contact ids to the same thing [21:40:03] 'source_contact_id' => $unsubscribes['contact_id'], [21:40:09] yep [21:40:39] I guess if we run from the command line with debug we'll see the contact id involved [21:42:20] I'm in! [21:42:25] woohoo! [21:43:04] so, we should maybe be tracking down the user that was merged into? [21:43:42] ejegg: ok i am optimistic that package built properly [21:43:49] nice! [21:43:52] ejegg: yeah - I think there is a job for figuring out how merges work on recipients - but maybe higher priority now that failmail is chatting [21:43:56] want me to roll it out? [21:44:16] cwd yeah! Lemme just turn the jobs off for the deploy [21:44:27] groovy [21:44:31] [ [21:44:37] -[ [21:44:45] ? [21:45:26] ejegg: so I'm going to try to set the recipient.load job back a few days because I'm not 100% sure that start_date bug didn't cause anything to be missed & I think it got deployed on the 30th [21:45:49] ok, sounds good eileen1 [21:46:16] actually, hang on a sec, I'm turning the jobs off for a p-c deploy [21:46:28] ok [21:47:20] I think I can do it this way [21:47:21] drush cvapi OmnimailJobProgress.create id=2 last_timestamp='2017-10-29' [21:47:51] oh right, not via the db? [21:48:05] !log fundraising jobs disabled [21:48:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:48:13] cwd ok, ready for the deployment! [21:48:57] here goes [21:49:27] ok, ready to roll [21:52:22] Take that Hillary http://www.radionz.co.nz/news/top/342900/ardern-makes-list-of-most-powerful-women-in-global-politics [21:53:55] oy, ivanka at #6... [21:55:10] yeah that's a bit dodgey [21:55:19] argh i was just about to say [21:55:49] to be honest it's hard to see how NZ trumps Norway & Scotland but…. [21:55:56] (╯°□°）╯︵ ┻━┻) [21:56:25] I didn't even realise Bangladesh had a female PM - feel backwards now? [21:56:26] cwd the list, or process-control ? [21:57:25] hehe, the list [21:57:29] i think p-c is ok? [21:57:47] all deployed? [21:57:51] yep [21:58:08] sorry that's what i meant by ready to roll [21:58:25] ah, cool! [21:58:43] eileen1: didja try the yubikey? [21:58:51] cwd yep all good [21:58:57] cool [21:59:29] durn, doesn't seem to have added anything to bash_completion.d [21:59:48] logged out and back in, and no dice tabbing to get job names [22:00:14] hmm, all i did was add that file [22:00:20] and change control and changelog [22:00:22] and pull the new code [22:00:26] was there another step? [22:01:15] I didn't think so, but I never quite got things building locally [22:01:36] just going on the instructions here: https://www.debian.org/doc/manuals/maint-guide/dreq.en.html#customrules [22:01:56] anyway, if the allow_overtime thing is working, that's the important bit! [22:02:26] huh [22:02:44] i also added the new deps in pbuilder but... there are 8000 ways to .deb [22:04:00] ejegg: is allow overtime the last commit? i noticed there was only one new one [22:04:25] cwd yep! [22:05:24] ok, turning jobs back on [22:05:53] holler [22:06:06] !log re-enabled fundraising jobs [22:06:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:14:04] ejegg: I've repushed to enable the recipient back fill - can deploy when you are happy about the rest of p-c [22:14:42] eileen1: sure, the rest of it looks fine now! [22:18:12] eileen1: ok, that's all set [22:19:12] now I'm confused - did you deploy already or did I just deploy [22:19:21] !log process-control updated to 9c8b4bb1849f49e7a698107c09324b35b9b9d212 [22:19:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:20:47] hheh, one way or another it's out there! [22:34:30] ejegg: oddly enough this query doesn't return a deleted contact select * FROM civicrm_mailing_provider_data WHERE event_type IN ( 'Opt Out', 'Reply Abuse', 'Suppressed') AND is_civicrm_updated = 0 LIMIT 1; [22:35:09] oh? [22:35:18] Weird, so where did the failing one go? [22:37:16] not sure - will see if I can test on staging although it may be too out of date [22:38:04] (PS1) Ejegg: Use shell-safe verp when not making CiviMail records [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387953 [22:40:51] (PS2) Ejegg: Use shell-safe verp when not making CiviMail records [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387953 [22:42:48] cwd cool, the failmail suppression is working - just got a 'timed out' failmail without the corresponding 'aborting next run' failmail [22:42:56] now I just need to adjust those timeouts [22:47:14] k, that's dedupe's timeout adjusted to 55 min [22:47:32] ejegg: maybe we should schedule a backup to staging & then I can test the unsubscribes on staging [22:47:44] (might make sense to turn them off until then [22:47:45] yeah, sounds good! [22:47:56] ok, I'll turn it off for now [22:48:09] cwd - I should log a ticket to get staging DB updated [22:49:24] !log disabled fundraising unsubscribe import processing [22:49:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:51:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: process unsubscribes job is failing - https://phabricator.wikimedia.org/T179547#3728244 (Eileenmcnaughton) [22:53:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Update staging DB to be up-to-date with live - https://phabricator.wikimedia.org/T179548#3728259 (Eileenmcnaughton) [22:53:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Update staging DB to be up-to-date with live - https://phabricator.wikimedia.org/T179548#3728259 (Eileenmcnaughton) [22:57:29] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: process unsubscribes job is failing - https://phabricator.wikimedia.org/T179547#3728277 (Eileenmcnaughton) @Ejegg you beat me to turning it off! [22:58:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: process unsubscribes job is failing - https://phabricator.wikimedia.org/T179547#3728281 (Eileenmcnaughton) related https://phabricator.wikimedia.org/T161761 [23:02:09] eileen the mailing data fetch failure is weird: 'no data found for trigger id XXXYYY' [23:02:26] is that something from the Silverpop API? [23:03:44] ejegg: yeah so the issue there is that the job had not been run for a long time [23:03:58] & it was asking silverpop for a job that silverpop had deleted I think [23:04:06] ah, got it [23:04:12] I've reset it to be date-based [23:04:17] just waiting to see it run again [23:04:30] but, that fail should be noisier so I should log to look at that [23:04:40] or did we get a failmail? [23:04:59] ah we did - all good! [23:05:45] that drush civi-api fix should have been done years ago - the commenters upstream were all like 'Yeah we need this" [23:06:36] :) awesome! [23:07:36] 10 minute wait to see how it runs now [23:08:15] btw leannes came back on those new links in the email querying that the first link still goes to the deleted contact - is that as intended? [23:09:46] Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review: New thank you email for big english 2017 - https://phabricator.wikimedia.org/T177878#3728313 (Ejegg) @Jrobell How about that subject... [23:11:55] eileen1: yeah, we didn't do any checking for deleted, just added another link [23:12:00] thalso, the contact isn't deleted when we send the email! [23:13:49] well, i'm going to head out for the evening [23:13:55] have a good one! [23:24:44] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Fix 'the silence of the crons' - https://phabricator.wikimedia.org/T179358#3722185 (Eileenmcnaughton) Open>Resolved Our failmail tells us this is fixed! [23:25:00] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Start date being overwritten on recipient retrieval cron, resulting in some job fails - https://phabricator.wikimedia.org/T179357#3722173 (Eileenmcnaughton) Open... [23:36:17] I'm running a job that is deleting a large number of rows from a log table - in case there is any server impact