[00:06:32] eileen1: hi! [00:08:56] cwd hey [00:09:39] how goes? [00:10:07] not bad - you? [00:10:20] just fine thanks [00:10:26] was about to fire off that staging db restore [00:10:35] is now a good time? [00:10:42] yeah go for it [00:11:10] eileen1: there was a file dangling in this dir, dev_civicrm_20170628_extra_tables.sql.gz [00:11:21] but i don't see it in the backups...know what that's about? [00:12:16] nope = can't recall [00:13:18] heh cool [00:13:25] i'll just do civi and drupal then [00:13:28] yep [06:20:41] (PS2) Eileen: Add dedupetools extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389650 (https://phabricator.wikimedia.org/T177999) [06:20:43] (PS2) Eileen: Tidy up dedupe rules & install dedupetools. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389651 (https://phabricator.wikimedia.org/T177999) [09:46:51] Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review: New thank you email for big english 2017 - https://phabricator.wikimedia.org/T177878#3740063 (jrobell) @Ejegg Let's skip the period as... [12:35:29] morning everyone [14:15:27] jgleeson: morning!! [14:17:44] morning jgleeson! [14:17:48] and AndyRussG! [14:21:37] morning morning mepps & AndyRussG :) [14:22:14] mepps: hey! [14:22:21] :) [14:27:26] mepps: jgleeson: ejegg|away: able meet for that Prometheus/Grafana overview at 8:00 am Pacific Time (i.e., in about 1 1/2 hours)? [14:27:44] that would work for me! [14:27:45] (another time that's more convenient for you is also cool, of course) [14:28:22] AndyRussG: sure! [14:28:42] mepps: jgleeson: fantastic thanks!!! [14:41:02] fr-tech K put it on everyone's calendars ^ (anyone I didn't ask, who's not interested/available, pls ignore.....) thanks!!! [14:58:43] ejegg: hi!!! :) ^ [15:00:00] hi AndyRussG [15:01:05] hey ejegg, good long weekend? [15:01:23] amazing! [15:01:45] awesome, what did you get up to? [15:01:55] machu picchu! [15:02:07] so much more extensive than I though [15:02:08] let me google that :) [15:02:11] *thought [15:02:56] whoa awesome [15:05:54] looks like a very interesting place [15:06:05] got a ridiculous amount of pictures to upload... [15:13:04] the only notable ruins site I've visited is Pompeii, that was really interesting to see. [15:15:34] oh wow! [15:15:48] restoring civi staging dbs fyi [15:22:23] (PS1) Ejegg: WIP thank you sender is a queue consumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389721 (https://phabricator.wikimedia.org/T172300) [15:26:32] (CR) jerkins-bot: [V: -1] WIP thank you sender is a queue consumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389721 (https://phabricator.wikimedia.org/T172300) (owner: Ejegg) [15:29:59] has anyone has issues bringing up the mediawiki vagrant machine due to broken .config/google-chrome symlinks crashing the rsync process? [15:30:09] had* [15:30:21] weird, nothing I've heard of! [15:30:50] yeah it's really random, I can find results online of similar issues but no idea why it's suddenly started happening [15:31:16] so... this is .config/google-chrome in the vagrant user's directory? [15:31:17] I was just going to clear the directories but then read up that google uses chrome config to store remote desktop user info, which I'm using [15:31:24] or in the real user's? [15:31:44] it appears to be syncing the active home directory with /vagrant [15:32:13] actually [15:32:18] (PS2) Ejegg: New TY email subject line [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/384726 (https://phabricator.wikimedia.org/T177878) [15:32:19] I've worked out what's wrong [15:32:27] jgleeson: whoa, is that normal? [15:33:01] (PS3) Ejegg: New TY email subject line [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/384726 (https://phabricator.wikimedia.org/T177878) [15:33:24] I have a symlink in my own home directory to get to the civi project folders quicker. My projects are all stored within home/jack/projects/wiki/* so to save navigating each time I set that up [15:33:25] (CR) Ejegg: [C: 2] New TY email subject line [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/384726 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg) [15:33:39] I bet this issue is due to where I'm running vagrant up from [15:33:45] ah, got it [15:33:47] I'll try browsing to the full path [15:36:20] (Merged) jenkins-bot: New TY email subject line [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/384726 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg) [15:37:23] yep that worked [15:37:53] sometimes I need to type out a problem and view all the context in one place to work out what's wrong :) [15:38:01] it would seem [15:38:43] heh, otherwise known as the 'rubber duck' strategy [15:38:54] i.e. explain your problem to a rubber duck [15:39:00] lol :P) [15:39:06] :) * [15:39:07] or a person that may have no idea what you're talking about [15:40:36] now that's a coincidence [15:40:48] I was just looking over The Pragmatic Programmer [15:40:55] jgleeson: oh hey, is your packagist username jackgleeson? [15:41:20] In software engineering, rubber duck debugging or rubber ducking is a method of debugging code. The name is a reference to a story in the book The Pragmatic Programmer in which a programmer would carry around a rubber duck and debug their code by forcing themselves to explain it, line-by-line, to the duck. [15:41:40] hmm, not found. let me know when you have that set up and I'll add you as a maintainer [15:41:52] ah, is that where it came from? [15:42:03] Plenty of other good stuff in that book? [15:46:29] I think it's got a lot of good information in, albeit a little dated. It's something I bought very early on in my career and didn't really take it much first time round. However I find myself referring to it for advice on general subjects. This morning I was reading about refactoring [15:46:49] I've also created the account 'jackgleeson' on packagist [15:46:51] heh, whatever for? :) [15:46:59] * (the refactoring) [15:47:04] :) [15:47:28] cool, adding you to th smash-pig and donation-interface maintainers [15:47:58] there's not much to it, mostly just hit 'update' now and then [15:49:06] I also realised this morning, when looking at putting my stats utility to use, that I didn't take on board first time round how the current process works [15:49:34] I wasn't searching for the right functions :) [15:49:59] oh really? What was missing? [15:53:16] I was focusing on instances of metrics_reporting_report_metrics() without too much context of the goings on around this method. This morning I was searching for methods on the $counter object, one being addAgeMeasurement() and it made me realise I didn't see the different modules first time round [15:53:21] using that same method multiple times [15:53:47] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising: Look at using Lua for donatewiki - https://phabricator.wikimedia.org/T87669#3741615 (Pcoombe) p:Triage>Low [15:57:15] When you have time can I chat to you for 5 minutes after the Prometheus/Grafana call. I *think* I understand it a little better now so just want to go through what I plan to do next and how I plan to introduce the little utility I've added [15:57:38] ejegg ^ [16:28:53] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, and 3 others: Registering test in impressions - https://phabricator.wikimedia.org/T176334#3741708... [16:29:46] fundraising-tech-ops: fundraising-puppetize HP RAID software rename from hpssacli to ssacli - https://phabricator.wikimedia.org/T179719#3741738 (Jgreen) Open>Resolved a:Jgreen commit 135aeeb1bae91da490cf8f98f15594aa470eeef7 Author: Jeff Green Date: Tue Nov 7 11:22:38 2017... [17:14:31] (PS1) Ejegg: Update donation-interface for new ty message subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389737 (https://phabricator.wikimedia.org/T177878) [17:27:01] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, and 3 others: CiviCRM dedupe jobs should grace... - https://phabricator.wikimedia.org/T172303#3741930 [17:27:16] Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: donatewiki_counts and banner impre... - https://phabricator.wikimedia.org/T177331#3741932 [17:27:32] Fundraising Sprint Uptight Piano, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, Patch-For-Review: Generic orphan rectifier needs to handle contribution tracking - https://phabricator.wikimedia.org/T176376#3741936 (mepps) Open>Resolved a:... [17:31:39] Fundraising-Backlog: Track rate of new successful donations created at the payments cluster, in prometheus - https://phabricator.wikimedia.org/T179215#3717077 (Ejegg) Oh hey, looks like we ARE already counting this correctly after all. The donations queue consumer is only incrementing counts on real donation... [17:32:05] Fundraising-Backlog: Track rate of new successful donations created at the payments cluster, in prometheus - https://phabricator.wikimedia.org/T179215#3741971 (Ejegg) oops, wrong ticket... [17:35:52] Fundraising Sprint Uptight Piano, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Upgrade to QUnit 2 - https://phabricator.wikimedia.org/T179198#3716673 (AndyRussG) Open>Resolved [17:40:16] Fundraising Sprint V 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add link to contact on Contribution View page - https://phabricator.wikimedia.org/T179864#3742005 (DStrine) [17:40:18] Fundraising Sprint V 2017, Fundraising-Backlog: Review emergency procedures for holidays - https://phabricator.wikimedia.org/T179843#3742007 (DStrine) [17:40:21] Fundraising Sprint V 2017, Fundraising-Backlog: Support MG event in LA on the 15th - https://phabricator.wikimedia.org/T179853#3742006 (DStrine) [17:40:23] Fundraising Sprint V 2017, Fundraising-Backlog: Scope Kafkatee replacement and break out tasks - https://phabricator.wikimedia.org/T179841#3742009 (DStrine) [17:40:25] Fundraising Sprint V 2017, Fundraising-Backlog: Track fundraising failmail volume in prometheus - https://phabricator.wikimedia.org/T179704#3742010 (DStrine) [17:40:29] Fundraising Sprint V 2017, Fundraising-Backlog: Scope and create tasks for Prometheus work - https://phabricator.wikimedia.org/T179842#3742008 (DStrine) [17:40:33] Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising-Backlog: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3742012 (DStrine) [17:40:35] Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Geolocation - https://phabricator.wikimedia.org/T179344#3742011 (DStrine) [17:40:38] Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising-Backlog: Prometheus: Add seconds diff metric report [donation message enqueued => donation saved to civi] - https://phabricator.wikimedia.org/T179173#3742013 (DStrine) [17:40:40] Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Improve major gifts email links when a contact has already been merged so there is not a findy-game - https://phabricator.wikimedia.org/T178000#3742016 (... [17:40:42] Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Consolidate typical analytics queries (for example, for impression rates) into a library - https://phabricator.wikimedia.org/T178930#3742014 (DStrine) [17:40:45] Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Make it easier to move from contact deleted by merge to the contact they were merged to - https://phabricator.wikimedia.org/T178003#3742015 (DStrine) [17:40:47] Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Add link to contact summary to assist in finding & deduping the contact - https://phabricator.wikimedia.org/T177999#3742017 (DStrine) [17:40:49] Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising-Backlog, FR-Adyen, and 3 others: Adyen jobs should retry at least once on connect failure - https://phabricator.wikimedia.org/T177893#3742018 (DStrine) [17:40:51] Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, and 2 others: Implement concept of 'load' action to dedupe (& api in general) - https://phabricator.wikimedia.org/T177882#3742019... [17:40:53] Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review: Still an issue in merge screen display -not showing all... - https://phabricator.wikimedia.org/T177873#3742021 [17:40:55] Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, and 2 others: New thank you email for big english 2017 - https://phabricator.wikimedia.org/T177878#3742020 (DStrine) [17:40:57] Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, and 4 others: Improve conflict handling by doing postal... - https://phabricator.wikimedia.org/T177807#3742022 [17:41:00] Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 4 others: Epic: Don't duplicate contact for email donations - https://phabricator.wikimedia.org/T177663#3742025 (DStrine) [17:41:04] Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, and 4 others: adyen cookie error after entering informa... - https://phabricator.wikimedia.org/T176913#3742029 [17:41:07] Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, and 3 others: Validation not clearing error on blur - https://phabricator.wikimedia.org/T176501#3742030 (... [17:41:09] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint V 2017, and 4 others: Registering test in impressions - https://phabricator.wikimedia.org/T176334#3742031 (DStrine) [17:41:11] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, and 6 others: Investigate email: BH data storage/transfer issue for iPad donations - https://phabricator.wikimedia.org/T174719#3742034 (DStrine) [17:41:14] Fundraising Sprint V 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Civi Import - https://phabricator.wikimedia.org/T172423#3742035 (DStrine) [17:41:16] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, and 7 others: CN Campaign Suppression prior to scheduled start time - https://phabricator.wikimedia.org/T175358#3742033 (DStrine) [17:41:19] Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, and 10 others: Create orphan rectifier for PayPal Express Checkout - https://phabricator.wikimedia.org/T172202#3742036 (DStrine) [17:41:22] Fundraising Sprint V 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Create a way to view the history of address records (dedupe follow up task) - https://phabricator.wikimedia.org/T142549#3742037 (DStrine) [18:06:41] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3717061 (Ejegg) Oh hey, looks like we ARE already counting this correctly af... [18:08:45] brb [18:14:34] ejegg do you have time for a quick chat? [18:15:30] jgleeson: sure, give me 5 min and i'll hop in the usual chat [18:15:38] great, see you there [18:22:34] ejegg: and mepps MG is having some trouble with smart groups. I'm wondering if you have any feedback on the thread "Accessing smart group memberships" [18:23:54] i haven't had to look up smartgroups directly in the db. If this is a bug it might need to get unbreak now status [18:33:36] ejegg: Here’s the fun article I mentioend we might use as our bible / papel higenico … https://www.confluent.io/blog/messaging-single-source-truth/ [18:34:51] i'll take a look dstrine [18:35:47] thanks mepps !! [18:43:50] Wikimedia-Fundraising, Design: Redesign of the ‘Thank You’ Page - https://phabricator.wikimedia.org/T179713#3742283 (schoenbaechler) I've moved the page to Collab today. Here's the link: https://collab.wikimedia.org/wiki/2017_Thank_You_Page **Some notes** - I've changed the share behavior: it now opens... [18:55:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Access denied for error log files - https://phabricator.wikimedia.org/T179969#3742335 (LeanneS) [19:25:39] I'm gonna wrap up for today [19:25:44] have a great day everyone [19:25:50] see you all again tomorrow o/ [19:28:12] dstrine-lunch [19:50:56] (CR) Ejegg: [C: 2] Update donation-interface for new ty message subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389737 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg) [19:55:45] (PS1) Ejegg: Update English thank you letter for 2017 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389789 (https://phabricator.wikimedia.org/T177878) [19:56:14] (Merged) jenkins-bot: Update donation-interface for new ty message subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389737 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg) [19:58:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Update staging DB to be up-to-date with live - https://phabricator.wikimedia.org/T179548#3742502 (cwdent) a:cwdent [19:59:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Update staging DB to be up-to-date with live - https://phabricator.wikimedia.org/T179548#3728259 (cwdent) I tried to import yesterday's dump but the drupal one produced a syntax error on a line with over a million characters so... [20:12:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Update staging DB to be up-to-date with live - https://phabricator.wikimedia.org/T179548#3742581 (Eileenmcnaughton) Wow! That could be an issue in a real restore too. From my pov the civicrm db is more important, but it's also... [20:14:31] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, and 6 others: Investigate email: BH data storage/transfer issue for iPad donations - https://phabricator.wikimedia.org/T174719#3742598 (Mpany) @AndyRus... [20:42:59] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Geolocation - https://phabricator.wikimedia.org/T179344#3721694 (Eileenmcnaughton) @DStrine if this is 'done enough for BE but we should revisit next year... [20:44:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Access denied for error log files - https://phabricator.wikimedia.org/T179969#3742670 (Eileenmcnaughton) @LeanneS does it only relate to this file "1 - Oct'17_JPM EUR GBP_errors.181" ? I suspect the apostrophe in the url might be causing problems [20:46:39] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Civi Import - https://phabricator.wikimedia.org/T172423#3742677 (Eileenmcnaughton) a:Eileenmcnaughton [20:49:37] (PS6) Mepps: Script to update old activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003) [20:50:18] hey ejegg i have two patches that could use review [20:50:34] sure thing mepps [21:02:52] (CR) Ejegg: "Looks super efficient! Think there's an extra change committed tho - guess that earlier update was breaking on your machine?" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003) (owner: Mepps) [21:03:46] (PS7) Mepps: Script to update old activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003) [21:03:48] (PS5) Ejegg: When undelete is true, add new contact as assignee for merged contact activity record [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/386624 (https://phabricator.wikimedia.org/T178003) (owner: Mepps) [21:03:59] (CR) Ejegg: [C: 2] When undelete is true, add new contact as assignee for merged contact activity record [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/386624 (https://phabricator.wikimedia.org/T178003) (owner: Mepps) [21:10:21] (Merged) jenkins-bot: When undelete is true, add new contact as assignee for merged contact activity record [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/386624 (https://phabricator.wikimedia.org/T178003) (owner: Mepps) [21:12:09] mepps: what is with that please reply thread - is someone parsing ALL those responses? [21:12:33] yeah eileen--it's weird! i only responded after i saw you had :) [21:13:00] well so many people had been. but?? [21:14:48] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Geolocation - https://phabricator.wikimedia.org/T179344#3742801 (DStrine) if @jkim_wikimedia is cool with it, then I'd say close this and we'll open anothe... [21:19:30] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Geolocation - https://phabricator.wikimedia.org/T179344#3742813 (jkim_wikimedia) Hey @DStrine and @Eileenmcnaughton , thanks for your work on this! We fini... [21:19:48] dstrine: now I don't know from her response if it workied for them or they just didn't use it :-) [21:20:49] eileen: it sounds like they didn't use it. [21:20:59] (PS8) Ejegg: Script to update old activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003) (owner: Mepps) [21:21:06] :-( [21:21:11] (CR) Ejegg: [C: 2] Script to update old activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003) (owner: Mepps) [21:21:17] I did let her know by email at the time [21:21:37] eileen: we might as well keep what you just created. I'm not sure if they will need it again during BE. [21:21:43] but it's better than nothing [21:22:18] dstrine yeah it's deployed anyway [21:22:24] cool [21:22:36] mepps: looks like my line 3132 will conflict with your patch :-) https://gerrit.wikimedia.org/r/#/c/389651/2/sites/all/modules/wmf_civicrm/wmf_civicrm.install [21:27:27] (Merged) jenkins-bot: Script to update old activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003) (owner: Mepps) [21:28:11] ahh elieen, can you rename? [21:28:40] ejegg are you seeing the failmail? [21:29:00] mepps: oops, checking! [21:29:40] mepps: yours is merged now so I can remove from my patch [21:30:02] I meant the hobbled function - not the fn name [21:30:31] i deleted the commented out lines in mine--did it merge with that still in there? [21:30:43] yours seems like a better fix, just in terms of clarity [21:31:47] mepps I'd like to do a civi deploy for the new thank you letter [21:32:23] okay, do you want to wait on my patches, or include them? do you want a shadow? i'm here for another half hour [21:32:55] I'll include 'em [21:33:04] cool ejegg [21:33:50] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389825 [21:35:08] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389825 (owner: Ejegg) [21:36:05] (PS3) Eileen: Add dedupetools extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389650 (https://phabricator.wikimedia.org/T177999) [21:36:08] (PS3) Eileen: Tidy up dedupe rules & install dedupetools. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389651 (https://phabricator.wikimedia.org/T177999) [21:36:09] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389825 (owner: Ejegg) [21:39:33] I added a minor function into this extension https://gerrit.wikimedia.org/r/#/c/389651/ which I have only used on staging for analysis before. It seemed like the right place to consolidate wmf-specific merge related stuff - but I'm worried that it will look like a big scary thing to review when it's a very small function I'm wanting to deploy [21:39:53] sorry this one https://gerrit.wikimedia.org/r/#/c/389650/ [21:47:12] d'oh, forgot the vendor update... [21:48:13] (PS1) Ejegg: Update donation-interface [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/389849 [21:48:26] (CR) Ejegg: [C: 2] Update donation-interface [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/389849 (owner: Ejegg) [21:49:14] (PS1) Ejegg: Update vendor [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389850 [21:49:22] (CR) Ejegg: [C: 2] Update vendor [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389850 (owner: Ejegg) [21:52:11] (Merged) jenkins-bot: Update donation-interface [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/389849 (owner: Ejegg) [21:55:30] (Merged) jenkins-bot: Update vendor [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389850 (owner: Ejegg) [21:56:07] !log updated CiviCRM from dc9d054169a196ab14f6a4070e871c2dd8580ad4 to 122ba657ba347c02a3f5e3c689bb5acbce6e7364 [21:56:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:56:17] ok, sending a test ty mail [21:58:26] looks good! turning the job back on [21:58:34] mepps, i'll run your update next [22:00:58] whoa, that was really fast [22:01:15] shoot, running that select on staging [22:03:03] mepps oh shoot, that loop condition is a bit off :( [22:03:54] sorry, bad code review [22:08:10] (CR) Ejegg: "Sorry, I should have reviewed better :(" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387311 (https://phabricator.wikimedia.org/T178003) (owner: Mepps) [22:12:29] (CR) Ejegg: [C: 2] Update English thank you letter for 2017 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389789 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg) [22:15:35] (PS1) Ejegg: Update English thank you letter for 2017 [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389873 (https://phabricator.wikimedia.org/T177878) [22:16:17] (Merged) jenkins-bot: Update English thank you letter for 2017 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389789 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg) [22:21:53] (CR) Ejegg: [C: 2] Update English thank you letter for 2017 [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389873 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg) [22:23:08] (Merged) jenkins-bot: Update English thank you letter for 2017 [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389873 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg) [22:23:10] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389874 (owner: Ejegg) [22:28:20] !log updated CiviCRM from 122ba657ba347c02a3f5e3c689bb5acbce6e7364 to 85e89c657bbfcaffc42f66a4f26aa6e9686a989e [22:28:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:33:37] argh, unsubscribe link is broken [22:33:42] reverting ty update [22:35:42] (PS1) Ejegg: Revert "Update English thank you letter for 2017" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389877 [22:35:44] (PS1) Ejegg: Revert "Update donation-interface for new ty message subject" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389878 [22:35:46] (CR) Ejegg: [C: 2] Revert "Update English thank you letter for 2017" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389877 (owner: Ejegg) [22:35:50] (CR) Ejegg: [C: 2] Revert "Update donation-interface for new ty message subject" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389878 (owner: Ejegg) [22:38:26] (PS1) Ejegg: Revert "Update vendor" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389879 [22:38:28] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389880 [22:38:34] (CR) Ejegg: [C: 2] Revert "Update vendor" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389879 (owner: Ejegg) [22:38:39] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389880 (owner: Ejegg) [22:39:48] (Merged) jenkins-bot: Revert "Update English thank you letter for 2017" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389877 (owner: Ejegg) [22:42:36] (Merged) jenkins-bot: Revert "Update donation-interface for new ty message subject" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389878 (owner: Ejegg) [22:42:38] (Merged) jenkins-bot: Revert "Update vendor" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389879 (owner: Ejegg) [22:42:40] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389880 (owner: Ejegg) [22:44:46] (PS1) Ejegg: Revert "Update English thank you letter for 2017" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389882 [22:44:59] (CR) Ejegg: [C: 2] Revert "Update English thank you letter for 2017" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389882 (owner: Ejegg) [22:45:26] uff, why is this so hard for me today? [22:45:46] (Merged) jenkins-bot: Revert "Update English thank you letter for 2017" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/389882 (owner: Ejegg) [22:49:08] !log updated CiviCRM from 85e89c657bbfcaffc42f66a4f26aa6e9686a989e to dc1b2798a051019177de3adf5f7e93fb95148ccf [22:49:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:50:44] !log re-enabled thank you mailer [22:50:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:51:25] so long!