[03:06:26] <wikibugs>	 (CR) Ejegg: "This ends up as the return-path header in the email. After a security patch last winter, phpmailer started checking to make sure the retur" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387953 (owner: Ejegg)
[03:06:54] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3743416 (Ejegg) Open>Invalid
[03:06:56] <wikibugs>	 Fundraising-Backlog, Epic: EPIC: Prometheus Metric Suggestions - https://phabricator.wikimedia.org/T179179#3743417 (Ejegg)
[03:08:25] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, and 2 others: New thank you email for big english 2017 - https://phabricator.wikimedia.org/T177878#3673642 (Ejegg) p:...
[05:34:50] <wikibugs>	 (PS1) TerraCodes: git.wikimedia.org -> phab [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/389915 (https://phabricator.wikimedia.org/T139089)
[11:26:47] <wikibugs>	 (Abandoned) Jgleeson: Rename componentNS property to StatsNS as component doesn't really fit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387351 (owner: Jgleeson)
[11:26:54] <wikibugs>	 (Abandoned) Jgleeson: Added metric to track difference between message enqueue time and donation save to civicrm time. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/386971 (owner: Jgleeson)
[11:26:58] <wikibugs>	 (Abandoned) Jgleeson: add inital StatsCollector stub class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387244 (owner: Jgleeson)
[11:27:02] <wikibugs>	 (Abandoned) Jgleeson: Added documentaton to WIP Statistics Collector object and added stubs for its dependencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387245 (owner: Jgleeson)
[11:27:05] <wikibugs>	 (Abandoned) Jgleeson: added some minor updates around namespace container getters and setters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387300 (owner: Jgleeson)
[11:27:09] <wikibugs>	 (Abandoned) Jgleeson: added initial implementation of methods to bring design to life [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387312 (owner: Jgleeson)
[11:27:12] <wikibugs>	 (Abandoned) Jgleeson: fixed some obvious wiring up problems / added exceptions to phase two behaviour [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387319 (owner: Jgleeson)
[11:27:15] <wikibugs>	 (Abandoned) Jgleeson: Added exception for is_incrementable() failure / updated docblocks [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387346 (owner: Jgleeson)
[11:27:19] <wikibugs>	 (Abandoned) Jgleeson: clean up is_incrementable() arguements and docbloc [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387347 (owner: Jgleeson)
[14:17:41] <jgleeson>	 morning mepps :)
[14:34:17] <ejegg>	 hi mepps and jgleeson
[14:35:31] <jgleeson>	 Morning ejegg
[14:39:22] <mepps>	 Hi ejegg and jgleeson!
[14:45:28] <jgleeson>	 morning mepps :)
[14:47:25] <ejegg>	 So, I put off the rollout of the TY email yesterday because I thought the unsubscribe link was broken
[14:48:10] <ejegg>	 but now I think the unsub links from test TY emails were never supposed to work
[14:48:44] <ejegg>	 Anyone want to learn about one of our lesser-known mediawiki extensions?
[14:49:15] <ejegg>	 https://github.com/wikimedia/mediawiki-extensions-FundraisingEmailUnsubscribe
[14:49:28] <ejegg>	 Is our self-hosted unsubscribe page
[14:49:49] <ejegg>	 It expects qs params for email address, contribution ID, and a hash
[14:50:45] <ejegg>	 there's a secret salt shared between the thank you module which creates the links, and
[14:50:58] <ejegg>	 the settings on the payments servers, which host the unsubscribe page
[14:51:34] <ejegg>	 fr-tech some random info in case of curiousity ^^^
[14:52:21] <ejegg>	 So we hash the contribution ID and the email address along with the salt, and check if the
[14:52:47] <ejegg>	 hash param matches. If so, we drop a message into the unsubscribe queue.
[14:53:59] <mepps>	 i can look into unsubscribe ejegg
[14:54:16] <jgleeson>	 so is the comparison of the hash failing due to the test environment?
[14:55:04] <ejegg>	 By 'test thank you email', I mean an email sent from the production server via the form at /admin/config/thank_you/test
[14:55:38] <ejegg>	 that form takes a bunch of parameters for a fake donation, fills out the email template, and sends it off
[14:55:59] <ejegg>	 but it always uses '-1' for the contribution id
[14:57:07] <ejegg>	 The problem is that this constraint on the unsubscribe page doesn't allow anything but digits:
[14:57:10] <ejegg>	 https://github.com/wikimedia/mediawiki-extensions-FundraisingEmailUnsubscribe/blob/master/methods/FundraiserUnsubscribeThankYou.php#L33
[14:58:12] <ejegg>	 So even if the hash would be fine, we show an error when you click on an unsubscribe link from that test email
[14:58:40] <ejegg>	 I'll make a little patch to allow the minus sign and treat it as a test
[15:03:46] <wikibugs>	 (PS1) Ejegg: Don't error on links from test TY mails [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/389992 (https://phabricator.wikimedia.org/T177878)
[15:04:03] <ejegg>	 lemme just test that locally....
[15:04:43] <wikibugs>	 (CR) Mepps: [C: 2] Don't error on links from test TY mails [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/389992 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg)
[15:05:09] <mepps>	 oops! i +2ed, should I remove it?
[15:05:26] <ejegg>	 heh, we can fix it before we deploy if there are problems
[15:05:28] <wikibugs>	 (CR) Mepps: Don't error on links from test TY mails [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/389992 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg)
[15:05:58] <mepps>	 haha well i removed it and will add it as soon as you test
[15:21:23] <mepps>	 ejegg do you want to give me a sense of what's going on with unsubscribe that you know of?
[15:25:29] <mepps>	 unless that's what you just fixed? sorry i wasn't sure if these were two separate things
[15:25:41] <ejegg>	 mepps I think there's nothing wrong
[15:26:01] <ejegg>	 It's just that the new English thank you letter has an unsubscribe link in the footer
[15:26:15] <wikibugs>	 (CR) Mepps: [C: 2] Don't error on links from test TY mails [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/389992 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg)
[15:26:26] <ejegg>	 and when I tested it yesterday I saw an error page b/c of that regex in the landing page
[15:27:05] <ejegg>	 just wanted to shine a light on that extension for fr-tech folks who hadn't seen it yet
[15:27:14] <mepps>	 ah gotcah ejegg
[15:28:23] <wikibugs>	 (Merged) jenkins-bot: Don't error on links from test TY mails [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/389992 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg)
[15:28:56] <mepps>	 hey ejegg, looks like you approved my change to the Payment class, do you think it needs a test?
[15:30:34] <ejegg>	 mepps shoot, which change was that you mean?
[15:31:18] <mepps>	 hmm ejegg i'm trying to find it..
[15:31:27] <ejegg>	 mepps also, did you see my post-merge comments on https://gerrit.wikimedia.org/r/387311 ?
[15:31:51] <ejegg>	 I should have looked harder at that the first time around :(
[15:32:34] <AndyRussG>	 it's painted light-absorbent black so even shining a light, I still can't see it ;p
[15:32:37] <mepps>	 nope, i see it now! hmm, weird if it's 87, i thikn it's supposed to be a civi constant but i'll take a look
[15:32:55] <wikibugs>	 (PS1) Mepps: On exception, increase count and log error [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893)
[15:33:23] <mepps>	 ejegg ^^ oops i guess i'd just never opened a review--which is why i couldn't find it!
[15:33:43] <mepps>	 i was surprised you'd had no comments--i'm just seeing if it's on the right track
[15:33:53] <ejegg>	 hehe, looking!
[15:40:48] <wikibugs>	 (CR) Chad: [C: 2] git.wikimedia.org -> phab [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/389915 (https://phabricator.wikimedia.org/T139089) (owner: TerraCodes)
[15:41:34] <wikibugs>	 (Merged) jenkins-bot: git.wikimedia.org -> phab [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/389915 (https://phabricator.wikimedia.org/T139089) (owner: TerraCodes)
[15:46:23] <ejegg|brb>	 mepps thanks for the CR! Looks like it works fine on my machine
[15:46:35] <ejegg>	 The ty test code, I mean
[15:47:08] <ejegg>	 taking a look at the SmashPig fix now
[15:59:32] <wikibugs>	 (CR) Ejegg: "Definitely the right direction! Some suggestions inline" (7 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893) (owner: Mepps)
[16:00:30] <ejegg>	 mepps I also responded to your question on https://gerrit.wikimedia.org/r/387953
[16:00:35] <wikibugs>	 fundraising-tech-ops: fundraising_code_update lint localsettings config before deploy - https://phabricator.wikimedia.org/T179340#3744893 (Jgreen)
[16:22:27] <jgleeson>	 fr-tech: is the civi contribution receive_date field  the time when the contribution was recorded in civi or something else?
[16:22:55] <ejegg>	 jgleeson: it's the official date of the transaction, usually according to the payment processor
[16:23:18] <jgleeson>	 thanks ejegg
[16:29:07] <wikibugs>	 (CR) Ejegg: [C: -1] "Looks like a bunch of the validation code is now duplicated. If we're moving the old validation code into the new module, let's stop calli" (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet)
[16:35:19] <wikibugs>	 (PS1) Mepps: Fix activity_type_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390024
[16:43:21] <mepps>	 hey ejegg, fixed your main comment but i tested the loop and it works ^^
[16:43:32] <mepps>	 or i mean fixed the issue with the id
[16:43:49] <wikibugs>	 (PS2) Mepps: Fix activity_type_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390024
[16:52:35] <ejegg|afk>	 mepps sure, it works, but it's going to be pretty slow on production that way!
[16:52:54] <ejegg>	 it fetches 100, fixes the first one, then fetches another 100
[16:53:05] <mepps>	 ahh
[16:53:07] <mepps>	 got it
[16:59:44] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog: Prometheus: Add seconds diff metric report  [donation message enqueued => donation saved to civi] - https://phabricator.wikimedia.org/T179173#3745071 (jgleeson)
[17:02:29] <dstrine>	 AndyRussG:  meeting?
[17:06:38] <wikibugs>	 (CR) Ejegg: "maybe run the type id query once at the start, then use it as a parameter like before?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390024 (owner: Mepps)
[17:34:55] <jgleeson_>	 I just got the seed email for the Wikipedia fundraiser in LA, if only it was in the same country and I could go!! Ken Robinson's talk on education and creativity was the first TED talk I ever saw and it blew me away.
[17:40:20] <wikibugs>	 Wikimedia-Fundraising, Design: Redesign of the ‘Thank You’ Page - https://phabricator.wikimedia.org/T179713#3745175 (Pcoombe) (now looking at the version on https://wikimediafoundation.org/wiki/Thank_You/draft)  The code looks fine. We'll need to remove the "Your donation has been processed", often it ha...
[18:11:17] <dstrine>	 AndyRussG:  random idea: let's say we wanted to tell if someone had some WMF data in their local storage related to CN but did not actually affect the current campaign they were experiencing, could we detect that data? My idea is that you cold actually exclude people from final analysis if it looks like they had cleared their local storage recently.
[18:12:31] <dstrine>	 but this would also exclude anyone who has never been to wikipedia ever before on that machine from one's final analysis
[18:29:41] <ejegg>	 fr-tech any news for scrum of scrums?
[18:41:51] <ejegg>	 AndyRussG: looks like there are some remnants of ruby/selenium tests in CentralNotice, according to rel-eng
[18:42:04] <ejegg>	 T139740
[18:42:07] <stashbot>	 T139740: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740
[18:43:41] <jgleeson_>	 that sounds like a cool project
[18:45:51] <ejegg>	 yeah!
[18:46:06] <ejegg>	 I really want to get some browser tests happening on DonationInterface too
[18:47:32] <jgleeson>	 ejegg you still on the scrum of scrums call?
[18:52:40] <ejegg>	 yep
[18:52:50] <ejegg>	 any last-minute news?
[18:53:12] <jgleeson>	 ah no, just checking to see when I can grab you :)
[18:58:24] <ejegg>	 jgleeson: ok, free now
[18:58:30] <ejegg>	 usual hangout?
[18:59:21] <jgleeson>	 just gonna finish something really quickly and then test it, be about 5 minutes is that okay for you?
[18:59:48] <ejegg>	 yep, see you in 5
[19:02:44] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Access denied for error log files - https://phabricator.wikimedia.org/T179969#3742335 (DStrine) @LeanneS saw the last comment and will test again soon.
[19:07:43] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Access denied for error log files - https://phabricator.wikimedia.org/T179969#3745619 (LeanneS) @Eileenmcnaughton thanks! I currently don't have another import file to test. Could I test with the same file removing the apostrophe? I believe it would cat...
[19:09:08] <jgleeson>	 joining now ejegg
[19:09:12] <jgleeson>	 sorry!
[19:18:50] <AndyRussG>	 ejegg: thanks for the heads-up!
[19:20:25] <AndyRussG>	 dstrine: there might be ways of doing it
[19:21:09] <AndyRussG>	 probably none of them reliable
[19:21:45] <AndyRussG>	 Mainly difficulty in distinguishing people who cleared their storage from those who visit the site infrequently
[19:22:13] <AndyRussG>	 Hmmm though maybe... mmm I dunno, I'd have to dive in to look at some other possibilities
[19:27:53] <wikibugs>	 (CR) AndyRussG: [C: 2] Remove obsolete mockup-template.txt [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/382840 (owner: VolkerE)
[19:30:05] <wikibugs>	 (Merged) jenkins-bot: Remove obsolete mockup-template.txt [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/382840 (owner: VolkerE)
[20:19:42] <wikibugs>	 (PS1) Ejegg: Update FundraisingEmailUnsubscribe extension [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/390079
[20:19:52] <wikibugs>	 (CR) Ejegg: [C: 2] Update FundraisingEmailUnsubscribe extension [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/390079 (owner: Ejegg)
[20:21:17] <ejegg>	 fr-tech going to deploy an update to the unsubscribe extension
[20:26:06] <wikibugs>	 (Merged) jenkins-bot: Update FundraisingEmailUnsubscribe extension [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/390079 (owner: Ejegg)
[20:27:36] <wikibugs>	 Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add link to contact on Contribution View page - https://phabricator.wikimedia.org/T179864#3738574 (Ejegg) Is there supposed to be an associated commit to review?
[20:28:05] <dstrine>	 AndyRussG:  ok just wondering.
[20:29:42] <wikibugs>	 (PS1) Ejegg: Update donation-interface for new ty message subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390080 (https://phabricator.wikimedia.org/T177878)
[20:29:44] <wikibugs>	 (PS1) Ejegg: Update English thank you letter for 2017 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390081 (https://phabricator.wikimedia.org/T177878)
[20:29:46] <wikibugs>	 (PS1) Ejegg: English TY letter updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390082 (https://phabricator.wikimedia.org/T177878)
[20:29:54] <wikibugs>	 (CR) Ejegg: [C: 2] Update donation-interface for new ty message subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390080 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg)
[20:29:58] <wikibugs>	 (CR) Ejegg: [C: 2] Update English thank you letter for 2017 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390081 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg)
[20:33:54] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Access denied for error log files - https://phabricator.wikimedia.org/T179969#3745839 (Eileenmcnaughton) Yes, it should (although I'd probably cut out most of the file before retrying )
[20:36:07] <ejegg>	 !log updated payments-wiki from a539d275377b251762f4935c3014978253f39c08 to d150287f0b64d13589e1af728be0cb5b89f66699
[20:36:12] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[20:37:09] <wikibugs>	 (Merged) jenkins-bot: Update donation-interface for new ty message subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390080 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg)
[20:37:16] <wikibugs>	 (Merged) jenkins-bot: Update English thank you letter for 2017 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390081 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg)
[20:40:09] <wikibugs>	 (PS3) Mepps: Fix activity_type_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390024
[20:40:25] <wikibugs>	 (PS3) Mepps: Use shell-safe verp when not making CiviMail records [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387953 (owner: Ejegg)
[20:40:29] <wikibugs>	 (CR) Mepps: [C: 2] Use shell-safe verp when not making CiviMail records [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387953 (owner: Ejegg)
[20:40:35] <wikibugs>	 (CR) Ejegg: [C: 2] English TY letter updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390082 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg)
[20:41:09] <wikibugs>	 (PS2) Mepps: On exception, increase count and log error [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893)
[20:41:47] <wikibugs>	 (CR) jerkins-bot: [V: -1] Fix activity_type_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390024 (owner: Mepps)
[20:42:25] <mepps>	 ignore that ^^ WIP
[20:43:13] <ejegg>	 k
[20:43:29] <wikibugs>	 (PS3) Mepps: On exception, increase count and log error [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893)
[20:46:25] <wikibugs>	 (Merged) jenkins-bot: Use shell-safe verp when not making CiviMail records [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/387953 (owner: Ejegg)
[20:46:38] <wikibugs>	 (Merged) jenkins-bot: English TY letter updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390082 (https://phabricator.wikimedia.org/T177878) (owner: Ejegg)
[20:48:00] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Follow up to T179344 - more permanent fix for geolocation - https://phabricator.wikimedia.org/T180074#3745867 (Eileenmcnaughton)
[20:48:21] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Geolocation - https://phabricator.wikimedia.org/T179344#3745880 (Eileenmcnaughton) Open>Resolved
[20:49:05] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Geolocation - https://phabricator.wikimedia.org/T179344#3721694 (Eileenmcnaughton) Note that the proximity search was updated to use lat / long so it can b...
[20:49:55] <wikibugs>	 (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/390084
[20:50:05] <wikibugs>	 (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/390084 (owner: Ejegg)
[20:50:55] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/390084 (owner: Ejegg)
[20:52:26] <wikibugs>	 Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add link to contact on Contribution View page - https://phabricator.wikimedia.org/T179864#3738574 (Eileenmcnaughton) @mepps do you feel like the fix should be that we could get to a contact record using this url  ci...
[20:52:31] <ejegg>	 !log turned off donations consumer for ty letter update
[20:52:36] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[20:57:55] <wikibugs>	 (PS1) Ejegg: Fix TY mail test form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390087
[20:58:10] <wikibugs>	 (CR) Ejegg: [C: 2] Fix TY mail test form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390087 (owner: Ejegg)
[21:02:01] <wikibugs>	 (Merged) jenkins-bot: Fix TY mail test form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390087 (owner: Ejegg)
[21:03:46] <wikibugs>	 (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/390088
[21:03:57] <wikibugs>	 (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/390088 (owner: Ejegg)
[21:05:11] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/390088 (owner: Ejegg)
[21:09:06] <ejegg>	 !log updated CiviCRM from b11c59130e7f17425da3024067441a2635fffe55 to ddc388195e1974e17c1f6f3f67f285898c0eb2bb
[21:09:12] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[21:34:41] <ejegg>	 !log re-started donations queue consumer with new thank you letter
[21:34:45] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[21:36:03] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, and 2 others: New thank you email for big english 2017 - https://phabricator.wikimedia.org/T177878#3673642 (Ejegg) ...
[21:42:47] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Update staging DB to be up-to-date with live - https://phabricator.wikimedia.org/T179548#3745975 (cwdent) Open>Resolved Not sure what that was about but the dumps from the next day worked fine.  There seems to be a prob...
[21:42:49] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: process unsubscribes job is failing - https://phabricator.wikimedia.org/T179547#3745977 (cwdent)
[21:45:31] <wikibugs>	 (PS4) Mepps: On exception, increase count and log error [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893)
[21:46:08] <mepps>	 ejegg--i think with these updates i've addressed your comments, but a test may not make sense because makeApiCall is protected?
[21:48:38] <ejegg|afk>	 right, SoapClient seems impossible to test without making requests anyway
[21:56:34] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Update staging DB to be up-to-date with live - https://phabricator.wikimedia.org/T179548#3746010 (Eileenmcnaughton) stylesheets always happens after a DB restore- it's because there is a link to some generated file stored in th...