[00:05:42] off to the east coast, see everyone tuesday! [04:21:25] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Make it easier to move from contact deleted by merge to the contact they were merged to - https://phabricator.wikimedia.org/T178003#3746545 (Eileenmcnaughton) I've... [04:28:05] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Make it easier to move from contact deleted by merge to the contact they were merged to - https://phabricator.wikimedia.org/T178003#3746549 (Eileenmcnaughton) Hmm... [05:08:35] (PS7) AndyRussG: Add API to delay call to record impression [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) [05:11:28] (CR) jerkins-bot: [V: -1] Add API to delay call to record impression [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) (owner: AndyRussG) [05:21:50] (PS8) AndyRussG: Add API to delay call to record impression [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) [05:23:58] (CR) AndyRussG: "> Those are some really creative tests! Just wondering if we get a double impression when the promise resolves AFTER the timeout." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) (owner: AndyRussG) [11:58:11] Wikimedia-Fundraising, Design: Redesign of the ‘Thank You’ Page - https://phabricator.wikimedia.org/T179713#3747422 (schoenbaechler) @Pcoombe Thanks for the feedback. > The code looks fine. We'll need to remove the "Your donation has been processed", often it hasn't at this point hence the "You will rec... [14:04:20] morning jgleeson! [14:10:36] morning mepps :) [14:17:17] MediaWiki-extensions-FundraisingChart, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingChart extension - https://phabricator.wikimedia.org/T178762#3747947 (MarcoAurelio) [14:18:21] Fundraising-Backlog, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3747965 (MarcoAurelio) @hashar Would like confirmation from the Fundraising team that this extension is safe to archive. Thanks. [14:18:44] Fundraising-Backlog, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3747979 (MarcoAurelio) Open>stalled [14:19:12] Fundraising-Backlog, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3701929 (MarcoAurelio) [14:24:48] Wikimedia-Fundraising-Banners, Accessibility: Can't see or click login button due to fundraising banner - https://phabricator.wikimedia.org/T74013#3748025 (TheDJ) Open>Invalid This ticket is from 2014. We probably don't even use that particular banner anymore. Can be reopened if the issue is enco... [14:41:29] Fundraising-Backlog, Cleanup, Repository-Admins: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3748059 (MarcoAurelio) [14:42:52] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add link to contact on Contribution View page - https://phabricator.wikimedia.org/T179864#3748062 (mepps) @Eileenmcnaughton Did you have something to review on here? I'm still working on a patch. I was thinking that... [15:05:58] (PS1) Mepps: Link to contact [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/390256 (https://phabricator.wikimedia.org/T179864) [15:27:55] (PS4) Mepps: Fix activity_type_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390024 [16:21:44] ejegg: new patch set for the dancing record impression feature, in quality cinemas now! [16:22:17] "feature" heheheh /me snickers at unintended pun [16:23:25] great, I'll take a look in a sec! [16:25:36] ejegg: thx! [16:32:42] (CR) Ejegg: [C: -1] "Looking a lot better! Need quotes around a param in the create call, some suggestions." (6 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390024 (owner: Mepps) [16:35:16] (CR) Ejegg: "quote question" (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/390256 (https://phabricator.wikimedia.org/T179864) (owner: Mepps) [16:38:10] Wikimedia-Fundraising, Design: Redesign of the ‘Thank You’ Page - https://phabricator.wikimedia.org/T179713#3748352 (kaythaney) @schoenbaechler -- some copy suggestions: Instead of the "Safeguarding" lead in, perhaps "Ensuring the future of free knowledge: the Wikimedia Endowment" ... with the bottom... [16:39:27] Wikimedia-Fundraising, Design: Redesign of the ‘Thank You’ Page - https://phabricator.wikimedia.org/T179713#3748353 (Nirzar) Looking good! Few minor comments 1. The confirmation line with the green checkmark can occupy the entire line. adding
at the end? 2. Thank you for your gift"!" instead of... [16:47:05] Fundraising-Backlog, Cleanup, Repository-Admins: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3701929 (Ejegg) Hi @MarcoAurelio, can we please reverse this process? This extension is in active use on the payments cluster. [16:52:18] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 4 others: Epic: Don't duplicate contact for email donations - https://phabricator.wikimedia.org/T177663#3748385 (Ejegg) @CCogdill_WMF do you want to try to move forward with... [16:55:04] Fundraising-Backlog, Cleanup, Repository-Admins: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3748399 (Kghbln) I am sorry for triggering this process somehow. The documentation page of this extension was in very bad shape to put it in positive words an... [17:01:21] is anyone else getting This video call isn't available at the moment. Try again in a few minutes. [17:01:26] for the fr-retro call? [17:04:54] (CR) Ejegg: [C: -1] "Looking really good! Just needs fixes to the config calls and loop end logic." (7 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [17:40:27] (PS1) Ejegg: Add authors [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/390278 [17:40:29] (PS1) Ejegg: Add GPL 2.0 license [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/390279 [17:49:07] Fundraising-Backlog, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3748541 (Umherirrender) Readded to mediawiki/extensions, I am not sure, if translatewiki.net is needed, see T75286 Please restore Gith... [18:02:52] off to lunch! [18:51:41] fr-tech / Jeff_Green let's postpone the kafkatee meeting till next week [18:51:53] tuesday at the same time? [18:52:10] sure [19:34:22] Fundraising-Backlog, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3748895 (Ejegg) Sorry, some of the fundraising-only extensions do appear unused, since the payments cluster configuration is not include... [19:54:04] (CR) Ejegg: [C: 2] Add authors [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/390278 (owner: Ejegg) [19:54:24] (CR) Ejegg: [C: 2] Add GPL 2.0 license [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/390279 (owner: Ejegg) [19:56:50] (Merged) jenkins-bot: Add authors [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/390278 (owner: Ejegg) [19:56:52] (Merged) jenkins-bot: Add GPL 2.0 license [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/390279 (owner: Ejegg) [20:03:56] (CR) Ejegg: [C: 1] "The code looks great, and seems to work right. Only one question on the tests - does it matter that we don't reset the recordImpressionDef" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) (owner: AndyRussG) [20:12:30] Fundraising-Backlog, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3749038 (Umherirrender) >>! In T178763#3748895, @Ejegg wrote: > Sorry, some of the fundraising-only extensions do appear unused, since t... [20:13:50] (CR) Mepps: On exception, increase count and log error (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [20:14:58] Wikimedia-Fundraising, Design: Redesign of the ‘Thank You’ Page - https://phabricator.wikimedia.org/T179713#3749041 (cmadeo) Here's a first pass updates to the illustrations: {F10700440 width=500} You can access the sketch file here: https://www.dropbox.com/s/vkv8skd22fnwxyb/Building%20block%20illustrat... [20:15:30] (PS5) Mepps: On exception, increase count and log error [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893) [20:15:52] Fundraising-Backlog, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3749043 (Ejegg) > Would be nice to have it in the multiversion submodules.json list to see that it is a wmf extensions (if possible and... [20:19:30] (CR) Ejegg: [C: -1] "Re: the PHPstorm var claim, that seems like really weird behavior! Still needs a bit of a fix to the loop logic." (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [20:20:56] (PS6) Mepps: On exception, increase count and log error [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893) [20:23:59] (CR) Ejegg: [C: -1] "oops, noticed one more loop thing" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [20:25:24] (PS7) Mepps: On exception, increase count and log error [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893) [20:34:22] (CR) Ejegg: [C: -1] "oops again, one last thing!" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [20:35:19] (PS8) Mepps: On exception, increase count and log error [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893) [20:36:28] (CR) Ejegg: [C: 2] "Awesome, thanks!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [20:37:58] (Merged) jenkins-bot: On exception, increase count and log error [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/389998 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [20:38:38] Fundraising-Backlog, Performance-Team, Readers-Web-Backlog, Performance, Regression: Anonymous fully-loaded and first paint (moving medium) page time significantly increased on 3G Barack Obama en.wiki on November 3rd, 06:00 - https://phabricator.wikimedia.org/T180049#3749133 (Jdlrobson) Addin... [20:49:54] (PS1) Ejegg: Demote error to warning, change WS [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/390306 (https://phabricator.wikimedia.org/T177893) [20:50:14] mepps: I just realized we probably want a different logging level ^^^ [20:50:57] (CR) Mepps: [C: 2] Demote error to warning, change WS [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/390306 (https://phabricator.wikimedia.org/T177893) (owner: Ejegg) [20:52:01] (Merged) jenkins-bot: Demote error to warning, change WS [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/390306 (https://phabricator.wikimedia.org/T177893) (owner: Ejegg) [20:59:24] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, FR-Smashpig, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Amazon code should allow specifiying proxy parameters in configuration - https://phabricator.wikimedia.org/T180168#3749191 (Ejegg) [21:14:18] (PS1) Ejegg: Use PHP-Queue 1.0 [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/390317 [21:18:14] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add link to contact on Contribution View page - https://phabricator.wikimedia.org/T179864#3749223 (Eileenmcnaughton) I can take a look at the bigger fix if you want - although yours is fine as... [21:19:09] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add link to contact on Contribution View page - https://phabricator.wikimedia.org/T179864#3749227 (Eileenmcnaughton) Actually my suggestion fixes something slightly different I think - mine is... [21:21:40] (CR) Ejegg: [C: 2] Use PHP-Queue 1.0 [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/390317 (owner: Ejegg) [21:21:42] (CR) Eileen: [C: -1] "The 'fishnet ' rule is not working as well on staging now as it was prior to the restore - I need to check what has changed" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389651 (https://phabricator.wikimedia.org/T177999) (owner: Eileen) [21:24:44] (Merged) jenkins-bot: Use PHP-Queue 1.0 [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/390317 (owner: Ejegg) [21:31:02] (PS1) Umherirrender: Add stylelint for css file [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/390322 [21:36:06] (PS2) Umherirrender: Add stylelint for css file [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/390322 [21:38:58] (PS5) Mepps: Fix activity_type_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390024 [21:40:09] (CR) Mepps: "Ejegg followed up on most of your comments. However I didn't want to join to activity_contact again because I don't need to select any fie" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390024 (owner: Mepps) [22:11:55] (PS1) Ejegg: Get Amazon SDK object from SmashPig config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/390331 (https://phabricator.wikimedia.org/T180168) [22:18:55] (PS2) Ejegg: Get Amazon SDK object from SmashPig config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/390331 (https://phabricator.wikimedia.org/T180168) [22:20:08] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3749421 (Ejegg) p:Triage>Normal [22:30:06] hey ejegg, I'm about to sign off for tonight. I wanted to get the finished ticket out for code review before I go but.. I've run into a problem, for some reason I can't namespace with the word astropay in it @_@ which makes no sense at all so I will have to debug it tomorrow and work out what's up [22:31:32] wat [22:31:39] jgleeson_: sounds bizarre! [22:31:48] good luck with that [22:32:23] Also, feel free to submit patches to gerrit in any state if they're prefixed with WIP: [22:34:01] okay I'll submit this for now [22:34:27] double sure we want committed broken code? [22:34:46] actually WIP pretty much means that [22:34:47] (PS6) Ejegg: Fix activity_type_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390024 (owner: Mepps) [22:34:51] as you said [22:35:47] (CR) Ejegg: [C: 2] "Thanks! I still feel like the left join ... where id = null would be more performant, but I'm happy to give it a try like this." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390024 (owner: Mepps) [22:36:54] hehe, sure thing! [22:37:04] the depends on thing [22:37:08] do I add that to the commit message? [22:37:12] or within gerrit [22:37:34] as this ticket depends on a smashpig update, with the same branch name [22:37:40] Just at the start of the commit message [22:38:08] oops, sorry [22:38:18] I mean at the foot of the commit message [22:38:27] noooo [22:38:28] lol [22:38:31] okay :) [22:38:54] I really need to stop writing my commit messages on the cli [22:39:03] it's super limited when trying to move text around [22:39:04] Depends-on: Iisdufaiudshf [22:39:30] (PS1) TerraCodes: git.wikimedia.org -> phab [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/390336 (https://phabricator.wikimedia.org/T139089) [22:39:32] hehe, yeah, seems like that would also mean really long lines [22:39:39] (Merged) jenkins-bot: Fix activity_type_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390024 (owner: Mepps) [22:39:58] Iisdufaiudshf = branch or project/branch [22:40:20] jgleeson_: it's actually the Change-Id from the footer of the related SmashPig commit [22:40:30] ah okay [22:42:23] Ok, I will WIP the smashpig branch also as I would feel more comfortable reimporting the donation json messges again to make sure that still works. I'll do that tomorrow [22:42:43] but push what I have now [22:44:54] (PS1) Jgleeson: WIP: Updated behaviour when queue is populated from dump file to detect whether additional info source headers are present and if not inject them [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/390338 [22:45:18] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3749463 (Kghbln) @Ejegg Thanks a lot for explaining and editing. So my usual checks were destined... [22:45:30] (CR) Chad: [V: 2 C: 2] git.wikimedia.org -> phab [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/390336 (https://phabricator.wikimedia.org/T139089) (owner: TerraCodes) [22:45:58] (CR) jerkins-bot: [V: -1] WIP: Updated behaviour when queue is populated from dump file to detect whether additional info source headers are present and if not inject them [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/390338 (owner: Jgleeson) [22:50:14] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3749485 (Ejegg) No worries @Kghbln, it turned out to be a good nudge to fix documentation and do a... [22:50:37] ejegg I am seeing a ton of commits when I do git review which I haven't added [22:51:10] should I be merging master into my branch prior to git review [22:51:17] it's likely a bit out of date [22:52:04] jgleeson_: shoot [22:52:23] so, the thing to do is rebase your branch on top of current master [22:52:58] i.e., git checkout master; git pull (this should be a clean fast-forward, not a merge) [22:53:12] then git checkout yourWorkingBranch; git rebase master; [22:53:24] do I need the --onto flag? [22:53:28] or git rebase -i master; [22:53:37] hmm, i never seem to use that one [22:54:06] okay I will do as you describe [22:54:12] rebase -i will give you a preview of all the things that will get merged [22:54:26] and let you delete ones you don't mean to include [22:56:52] I still have about 20 commits apparently outstanding [22:57:03] when running git review, after the rebase [22:57:07] shoot, are they things you wrote locally? [22:57:26] nope, things like: 2113e55 Always delete 'worse' address [22:57:57] OK, let's try this a different way [22:58:09] your master is now even with origin/master, right? [22:58:17] so let's cut a new branch off of master [22:58:26] git checkout master; git checkout -b newBranch [22:58:44] then just cherry-pick the one commit you want from your old working banch [22:58:59] with git cherry-pick [23:01:45] just resolving some conflicts [23:02:09] on the cherry-pick? [23:02:14] yeah [23:02:17] k [23:03:20] lol [23:03:25] this is crazy [23:03:36] so after that, I still have the big list of commits pending [23:03:37] want to screenshare to work through it? [23:03:40] sure [23:03:44] usual room? [23:04:14] sure, be there in a sec [23:09:40] (PS1) Jgleeson: added first implmentation of new stats collector prometheus behaviour alongside existing donation processor and age prometheus metric reporting code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 [23:09:42] (PS1) Jgleeson: WIP: Added new stats collector implemetation of prometheus tracking for donation count by gateway and donation message age between enqueued to save time Depends-on: I7a0cca729fc2bfc772c8aba1ccaff4aed8fb6816 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390343 [23:13:52] (CR) jerkins-bot: [V: -1] WIP: Added new stats collector implemetation of prometheus tracking for donation count by gateway and donation message age between enqueued to save time Depends-on: I7a0cca729fc2bfc772c8aba1ccaff4aed8fb6816 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390343 (owner: Jgleeson) [23:14:26] (PS2) Jgleeson: First implementation of new stats collector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 [23:14:28] (PS2) Jgleeson: WIP: Added new stats collector implemetation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390343 [23:18:50] (CR) jerkins-bot: [V: -1] WIP: Added new stats collector implemetation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390343 (owner: Jgleeson)