[04:39:04] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, and 6 others: Investigate email: BH data storage/transfer issue for iPad donations - https://phabricator.wikimedia.org/T174719#3571255 (AndyRussG) O... [09:57:25] Fundraising-Backlog, Performance-Team, Readers-Web-Backlog, Performance, Regression: Anonymous fully-loaded and first paint (moving medium) page time significantly increased on 3G Barack Obama en.wiki on November 3rd, 06:00 - https://phabricator.wikimedia.org/T180049#3745038 (Peter) Hi sorry... [11:38:17] Wikimedia-Fundraising, Design: Redesign of the ‘Thank You’ Page - https://phabricator.wikimedia.org/T179713#3754352 (schoenbaechler) @cmadeo Thanks for the feedback. I left the gift's ribbon yellow by intention. As far as I know is “Match your Gift” the second most important action of the page, that's w... [11:53:50] Wikimedia-Fundraising, Design: Redesign of the ‘Thank You’ Page - https://phabricator.wikimedia.org/T179713#3733874 (Nemo_bis) The prototype contains a mistake, "from readers like you". There's no reason to assume the donor is (only) a "reader". [13:28:25] morning jgleeson, AndyRussG! [13:28:35] morning mepps :) [13:28:42] how was your weekend? [13:30:33] it was good thanks. Caught up with all the family yesterday which was good fun, how about yours? [13:36:41] mostly good! although have a cold which is less fun :( [13:39:45] :( [13:54:04] (CR) Mepps: Link to contact (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/390256 (https://phabricator.wikimedia.org/T179864) (owner: Mepps) [13:55:56] mepps jgleeson hey ho! [13:56:10] mepps sorry to hear about the cold [13:56:30] Sofi was sick with a cough much of last week... [14:00:17] yeah James has it too [14:00:48] good news is that we weaned him from his pacifier while sleeping this weekend though! a little rough but he's still sleeping through th enight [14:01:15] hi AndyRussG :) [14:01:17] aww [14:01:20] jgleeson: :) [14:01:35] mepps: hope everyone gets better sooooon [14:01:46] ah jeez, I just spent nearly an hour trying to debug an issue to then discover drush cache :(((( [14:02:03] ahh, been there [14:03:28] yeah that was painful [14:12:36] good news on the pacifier mepps! [14:12:43] We gave in again [14:15:35] Oscar is teething again, we think it's his back teeth now. He was really distressed over the weekend so we gave in .... proving difficult to leave it behind. [14:16:20] (PS3) Mepps: Get Amazon SDK object from SmashPig config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/390331 (https://phabricator.wikimedia.org/T180168) (owner: Ejegg) [14:16:28] (CR) Mepps: [C: 2] Get Amazon SDK object from SmashPig config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/390331 (https://phabricator.wikimedia.org/T180168) (owner: Ejegg) [14:18:46] (Merged) jenkins-bot: Get Amazon SDK object from SmashPig config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/390331 (https://phabricator.wikimedia.org/T180168) (owner: Ejegg) [14:24:19] oooooh teething [14:24:24] yeah that brings back memories! [14:27:32] (PS1) Jgleeson: Updated IDE to use 2 spaces for indents to hopefully fix phpcs issues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/391005 [14:28:31] (CR) jerkins-bot: [V: -1] Updated IDE to use 2 spaces for indents to hopefully fix phpcs issues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/391005 (owner: Jgleeson) [14:38:56] (PS1) Jgleeson: Updated coding style to resolve parenthesis spacing problems [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/391009 [14:58:45] hi fr-tech! [14:58:51] thanks for the CR mepps! [14:59:00] now to add the proxy params in SmashPig... [15:07:29] morning ejegg! [15:11:22] (PS1) Ejegg: Pass proxy parameters to Amazon SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/391018 (https://phabricator.wikimedia.org/T180168) [15:16:22] oh hey, I think that's all we need to try out the Amazon proxy ^^^ [15:24:40] taking a look ejegg [15:24:53] thanks! [15:25:22] (CR) Mepps: Pass proxy parameters to Amazon SDK (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/391018 (https://phabricator.wikimedia.org/T180168) (owner: Ejegg) [15:28:25] (PS1) Jgleeson: WIP added new implementation of stats for donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391021 [15:28:27] (PS1) Jgleeson: Separated out Donation Stats to new DonationsStats.php helper class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391022 [15:28:49] (CR) Ejegg: Pass proxy parameters to Amazon SDK (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/391018 (https://phabricator.wikimedia.org/T180168) (owner: Ejegg) [15:40:13] ejegg what's the best way for me to pull in or work on-top of the patch to record consumer_run_time here https://gerrit.wikimedia.org/r/#/c/381856/3/sites/all/modules/queue2civicrm/queue2civicrm.module should I wait until it gets merged or merge it to my branch, so I can add a message/time ratio [15:42:28] jgleeson: feel free to either merge that and rebase yours on top of it [15:42:41] or just copy the relevant code into your own patch [15:51:03] thanks ejegg [15:51:23] will try rebase [15:53:46] I have my 1:1 with Katie in 10 minutes but afterwards it would be great if I could go over the latest changes to the Prometheus work with you. I think we're done now but want to confirm with you before I start taking over the other instances of the previous implementation. [15:56:44] ok, I might have to relocate from where I am now to do videochat [15:58:34] are you working in a lively space :) [15:59:25] nah, just poor signal :) [16:01:28] ok fr-tech, I'm going to try to intentionally get a failmail on the amazon audit download, to make sure the params are getting passed through [16:48:38] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3755548 (Ejegg) @MarcoAurelio FundraisingChart is actually obsolete, that one can stay archived.... [16:53:11] Fundraising-Backlog, MediaWiki-extensions-FundraisingChart, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingChart extension - https://phabricator.wikimedia.org/T178762#3755572 (Kghbln) >>! In T178762#3752370, @MarcoAurelio wrote: > Checking if we really want this archived... [16:58:15] (CR) Ejegg: [C: 2] Link to contact [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/390256 (https://phabricator.wikimedia.org/T179864) (owner: Mepps) [16:59:43] (CR) Ejegg: "Sorry, this repo is using the mediawiki coding standard, with tabs instead of spaces." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/391005 (owner: Jgleeson) [17:02:13] (Merged) jenkins-bot: Link to contact [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/390256 (https://phabricator.wikimedia.org/T179864) (owner: Mepps) [17:03:45] (CR) Ejegg: "Want to squash these three patches together?" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/391009 (owner: Jgleeson) [17:04:40] (CR) Ejegg: [C: 2] Add stylelint for css file [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/390322 (owner: Umherirrender) [17:06:05] (Merged) jenkins-bot: Add stylelint for css file [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/390322 (owner: Umherirrender) [17:08:49] Fundraising-Backlog, Performance-Team, Readers-Web-Backlog, Performance, Regression: Anonymous fully-loaded and first paint (moving medium) page time significantly increased on 3G Barack Obama en.wiki on November 3rd, 06:00 - https://phabricator.wikimedia.org/T180049#3755624 (Jdlrobson) p:... [17:12:09] ejegg completely agree with you on the inefficiency point, I'll revert it back to instantiating the datastore at the top of the method. [17:12:27] will add comments to gerrit [17:16:01] (CR) Jgleeson: "Completely agree with inefficient $datastore usage, I will revert back to what it was doing previously and being instantiated at the start" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/391009 (owner: Jgleeson) [17:40:22] ejegg hows the signal :) [17:52:53] jgleeson: better here! [17:53:10] wanna go now or wait till after standup? [17:53:26] after standup OK? [17:53:37] sure [18:08:49] Wikimedia-Fundraising, Design: Redesign of the ‘Thank You’ Page - https://phabricator.wikimedia.org/T179713#3755946 (cmadeo) @schoenbaechler Thanks for the clarification with the ribbon! Makes sense! [18:23:18] jgleeson: in 15 minutes ok? food just showed up [18:24:30] yup no problem. Enjoy your food! [18:31:18] ejegg: since you have some repro steps, can you make a bug for the TY email in civi? [18:42:11] dstrine: sure [18:42:18] thanks! [18:43:19] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Google filters test TY emails to spam folder - https://phabricator.wikimedia.org/T180388#3756072 (Ejegg) [18:46:49] (PS1) Ejegg: Use standard 'from' in TY test form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391054 (https://phabricator.wikimedia.org/T180388) [18:47:09] jgleeson: [18:47:19] ready when you are [18:47:27] usual hangout? [18:47:31] sure [18:47:39] see you there [19:06:57] ejegg: hi! when u have a sec, there's a new PS for the record impression change... I think fr-online was hoping for that to be deployed before Wednesday..... ;) thx in advance : [19:06:59] :) [19:07:20] fr-tech also anyone else with a CN itch to scratch ^ [19:07:43] https://gerrit.wikimedia.org/r/#/c/386883/ [19:08:47] hi AndyRussG, taking a look! [19:13:36] ejegg, after our chat I am looking at the code and thinking I could add a new method to workout averages and overalls at the end, before the export. That would probably be more efficient than working them out on every run in a moving average fashion, what do you think? [19:14:02] I think you were suggesting that anyway [19:15:28] ejegg: thx!!! [19:17:45] jgleeson: yeah, I was thinking about that, but I can see reasons to keep the average calculation in exactly the same place as adding the stats [19:18:20] And since it's just some math, not i/o, I'm not super concerned about the efficiency [19:18:39] AndyRussG that's some extensive js testing right there, had to go over it slowly to workout what's going on :) I haven't seen that level of craftsmanship in JavaScript for a while [19:18:42] So whichever way seems to be the cleanest to you works for me [19:22:52] okay great ejegg, I'll stick with the as-is for now and move on getting it finished if the performance saving is negligible. Am I right in thinking that I should add a simple test using processMessage() based on one already there? [19:23:53] jgleeson: sure, just something to make sure the stats-collector codepath ran and didn't blow up! [19:25:30] I forgot to say on the call that the reason it terrifies me to leave tests too long is that I end up writing untestable code, so I find to keep my self in order, I have to test early so I can refactor sooner :) [19:26:03] it's a bad habit of mine [19:40:49] (PS10) Ejegg: Add API to delay call to record impression [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) (owner: AndyRussG) [19:41:04] (CR) Ejegg: [C: 2] "Looks great!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) (owner: AndyRussG) [19:42:15] fr-tech here's a really simple patch to fix the thank you test form 'from' address: https://gerrit.wikimedia.org/r/391054 [19:44:03] (Merged) jenkins-bot: Add API to delay call to record impression [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/386883 (https://phabricator.wikimedia.org/T176334) (owner: AndyRussG) [19:49:38] ejegg i'll take a look! [19:49:54] (CR) Mepps: [C: 2] Use standard 'from' in TY test form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391054 (https://phabricator.wikimedia.org/T180388) (owner: Ejegg) [19:53:01] thanks! [19:53:52] (Merged) jenkins-bot: Use standard 'from' in TY test form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391054 (https://phabricator.wikimedia.org/T180388) (owner: Ejegg) [19:54:35] jgleeson: hey thanks much! I guess we try to be pretty stringent about the client-side JS for CN, since it can run on almost every pageview across sites. This particular change also impacts a really essential bit of our monitoring infrastructure [19:54:43] ejegg: thanks! [19:55:42] jgleeson: ^ testing early actually sounds like good habit! [19:56:01] ah yes, the bad habit is not doing it! :) [19:56:31] sometimes in the past it's easy to "run away" with something and then I test too late and realise I have to chop and change to actually test it :) [19:56:52] I've tried TDD a few times, with mixed success [19:57:11] as a counter measure [19:58:56] ok, i'm going to deploy some CRM stuff [20:00:25] (PS1) Ejegg: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391073 [20:00:52] mepps, I'm about to deploy your activity ID fixes [20:01:03] cool ejegg! [20:02:01] (CR) Ejegg: [C: 2] Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391073 (owner: Ejegg) [20:02:54] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391074 [20:04:06] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391074 (owner: Ejegg) [20:07:23] (Merged) jenkins-bot: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391073 (owner: Ejegg) [20:07:24] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391074 (owner: Ejegg) [20:20:22] (CR) Eileen: [C: 2] Tidy up dedupe rules & install dedupetools. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389651 (https://phabricator.wikimedia.org/T177999) (owner: Eileen) [20:20:27] Hi XenoRyet ! Feeling better? [20:20:27] (CR) Eileen: Tidy up dedupe rules & install dedupetools. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389651 (https://phabricator.wikimedia.org/T177999) (owner: Eileen) [20:20:48] !log updated CiviCRM from ddc388195e1974e17c1f6f3f67f285898c0eb2bb to f571c67ceb353b457f250cc4606cfaa882343e39 [20:20:51] (CR) Eileen: "removed the -1 because the speed issue was during a file restore & seems acceptable today" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389651 (https://phabricator.wikimedia.org/T177999) (owner: Eileen) [20:20:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:22:02] Fundraising-Backlog, Performance-Team, Readers-Web-Backlog, Performance, Regression: Anonymous fully-loaded and first paint (moving medium) page time significantly increased on 3G Barack Obama en.wiki on November 3rd, 06:00 - https://phabricator.wikimedia.org/T180049#3756566 (AndyRussG) Hi! A... [20:23:22] * XenoRyet wonders why IRC has been so quiet this morning [20:23:29] * XenoRyet realizes I forgot to sign in... [20:23:46] Feeling a little better. Enough to attempt some work anyway. [20:24:33] well, glad to hear there's some improvement! [20:25:05] Yea, I'll take what I can get. This one has been just brutal. [20:27:27] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Google filters test TY emails to spam folder - https://phabricator.wikimedia.org/T180388#3756072 (Ejegg) @jrobell Want to try sending yourself another test thank you? The test form used to defa... [20:29:55] mepps ok, re-running the update [20:45:38] Fundraising-Backlog, Performance-Team, Performance, Readers-Web-Backlog (Tracking), Regression: Anonymous fully-loaded and first paint (moving medium) page time significantly increased on 3G Barack Obama en.wiki on November 3rd, 06:00 - https://phabricator.wikimedia.org/T180049#3756624 (Jdlrob... [20:48:12] Fundraising-Backlog, Performance-Team, Performance, Readers-Web-Backlog (Tracking), Regression: Anonymous fully-loaded and first paint (moving medium) page time significantly increased on 3G Barack Obama en.wiki on November 3rd, 06:00 - https://phabricator.wikimedia.org/T180049#3756626 (Jdlrob... [20:50:48] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add link to contact on Contribution View page - https://phabricator.wikimedia.org/T179864#3738574 (Ejegg) Open>Resolved Name is now linked in the 'From' row. Nicely done! [21:09:29] Fundraising-Backlog, fundraising-tech-ops, Operations: reports.frdev.wm.o -- still in use? - https://phabricator.wikimedia.org/T170640#3756669 (Jgreen) >>! In T170640#3449856, @cwdent wrote: > @Ejegg - there are functioning sites at /reports and /webfiledrop, but no real idea if they are still in use... [21:51:51] relocating [23:11:59] ejegg: the question I was wondering about the address history is that I got it going by adding it into the framework of https://github.com/eileenmcnaughton/nz.co.fuzion.extendedreport - which is a collection of Civi reports - now I'm wondering if I should deploy that extension (which includes a lot of report templates we probably don't have much interest in) or just move the address history report out into something of our [23:12:00] s (mepps) [23:12:54] eileen1: was it a lot easier putting it in there? [23:13:06] would it make sense to go in the mergetools? [23:14:40] ejegg: yeah it was easier because there are helper functions - but I can move out [23:14:55] Some of the report helper functions could be usptreamed I think [23:15:28] Hmm, sounds like more than an hour or two's work [23:15:46] yeah [23:15:48] but I guess worth it if they'd be helpful down the road? [23:16:49] well I go back & forwards on it a bit - because I tend to write all sorts of reports into that extension & sometimes I build the extension out & other times I upstream stuff - but I think the upstream could be improved [23:17:37] one thing is that as of next month Civi will stop supporting 5.3 - which means traits can be used to tidy up some of the report stuff [23:31:17] ooh, cool! [23:55:37] katie & I just revisited this … http://wiki.civicrm.org/confluence/display/CRM/Toxic+Code+Protocol