[00:00:00] (CR) Ejegg: [C: 2] "recheck" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/391362 (owner: Ejegg) [00:02:06] (Merged) jenkins-bot: Update vendor submodule for .htaccess [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/391362 (owner: Ejegg) [00:02:45] (PS1) Ejegg: XSS in langconverter when regex hits pcre.backtrack_limit [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391409 (https://phabricator.wikimedia.org/T124404) [00:02:47] (PS1) Ejegg: Make anchor for headlines escape > and < [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391410 (https://phabricator.wikimedia.org/T125163) [00:02:49] (PS1) Ejegg: SECURITY: API: Avoid some silliness with browser-guessed filenames [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391411 (https://phabricator.wikimedia.org/T128209) [00:03:04] (PS1) Ejegg: SECURITY: Do not reveal if user exists during login failure [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391412 (https://phabricator.wikimedia.org/T134100) [00:03:16] (PS1) Ejegg: SECURITY: Ensure Message::rawParams can't lead to XSS [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391413 (https://phabricator.wikimedia.org/T176247) [00:03:18] (PS1) Ejegg: update.php: Remove eval-stdin.php if necessary [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391414 (https://phabricator.wikimedia.org/T180231) [00:03:20] (PS1) Ejegg: Create a .htaccess in /vendor after composer runs [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391415 (https://phabricator.wikimedia.org/T180237) [00:03:23] (PS1) Ejegg: SECURITY: Handle -{}- syntax in attributes safely [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391416 (https://phabricator.wikimedia.org/T119158) [00:03:27] (CR) Ejegg: [C: 2] XSS in langconverter when regex hits pcre.backtrack_limit [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391409 (https://phabricator.wikimedia.org/T124404) (owner: Ejegg) [00:03:29] (CR) Ejegg: [C: 2] Make anchor for headlines escape > and < [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391410 (https://phabricator.wikimedia.org/T125163) (owner: Ejegg) [00:03:32] (CR) Ejegg: [C: 2] SECURITY: API: Avoid some silliness with browser-guessed filenames [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391411 (https://phabricator.wikimedia.org/T128209) (owner: Ejegg) [00:03:35] (CR) Ejegg: [C: 2] SECURITY: Do not reveal if user exists during login failure [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391412 (https://phabricator.wikimedia.org/T134100) (owner: Ejegg) [00:03:39] (CR) Ejegg: [C: 2] SECURITY: Ensure Message::rawParams can't lead to XSS [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391413 (https://phabricator.wikimedia.org/T176247) (owner: Ejegg) [00:03:44] (CR) Ejegg: [C: 2] Create a .htaccess in /vendor after composer runs [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391415 (https://phabricator.wikimedia.org/T180237) (owner: Ejegg) [00:03:46] (CR) Ejegg: [C: 2] SECURITY: Handle -{}- syntax in attributes safely [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391416 (https://phabricator.wikimedia.org/T119158) (owner: Ejegg) [00:07:07] (CR) Ejegg: [C: 2] Disallow web access to /vendor [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/391373 (https://phabricator.wikimedia.org/T180237) (owner: Ejegg) [00:07:19] (CR) Ejegg: [C: 2] Update submodules to deny /vendor web access [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391385 (owner: Ejegg) [00:08:25] (Merged) jenkins-bot: Update submodules to deny /vendor web access [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391385 (owner: Ejegg) [00:08:57] jeez, that's a nasty looking zuul queue [00:09:54] (Merged) jenkins-bot: XSS in langconverter when regex hits pcre.backtrack_limit [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391409 (https://phabricator.wikimedia.org/T124404) (owner: Ejegg) [00:10:49] (Merged) jenkins-bot: Make anchor for headlines escape > and < [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391410 (https://phabricator.wikimedia.org/T125163) (owner: Ejegg) [00:10:52] (Merged) jenkins-bot: SECURITY: API: Avoid some silliness with browser-guessed filenames [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391411 (https://phabricator.wikimedia.org/T128209) (owner: Ejegg) [00:11:38] (CR) jerkins-bot: [V: -1] SECURITY: Do not reveal if user exists during login failure [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391412 (https://phabricator.wikimedia.org/T134100) (owner: Ejegg) [00:11:41] (CR) jerkins-bot: [V: -1] SECURITY: Ensure Message::rawParams can't lead to XSS [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391413 (https://phabricator.wikimedia.org/T176247) (owner: Ejegg) [00:11:59] grr [00:12:28] !log updated CiviCRM from f571c67ceb353b457f250cc4606cfaa882343e39 to b99a9cf65aa02c09b68b2f6084535be80f4eb90e [00:12:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:14:37] (CR) Ejegg: [C: 2] "recheck" [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/391366 (owner: Ejegg) [00:15:55] damn, that was a legit test failure [00:16:34] fixed on main backport? [00:16:57] (Merged) jenkins-bot: Update vendor for .htaccess [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/391366 (owner: Ejegg) [00:18:49] !log updated SmashPig payments listener from 5262d532e30aef76a72fd9b8ff248e9a9570f8f7 to 45aa62650cad92a295ed1b94f07f0a62c992e2af [00:18:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:20:52] (Merged) jenkins-bot: Disallow web access to /vendor [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/391373 (https://phabricator.wikimedia.org/T180237) (owner: Ejegg) [00:21:10] dang, nope, not fixed on the main REL1_27 [00:21:16] marking test skipped for now... [00:25:53] (PS2) Ejegg: SECURITY: Do not reveal if user exists during login failure [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391412 (https://phabricator.wikimedia.org/T134100) [00:25:57] (PS2) Ejegg: SECURITY: Ensure Message::rawParams can't lead to XSS [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391413 (https://phabricator.wikimedia.org/T176247) [00:25:59] (PS2) Ejegg: update.php: Remove eval-stdin.php if necessary [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391414 (https://phabricator.wikimedia.org/T180231) [00:26:03] (PS2) Ejegg: Create a .htaccess in /vendor after composer runs [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391415 (https://phabricator.wikimedia.org/T180237) [00:26:06] (PS2) Ejegg: SECURITY: Handle -{}- syntax in attributes safely [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391416 (https://phabricator.wikimedia.org/T119158) [00:26:10] (PS1) Ejegg: Update DonationInterface for vendor .htaccess [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391431 [00:26:14] (PS1) Ejegg: Update FundraisingEmailUnsubscribe submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391432 [00:26:23] (PS1) Ejegg: SECURITY: Escape internal error message [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391433 (https://phabricator.wikimedia.org/T178451) [00:26:26] (PS1) Ejegg: SECURITY: Add throttling for BotPasswords authentication attempts [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391434 (https://phabricator.wikimedia.org/T165846) [00:26:29] (PS1) Ejegg: Update vendor submodule for .htaccess [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391435 [00:26:31] (PS2) Ejegg: Update vendor submodule for .htaccess [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391435 [00:31:25] (PS1) Ejegg: Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391436 [00:31:32] (CR) Ejegg: [C: 2] SECURITY: Do not reveal if user exists during login failure [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391412 (https://phabricator.wikimedia.org/T134100) (owner: Ejegg) [00:32:10] (CR) Ejegg: [C: 2] update.php: Remove eval-stdin.php if necessary [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391414 (https://phabricator.wikimedia.org/T180231) (owner: Ejegg) [00:33:14] (CR) Ejegg: [C: 2] Update DonationInterface for vendor .htaccess [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391431 (owner: Ejegg) [00:34:08] no whammy, no whammy [00:34:36] (CR) Ejegg: [C: 2] Update FundraisingEmailUnsubscribe submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391432 (owner: Ejegg) [00:34:39] (CR) Ejegg: [C: 2] SECURITY: Add throttling for BotPasswords authentication attempts [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391434 (https://phabricator.wikimedia.org/T165846) (owner: Ejegg) [00:34:40] (CR) Ejegg: [C: 2] Update vendor submodule for .htaccess [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391435 (owner: Ejegg) [00:34:45] (CR) Ejegg: [C: 2] SECURITY: Escape internal error message [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391433 (https://phabricator.wikimedia.org/T178451) (owner: Ejegg) [00:34:53] (CR) Ejegg: [C: 2] Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391436 (owner: Ejegg) [00:34:55] (CR) jerkins-bot: [V: -1] SECURITY: Do not reveal if user exists during login failure [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391412 (https://phabricator.wikimedia.org/T134100) (owner: Ejegg) [00:35:02] (CR) jerkins-bot: [V: -1] SECURITY: Ensure Message::rawParams can't lead to XSS [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391413 (https://phabricator.wikimedia.org/T176247) (owner: Ejegg) [00:35:11] (CR) jerkins-bot: [V: -1] update.php: Remove eval-stdin.php if necessary [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391414 (https://phabricator.wikimedia.org/T180231) (owner: Ejegg) [00:35:28] (CR) jerkins-bot: [V: -1] Create a .htaccess in /vendor after composer runs [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391415 (https://phabricator.wikimedia.org/T180237) (owner: Ejegg) [00:35:30] (CR) jerkins-bot: [V: -1] SECURITY: Handle -{}- syntax in attributes safely [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391416 (https://phabricator.wikimedia.org/T119158) (owner: Ejegg) [00:35:40] (CR) jerkins-bot: [V: -1] Update DonationInterface for vendor .htaccess [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391431 (owner: Ejegg) [00:35:42] (CR) jerkins-bot: [V: -1] Update FundraisingEmailUnsubscribe submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391432 (owner: Ejegg) [00:35:44] (CR) jerkins-bot: [V: -1] SECURITY: Escape internal error message [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391433 (https://phabricator.wikimedia.org/T178451) (owner: Ejegg) [00:35:47] (CR) jerkins-bot: [V: -1] SECURITY: Add throttling for BotPasswords authentication attempts [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391434 (https://phabricator.wikimedia.org/T165846) (owner: Ejegg) [00:35:50] (CR) jerkins-bot: [V: -1] Update vendor submodule for .htaccess [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391435 (owner: Ejegg) [00:35:53] (CR) jerkins-bot: [V: -1] Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391436 (owner: Ejegg) [00:36:38] blargh [00:38:38] (CR) Ejegg: [C: 2] "recheck" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391412 (https://phabricator.wikimedia.org/T134100) (owner: Ejegg) [00:40:14] (CR) jerkins-bot: [V: -1] SECURITY: Do not reveal if user exists during login failure [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391412 (https://phabricator.wikimedia.org/T134100) (owner: Ejegg) [00:40:29] (CR) jerkins-bot: [V: -1] SECURITY: Ensure Message::rawParams can't lead to XSS [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391413 (https://phabricator.wikimedia.org/T176247) (owner: Ejegg) [00:41:21] (CR) jerkins-bot: [V: -1] update.php: Remove eval-stdin.php if necessary [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391414 (https://phabricator.wikimedia.org/T180231) (owner: Ejegg) [00:41:55] (CR) jerkins-bot: [V: -1] Create a .htaccess in /vendor after composer runs [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391415 (https://phabricator.wikimedia.org/T180237) (owner: Ejegg) [00:42:29] (CR) jerkins-bot: [V: -1] SECURITY: Handle -{}- syntax in attributes safely [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391416 (https://phabricator.wikimedia.org/T119158) (owner: Ejegg) [00:42:54] (CR) jerkins-bot: [V: -1] Update DonationInterface for vendor .htaccess [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391431 (owner: Ejegg) [00:42:57] (CR) jerkins-bot: [V: -1] Update FundraisingEmailUnsubscribe submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391432 (owner: Ejegg) [00:43:06] (CR) jerkins-bot: [V: -1] SECURITY: Escape internal error message [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391433 (https://phabricator.wikimedia.org/T178451) (owner: Ejegg) [00:43:08] (CR) jerkins-bot: [V: -1] SECURITY: Add throttling for BotPasswords authentication attempts [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391434 (https://phabricator.wikimedia.org/T165846) (owner: Ejegg) [00:43:10] (CR) jerkins-bot: [V: -1] Update vendor submodule for .htaccess [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391435 (owner: Ejegg) [00:43:13] (CR) jerkins-bot: [V: -1] Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391436 (owner: Ejegg) [00:46:13] (CR) Ejegg: [V: 2 C: 2] SECURITY: Do not reveal if user exists during login failure [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391412 (https://phabricator.wikimedia.org/T134100) (owner: Ejegg) [00:52:04] (CR) jerkins-bot: [V: -1] SECURITY: Ensure Message::rawParams can't lead to XSS [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391413 (https://phabricator.wikimedia.org/T176247) (owner: Ejegg) [00:52:06] (CR) jerkins-bot: [V: -1] update.php: Remove eval-stdin.php if necessary [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391414 (https://phabricator.wikimedia.org/T180231) (owner: Ejegg) [00:52:08] (CR) jerkins-bot: [V: -1] Create a .htaccess in /vendor after composer runs [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391415 (https://phabricator.wikimedia.org/T180237) (owner: Ejegg) [00:52:25] (CR) jerkins-bot: [V: -1] SECURITY: Handle -{}- syntax in attributes safely [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391416 (https://phabricator.wikimedia.org/T119158) (owner: Ejegg) [00:52:27] (CR) jerkins-bot: [V: -1] Update DonationInterface for vendor .htaccess [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391431 (owner: Ejegg) [00:52:29] (CR) jerkins-bot: [V: -1] Update FundraisingEmailUnsubscribe submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391432 (owner: Ejegg) [00:52:32] (CR) jerkins-bot: [V: -1] SECURITY: Escape internal error message [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391433 (https://phabricator.wikimedia.org/T178451) (owner: Ejegg) [00:52:38] (CR) jerkins-bot: [V: -1] SECURITY: Add throttling for BotPasswords authentication attempts [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391434 (https://phabricator.wikimedia.org/T165846) (owner: Ejegg) [00:52:41] (CR) jerkins-bot: [V: -1] Update vendor submodule for .htaccess [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391435 (owner: Ejegg) [00:52:43] (CR) jerkins-bot: [V: -1] Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391436 (owner: Ejegg) [00:55:25] (PS2) Ejegg: Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391436 [00:56:00] (CR) Ejegg: [V: 2 C: 2] SECURITY: Ensure Message::rawParams can't lead to XSS [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391413 (https://phabricator.wikimedia.org/T176247) (owner: Ejegg) [00:56:32] (CR) Ejegg: [V: 2 C: 2] update.php: Remove eval-stdin.php if necessary [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391414 (https://phabricator.wikimedia.org/T180231) (owner: Ejegg) [00:56:41] ok, nuff of this zuul nonsense [00:56:59] (CR) Ejegg: [V: 2 C: 2] Create a .htaccess in /vendor after composer runs [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391415 (https://phabricator.wikimedia.org/T180237) (owner: Ejegg) [00:57:01] (CR) Ejegg: [V: 2 C: 2] SECURITY: Handle -{}- syntax in attributes safely [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391416 (https://phabricator.wikimedia.org/T119158) (owner: Ejegg) [00:57:07] (CR) Ejegg: [V: 2 C: 2] Update DonationInterface for vendor .htaccess [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391431 (owner: Ejegg) [00:57:10] (CR) Ejegg: [V: 2 C: 2] Update FundraisingEmailUnsubscribe submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391432 (owner: Ejegg) [00:57:13] (CR) Ejegg: [V: 2 C: 2] SECURITY: Escape internal error message [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391433 (https://phabricator.wikimedia.org/T178451) (owner: Ejegg) [00:57:16] (CR) Ejegg: [V: 2 C: 2] SECURITY: Add throttling for BotPasswords authentication attempts [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391434 (https://phabricator.wikimedia.org/T165846) (owner: Ejegg) [00:57:19] (CR) Ejegg: [V: 2 C: 2] Update vendor submodule for .htaccess [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391435 (owner: Ejegg) [00:57:22] (CR) Ejegg: [V: 2 C: 2] Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391436 (owner: Ejegg) [00:59:29] !log updated payments-wiki from d150287f0b64d13589e1af728be0cb5b89f66699 to 210cb37d9973eabed06a520ac31fe74d30ffde4a [00:59:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:05:17] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, and 2 others: Apply 1.27.4 security patches - https://phabricator.wikimedia.org/T180547#3761386 (Ejegg) [01:32:18] (PS1) Ejegg: Update phpunit in composer.lock [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/391457 [01:32:20] (CR) Ejegg: [C: 2] Update phpunit in composer.lock [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/391457 (owner: Ejegg) [01:34:33] (Merged) jenkins-bot: Update phpunit in composer.lock [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/391457 (owner: Ejegg) [02:00:19] ok, that's an hour of burn-in and payments-wiki is looking fine so far... [02:00:25] taking off! [03:32:32] (PS5) Eileen: Add dedupetools extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389650 (https://phabricator.wikimedia.org/T177999) [03:32:34] (PS5) Eileen: Tidy up dedupe rules & install dedupetools. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389651 (https://phabricator.wikimedia.org/T177999) [03:32:36] (PS2) Eileen: Add extended reports extension to add Address History tab option. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391352 [03:33:45] (PS3) Eileen: Add extended reports extension to add Address History tab option. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391352 [03:35:33] (PS1) Eileen: Enable extended report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391479 (https://phabricator.wikimedia.org/T142549) [04:37:45] (CR) AndyRussG: [C: 2] "Great!!! Thanks!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/380891 (https://phabricator.wikimedia.org/T176656) (owner: Pcoombe) [05:25:56] (PS2) Eileen: Enable extended report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391479 (https://phabricator.wikimedia.org/T142549) [06:39:18] (Merged) jenkins-bot: Don't load CentralNotice on history or diff pages [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/380891 (https://phabricator.wikimedia.org/T176656) (owner: Pcoombe) [10:02:02] Fundraising-Backlog: mnoor to gain access to the "dash" - https://phabricator.wikimedia.org/T180509#3762131 (MNoorWMF) Hmm...I think I'm missing something. I tried multiple browsers and got the same result (see attached screenshot).{F10803443} [11:19:41] Fundraising-Backlog, MediaWiki-extensions-FundraisingChart, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingChart extension - https://phabricator.wikimedia.org/T178762#3762395 (MarcoAurelio) [11:19:59] Fundraising-Backlog, MediaWiki-extensions-FundraisingChart, Cleanup, Repository-Admins, and 2 others: Archive the FundraisingChart extension - https://phabricator.wikimedia.org/T178762#3701916 (MarcoAurelio) [13:51:05] pcoombe: hi! thanks for the work on the history/diff pages patch, and apologies for the delay in getting to it.... Also BTW dunno if you saw, the change for registering tests went out to production yesterday :) [14:06:55] Awesome, thanks AndyRussG. I'll try the new registering tests code in our banners tomorrow [14:13:46] morning AndyRussG o/ [14:49:09] looks like eileen and i will be rooting foropposing teams this afternoon [15:53:52] Fundraising-Backlog: mnoor to gain access to the "dash" - https://phabricator.wikimedia.org/T180509#3763306 (Ejegg) @Jgreen or @cwdent any ideas? [16:15:21] Fundraising-Backlog: mnoor to gain access to the "dash" - https://phabricator.wikimedia.org/T180509#3763372 (Jgreen) >>! In T180509#3762131, @MNoorWMF wrote: > Hmm...I think I'm missing something. I tried multiple browsers and got the same result (see attached screenshot).{F10803443} That's a client certifi... [16:17:55] (CR) Ejegg: [C: -1] "When I try to print_r a curl resource, all I get is this:" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/391291 (owner: Mepps) [16:21:19] (PS1) Ejegg: Fix tests for I7afaa955a4b393ef00b11e420709bd62b84fbc71 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391571 [16:21:44] (CR) Ejegg: [C: 2] Fix tests for I7afaa955a4b393ef00b11e420709bd62b84fbc71 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391571 (owner: Ejegg) [16:22:14] lotsa noise in the streets... guessing it's related to the upcoming soccer game? [16:22:26] going to take a quick look [16:26:12] (CR) jerkins-bot: [V: -1] Fix tests for I7afaa955a4b393ef00b11e420709bd62b84fbc71 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391571 (owner: Ejegg) [16:50:06] more interesting, it was a strike [16:50:41] though when I tried talking to the folks on the sidelines they were more interested in talking soccer [16:57:16] lol [16:58:03] England played Brazil yesterday with is a pretty big event on the football/soccer calendar... and I completely forgot because I was too busy fighting with phpunit [16:58:17] which is*** [17:25:42] Fundraising-Backlog: mnoor to gain access to the "dash" - https://phabricator.wikimedia.org/T180509#3763572 (MNoorWMF) RE: #2 - can confirm, there was no pop-up when first connecting to Dash. I am currently remote (GMT+2) but can be available on a Hangout/IRC to resolve. [17:56:36] XenoRyet: anything I can do to help out? [17:57:24] Na, I [17:57:40] I'm pretty sure I worked it out. I'll let you know when it's ready for review agian. [17:57:53] ok [17:58:18] Thanks for the offer though. [18:26:08] fr-tech any news for scrum of scrums? [18:26:37] I'll remind people that we're locking things down and to please double check on anything that might affect CentralNotice or the banners [18:26:37] Nothing here [18:36:58] nothing from me [18:38:37] ejegg I'm having difficultly squashing merges into one for the final commit :( hopefully catch you later if that's okay to work out what I am doing wrong, just gonna pick up family and will reach out when I'm back o/ [18:39:17] I was following this but must have been doing something wrong https://www.mediawiki.org/wiki/Gerrit/Tutorial#Squash_several_commits_into_one_single_commit_via_rebase [18:46:22] Fundraising-Backlog: mnoor to gain access to the "dash" - https://phabricator.wikimedia.org/T180509#3763839 (Jgreen) Open>Resolved a:Jgreen Turns out Moska's laptop had been replaced since we issued her last SSL cert, and the cert was not installed on the new one. I sent a new cert and she instal... [18:47:41] jgleeson|afk: soon as I'm done this scrum of scrums meeting I'll take a look [18:59:33] (PS7) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [19:02:51] (CR) jerkins-bot: [V: -1] Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [19:09:09] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, WMF FR: Clean up obsolete fundraising templates on foundationwiki - https://phabricator.wikimedia.org/T180622#3763888 (Ejegg) [19:11:01] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, WMF FR: Clean up obsolete fundraising templates on foundationwiki - https://phabricator.wikimedia.org/T180622#3763908 (Ejegg) @Pcoombe do you have any thoughts on the most efficient way to mark all of these as obsolete and direct donors to... [19:11:49] (PS8) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [19:16:08] (CR) jerkins-bot: [V: -1] Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [19:19:10] (PS9) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [19:46:23] (CR) Ejegg: [C: -1] "Needs a bunch of scope fixes. Maybe have validateField return true or false to replace that errorsPresent var." (10 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [19:58:29] (CR) Ejegg: [C: 2] "recheck" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391571 (owner: Ejegg) [20:06:07] (CR) jerkins-bot: [V: -1] Fix tests for I7afaa955a4b393ef00b11e420709bd62b84fbc71 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391571 (owner: Ejegg) [20:06:28] wtf, that assertion doesn't even exist on our branch [20:25:04] ejegg: I managed to get the dedupe search back into the popup [20:38:17] great! [20:38:23] looking [20:40:21] well, at 'add dedupetools extension' first [20:57:58] (CR) Ejegg: "Missing a DAO file from the commit?" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389650 (https://phabricator.wikimedia.org/T177999) (owner: Eileen) [20:59:44] eileen: ah, so that extension's whole purpose currently is to add those links to the dropdown? [21:01:03] hi jgleeson|afk [21:01:41] hey ejegg! [21:01:52] you free at the moment? [21:03:22] just eating a bit, will you be around another 15 min? [21:03:53] yeah no problem, I'll try and work it out myself in the meantime :) [21:04:42] jgleeson: do you have a good merge tool installed? [21:04:53] I'm a big fan of meld [21:05:09] I normally use my IDE for git related things [21:05:16] ejegg: yep - that's all it adds at the moment [21:05:18] never used a standalone one [21:05:48] jgleeson: oh cool, I've never tried git stuff in phpstorm beyond it tracking adds/deletes/renames [21:05:56] (the other code in it I used for analysing conflicts but don't have a specific reason to use at the moment, however, I thought we should keep all our dedupe code together) [21:06:10] cool eileen [21:07:52] ug - will look for the DAO [21:08:41] yeah ejegg you can do interactive rebase in phpstorm, it's pretty neat. I typically use cli for basic stuff but for conflicts and resolve using phpstorm [21:09:22] in my other companies we mostly used gitflow as our git workflow so didn't do much with rebasing [21:10:18] gitflow == not revising commits ? [21:11:28] you wouldn't typically revise a commit using gitflow [21:11:36] as it goes into a develop branch [21:11:48] so any updates to the WIP just gets treated an another branch [21:11:50] https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow [21:13:27] my workflow was something like, create a feature branch from develop, work on it, merge to develop and run CI, if all goes well, merge to master and tag [21:19:51] jgleeson: ah, that's cool. [21:20:02] so I think I got it to work, the rebase that is [21:20:11] nice! [21:20:14] I actually used phpstorm which gives you a nice UI for rebasing [21:20:18] was it a composer.* conflict? [21:20:58] no, it was combination of me not picking the right branch to keep and some issue about an unmerged path, civicrm [21:21:17] I had to git add civicrm [21:21:24] which I'm not 100% sure why [21:21:29] oh weird... [21:21:32] that seems off [21:21:35] yeah [21:21:38] I did just update the civicrm [21:21:40] pointer [21:21:47] as part of the security updates yesterday [21:21:49] it was since my latest git pull on maste [21:21:52] master* [21:22:13] besides the mw-specific ones, there was a suggestion to put .htaccess files in all of the /vendor dirs to prevent web access [21:22:25] which seemed like a good idea for crm and smashpig too [21:23:35] hmm, the dual branch concept in gitflow sounds a bit like ours [21:23:46] only what they call 'master' we call 'deployment' [21:23:54] and their 'development' is our 'master' [21:24:56] I need to fix this issue of gerrit being a different remote for some reason [21:25:05] (PS3) Jgleeson: Added Donations Stats class which uses stats-collector. Added DonationStatsTests. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 [21:25:13] (CR) jerkins-bot: [V: -1] Added Donations Stats class which uses stats-collector. Added DonationStatsTests. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 (owner: Jgleeson) [21:29:44] I think that just tripped me up again [21:30:12] as git review is using my 'gerrit' remote but I rebased origin/master which is a different remote (both pointing to the same thing) [21:30:18] jgleeson in my ~/.gitconfig, I have this section: [21:30:23] [gitreview] [21:30:23] username = ejegg [21:30:23] remote = origin [21:30:45] (where the weird character starting the last two lines is a tab) [21:30:56] this is possible due to me initially cloning the project using basic auth before getting my keys setup and then installing git review [21:31:02] possibly* [21:31:32] Vagrant would do that too if it cloned as part of a role provision, I think [21:34:36] jgleeson: want to try fixing that civicrm submodule version? [21:34:55] Seems to be giving your commit the red mark of 'Merge conflict' in gerrit [21:35:33] I've just remote the second gerrit remote which is causing some problems, I think I need to point git review at my origin... someshow [21:35:43] removed [21:36:01] I'm in the usual room if you wanna jump on and watch me fight ;) [21:36:40] sure, one sec! [21:47:45] (CR) Eileen: Add dedupetools extension. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389650 (https://phabricator.wikimedia.org/T177999) (owner: Eileen) [21:47:47] (PS6) Eileen: Add dedupetools extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389650 (https://phabricator.wikimedia.org/T177999) [21:51:11] (PS6) Eileen: Tidy up dedupe rules & install dedupetools. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389651 (https://phabricator.wikimedia.org/T177999) [21:51:13] (PS4) Eileen: Add extended reports extension to add Address History tab option. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391352 [21:51:15] (PS3) Eileen: Enable extended report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391479 (https://phabricator.wikimedia.org/T142549) [21:56:21] (PS4) Jgleeson: Added Donations Stats class which uses stats-collector. Added DonationStatsTests. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 [22:01:27] (Abandoned) Jgleeson: WIP: Added new stats collector implemetation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390343 (owner: Jgleeson) [22:01:34] (Abandoned) Jgleeson: WIP added new implementation of stats for donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391021 (owner: Jgleeson) [22:01:39] (Abandoned) Jgleeson: Separated out Donation Stats to new DonationsStats.php helper class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391022 (owner: Jgleeson) [22:03:00] (CR) jerkins-bot: [V: -1] Added Donations Stats class which uses stats-collector. Added DonationStatsTests. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 (owner: Jgleeson)