[00:05:38] (CR) Ejegg: [C: 2] "Really exciting to get towards making this logic reusable! Some of the API stuff looks first-draft-y, so I won't -1 based on that code. Th" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389650 (https://phabricator.wikimedia.org/T177999) (owner: Eileen) [00:07:32] (CR) Eileen: "Thanks ejegg - I was hoping that keeping the 'not yet really in play' code wouldn't derail the actual change in this" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389650 (https://phabricator.wikimedia.org/T177999) (owner: Eileen) [00:08:35] definitely some useful heuristics! [00:10:32] yeah - I used that code when I was analysing our conflicts [00:10:40] I have no specific plans to run it on live [00:12:24] (Merged) jenkins-bot: Add dedupetools extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389650 (https://phabricator.wikimedia.org/T177999) (owner: Eileen) [00:16:09] (PS7) Ejegg: Tidy up dedupe rules & install dedupetools. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389651 (https://phabricator.wikimedia.org/T177999) (owner: Eileen) [00:18:35] (CR) Ejegg: [C: 2] "Admirably reproducible data cleanup!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389651 (https://phabricator.wikimedia.org/T177999) (owner: Eileen) [00:18:51] ok, I'm going to take off for the night. See y'all tomorrow! [00:22:41] see ya! [00:25:10] (Merged) jenkins-bot: Tidy up dedupe rules & install dedupetools. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/389651 (https://phabricator.wikimedia.org/T177999) (owner: Eileen) [00:30:55] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391743 [00:31:44] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391743 (owner: Eileen) [00:32:32] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391743 (owner: Eileen) [00:42:52] !log update civicrm from b99a9cf65aa02c09b68b2f6084535be80f4eb90e to 22f65325510adf538b0fb087c5dd2867b8fcf5fb [00:42:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:07:32] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Add link to contact summary to assist in finding & deduping the contact - https://phabricator.wikimedia.org/T177999#3765381 (Eileenmcnaughton) @LeanneS @NNichols... [11:54:56] Fundraising-Backlog, MediaWiki-extensions-FundraisingChart, Cleanup, Repository-Admins, and 2 others: Archive the FundraisingChart extension - https://phabricator.wikimedia.org/T178762#3766256 (MarcoAurelio) @Ejegg Can I please have a +2 on https://gerrit.wikimedia.org/r/#/c/391174/ and later on... [14:23:57] Wikimedia-Fundraising, Design: Redesign of the ‘Thank You’ Page - https://phabricator.wikimedia.org/T179713#3766607 (spatton) Note that @schoenbaechler's TY page has been merged into the English TY page and is now live. https://wikimediafoundation.org/wiki/Thank_You/en https://wikimediafoundation.org/w... [14:35:08] hi fr-tech! [14:35:22] i'm trying to be around today though woke up still not feeling great [14:58:09] hey mepps, ah bad news on the cold, are you taking anything for it? Do they have lemsip where you are? [14:58:31] what is lemsip, jgleeson? lemon and water? [14:59:20] http://www.lemsip.co.uk/products/lemsip-max-cold-flu/ [14:59:34] it's a cold & flu remedy [14:59:46] mix of paracetamol and decongestant [15:00:58] I don't think it actually fights the cold, it just makes the symptoms more bearable [15:06:43] good to know! [15:06:48] how are you jgleeson? [15:10:06] this is what i found searching for lemsip us http://britishexpats.com/forum/usa-57/lemsip-alternatives-271547/ [15:11:16] (PS3) Mepps: More debugging for orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/391291 [15:11:50] I am good thanks, just working on some unit tests. It's Oscars 2nd birthday December 1st so spent some time earlier trying to work out what do for this birthday :) [15:12:45] ah, looks like Theraflu is a close match [15:13:13] on your side of the Atlantic [15:20:55] (CR) jerkins-bot: [V: -1] More debugging for orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/391291 (owner: Mepps) [15:55:59] hi ejegg. I'm guessing things were lively last night where you are after Peru won and got through to the world cup! [15:58:49] hehe, you guess right [16:03:49] (PS4) Mepps: More debugging for orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/391291 [16:11:09] fundraising-tech-ops: samarium/rsyslog - too many open files - https://phabricator.wikimedia.org/T179431#3766941 (cwdent) Open>Resolved a:cwdent Worked! [16:20:33] (CR) Ejegg: [C: 1] "should be informative. mind changing the log level to debug so we can enable this just for paypal_ec?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/391291 (owner: Mepps) [16:23:13] (PS5) Mepps: More debugging for orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/391291 [16:29:28] (PS1) Ejegg: Fix undefined variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/391859 [16:31:12] (PS6) Ejegg: More debugging for orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/391291 (owner: Mepps) [16:31:23] (CR) Ejegg: [C: 2] More debugging for orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/391291 (owner: Mepps) [16:31:29] (PS2) Ejegg: Fix undefined variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/391859 [16:34:38] mepps that undefined variable fix might be worth deploying along with the orphan rectifier debugging ^^ [16:35:06] (Merged) jenkins-bot: More debugging for orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/391291 (owner: Mepps) [16:35:30] (CR) Mepps: [C: 2] Fix undefined variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/391859 (owner: Ejegg) [16:35:37] looks good ejegg! [16:38:50] (Merged) jenkins-bot: Fix undefined variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/391859 (owner: Ejegg) [16:40:16] are you going to deploy ejegg, or do you want me to? [17:01:28] ummm [17:01:31] fr-tech [17:01:58] jgleeson: hi! [17:02:05] is stand-up going ahead or are people in the global leadership meeting? [17:36:05] mepps do you want to go ahead with the deploy? [17:36:34] hey ejegg, i'll be going to lunch shortly but i can do it after the emergency procedure call [17:36:46] sounds good [17:42:57] Wikimedia-Fundraising: The banner appears in article's section - https://phabricator.wikimedia.org/T180717#3767319 (Etonkovidova) [18:00:10] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: unsubscribe is 109 100 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 9 keys, up 51 days 1 hours - memory use is 3.71M (peak 23.12M, 0.08% of max, fragmentation 1.83%), connected_slaves is 2, donations is 167, jobs is 0, jobs-adyen is 0, jobs-paypal is 337, payments-antifraud is 140, payments-init is 499, pending is 268, recurring is 97, refund is 13 [18:02:27] fr-tech do we know what is wrong with REDIS from the above? [18:05:10] RECOVERY - check_redis on frqueue1001 is OK: OK: REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 51 days 1 hours - memory use is 2.49M (peak 23.12M, 0.08% of max, fragmentation 2.57%), connected_slaves is 2, donations is 184, jobs is 0, jobs-adyen is 0, jobs-paypal is 149, payments-antifraud is 21, payments-init is 43, pending is 40, recurring is 37, refund is 0, unsubscribe is 8 [18:23:46] jgleeson: I think we need to adjust the limit on that queue [18:24:11] we just added a visible unsubscribe link to the footer of the thank you email [18:24:24] previously it was just in the list-unsubscribe email header [18:25:14] jgleeson can you log in at icinga.wikimedia.org? [18:25:27] (using your wikitech creds) [18:25:44] yep [18:25:55] ever used icinga before? [18:25:59] nope [18:26:07] just on the unsubscribe queue [18:26:19] I don't see that mentioned in the PROBLEM report [18:26:27] however I do see it in the RECOVERY report [18:27:08] hmm, let's see... where do we change that limit [18:28:02] cwd / Jeff_Green can we change queue alert thresholds via the icinga web ui? [18:28:38] no, with nagios/icinga all that config happens at the host not the master [18:28:42] so it's in puppet [18:28:55] that's brilliant, one of the options is 'Start Obsessing Over Checked Host(s)' [18:29:02] hehe [18:29:12] Jeff_Green: thanks! [18:29:12] i don't even know what that option means [18:33:36] Jeff_Green: I made a commit tripling the warning levels for the unsubscribe queue [18:33:46] in my homedir copy of the puppet repo [18:33:51] but I have no push permissions [18:36:02] ok merged [18:43:15] thanks! [19:06:12] hey fr-tech, google is taking a minute to connect [19:06:36] No worries, just getting started. [19:22:27] (PS1) Ejegg: Change individual amount cutoff to $5000 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/391884 [19:57:01] I was gonna ask what do I do when the yubikey arrives but I'll wait until it arrives tomorrow [20:05:46] (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/391890 [20:06:28] hey ejegg, does this commit require any settings updates: d724218 Get Amazon SDK object from SmashPig config [20:07:11] mepps ooh, I don't think so, but I should definitely look closely at this deploy [20:09:36] mepps just gonna relocate down the street, I'll be back in 5 min [20:17:34] okay ejegg|afk, pausing on deploy til you get back [20:17:40] ok, all set! [20:17:58] all set as in reviewed the commits or all set as in you're back ejegg? [20:18:17] :) [20:18:38] back online and tailing the logs [20:19:31] oh shoot, that's a bunch of globalcollect errors [20:19:43] oh no, we haven't even deployed yet [20:19:44] TypeError: Not enough arguments [20:19:58] right, what the heck? [20:20:06] have we deployed something recently? [20:20:29] oh wait, that's the client-side error logging picking up browser errors! [20:20:49] so, probably something that's been broken for a while :S [20:20:52] I'll file a bug [20:21:41] mepps the commits all look good to go [20:21:44] cool [20:21:49] (CR) Mepps: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/391890 (owner: Mepps) [20:23:51] if Amazon keeps on chugging after that deploy we can actually delete a few lines from the settings [20:24:30] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/391890 (owner: Mepps) [20:25:46] (PS1) Mepps: Updated DI with latest commits [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391894 [20:25:55] (CR) Mepps: [C: 2] Updated DI with latest commits [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391894 (owner: Mepps) [20:34:35] (CR) jerkins-bot: [V: -1] Updated DI with latest commits [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391894 (owner: Mepps) [20:35:48] erg, no idea why that failed ejegg ^^, looks like two unrelated tests broke [20:36:12] mepps oh damn, that's right, I was trying to figure that out yesterday [20:36:22] ahh [20:36:44] did you mean to update ContributionTracking too? [20:36:45] when did they first break? did we upgrade or pull anything new in recently? [20:36:50] oops, i did not [20:37:06] it was one of the security patches from Tuesday [20:38:01] (PS2) Mepps: Updated DI with latest commits [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391894 [20:38:21] let's see if there have been any more commits to the regular 1_27 branch [20:41:39] i just see this on first glance: https://gerrit.wikimedia.org/r/#/c/391724/ [20:41:54] mepps OK, I see a fix [20:42:01] lemme merge those first [20:42:14] cool ejegg [20:43:28] (PS1) Ejegg: Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391904 [20:43:36] (CR) Ejegg: [C: 2] Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391904 (owner: Ejegg) [20:48:04] (PS5) Jgleeson: Added DonationsStats class which uses new https://github.com/jackgleeson/stats-collector to record stats Added DonationStats Tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 [20:49:11] (Merged) jenkins-bot: Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391904 (owner: Ejegg) [20:49:23] ah man, looks like somehow I've ended up with some of Eileen's new work in my latest squashed rebase [20:49:32] dang! [20:49:51] so I thought skip, would skip them [20:50:00] I really need to read up on rebase more [20:50:39] 'skip' would actually remove them from your branch's history [20:51:16] which you wouldn't want for stuff that's actually merged into master [20:51:41] I'm guessing it's not merged into master if they are showing as new files [20:55:48] (CR) Mepps: [C: 2] "recheck" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391894 (owner: Mepps) [20:56:10] (CR) Mepps: [C: 2] Updated DI with latest commits [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391894 (owner: Mepps) [21:04:21] (Merged) jenkins-bot: Updated DI with latest commits [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391894 (owner: Mepps) [21:04:49] okay ejegg deploying now [21:05:05] ok mepps, tailing the logs [21:05:47] !log updated payments-wiki from 210cb37d9973eabed06a520ac31fe74d30ffde4a to f871160c83d5be95bf25587aaf8bb87b8b56a809 [21:05:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:07:55] just successfully donated ejegg [21:08:33] nice! [21:08:47] though to deploy my debug code, don't i have to update crm? [21:09:14] yeah, and the packagist dev-master version [21:09:24] (PS6) Jgleeson: Added DonationsStats class which uses new https://github.com/jackgleeson/stats-collector to record stats Added DonationStats Tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 [21:09:30] Wikimedia-Fundraising, Android-app-feature-Feeds, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, and 2 others: Big English Mobile App Fundraising 2017 - https://phabricator.wikimedia.org/T180741#3768119 (schoenbaechler) [21:09:44] phew... that looks better [21:09:46] Still need to have it on payments so we can compare though [21:09:56] git reset --hard is a scary command [21:10:17] yeah [21:10:50] pursued by a bear :) [21:10:50] even if you lose stuff that way, you can find it again with git reflog though [21:11:01] I created a tag before resetting [21:11:03] called backup [21:11:08] heh, it's a stage direction from shakespeare [21:11:40] http://www.roh.org.uk/news/exit-pursued-by-a-bear-how-do-you-approach-shakespeares-famous-stage-direction [21:13:30] I like the trained actor bear theory [21:14:13] hey ejegg how long is it supposed to take between a donation and the donation appearing in civi? [21:14:45] mepps oh hey, we have a graph for that! [21:14:48] https://grafana.wikimedia.org/dashboard/db/fundraising-overview?refresh=1m&orgId=1&panelId=21&fullscreen [21:15:12] so right now, it should happen pretty fast [21:15:33] hmm i still haven't gotten a thank you for my contribution through paypal [21:16:06] let's see where you show up in the logs [21:16:14] grepps ? [21:16:39] haha [21:17:32] hmm, I do see a paypal IPN job with your name in it [21:18:07] that sounds like an assignment ;) [21:18:22] and what are you seeing? [21:19:34] in fundraising-misc it lists the job payload [21:19:52] okay i did get it but it's not in my inbox for some reason [21:20:04] oh shoot, did it get sent to spam? [21:21:17] if so we should make sure our headers are legit [21:21:51] ohh no it's just in promotional [21:21:59] which i never check, haha [21:22:16] hmm, I don't have that enabled [21:22:38] had you done test donations before where the TY message got to the normal inbox? [21:23:04] (PS2) Jgleeson: Updated behaviour when queue is populated from dump file to detect whether additional info source headers are present and if not inject them [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/390338 [21:23:27] (Abandoned) Jgleeson: Updated IDE to use 2 spaces for indents to hopefully fix phpcs issues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/391005 (owner: Jgleeson) [21:23:32] (Abandoned) Jgleeson: Updated coding style to resolve parenthesis spacing problems [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/391009 (owner: Jgleeson) [21:28:00] I've finished what I wanted to do for today so I am signing off fr-tech [21:28:12] have a great day, see you all tomorrow o/ [21:28:21] i think the last time i did a test donation i wasn't looking for it, ejegg, trying to see though it's not clear the way gmail displays those tags [21:28:31] it sorts them but doesn't show the label on search :/ [21:29:22] just as I type that... I spot some left over debug code in my patch.... [21:32:02] (PS7) Jgleeson: Added DonationsStats class which uses new https://github.com/jackgleeson/stats-collector to record stats Added DonationStats Tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 [21:34:02] Wikimedia-Fundraising, Wikimedia-Fundraising-Banners: The banner appears in article's section - https://phabricator.wikimedia.org/T180717#3768147 (Pcoombe) Open>Resolved You're correct that this was desired behaviour. This banner position was one we tried in a short test today, and based on its d... [21:35:59] (PS8) Jgleeson: Added DonationsStats class which uses new https://github.com/jackgleeson/stats-collector to record stats Added DonationStats Tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 [21:36:39] (PS1) Mepps: Update donation-interface with debug code for orphanslayer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391913 [21:40:27] okay, this time. I'm done, good night all ! [21:41:25] (CR) Mepps: [C: 2] Update donation-interface with debug code for orphanslayer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391913 (owner: Mepps) [21:42:14] hey ejegg, should i deploy crm? i have to go in 20 so don't want to deploy and run [21:42:45] mepps I can take care of it if you want [21:43:07] ejegg i can do the merge to deployment and the code_update if you can just keep an eye on logs [21:43:14] sure thing [21:43:54] thanks! [21:45:12] (Merged) jenkins-bot: Update donation-interface with debug code for orphanslayer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391913 (owner: Mepps) [21:45:50] (PS1) Ejegg: Update civicrm to match deployment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391915 [21:45:56] (CR) Ejegg: [C: 2] Update civicrm to match deployment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391915 (owner: Ejegg) [21:46:34] (PS1) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391916 [21:48:48] (CR) Mepps: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391916 (owner: Mepps) [21:49:44] (Merged) jenkins-bot: Update civicrm to match deployment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391915 (owner: Ejegg) [21:49:46] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391916 (owner: Mepps) [21:51:17] Wikimedia-Fundraising, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Design: 2017 Big English feed card designs for iOS - https://phabricator.wikimedia.org/T180742#3768160 (cmadeo) [21:51:32] Wikimedia-Fundraising, Design, iOS-app-v5.8.0-Manatee-On-A-Skateboard: 2017 Big English feed card designs for iOS - https://phabricator.wikimedia.org/T180742#3768160 (cmadeo) [21:52:06] !log updated civicrm from 22f65325510adf538b0fb087c5dd2867b8fcf5fb to 0b8ceeafce9bb69132bce721978101d905409292 [21:52:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:52:19] cool done ejegg [21:52:38] ok, logs still look fine [21:53:02] I'll turn on that debug logging on payments and civi and see if anything obvious pops up [21:53:43] mepps oh shoot, I don't see a crm/vendor update in the backscroll [21:54:18] oh hmm, how does that work ejegg? i don't htink i've done that [21:54:42] so we have vendor as a submodule, only on the deployment branch [21:55:05] when we merge a composer.lock update to deployment, we need to also make a commit in vendor [21:55:16] and update that submodule [21:57:18] so far it's not registering a change for me in vendor [21:57:34] hmm [21:57:57] i still the vendor directory in .gitignore on the deployment branch [21:58:13] ooh, that shouldn't be there! [21:59:55] (PS1) Ejegg: Remove vendor from deploy branch .gitignore [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391919 [21:59:57] weird! ejegg i have to run, should i rollback the deployment beforehand? [22:00:03] (CR) Mepps: [C: 2] Remove vendor from deploy branch .gitignore [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391919 (owner: Ejegg) [22:00:18] mepps: nah, I'll just update the submodule [22:00:23] have a good evening! [22:01:01] (Merged) jenkins-bot: Remove vendor from deploy branch .gitignore [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391919 (owner: Ejegg) [22:04:50] ah damn, the new translations of the thank you subject aren't going to match up with the non-english letters [22:05:27] grr, we really need to fix that [22:28:13] (PS1) Ejegg: Don't create CiviMail mailing record in make_thank_you [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391951 (https://phabricator.wikimedia.org/T167806) [22:28:14] (PS1) Ejegg: Remove useless subject line setting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391952 [22:32:47] hi XenoRyet [22:33:03] I was about to deploy a vendor update to civi [22:33:24] when I realized it would make the ty mail subjects not match up with the translations [22:33:39] because of the sillyness described in T167806 [22:33:39] T167806: Thank you email subject and body should be translated in same place - https://phabricator.wikimedia.org/T167806 [22:34:19] so I'm trying to make the thank you subject be a deliberately deployed thing like the body template [22:37:41] (PS2) Ejegg: Don't create CiviMail mailing record in make_thank_you [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391951 (https://phabricator.wikimedia.org/T167806) [22:43:04] (PS2) Ejegg: Remove useless subject line setting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391952 [22:43:06] (PS1) Ejegg: Add thank you subject generator [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391971 (https://phabricator.wikimedia.org/T167806) [22:45:07] Fundraising-Backlog: Donation form Other amount field: 'minimum amount' error message - https://phabricator.wikimedia.org/T180751#3768396 (MBeat33) [22:47:28] (PS2) Ejegg: Add thank you subject generator [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391971 (https://phabricator.wikimedia.org/T167806) [22:56:55] (PS3) Ejegg: Add thank you subject generator [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391971 (https://phabricator.wikimedia.org/T167806) [22:59:10] (PS1) Ejegg: Remove redundant default generator call [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391972 [23:03:15] (PS1) Ejegg: Add thank you email subject templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391973 (https://phabricator.wikimedia.org/T167806) [23:16:59] (PS1) Ejegg: Get thank you email subject from template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391975 (https://phabricator.wikimedia.org/T167806) [23:17:50] OK, that should do it! [23:18:04] XenoRyet: let me know if you get a chance to review those ^^^ [23:18:25] Yea, I'll try to take a look in a little bit here. [23:20:39] thanks! [23:20:47] going to get some food, back in a bit [23:23:32] Wikimedia-Fundraising, Design, iOS-app-v5.8.0-Manatee-On-A-Skateboard: 2017 Big English feed card designs for iOS - https://phabricator.wikimedia.org/T180742#3768553 (cmadeo) a:schoenbaechler>None [23:23:58] ooh, the app team has some nice sprint names too! [23:31:53] (CR) XenoRyet: [C: 2] Don't create CiviMail mailing record in make_thank_you [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391951 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg) [23:33:22] (CR) XenoRyet: [C: 2] Remove useless subject line setting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391952 (owner: Ejegg) [23:37:34] (CR) XenoRyet: [C: 2] Add thank you subject generator [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391971 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg) [23:37:38] (Merged) jenkins-bot: Don't create CiviMail mailing record in make_thank_you [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391951 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg) [23:37:40] (Merged) jenkins-bot: Remove useless subject line setting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391952 (owner: Ejegg) [23:38:37] (CR) XenoRyet: [C: 2] Add thank you email subject templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391973 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg) [23:39:40] Wikimedia-Fundraising, Android-app-feature-Feeds, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, and 2 others: Big English Mobile App Fundraising 2017 - https://phabricator.wikimedia.org/T180741#3768585 (schoenbaechler) Maybe these stickers could be of use to you @RHo @cmadeo. An exter... [23:40:24] Wikimedia-Fundraising, Android-app-feature-Feeds, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, and 2 others: Big English Mobile App Fundraising 2017 - https://phabricator.wikimedia.org/T180741#3768586 (schoenbaechler) [23:40:32] (CR) XenoRyet: [C: 2] Get thank you email subject from template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391975 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg) [23:41:05] Wikimedia-Fundraising, Android-app-feature-Feeds, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, and 2 others: Big English Mobile App Fundraising 2017 - https://phabricator.wikimedia.org/T180741#3768119 (schoenbaechler) [23:43:38] (Merged) jenkins-bot: Add thank you subject generator [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391971 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg) [23:44:38] (Merged) jenkins-bot: Add thank you email subject templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391973 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg) [23:44:40] (Merged) jenkins-bot: Get thank you email subject from template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391975 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg)