[00:47:45] Fundraising-Backlog: Donation form Other amount field: 'minimum amount' error message - https://phabricator.wikimedia.org/T180751#3768732 (spatton) Adding @Pcoombe and @schoenbaechler as subscribers to this too. Just based off the screenshots, it might be a confusing design choice on our part, more than a b... [00:55:43] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391981 [00:58:51] (PS1) Ejegg: Update donation-interface for PayPal EC debugging [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/391983 [00:59:00] (CR) Ejegg: [C: 2] Update donation-interface for PayPal EC debugging [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/391983 (owner: Ejegg) [00:59:32] (PS1) Ejegg: Update vendor for paypal debugging [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391984 [00:59:36] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391981 (owner: Ejegg) [00:59:43] (CR) Ejegg: [C: 2] Update vendor for paypal debugging [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391984 (owner: Ejegg) [01:03:51] !log disabled donations queue consumer for thank you subject update [01:03:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:04:44] (Merged) jenkins-bot: Update donation-interface for PayPal EC debugging [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/391983 (owner: Ejegg) [01:04:46] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391981 (owner: Ejegg) [01:04:48] (Merged) jenkins-bot: Update vendor for paypal debugging [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391984 (owner: Ejegg) [01:07:07] !log updated CiviCRM from 0b8ceeafce9bb69132bce721978101d905409292 to 8454e0639eed6d4a0e7b01970dd5a6f9d426cb29 [01:07:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:18:05] (PS1) Ejegg: Get rid of 'qqq' TY subject, link zh to zh-hans [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391989 [01:18:11] (CR) Ejegg: [C: 2] Get rid of 'qqq' TY subject, link zh to zh-hans [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391989 (owner: Ejegg) [01:19:00] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391990 [01:19:09] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391990 (owner: Ejegg) [01:24:09] (Merged) jenkins-bot: Get rid of 'qqq' TY subject, link zh to zh-hans [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/391989 (owner: Ejegg) [01:24:11] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/391990 (owner: Ejegg) [01:28:53] !log updated CiviCRM from 8454e0639eed6d4a0e7b01970dd5a6f9d426cb29 to 272580a4b0511b7eb5392dc087a2d21e56474ab9 [01:28:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:32:41] !log re-enabled donation queue consumer [01:32:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [11:27:25] Wikimedia-Fundraising, Design, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): Implement 2017 Big English feed campaign on Android - https://phabricator.wikimedia.org/T180781#3769310 (RHo) [12:35:49] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog: Prometheus: Add seconds diff metric report [donation message enqueued => donation saved to civi] - https://phabricator.wikimedia.org/T179173#3769446 (jgleeson) Added DonationsStats (wrapper for newly added https... [12:39:43] (PS9) Jgleeson: Added DonationsStats to DonationQueueConsumer to record stats and export to Prometheus file. Exported stats are scraped by Prometheus and then available to be graphed within Grafana. For full details of changes, read comment on phab ticket here: https://p [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 [13:23:41] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog: Prometheus: Add seconds diff metric report [donation message enqueued => donation saved to civi] - https://phabricator.wikimedia.org/T179173#3769528 (jgleeson) Smashpig Patch: https://gerrit.wikimedia.org/r/#/c/... [13:40:05] (CR) Umherirrender: [V: 2 C: 2] Archive the FundraisingChart extension [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/391174 (https://phabricator.wikimedia.org/T178762) (owner: MarcoAurelio) [13:40:29] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3769539 (jgleeson) Invalid>Open [13:40:29] Fundraising-Backlog, Epic: EPIC: Prometheus Metric Suggestions - https://phabricator.wikimedia.org/T179179#3769540 (jgleeson) [13:40:31] (CR) Umherirrender: [V: 2 C: 2] Mark repository as read-only [extensions/FundraisingChart] (refs/meta/config) - https://gerrit.wikimedia.org/r/391176 (https://phabricator.wikimedia.org/T178762) (owner: MarcoAurelio) [13:41:15] Fundraising-Backlog, MediaWiki-extensions-FundraisingChart, Cleanup, Repository-Admins, and 2 others: Archive the FundraisingChart extension - https://phabricator.wikimedia.org/T178762#3769544 (Umherirrender) [13:42:00] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3717061 (jgleeson) I've reopened this task as we're currently not reporting... [13:42:44] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3717061 (jgleeson) a:jgleeson [13:58:39] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Cleanup, Repository-Admins, Patch-For-Review: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T178763#3769586 (Umherirrender) >>! In T178763#3755548, @Ejegg wrote: > @Umherirrender could you point me... [14:32:39] (PS10) Jgleeson: Added DonationsStats to DonationQueueConsumer to record stats and export to Prometheus file. Exported stats are scraped by Prometheus and then available to be graphed within Grafana. For full details of changes, read comment on phab ticket here: https://p [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 [16:07:01] hi mepps AndyRussG, are either of you online :) ? got a quick question regarding workflow [16:36:25] hey jgleeson, i'm here! [16:44:04] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3770211 (jgleeson) I have found a problem with my above calculation. The pro... [16:44:07] Fundraising-Backlog, MediaWiki-extensions-FundraisingChart, Cleanup, Repository-Admins, User-MarcoAurelio: Archive the FundraisingChart extension - https://phabricator.wikimedia.org/T178762#3770212 (MarcoAurelio) Open>Resolved [16:44:40] hey mepps, I'll save it for stand-up in 15 minutes. It's a general question on workflow so will be good to get feedback from all :) [16:45:09] hows your Friday going so far? [16:49:01] eh it's okay [16:54:23] are you feeling any better mepps? [16:54:50] a little bit, i started my morning with hot water with lemon, honey and cayenne and that seemed to make a big difference [16:55:01] good good! [17:01:23] fr-tech i'll ve a couple minutes late to standup [17:01:29] *be [17:22:00] spatton [17:23:30] This is where I type. Okely dokely. [17:56:46] hello and welcome from fundraising-tech, tskaff [17:57:10] Thank you ejegg! [17:57:29] welcome :) [17:59:06] tskaff! welcome [18:02:09] tskaff: welcome! [18:02:54] fr-tech here's my rebase workflow [18:03:04] So say you have Gerrit change A [18:03:20] let's say that's on branch review/A [18:03:22] locally [18:03:36] then Gerrit change B, on local branch review/B [18:04:07] So on A, you can be like, work work, commit --amend --all, etc etc [18:04:17] All the commits on A are just amend commits [18:05:01] So actual commit branch A is pointing to changes, though it's always just one commit away from master [18:05:25] every so often do a "git review -R" to send the latest up to Gerrit [18:05:33] Then on branch B it's the same flow [18:05:59] Except that every now and again you want to update B so its parent is the most recent version of A [18:06:22] So let's say you have your most recent stuff committed in local branch review/A [18:06:32] And want to rebase review/B onto that most recent stuff [18:06:59] So first git checkout review/B [18:07:41] then: git rebase -i --onto review/A review/B~1 review/B [18:08:10] It should show you a text file where there's just the latest version of B, no need to change anything there [18:08:15] And normally it just works [18:08:33] interesting [18:08:43] Don't recall exactly what the two last arguments do, something like telling git where to cut, or something like that [18:09:10] I would of assumed the final two arguments get you the contents of the last commit only on branch B [18:09:22] So that git realizes you just want to take the very last thing in B, stick it on top of A, and point the head of B to that [18:09:25] due to the range (review/B~1 review/B) [18:09:31] yeah something like that :) [18:09:55] got it [18:09:57] Then I look at it in one of those tree graph apps that Elliott doesn't use [18:10:35] and it should look like review/A branches off of master (from the HEAD or somewhere) and has just one commit, and then review/B branches off the commit of review/A [18:11:19] Then on branch B you can do git review -R and Gerrit should understand what's going on, and should show links and so on to the related Gerrit changes [18:12:17] And after someone +2's Gerrit change A, and it's merged into master, then it will be possible for B to be merged as well [18:12:25] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3770749 (jgleeson) Using the above calculation, I am getting the following s... [18:12:30] (after someone +2's that one, too) [18:14:17] what does the '-R' flag do? [18:14:40] ah [18:14:47] -R, --no-rebase Don't rebase changes before submitting. [18:18:03] jgleeson: yeah... I just always use it by default [18:18:16] There is definitely some controversy about this workflow [18:18:56] I'm basically totally acclimated to it and in a few years will not be able to conceive of anything different [18:19:31] One issue about it is that with these automatic merges to master, you may not ever have tested the exact state of the code as it in master [18:19:53] So sometimes you may wish to to that... i.e. download the latest master after stuff has merged and poke at it a bit... [18:19:56] :) [18:20:10] jgleeson: which ticket were you asking about? [18:20:57] This is the ticket I have resurrected https://phabricator.wikimedia.org/T179214 [18:21:01] ejegg [18:21:28] I've added some comments covering why and my approach [18:22:01] although there's a flaw in the calculation I'm using which might obfuscate the actual throughput rate so wanted to run that by you to see if you can think of a better way to record the data [18:22:04] jgleeson: oh yeah, actual imports per second sound good! [18:31:11] ejegg when you have a minute I'd be interest to hear what you think on tracking the average donations per second vs the actual [18:31:17] interested* [18:33:34] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3770866 (Ejegg) One more wrinkle to consider is that we're not running these... [18:34:47] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising-Backlog: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3770878 (Ejegg) The scheduling data is a bit scattered, however. The fact th... [18:38:55] jgleeson: maybe we should be using a 'counter' prometheus type for the processed counts [18:39:09] I think the current graph is a 'gauge' by default [18:39:20] yeah that's a good point [18:39:35] at the moment it's just being output as a gauge by the exporter [18:40:10] would the counter type give us rates on the prometheus side? [18:41:01] potentially, but I imagine it would be limited to rates per window of the Prometheus scraping schedule [18:41:27] ah, right [18:41:46] that's so frustrating [18:41:56] Jeff_Green do you know how often Prometheus scrapes fundraising tech boxes? [18:42:04] we need to set up that push collection [18:42:32] think he said it's 1x/min [18:42:37] jgleeson: I think it's 1 min but I could be wrong [18:42:44] yeah that ^^^ [18:43:10] thanks [18:44:10] hmm that highlights another flaw in my current approach [18:45:21] a 1 minute scraping cycle means that Prometheus will only see the last QueueConsumer batch run stats when it scrapes, potentially missing any other runs that finished earlier within the minute [18:45:56] jgleeson: fortunately we don't run any of the consumers more than 1x/min [18:46:12] and the only one we run that often is the banner history queue consumer [18:47:33] that would only affect the consumption rates stuff, as the other stats data is moving average so is accurate at point of scraping... I think [18:47:49] ah, that's good [18:49:08] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, and 4 others: Registering test in impressions - https://phabricator.wikimedia.org/T176334#3770908 (Pcoombe) Thanks for the work on this @AndyRussG. I'... [18:49:16] donations per minute doesn't feel like a bad starting point [18:49:42] although seconds would be nicer for more immediate alerting in the event of a problem [18:50:22] i think our other critical service monitoring is every 5 minutes [18:50:28] that's the icinga checks [18:50:39] Wikimedia-Fundraising, Android-app-feature-Feeds, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, and 2 others: Big English Mobile App Fundraising 2017 - https://phabricator.wikimedia.org/T180741#3770919 (TSkaff) Thanks so much for starting this Robin! Sam/Jessica & I will chat about co... [18:51:48] well I'm gonna call it a day, my wife is reminding me that we need to go food shopping :) [18:51:56] have a great weekend! [18:52:11] catch up with you on Monday ejegg on this subject. Have a great weekend fr-tech! bye for now [19:47:28] Wikimedia-Fundraising-Banners: Donation form Other amount field: 'minimum amount' error message - https://phabricator.wikimedia.org/T180751#3771099 (Pcoombe) I agree that confusion about the input seems most likely. If you click outside the input after selecting it, it looks just like any other selected butt... [20:21:10] can we close this ejegg: https://phabricator.wikimedia.org/T172202 [20:24:14] Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, and 10 others: Create orphan rectifier for PayPal Express Checkout - https://phabricator.wikimedia.org/T172202#3771198 (mepps) @ejegg can we close this? [20:29:01] hey ejegg i have my changes open for pr with civi, and i just reviewed the sprint board and there's not much i can contribute on, any areas you need help? [20:36:44] Fundraising-Backlog: Update Paypal API certificate - https://phabricator.wikimedia.org/T180844#3771203 (Ejegg) [20:39:09] Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, and 10 others: Create orphan rectifier for PayPal Express Checkout - https://phabricator.wikimedia.org/T172202#3771219 (Ejegg) Let's test it again! I fixed the... [20:41:03] Fundraising-Backlog, FR-Amazon, MediaWiki-extensions-DonationInterface: Amazon pay: cross-domain issue in mobile safari - https://phabricator.wikimedia.org/T180845#3771221 (Ejegg) [20:41:37] (CR) Ejegg: [C: 2] Updated behaviour when queue is populated from dump file to detect whether additional info source headers are present and if not inject them [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/390338 (owner: Jgleeson) [20:42:42] (Merged) jenkins-bot: Updated behaviour when queue is populated from dump file to detect whether additional info source headers are present and if not inject them [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/390338 (owner: Jgleeson) [20:50:10] ut-oh, lappy froze hard, and is stuck on tge grub screen after reboot [21:07:13] whew, back [21:07:19] just needed a little rest I guess? [21:11:49] (PS10) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [21:13:54] (CR) jerkins-bot: [V: -1] Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [21:15:46] (PS11) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501)