[00:05:38] (PS13) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [00:06:43] (CR) Ejegg: [C: 2] "Looks good! I didn't notice PS1 was based on a revision from before that selection fix." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392536 (https://phabricator.wikimedia.org/T176419) (owner: Pcoombe) [00:07:39] (CR) jerkins-bot: [V: -1] Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [00:08:52] (Merged) jenkins-bot: Fix card type selection spacing on mobile [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392536 (https://phabricator.wikimedia.org/T176419) (owner: Pcoombe) [00:09:04] heading to dinner, but I'll probably check back in later [00:10:14] (CR) XenoRyet: "Nevermind, that broke more than it fixed." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [00:15:18] (CR) XenoRyet: "Anyway, the remaining issue seems to be that the blur event is causing the click event to miss its target element because the page moves." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [00:49:29] (PS14) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [00:51:33] (CR) jerkins-bot: [V: -1] Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [00:53:11] (PS15) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [00:55:17] (CR) jerkins-bot: [V: -1] Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [00:56:53] (PS16) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [00:58:50] (CR) jerkins-bot: [V: -1] Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [01:00:00] (PS17) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [01:29:52] (PS1) Eileen: Align whitespace to drupal std. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392553 [01:40:38] (PS2) Eileen: Align whitespace to drupal std. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392553 [01:46:46] (PS1) Eileen: Move basic declaration of epochtime to parent. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392555 (https://phabricator.wikimedia.org/T172423) [04:00:42] (PS1) Eileen: Apply drupal formatting to offline2civicrm.module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392565 [04:00:45] (PS1) Eileen: [WIP] add stripe import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392566 (https://phabricator.wikimedia.org/T172423) [14:43:21] pcoombe: hi! can I bother you for a quick link to the banner code used to detect the popups test? thx!!! :) [14:43:25] fr-tech morning!! [15:12:17] AndyRussG: line 192 of https://meta.wikimedia.org/wiki/MediaWiki:FundraisingBanners/CoreJS-2017.js [15:15:31] AndyRussG: line 192 of https://meta.wikimedia.org/wiki/MediaWiki:FundraisingBanners/CoreJS-2017.js [15:15:54] good morning AndyRussG and jgleeson! [15:18:08] pcoombe: thanks!! [15:18:14] mepps: hey :) [15:18:20] hi all! [15:18:51] ejegg: hullo [15:23:18] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Unplanned-Sprint-Work: Update Paypal API certificate - https://phabricator.wikimedia.org/T180844#3778191 (Ejegg) Open>Resolved Checked on it - ours is already the 2048 bit type, as we replaced it last October. No need to do anything more! [15:26:04] hello fr-tech :) [15:31:31] hello! [15:34:02] hi jgleeson ! [15:34:49] I'm currently watching videos on how to use a yubikey with chrome os [15:35:06] oh, can it do special tricks? [15:36:13] jgleeson: morning [15:36:15] :) [16:07:49] (PS1) Mepps: Filter for ios and safari [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392665 (https://phabricator.wikimedia.org/T176913) [16:09:56] (CR) jerkins-bot: [V: -1] Filter for ios and safari [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392665 (https://phabricator.wikimedia.org/T176913) (owner: Mepps) [16:15:15] fr-tech I was considering backing up my local ubuntu files today so I could format and reinstall with an encrypted partition as discussed on yesterdays call. I'm now thinking it makes sense to finish off the tickets I've got in code review first before starting this process as the lead time to get [16:15:57] (CR) Ejegg: [C: 2] Apply drupal formatting to offline2civicrm.module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392565 (owner: Eileen) [16:16:29] setup again might push out the release of the new Prometheus metrics work. [16:18:28] (PS3) Ejegg: Align whitespace to drupal std. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392553 (owner: Eileen) [16:18:38] (PS2) Ejegg: Move basic declaration of epochtime to parent. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392555 (https://phabricator.wikimedia.org/T172423) (owner: Eileen) [16:18:45] (PS2) Ejegg: Apply drupal formatting to offline2civicrm.module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392565 (owner: Eileen) [16:18:54] (CR) Ejegg: [C: 2] Align whitespace to drupal std. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392553 (owner: Eileen) [16:19:01] (CR) Ejegg: [C: 2] Move basic declaration of epochtime to parent. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392555 (https://phabricator.wikimedia.org/T172423) (owner: Eileen) [16:20:38] (CR) jerkins-bot: [V: -1] Align whitespace to drupal std. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392553 (owner: Eileen) [16:20:39] (CR) jerkins-bot: [V: -1] Move basic declaration of epochtime to parent. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392555 (https://phabricator.wikimedia.org/T172423) (owner: Eileen) [16:20:41] (CR) jerkins-bot: [V: -1] Apply drupal formatting to offline2civicrm.module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392565 (owner: Eileen) [16:20:43] (CR) jerkins-bot: [V: -1] Apply drupal formatting to offline2civicrm.module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392565 (owner: Eileen) [16:24:32] (CR) Ejegg: [C: 2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392555 (https://phabricator.wikimedia.org/T172423) (owner: Eileen) [16:26:25] (CR) jerkins-bot: [V: -1] Move basic declaration of epochtime to parent. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392555 (https://phabricator.wikimedia.org/T172423) (owner: Eileen) [16:26:27] (CR) jerkins-bot: [V: -1] Apply drupal formatting to offline2civicrm.module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392565 (owner: Eileen) [16:27:23] (CR) Ejegg: [V: 2 C: 2] Move basic declaration of epochtime to parent. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392555 (https://phabricator.wikimedia.org/T172423) (owner: Eileen) [16:27:47] (CR) Ejegg: [V: 2 C: 2] Apply drupal formatting to offline2civicrm.module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392565 (owner: Eileen) [16:31:35] (PS2) Mepps: Filter for ios and safari [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392665 (https://phabricator.wikimedia.org/T176913) [16:33:47] (Merged) jenkins-bot: Move basic declaration of epochtime to parent. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392555 (https://phabricator.wikimedia.org/T172423) (owner: Eileen) [16:33:49] (CR) jerkins-bot: [V: -1] Apply drupal formatting to offline2civicrm.module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392565 (owner: Eileen) [16:35:11] (PS2) Ejegg: Fix tests for I7afaa955a4b393ef00b11e420709bd62b84fbc71 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/391571 [16:44:03] (CR) Ejegg: Do per-field client side validdation. (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [16:59:43] Wikimedia-Fundraising, Android-app-feature-Feeds, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, and 2 others: Big English Mobile App Fundraising ideas 2017 - https://phabricator.wikimedia.org/T180741#3778521 (schoenbaechler) Hey @JMinor, we were just wondering, is a cookie set in the... [17:02:24] hey ejegg i put a question on this patch a while ago: https://gerrit.wikimedia.org/r/#/c/288527/ [17:02:46] oh, sorry I missed it [17:02:47] looking [17:03:17] and this one too: https://gerrit.wikimedia.org/r/#/c/288527/ [17:03:28] do we have a preferred config format for stuff on production (json, yaml, ini...)? [17:03:47] (CR) Ejegg: "No need, the translation magic takes care of that" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288527 (owner: Ejegg) [17:03:56] (CR) Mepps: [C: 2] Remove some unused and redundant i18n keys [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288527 (owner: Ejegg) [17:03:59] (PS4) Mepps: Remove some unused and redundant i18n keys [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288527 (owner: Ejegg) [17:04:03] AndyRussG: I think we're moving to yaml [17:04:09] This is for configuring the centralnotice analytics lib, for creating grafana graphs (and also use in Jupyter) [17:04:20] ejegg: K! [17:04:22] :) [17:04:24] at least for fundraising-specific stuff [17:04:33] yamlp [17:04:47] ("yup" + yaml) [17:05:15] mv config.json config.yaml [17:19:54] What about python dependencies? Do we have some hardened way of bringing them in? [17:20:53] Is that gonna be a pain for cwd and Jeff_Green? [17:29:00] back in a bit! [17:30:19] python deps for yaml parsing? [17:30:24] (CR) Ejegg: "Looks good, just one bit of whitespace inconsistency" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392665 (https://phabricator.wikimedia.org/T176913) (owner: Mepps) [18:00:35] (PS18) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [19:08:31] cwd yes, and also for querying Druid [19:08:50] cwd: [19:08:51] (PS3) Mepps: Filter for ios and safari [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392665 (https://phabricator.wikimedia.org/T176913) [19:08:53] https://github.com/druid-io/pydruid [19:08:56] ^ [19:10:47] AndyRussG: i think i am missing the context, is there a task? [19:11:37] generally if there's an apt package deps are easy, otherwise we'd probably package a .deb ourselves [19:17:09] Wikimedia-Fundraising, Android-app-feature-Feeds, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, and 2 others: Big English Mobile App Fundraising ideas 2017 - https://phabricator.wikimedia.org/T180741#3779004 (schoenbaechler) Hey @Pcoombe, I was wondering about the Android and iOS targ... [19:30:35] gotcha... Mmmm task is writing a bit of code to easily get banner impression rates. Should work in both Jupyter notebooks and as a job to create data for Prometheus [19:30:57] https://phabricator.wikimedia.org/T178930 [19:31:53] cwd: hmm don't see an apt for pydruid [19:32:01] I mean a deb [19:32:38] AndyRussG: would this be a thing that ran on frdev1001, and talked to stuff in the analytics cluster? [19:33:16] cwd don't recall where Prometheus slurps data from and where the jobs that write it are... [19:34:09] well, each machine has one or more exporters [19:34:13] except for trusty [19:34:26] for instance prometheus-mysqld-exporter [19:34:27] cwd I think it has to write to civi1001 [19:35:04] and has to query data from druid1001.eqiad.wmnet on the analytics cluster [19:35:26] so I don't know the best place to run stuff for that is [19:36:07] what civi dbs will it write to? [19:36:29] i thought all the impressions stuff was on staging [19:39:44] cwd: wouldn't write to a db, would write to text files to be read by Prometheus [19:40:29] This isn't the same impression dataset... it's stuff to pull from analytics that we can combine with pageviews to check that the rate of impressions to pageviews for a given target audience is within the expected range [19:41:09] Actually a very neat system, lets us run the majority of the queries we'd used to do on Hive, almost instantly [19:41:50] gotcha, yeah sounds like a good plan [19:42:20] so there will be a python script with that druid lib reading data from analytics and writing prometheus files? [19:45:02] yeah that's the idea :) [19:46:14] one thing we'll want to watch out for is disk space [19:46:27] i imagine it would be really easy to fill the disk up with analytics data [19:46:43] prometheus comes with a "figure it out yourself" approach to long term data storage [19:47:11] but is rumored to get unqueryable as the data set gets bigger than ram [19:47:42] so the user is supposed to figure out a way to store aggregated numbers long term [19:54:08] cwd: ah ok, interesting... This'll be my first time dabbling in Prometheus, no idea how purging old stuff is set up [19:55:04] it's in fact just aggregate data, which is what Druid does. So, total pageviews and total impressions per (whatever time granularity we decide, minute, hour, etc.) for each segment/campaign that we wish to monitor [19:55:45] whew... just got done lunch with adam, michelle, and their kids. restaurant with a 1 year ood and a 4 year old is not exactly relaxing... [19:56:21] ha [19:56:24] ejegg heheheh for sure [19:56:33] are they visiting you down south? [19:57:01] or did you come back until the visa gets sorted? [20:00:12] I have found that very few situations can really be described as 'relaxing' when a baby and a toddler are involved... [20:00:34] ^^ especially when at a restaurant [20:01:07] You ain't kidding there. Even purportedly family friendly places get hectic. [20:02:54] even when there's one of those enclosed playgrounds, you're always glancing over nervously to check they didn't get stuck in one of those tubular slides... [20:03:40] it's especially hard when the food arrives, but it's too hot for them to eat so you have to somehow distract them from the food right in front of them until it cools :( [20:03:53] cwd adam's wife was doing a workshop in a town an hour outside of Cusco [20:04:09] https://uproxx.files.wordpress.com/2013/09/sunny-timeshare-top.jpg?quality=100&w=650 [20:04:44] hehe, and this was a restaurant where the staff barely have room to get between the tables [20:05:12] I have nightmares that start with having my kids in a resteraunt like that... [20:07:10] XenoRyet: awwww [20:08:18] In reality, Marek actually does pretty well at resteraunts. Dylan is a bit more chaotic, but she's still little so that's kind of how it goes. [20:09:01] ejegg: Anyway, https://gerrit.wikimedia.org/r/388651 is ready for another look if you have a minute before the meeting. [20:09:23] aaarg I wish I had someone to distract me from hot food so I wouldn't try to eat it and burn myself [20:09:27] (just did exactly that) [20:09:49] :) [20:11:16] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288527 (owner: Ejegg) [20:11:55] I normally try to find the most visually exciting menu to use to shield the food on arrival and double up as something interesting for Oscar to look at while it cools. Although on a few occasions it ends up in the food. [20:14:03] XenoRyet: cool, I didn't realize you could pass parameters like that in setTimeout! [20:14:33] Yea, neither did I, but that turned out to be the secret sauce to make it work as expected. [20:14:55] d'oh, IE9 is still one of the JS browsers [20:15:07] jgleeson: hehehe sounds like a plan [20:15:27] XenoRyet: MDN says params are only supported in IE in 10+ [20:15:29] https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/setTimeout [20:15:57] Hmm... Ok. Let me see if I can get it to work the other way. [20:17:00] when I was trying that before though for some reason it was thinking di and fieldId were not defined. [20:17:11] Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Merge on addresses for MG - https://phabricator.wikimedia.org/T181088#3779205 (DStrine) [20:17:43] argh, closure scope madness! [20:17:59] Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Let dedupe run on orgs - https://phabricator.wikimedia.org/T181089#3779219 (DStrine) [20:18:12] Yep [20:18:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Merge on addresses for MG - https://phabricator.wikimedia.org/T181088#3779231 (DStrine) [20:18:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Let dedupe run on orgs - https://phabricator.wikimedia.org/T181089#3779232 (DStrine) [20:19:18] (PS4) Ejegg: Filter for ios and safari [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392665 (https://phabricator.wikimedia.org/T176913) (owner: Mepps) [20:19:29] (CR) Ejegg: [C: 2] Filter for ios and safari [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392665 (https://phabricator.wikimedia.org/T176913) (owner: Mepps) [20:20:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Can the engage import dedupe on import? - https://phabricator.wikimedia.org/T181090#3779233 (DStrine) [20:21:21] (Merged) jenkins-bot: Filter for ios and safari [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392665 (https://phabricator.wikimedia.org/T176913) (owner: Mepps) [20:31:07] fr-tech gonna be 1 min late to the meeting. [20:33:25] AndyRussG: meeting? [20:52:49] Fundraising-Backlog: thank you letter update - https://phabricator.wikimedia.org/T181093#3779298 (DStrine) [20:59:16] (PS2) Eileen: [WIP] add stripe import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392566 (https://phabricator.wikimedia.org/T172423) [21:20:15] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Google filters test TY emails to spam folder - https://phabricator.wikimedia.org/T180388#3779384 (Ejegg) Open>Resolved p:Triage>High [21:24:21] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog: Support MG event in LA on the 15th - https://phabricator.wikimedia.org/T179853#3779412 (DStrine) Open>Resolved [21:25:23] Fundraising Sprint Vaporwerewolf, Fundraising-Backlog: Scope and create tasks for Prometheus work - https://phabricator.wikimedia.org/T179842#3737918 (DStrine) Open>Resolved [21:31:24] (PS5) Ejegg: Remove some unused and redundant i18n keys [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288527 [21:38:34] Fundraising Sprint W 2017, Fundraising-Backlog: thank you letter update - https://phabricator.wikimedia.org/T181093#3779477 (DStrine) [21:38:36] Fundraising Sprint W 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Let dedupe run on orgs - https://phabricator.wikimedia.org/T181089#3779478 (DStrine) [21:38:38] Fundraising Sprint W 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Merge on addresses for MG - https://phabricator.wikimedia.org/T181088#3779479 (DStrine) [21:38:40] Fundraising Sprint W 2017, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Blocked cookie detection not working on payments-wiki - https://phabricator.wikimedia.org/T180975#3779480 (DStrine) [21:38:42] Fundraising Sprint Vaporwerewolf, Fundraising Sprint W 2017, Fundraising-Backlog, FR-Amazon, and 2 others: Amazon pay: cross-domain issue in mobile safari - https://phabricator.wikimedia.org/T180845#3779481 (DStrine) [21:38:44] Fundraising Sprint W 2017, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: instrument debugging for "Large banner limit and switch" mixin - https://phabricator.wikimedia.org/T180478#3779482 (DStrine) [21:38:47] Fundraising Sprint Vaporwerewolf, Fundraising Sprint W 2017, Fundraising-Backlog: Review emergency procedures for holidays - https://phabricator.wikimedia.org/T179843#3779484 (DStrine) [21:38:50] Fundraising Sprint Vaporwerewolf, Fundraising Sprint W 2017, Fundraising-Backlog: Track fundraising failmail volume in prometheus - https://phabricator.wikimedia.org/T179704#3779485 (DStrine) [21:38:52] Fundraising Sprint Vaporwerewolf, Fundraising Sprint W 2017, Fundraising-Backlog, FR-Smashpig, and 4 others: Amazon code should allow specifiying proxy parameters in configuration - https://phabricator.wikimedia.org/T180168#3779483 (DStrine) [21:38:54] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint W 2017, Fundraising-Backlog: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3779486 (DStrine) [21:38:56] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint W 2017, Fundraising-Backlog: Prometheus: Add seconds diff metric report [donation message enqueued => donation saved to civi] - https://phabricator.wikimedia.org/T179173#3779487 (DStrine) [21:38:58] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint W 2017, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Consolidate typical analytics queries (for example, for impression rates) into... - https://phabricator.wikimedia.org/T178930#3779488 [21:39:02] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint W 2017, Fundraising-Backlog, and 3 others: Make it easier to move from contact deleted by merge to the contact they were merged to - https://phabricator.wikimedia.org/T178003#3779489 (DStrine) [21:39:03] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint W 2017, Fundraising-Backlog, and 2 others: Improve major gifts email links when a contact has already been merged so there is not a findy-game - https://phabricator.wikimedia.org/T178000#3779490 (DStrine) [21:39:05] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint W 2017, Fundraising-Backlog, and 4 others: Adyen jobs should retry at least once on connect failure - https://phabricator.wikimedia.org/T177893#3779491 (DStrine) [21:39:07] Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint W 2017, and 4 others: Validation not clearing error on blur - https://phabricator.wikimedia.org/T176501#3779496 (DStrine) [21:39:11] Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint W 2017, and 5 others: adyen cookie error after entering information on mobile Safari - https://phabricator.wikimedia.org/T176913#3779495 (DStrine) [21:39:13] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, and 5 others: Registering test in impressions - https://phabricator.wikimedia.org/T176334#3779497 (DStrine) [21:39:15] Fundraising Sprint Vaporwerewolf, Fundraising Sprint W 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Civi Import - https://phabricator.wikimedia.org/T172423#3779499 (DStrine) [21:39:17] Fundraising Sprint W 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changing contact records from individual records to organization records - https://phabricator.wikimedia.org/T156193#3779501 (DStrine) [21:39:19] Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, and 11 others: Create orphan rectifier for PayPal Express Checkout - https://phabricator.wikimedia.org/T172202#3779500 (DStrine) [22:07:33] (PS19) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [22:09:33] (CR) jerkins-bot: [V: -1] Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [22:10:57] (PS20) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [22:22:07] huh, we totally don't cater to single-name donors [22:22:31] Besides Madonna, I think that's a common thing in Indonesia [22:22:50] Yea, we totally don't. [22:24:55] well, so far it's holding up under all the clicking and tabbing [22:25:30] Yea, it's working for all the paces I'm putting it through, but having written the thing I probably have some blind spots. [22:27:48] aw damn, i don't think it's your code, but the ideal 'Choose a Bank' error message just says 'bank' [22:28:54] Damn. Yea, that would be a seperate thing, but damn. [22:30:04] huh, somehow I got tabbed out of the first name thing after adding text without it revalidating [22:30:42] Huh. Can you get it again? [22:31:14] oh shoot, sorry, this was a different commit, i switched to check out the existing bank error message [22:31:17] :P [22:31:18] sorry [22:31:27] Whew, had me worried for a second there. [22:31:32] yeah, the existing error message is just 'bank' too [22:31:42] Did not want to have to think about an intermitent failure to validate. [22:32:40] oh yeah, I should check amount stuff [22:34:21] doesn't revalidate on blur, but existing validation seems good [22:36:06] Yea, I suppose I should go ahead and put the blur behavior on that one as well. Shouldn't come up really, but it might. [22:36:10] welllllll [22:36:24] Or you think leave well enough alone? [22:36:35] let's leave it be for now [22:36:53] 10-4 [22:36:57] make another ticket for that and the bank selection? [22:37:06] Sounds good. I'll do that. [22:39:20] Fundraising-Backlog: Additional Client Side Validation fixes - https://phabricator.wikimedia.org/T181105#3779696 (XenoRyet) [22:39:38] oh yeah, lemme just test the fiscal number [22:40:13] not that it should matter for big english [22:40:13] Yea. It works for me, but definitely give it another pair of eyes. [22:41:59] hmm, existing email validation allows double at signs [22:42:31] Fundraising-Backlog: Additional Client Side Validation fixes - https://phabricator.wikimedia.org/T181105#3779696 (Ejegg) Email validation could use a cleanup too, seems to allow double at signs [22:42:44] Oh that's a fun one. Must've always been that way. [22:45:13] Fundraising-Backlog: Additional Client Side Validation fixes - https://phabricator.wikimedia.org/T181105#3779718 (Ejegg) If the 'invalid email' error is showing and an autocorrect suggestion is given, clicking the autocorrection should hide the 'invalid email' error [22:46:34] ah drat, just noticed there's some old rapidhtml stuff dragged over in the amount validation [22:47:32] Fundraising Sprint RadioActivewear, Fundraising-Backlog, Graphite: Persistent colors for labels in Grafana - https://phabricator.wikimedia.org/T176173#3779720 (Krinkle) Aside from coding it into the data panels, you can also change it through the UI, which also ends up saving it tied to the metric in... [22:47:34] well, guess it's never going to be hit [22:47:37] Fundraising Sprint RadioActivewear, Fundraising-Backlog, Graphite: Persistent colors for labels in Grafana - https://phabricator.wikimedia.org/T176173#3779722 (Krinkle) Open>Resolved a:Krinkle [22:52:53] ah crud [22:53:19] XenoRyet: the currency conversion message is blocking submission [22:53:38] because it's got the .errorMsg styling [22:54:28] Hmm... [22:54:32] damn, is that beaking the existing paypal ec stuff? [22:54:58] so, we used to rely on the return values from the field validation fns to determine whether to submit [22:55:44] oh, it's not breaking paypal ec, it's just making sure the form doesn't auto-submit when we want to tell the donor we're converting [22:55:53] (PS1) AndyRussG: Add client-side setDebug() method [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/392735 (https://phabricator.wikimedia.org/T180478) [22:56:17] So that's ok, yea? [22:56:37] fr-tech ^ first patch for quick CN debug instrumentation [22:56:48] XenoRyet: the currently deployed code is ok [22:57:09] but the patch under review makes it impossible to submit when there's a currency conversion message displayed [22:57:39] because it never clears and looks like an error message. [22:57:45] yah [22:59:24] (PS2) AndyRussG: Add client-side setDebug() method [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/392735 (https://phabricator.wikimedia.org/T180478) [22:59:58] AndyRussG: so this is something you would call from banner code rather than the user adding '&debug=true' [23:01:23] ? [23:02:58] (CR) Ejegg: [C: -1] "Might need to use the return values of the validation functions instead of checking for .errorMsg classes." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [23:05:10] ejegg: gonna call it from the large banner and switch mixin [23:05:16] that patch is coming in a sec [23:05:26] the idea is to send debug info on the record impression call [23:05:53] oops, need an outlet... [23:19:38] ejegg ^ oops lemme fix something... [23:24:38] (PS3) AndyRussG: Add client-side setDebug() method [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/392735 (https://phabricator.wikimedia.org/T180478) [23:24:49] fr-tech ^ ... [23:26:14] AndyRussG: ah cool, I was just going to ask about the existing 'debug' use [23:29:27] (PS21) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [23:33:01] (CR) jerkins-bot: [V: -1] Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [23:33:10] AndyRussG: mind if I just edit the commit message to match the new fn name? [23:33:25] (PS1) AndyRussG: large banner limit: debugging instrumentation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/392743 (https://phabricator.wikimedia.org/T180478) [23:34:08] ejegg: sure... Or if u like I can do it, saves having to download and rebase the next patch (^) [23:34:14] (PS4) Ejegg: Add client-side setDebugInfo() method [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/392735 (https://phabricator.wikimedia.org/T180478) (owner: AndyRussG) [23:34:32] heh, that's the sort of thing I don't actually mind doing in the gerrit web ui [23:34:38] (PS5) AndyRussG: Add client-side setDebugInfo() method [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/392735 (https://phabricator.wikimedia.org/T180478) [23:34:51] wouldn't trust it for editing much code... [23:34:57] hehehe [23:35:16] oh, next patch, i see what you meant [23:35:18] control-R refresh! erase codebase! [23:35:42] (CR) Ejegg: [C: 2] Add client-side setDebugInfo() method [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/392735 (https://phabricator.wikimedia.org/T180478) (owner: AndyRussG) [23:36:08] (PS2) AndyRussG: large banner limit: debugging instrumentation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/392743 (https://phabricator.wikimedia.org/T180478) [23:36:16] (PS22) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [23:36:25] ejegg: ^ [23:36:53] looking.... [23:37:09] any worry that the debug info will be too long? [23:38:02] (Merged) jenkins-bot: Add client-side setDebugInfo() method [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/392735 (https://phabricator.wikimedia.org/T180478) (owner: AndyRussG) [23:38:24] fr-tech sorry to bother, if we're going for a pre-test speed deploy, it might be fun to have a few more eyes ^ (no disrespect meant to ejegg fantabulous CR skills of course!) [23:38:36] ejegg: I did worry about that [23:38:43] and then dismissed the worry without any evidence [23:38:56] I don't feel like I'd like to do the magic number thing [23:39:04] could reduce the length of the prefix-y bit to an acronym [23:39:19] yah, acronym is exactly what I was thinking [23:40:47] (CR) jerkins-bot: [V: -1] Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet) [23:40:50] hmm, i remember some kind of length checking... was that banner history? [23:40:56] ejegg: k acronymin' [23:41:00] yeah that's BH [23:41:13] definitely needed there, it goes over the limit easily [23:41:54] (PS23) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) [23:41:56] (PS3) AndyRussG: large banner limit: debugging instrumentation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/392743 (https://phabricator.wikimedia.org/T180478) [23:42:02] ^ [23:46:34] AndyRussG: i notice you're not instrumenting legacy cookie stuff - the switch to localstorage was long enough ago it shouldn't matter? [23:46:54] ejegg: That validation patch should be back to using return values now. [23:47:03] looking XenoRyet [23:47:07] Thanks [23:51:37] ejegg: hmmm looking [23:53:03] ejegg: didn't really think of it, makes sense, though, if we're trying to lock down possible bugs :) [23:55:14] ejegg: the legacy cookie is different from non-legacy cookies... we should be setting non-legacy cookies on clients with no localStorage [23:56:16] (PS4) AndyRussG: large banner limit: debugging instrumentation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/392743 (https://phabricator.wikimedia.org/T180478) [23:56:23] ejegg: ^