[00:01:46] <AndyRussG>	 ejegg: SWAT deploy window starting........
[00:01:52] <AndyRussG>	 aaaarg
[00:02:01] <ejegg>	 oh no!
[00:02:06] <AndyRussG>	 it's OK
[00:02:18] <AndyRussG>	 they accept patches even after the window has started
[00:02:26] <ejegg>	 XenoRyet: mind cross-checking Andy's last couple of patches?
[00:02:38] <XenoRyet>	 Yea, let me take a look.
[00:03:18] <XenoRyet>	 We're looking at https://gerrit.wikimedia.org/r/#/c/392735 and https://gerrit.wikimedia.org/r/#/c/392743 yea?
[00:03:19] <AndyRussG>	 XenoRyet: thanks!!!! https://gerrit.wikimedia.org/r/#/c/392735/ https://gerrit.wikimedia.org/r/#/c/392743/
[00:03:25] <AndyRussG>	 yup!
[00:05:00] <wikibugs>	 (CR) Ejegg: [C: 1] "Looks legit, waiting for cross-check!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/392743 (https://phabricator.wikimedia.org/T180478) (owner: AndyRussG)
[00:05:47] <wikibugs>	 (CR) XenoRyet: [C: 2] "Yea, looks good to me too." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/392743 (https://phabricator.wikimedia.org/T180478) (owner: AndyRussG)
[00:06:19] <XenoRyet>	 First one looks good as well, and has already been graced with the illustrious +2
[00:09:33] <AndyRussG>	 XenoRyet: ejegg thanks much!!!
[00:10:44] <wikibugs>	 (Merged) jenkins-bot: large banner limit: debugging instrumentation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/392743 (https://phabricator.wikimedia.org/T180478) (owner: AndyRussG)
[00:12:07] <wikibugs>	 (PS1) AndyRussG: Add client-side setDebugInfo() method [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/392754 (https://phabricator.wikimedia.org/T180478)
[00:12:12] <wikibugs>	 (PS1) AndyRussG: large banner limit: debugging instrumentation [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/392755 (https://phabricator.wikimedia.org/T180478)
[00:18:39] <wikibugs>	 (CR) AndyRussG: [C: 2] Add client-side setDebugInfo() method [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/392754 (https://phabricator.wikimedia.org/T180478) (owner: AndyRussG)
[00:18:57] <wikibugs>	 (CR) AndyRussG: [C: 2] large banner limit: debugging instrumentation [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/392755 (https://phabricator.wikimedia.org/T180478) (owner: AndyRussG)
[00:20:34] <wikibugs>	 (Merged) jenkins-bot: Add client-side setDebugInfo() method [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/392754 (https://phabricator.wikimedia.org/T180478) (owner: AndyRussG)
[00:20:52] <wikibugs>	 (Merged) jenkins-bot: large banner limit: debugging instrumentation [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/392755 (https://phabricator.wikimedia.org/T180478) (owner: AndyRussG)
[00:22:06] <XenoRyet>	 ejegg: So, that latest version of the validation patch passing muster so far?
[00:25:53] <ejegg>	 XenoRyet: sorry, getting back to that, had to get some stats
[00:26:06] <XenoRyet>	 Heh, no worries
[00:28:04] <AndyRussG>	 fr-tech tested on the beta cluster, works fine, deployin'
[00:28:10] <ejegg>	 woohoo!
[00:28:11] <XenoRyet>	 Nice
[00:29:59] <AndyRussG>	 just kicking the browser tests to be really sure
[00:37:00] <AndyRussG>	 browser tests check out toooooo
[00:37:13] <XenoRyet>	 Good times
[00:37:23] <AndyRussG>	 indeed....
[00:37:30] <AndyRussG>	 XenoRyet ejegg thanks much for the super-speedy CR!!
[00:37:41] <AndyRussG>	 going live on prod now
[00:37:42] <XenoRyet>	 No worries, happy to help
[00:41:54] <ejegg>	 AndyRussG: if you're free I'd love a cross-check on this validation stuff too, even if you're not familiar with the context
[00:42:06] <ejegg>	 https://gerrit.wikimedia.org/r/388651
[00:48:59] <AndyRussG>	 ejegg: sure.... is there a timeline of urgency there too?
[00:49:16] <ejegg>	 hehe, it's tonight or january...
[00:49:25] <AndyRussG>	 ejegg: gotcha :)
[00:49:29] <XenoRyet>	 Yea, pretty much now or never ;-)
[00:50:23] <XenoRyet>	 I'm cool to stay on for deploy and post-deploy monitoring once we get to that step.  Need to make sure it's good to go though.
[00:50:55] <AndyRussG>	 ejegg: so now di.form.core.validate module just brings in dependencies, no actual script?
[00:51:03] <XenoRyet>	 Actually, I think I'm going to pop out to get Marek real fast, be back on in a few.
[00:51:32] <ejegg>	 AndyRussG: oh shoot, is that the case? I thought the .validate module brought in the validation.js
[00:51:49] <ejegg>	 hadn't paid enough attention to that part
[00:52:38] <AndyRussG>	 ejegg: just looking at the diff for extension.json. It removes a script declaration
[00:53:42] <AndyRussG>	 removes "modules/validate_input.js"
[00:55:12] <AndyRussG>	 why is there a timeout on some validations and not others?
[00:57:40] <AndyRussG>	 yea completely unfamiliar with how this works...
[00:57:51] <AndyRussG>	 K I see the script that was removed from that module is also deleted....
[01:01:50] <wikibugs>	 (CR) Ejegg: [C: -1] "Latest change de-scopes a variable and short circuits email validation when country is bad. Also, error / hasError / failed / invalid is c" (9 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet)
[01:02:55] <ejegg>	 good catch AndyRussG, that .validate should go away
[01:03:29] <ejegg>	 and we can fold the did-you-mean into the errorMessages
[01:04:38] <ejegg>	 oh man, noscript-message is in the list of messages provided by javascript...
[01:06:28] <AndyRussG>	 ejegg: where else would you put it?
[01:06:50] <AndyRussG>	 all messages go that way
[01:07:15] <ejegg>	 heh, it should be rendered right into the page by php, then hidden by js
[01:07:47] <ejegg>	 or... no, it's right inside the <noscript> element, so no need to even hide it
[01:09:58] <AndyRussG>	 meh, those who won't enable JS should just suffer
[01:10:16] <AndyRussG>	 knowning that there was a message for them that they'll never get
[01:10:33] <ejegg>	 heh, they'll actually see the message - we are doing the rendering
[01:10:49] <ejegg>	 it's just redundantly sent along with load.php
[01:11:13] <ejegg>	 XenoRyet: did you see AndyRussG's observation about the empty .validate module?
[01:11:22] <ejegg>	 should just replace that with the dependencies directly
[01:11:44] <XenoRyet>	 No, just catching up now.
[01:13:04] <ejegg>	 looks like it's getting on towards closing time in this cafe
[01:13:13] <ejegg>	 i'll be back on later
[01:13:30] <XenoRyet>	 Think this is still in range of happening tonight, or are we getting too late?
[01:30:00] <AndyRussG>	 XenoRyet: I can be around-ish for a while and then back on fully a bit later, but I'm not sure +2'ing falls within the scope of my abilities
[01:30:25] <XenoRyet>	 Yea, probably need ejegg for the +2
[01:30:55] <AndyRussG>	 I can kep poking tho :)
[01:33:46] <wikibugs>	 (PS24) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501)
[01:34:08] <XenoRyet>	 Yea, please do let me know any other issues you spot.
[01:34:49] <wikibugs>	 (CR) jerkins-bot: [V: -1] Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet)
[01:36:54] <wikibugs>	 (PS25) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501)
[01:37:43] <AndyRussG>	 XenoRyet: wil don!
[01:37:46] <AndyRussG>	 will do!
[01:52:17] <wikibugs>	 (PS26) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501)
[01:54:52] <XenoRyet>	 ejegg|afk: I've gotta step away for a few, but that patch is ready for another looking over and I'll be back on in a little bit.
[02:09:21] <AndyRussG>	 (I'll also be back on in a bit)
[03:06:51] <wikibugs>	 (CR) Ejegg: "Dang, it's skipping validation again when clicking the buttons from being focused in a field. Trying to diagnose..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet)
[03:26:49] <XenoRyet>	 Man, I swear I tested that before the last push.
[03:32:12] <XenoRyet>	 ejegg: I'm almost remembering something weird about those buttons.  Like clicks that are in the grey area but not right on the logo or the radio button act a little differently for some reason.
[03:32:53] <XenoRyet>	 That seems to be what's happening here, but I'm not totally understanding why the second click works in that case.
[03:33:27] <wikibugs>	 (CR) Ejegg: Do per-field client side validdation. (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet)
[03:35:08] <AndyRussG>	 Checkin' it out now....
[03:38:00] <AndyRussG>	 Yea js events bubbling can be funky...
[03:48:05] <ejegg>	 XenoRyet: oh, is it just a click target issue?
[03:48:42] <ejegg>	 hmm, no, if my first click is right on the radio button it still acts the same
[03:49:13] <ejegg>	 but yeah, if I click back into the field and click again on the radio button all the validations fire
[03:50:00] <XenoRyet>	 Weird, clicking right on the radio is working for me on the first click.
[03:51:01] <XenoRyet>	 Wonder why we're getting different behavior
[03:53:11] <ejegg>	 firefox?
[03:53:21] <ejegg>	 i'll take a look at chrome
[03:54:04] <XenoRyet>	 Yea, firefox and chrome.  I'm on the Adyen gateway too, but I can't see that should matter.
[03:54:25] <ejegg>	 durn
[03:54:53] <XenoRyet>	 maybe I stealth fixed it while I was working on that amount function?
[03:55:04] <wikibugs>	 (PS27) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501)
[03:55:28] <ejegg>	 well shoot, pcoombe made a little change to the targets yesterday, lemme take another look at that
[03:56:25] <XenoRyet>	 Oh, it might be to do with that.  I don't think I'll have that patch locally.
[03:58:29] <XenoRyet>	 Or no.  Rebased and I'm still getting right behavior on the first click
[04:00:24] <ejegg>	 argh, sorry, isNaN('asda') apparently DOES return true.
[04:05:19] <XenoRyet>	 k, I'll put that back.
[04:07:54] <wikibugs>	 (PS28) XenoRyet: Do per-field client side validdation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501)
[04:14:37] <ejegg>	 XenoRyet: I'm still a bit confused why the setTimeout helps
[04:15:09] <ejegg>	 shouldn't 'return true' after the validation keep the bubbling happening?
[04:15:45] <XenoRyet>	 The theory goes that blur fires before the click, and since blur moves things around, by the time the click fires it isn't where you thought it was.  The timeout gives the click time to fire properly.
[04:16:16] <ejegg>	 isn't where you thought it was?
[04:16:52] <XenoRyet>	 Yea, so the error message pops up and moves the payment method buttons down a few lines.  After that happens where you clicked sometimes isn't on the button anymore.
[04:17:00] <ejegg>	 ohhhh
[04:18:15] <XenoRyet>	 So the delay lets the click finish before blur moves the button.
[04:19:11] <XenoRyet>	 On a different tack,  I can get the validation to fail to fire if I click sort of just above the radio button, but that behavior is occuring on master as well, so I'm not sure what's going on there.
[04:19:29] <XenoRyet>	 Oh hey, happens on prod too
[04:20:35] <ejegg>	 ah, so that's just a click target problem, I guess
[04:21:01] <ejegg>	 there's an input and a label, and clicking either of those will trigger the stuffs
[04:21:11] <XenoRyet>	 Still weird if you're getting it to fail right on the radio though.
[04:21:51] <ejegg>	 lemme see...
[04:23:31] <ejegg>	 shoot, i swear it was doing that for me before
[04:24:20] <ejegg>	 clicking right on the button seems to be working for me now
[04:25:39] <XenoRyet>	 Maybe it did get cleared up sometime in addressing the other issues
[04:27:14] <ejegg>	 well, this is feeling like an improvement, even if there's potential to clean up more later
[04:27:43] <XenoRyet>	 Definitely  more we can clean up, yea.  Running out of time though.
[04:28:40] <ejegg>	 phooey, paypal with initial no amount is borken
[04:29:03] <ejegg>	 paypal ec that is
[04:31:09] <XenoRyet>	 Huh, wonder what I did to cause that.
[04:33:42] <ejegg>	 somehow calling $.each with undefined as the array, it looks like
[04:34:18] <ejegg>	 ugh, we need browser testing
[04:35:05] <ejegg>	 think i need to hit the hay soon. sorry :(
[04:35:24] <ejegg>	 lemme try one thing for that click target first tho
[04:36:34] <XenoRyet>	 Yea, if it's not gonna happen tonight, then we'll just have to wait.  I don't want to keep you up all hours over it, existing validation is still pretty good.
[04:47:35] <wikibugs>	 (PS1) Ejegg: Use padding instead of margin to close a gap [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392772
[04:51:58] <XenoRyet>	 That doesn't seem to be affecting behavior to me.
[04:55:09] <wikibugs>	 (PS2) Ejegg: Use padding instead of margin to close a gap [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392772
[04:55:32] <ejegg>	 OK, that should make the whole dang grey area a click target
[04:55:41] <XenoRyet>	 looking
[04:56:45] <ejegg>	 eh, a few pixels at the edge still not clicky, but close
[04:57:12] <XenoRyet>	 Yea.  In chrome it looks like it might have pushed things slightly off center as well.
[04:57:46] <XenoRyet>	 Looks like maybe just the width of the non-clicky area
[04:58:05] <ejegg>	 ah, oh well
[04:58:21] <XenoRyet>	 Can't say we didn't try.
[04:58:53] <XenoRyet>	 Anyway, thanks for all the CR
[04:59:12] <wikibugs>	 (PS3) Ejegg: Use padding instead of margin to close a gap [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392772
[04:59:49] <XenoRyet>	 Oh, that one looks good.
[05:02:05] <XenoRyet>	 Yea, seems to work everywhere, clicky right out to the edges.
[05:02:37] <wikibugs>	 (CR) XenoRyet: [C: 2] Use padding instead of margin to close a gap [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392772 (owner: Ejegg)
[05:03:12] <ejegg>	 :)
[05:03:24] <XenoRyet>	 At least we got one win tonight
[05:03:36] <ejegg>	 thanks for sticking it out!
[05:03:42] <XenoRyet>	 Yea no worries
[05:04:24] <wikibugs>	 (Merged) jenkins-bot: Use padding instead of margin to close a gap [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392772 (owner: Ejegg)
[05:08:27] <ejegg>	 ah drat, forgot to check mobile :( not gonna deploy that right now
[05:08:43] <XenoRyet>	 Ah right.  Mobile
[05:09:06] <ejegg>	 oh hey, looks like an easy fix, actually
[05:15:12] <wikibugs>	 (PS1) Ejegg: Clicky to the edges on mobile too [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392774
[05:18:16] <XenoRyet>	 Code looks fine.  How do you get to the mobile version of the page?
[05:19:16] <ejegg>	 just using the mobile view in dev tools
[05:19:57] <ejegg>	 or 'responsive design mode' in ff-speak
[05:21:10] <ejegg>	 eh, still a bit of not-clicky at the bottom for mobile
[05:21:34] <XenoRyet>	 I always manage to forget that mode is there.
[05:21:40] <XenoRyet>	 Anyway, yea, not clicky on the bottom.
[05:23:03] <ejegg>	 oh, it's the height
[05:23:13] <ejegg>	 can I just put that on the label?
[05:24:58] <wikibugs>	 (PS2) Ejegg: Clicky to the edges on mobile too [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392774
[05:26:05] <XenoRyet>	 Yep, looks like that's got it.
[05:26:14] <ejegg>	 :D
[05:27:10] <wikibugs>	 (CR) XenoRyet: [C: 2] Clicky to the edges on mobile too [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392774 (owner: Ejegg)
[05:27:54] <ejegg>	 funny how the fix is for an input to live inside its label, but ehh
[05:28:21] <XenoRyet>	 ehh indeed
[05:29:02] <wikibugs>	 (Merged) jenkins-bot: Clicky to the edges on mobile too [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392774 (owner: Ejegg)
[05:30:09] <wikibugs>	 (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/392775
[05:30:13] <wikibugs>	 (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/392775 (owner: Ejegg)
[05:32:00] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/392775 (owner: Ejegg)
[05:32:19] <XenoRyet>	 I better go check on the kids and attend to some chores, but I'll pop back on in a while to make sure the delpoy went ok.
[05:32:50] <XenoRyet>	 Again, thanks for all that CR
[05:33:36] <wikibugs>	 (PS1) Ejegg: Un-shrink mobile card logos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392776
[05:36:34] <wikibugs>	 (CR) XenoRyet: [C: 2] "Yea, looks better." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392776 (owner: Ejegg)
[05:41:20] <wikibugs>	 (Merged) jenkins-bot: Un-shrink mobile card logos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392776 (owner: Ejegg)
[05:43:27] <wikibugs>	 (PS1) Ejegg: One more mobile fix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392777
[05:44:18] <ejegg>	 XenoRyet|afk: sorry, realized that previous one was a bit borked on the 3-per-line view
[05:44:33] <ejegg>	 needed to get rid of the useless padding
[05:46:44] <ejegg>	 ah, what fun
[05:56:21] <wikibugs>	 (CR) Ejegg: [C: 2] One more mobile fix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392777 (owner: Ejegg)
[05:57:12] <wikibugs>	 (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/392779
[05:57:19] <wikibugs>	 (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/392779 (owner: Ejegg)
[05:58:16] <wikibugs>	 (Merged) jenkins-bot: One more mobile fix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392777 (owner: Ejegg)
[05:58:18] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/392779 (owner: Ejegg)
[06:00:36] <wikibugs>	 (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/392780
[06:00:56] <wikibugs>	 (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/392780 (owner: Ejegg)
[06:02:06] <wikibugs>	 (PS2) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/392780
[06:05:41] <wikibugs>	 (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/392780 (owner: Ejegg)
[06:10:06] <wikibugs>	 (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/392780 (owner: Ejegg)
[06:28:35] <ejegg>	 !log updated payments-wiki from f871160c83d5be95bf25587aaf8bb87b8b56a809 to 1ca91b1b029161457c86f4f403be0ac78e715d79
[06:28:42] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[11:54:02] <wikibugs>	 Wikimedia-Fundraising, Android-app-feature-Feeds, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, and 2 others: Big English Mobile App Fundraising ideas 2017 - https://phabricator.wikimedia.org/T180741#3780888 (RHo)
[11:54:06] <wikibugs>	 Wikimedia-Fundraising, Design, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): Implement 2017 Big English feed campaign on Android - https://phabricator.wikimedia.org/T180781#3780886 (RHo) Open>Invalid keeping to main ticket
[13:01:26] <wikibugs>	 fundraising-tech-ops: managertask - https://phabricator.wikimedia.org/T181146#3781120 (Kopelsony)
[13:01:35] <wikibugs>	 Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface, MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review: Credit card type logos can overflow boxes on mobile - https://phabricator.wikimedia.org/T176419#3781134 (Pcoombe) Open>Resolved
[13:52:48] <jgleeson>	 hello fr-all, does the wikistore ship to the UK?
[14:41:19] <wikibugs>	 Wikimedia-Fundraising, Android-app-feature-Feeds, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, and 2 others: Big English Mobile App Fundraising ideas 2017 - https://phabricator.wikimedia.org/T180741#3781357 (Pcoombe) Let's use these URLs, changing "control" if we do run alternative d...
[15:14:24] <wikibugs>	 (CR) Mepps: [C: 2] "Not sure why this hasn't merged." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288527 (owner: Ejegg)
[15:25:04] <wikibugs>	 (Merged) jenkins-bot: Remove some unused and redundant i18n keys [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288527 (owner: Ejegg)
[15:35:42] <AndyRussG>	 pcoombe: hey... :) just to let you know, we deployed a bit of debugging instrumentation for the large banner limit and switch feature last night, to have it on prod ahead of today's test
[15:36:34] <AndyRussG>	 the goal was to have more certainty that everything is working as it should, and that to be able to see how many people get small banners due to a previous identifier
[15:36:59] <AndyRussG>	 ...following the questions we had recently about large/small banner ratios
[15:37:33] <AndyRussG>	 it should just add a new debugInfo field onto the beacon/impression calls, nothing should be affected
[15:38:49] <pcoombe>	 Okay, thanks AndyRussG!
[15:39:37] <wikibugs>	 (PS1) Mepps: Updated thank you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392855 (https://phabricator.wikimedia.org/T181093)
[15:40:50] <wikibugs>	 Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, and 3 others: Make it easier to move from contact deleted by merge to the contact they were merged to - https://phabricator.wikimedia.org/T178003#3781516 (mepps) Open...
[15:41:59] <AndyRussG>	 pcoombe: likewise :)
[15:45:52] <wikibugs>	 (CR) Mepps: "Wow, that worked!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288527 (owner: Ejegg)
[15:56:11] <ejegg>	 thanks mepps!
[15:57:30] <pcoombe>	 Hey fr-tech, on the Adyen donation page I'm getting a js error - ReferenceError: ios is not defined. And then selecting a card type takes me straight to the TY page. This is Chrome on desktop.
[15:57:33] <pcoombe>	 https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&ffname=adyen-test&recurring=false&utm_source=fr-redir.default~default~default~default~control.cc&utm_medium=spontaneous&utm_campaign=spontaneous&utm_key=&referrer=&language=en&country=FR&payment_method=cc&payment_submethod=&gateway=adyen&amountGiven=&frequency=onetime&amount=2&currency=EUR
[16:01:17] <mepps>	 ejegg did you deploy the change i made yesterday already?
[16:01:40] <mepps>	 thanks for letting us know pcoombe! i'll look into this
[16:02:02] <pcoombe>	 Thanks mepps!
[16:06:03] <ejegg>	 mepps yeah,the adyen one?
[16:06:10] <wikibugs>	 (PS1) Mepps: Fix adyen bug caused by typo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392858
[16:06:20] <mepps>	 ejegg yeah it needs a fix ^^
[16:06:24] <ejegg>	 oh shoot
[16:06:27] <ejegg>	 looking
[16:08:15] <wikibugs>	 (CR) Ejegg: [C: 2] "Sneaky letters, looking so similar upper and lower case..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392858 (owner: Mepps)
[16:08:15] <MBeat>	 ty pcoombe !
[16:08:23] <mepps>	 want me to deploy ejegg?
[16:08:38] <ejegg>	 sure mepps!
[16:09:08] <mepps>	 i'm about to deploy a fix pcoombe!
[16:09:34] <pcoombe>	 Cool, thanks for the super speedy response :)
[16:10:21] <wikibugs>	 (Merged) jenkins-bot: Fix adyen bug caused by typo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392858 (owner: Mepps)
[16:12:41] <wikibugs>	 (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/392860
[16:12:50] <wikibugs>	 (CR) Mepps: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/392860 (owner: Mepps)
[16:15:35] <wikibugs>	 (PS11) Jgleeson: Added DonationsStats class to DonationQueueConsumer. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342
[16:17:06] <wikibugs>	 (CR) Mepps: [C: 2] "Hmm still waiting on merge." [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/392860 (owner: Mepps)
[16:18:26] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/392860 (owner: Mepps)
[16:19:10] <wikibugs>	 (PS1) Mepps: Latest DI Updates with adyen fix,localisation [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/392862
[16:19:21] <wikibugs>	 (CR) Mepps: [C: 2] Latest DI Updates with adyen fix,localisation [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/392862 (owner: Mepps)
[16:19:33] <wikibugs>	 (CR) jerkins-bot: [V: -1] Latest DI Updates with adyen fix,localisation [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/392862 (owner: Mepps)
[16:19:36] <wikibugs>	 (CR) jerkins-bot: [V: -1] Latest DI Updates with adyen fix,localisation [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/392862 (owner: Mepps)
[16:20:24] <wikibugs>	 (PS2) Mepps: Latest DI Updates with adyen fix,localisation [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/392862
[16:21:35] <wikibugs>	 (CR) Mepps: [C: 2] Latest DI Updates with adyen fix,localisation [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/392862 (owner: Mepps)
[16:25:39] <wikibugs>	 (Merged) jenkins-bot: Latest DI Updates with adyen fix,localisation [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/392862 (owner: Mepps)
[16:28:12] <mepps>	 ejegg is there a way to clear the js cache for payments-wiki?
[16:28:30] <mepps>	 or cwd do you know this? ^^
[16:29:45] <mepps>	 how often does it get cleared?
[16:39:37] <pcoombe>	 It's working for me now. Thanks mepps!
[16:43:31] <jgleeson>	 fr-tech, I am struggling to clear the changes my branch has made to the civicrm submodule. The cause appears to be when I originally ran git submodule update --init.  It checked out a version of civi, and the submodule pointer is now part of my commit. Any ideas how to undo this?
[16:44:18] <jgleeson>	 I've tried removing the dir and running git checkout -- path, also tried git checkout origin/master path
[16:46:17] <mepps>	 great pcoombe!
[16:52:56] <jgleeson>	 so my solution fr-tech was to explicitly checkout the submodule hash currently set in master in my branch which unwound my change
[16:54:02] <mepps>	 !log updated payments-wiki from 1ca91b1b029161457c86f4f403be0ac78e715d79 to 6b3019b1f18b4d6cd1705a49e95005124435e3d2
[16:54:08] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[16:55:33] <wikibugs>	 (PS12) Jgleeson: Added DonationsStats class to DonationQueueConsumer. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342
[16:59:53] <ejegg>	 jgleeson: yep, that sounds good
[17:00:08] <ejegg>	 mepps sorry, js cache would all be client-side
[17:00:35] <mepps>	 ah i thought you said we cached on our end too, but no worries, looks like it's resolved now
[17:01:04] <ejegg>	 on the main cluster there are lots of levels of caching
[17:01:29] <ejegg>	 but on the payments cluster almost everything goes right to the server, I think
[17:08:57] <wikibugs>	 (CR) Ejegg: "Looks like some good edits! Just noticed one place the generator seems to be adding an extra blank line. Want to do a little fix?" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392855 (https://phabricator.wikimedia.org/T181093) (owner: Mepps)
[17:10:55] <wikibugs>	 Fundraising Sprint Winter Wanderland, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Blocked cookie detection not working on payments-wiki - https://phabricator.wikimedia.org/T180975#3775087 (Ejegg) a:Ejegg
[17:26:26] <wikibugs>	 (PS2) Mepps: Updated thank you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392855 (https://phabricator.wikimedia.org/T181093)
[17:54:03] <ejegg>	 jgleeson: oops, sorry, I'll be off tomorrow
[17:54:23] <jgleeson>	 ah ok no problem
[17:56:18] <jgleeson>	 ejegg I'll try and get it to a position so that we have either, a straightforward implementation that can detect and output Prometheus style labels
[17:56:37] <ejegg>	 great!
[17:56:38] <jgleeson>	 or, a single value for each separate metric time
[17:57:58] <jgleeson>	 if it's the latter and I have time on my hands, I'll move back to the stats-collector tests as outlined in the email sent over a little earlier today
[17:58:50] <jgleeson>	 it doesn't make sense to me to start the failmail stats ticket until I've had a chance to discuss that with you and determine the areas (PHP specifc) that would be good to start tracking
[17:59:24] <jgleeson>	 unless you can point me at some obvious locations now?
[18:00:33] <ejegg>	 right, I think failmail is already visible, plus half of it is sent via process-control
[18:00:41] <ejegg>	 (python)
[18:02:58] <ejegg>	 hmm, if we're at all consistent with subjects or senders, that might be something to track via mail server logs
[18:16:46] <ejegg>	 fr-tech anything you want me to bring up at Scrum of Scrums? I'm going to check on the Selenium tests
[18:21:49] <cwd>	 nothing here ty
[18:41:00] <jgleeson>	 signing off for tonight
[18:41:13] <jgleeson>	 have a great day all, see you tomorrow
[19:08:54] <wikibugs>	 (CR) Ejegg: "Would using keydown/mousedown instead of 'click' on the continue/payment buttons let us avoid the complexity of setTimeout?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet)
[19:09:12] <wikibugs>	 (CR) Ejegg: [C: 2] Updated thank you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392855 (https://phabricator.wikimedia.org/T181093) (owner: Mepps)
[19:09:21] <wikibugs>	 (PS3) Ejegg: Updated thank you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392855 (https://phabricator.wikimedia.org/T181093) (owner: Mepps)
[19:15:05] <wikibugs>	 (CR) XenoRyet: "Na, I tried mousedown.  Unfortunately seemed to have the same unwanted behavior." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388651 (https://phabricator.wikimedia.org/T176501) (owner: XenoRyet)
[19:45:25] <ejegg>	 mepps: do you want to deploy that thank you letter update?
[19:45:38] <mepps>	 sure ejegg!
[19:45:43] <ejegg>	 thanks!
[19:46:09] <ejegg>	 I kind of want to deploy the SmashPig update for Adyen retries, even though it's the day before thanksgiving...
[19:46:34] <mepps>	 could we do it monday ejegg?
[19:46:45] <ejegg>	 yeah, that's probably a better idea!
[19:49:02] <ejegg>	 Saw some fun pyrotechnics last night in honor of the patron saint of musicians: https://www.youtube.com/watch?v=fPjHIEmR4eU
[19:49:18] <ejegg>	 And there seem to be a bunch of parades with marching bands today
[19:50:48] <mepps>	 nice!
[19:52:31] <wikibugs>	 (PS1) Mepps: Updated thank you letter [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/392896 (https://phabricator.wikimedia.org/T181093)
[19:53:52] <wikibugs>	 (CR) Mepps: [C: 2] Updated thank you letter [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/392896 (https://phabricator.wikimedia.org/T181093) (owner: Mepps)
[19:54:38] <mepps>	 ejegg there were a couple commits in the diff between deployment and master but i'm just doing the updated thank you letter since it's the day before txgiving--let me know if there are any others that should go out
[19:54:42] <wikibugs>	 (Merged) jenkins-bot: Updated thank you letter [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/392896 (https://phabricator.wikimedia.org/T181093) (owner: Mepps)
[19:55:12] <ejegg>	 mepps just the ty letter for now is great
[19:59:54] <mepps>	 ejegg is there a way to manually trigger resending a thank you email?
[20:00:23] <mepps>	 !log updated civicrm from a16e566940c43e0155b9dbbdaba3399b0d2e01bd to a1022cf2a64c048382a1ae5da7f1f81da0336d62
[20:00:28] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[20:04:52] <ejegg>	 mepps yeah
[20:05:00] <ejegg>	 you can set the thank_you_date to null
[20:12:50] <wikibugs>	 (CR) Ejegg: "The code looks great, and seems to record things correctly!" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 (owner: Jgleeson)
[20:13:17] <ejegg>	 mepps there's also the TY test page - are you familiar with that?
[20:14:58] <ejegg>	 off to get some food
[20:42:07] <mepps>	 i am not ejegg|food
[21:12:13] <ejegg>	 mepps it's at /admin/config/thank_you/test
[21:19:55] <mepps>	 thanks ejegg, it looks good to me!
[21:32:14] <ejegg>	 great!
[21:34:46] <ejegg>	 oops, chess club is taking over this room of the library...
[22:52:15] <wikibugs>	 (PS1) Ejegg: Show 'enable cookies' error message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392985 (https://phabricator.wikimedia.org/T180975)
[23:15:01] <wikibugs>	 Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, FR-Amazon, and 2 others: Amazon pay: cross-domain issue in mobile safari - https://phabricator.wikimedia.org/T180845#3782915 (Ejegg) Could have something to do with this? https://bugs.chromium.org/p/chrom...
[23:44:03] <wikibugs>	 Fundraising-Backlog, FR-Paypal, FR-Smashpig: Paypal IPN messages: Unknown refund type 'admin_reversal' - https://phabricator.wikimedia.org/T181203#3782943 (Ejegg)