[15:15:46] morning ejegg ;0 [15:18:11] Hey, um… when is the Big English deployment freeze? [15:18:22] I don’t see anything mentioned on https://wikitech.wikimedia.org/wiki/Deployments [15:20:54] ejegg: ^ [15:20:55] hi jgleeson ! [15:22:13] awight: oh shoot, I've been giving those informal warning in SoS, but I forgot - did we have a full train freeze for all of December in past years? [15:22:27] Or at least, when is BE day 1? [15:22:46] Day 1 is tomorrow! [15:23:07] I can put a note on that page [15:24:18] IIRC, we always ask for a freeze and rarely get it :) [15:26:20] Break a leg! [15:26:32] thanks! [15:52:19] Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, and 5 others: adyen cookie error after entering information on mobile Safari - https://phabricator.wikimedia.org/T176913#3789028 (mepps) @dstrine,... [15:52:48] hi fr-tech! James is napping so i'm checking in, hoping to at least get a half day in [15:53:02] hi mepps! [15:53:07] hi mepps :) [15:53:29] fr-tech morning! [15:53:43] morning AndyRussG :) [15:53:57] :) [15:53:59] hi AndyRussG ! [16:04:58] Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, and 5 others: adyen cookie error after entering information on mobile Safari - https://phabricator.wikimedia.org/T176913#3789124 (DStrine) I just r... [16:07:24] Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, and 5 others: adyen cookie error after entering information on mobile Safari - https://phabricator.wikimedia.org/T176913#3789146 (DStrine) @Ppena t... [16:12:21] (CR) Ejegg: [C: 2] "Looks great! Let's do a follow-on composer.lock patch to get the very latest fixes in stats-collector." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 (owner: Jgleeson) [16:14:35] jgleeson: do the changes to stats-collector post-1c792bb (the version in your composer.lock) require any changes to the usage in crm? [16:15:26] (PS2) Mepps: Show 'enable cookies' error message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392985 (https://phabricator.wikimedia.org/T180975) (owner: Ejegg) [16:15:30] (CR) Mepps: [C: 2] Show 'enable cookies' error message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392985 (https://phabricator.wikimedia.org/T180975) (owner: Ejegg) [16:16:15] (Merged) jenkins-bot: Added DonationsStats class to DonationQueueConsumer. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/390342 (owner: Jgleeson) [16:17:07] thanks mepps! [16:17:24] (Merged) jenkins-bot: Show 'enable cookies' error message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/392985 (https://phabricator.wikimedia.org/T180975) (owner: Ejegg) [16:19:15] mepps I'm going to update the test Adyen skin with Peter's proposed styles [16:20:30] sure ejgg, although i'm happy to take that too if you want [16:20:37] i only see this issue though: https://phabricator.wikimedia.org/T181252 [16:26:01] ejegg sorry was on my other profile so missed your messages [16:26:26] ejegg no, in response to the changes of usage in crm question [16:26:45] the refactoring doesn't affect the api, I also tested it again to confirm results were the same [16:27:02] Great! Looks like some good internal fixes to pick up. [16:27:51] I am writing tests for the stats-collector now actually, so I can more more confidently refactor going forward [16:28:05] ejegg, have you spotted an issue? [16:30:20] No, just looking at the diffs for things like flatten and sorting it looks like they clarify possibly unstable edge cases [16:30:47] and I always like better PHPDocs! [16:32:13] oh I see, I was apprehensive to pull in the new version on the original patch in case it meant you having to reevaluate the entire utility because the refactor was quite sizeable. [16:32:20] but I am guessing you've already done it :) [16:32:25] super code review man! [16:32:55] well... I could scrutinize a bit more. That's why I suggested updating composer.lock in a separate patch [16:32:58] I did add it to the second patch, related to the processing rate tracking with the new first-attempt Prometheus labels work [16:33:05] ah, cool [16:33:11] sorry, hadn't peeked at that yet [16:33:25] in that case, carry on! [16:34:50] I am going to tag the stats-collector hopefully by the end of today [16:34:57] awesome! [16:34:58] once we have a basic line of tests in place [16:37:11] I wanted to chat with you about the option I see in regards to more advanced Prometheus metric typing. I didn't want to over complicate the first-attempt due to the time pressures relating to the big english launch tomorrow [16:37:43] options* [16:57:28] cwd: Hey, I remember you had a nice vimrc for whitespaces…. I’m currently editing a bloody Makefile :) [17:00:48] awight: hi! [17:01:08] what is the particular ws concern? [17:01:36] Oh just looking for a snazzy way to make the WS visible [17:01:55] Do you go for the “:set listchars” method? [17:05:41] listchars=tab:›⠀,trail:␢,extends:❯,precedes:❮ [17:07:23] bd808: :) that looks cray cray [17:08:53] I think I have some syntaxhighlight magic for trailing whitespace too. My vimrc is a bit out of control [17:09:36] That “trail” term works well enough for me, but I’ll never turn down a batshit vimrc [17:10:10] the "light" version is https://github.com/wikimedia/puppet/blob/production/modules/admin/files/home/bd808/.vimrc [17:10:41] lol “computer, don’t deploy any new machines that make me feel stupid when I boot into vim" [17:11:50] bd808: That’s sick, thanks! [17:12:00] bd808, awight : my fav traling ws command: match ErrorMsg '\s\+$' [17:12:29] and yeah listchars is handy for tab/space, i set it selectively on file type [17:12:48] ooh syntax match Error " \+\t"me=e-1 [17:14:44] Sorry to spam up your channel on Big English-eve! [17:32:45] fr-tech: debug data from large/small banners just in: https://phabricator.wikimedia.org/T176146#3789451 [17:33:53] ejegg after stand-up do you have a some time to talk about how we update Prometheus to consume the new metric output, do we have a Test Prometheus env? [17:36:45] jgleeson: i have a test setup in virtualbox but nothing shared unfortunately [17:37:43] ah ok, I also have a local install of Prometheus and Grafana but would really like another pair of eyes to try out the new metric data also before going live [17:39:24] jgleeson: cool, i would be happy to take a look, are the changes on gerrit or anything? [17:42:59] awesome, thanks cwd. Yes they are, here's the first update https://gerrit.wikimedia.org/r/#/c/390342/ and the second update using metric labels is here https://gerrit.wikimedia.org/r/#/c/392425/ [18:16:57] guess this is Ppena here :) [18:20:22] pcoombe: quick question: were the CentralNotice campaigns used for last Wednesday's test ever used previously, or were they new for this test? [18:20:38] also: https://phabricator.wikimedia.org/T176146#3789451 [18:21:09] AndyRussG: Those were the same campaigns we used previously [18:29:00] Fundraising-Backlog: Silverpop to Civi donor country error - https://phabricator.wikimedia.org/T181424#3789706 (krobinson) [18:36:29] Fundraising-Backlog: Silverpop to Civi donor country error - https://phabricator.wikimedia.org/T181424#3789706 (Ejegg) We get the country from their IP address. It's likely they were browsing via a VPN or something else that routed their traffic via a US IP address. [18:39:34] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/393624 [18:39:54] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/393624 (owner: Ejegg) [18:41:31] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/393624 (owner: Ejegg) [18:41:31] fr-tech going to deploy the no-cookies message fix ^^ [18:43:24] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/393625 [18:43:27] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/393625 (owner: Ejegg) [18:47:06] I think I'm back to normal [18:47:10] yay! [18:47:21] do I look like dstrine to anyone else? [18:47:35] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/393625 (owner: Ejegg) [18:47:41] yup [18:47:42] dstrine: yes but i still can't see your cloak [18:48:07] welcome back dstrine! [18:48:08] cwd: I never understood want a cloak was in IRC [18:48:16] so i'll have to assume you are an enemy operative [18:48:26] dstrine it confirms you are associated with WMF [18:48:27] I didn't expect that from a harry potter fan [18:48:33] you need it for certain channels [18:48:39] I think IRC cloud takes care of this [18:48:44] yeah it's another thing about IRC that should be simple but is instead incredibly convoluted [18:48:53] which is why oit give us the accounts [18:49:26] jgleeson: I know what that cloak is :P [18:51:16] !log updated payments-wiki from 6b3019b1f18b4d6cd1705a49e95005124435e3d2 to fea6b375affc629f3dbce71aa348704b307e7a94 [18:51:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:54:36] :) [18:56:56] jgleeson let me just get this css up and then I'm free to talk Prometheus [18:57:56] pcoombe: ready to test in like half an hour? With some of the traffic going to Adyen? [18:59:13] amazing, thanks so much ejegg. Yes I can try and set up some banners pointing to Adyen. Is that US only? [18:59:41] pcoombe: argh, I just noticed some off-centered-ness of the payment icons [18:59:52] I was tweaking those last week to make the click target larger [19:00:38] sorry, lemme make sure i'm not loading anything cached [19:01:26] yeah, I made the logos a little larger and shrunk some borders [19:01:54] (PS1) Mepps: Redirect Adyen skin [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/393633 [19:02:33] pcoombe do you think you can work these in: https://gerrit.wikimedia.org/r/392772 https://gerrit.wikimedia.org/r/392774 [19:03:00] ejegg: do you have a screenshot? thought I'd got them centered [19:05:09] Fundraising-Backlog: Style Ingenico iframe to match new css - https://phabricator.wikimedia.org/T181427#3789821 (mepps) [19:05:20] pcoombe: sorry, my mistake, loading some old css [19:08:59] The current style looks quite off center in Chrome. https://www.dropbox.com/s/j38sskl3u2golvg/Screenshot%202017-11-27%2019.05.36.png?dl=0. I gave up on trying to center the radio buttons themselves, it was proving tricky [19:09:15] oh boy, yep, the current one does need fixing! Sorry about that [19:09:26] well, all the more reason to get this change out! [19:15:03] (PS2) Ejegg: Restyle payments forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/393096 (https://phabricator.wikimedia.org/T181252) (owner: Pcoombe) [19:15:23] (CR) Ejegg: [C: 2] "OK, let's give this a shot! Thanks for fixing my off-center logos." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/393096 (https://phabricator.wikimedia.org/T181252) (owner: Pcoombe) [19:16:02] Adyen iframe css is updated on test and ready to publish [19:16:59] ejegg: Cool! Not quite ready with the banners yet. Should we do Adyen for US only? [19:17:40] I can't remember which countries it's ready for [19:18:13] (Merged) jenkins-bot: Restyle payments forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/393096 (https://phabricator.wikimedia.org/T181252) (owner: Pcoombe) [19:21:25] pcoombe: sorry, I think it has been mostly US so far [19:21:26] pcoombe: I think we have US and CA ready for Adyen, but dstrine and ejegg correct me if im wrong [19:21:26] lemme see [19:21:36] ah, CA too? [19:22:00] cool [19:22:46] pcoombe: ok gotcha ,thanks! [19:24:55] ejegg: pllls check I think so but just in case [19:24:57] Fundraising-Backlog: Silverpop to Civi donor country error - https://phabricator.wikimedia.org/T181424#3789896 (CCogdill_WMF) Shouldn't the country in Civi match the country in IBM? [19:25:25] yep, checking which places we've gotten Adyen donations from [19:28:46] Fundraising-Backlog: Silverpop to Civi donor country error - https://phabricator.wikimedia.org/T181424#3789902 (Ejegg) @CCogdill_WMF oh sorry, I didn't process 'only ever donated from unaccepted countries'... I'll take a look at those specific cases [19:32:26] Fundraising-Backlog: Silverpop to Civi donor country error - https://phabricator.wikimedia.org/T181424#3789706 (DStrine) yeah I agree with @Ejegg if we got tons of these all together or related to a specific mailing that might mean something. We should continue to correct their records in civi. @MBeat33 men... [19:32:59] Fundraising-Backlog: Silverpop to Civi donor country error - https://phabricator.wikimedia.org/T181424#3789918 (DStrine) Open>declined [19:33:51] Fundraising-Backlog: Silverpop to Civi donor country error - https://phabricator.wikimedia.org/T181424#3789919 (CCogdill_WMF) Hey @Dstrine I think this needs to stay open. These donors only ever gave in unaccepted countries according to Civi. We should be using that data in Silverpop to ensure we aren't emai... [19:33:53] Fundraising-Backlog: Silverpop to Civi donor country error - https://phabricator.wikimedia.org/T181424#3789920 (DStrine) declined>Open [19:34:45] Fundraising-Backlog: Silverpop to Civi donor country error - https://phabricator.wikimedia.org/T181424#3789706 (DStrine) sorry our messages crossed paths and I didn't see your updates. If that is the case, this is a bug. [19:37:46] pcoombe looks like we have done a small amount of Adyen traffic in CA [19:38:02] pcoombe and GB as well [19:39:12] that sounds right to me ejegg [19:42:06] I'm down to test all 3, if that's ok :) [19:42:33] Im restarting my computer and will be back in 5- hopefully as ppena! [19:47:41] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface, Patch-For-Review: Payments forms restyle - https://phabricator.wikimedia.org/T181252#3789964 (DStrine) [19:51:51] nope, still a guest :( [20:00:27] okay ejegg, banners are ready for US, CA, and GB. Half using ingenico, half using adyen [20:00:44] Fundraising-Backlog: Silverpop to Civi donor country error - https://phabricator.wikimedia.org/T181424#3790079 (Ejegg) Aha, I see where this came from. All of those donors are marked opted_out in the Silverpop table. To save some time in the export, we only look up countries for donors who are NOT opted_out... [20:00:51] ok, great. I'll merge to deployment [20:01:34] heads up Guest98955, MBeat [20:01:40] Fundraising-Backlog: Silverpop to Civi donor country error - https://phabricator.wikimedia.org/T181424#3790084 (Ejegg) Let me know if you find any donors with country mismatches on the lists that we ARE sending mail to. [20:01:55] ty pcoombe [20:02:16] pcoombe: can we have the links for review?:) [20:02:28] After deployment but before launching banners, I'll do a quick run in crossbrowsertesting [20:02:36] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/393645 [20:02:41] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/393645 (owner: Ejegg) [20:02:47] Guest98955: https://docs.google.com/spreadsheets/d/1uETLfG5u1zRFyVwr5qJNZdF_EMaSXHLnjRFimSTeTic/edit#gid=1508425515 [20:04:36] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/393647 [20:04:41] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/393647 (owner: Ejegg) [20:05:22] pcoombe: awesome!! [20:06:44] pcoombe: are we doing CA and GB too? should I just change the country on those links? [20:07:37] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/393645 (owner: Ejegg) [20:08:23] Guest98955: yes, you can just change the country [20:08:29] cool! [20:08:45] ejegg: let us k ow once it deploys! [20:10:03] will do, just waiting for the build machines to approve it [20:12:57] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/393647 (owner: Ejegg) [20:14:54] OK, there's our merge ^^ [20:15:22] Guest98955, fr-tech, pcoombe, MBeat, dstrine I'm about to deploy the style updates [20:15:37] 10-4 [20:15:42] cool, will watch the queue for any bumps [20:15:47] cool and good luck [20:16:03] cool, ready to check things out [20:17:09] !log updated payments-wiki from fea6b375affc629f3dbce71aa348704b307e7a94 to f594dfa763292b2f8785b6aa83d6b50ef8cae64e [20:17:15] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:17:31] and updated the adyen iframe skin... [20:17:46] Guest98955, fr-tech, pcoombe, MBeat, dstrine OK, it's deployed [20:17:55] let's see if any cache-clearing is needed [20:19:02] nope, seeing the fresh stuff [20:20:42] I see it :) Ingenico and Adyen both looking as expected [20:20:56] yay! [20:21:02] Amazon also still looks good [20:21:19] I'm still seeing the old stuff on Ingenico. [20:21:47] Oh, nevermind. [20:21:49] Got the new now. [20:22:06] cool, that one is loaded from our site via load.php [20:22:11] so it may cache for a few min [20:22:18] Yea, probably what it was. [20:23:01] pcoombe: what method are you using to test locally the popups test registration code? enabling a campaign on wikibooks? just testing when FR campaigns are up? [20:24:16] errors all look fine [20:25:44] Email suggest looks fine too [20:26:06] pcoombe one tiny thing: the select box for the currency has the dropdown arrow superimposed over the last letter [20:26:35] ah, and state dropdown sometimes overlaps if I zoom text in [20:27:03] ejegg: oh, okay. I can look into fixing that [20:28:11] I see the card icons overlapping their boxes slightly on ipad. But they were before too, so that's not a regression (just thought I had fixed it and evidently hadn't) [20:30:11] Internet Exploder looks good though! [20:30:29] :P [20:32:00] ooh, I had never noticed before the Adyen frame changes between CID and CVV based on the card number you enter. pretty cool. [20:33:51] ejegg, happy for us to test some banners now? And feel free to make a phab task for the dropdown arrow and assign to me [20:34:09] yeah, let's send some donors to the forms! [20:34:15] pcoombe: ^^^ [20:36:19] Great. Banners are up! ejegg fr-tech MBeat Guest98955 [20:40:55] Fundraising-Backlog: Silverpop to Civi donor country error - https://phabricator.wikimedia.org/T181424#3790239 (Ejegg) @CCogdill_WMF are those donors not opted out in Silverpop? [20:44:34] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Currency selector dropdown: arrow overlaps last letter - https://phabricator.wikimedia.org/T181435#3790247 (Ejegg) [20:48:18] yay [20:53:46] Fundraising-Backlog: Silverpop to Civi donor country error - https://phabricator.wikimedia.org/T181424#3790295 (CCogdill_WMF) @Ejegg I think these people got added to the opted_out list as a result of contacting Donor Services. For example, CID 2332953 received an email on 11/14/17 and I showed them opted ou... [20:53:51] Weird, paypal donations seem to be slow coming in. Is the queue backed up? [20:55:14] I'm seeing plenty of them in the payments_init [20:55:16] lessee [20:56:07] only seeing about 4 minutes time to Civi still [20:56:46] Ah, but paypal classic is always a bit slower [20:57:34] Okay, don't think it's anything to worry about then [20:57:46] we wait for the IPN message, then process a batch of those every 3 minutes, THEN send that to the donations queue where it can wait up to 2 min more [21:00:04] orrr, batch of IPN messages every 5 min [21:00:13] could definitely make that more often [21:09:14] AndyRussG: I ran a campaign geotargeted at the Pitcairn Islands, and faked my location with country=PN in the url. My apologies to the 50 people who live there if they saw any unwanted banners :) [21:09:52] pcoombe: K gotcha thanks! [21:15:25] one “perhaps your browser does not accept cookies” mobile error in the queue (& a couple unspecified) any chance CSS related, ejegg ? [21:16:09] MBeat: ejegg just added that back in before the CSS [21:16:24] that message had not been popping up when needed in some cases [21:16:53] ah, cool. So best response is to ask them to enable 3rd party cookies, dstrine ? [21:17:31] yeah some people were not getting that message when their cookies were totally closed down [21:17:47] I mean blocked [21:19:30] MBeat: right, that was something we had just added back. If you can get browser info that would be great! [21:19:46] will ask, thanks ejegg & dstrine [21:19:46] Hope we're not showing any false positives. [21:20:11] if so, we could maybe make that a non-blocking error [21:22:05] Jeff_Green / cwd want to pop in to the meeting? [21:22:29] ejegg: i was just saying to jeff, i didn't get an invite [21:22:36] or is it just rolled into standup now? [21:22:53] oh weird, lemme check on the event [21:22:54] cwd: it's the same meeting room [21:23:13] be there in 2 minutes [21:23:21] cwd you seem to have declined the invite [21:23:25] hahahah [21:23:28] i'll reinvite you [21:23:39] perhaps he's anti-meeting :-P [21:23:47] * Jeff_Green goes looking for URL [21:26:45] haha oops! didn't mean to do that [21:30:26] ejegg MBeat Guest98955 : any objection to me extending the test another 25 minutes (until 22 UTC)? [21:30:41] non at all, pcoombe [21:31:10] Looks like more data would be helpful, but I also want time to analyse before I log off [21:32:04] thanks pcoombe [21:38:44] go for it! [21:40:25] seeing a bunch of GlobalCollect API timeouts mbeat pcoombe [21:41:01] uh-oh. need me to pull the banners ejegg ? [21:41:08] fwiw ejegg I am seeing what looks like console lag from GC, things in Civi are not appearing there - sent them an email [21:44:51] damn, cyber monday meltdown? [21:45:14] pcoombe maybe? I've seen 135 timeouts after 3 retries so far [21:46:18] okay ejegg MBeat Guest98955: banners are down [21:46:42] ty pcoombe [21:47:26] what an annoying time for GC to melt down. Although I suppose tomorrow would have been worse. [21:49:17] why we love testing [21:55:24] ejegg: will you email merch services? [21:55:45] ok, will do [21:55:56] Guest98955: MBeat did [21:56:17] fr-tech / K4 sorry, compy shut down. Found an outlet, though [21:56:20] will fwd any repy to fr-tech [21:56:28] thanks MBeat ! [21:56:32] np [21:56:36] I saw a mention of lag, but not timeouts? [21:56:47] OK, I'll also send one [21:57:01] pls add URGENT [21:57:04] :D [22:09:29] MBeat: any other zendesk patterns or issues that may be related to the test? [22:10:10] around 10 donation errors, but no clear feedback yet from donors, dstrine - some report form freezing up [22:10:27] some successfully retried [22:13:59] Hello all, thanks for the feedback. Just to be clear, the ingenico issues we were seeing are not directly related to the banner changes though, correct? [22:17:05] jessicarobell: I'm assuming you mean the CSS changes the pcoombe made? If so we're still assessing. But if MBeat only saw freezing that is probably not related. Right ejegg ? [22:17:28] Correct. That was my question [22:33:08] thanks ejegg for the email. Do you feel ok with the CSS? [22:33:25] dstrine yeah, the css seems totally solid [22:33:33] sound like Ingenico is having separate issues [22:34:00] jessicarobell: yeah so CSS is good but ingenico is have it's own bad day [22:35:09] I'm looking at the results now, cc conversion for desktop ingenico seems a little down but that's likely due to their issues. Mobile is actually slightly up despite that :) [22:37:16] Thank you @dstrine. good news on the CSS. Bad timing about Ingenico though.. Do we have any idea what that's about? [22:39:57] jessicarobell: an urgent email is out to them. we'll have to wait to hear back [22:43:03] jessicarobell: We found one bug in the CSS, but it's pretty minor and should be easy for me to fix: https://phabricator.wikimedia.org/T181435 [22:45:15] Ok, thanks for following up and looking into it @MBeat and @dstrine. Will you please send an email to the entire team regarding the status before the end of your day, just so everyone's in the loop before tomorrow's launch? [22:46:12] jessicarobell: I'm just getting together results for an email. Will send that out shortly. [22:46:35] Thank you @pcee [22:46:47] @pcoombe that is :) [22:47:52] That's helpful. It would be good to get to also get feedback from tech/Michael once we know more about the Ingenico issue. Thanks everyone [22:48:31] (jessicarobell: you don't need to use @ in IRC by the way. If you start typing someone's name, you should be able to press Tab to complete it) [22:49:20] aha, thanks pcoombe [23:02:27] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Consider doing more retries before declaring a deadlock - https://phabricator.wikimedia.org/T181450#3790785 (Eileenmcnaughton) [23:06:11] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Consider doing more retries before declaring a deadlock - https://phabricator.wikimedia.org/T181450#3790817 (Eileenmcnaughton) Hmm - looking at the code - I have doubts it is actually... [23:20:17] (PS1) Ejegg: Configurable target per campaign [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/393681 [23:20:42] fr-tech anyone available to review ^^^ and its parent patches? [23:21:04] Would be cool to do a dash deploy today to fix the big english target [23:21:07] Yea, I can take a look. [23:21:13] thanks! [23:23:17] rebasing [23:23:25] (PS4) Ejegg: Label dates better in Big English chart [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/383708 [23:23:27] (PS2) Ejegg: Change individual amount cutoff to $5000 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/391884 [23:23:29] (PS2) Ejegg: Configurable target per campaign [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/393681 [23:28:28] (CR) XenoRyet: [C: 2] Label dates better in Big English chart [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/383708 (owner: Ejegg) [23:29:06] (CR) XenoRyet: [C: 2] Change individual amount cutoff to $5000 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/391884 (owner: Ejegg) [23:29:25] (Merged) jenkins-bot: Label dates better in Big English chart [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/383708 (owner: Ejegg) [23:30:00] (Merged) jenkins-bot: Change individual amount cutoff to $5000 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/391884 (owner: Ejegg) [23:30:50] (CR) XenoRyet: [C: 2] Configurable target per campaign [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/393681 (owner: Ejegg) [23:30:53] (PS7) Reedy: Remove 'UnitTestList' hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/303261 (https://phabricator.wikimedia.org/T142120) [23:31:45] (Merged) jenkins-bot: Configurable target per campaign [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/393681 (owner: Ejegg) [23:33:53] thanks XenoRyet [23:34:06] lemme see if I can minify that for deploy this time [23:34:13] might have to ask for some more help... [23:34:52] No worries [23:40:10] (PS1) Ejegg: Update momentjs [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/393684 [23:40:22] (CR) Ejegg: [C: 2] Update momentjs [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/393684 (owner: Ejegg) [23:41:10] (CR) Ejegg: [V: 2 C: 2] Update momentjs [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/393684 (owner: Ejegg) [23:42:11] (PS1) Ejegg: Update bower_modules [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/393685 [23:42:15] (CR) Ejegg: [C: 2] Update bower_modules [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/393685 (owner: Ejegg) [23:43:13] (Merged) jenkins-bot: Update bower_modules [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/393685 (owner: Ejegg) [23:43:48] well, the minifier is chewing on cpu... [23:44:08] grr [23:44:21] so silly that we're using this build system [23:46:01] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/393686 [23:46:07] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/393686 (owner: Ejegg) [23:47:01] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/393686 (owner: Ejegg) [23:58:39] hmph [23:58:47] lessee if I can make it work under vagrant