[16:36:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-WMF-Audit: Ingenico WX audit parser taking crazy long, mysql connect dying - https://phabricator.wikimedia.org/T182605#3828499 (Ejegg) [17:23:37] Wikimedia-Fundraising-Banners: Hide desktop banners on mobile site and vice versa - https://phabricator.wikimedia.org/T182122#3828640 (Pcoombe) Open>Resolved This is done. Diffs: * [desktop large](https://meta.wikimedia.org/w/index.php?title=MediaWiki:Centralnotice-template-B1718_1101_en6C_dsk_p1_lg... [18:59:08] XenoRyet: want to help me figure out why ingenico WX parsing is taking so darn long? [18:59:43] https://phabricator.wikimedia.org/T182605 [19:00:43] ejegg: I'm meeting with K4 right now. [19:00:56] k, lmk when you're free [19:38:04] (PS1) Ejegg: Use XMLReader for WX audit [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/397608 (https://phabricator.wikimedia.org/T182605) [19:38:44] k, that wasn't too painful [19:42:24] Ah, figured it out already? [19:42:31] I'll take a look. [19:44:10] XenoRyet: well, not necessarily [19:44:23] just figured that was worth a try [19:45:25] How long has this been going on anyway. Was it happening last few weeks or is it new to this week? [19:45:32] fundraising-tech-ops: Excessive sysloggin' on civi1001 - https://phabricator.wikimedia.org/T182442#3823271 (Jgreen) Proposed DNS change is here: https://gerrit.wikimedia.org/r/#/c/397612/ [19:46:03] XenoRyet: looking [19:46:20] Since the 5th, seems like. [19:46:29] ah yeah [19:47:21] Jeff_Green: was that comment possibly destined for https://phabricator.wikimedia.org/T182006 ? [19:47:34] hmm, the audit files we did process in Dec look suspiciously small [19:48:08] like, how is the file for 12/02 only 1.4MB? [19:48:14] cwd: no, I made a new task re. DMARC report routing for donate.wm.o [19:48:18] I was gonna say, are the ones we choked on atypically big, 'cause big days? [19:48:26] yeah, exactly [19:48:32] i'll link it to T182006 too [19:49:25] I mean, your patch makes sense anyway, but it might just be December strain. But that small file on the 2nd is weird. [19:49:42] Should've been getting big ones all the way back to when banners went up, yea? [19:50:11] (PS1) Mepps: End connections after query [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/397614 [19:50:30] XenoRyet: that's what I'd think [19:51:38] (CR) jerkins-bot: [V: -1] End connections after query [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/397614 (owner: Mepps) [19:52:41] (CR) XenoRyet: [C: 2] Use XMLReader for WX audit [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/397608 (https://phabricator.wikimedia.org/T182605) (owner: Ejegg) [19:53:07] mepps whew, crazy amount of ways those fns can exit :P [19:53:11] (PS2) Mepps: End connections after query [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/397614 [19:53:49] (Merged) jenkins-bot: Use XMLReader for WX audit [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/397608 (https://phabricator.wikimedia.org/T182605) (owner: Ejegg) [19:59:11] grr, did packagist change how they pick up version tags? [20:00:45] oh well, v0.5.1 seems to be accepted as valid [20:05:01] (PS1) Ejegg: Update SmashPig lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/397620 [20:05:08] (CR) Ejegg: [C: 2] Update SmashPig lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/397620 (owner: Ejegg) [20:13:02] (Merged) jenkins-bot: Update SmashPig lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/397620 (owner: Ejegg) [20:13:17] ejegg: just looking at the stripe import [20:13:39] eileen: oh yeah, that was looking good [20:13:47] There are a couple of things left - the payment instrument - she seems to be saying Stripe is o [20:13:48] ok [20:13:49] and I guess we don't need to import the card types [20:14:09] & I think I need to add currency handling (which won't be too hard) [20:14:22] but the other thing is she is having trouble getting emails into the file [20:14:30] yeah, can you just map the column for currency? [20:14:33] which we can't really do anything about can we [20:14:38] yeah I think so on currency [20:14:53] Jerry has gone back to the people who supplied the file [20:15:27] but the email is missing for collection reasons or something - so it might be that they are email-less [20:15:31] so the issue is just to ask stripe to add emails? [20:15:37] yeah kind of [20:15:50] huh, yeah, doesn't sound like a thing we can help with then [20:15:59] Yeah - that's my thinking [20:16:11] the other thing is the csv has a column for refund amount [20:16:24] she has no examples of that being used & doesn't forsee ny [20:16:41] so I'm wondering if I should throw an exception if that field is non-empty [20:17:00] sure, that could be prudent [20:17:05] (since I don't have a sample of how a row would look like if it were there but it seems like it would be an error) [20:17:29] alright - I [20:17:43] (PS3) Mepps: End connections after query [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/397614 [20:17:48] will do the currency now [20:18:41] (CR) jerkins-bot: [V: -1] End connections after query [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/397614 (owner: Mepps) [20:21:18] Amount,Currency,Converted Amount, - hmm - I'm assuming the latter is the USD amount - is that a given? [20:22:15] Sounds likely, if there's just one currency column [20:22:47] so we'd want to map amount and currency to original_amount and original_currency [20:23:00] then converted amout to gross [20:23:19] sorry, amount maps to original_gross [20:23:27] ah no there is this column too Converted Currency, [20:23:47] I'll question here on it [20:26:04] Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Civi Import - https://phabricator.wikimedia.org/T172423#3829263 (Eileenmcnaughton) Hi @jkim_wikimedia the sample I'm looking at has only USD value... [20:28:57] (PS4) Mepps: End connections after query [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/397614 [20:29:50] (CR) jerkins-bot: [V: -1] End connections after query [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/397614 (owner: Mepps) [20:32:40] (PS5) Mepps: End connections after query [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/397614 [20:36:26] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-WMF-Audit, Patch-For-Review: Ingenico WX audit parser taking crazy long, mysql connect dying - https://phabricator.wikimedia.org/T182605#3829275 (DStrine) [20:36:49] Fundraising Sprint Winter Wanderland, Fundraising-Backlog: dash(?) is leaving mysql connections dangling - https://phabricator.wikimedia.org/T182440#3829277 (DStrine) [20:40:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Weird FK constraint problems in Civi - https://phabricator.wikimedia.org/T182148#3814349 (DStrine) p:Triage>Normal [20:41:43] Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, and 3 others: Validation not clearing error on b... - https://phabricator.wikimedia.org/T176501#3627759 [20:42:02] Fundraising Dash, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: dash minification busted under debian stretch - https://phabricator.wikimedia.org/T181467#3829291 (Ejegg) Open>Resolved [20:43:42] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, fundraising-tech-ops: Civi credential for new Engage user - https://phabricator.wikimedia.org/T181537#3793506 (Eileenmcnaughton) Angel should have an email now with the civi account [21:09:47] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Slow log in - looks like it's drupal cron - https://phabricator.wikimedia.org/T155084#3829341 (Eileenmcnaughton) @DStrine we should pull this back in soon [21:12:48] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, fundraising-tech-ops: Civi credential for new Engage user - https://phabricator.wikimedia.org/T181537#3793506 (Eileenmcnaughton) a:Eileenmcnaughton [21:13:31] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civimail bounce processing failing - https://phabricator.wikimedia.org/T181934#3807047 (Eileenmcnaughton) a:Ejegg [21:15:33] cwd: Jeff_Green you got a mintue to chat with fr-tech? [21:15:37] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Merge on addresses for MG - https://phabricator.wikimedia.org/T181088#3829388 (Eileenmcnaughton) @LeanneS @NNichols now merging on address conflicts - hopef... [21:15:47] be right there [21:16:23] dstrine: sure [21:16:25] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Let dedupe run on orgs - https://phabricator.wikimedia.org/T181089#3829392 (Eileenmcnaughton) @LeanneS @NNichols this is running now - hopefully you are seeing more orgs merged.... [22:00:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Consider adding CiviCRM permission to block exports - https://phabricator.wikimedia.org/T182634#3829521 (Eileenmcnaughton) [22:00:20] (PS1) Pcoombe: Tweak informationsharing message to be more upfront [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/397637 [22:08:44] K4-713: sorry, battery died faster than i expected! [22:09:13] ejegg: Ha, no worried. [22:09:16] *worries [22:09:37] (PS8) Eileen: Add stripe import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392566 (https://phabricator.wikimedia.org/T172423) [23:01:39] ejegg[m]: I've updated the stripe import. I'm just thinking about the flow. [23:01:52] Jerry doesn't need it now for a few months [23:01:57] & she is following up on the email [23:02:07] my feeling is that we probably deploy it now [23:02:28] & close the phab from our end but re-visit with a new phab if she gets more info [23:02:47] I haven't had her do another test on staging yet with the currency but am putting it on staging now [23:05:33] Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Civi Import - https://phabricator.wikimedia.org/T172423#3829712 (Eileenmcnaughton) @jkim_wikimedia there is an updated version on staging now that... [23:07:30] mepps: I just took a look at this one in review https://phabricator.wikimedia.org/T120000 & it looks like it has been reviewed & is due a column change [23:20:32] sounds good eileen, reviewing [23:32:29] (CR) Ejegg: [C: 1] "Looks good, just one tiny thing - the contact_source = check from parent::getDefaultValues seems out of place here. Do our users just take" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392566 (https://phabricator.wikimedia.org/T172423) (owner: Eileen) [23:34:06] (CR) Eileen: "I think Stripe Import would make more sense - will change" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392566 (https://phabricator.wikimedia.org/T172423) (owner: Eileen) [23:34:59] (PS9) Eileen: Add stripe import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392566 (https://phabricator.wikimedia.org/T172423) [23:35:17] (CR) Eileen: "updated" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392566 (https://phabricator.wikimedia.org/T172423) (owner: Eileen) [23:47:05] eileen: do you need to change the order of the args for array '+'? [23:47:21] I think keys from the 2nd get ignored when the 1st has the same