[00:00:08] <icinga-wm>	 PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: payments-antifraud is 27162 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 82 days 7 hours - memory use is 19.78M (peak 23.12M, 0.28% of max, fragmentation 1.16%), connected_slaves is 2, donations is 7, jobs is 0, jobs-adyen is 0, jobs-paypal is 25, payments-init is 31, pending is 14, recurring is 5, refund is 0, unsubscribe is 22
[00:04:07] <eileen>	 cwd - I think I feel safe pushing a patch for this - 10 mins
[00:04:26] <cwd>	 eileen: to make it drop the message on a bad value?
[00:04:56] <cwd>	 i am deeply wary of trying to delete anything from live redis
[00:05:09] <icinga-wm>	 PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: payments-antifraud is 27184 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 82 days 7 hours - memory use is 19.94M (peak 23.12M, 0.28% of max, fragmentation 1.15%), connected_slaves is 2, donations is 17, jobs is 0, jobs-adyen is 0, jobs-paypal is 18, payments-init is 74, pending is 19, recurring is 1, refund is 0, unsubscribe is 2
[00:07:32] <ejegg>	 hi folks
[00:07:58] <ejegg>	 whoa, weird
[00:08:12] <ejegg>	 dang, it should kick the message to damaged ideally
[00:08:18] <ejegg>	 lessee, can we do that manually?
[00:08:50] <cwd>	 ejegg: from redis-cli? i was just looking into it
[00:09:10] <ejegg>	 eileen I guess it should throw the same kind of WmfException that it does when a required field is missing
[00:09:22] <ejegg>	 or too long
[00:09:47] <wikibugs>	 (PS1) Eileen: Top out risk score at 100 million. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398777 (https://phabricator.wikimedia.org/T183102)
[00:09:50] <ejegg>	 ah, we could append a too-long explanation string to one of the fields?
[00:09:52] <eileen>	 ejegg: can you check what I just pushed?
[00:09:58] <ejegg>	 looking
[00:10:18] <icinga-wm>	 PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: payments-antifraud is 27200 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 7 keys, up 82 days 7 hours - memory use is 20.04M (peak 23.12M, 0.28% of max, fragmentation 1.15%), connected_slaves is 2, donations is 8, jobs is 0, jobs-adyen is 0, jobs-paypal is 28, payments-init is 217, pending is 0, recurring is 1, refund is 0, unsubscribe is 2
[00:10:33] <eileen>	 actually I don't need that first if
[00:11:20] <ejegg>	 yeah, it'll figure out the scientific notation automatically, right?
[00:12:16] <eileen>	 yep
[00:12:54] <wikibugs>	 (CR) jerkins-bot: [V: -1] Top out risk score at 100 million. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398777 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[00:13:06] <wikibugs>	 (PS2) Eileen: Top out risk score at 100 million. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398777 (https://phabricator.wikimedia.org/T183102)
[00:13:07] <eileen>	 ok - new one up
[00:14:04] <eileen>	 ejegg: I feel pretty comfortable doing an emergency fix here based on analysis - but if we didn't what is the impact of turning off that q
[00:15:18] <icinga-wm>	 PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: payments-antifraud is 29468 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 82 days 7 hours - memory use is 21.29M (peak 23.12M, 0.30% of max, fragmentation 1.15%), connected_slaves is 2, donations is 12, jobs is 0, jobs-adyen is 0, jobs-paypal is 24, payments-init is 32, pending is 15, recurring is 1, refund is 0, unsubscribe is 2
[00:15:55] <wikibugs>	 (CR) jerkins-bot: [V: -1] Top out risk score at 100 million. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398777 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[00:18:10] <wikibugs>	 (PS3) Eileen: Top out risk score at 100 million. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398777 (https://phabricator.wikimedia.org/T183102)
[00:19:55] <wikibugs>	 (CR) jerkins-bot: [V: -1] Top out risk score at 100 million. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398777 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[00:20:08] <icinga-wm>	 PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: payments-antifraud is 29491 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 82 days 7 hours - memory use is 21.31M (peak 23.12M, 0.30% of max, fragmentation 1.15%), connected_slaves is 2, donations is 13, jobs is 0, jobs-adyen is 0, jobs-paypal is 33, payments-init is 12, pending is 17, recurring is 3, refund is 0, unsubscribe is 4
[00:20:42] <wikibugs>	 (PS4) Eileen: Top out risk score at 100 million. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398777 (https://phabricator.wikimedia.org/T183102)
[00:24:10] <ejegg>	 eileen: oh crud, we'll need to roll back a couple things on deployment before we push that out
[00:24:21] <ejegg>	 lemme get that branch back in line with production
[00:24:23] <eileen>	 ug
[00:24:36] <ejegg>	 yeah :(
[00:24:41] <eileen>	 we have stuff merged but not deployed?
[00:24:57] <eileen>	 I think the patch is good to merge to master now https://gerrit.wikimedia.org/r/#/c/398777/
[00:25:08] <icinga-wm>	 PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: payments-antifraud is 29520 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 7 keys, up 82 days 7 hours - memory use is 21.32M (peak 23.12M, 0.30% of max, fragmentation 1.15%), connected_slaves is 2, donations is 24, jobs is 0, jobs-adyen is 0, jobs-paypal is 13, payments-init is 47, pending is 0, recurring is 3, refund is 0, unsubscribe is 7
[00:25:13] <ejegg>	 we deployed stuff on Thursday then realized friday it was bad
[00:25:23] <eileen>	 dang
[00:25:28] <ejegg>	 just rolled back on production without reverting on deployment
[00:25:42] <ejegg>	 yeah, for a sec it looked like we were all done with the cherry picks
[00:26:15] <ejegg>	 but it turns out duplicate metric names anywhere in hte prometheus stats dir break all the stats on that machine
[00:26:43] <eileen>	 :-(
[00:26:53] <eileen>	 so I see there is a submodule merge commit
[00:27:30] <eileen>	 ah it's this one 0a5606d
[00:30:08] <icinga-wm>	 PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: payments-antifraud is 29549 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 82 days 7 hours - memory use is 21.39M (peak 23.12M, 0.30% of max, fragmentation 1.15%), connected_slaves is 2, donations is 6, jobs is 0, jobs-adyen is 0, jobs-paypal is 38, payments-init is 39, pending is 20, recurring is 3, refund is 0, unsubscribe is 8
[00:31:28] <wikibugs>	 (CR) Ejegg: [C: 2] "Great fix for right now. TODO: fix producer and make this throw an error on any number field out of bounds." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398777 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[00:32:04] <eileen>	 ejegg: can we revert the specific patches that are uncool on live?
[00:34:07] <icinga-wm>	 ACKNOWLEDGEMENT - check_redis on frqueue1001 is CRITICAL: CRITICAL: payments-antifraud is 29549 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 82 days 7 hours - memory use is 21.39M (peak 23.12M, 0.30% of max, fragmentation 1.15%), connected_slaves is 2, donations is 6, jobs is 0, jobs-adyen is 0, jobs-paypal is 38, payments-init is 39, pending is 20, recurring is 3, refund is 0, unsubscribe is 8 J
[00:34:07] <icinga-wm>	  on it
[00:34:22] <wikibugs>	 (Merged) jenkins-bot: Top out risk score at 100 million. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398777 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[00:36:32] <eileen>	 ejegg: I feel like we can patch by removing one line from queue2civicrm.info & reverting vendor patch
[00:37:49] <wikibugs>	 (PS1) Ejegg: Reset deploy branch to match production [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/398778
[00:38:09] <wikibugs>	 (CR) Ejegg: [C: 2] Reset deploy branch to match production [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/398778 (owner: Ejegg)
[00:38:31] <ejegg>	 eileen: ah really? I just reset it all back to match prod, just to be safe
[00:39:03] <wikibugs>	 (Merged) jenkins-bot: Reset deploy branch to match production [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/398778 (owner: Ejegg)
[00:39:08] <eileen>	 so deployment is cleaned up now?
[00:39:20] <ejegg>	 eileen: yep!
[00:39:59] <eileen>	 ok - that looks good
[00:40:04] <ejegg>	 hopefully tomorrow we can get those duplicate stat names sorted and really be done with the cherry-picks
[00:40:37] <eileen>	 I'm gonna merge & then do a quick git diff check & then cherry-pick th enew fix
[00:41:09] <ejegg>	 ok, I think you can actually just merge the new fix
[00:41:28] <ejegg>	 it'll be a little annoying getting all the stuff redeployed, but we can figure it out
[00:41:33] <eileen>	 ok - looks good
[00:42:18] <wikibugs>	 (PS1) Eileen: Top out risk score at 100 million. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/398779 (https://phabricator.wikimedia.org/T183102)
[00:42:30] <wikibugs>	 (CR) Eileen: [C: 2] Top out risk score at 100 million. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/398779 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[00:43:16] <wikibugs>	 (Merged) jenkins-bot: Top out risk score at 100 million. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/398779 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[00:49:36] <eileen>	 !log  civicrm revision changed from 798e24671b to 43d3f4d739
[00:49:47] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[00:50:21] <eileen>	 patch is deployed, ip is blocked, all is spookily calm
[00:50:58] <pcoombe>	 Hi y'all, just checking in because I saw the failmails. Sounds like you've got it in hand though, thanks for being so responsive on a weekend!
[00:51:14] <eileen>	 yep - we think it's all sorted now
[00:51:31] <ejegg>	 thanks eileen!
[00:52:03] <eileen>	 ejegg: seemed to stop before the patch went out - perhaps the ip block?
[00:53:52] <cwd>	 i haven't blocked the IP
[00:53:53] <wikibugs>	 Fundraising-Backlog: Failing job AntifraudQueueConsumer.php on risk_score format - https://phabricator.wikimedia.org/T183102#3843503 (Eileenmcnaughton) We have deployed a patch for this to translate fraud scores higher than 100 million to 100 million. All quiet on the multifredgequeue processor front
[00:53:55] <cwd>	 was debating
[00:54:02] <eileen>	 ah ok
[00:54:12] <cwd>	 in case it's shared
[00:54:15] <eileen>	 well the queue should quiet down now
[00:54:22] <cwd>	 i have seen one more instance in the last 10 minutes
[00:54:32] <eileen>	 because no score is too high any more :-)
[00:54:52] <wikibugs>	 Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Unplanned-Sprint-Work: Failing job AntifraudQueueConsumer.php on risk_score format - https://phabricator.wikimedia.org/T183102#3843504 (Eileenmcnaughton)
[00:54:54] <cwd>	 heh
[00:55:22] <eileen>	 (BTW I stuck 2 story points on the phab - fix was not so hard but since it involved many of us 1 seemed too low)
[00:55:55] <eileen>	 I'm going to go out for lunch now
[00:56:05] <cwd>	 ok, thanks for the fix!
[00:56:11] <cwd>	 i'll keep an eye
[00:59:01] <cwd>	 hrm, seems to still be stuck
[01:17:06] <cwd>	 !log disabled fredge multiqueue consumer
[01:17:16] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[01:58:46] <eileen>	 cwd - argh it didn't work huh?
[01:59:22] <eileen>	 I thought it had when I left
[02:00:55] <cwd>	 eileen: yeah...
[02:01:00] <cwd>	 i started looking at the code
[02:01:05] <cwd>	 but nothing obvious
[02:01:10] <cwd>	 maybe it's not getting there
[02:02:23] <eileen>	 I think I see it
[02:03:59] <eileen>	 there is a second place in the code
[02:04:02] <eileen>	 that relates to updates
[02:09:14] <wikibugs>	 (PS1) Eileen: Extend risk score test to cover components [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398780 (https://phabricator.wikimedia.org/T183102)
[02:12:06] <wikibugs>	 (CR) jerkins-bot: [V: -1] Extend risk score test to cover components [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398780 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[02:13:15] <eileen>	 perfect - got it in the test
[02:13:15] <eileen>	 https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/5816/console
[02:14:15] <wikibugs>	 (PS2) Eileen: Extend risk score limiting to cover components of the score [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398780 (https://phabricator.wikimedia.org/T183102)
[02:14:27] <eileen>	 if that passes I will self merge - think we should get it out
[02:15:23] <cwd>	 yeah
[02:15:27] <cwd>	 i don't mind merging
[02:15:29] <cwd>	 spread the blame
[02:15:47] <cwd>	 what is the error string on the console page?
[02:15:58] <cwd>	 there are no helpful colors
[02:16:31] <cwd>	 "by Sebastian Bergmann"
[02:16:36] <cwd>	 ^ so weird
[02:17:02] <wikibugs>	 (CR) jerkins-bot: [V: -1] Extend risk score limiting to cover components of the score [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398780 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[02:17:08] <cwd>	 ah i see it now
[02:18:40] <cwd>	 eileen: just have to change the # of tests?
[02:19:27] <eileen>	 I think so
[02:24:15] <wikibugs>	 (PS3) Eileen: Extend risk score limiting to cover components of the score [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398780 (https://phabricator.wikimedia.org/T183102)
[02:24:21] <eileen>	 hopefully this time
[02:29:17] <wikibugs>	 (CR) jerkins-bot: [V: -1] Extend risk score limiting to cover components of the score [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398780 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[02:33:08] <eileen>	 hmm issue is in the test still
[02:34:20] <cwd>	 yeah confused
[02:35:38] <cwd>	 i do not have a viable test env atm :(
[02:40:23] <wikibugs>	 (PS4) Eileen: Extend risk score limiting to cover components of the score [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398780 (https://phabricator.wikimedia.org/T183102)
[02:40:25] <eileen>	 ok - that class is now all passing locally
[02:40:29] <eileen>	 so I'm optimistic
[02:41:02] <eileen>	 the problem is the class has some assumptions that I broke - but adding another score vector, but the log showed that vector being a real thing
[02:44:05] <eileen>	 cwd - it passed!
[02:44:24] <cwd>	 awesome, taking a quick look
[02:46:28] <wikibugs>	 (PS1) Eileen: Apply drupal formatting to AntifraudQueueConsumer.php [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398782
[02:46:38] <wikibugs>	 (CR) Cdentinger: Extend risk score limiting to cover components of the score (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398780 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[02:47:09] <cwd>	 eileen: ha
[02:47:26] <eileen>	 :-)
[02:47:28] <cwd>	 so this should be 2 spaces?
[02:47:39] <eileen>	 Drupal formatting is 2 spaces
[02:47:53] <eileen>	 & we've started to reformat files in the drupal area to fit that
[02:48:04] <eileen>	 but the formatting one can wait for later in the week
[02:48:19] <cwd>	 sounds good
[02:48:34] <eileen>	 the thing is vendor dir should mostly follow psr2
[02:48:44] <eileen>	 but drupal dir should follow drupal formatting. sign
[02:48:47] <eileen>	 sigh
[02:48:56] <wikibugs>	 (CR) Cdentinger: [C: 2] Extend risk score limiting to cover components of the score [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398780 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[02:49:12] <cwd>	 what is psr2? tabs?
[02:49:17] <cwd>	 4sp?
[02:49:41] <eileen>	 4 spaces I think
[02:50:19] <eileen>	 also true & drupal is TRUE
[02:50:37] <cwd>	 well drupal rules seem appropriate for civi stuff
[02:50:55] <eileen>	 yeah civi follows drupal stds
[02:51:17] <eileen>	 so basically if it's in vendor it's 4 spaces & if it's in sites then it's 2
[02:51:45] <wikibugs>	 (Merged) jenkins-bot: Extend risk score limiting to cover components of the score [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398780 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[02:53:09] <wikibugs>	 (PS1) Eileen: Extend risk score limiting to cover components of the score [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/398783 (https://phabricator.wikimedia.org/T183102)
[02:56:23] <AndyRussG>	 hey eileen cwd :) pls lmk if there's anything I can help with....
[02:56:35] <wikibugs>	 (CR) Eileen: [C: 2] Extend risk score limiting to cover components of the score [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/398783 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[02:56:59] <eileen>	 AndyRussG: the smiley face is helpful :-)
[02:57:18] <AndyRussG>	 eileen: ;)
[02:57:24] <wikibugs>	 (Merged) jenkins-bot: Extend risk score limiting to cover components of the score [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/398783 (https://phabricator.wikimedia.org/T183102) (owner: Eileen)
[03:00:02] <eileen>	 !log civicrm revision changed from 43d3f4d739 to e0ee2d189c
[03:00:10] <eileen>	 cwd - time to try the job again
[03:00:13] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[03:00:48] <cwd>	 eileen: i'll kick it in a sec
[03:00:53] * cwd looks for keys
[03:00:57] <eileen>	 I can
[03:01:17] <cwd>	 ok go for it
[03:02:22] <eileen>	 !log re-enable multiqueue_consumer process-control config revision is 1ae3778278
[03:02:33] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[03:02:49] <eileen>	 looks like it runs every 3 mins
[03:03:22] <cwd>	 yep, i assume it does a batch?
[03:04:44] <eileen>	 yeah - am watching now -was too cocky last time
[03:04:49] <eileen>	 (or too hungry)
[03:05:12] <cwd>	 :)
[03:05:54] <cwd>	 this rascal will never know they found a bug
[03:06:03] <cwd>	 ...unless they are in this channel
[03:06:16] <cwd>	 <_<
[03:06:21] <cwd>	 >_>
[03:07:24] <cwd>	 https://grafana.wikimedia.org/dashboard/db/fundraising-redis?orgId=1&from=now-15m&to=now
[03:07:26] <cwd>	 nice
[03:08:20] <eileen>	 lol - I must be watching the wrong thing because no output on what I am tailing :-)
[03:09:25] <eileen>	 aha - crazy risk scores passing through 2.0572640052129e+109
[03:12:51] <cwd>	 eileen: \o/
[03:15:08] <icinga-wm>	 RECOVERY - check_redis on frqueue1001 is OK: OK: REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 82 days 10 hours - memory use is 1.96M (peak 24.03M, 0.07% of max, fragmentation 3.07%), connected_slaves is 2, donations is 19, jobs is 0, jobs-adyen is 0, jobs-paypal is 22, payments-antifraud is 9, payments-init is 35, pending is 16, recurring is 4, refund is 0, unsubscribe is 7
[03:26:55] <wikibugs>	 (PS2) Eileen: Greetings fixes to support contact type change. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/398188
[03:26:57] <wikibugs>	 (PS2) Eileen: Greetings fixes (already upstreamed) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/398190 (https://phabricator.wikimedia.org/T156193)
[03:26:59] <wikibugs>	 (PS2) Eileen: Fix for CRM-21180: Inline changes to custom fields aren't reflected in custom greetings. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/398210
[03:27:01] <wikibugs>	 (PS1) Eileen: CRM-21551 Add parameter to support skipping processing greetings when calling api contact.create [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/398786
[03:29:59] <wikibugs>	 (PS2) Eileen: CRM-21551 Add parameter to support skipping processing greetings when calling api contact.create [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/398786 (https://phabricator.wikimedia.org/T156193)
[03:31:00] <wikibugs>	 (PS4) Eileen: Add extension to change contact types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193)
[03:31:02] <wikibugs>	 (PS1) Eileen: CiviCRM updates to support changing contact type. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398787 (https://phabricator.wikimedia.org/T156193)
[03:32:22] <wikibugs>	 (PS1) Eileen: Pass in skip_greeting_proceessing param [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398788 (https://phabricator.wikimedia.org/T156193)
[03:37:47] <wikibugs>	 (CR) jerkins-bot: [V: -1] Add extension to change contact types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen)
[03:40:16] <wikibugs>	 (CR) jerkins-bot: [V: -1] CiviCRM updates to support changing contact type. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398787 (https://phabricator.wikimedia.org/T156193) (owner: Eileen)
[03:40:32] <wikibugs>	 (CR) jerkins-bot: [V: -1] Pass in skip_greeting_proceessing param [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398788 (https://phabricator.wikimedia.org/T156193) (owner: Eileen)
[13:25:46] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, DBA, Epic: fundraising database improvements for 2018 - https://phabricator.wikimedia.org/T183138#3844519 (Jgreen)
[13:26:25] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, DBA, Epic: fundraising database improvements for 2018 - https://phabricator.wikimedia.org/T183138#3844528 (Jgreen) This is an tracking task for improvements for the fundraising (civicirm) database cluster.
[13:27:13] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: add primary keys or unique indexes to some tables in civicrm, drupal, and pgehres databases - https://phabricator.wikimedia.org/T176631#3844530 (Jgreen)
[13:27:15] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, DBA, Epic: fundraising database improvements for 2018 - https://phabricator.wikimedia.org/T183138#3844529 (Jgreen)
[13:29:01] <wikibugs>	 fundraising-tech-ops: encrypt fundraising mysql client->server communication - https://phabricator.wikimedia.org/T170321#3844533 (Jgreen)
[13:29:01] <wikibugs>	 fundraising-tech-ops: encrypt fundraising mariadb replication - https://phabricator.wikimedia.org/T170320#3844534 (Jgreen)
[13:29:03] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, DBA, Epic: fundraising database improvements for 2018 - https://phabricator.wikimedia.org/T183138#3844519 (Jgreen)
[13:33:12] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Ensure that CiviCRM triggers are always the same on staging as on production - https://phabricator.wikimedia.org/T159507#3844542 (Jgreen) I'm not sure whether this problem should be tackled from a database angle, or from a code...
[13:33:40] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Ensure that CiviCRM triggers are always the same on staging as on production - https://phabricator.wikimedia.org/T159507#3844544 (Jgreen)
[13:33:42] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, DBA, Epic: fundraising database improvements for 2018 - https://phabricator.wikimedia.org/T183138#3844543 (Jgreen)
[13:43:30] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, DBA, Epic: test and switch fundraising cluster replication from 'mixed' to 'row' - https://phabricator.wikimedia.org/T183140#3844578 (Jgreen)
[13:44:33] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, Epic: fundraising database improvements for 2018 - https://phabricator.wikimedia.org/T183138#3844592 (Marostegui)
[13:46:54] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: add primary keys or unique indexes to some tables in civicrm, drupal, and pgehres databases - https://phabricator.wikimedia.org/T176631#3844599 (Jgreen) >>! In T176631#3841697, @jcrespo wrote: > @Jgreen My recommendation, in preparation **for next year**, would...
[14:30:47] <mepps>	 morning jgleeson!
[14:30:57] <jgleeson>	 morning mepps :)
[14:31:01] <jgleeson>	 good weekend?
[14:31:13] <mepps>	 in some ways!
[14:31:19] <mepps>	 how about you?
[14:32:48] <jgleeson>	 yea it was good thanks, although a little busy due to the holidays build up
[14:32:58] <jgleeson>	 the roads were busy
[14:33:30] <mepps>	 yeah holiday craziness has definitely begun
[14:35:46] <jgleeson>	 the big english dash is a welcomed sight
[14:37:19] <jgleeson>	 pretty amazing tbh for me to see how quickly something like that can happen
[14:43:32] <jgleeson>	 ah my random disconnections really are a pain
[14:45:01] <mepps>	 yeah definitely jgleeson re: dash, ugh about disconnections!
[14:46:57] <jgleeson>	 I think it may be related to the thinkpad ethernet adapter which is a shame because in all other aspects the laptop is a hero
[14:47:37] <mepps>	 huh weird
[14:54:09] <Jeff_Green>	 jgleeson: case has had some trouble with ethernet too, with Debian and the Intel 8265
[14:55:02] <jgleeson>	 ah so maybe it's driver related
[14:55:12] <Jeff_Green>	 he said he got some improvement by switching to a newer(?) firmware he found on intel's site I think
[14:55:34] <jgleeson>	 thanks for the heads up
[14:55:39] <Jeff_Green>	 it sounds like that's of the flavor where firmware is in RAM instead of on the 'card'
[14:55:56] <Jeff_Green>	 sure, ping him for details, he's probably got better info
[15:13:25] <jgleeson>	 mepps, getting unit tests running on the mw-vagrant vm is not straightforward at the moment, it requires downloading some local civi packages that are missing by default and customising some requirements config due to discrepancies between php and hhvm. The process is easily forgotten though once up and running so I want to write it down somewhere useful for fr-tech. Where would you recommend? Do we have an
[15:13:25] <jgleeson>	 fr-tech specific place for tech docs?
[15:14:03] <mepps>	 i think it's generally this: https://www.mediawiki.org/wiki/Fundraising_tech
[15:14:12] <mepps>	 unless it's something that should be private, in which case it's wikitech
[15:16:20] <jgleeson>	 thanks
[15:16:55] <jgleeson>	 there's actually a head there for Running PHPUnit tests under vagrant
[15:17:04] <jgleeson>	 with a note, FIXME: not working.
[15:17:06] <jgleeson>	 :)
[15:17:54] <ejegg|away>	 l
[15:18:26] <mepps>	 ejegg|away?
[15:18:40] <mepps>	 jgleeson haha
[15:18:42] <ejegg|away>	 oops
[15:19:18] <ejegg>	 hi all!
[15:19:28] <jgleeson>	 hi ejegg
[15:38:04] <mepps>	 hi ejegg!
[15:49:10] <mepps>	 looking into this failmail about missing currency_code ejegg, let me know if you're already on top of it
[15:49:35] <pcoombe>	 Morning MBeat ejegg! We're going to put traffic back up to 100% for a couple of hours for a test. Any objections to that?
[15:50:09] <MBeat>	 that’s fine, pcoombe thanks for the alert
[15:52:43] <ejegg>	 sounds great
[15:52:53] <ejegg>	 mepps thanks, let me know what you find
[15:52:58] <ejegg>	 seems pretty strange!
[15:53:19] <AndyRussG>	 hi fr-tech!
[15:54:05] <ejegg>	 hi AndyRussG !
[15:54:11] <ejegg>	 how was your weekend?
[15:55:38] <AndyRussG>	 ejegg: heheh not toooo bad
[15:55:41] <AndyRussG>	 housework
[15:56:07] <AndyRussG>	 fixed(ish) a sound setup issue on my laptop that appeared after update
[15:56:11] <AndyRussG>	 did a bit of work ;)
[15:56:15] <AndyRussG>	 yours?
[15:56:39] <AndyRussG>	 ah also a longtime friend came over for a short while, that was fun
[15:56:57] <ejegg>	 Mine was good!
[15:57:05] <ejegg>	 went on a pretty long hike saturday
[15:57:31] <ejegg>	 then took an overnight bus on some bumpy roads, but I was tired enough to sleep through it all that night
[15:57:58] <ejegg>	 and yesterday met up with my girlfriend here in lima
[15:59:10] <ejegg>	 she's off exploring the historic center today while i'm camped out in a nearby cafe
[15:59:40] <ejegg>	 pcoombe are you turning that all on now-ish?
[15:59:58] <pcoombe>	 ejegg: Yes, if that's okay with you?
[16:00:07] <ejegg>	 I was thinking of deploying your css & wording updates, but I'll wait till after the test
[16:01:15] <AndyRussG>	 ejegg: cool! sounds great :)
[16:01:30] <pcoombe>	 Okay, thanks. We should be done in a couple of hours
[16:01:36] <ejegg>	 cool
[16:06:23] <pcoombe>	 Traffic is up to 100% now
[16:11:39] <dstrine>	 greetings programs
[16:11:52] <dstrine>	 pcoombe:  yay tests!
[16:13:38] <ejegg>	 fr-tech i'd like to deploy this too when the tests are over: https://gerrit.wikimedia.org/r/398500
[16:13:50] <mepps>	 i'll take a look ejegg
[16:13:52] <dstrine>	 fr-tech I see a bunch of stuff in the analysis column. I already moved the fail mail ticket over to the sprint column. Does anything else need discussing before our standup?
[16:14:38] <wikibugs>	 (PS2) Mepps: Update Amazon SDK fork for logging retries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/398500 (https://phabricator.wikimedia.org/T182735) (owner: Ejegg)
[16:14:45] <wikibugs>	 (CR) Mepps: [C: 2] Update Amazon SDK fork for logging retries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/398500 (https://phabricator.wikimedia.org/T182735) (owner: Ejegg)
[16:14:57] <ejegg>	 dstrine: Ah, that patch ^^^ is to help diagnose T182735
[16:14:57] <stashbot>	 T182735: Amazon gateway - crash on getCaptureDetails failiure? - https://phabricator.wikimedia.org/T182735
[16:15:30] <dstrine>	 ejegg:  shall I move that into the sprint?
[16:15:36] <ejegg>	 yes please
[16:15:47] <wikibugs>	 Fundraising Sprint Winter Wanderland, Fundraising-Backlog, FR-Amazon, MediaWiki-extensions-DonationInterface, Patch-For-Review: Amazon gateway - crash on getCaptureDetails failiure? - https://phabricator.wikimedia.org/T182735#3845282 (DStrine)
[16:16:09] <dstrine>	 cool and thanks
[16:16:16] <ejegg>	 nothing hugely concerning, just one of the last chunks of failmail that I'm not exactly sure of the cause for
[16:16:32] <dstrine>	 cool
[16:16:48] <ejegg>	 thanks mepps!
[16:17:38] <ejegg>	 oh mepps, if you're deploying your dash fix soon, want to roll in this trivial bit? https://gerrit.wikimedia.org/r/394636
[16:17:59] <jgleeson>	 hey fr-tech. When adding bugfix tasks to phabricator, do we just usually create a standard task or is there a bug specific type of task available to use?
[16:18:05] <wikibugs>	 (PS2) Mepps: Update gateway list [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/394636 (owner: Ejegg)
[16:18:10] <wikibugs>	 (CR) Mepps: [C: 2] Update gateway list [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/394636 (owner: Ejegg)
[16:18:16] <ejegg>	 jgleeson: just a normal task
[16:18:32] <ejegg>	 apparently the phab team doesn't believe in bugs
[16:19:10] <jgleeson>	 :)
[16:19:12] <jgleeson>	 ok thanks
[16:19:21] * dstrine grumbles about phab
[16:19:34] <wikibugs>	 (Merged) jenkins-bot: Update gateway list [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/394636 (owner: Ejegg)
[16:19:46] <AndyRussG>	 jgleeson: make sure Fundraising-Backlog project is in the tag field, though, and any other projects as needed (e.g. CentralNotice, CiviCRM, etc.). That'll help ensure the right people see it
[16:20:22] <AndyRussG>	 I usually go to the Fundraising-Backlog workboard (https://phabricator.wikimedia.org/tag/fundraising-backlog/) and use the dropdown at the top of the Analysis column
[16:20:44] <AndyRussG>	 dstrine: phab still loves you ;p
[16:21:45] <wikibugs>	 (CR) Ejegg: [C: 2] Apply drupal formatting to AntifraudQueueConsumer.php [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398782 (owner: Eileen)
[16:21:54] <wikibugs>	 (Merged) jenkins-bot: Update Amazon SDK fork for logging retries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/398500 (https://phabricator.wikimedia.org/T182735) (owner: Ejegg)
[16:22:26] <ejegg>	 thanks again mepps
[16:24:31] <wikibugs>	 Fundraising-Backlog: Bugfix: remove duplicate Prometheus metric keys output from DonationStats .prom file output - https://phabricator.wikimedia.org/T183153#3845307 (jgleeson)
[16:24:46] <wikibugs>	 (Merged) jenkins-bot: Apply drupal formatting to AntifraudQueueConsumer.php [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398782 (owner: Eileen)
[16:24:51] <dstrine>	 AndyRussG:  Yeah in some twisted abusive relationship sort of way
[16:25:47] <AndyRussG>	 dstrine: awwww
[16:26:53] <AndyRussG>	 something bad happened to it in the early stages of its development
[16:38:40] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Adyen: we don't deal well with two responses on same merchant ID - https://phabricator.wikimedia.org/T183155#3845367 (Ejegg)
[16:48:55] <wikibugs>	 Fundraising-Backlog: set dash default to 51 million - https://phabricator.wikimedia.org/T183157#3845409 (DStrine)
[16:52:17] <mepps>	 ejegg do you know where to find a reference for the different global collect payment product ids?
[16:52:51] <wikibugs>	 (PS1) Ejegg: Set 2017 target to 51000000 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/398875 (https://phabricator.wikimedia.org/T183157)
[16:52:55] <ejegg>	 mepps yeah, we should have that on the fileshare
[16:53:18] <mepps>	 ejegg sorry, where is the fileshare?
[16:53:57] <ejegg>	 ah, you'll need to connect to vpn (at least split tunnel, but full works too)
[16:54:24] <ejegg>	 further instructions here: https://office.wikimedia.org/wiki/Fileserver_Access_Guide
[16:54:57] <ejegg>	 hmm, though maybe they've got that documented online now?
[16:55:02] <ejegg>	 let's see...
[16:55:55] <ejegg>	 nah, just the API call that lets you list them: https://epayments.developer-ingenico.com/documentation/api/server/#products
[16:57:52] <mepps>	 cool thanks, also should i deploy this with dash too: https://gerrit.wikimedia.org/r/#/c/398875/
[16:58:12] <ejegg>	 mepps sure, that would be great!
[16:58:24] <ejegg>	 you'll need to run the minify if you include that one is all
[16:58:27] <wikibugs>	 (CR) Mepps: [C: 2] Set 2017 target to 51000000 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/398875 (https://phabricator.wikimedia.org/T183157) (owner: Ejegg)
[16:58:41] <ejegg>	 minify instructions here: https://gerrit.wikimedia.org/r/394371
[16:59:01] <ejegg>	 or was grunt working for you locally? I forget again
[16:59:23] <wikibugs>	 (Merged) jenkins-bot: Set 2017 target to 51000000 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/398875 (https://phabricator.wikimedia.org/T183157) (owner: Ejegg)
[17:01:09] <ejegg>	 mepps so the path on the fileserve will be fundraising/Tech/GatewayDocumentation/GlobalCollect
[17:02:09] <ejegg>	 and I think the latest we have on the old API is WebCollect_technical_guide_2013_Q4.pdf
[17:02:41] <ejegg>	 and Appendix E is the payment product listing
[17:14:38] <jgleeson>	 I know it's a long shot, but fr-tech has anyone ever had a problem with civicrm unit tests not running due to being able to find the "includes" directory within the tests folder?
[17:15:06] <jgleeson>	 getting the following when running the default config, Fatal error: Class 'AmazonDonationMessage' not found in /vagrant/srv/org.wikimedia.civicrm/sites/all/modules/queue2civicrm/tests/phpunit/DonationQueueTest.php on line 374
[17:17:46] <jgleeson>	 s/being able/not being able/
[17:25:20] <ejegg>	 jgleeson hmm, you're not on the deployment branch?
[17:25:35] <jgleeson>	 master
[17:26:03] <ejegg>	 huh, ok
[17:26:21] <ejegg>	 maybe try another drush cc all from inside the drupal dir?
[17:29:18] <jgleeson>	 ok that removed the earlier error and now reports a permissions error
[17:29:19] <jgleeson>	 Warning: file_put_contents(/vagrant/srv/org.wikimedia.civicrm/drupal/sites/default/files/civicrm/templates_c//CachedExtLoader.b0aee97218a03419a9420d72f132f668.php): failed to open stream: Permission denied in /vagrant/srv/org.wikimedia.civicrm/civicrm/CRM/Extension/ClassLoader.php on line 93
[17:29:28] <jgleeson>	 vagrant owns that file
[17:29:42] <jgleeson>	 so I wonder if the unit tests are being run locally as something else
[17:30:40] <ejegg>	 jgleeson ohh, that's annoying
[17:31:08] <ejegg>	 Are you running the tests inside the vm?
[17:31:13] <jgleeson>	 yep
[17:31:39] <ejegg>	 weird, then I'd think you'd be running as vagrant
[17:32:02] <ejegg>	 anyway, if you need to, you can just sudo rm all those templates_c files first
[17:32:23] <ejegg>	 that's just a cache
[17:32:37] <ejegg>	 might have to delete some log files in ConfigAndLog as well
[17:33:14] <jgleeson>	 ah
[17:45:34] <jgleeson>	 I must haven been mistaken earlier, setting vagrant and granting group rw on the template_c dir has fixed it
[17:45:45] <jgleeson>	 setting vagrant as group*
[17:45:46] <ejegg>	 ah, cool!
[17:46:05] <jgleeson>	 it's always fun trying to get phpunit running on the mediawiki vm
[17:46:32] <ejegg>	 oh man, yeah...
[17:46:48] <ejegg>	 i guess that's another reason I just run it all on my real box
[17:46:55] <ejegg>	 (but mostly the battery life)
[17:46:59] <jgleeson>	 this time I am actually going to write down the steps I've gone through somewhere accessible, so I don't forget them again and have to go through the trial and error process
[17:47:07] <ejegg>	 thank you!
[17:47:27] <ejegg>	 I'm sorry I haven't had a chance to try your vagrant patch
[17:48:14] <ejegg>	 Been in a string of places without enough bandwidth to destroy and redownload the whole durn setup
[17:52:03] <jgleeson>	 no problem
[18:43:38] <wikibugs>	 (PS1) Jgleeson: T183153: Removed Prometheus duplicate key output from DonationStats [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398894
[18:47:16] <wikibugs>	 (PS2) Jgleeson: T183153: Removed Prometheus duplicate key output from DonationStats [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398894
[18:52:52] <wikibugs>	 (PS1) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/398896
[20:02:08] <eileen>	 I have the work to change contact type ready for review - but I need to get some bits merged with a bit of juggling before tests will pass
[20:02:09] <eileen>	 https://gerrit.wikimedia.org/r/#/c/398188/
[20:02:29] <eileen>	 a lot of it is already merged upstream
[20:23:00] <wikibugs>	 (CR) Mepps: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/398896 (owner: Mepps)
[20:24:34] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/398896 (owner: Mepps)
[20:26:47] <wikibugs>	 (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/398905
[20:26:58] <wikibugs>	 (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/398905 (owner: Ejegg)
[20:27:50] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/398905 (owner: Ejegg)
[20:30:27] <wikibugs>	 (PS1) Ejegg: Update Amazon SDK for logging [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/398906
[20:30:42] <wikibugs>	 (CR) Ejegg: [C: 2] Update Amazon SDK for logging [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/398906 (owner: Ejegg)
[20:30:56] <wikibugs>	 (PS1) Ejegg: Update vendor submodule [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/398907
[20:31:00] <wikibugs>	 (CR) Ejegg: [C: 2] Update vendor submodule [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/398907 (owner: Ejegg)
[20:31:39] <wikibugs>	 (CR) jerkins-bot: [V: -1] Update vendor submodule [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/398907 (owner: Ejegg)
[20:31:43] <wikibugs>	 (CR) jerkins-bot: [V: -1] Update vendor submodule [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/398907 (owner: Ejegg)
[20:34:05] <wikibugs>	 Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Patch-For-Review: set dash default to 51 million - https://phabricator.wikimedia.org/T183157#3846095 (DStrine)
[20:36:10] <wikibugs>	 Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Patch-For-Review: Bugfix: remove duplicate Prometheus metric keys output from DonationStats .prom file output - https://phabricator.wikimedia.org/T183153#3846100 (DStrine)
[20:39:19] <wikibugs>	 Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Patch-For-Review: Bugfix: remove duplicate Prometheus metric keys output from DonationStats .prom file output - https://phabricator.wikimedia.org/T183153#3846106 (jgleeson) a:jgleeson
[20:39:35] <wikibugs>	 Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Different currencies for Benevity import - https://phabricator.wikimedia.org/T182808#3846108 (DStrine)
[20:40:59] <wikibugs>	 (CR) Ejegg: [V: 2 C: 2] Update Amazon SDK for logging [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/398906 (owner: Ejegg)
[20:44:06] <wikibugs>	 (CR) Ejegg: [C: 2] Update vendor submodule [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/398907 (owner: Ejegg)
[20:44:55] <wikibugs>	 (Merged) jenkins-bot: Update vendor submodule [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/398907 (owner: Ejegg)
[20:45:28] <wikibugs>	 Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Merge on addresses for MG - https://phabricator.wikimedia.org/T181088#3846126 (Eileenmcnaughton) OK  to close this? @LeanneS
[20:45:52] <wikibugs>	 Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Let dedupe run on orgs - https://phabricator.wikimedia.org/T181089#3846127 (Eileenmcnaughton) @LeanneS ok to close this?
[21:03:32] <wikibugs>	 (PS3) Mepps: Update readme with minify workaround [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/394371 (https://phabricator.wikimedia.org/T181467) (owner: Ejegg)
[21:03:37] <wikibugs>	 (CR) Mepps: [C: 2] Update readme with minify workaround [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/394371 (https://phabricator.wikimedia.org/T181467) (owner: Ejegg)
[21:04:43] <wikibugs>	 (Merged) jenkins-bot: Update readme with minify workaround [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/394371 (https://phabricator.wikimedia.org/T181467) (owner: Ejegg)
[21:12:54] <wikibugs>	 Fundraising-Backlog, FR-Ingenico: Close all old and unresolved GC orders - https://phabricator.wikimedia.org/T183190#3846247 (Ejegg)
[21:14:00] <wikibugs>	 Fundraising-Backlog: AUD minimum donation amount error on mobile form? - https://phabricator.wikimedia.org/T183191#3846257 (MBeat33)
[21:25:19] <wikibugs>	 Fundraising-Backlog: AUD minimum donation amount error on mobile form? - https://phabricator.wikimedia.org/T183191#3846257 (Ejegg) Our minimum is 1 USD, which would be 1.30 AUD. I guess the donatewiki logic is rounding up?
[21:28:35] <wikibugs>	 (PS1) Mepps: Revert "Merge branch 'master' into deployment" [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/398938
[21:28:37] <wikibugs>	 (PS1) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/398939
[21:29:17] <wikibugs>	 (Abandoned) Mepps: Revert "Merge branch 'master' into deployment" [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/398938 (owner: Mepps)
[21:35:14] <wikibugs>	 (CR) Ejegg: [C: 2] "Thanks, this looks good! Working locally." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398894 (owner: Jgleeson)
[21:38:11] <wikibugs>	 (Merged) jenkins-bot: T183153: Removed Prometheus duplicate key output from DonationStats [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398894 (owner: Jgleeson)
[21:48:19] <wikibugs>	 (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/398943
[21:48:52] <wikibugs>	 Fundraising-Backlog: AUD minimum donation amount error on mobile form? - https://phabricator.wikimedia.org/T183191#3846390 (Pcoombe) This is actually a banner, and I don't think there's a bug here.   Based on a suggestion by @schoenbaechler we do now round the minimum donation amount up to the nearest whole...
[22:02:29] <jgleeson_>	 bye mepps!
[22:12:47] <eileen>	 if someone wants to look through those contact patches (starting from https://gerrit.wikimedia.org/r/#/c/398188/) ping me to explain
[22:22:04] <wikibugs>	 (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/398943 (owner: Ejegg)
[22:26:27] <wikibugs>	 (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/398943 (owner: Ejegg)
[22:34:10] <ejegg>	 !log updated payments-wiki from f594dfa763 to e91db27108
[22:34:20] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[22:39:44] <ejegg>	 eileen: do you have 15-20 min just now?
[22:41:05] <eileen>	 ejegg: sure do
[22:41:26] <eileen>	 hangout?
[22:41:32] <ejegg>	 cool! hopping into the regular chat
[22:42:40] <eileen>	 all aboard
[22:45:46] <wikibugs>	 (CR) Ejegg: [C: 2] Greetings fixes to support contact type change. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/398188 (owner: Eileen)
[22:51:12] <wikibugs>	 (Merged) jenkins-bot: Greetings fixes to support contact type change. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/398188 (owner: Eileen)
[22:51:39] <wikibugs>	 (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen)
[22:52:11] <wikibugs>	 (CR) Ejegg: [C: 2] Greetings fixes (already upstreamed) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/398190 (https://phabricator.wikimedia.org/T156193) (owner: Eileen)
[22:54:37] <wikibugs>	 (CR) jerkins-bot: [V: -1] Add extension to change contact types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen)
[22:55:03] <wikibugs>	 (PS2) Eileen: Pass in skip_greeting_proceessing param [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398788 (https://phabricator.wikimedia.org/T156193)
[22:57:09] <wikibugs>	 (Merged) jenkins-bot: Greetings fixes (already upstreamed) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/398190 (https://phabricator.wikimedia.org/T156193) (owner: Eileen)
[23:06:16] <wikibugs>	 (Abandoned) Eileen: CiviCRM updates to support changing contact type. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398787 (https://phabricator.wikimedia.org/T156193) (owner: Eileen)
[23:06:42] <wikibugs>	 (PS5) Eileen: Add extension to change contact types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193)
[23:11:33] <wikibugs>	 (CR) jerkins-bot: [V: -1] Add extension to change contact types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen)
[23:23:29] <wikibugs>	 Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Merge on addresses for MG - https://phabricator.wikimedia.org/T181088#3846762 (LeanneS) @NNichols and @DKaufman Since you're doing the bulk of merges right...