[06:25:32] (Abandoned) Eileen: Extract function to get Importer class (to re-use from another place) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/399251 (https://phabricator.wikimedia.org/T182808) (owner: Eileen) [12:05:46] (PS4) Jgleeson: Updated stats-collector composer package to version 1.0.1 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398495 [16:39:55] hi fr-tech! [16:43:13] hey mepps :) [16:43:32] James okay? [16:44:25] yes it was just the 18 month check up [16:44:36] but he had to get a shot and the whole appointment took forever [16:45:52] ah good :) [16:46:28] how was he with the shot? Oscar was really distressed during his last one so it was hard [16:49:18] yeah he was upset [16:49:35] enough that i almost cried, but he recovered quickly [16:49:49] :( [16:50:25] good that he recovered quickly.. and it's done and our of the way [17:06:12] Fundraising-Backlog: Add formatting capabilities (?) to Details field of an Activity - https://phabricator.wikimedia.org/T183389#3851761 (CaitVirtue) [17:07:14] Fundraising-Backlog: Add formatting capabilities (?) to Details field of an Activity - https://phabricator.wikimedia.org/T183389#3851761 (CaitVirtue) {F11955073} [17:08:38] Fundraising-Backlog: Add formatting capabilities (?) to Details field of an Activity - https://phabricator.wikimedia.org/T183389#3851776 (CaitVirtue) Currently, text added to that field looks like the screenshot above, but I'd like it to render more like it does in the original message, like this: Marc, I... [17:56:28] dstrine: hey... FWI, it really seems likely that something in the WMDE banner code is causing the problem, following the most recent Pivot queries, just posted on the task [17:56:47] yup I read all that [17:57:06] dstrine: ...mmm just posted another one 30 seconds ago ;) [17:57:14] oh [17:57:15] Sorry 3 min ago [17:57:16] 1 second [17:57:21] heheheh [17:57:37] also seems to indicate that the test Seddon was thinking of doing seems a lot less urgent [17:58:20] gotta disconnect to relocate, back here in a little while!!!! [17:58:48] I think we wanted to do a very simple banner. That would still help indicate that the current banners have something complex going on in them [17:59:01] we=he=Seddon [18:04:18] fr-tech, signing off, have a great one o/ [18:18:01] (PS1) Mepps: Update readme with minify workaround [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/399442 (https://phabricator.wikimedia.org/T181467) [18:18:04] (PS1) Mepps: Update dist correctly [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/399443 [18:18:12] okay ejegg i think i got it this time [18:21:00] nice! [18:21:17] fr-tech any scrum of scrums news? [18:21:31] (CR) Mepps: [C: 2] Update readme with minify workaround [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/399442 (https://phabricator.wikimedia.org/T181467) (owner: Mepps) [18:21:35] (CR) Mepps: [C: 2] Update dist correctly [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/399443 (owner: Mepps) [18:22:30] (Merged) jenkins-bot: Update readme with minify workaround [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/399442 (https://phabricator.wikimedia.org/T181467) (owner: Mepps) [18:22:36] (Merged) jenkins-bot: Update dist correctly [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/399443 (owner: Mepps) [18:35:51] okay ejegg got through the deploy but saw another bug so had to rollback again [18:37:31] ok, what's the new bug? [18:39:05] the numbers weren't displaying in the charts [18:41:26] the problem is i'm seeing this bug by default in my local copy (even after rolling back before the first merge in this deploy) so it's tough to know what's causing it [18:46:52] mepps ok, just got done scrum of scrums, I'll pull down the latest deploy branch and check it out [18:47:02] cool ejegg [18:48:42] just editing server.js line 110 to make it use dist even without real auth [18:49:32] ? [18:49:40] ah [18:50:08] mepps do you have test data locally that should be showing up? [18:50:14] i.e. from the last few months? [18:50:38] no not a lot from the last few months, but i can make it now--that's definitely what's missing [18:51:08] OK, locally the current deploy branch seems to be working for me [18:51:22] lemme just verify that's what it's using... [18:51:42] yeah, it's the minified file [18:52:47] okay cool ejegg [18:53:06] maybe it was a blip what i saw? [18:53:39] i've just discovered my local version of crm is broken :( [18:53:49] ah dang [18:54:28] ah, wait, it's minified, but is it current? [18:54:49] i think so! i reminified it before deploy [18:55:06] yeah, I think I'm just looking at ff's cache here, lemme see [18:55:18] looks like new versions of bootstrap etc [18:56:47] err, wait, or older versions? [18:57:01] mepps, do you have bower_modules up to date? [18:57:16] or did I have them wrong [18:57:21] ? [18:57:49] it looks like they're up to date ejegg [19:01:37] mepps I'm just a bit confused about all the version changes in this: https://gerrit.wikimedia.org/r/#/c/398896/1/dist/scripts-0875ff1e.js [19:01:55] Like, did moment.js actually get rolled back to 2.7.0? [19:07:36] OK, it still contains utcOffset, so I guess not [19:09:49] ejegg brb just relocating out of my house [19:11:08] k [19:18:13] mepps I need to get some lunch in me [19:20:21] Sounds good [19:29:47] (PS1) Mepps: Update dist with latest node modules [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/399455 [19:31:37] (CR) Mepps: [C: 2] Update dist with latest node modules [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/399455 (owner: Mepps) [19:32:38] (Merged) jenkins-bot: Update dist with latest node modules [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/399455 (owner: Mepps) [20:11:56] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Merge on addresses for MG - https://phabricator.wikimedia.org/T181088#3852363 (NNichols) @Eileenmcnaughton Sorry for the delay! I have definitely noticed... [20:33:40] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Merge on addresses for MG - https://phabricator.wikimedia.org/T181088#3852451 (Eileenmcnaughton) Open>Resolved Thanks @NNichols [20:38:54] mepps hi again! [20:40:09] hi ejegg! [20:40:12] did you try deploying again? [20:42:35] yes, ran into a new, and completely inscrutable bug [20:42:43] i even update moment.js locally [20:42:48] ejegg: did you reach some degree of comfort on this one? https://gerrit.wikimedia.org/r/#/c/398210/ - I'd like to try to get the tests passing on the main pr - but need the civi ones merged [20:42:49] https://gerrit.wikimedia.org/r/#/c/399455/ [20:42:51] updated [20:43:43] yep, I saw that [20:43:51] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Different currencies for Benevity import - https://phabricator.wikimedia.org/T182808#3852478 (Eileenmcnaughton) a:Eileenmcnaughton [20:43:56] so now, locally, everything works well [20:44:06] looks good to me locally [20:44:18] eileen sorry, getting back to that now! [20:44:23] thx [20:44:27] yes but after deploying i was getting a weird error with the date on the totals-earned chart [20:45:05] mepps can we try deploying again so I can see it? [20:46:23] done ejegg [20:46:31] ok, reloading [20:47:14] i'm currently seeing the charts be really slow to load post-deploy [20:47:27] hmm, slow to load is kinda normal [20:47:36] so it's as of Invalid date [20:47:40] it does cache the results [20:47:44] on the totals-earned chart [20:47:44] hmm [20:47:52] oh... weird [20:48:15] are you seeing that/ [20:49:12] mepps oh, dang, I'm seeing a select access denied [20:49:20] huh weird [20:49:23] what would cause that? [20:51:33] (PS3) Eileen: [wip]Allow Benevity currencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/399252 (https://phabricator.wikimedia.org/T182808) [21:05:31] (PS1) Mepps: Fix data.js [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/399467 [21:06:31] (CR) jerkins-bot: [V: -1] Fix data.js [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/399467 (owner: Mepps) [21:13:41] (PS2) Mepps: Fix data.js [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/399467 [21:13:48] ejegg ^^ [21:14:32] (CR) jerkins-bot: [V: -1] Fix data.js [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/399467 (owner: Mepps) [21:15:37] ah, just need to put that var declaration back [21:16:42] mepps I think the .end() needs to go inside the results callback, too [21:16:55] not according the documentation ejegg [21:17:05] https://github.com/mysqljs/mysql [21:17:13] ah, thanks! [21:17:34] (PS3) Mepps: Fix data.js [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/399467 [21:17:56] oh cool, .end waits for the queries to finish! [21:18:05] nice! [21:18:05] might be worth a reassuring comment in our code? [21:19:51] (PS4) Mepps: Fix data.js [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/399467 [21:23:02] (CR) Ejegg: [C: 2] Fix data.js [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/399467 (owner: Mepps) [21:24:01] (Merged) jenkins-bot: Fix data.js [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/399467 (owner: Mepps) [21:35:03] (PS1) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/399473 [21:36:36] (CR) Mepps: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/399473 (owner: Mepps) [21:37:47] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/399473 (owner: Mepps) [21:39:58] okay just deployed ejegg and it looks good so far to me if you want to poke around [21:42:07] !log updated dash from 114131713e to b01458b260 [21:42:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:43:37] great! [21:44:33] yeah, looks good to me too [21:44:42] phew! [22:01:55] (PS1) Rafidaslam: Add minus-x to "composer test" [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/399480 (https://phabricator.wikimedia.org/T175794) [22:02:05] (CR) jerkins-bot: [V: -1] Add minus-x to "composer test" [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/399480 (https://phabricator.wikimedia.org/T175794) (owner: Rafidaslam) [22:02:26] (CR) Ejegg: [C: 2] "Couple of concerns, but mostly looks good!" (6 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/398210 (owner: Eileen) [22:05:27] (Merged) jenkins-bot: Fix for CRM-21180: Inline changes to custom fields aren't reflected in custom greetings. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/398210 (owner: Eileen) [22:08:40] (CR) Ejegg: [C: 2] CRM-21551 Add parameter to support skipping processing greetings when calling api contact.create [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/398786 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [22:09:14] (CR) Rafidaslam: "Hmm, I think we need to add `composer.lock` and perhaps `vendor/` to the `.gitignore`?" [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/399480 (https://phabricator.wikimedia.org/T175794) (owner: Rafidaslam) [22:10:01] (CR) Ejegg: [C: 2] Pass in skip_greeting_proceessing param [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398788 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [22:10:37] (CR) Rafidaslam: "I think adding `composer.lock` to `.gitignore` is sufficent for this.." [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/399480 (https://phabricator.wikimedia.org/T175794) (owner: Rafidaslam) [22:11:35] (CR) Eileen: Fix for CRM-21180: Inline changes to custom fields aren't reflected in custom greetings. (3 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/398210 (owner: Eileen) [22:11:53] (Merged) jenkins-bot: CRM-21551 Add parameter to support skipping processing greetings when calling api contact.create [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/398786 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [22:12:04] thanks ejegg - now to see if I can get tests to pass [22:12:10] (CR) Ejegg: "Unfortunately, anything deployed to the payments cluster needs to be checked out directly from gerrit rather than pulled in from composer." [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/399480 (https://phabricator.wikimedia.org/T175794) (owner: Rafidaslam) [22:15:01] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [22:15:10] (Merged) jenkins-bot: Pass in skip_greeting_proceessing param [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398788 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [22:19:22] ohhh ejegg it was enough to get the main one passing [22:19:23] https://gerrit.wikimedia.org/r/#/c/398176/ [22:21:09] (CR) Rafidaslam: "> Unfortunately, anything deployed to the payments cluster needs to" [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/399480 (https://phabricator.wikimedia.org/T175794) (owner: Rafidaslam) [22:22:08] ejegg: mepps regarding ^^ - from talking to Leanne that PR (adding an extension to change contact types) - would be nice sooner but doesn't have to be before Jan, - I'm conscious that we may not have anyone with time to review it [22:35:56] cool, eileen [22:36:29] so lemme get up to speed on the current state of contact types and how the ext fixes stuff [22:36:36] ejegg: also - I don't think it needs to be you - ie. it's not so tightly coupled with what you already reviewed that it needs to [22:36:37] be [22:36:59] most of the core fixes were so I could run unit tests on it [22:38:03] I might deploy the civi changes now actually [22:42:12] cool! [22:43:20] weird, wikibugs didn't mention a DonationInterface bug I just created [22:43:30] oops, left off the fundraising-backlog tag [22:43:36] thanks, wikibugs! [22:43:51] Fundraising-Backlog, FR-Amazon, FR-Smashpig, MediaWiki-extensions-DonationInterface: Deal better with Amazon auth/capture timing out - https://phabricator.wikimedia.org/T183429#3852834 (Ejegg) [22:46:12] Fundraising-Backlog, FR-Amazon, FR-Smashpig, MediaWiki-extensions-DonationInterface: Deal better with Amazon auth/capture timing out - https://phabricator.wikimedia.org/T183429#3852848 (Ejegg) [23:16:13] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Different currencies for Benevity import - https://phabricator.wikimedia.org/T182808#3852889 (Eileenmcnaughton) [23:56:28] (CR) Umherirrender: "It is a devDependency, so you could handle it like php-parallel-lint is handeld: The file under vendor are ignored by .gitignore, but comp" [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/399480 (https://phabricator.wikimedia.org/T175794) (owner: Rafidaslam)