[10:47:50] AndyRussG: is there any (documented) recommendation on how to programmatically assign users to other buckets? [10:54:41] maybe pcoombe or Seddon? [10:55:23] Kai_WMDE: AndyRussG is probably the one to ask, if he's around [10:56:28] pcoombe: yes, that's what I thought. I'll just wait a little. [13:14:36] (PS2) Jgleeson: Restored `composer test` script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/399670 [13:59:24] (CR) Thiemo Kreuz (WMDE): [C: 1] Removed use of deprecated "= &new" being reported by phplint on crm project. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/399669 (owner: Jgleeson) [14:08:42] http://www.clickhole.com/article/call-action-wikipedia-asking-each-its-users-donate-7132 [14:44:30] hi fr-tech :) [14:44:34] hi jgleeson! [14:44:36] how are you? [14:45:02] good now, just sat down and got a coffee cooling beside me [14:45:10] been picking up some last minute gifts [14:45:53] brought my laptop with me and found a great little coffee shop hidden away from the bustling main streets [14:48:19] how are you? [14:49:26] i'm okay jgleeson, had a slightly rough morning with james but otherwise fine [14:51:08] ah sorry to hear, all ok now? [14:52:01] he'll soon be no doubt fascinated with the wrapping paper of the numerous presents he'll be given for xmas :) [14:52:15] if he's anything like Oscar [14:56:30] yeah it's fine now jgleeson, he just didn't want to wear his diaper [14:56:37] :) [14:57:02] hi ejegg :) [15:05:51] hello! [15:08:31] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, and 5 others: Registering test in impressions - https://phabricator.wikimedia.org/T176334#3856864 (Pcoombe) Even after updating all the banners, we co... [15:10:18] Kai_WMDE: morning! [15:10:33] fr-tech hey! :) [15:11:05] hi AndyRussG, how's it going? [15:13:45] hey AndyRussG [15:13:46] :) [15:15:03] :) [15:15:11] ejegg: not toooooooo bad, yourself? [15:16:03] Kai_WMDE: I don't recall any recent documentation on buckets in any case, so if you find any it may be out of date [15:17:00] ok [15:17:50] Kai_WMDE: what's the use case you're thinking of? [15:17:55] doing pretty good [15:18:01] in the meantime, i found another approach for what we want to achieve [15:18:22] we have two different banners that are supposed to show 4 times each [15:18:26] subsequently [15:18:35] Kai_WMDE: have you looked at the banner sequence feature? [15:18:40] that's what it's for :) [15:19:20] oh, err, no [15:19:24] The old usage of buckets, basically overloading a feature that was for A/B testing with another use, was sort of for that too [15:19:55] but that seems like it's exactly what I'm looking for :) [15:20:17] banner sequence is pretty new and shiney... Should work, though I'm not sure if it's been tested at scale yet [15:20:53] Kai_WMDE: pls lmk if I can help out with any details there :) [15:21:21] if I recall jessica correctly, there was some kind of trouble when you first tested this function [15:22:03] Till_WMDE: Hmmmm I don't recall any issues on production per se... pcoombe anything there? [15:22:07] but maybe you got that fixed [15:22:31] The issue that's pending is how the config looks (ugly and no info) for users that don't have CN admin rights [15:22:47] IIRC that's the biggest pain point right now [15:23:22] Under normal circumstances, for example with the banner sequence feature, I'd recommend setting up only 2 buckets. On a first pageview in a campaign, CN will only automatically chose randomly between buckets 0 and 1 (A and B) [15:23:58] The other buckets only ever get used if there's code that specifically sends users to them, either in the banner, or by way of the large-banner-limit-and-switch mixin [15:24:13] AndyRussG Till_WMDE : We used banner sequencing a bit, and never had any problems with it [15:24:32] pcoombe: perfect [15:25:06] However banner sequence can replace _almost_ all the features of the banner limit-and-switch (the only one missing is the re-shuffling of buckets after the first pageview) [15:25:26] pls lmk how it goes!! :) [15:26:06] sounds good. [15:26:11] ok, let's give it a try :) [15:26:25] thanks, AndyRussG [15:27:24] Kai_WMDE: yw :) ...any news on the banner close status code issue? I tried poking around more at some of your banners but couldn't trigger any unwanted close cookies [15:27:49] Also last night I ran a Hive query to break this down by platform/browser/browser version [15:27:58] Just about to assemble the results [15:28:24] (This is one of the times we need to go to Hive, since this isn't available in Pivot/Druid) [15:33:29] AndyRussG: we're currently quite busy with finishing the campaign [15:33:55] that ticket is on my todo-list, atm just not so high up [15:36:42] Fundraising-Backlog, ยง Fundraising Sprint Abba: Make DI forms visually match what's on donate wiki - https://phabricator.wikimedia.org/T86086#3856988 (Pcoombe) Open>Resolved a:Pcoombe Fixed as part of T181252 [15:36:44] Fundraising-Backlog, Epic: [epic] Make WorldPay more robust - https://phabricator.wikimedia.org/T77909#3856993 (Pcoombe) [15:39:33] Fundraising-Backlog, FR-Adyen, FR-Ingenico: Randomly show adyen or ingenico in form - https://phabricator.wikimedia.org/T143017#3857012 (Pcoombe) Open>Invalid It's easier to do this within banners now, so I don't think we need this any longer. [15:45:00] Kai_WMDE: ok... I'm worried that there might be a large number of banners not showing that should be shown... A lot of people at the WMF are off next week, BTW, but I will be working [15:58:47] (PS1) Ejegg: Amazon: show TY page on TransactionTimedOut [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399832 (https://phabricator.wikimedia.org/T183429) [16:39:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Make CentralNotice banner completely believe it to be in a certain country - https://phabricator.wikimedia.org/T111071#3857212 (Pcoombe) Open>Resolved a:Pcoombe You can now use `mw.centralNotice.data.country` in the banner cod... [16:52:13] Kai_WMDE: just posted by-platform data on hide code results on the Phab task [17:01:47] AndyRussG: you free for a meeting? [17:04:43] (PS1) Ejegg: WIP Amazon: automatic retry on TransactionTimedOut [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/399841 (https://phabricator.wikimedia.org/T183429) [17:21:22] Hi AndyRussG, just checking out some old tasks. I think https://phabricator.wikimedia.org/T167557 can be resolved? We've never seen it reoccur [17:22:21] pcoombe: I'll check into it :) [17:26:31] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, FR-Amazon, MediaWiki-extensions-DonationInterface, Patch-For-Review: Amazon errors showing up as [Object object] - https://phabricator.wikimedia.org/T183477#3857457 (Ejegg) p:Triage>High a:Ejegg [17:33:48] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Test adding WMF logo to donation form on mobile - https://phabricator.wikimedia.org/T183574#3857487 (Pcoombe) [17:36:53] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Test adding WMF logo to donation form on mobile - https://phabricator.wikimedia.org/T183574#3857512 (Pcoombe) [17:41:58] fr-tech I'm gonna jump offline now. If I don't speak to you before, happy holidays and have a great new year! [17:42:08] bye for now [18:38:25] fundraising-tech-ops: reimage bismuth to Jessie - https://phabricator.wikimedia.org/T165392#3264884 (cwdent) Unless I'm mistaken we don't have a backup of this server so we should either get one or will need downtime for this reimage. [19:17:43] (PS2) Mepps: Properly serialize Amazon error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399659 (https://phabricator.wikimedia.org/T183477) (owner: Ejegg) [19:18:00] (CR) Mepps: [C: 2] Properly serialize Amazon error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399659 (https://phabricator.wikimedia.org/T183477) (owner: Ejegg) [19:20:06] (Merged) jenkins-bot: Properly serialize Amazon error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399659 (https://phabricator.wikimedia.org/T183477) (owner: Ejegg) [19:25:38] (PS2) Mepps: Amazon: show TY page on TransactionTimedOut [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399832 (https://phabricator.wikimedia.org/T183429) (owner: Ejegg) [19:25:42] (CR) Mepps: [C: 2] Amazon: show TY page on TransactionTimedOut [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399832 (https://phabricator.wikimedia.org/T183429) (owner: Ejegg) [19:27:12] (Merged) jenkins-bot: Amazon: show TY page on TransactionTimedOut [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399832 (https://phabricator.wikimedia.org/T183429) (owner: Ejegg) [19:39:34] thanks for the review mepps! [20:08:21] (PS1) Ejegg: Fallback on NumberFormatter construct failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399884 (https://phabricator.wikimedia.org/T182737) [20:09:07] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Fatal error in Amount formatting - https://phabricator.wikimedia.org/T182737#3857913 (Ejegg) p:Triage>Normal a:Ejegg [20:11:04] cwd: how are the dash connections looking? [20:11:12] still lots left open? [20:11:21] db connections, that is [20:11:29] i'll check [20:11:47] thanks! [20:12:01] mepps deployed a fix to close 'em, I think yesterday [20:12:07] * cwd searches for keys [20:12:43] ejegg i think that finally went up on wednesday [20:13:05] https://xkcd.com/1931/ [20:13:09] mepps ah, thanks! [20:13:26] ok, so any connections from before should definitely have timed out by now [20:17:35] phew [20:17:46] cwd found your keys? [20:17:49] one thing about winter is there are a lot of pockets involved [20:17:54] heh [20:18:13] I used to consider that an advantage [20:18:42] before i toted a laptop everywhere and had to have a bag in any case [20:19:00] https://xkcd.com/15/ [20:19:41] ok well things seem quiet. I'm going to run. I'll be watching email all break. [20:19:50] see ya dstrine [20:19:50] see you all! [20:19:56] have a good holiday dstrine [20:19:57] have a good vacation! [20:19:59] me too, just came on to say I've filled in the thing [20:20:13] o/ [20:20:51] ejegg: those were all frdev connections right? [20:20:56] cwd yeah [20:21:06] yep processlist is small [20:21:10] nice! [20:21:11] looks normal [20:21:20] mepps want to do the honors with the task? [20:21:50] ejegg sure! [20:22:31] Fundraising Sprint Winter Wanderland, Fundraising-Backlog: dash(?) is leaving mysql connections dangling - https://phabricator.wikimedia.org/T182440#3857933 (mepps) Open>Resolved a:mepps [20:36:58] (PS1) Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/399895 [21:50:43] mepps: is there a way to tell civibuild to use local source code instead of downloading new civicrm-core? [22:16:17] oh hah, of course there is, we do that in CI [22:21:17] ah, but we're not really using civibuild [22:30:55] (PS2) Ejegg: Amazon: automatic retry on TransactionTimedOut [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/399841 (https://phabricator.wikimedia.org/T183429) [23:01:27] Hi XenoRyet [23:01:42] Howdy [23:01:52] mepps managed to review the bit in DonationInterface about Amazon TransactionTimedOut [23:02:03] Yea, was just looking at that. [23:02:07] but there's another part in SmashPig to automatically retry them: [23:02:13] https://gerrit.wikimedia.org/r/399841 [23:02:20] Good times, I'll take a look. [23:04:12] i'm just about out of battery here [23:04:29] might take that as a sign it's time to stop staring at this screen [23:04:42] Usually a good indicator, that. [23:04:45] but if you have any questions you can ping me on IRC and my phone will beep [23:04:55] Yea, will do. [23:05:05] ok, have a great vacation! [23:05:16] You too. Have fun!