[07:10:07] PROBLEM - check_procs on frdev1001 is CRITICAL: PROCS CRITICAL: 1418 processes [07:15:16] RECOVERY - check_procs on frdev1001 is OK: PROCS OK: 261 processes [13:40:48] Hello all o/ [13:56:06] jgleeson: boo! [13:56:20] How's everything? [13:56:27] hey AndyRussG :) [13:56:38] ;) [13:56:42] all good how about you? did you have a good holiday period [13:56:53] eh not toooo bad :) [13:57:15] good good :) [13:57:50] aaaaaaaaaaaarg cofffeeeeeeeeeeeee [13:58:28] good idea [14:00:47] Morrrninh [14:01:04] 'Mornin indeed [14:03:42] hey all [14:03:48] I'm on just in case [14:03:59] Good times [14:04:12] I am and the human slack bridge just in case [14:04:15] :) [14:04:22] hehe [14:04:47] sigh i thought i'd be okay with james because he's been sleeping until 7ish but i can hear him crying right now :/ [14:05:07] He knows... [14:05:13] mepps: aww [14:05:14] Kids always know [14:05:14] oooh mepps I forgot you are on the west coast [14:05:28] heh the gang's almost all here! [14:06:16] Yeah he’d finally adjusted to the time change but today he started crying at 5:45 [14:07:06] aww [14:07:52] in any case looks like there won't be any surprise replag wrecking havoc unnoticed today :) [14:09:18] hi all! [14:09:40] Hi [14:12:20] hey mepps XenoRyet ejegg :) [14:12:42] :) [14:12:52] James is up so I may have some “help” this morning [14:13:58] The timezones have been kind to me today [14:26:02] and of course i only just saw k4-713's email--but james was up before me so i'd be up anyways [14:27:43] * cwd yawns [14:32:20] :) [14:38:02] So it's 2018 for Eileen [16:08:50] ding ding! [16:15:54] jgleeson: dong dong? [16:16:04] Sorry as in ding, dong [16:16:23] the dash made the sound :) [16:16:29] ahhhh cool [16:16:30] although I am guessing I heard it late [16:16:30] yes [16:17:47] gonna afk for about 15 minutes then I'll check out impression rates... should be in soon, if not there already! [16:26:13] ok see you soon o/ [16:43:03] jgleeson: :) back now.... (silly dog thought I should walk him....) [16:45:43] :) [16:47:48] I'm hitting a mental block on how to include unit test helpers across different tests [16:49:34] I've tried setting/using a namespace (although it becomes ugly due to the tests dir structure) and also require/include but both approaches resulting in errors [16:50:14] ah I'll revert back to the simple solution of having the file in the directory of the test files that need it [16:51:14] no doubt, the thing I'm doing wrong will come to me tonight when lying in bed trying to get to sleep.. [16:54:26] That's typically when coding problems get solved. [16:56:48] yup [16:58:16] jgleeson: hmmm IIRC there is some cross-unit-test stuff in CN, lemme peek [17:00:31] fr-tech as far as we have data in Druid/Pivot, using the non-rigorous quick graph comparison impression rates check method, rates look fine :) [17:01:14] wouldn't dare say the same for my use of English grammar, tho [17:01:31] you and me both [17:01:48] which is why I use grammarly [17:01:49] jgleeson it looks like the way smashpig does it is to use a namespace and then the test extends a base testcase [17:02:01] and the base testcase has the helper methods [17:02:20] ah I see [17:02:27] thanks mepps :) [17:02:38] I'll see if I can work that in [17:07:21] jgleeson: here's a CN test helper: https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/a21f86738b8b49e6f005b541247d23b39041d3f5/tests/CentralNoticeTestFixtures.php [17:08:25] we just instantiate it and set it as a property of the test class in the setUp() method: https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/a21f86738b8b49e6f005b541247d23b39041d3f5/tests/ChoiceDataProviderTest.php#L15 [17:10:36] It gets added to $wgAutoloadClasses in a Mediawiki hook that's only run for tests: https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/a21f86738b8b49e6f005b541247d23b39041d3f5/CentralNotice.hooks.php#L328 [17:11:03] (dunno if that's at all useful for your specific case) [17:13:45] thanks AndyRussG. It is helpful to see the different implementations. It's one of those cases where the way forward is subjective, so it good to get the perspective of others who've come up with a pattern beforehand... standing on the shoulders of giants kinda thing :) [17:14:25] ultimately saving me thinking time :) [17:14:33] and refactor/clean-up time [17:14:57] it is good* [17:17:06] jgleeson: mmm IIRC this bit was Adam Wight's initiative :) yeah I remember lots of early programming mistakes I made that I could have avoided by studying previous stuff better 8p [17:18:23] :) [17:36:02] (PS10) Jgleeson: WIP DonationStats now tracking average processing times [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392425 [17:37:38] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, Fundraising-Backlog: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3865244 (jgleeson) //Filter// defa... [17:49:43] fr-tech, looks like we've had a good run so far today. I am heading off now. I hope you all have a great NYE where you are!!! see you in 2018 :) [18:01:37] Yep, looks like everything is ticking over smoothly, I'm going to sign off as well.