[00:07:41] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, and 6 others: Registering test in impressions - https://phabricator.wikimedia.org/T176334#3870139 (AndyRussG) >>! In T176334#3856864, @Pco... [00:14:03] eileen: yeah since I have their time estimates from last year I can look at their rates year over year [00:14:10] that's the magic number [00:16:51] dstrine: ok - I guess the thing is we tried to reduce the number they would need to manually merge [00:17:07] so that would show as growth in the merges by mr null [00:17:15] yeah that too [00:18:23] but even if null grew a lot manual merges could still "feel" tough and I want to be able to tell them that they are actually becoming more productive [00:22:21] yeah - that would be nice. The time tracking mechanism is probably pretty inaccurate sadly since I think only one or 2 of them have concentrated merging sessions & tbh the better the manual job works the less productive that will be - ie. all the easy ones will be done & they will be left with the must-research ones [00:23:10] btw the code to change contact type is in review at the moment - that will help them - but requires mepps or ejegg to review & they are both in short supply right now [00:28:17] cwd that Amazon message - do you know about that? [00:28:36] just saw your email [00:28:56] does not look familiar... [00:29:12] i wonder if it could have to do with the IP whitelist still [00:29:51] seems likely [00:29:58] there was a flood of other whitelisty messages [00:30:10] yeah [00:30:30] it's a php exception message so i don't know how trustworthy the literal text is :S [00:30:42] :-) [00:30:58] i thought we were using a proxy now for amazon stuff so the whitelisting could stop [00:33:18] cwd - email from Jack on it [00:34:19] ah ha [00:34:40] i *think* they only deployed to thulium so it should be an easy rollback [00:34:55] in any case that's the only code what is esplode [00:35:11] ok - I was just trying to figure that out - because I haven't deployed smashpig [00:35:19] but I thought it would be an update to vendor dir [00:36:08] but no recent updates in there [00:37:21] i believe thulium has a standalone smash pig installation [00:37:27] let's see... [00:42:03] well this is offering a rollback to the thing that looks right [00:42:04] fundraising_code_update -p SmashPig=rollback [00:42:53] (have not hit go on it yet though) [00:46:29] cwd - shall I just hit go on that or are you still digging? [00:46:53] eileen: go for it... got lost in the submodules [00:50:57] cwd how would I see if it had just gone to Thulium? [00:51:48] !log rollback smashPig SmashPig revision changed from ab7802d5b3 to 45aa62650c (locked), config revision is 4a4c61ae1b [00:51:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:52:04] (I rolled it back on all - seemed to update on all so probably was on all?) [00:52:20] yeah, i'm trying to think [00:52:27] you can look at the files in /srv [00:52:39] on each host or frpm? [00:52:41] but i am wondering if it is installed anywhere else explicitly, besides thulium? [00:52:48] on each host [00:52:56] isn't it a submodule in all other cases? [00:53:17] thulium and saiph (backup listener) [00:53:19] that makes sense but I got a much longer list [00:53:29] inc payments *8 [00:55:13] ah yes i see that in the config [00:55:26] i'm not sure why off hand [00:58:52] well I think it rolled back OK.... [00:59:07] thanks! [00:59:17] (PS1) Eileen: WIP stock upgrade to 4.7.30 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/401644 [01:00:50] cwd - I asked by email so we might find out later re the vagaries of deploy [01:01:15] ok great [01:01:25] payments* do make some API calls so maybe that's why [01:01:27] (CR) jerkins-bot: [V: -1] WIP stock upgrade to 4.7.30 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/401644 (owner: Eileen) [01:01:37] but i would think it'd just use the code in the submodule [01:02:29] yeah - that didn't seem to be updated tho [01:03:00] whole other can of worms [01:11:48] :-) [01:12:02] cwd can you check a change I just did in localsettings before I push it out [01:12:10] sure [01:12:16] (irc request to check seems to be our code review for setings changes) [01:12:28] commit is a7b9b585951afea1e [01:12:31] hehe yeah... [01:12:48] i usually email jeff patch files [01:13:08] going from 1 maintainer to 2 has some growing pains :) [01:13:13] :-) [01:14:17] eileen: looks like it should be the same path cause the symlink? [01:15:04] yep [01:15:25] cwd the code compares 2 paths & concludes they are different [01:15:35] when calculating the url for js code [01:15:42] ah gotcha [01:15:44] lgtm! [01:15:56] cool - will rock & roll with it [01:18:15] !log update process-control to use different reference to civicrm_root (symlinks) process-control config revision is a7b9b58595 [01:18:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:20:22] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/401648 [01:20:47] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/401648 (owner: Eileen) [01:21:33] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/401648 (owner: Eileen) [01:26:24] !log civicrm updated civicrm revision changed from ffa9d7fc7a to 429a5c5385, config revision is a7b9b58595 [01:26:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:27:51] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog: Add formatting capabilities (?) to Details field of an Activity - https://phabricator.wikimedia.org/T183389#3870275 (Eileenmcnaughton) @CaitVirtue this was a bug to do with it not handling the symlinks in our paths correctly. I just push... [02:37:19] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog, FR-Ingenico: Ingenico audit wobble? 12/20 transactions not in Civi - https://phabricator.wikimedia.org/T183934#3867839 (Eileenmcnaughton) I took a bit of a look but I'm coming into this a bit cold - would like to talk through it with... [02:47:51] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog: Document severity of the various forms of outage - https://phabricator.wikimedia.org/T183293#3870341 (Eileenmcnaughton) I took a look & the collab page appears to have been written off the s/sheet & is mostly slightly more up to date. Th... [02:52:52] Fundraising Sprint Murphy's Lawyer, Fundraising Sprint Navel Warfare, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: increase email limit from 50 to 700 in civi - https://phabricator.wikimedia.org/T170900#3870350 (Eileenmcnaughton) [02:52:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upstream setting to control email limit - https://phabricator.wikimedia.org/T171424#3870348 (Eileenmcnaughton) Open>Resolved This has been merged upstream [03:25:39] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM: Unexpected error (phone is not an integer) when I try to merge these 2 contacts (orgs) - https://phabricator.wikimedia.org/T181572#3870360 (Eileenmcnaughton) Open>Resolved I think I altered the data blocking this earlier. error is gone [13:39:20] (PS3) Jgleeson: Restored `composer test` script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/399670 [13:53:03] (PS11) Jgleeson: DonationStats now tracking average processing times [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392425 [14:32:37] (CR) Ejegg: [C: 2] "oh man, that's some painfully old code!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/399669 (owner: Jgleeson) [14:35:54] (Merged) jenkins-bot: Removed use of deprecated "= &new" being reported by phplint on crm project. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/399669 (owner: Jgleeson) [14:51:18] (PS2) Ejegg: Fallback on NumberFormatter construct failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399884 (https://phabricator.wikimedia.org/T182737) [15:31:12] (PS3) Ejegg: Fallback on NumberFormatter construct failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399884 (https://phabricator.wikimedia.org/T182737) [15:32:42] (CR) jerkins-bot: [V: -1] Fallback on NumberFormatter construct failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399884 (https://phabricator.wikimedia.org/T182737) (owner: Ejegg) [16:06:42] (PS4) Ejegg: Fallback on NumberFormatter construct failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399884 (https://phabricator.wikimedia.org/T182737) [16:09:37] (CR) jerkins-bot: [V: -1] Fallback on NumberFormatter construct failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399884 (https://phabricator.wikimedia.org/T182737) (owner: Ejegg) [16:11:19] hi ejegg, did you catch the email I sent to Eileen (fr-tech cc'd in) about rolling back yesterdays smashpig release? [16:12:50] we had quite a lot of failmail in the hours following and with amazon showing up across most of them I thought it made sense to rollback and dig into it separately [16:13:04] Thanks jgleeson_ [16:13:37] I think it must have had to do with the proxy details... [16:13:54] let's see, maybe we can just delete that in the localsettings repo and deploy again [16:17:23] sorry, I should have done a test with Amazon right after the deploy [16:25:11] ejegg: i think there was 2 issues [16:25:28] ejegg, I need to pop out for a bit before standup. I'd be interesting in knowing how we test our integration's once they're live, so I'm more useful when situations like this arise across my timezone. Will be back in about 20 minutes o/ [16:25:29] i did see the mails about a new IP [16:25:39] interested*** [16:25:39] i thought we were using a proxy now to fix that? [16:25:58] cwd it's not live yet, their first implementation wasn't quite right [16:27:27] ah ok [16:27:37] do we need to whitelist that ip then? [16:27:40] or... wait, we just need to do a workaround [16:27:48] i almost typed shitelist [16:27:52] i'm going to use that [16:27:52] it was their SDK that didn't quite handle TCP-level proxy [16:27:54] haha [16:28:14] so we needed to either update our fork, or use hosts-file redirection [16:29:07] hosts files on the frack servers? [16:30:27] is the problem something that they should fix upstream? [16:31:19] in their SDK, yeah [16:31:46] is there a task for this? [16:34:17] https://phabricator.wikimedia.org/T180168 ? [16:34:30] Sure, that one works! [16:36:08] should we make a github issue or something? [16:44:00] good call - they're not great at engaging on github, but it'd be good practice [16:44:28] the SDK _does_ have ways to pass the params in, just no so it works with TCP proxying [16:51:54] sounds annoying [17:27:57] (Abandoned) Jgleeson: Updated stats-collector composer package to version 1.0.1 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398495 (owner: Jgleeson) [17:29:27] ejegg, this might be the quickest one to review https://gerrit.wikimedia.org/r/#/c/399670/3 I can then rebase the other patch over master once merged to fix the composer conflict prior to you reviewing https://gerrit.wikimedia.org/r/#/c/392425/11 [17:29:40] thanks, looking! [17:29:43] rebase that* [17:30:05] thanks [17:33:40] (CR) Ejegg: [C: 2] "Thanks, this looks good and works locally!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/399670 (owner: Jgleeson) [17:36:57] (Merged) jenkins-bot: Restored `composer test` script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/399670 (owner: Jgleeson) [17:52:42] Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Civi Import - https://phabricator.wikimedia.org/T172423#3872141 (jkim_wikimedia) Thank you Eileen! [18:23:52] (PS12) Jgleeson: DonationStats now tracking average processing times [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/392425 [18:24:14] ejegg, that patch conflict has been resolved ^ [18:24:43] ok, great [18:46:11] ;;seen icingawm [18:46:20] well that didn't work [18:47:07] !seen #wikimedia-fundraising icingawm [18:47:13] (PS5) Ejegg: Fallback on NumberFormatter construct failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399884 (https://phabricator.wikimedia.org/T182737) [20:08:18] (CR) Eileen: [C: 2] Fallback on NumberFormatter construct failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399884 (https://phabricator.wikimedia.org/T182737) (owner: Ejegg) [20:10:05] (Merged) jenkins-bot: Fallback on NumberFormatter construct failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/399884 (https://phabricator.wikimedia.org/T182737) (owner: Ejegg) [20:33:04] hey ejegg I started to look at that gc audit ticket & realised how woefully little I know about it - I found what I thought were the audit files but didn't find those numbers by grepping - I feel like I should be more up to speed on that area [20:33:20] hi eileen! [20:33:35] Oh & I'm glad you didn't crash to your death in a bus :-) [20:33:49] for one thing, it'd have to be a zgrep - the audit files we use now are the wx1...xml.gz files [20:33:57] yep I used that [20:34:06] oh jeez, that was a heck of a news story to wake up to... [20:34:14] where was the crash? [20:36:09] ah north of Lima [20:36:13] Pacasmayo, Peru. I went past it in a bus on the way to Trujillo, but I guess we bypassed that stretch of road [20:36:32] apparently named 'la curva del diablo' [20:36:50] hey eileen did you see my email? What do you think? [20:36:52] it was some bus line i hadn't heard of too [20:36:59] dstrine: yep saw it - looks good [20:37:06] just trying to get the citibank file now [20:37:10] ok thanks! [20:37:23] yeah let me know what you think [20:39:08] dstrine: seems good - I will start on Citibank & pull others into the sprint as I go. We also need to work on getting Civi back up to date too now BE is over. [20:39:28] I didn't see anything I felt I could help with that well but happy to if people point me to them [20:40:00] ok cool. yeah and I was just saying that those other tasks were "contenders"we could do you task first if it's more clear at the moment [20:40:21] sorry typos [20:41:06] dstrine: well the one I pointed to had a bunch of subtasks - it was just my impression from my last discussion with leannes that was her biggest pain point right now [20:41:36] ok [20:42:05] sorry - last comment - was - about the sprint - ie. if there is anything in current sprint people feel I can help with please flag it [20:43:47] back in a few... [20:48:39] fundraising-tech-ops: route incoming mail for civicrm.wikimedia.org to civi1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T184120#3872981 (Jgreen) [21:41:59] !log re-enabled ingenico audit [21:42:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:16:25] fr-tech: i gotta make an airport run, be on later! [22:49:31] (PS1) Eileen: Add Citibank International to payment instruments on new installs. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/401817 [22:50:54] (CR) jerkins-bot: [V: -1] Add Citibank International to payment instruments on new installs. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/401817 (owner: Eileen) [22:55:22] (PS2) Eileen: Add Citibank International to payment instruments on new installs. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/401817 [22:55:52] (PS3) Eileen: Add Citibank International to payment instruments on new installs. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/401817 [23:23:33] wow, refund queue consumer is SLOW [23:23:54] wonder what's taking so long [23:25:11] (PS4) Eileen: Add Citibank International to payment instruments on new installs. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/401817 [23:33:01] (PS1) Eileen: WIP Citibank import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/401819 [23:41:33] (PS6) Eileen: Allow Benevity currencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/399252 (https://phabricator.wikimedia.org/T182808) [23:41:35] (PS5) Eileen: Add Citibank International to payment instruments on new installs. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/401817 [23:41:37] (PS2) Eileen: WIP Citibank import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/401819 [23:43:04] (CR) jerkins-bot: [V: -1] Add Citibank International to payment instruments on new installs. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/401817 (owner: Eileen) [23:43:09] (CR) jerkins-bot: [V: -1] WIP Citibank import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/401819 (owner: Eileen) [23:50:57] (PS3) Eileen: WIP Citibank import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/401819