[13:34:50] morning fr-tech [13:34:57] morning mepps :) [14:53:51] how are you doing jgleeson? [14:55:13] pretty good thanks, what about you? I've had a slow few days adjusting to getting back into the swing of things but now catching up :) [14:56:11] that's good! yeah i expect some ramp up time myself [14:56:30] doing pretty well considering yesterday was a long travel day [14:56:51] james was a great travel buddy though--even after we had to hang out in the terminal for two hours because the car battery died [14:57:25] morning ejegg! [14:57:34] aww that's great. Was he watching all the goings on around him? [14:58:00] hi mepps! [14:58:16] he really wanted to play on the baggage conveyor belt but otherwise we just ran in various directions and he found a great hiding spot [14:58:31] hey ejegg, so it looks like we'll be returning to ingenico work now? [14:58:38] and jgleeson! [14:58:45] :) [14:58:57] mepps yeah, want to chat about next steps later today? [14:59:04] sounds good ejegg! [15:00:18] haha, I can see how to a little one, an airport is a world of fun... although for us adults it's not always as as playground-like [15:00:23] anything else that needs attention this morning ejegg? i'm trying to get back in the swing of things [15:00:48] just trying to clear out whatever we can from the current sprint mepps [15:00:50] yeah jgleeson the hard part was that we couldn't get too far from the bags and they were pretty cumbersome to cart around with us [15:01:18] since john was out dealing with the car, luckily my stepmother eventually came and picked us up so we could go play at her apartment [15:01:28] :) [15:01:51] is right after standup good for ppl to talk ingenico? [15:02:52] Yup! [15:07:18] good for me ejegg if you want me to pop in! [15:07:45] yes, definitely! invite sent [15:09:43] ejegg i think we should close this: https://phabricator.wikimedia.org/T172202 and set up a new task to deal with expiration and enable the job [15:10:01] also i keep forgetting today is not monday [15:10:40] hehe [15:11:54] do you think we need to do more than just change the settings of the expire_pending_messages job? [15:18:28] probably not? i mean i guess i wonder if we should add any error handling just because if i remember right it still runs through all the api calls [15:22:48] oh right! [15:23:00] yeah, the error handling is worth a ticket [15:27:38] jgleeson: oho, I think I found the problem with Amazon (after much procrastination)... [15:27:50] what was it? [15:28:42] when I added the proxy params for the IPN handler, I thought the default config I added had the same values as the defaults in the amazon SDK code [15:28:53] null for cabundle_file, for example [15:29:11] but the yaml nulls I added apparently were being read in as the empty string [15:30:49] https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/master/config/amazon/main.yaml#L30 [15:34:02] (PS1) Ejegg: YAML null: magic string instead of ~ [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402365 (https://phabricator.wikimedia.org/T180168) [15:34:18] jgleeson: ^^^ seems to fix it locally [15:37:30] interesting [15:37:55] so it doesn't like the tilde for null? [15:38:01] no, I guess not [15:38:13] trying to see if that's the php yaml parser, or our config logic [15:40:36] hmm [15:40:38] http://www.yaml.org/spec/1.2/spec.html#id2805071 [15:40:54] looks like the tilde is an alias, not sure why it wouldn't still map to null [15:41:23] (PS1) Ejegg: Add missing action to Amazon config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402368 (https://phabricator.wikimedia.org/T183429) [15:46:43] ejegg, to test that fix locally are you running an integration test or do you use something like a script to simulate a payment message by the merchant? [15:51:55] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, and 12 others: Create orphan rectifier for PayPal Express Checkout - https://phabricator.wikimedia.org/T172202#3878495 (mepps) Open>Resolved [15:52:18] Fundraising-Backlog: Handle timeout in PaypalEC Orphan Rectifier and enable job - https://phabricator.wikimedia.org/T184284#3878497 (mepps) [15:53:38] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, and 6 others: adyen cookie error after entering information on mobile Safari - https://phabricator.wikimedia.org/T176913#3878506 (mepps) @d... [15:55:31] jgleeson: there's a 'manual' folder in PaymentProviders/Amazon/Tests [15:55:51] it takes a little config to make it work [15:56:04] ...I should add that to the apache config for vagrant! [16:16:03] jgleeson man, I'm a bit confused. I can't seem to reproduce the empty strings now [16:16:17] -_- [16:16:32] It definitely gave empty strings instead of nulls when I first debugged through it [16:16:47] and that would explain the behavior on prod [16:17:05] but now when i swap back to tildes I still get nulls as expected [16:17:15] that is odd [16:17:40] tried checking out the version of the file at the point it was erroring? [16:18:08] maybe there was some crazy spacing/formatting breaking things [16:19:00] yeah, I've got deployment checked out, with the Amazon tests added back in [16:21:15] Fundraising-Backlog: Handle timeout in PaypalEC Orphan Rectifier and enable job - https://phabricator.wikimedia.org/T184284#3878551 (mepps) a:mepps [16:22:11] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, and 5 others: Adyen jobs should retry at least once on connect failure - https://phabricator.wikimedia.org/T177893#3878554 (mepps) @ejegg did we... [16:23:19] jgleeson: ahhhh, it's an issue with the SDK! [16:23:30] :O [16:23:32] THEY're turning nulls into empty strings [16:23:39] uh oh [16:24:25] can you work around it at your implementation layer or will you have to fork/patch the SDK [16:24:47] we're already using a fork :S [16:24:53] :) [16:25:10] I've been trying hard to upstream our bits to re-use the message logic to communicate with their reporting server [16:25:31] but they're really reluctant to even merge my preliminary whitespace-fixing patch [16:26:20] ah jeez [16:26:28] :P [16:33:57] (PS1) Ejegg: Update Amazon SDK fork for array trim fix [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402378 [16:34:16] (PS2) Ejegg: Add missing action to Amazon config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402368 (https://phabricator.wikimedia.org/T183429) [16:34:34] (Abandoned) Ejegg: YAML null: magic string instead of ~ [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402365 (https://phabricator.wikimedia.org/T180168) (owner: Ejegg) [16:35:53] at this point I kind of feel like just copying their code into SmashPig and using their github issues page to try to get all the frustrated would-be contributors to switch over [16:38:50] jgleeson: here's the fix in the fork: https://github.com/ejegg/login-and-pay-with-amazon-sdk-php/commit/3349385d31f214fc2d2b7f68af289a957458559c [16:39:08] and we also need this one for the auth retries: https://gerrit.wikimedia.org/r/402368 [16:43:33] looks good! [17:03:43] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, and 5 others: Adyen jobs should retry at least once on connect failure - https://phabricator.wikimedia.org/T177893#3878617 (Ejegg) We tried Tuesd... [17:05:38] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, and 5 others: Adyen jobs should retry at least once on connect failure - https://phabricator.wikimedia.org/T177893#3878622 (Ejegg) Also, do you t... [17:17:59] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Update Ingenico hosted style to match new payments form CSS - https://phabricator.wikimedia.org/T184288#3878650 (Ejegg) [17:18:17] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Update Ingenico hosted style to match new payments form CSS - https://phabricator.wikimedia.org/T184288#3878659 (Ejegg) p:Triage>Normal [17:22:39] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: Support 3d Secure transactions - https://phabricator.wikimedia.org/T176512#3878675 (Ejegg) https://epayments.developer-ingenico.com/support/faq/is-it-possible-to-leave-3ds-on-only-where-it-s-mandatory-with-exception-to-a-few-countries [17:26:02] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: if we need 3rd-party cookies in their iframe, implement same thing as we have with Adyen - https://phabricator.wikimedia.org/T184289#3878696 (Ejegg) [17:27:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding additional details to a current Custom Field - Benefactor Page Listing - https://phabricator.wikimedia.org/T141489#3878707 (Aklapper) a:RLewis>None Resetting assignee to default as RLewis is not with WMF anymore. [17:29:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding additional details to a current Custom Field - Benefactor Page Listing - https://phabricator.wikimedia.org/T141489#3878717 (DStrine) a:RLewis [17:29:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding additional details to a current Custom Field - Benefactor Page Listing - https://phabricator.wikimedia.org/T141489#2500371 (DStrine) @Aklapper she is. She's just on leave for a bit. She should return shortly. [17:30:13] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: if we need 3rd-party cookies in their iframe, implement same thing as we have with Adyen - https://phabricator.wikimedia.org/T184289#3878720 (Ejegg) p:Triage>Normal [18:54:07] hi XenoRyet, how ya feeling? [18:54:34] ejegg: On the mend, for sure. [18:56:44] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: order id suffix incremented between pending and donations queues - https://phabricator.wikimedia.org/T184291#3878851 (Ejegg) [19:06:26] Fundraising-Backlog, FR-Ingenico, Fr-Ingenico-integration_2017-18, Spike: Spike: investigate new integration for ingenico to prevent order ID issues - https://phabricator.wikimedia.org/T136976#3878877 (Ejegg) Open>Resolved [19:49:36] Fundraising-Backlog, FR-Adyen, FR-Smashpig: Adyen capture failure - https://phabricator.wikimedia.org/T184200#3875720 (mepps) @ejegg have you looked at the backtrace? Are there any errors before this happens? [19:53:45] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, and 6 others: adyen cookie error after entering information on mobile Safari - https://phabricator.wikimedia.org/T176913#3878993 (DStrine)... [20:04:36] (PS1) Jgleeson: WIP got a working version of donations_count with labels but have moved overall to separate call at end and still having problems with accessing donations.count namespace indivdually during export [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/402423 [20:06:04] (CR) jerkins-bot: [V: -1] WIP got a working version of donations_count with labels but have moved overall to separate call at end and still having problems with accessing donations.count namespace indivdually during export [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/402423 (owner: Jgleeson) [20:09:27] fr-tech, I am calling it a night. I still have some work left on the Prometheus labels overall patch which I'll have to finish off on Monday now before moving on to Ingenico as discussed. I've pushed my work so far in https://gerrit.wikimedia.org/r/402423 but it's a WIP for now as the changes have broke some tests and selecting compound stats with labels to export is proving a challenge, one for next week :). [20:09:27] Have a great weekend all! [20:09:40] Catch you later [20:10:55] have a good one jgleeson [20:12:17] XenoRyet: we had a meeting about the remaining ingenico connect work [20:12:49] and decided we should each make sure we've got it working locally, [20:12:59] then make test donations and try to get them all the way into Civi [20:13:13] Good times. Sounds like a plan. [20:13:26] Had you gotten into that integration at all? [20:13:42] I don't think so. Not from what I remember anyway. [20:13:54] How much of it is merged? [20:14:07] all the stuff written to date is merged [20:14:25] then there's this vagrant patch to enable it and add some test links: [20:14:34] https://gerrit.wikimedia.org/r/402404 [20:14:36] Cool. [20:14:49] I'll start with that and see if I can get everything to run locally. [20:14:54] Thanks! [20:15:22] I'm on cafe wifi so vagrant rebuilds aren't so feasable just now [20:16:01] I know how that goes. I'm on plenty fast internet though, so I can beat vagrant into submission. [20:16:08] thanks again [20:17:07] cwd randall's take on the bugs is up: https://xkcd.com/ [20:18:51] hey ejegg, did we adjust the settings for adyen with curl/retries? [20:19:25] mepps oh drat, I didn't do any settings adjustments with that deploy [20:19:37] sorry, that whole thing was rushed :( [20:19:44] what do we need to add? [20:19:44] well, there probably should be a default value in the codebase [20:20:12] Ah, there is something in config/provider-defaults.yaml [20:20:18] oh? [20:20:20] hmm [20:20:39] all of the ProviderConfiguration yamls inherit from that [20:57:07] ejegg: awesome