[14:08:43] hello fr-tech! [15:15:58] hello jgleeson! [15:16:04] and ejegg! [15:16:06] hey mepps :) [15:16:09] & ejegg [15:16:14] how was your weekend jgleeson? [15:16:19] Hi mepps and jgleeson ! [15:16:42] ah it was a run of the mill family visit weekend for us :) [15:16:58] took Oscar swimming this morning though which was good [15:17:03] how about yours? [15:17:50] oooh fun! my weekend wasn't bad aside from james having a little trouble adjusting to the timezone change [15:20:38] ah, are you on pacific time now? [15:28:10] no we were on pacific time over the holiday [15:28:13] it was easier going that way [15:29:12] ah [15:29:40] I'm guessing I'll be a lot like james when I make the trip over for all hands [15:30:32] I struggle to sleep on planes so I'll be pretty jet lagged for the first day or two [15:31:10] yeah that's quite the time change [15:31:25] are you bringing your family jgleeson? [15:31:53] no just me, I wanted to but wasn't sure how much it would cost for us all and we weren't too sure on Oscar with such a long flight [15:32:08] in total it's about 13 hours with a connecting flight [15:32:10] yeah that is far [15:32:16] we're bringing james but i'm a little nervous [15:38:22] what's the travel time from where you are now, to the all-hands location? [15:39:32] 6 hours direct there but we had to get a connecting flight to go back [15:43:23] ah [15:45:51] we bought Oscar an amazon fire tablet during the sales for £30 and that kept him occupied enough before he fell asleep during a 4 hour flight he was on last year. He was watching mickey mouse and some other cartoons, with the adding benefit of it being available to download and watch offline on the device [15:46:37] added* [16:07:08] both flights are at night so i'm hoping to get james to sleep [16:07:38] internet in the apt is pretty bad today, relocating [16:44:07] Fundraising-Backlog: Clean up obsolete settings in /etc/fundraising and localsettings repo - https://phabricator.wikimedia.org/T184454#3883346 (Ejegg) [17:02:56] Fundraising-Backlog: Upgrade PaymentsWiki to Mediawiki 1.31 (new LTS) - https://phabricator.wikimedia.org/T184460#3883486 (Ejegg) [17:03:37] (CR) Ejegg: [C: 2] Update Amazon SDK fork for array trim fix [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402378 (owner: Ejegg) [17:03:49] (CR) Ejegg: [C: 2] Add missing action to Amazon config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402368 (https://phabricator.wikimedia.org/T183429) (owner: Ejegg) [17:04:57] mepps: once those merge I'm going to try to deploy the smashpig updates again, including your Adyen retry bit [17:05:03] (Merged) jenkins-bot: Update Amazon SDK fork for array trim fix [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402378 (owner: Ejegg) [17:05:05] (Merged) jenkins-bot: Add missing action to Amazon config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402368 (https://phabricator.wikimedia.org/T183429) (owner: Ejegg) [17:05:12] or do you want me to hold off based on your investigations? [17:05:30] ejegg i'm confused--i thought we believed the errors were due to adyen retry bits already being deployed? [17:05:50] ejegg i've been stumped so far [17:14:17] mepps we rolled back last week's deploy, including the adyen retry bits [17:14:42] ah okay ejegg, yeah i can't tell from the code why that error would occur [17:14:57] do you want to add any logging or anything before we deploy again? [17:15:55] hmm good idea ejegg [17:21:00] (PS1) Mepps: Add logging for debugging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402870 (https://phabricator.wikimedia.org/T177893) [17:21:07] (CR) jerkins-bot: [V: -1] Add logging for debugging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402870 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [17:22:54] (PS2) Mepps: Add logging for debugging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402870 (https://phabricator.wikimedia.org/T177893) [17:28:51] ejegg ^^ [17:29:37] looking [17:31:22] (CR) Ejegg: [C: -1] "Might need a print_r, not sure about the count field" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402870 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [17:38:28] (PS3) Mepps: Add logging for debugging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402870 (https://phabricator.wikimedia.org/T177893) [17:39:46] (CR) Mepps: Add logging for debugging (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402870 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [17:40:58] fr-tech I am relocating back home, be back shortly [17:42:28] (CR) Ejegg: [C: -1] "Sorry, still need to use the Logger. Also looks like a 'return' and some spaces got lost." (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402870 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [18:15:52] fr-tech i may be a bit distracted after 2:30 today, with the wintry mix coming schools are closing and i'm sending the nanny home early to avoid the bad weather [18:19:45] safe driving! [18:22:42] (PS4) Mepps: Add logging for debugging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402870 (https://phabricator.wikimedia.org/T177893) [18:28:30] (PS5) Mepps: Add logging for debugging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402870 (https://phabricator.wikimedia.org/T177893) [18:43:15] (CR) Ejegg: [C: -1] "Misused exception parameter, whitespace issues" (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402870 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [18:45:14] (PS6) Mepps: Add logging for debugging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402870 (https://phabricator.wikimedia.org/T177893) [18:50:38] (CR) Ejegg: [C: 2] Add logging for debugging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402870 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [18:51:43] (Merged) jenkins-bot: Add logging for debugging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402870 (https://phabricator.wikimedia.org/T177893) (owner: Mepps) [18:55:08] (PS1) Ejegg: Update Amazon SDK [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/402889 [18:55:26] (CR) Ejegg: [C: 2] Update Amazon SDK [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/402889 (owner: Ejegg) [18:55:51] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/402890 [18:55:57] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/402890 (owner: Ejegg) [18:56:30] (CR) Ejegg: [V: 2 C: 2] Update Amazon SDK [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/402889 (owner: Ejegg) [18:56:50] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/402890 (owner: Ejegg) [18:57:11] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/402890 (owner: Ejegg) [18:57:37] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/402890 (owner: Ejegg) [18:58:27] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/402890 (owner: Ejegg) [19:02:49] ok mepps, about to deploy that [19:02:56] great ejegg [19:04:52] !log updated SmashPig payments listener from 45aa62650c to 0e703f502d [19:05:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:18:31] Cool, looks like Amazon IPN messages are getting through fine [19:50:04] (CR) Ejegg: [C: -1] "Mostly looks good, just found a couple issues so far. Still checking it out!" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [19:54:18] (CR) Ejegg: [C: -1] "Ah, just noticed the retrieveValue function added in upstream core." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [20:00:09] mepps are you looking at those adyen failmails? [20:00:20] Think we should roll back? [20:01:54] mepps oho! we're not actually returning $resp from the capture function [20:02:01] (PS1) Umherirrender: Improve some parameter docs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/402900 [20:03:44] err, false alarm [20:05:07] mepps so you think the retries value is somehow wrong? [20:05:51] ok, I'm going to roll back for now, and try stepping through this locally [20:07:19] whey it’s the only thing that seems like it could be wrong [20:09:01] !log rolled back smashpig payments listener from 0e703f502d to 45aa62650c [20:09:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:19:53] mepps yeah, it looks like retries is null [20:20:03] still trying to figure out why [20:26:50] (PS6) Eileen: Add extension to change contact types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) [20:28:41] mepps ooh, is it the old-school constructor-with-the-same-name-as-the-class issue? [20:28:43] (CR) jerkins-bot: [V: -1] Add extension to change contact types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [20:28:49] doesn't seem to fire for me locally? [20:30:05] hmm that is odd ejegg, and what do you mean doesn't fire? [20:30:31] I set a breakpoint inside the 'Payment' function (which should be the constructor, I think) [20:30:35] and it never gets hit [20:30:55] even though the call to new WSDL\Payment definitely does [20:31:06] oh hey, meeting [20:31:15] ahh ejegg that would make sense [20:31:34] so it just uses the inherited construct function [20:31:40] I guess so [20:31:55] (PS1) Eileen: CRM-16819 improve on CRM_Utils_Request::retrieve [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/402905 [20:34:57] Fundraising-Backlog: Clean up obsolete settings in /etc/fundraising and localsettings repo - https://phabricator.wikimedia.org/T184454#3884226 (DStrine) [20:35:54] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: order id suffix incremented between pending and donations queues - https://phabricator.wikimedia.org/T184291#3878851 (DStrine) [20:37:52] (CR) Eileen: "Ah yeah totally - I must have tested on master not our branch - here is the upstream change... https://gerrit.wikimedia.org/r/#/c/402905/" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [20:38:40] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Skope: Ingenico Connect: if we need 3rd-party cookies in their iframe, implement same thing as we have with Adyen - https://phabricator.wikimedia.org/T184289#3884235 (DStrine) [20:46:00] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog, FR-Adyen, FR-Smashpig: Adyen capture failure - https://phabricator.wikimedia.org/T184200#3884255 (DStrine) [20:46:19] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog, FR-Adyen, FR-Smashpig, Unplanned-Sprint-Work: Adyen capture failure - https://phabricator.wikimedia.org/T184200#3875720 (DStrine) [21:13:04] (PS1) Mepps: Use newer construct function [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402931 (https://phabricator.wikimedia.org/T184200) [21:14:07] (CR) jerkins-bot: [V: -1] Use newer construct function [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402931 (https://phabricator.wikimedia.org/T184200) (owner: Mepps) [21:15:29] (PS2) Mepps: Use newer construct function [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/402931 (https://phabricator.wikimedia.org/T184200) [21:23:23] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/401817 (owner: Eileen) [21:24:05] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [21:32:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Civi credential for new fundraising contractor, Peter - https://phabricator.wikimedia.org/T183207#3884407 (LeanneS) Peter now has a WMF email address. Could we get the process in motion for his Civi login? I've just forwarded t... [21:35:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Override "Thank you already sent" notice when resending thank yous - https://phabricator.wikimedia.org/T28408#3884410 (Eileenmcnaughton) Open>declined I'm ditching this - open since 2010 & I don't know I understand it or that any of the people i... [21:38:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Civi credential for new fundraising contractor, Peter - https://phabricator.wikimedia.org/T183207#3884417 (Eileenmcnaughton) I've created a Civi account. Still pending cert from @cwdent - I used Engage role in civi - let me kno... [21:49:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Civi credential for new fundraising contractor, Peter - https://phabricator.wikimedia.org/T183207#3884479 (cwdent) ---------- Forwarded message ---------- From: Lisa Gruwell Date: Mon, Jan 8, 2018 at 12... [21:51:21] so Eileen I'm cool with you starting on any task from that email last week T179882 , T152048 , T182251 , T179118 [21:51:22] T179118: Can't link to a contact with no name in dedupe screen - https://phabricator.wikimedia.org/T179118 [21:51:23] T182251: Possibility to create bad query from dedupe by fishing net rule - https://phabricator.wikimedia.org/T182251 [21:51:23] T179882: improve MG mailing process - https://phabricator.wikimedia.org/T179882 [21:51:23] T152048: Search for email only works if primary email address - https://phabricator.wikimedia.org/T152048 [21:52:58] jumping off for tonight, have a good one fr-tech! [21:53:56] eileen: actually scratch that. We just got info for the new MG person via email [22:18:03] dstrine: thanks - will do a couple of easy ones first I think. Citibank needs some input from MG now so might stall until they get the next file [22:28:05] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Civi credential for new fundraising contractor, Peter - https://phabricator.wikimedia.org/T183207#3884566 (Eileenmcnaughton) [22:28:57] ok cool [22:36:02] https://security-tracker.debian.org/tracker/source-package/php5 [23:07:07] cwd: have y'all updated to running HHVM yet? Not sure if you watch such things, but MediaWiki is trying to get to a PHP7/HHVM only min version for the 1.31 release (our next LTS, current master) [23:07:44] the last 2 blockers for that on the main cluster are wikitech and dumps and both are being worked on this quarter [23:07:53] bd808: i heard rumblings of that, we are still zend 5.x af [23:08:08] but we are also running... 1.27 i believe [23:08:42] *nod* that's the current LTS [23:09:12] moving from 5.x to 7.x 'should' be easy when the time comes [23:09:15] do you have an EOL date for that one? [23:09:32] June 2019 [23:09:38] https://www.mediawiki.org/wiki/Version_lifecycle [23:09:38] groovy [23:09:40] thanks [23:10:06] i think our mediawiki instances should be easy to migrate to 7 yeah [23:10:08] in theory you'll have a year of overlap for testing [23:10:13] since we use approximately zero of the features [23:10:33] some of the other projects (civicrm) strike me as...less easy [23:10:51] eileen: do you know of anyone running civicrm on php7? [23:12:04] cwd yep [23:12:28] not that it'd be impossible to have both versions but i'd love to not [23:12:59] I'm pretty comfortable with civi on php7 [23:13:07] i think that's what I run locally even [23:13:10] great to hear [23:13:25] 7.1 there are a couple of issues but I think it would be OK too