[00:42:29] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Civi credential for new fundraising contractor, Peter - https://phabricator.wikimedia.org/T183207#3888668 (LeanneS) Thanks! [00:53:18] (PS8) Eileen: Add extension to change contact types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) [01:36:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Performance: CiviCRM queries become slower over time, require manual "flushing" - https://phabricator.wikimedia.org/T87032#3888724 (Eileenmcnaughton) I'm going to decline this cos it's really old & not 'user facing' & no longer seems to be affecting us [01:36:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Performance: CiviCRM queries become slower over time, require manual "flushing" - https://phabricator.wikimedia.org/T87032#3888725 (Eileenmcnaughton) Open>declined [03:34:43] (CR) Ejegg: [C: -1] "Think there's a little problem with the missing details validation, and the 'generic' relationship cache seems to duplicate the cache for " (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [03:37:40] (CR) Ejegg: [C: -1] Add extension to change contact types (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [03:53:33] (CR) Ejegg: [C: -1] Add extension to change contact types (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [06:07:59] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: MW-Vagrant CRM role needs maintenance - https://phabricator.wikimedia.org/T110372#3888938 (bd808) [14:26:52] morning fr-tech! [14:27:00] morning mepps :) [14:38:13] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-log-errors: Do not fatal if banner name does not exist - display an error message instead - https://phabricator.wikimedia.org/T184565#3889834 (Pcoombe) [14:38:16] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-log-errors: Don't serve an exception on Special:CentralNoticeBanners when the banner doesn't exist - https://phabricator.wikimedia.org/T149240#3889837 (Pcoombe) [15:24:52] mepps jgleeson fr-tech helloz :) [15:25:05] hello AndyRussG! [15:25:19] hellllllllllllooo AndyRussG :) [15:25:19] i just noticed i've overcaffienated [15:25:25] but i still want more coffee... [15:25:49] pretty common that issue amongst developers I'd bet [15:26:09] on that note, soup & coffee time [15:27:18] :) [15:30:46] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Quit giving non-JS donors the runaround - https://phabricator.wikimedia.org/T184536#3887037 (Pcoombe) Donatewiki does require javascript now, and it would be tricky to make it work without (and pointless if paymentswiki requires it). We could... [15:49:58] mepps: that's my life!!! [15:50:05] also hello everyone [15:50:12] hey dstrine! how are you feeling? [15:50:17] 75% [15:50:34] I'm taking all the teas and ariborn and what not [15:52:19] I just picked up a stray dog on my walk with Jasper. He's healthy but has no tags. I'm going to have to log off at some point in the morning and take him to the SPCA [15:53:08] aww [15:53:45] he's chihuahua sized but I'm not sure of breed. [15:54:42] Jasper's version of heaven is a tiny dog pushing him around and chasing him forever. So this morning is working out well for him [15:55:48] that's the cutest thing ever [15:56:11] yeah [16:40:23] (PS3) Jgleeson: T183275 WIP. Added new implementation (alongside existing for review purposes) of DonationStatsCollector (vs DonationStats) utilising inheritance over composition to avoid dependency on proxy methods and visibility juggling for testing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/403305 [16:41:08] (CR) Mepps: [C: 1] "This looks pretty good to me. I'm not sure if you want to wait for upstream review and ejegg may want to take a look." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/403098 (owner: Eileen) [16:42:24] fr-tech, following on from yesterdays frustration with my flaky DonationStats class, I have rewritten it to make the implementation more straightforward to following and easier to test. For now and in anticipation of discussion to contrast approaches, I have left the previous implementation in the branch https://gerrit.wikimedia.org/r/403305 [16:42:38] to follow* [16:43:56] the contrast is really between two files, DonationStatsCollector.php and DonationStats.php with the former being the newest [16:44:23] even though that sounds oxymoronish :) [16:46:09] (CR) jerkins-bot: [V: -1] T183275 WIP. Added new implementation (alongside existing for review purposes) of DonationStatsCollector (vs DonationStats) utilising inheritance over composition to avoid dependency on proxy methods and visibility juggling for testing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/403305 (owner: Jgleeson) [16:46:41] CI will fail btw, as the tests need to be ported once I'm confident this is the way to go [17:00:15] fr-tech I'm trying to support TCP proxy in the Amazon SDK fork: https://github.com/ejegg/login-and-pay-with-amazon-sdk-php/tree/tcpProxy [17:00:19] still need to test [17:00:35] based on this suggestion from Amazon: https://gist.github.com/islandskater43/0a518043f8f2f530a344866cdd9d17bf [17:00:57] not sure what that setopt(HEADER, false) was doing for us in the POST fn [17:06:57] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, and 2 others: CentralNotice: Consolidate typical analytics queries (for example, for impression r... - https://phabricator.wikimedia.org/T178930#3890421 [17:18:36] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Civi credential for new fundraising contractor, Peter - https://phabricator.wikimedia.org/T183207#3890511 (cwdent) Open>Resolved a:cwdent I see the account has logge... [17:20:43] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog, FR-Ingenico: Ingenico audit wobble? 12/20 transactions not in Civi - https://phabricator.wikimedia.org/T183934#3890544 (Ejegg) Open>Resolved a:Ejegg [17:22:31] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, and 5 others: Amazon code should allow specifiying proxy parameters in configuration - https://phabricator.wikimedia.org/T180168#3890553 (Ejegg) We need to en... [18:09:08] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, and 2 others: CentralNotice: Consolidate typical analytics queries (for example, for impression r... - https://phabricator.wikimedia.org/T178930#3890685 [18:17:01] https://www.macrumors.com/2018/01/10/macos-high-sierra-app-store-password-bug/ [18:26:52] update! the puppy's owner was on next door. I found out his name is Tiny. he was stolen from someone on their walk and the thief must have just left him in the neighborhood. Really sad. Someone is going to pick him up soon [18:28:18] cwd: that's a crazy bug [18:34:47] aww not cool dstrine. At least he's soon to be reunited with his owner [18:45:16] yeah the guy just stopped by and picked up Tiny. All is well now [18:45:26] Good to hear [18:54:53] fr-tech if you're on Ubuntu 16.04, watch out for the spectre/meltdown kernel updates! [18:55:14] milimetric passed along a warning that they're bricking some laptops [18:59:14] brutal [19:03:13] sounds like the cure is worse than the ailment [19:10:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: create a dashlet for dedupe script stats - https://phabricator.wikimedia.org/T146229#3890935 (DStrine) Open>declined [19:12:02] Fundraising-Backlog, FR-Email: Can we A/B test the TY email & get access to TY email stats? - https://phabricator.wikimedia.org/T166135#3890938 (DStrine) [19:14:03] woah ejegg|food [19:14:52] that reminds me, I really need to sort out an external backup drive [19:15:02] I have one, but it's bricked [19:15:07] so gonna get another [19:16:55] ok, reading further it looks like 'brick' is wrong [19:17:18] the don't boot, but you can still boot the previous kernel [19:17:57] things are not looking good for computers in 2018 [19:19:13] jgleeson: i have one of these, pretty happy with it https://www.amazon.com/Monoprice-Button-Tray-RAID-Enclosure/dp/B00H8Z215W/ref=sr_1_3?ie=UTF8&qid=1515611885&sr=8-3&keywords=monoprice+raid [19:19:29] it has a loud fan that never turns off though [19:19:44] so i only fire it up to do backups or recover [19:20:10] my original plan was to use it as a NAS but it's too annoying [19:21:05] ejegg|food, getting caught up in that os syrup with things to finish is equally as unattractive [19:21:22] so think I'll hold off, thanks for the heads up [19:23:57] cwd, that looks pretty neat [19:24:11] what RAID config do you use? [19:24:47] Fundraising-Backlog: Generate of list of CN admins active in the last 12 months - https://phabricator.wikimedia.org/T136050#3890959 (DStrine) Open>Invalid [19:25:04] raid1 [19:25:14] and hot glue over the self destruct switch [19:28:09] self-destruct??? [19:30:03] it has a little switch to change the raid mode [19:30:13] which would nuke your data [19:30:20] antifeature [19:31:11] heh, got it [19:31:32] does look like the same kind of switch that changes input voltage on a PS [19:31:40] and i've never flipped that by accident [19:31:43] hehe yep [19:33:32] one time at formerjob we're in a meeting and my boss plugged a POE cable into his laptop and it started smoking [19:33:39] and we laughed and laughed [19:34:54] damm [19:37:09] Fundraising-Backlog, FR-Ingenico, Fr-backlog-cleanup-Q3_2017-18: TY page in ingenico iframe - https://phabricator.wikimedia.org/T176669#3890996 (DStrine) [19:37:39] Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18, MediaWiki-extensions-CentralNotice: Geoip lookup - Misidentifying country due to travelling - https://phabricator.wikimedia.org/T175691#3890999 (DStrine) [19:38:04] Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18, MediaWiki-extensions-CentralNotice: Discussion: Identify rogue banner impressions to logged in user - https://phabricator.wikimedia.org/T175690#3891000 (DStrine) [19:38:21] https://security-tracker.debian.org/tracker/source-package/linux [19:38:59] Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18, MediaWiki-extensions-CentralNotice, Wikimedia-CentralNotice-Administration: Tracking Task: Banners immediately returning after being dismissed. - https://phabricator.wikimedia.org/T164099#3891005 (DStrine) [19:39:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: Help Civi users configure their dashboards - https://phabricator.wikimedia.org/T118345#3891006 (DStrine) [19:40:07] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 8 others: [Epic] Support Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#3891008 (DStrine) [19:40:19] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Fr-backlog-cleanup-Q3_2017-18, Epic: Paypal Express checkout campaign ready - https://phabricator.wikimedia.org/T131817#3891009 (DStrine) [19:40:41] Fundraising-Backlog, FR-PayPal-ExpressCheckout, Fr-backlog-cleanup-Q3_2017-18, Epic: Epic: Distinguish PayPal legacy vs. Express Checkout transactions - https://phabricator.wikimedia.org/T138013#3891010 (DStrine) [19:40:55] Fundraising-Backlog, FR-Adyen, Fr-backlog-cleanup-Q3_2017-18, MediaWiki-extensions-DonationInterface: Make Adyen default gateway for Ukraine - https://phabricator.wikimedia.org/T140086#3891011 (DStrine) [19:41:19] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 8 others: CentralNotice: Slurp up existing wild cookies and copy them to LocalStorage or del... - https://phabricator.wikimedia.org/T132640#3891014 [19:41:29] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, and 5 others: CentralNotice: finalize list of wild useless cookies for slurp, and push config change - https://phabricator.wikimedia.org/T135090#3891015 (D... [19:42:33] fr-tech OWASP top 10 vulnerabilities talk happening now: https://www.youtube.com/watch?v=wf1SfipLLzE [19:42:43] Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18, MediaWiki-extensions-CentralNotice, Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#3891018 (DStrine) [19:43:04] Fundraising-Backlog, FR-Amazon, Fr-backlog-cleanup-Q3_2017-18: Amazon interstitial page - https://phabricator.wikimedia.org/T121698#3891020 (DStrine) [19:43:20] Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18: UKFC Payment investigation - https://phabricator.wikimedia.org/T125887#3891022 (DStrine) [19:43:22] (CR) Jforrester: [C: 1] Use findItemFromData instead getItemFromData [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/400467 (https://phabricator.wikimedia.org/T76630) (owner: Prtksxna) [19:43:40] ejegg: I'm sorry - looks like that contacteditor was less review ready than I thought - seems I might have gotten distracted rather than doing the last part! [19:43:47] Fundraising-Backlog, FR-Adyen, Fr-backlog-cleanup-Q3_2017-18: Updates to Adyen form so that it matches Ingenico - https://phabricator.wikimedia.org/T128541#3891026 (DStrine) [19:44:03] heh, no worries [19:44:09] Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18: Recent up tick in fail mail - https://phabricator.wikimedia.org/T126482#3891027 (DStrine) [19:44:28] Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18, MediaWiki-extensions-CentralNotice: CentralNotice: Use only one cookie library - https://phabricator.wikimedia.org/T133434#3891029 (DStrine) [19:44:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: CiviCRM SQL is out of sync with code version - https://phabricator.wikimedia.org/T132057#3891030 (DStrine) [19:45:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: Improve security of UKFC data transfers - https://phabricator.wikimedia.org/T124315#3891032 (DStrine) [19:45:29] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: [Please rename me] UI Sillyness: The boxes don't fit in the other boxes the right way - https://phabricator.wikimedia.org/T117614#3891033 (DStrine) [19:45:55] Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico, Fr-backlog-cleanup-Q3_2017-18: Ingenico Ukrainian credit card iframe should fall back to English instead of Russian - https://phabricator.wikimedia.org/T118734#3891034 (DStrine) [19:52:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM: Simple Way to convert an Individual record into an Org record - https://phabricator.wikimedia.org/T120014#3891067 (DStrine) Open>Resolved a:DStrine We are doing the work for this on this task T156193 I'm closing this one as a dupe. [20:10:55] eileen1: is the Civi-core CI always this flakey? I seem to get different failures everytime I ask jenkins to re-run [20:10:59] none of them related to my work [20:17:14] ejegg: there has been an issue last few days [20:17:27] ah, ok [20:17:27] seems to be losing server connection [20:17:40] i do finally have the unit tests running locally with backdrop [20:18:05] so I'll just make sure my stuff's OK there for now [20:18:24] I think those tests will pass fine once the upstream issue is sorted [20:18:41] but I think I need to try to trade some upstream review to get some things merged [20:20:34] yeah, I should do some of that too [20:20:57] any particular devs I should look at? [20:21:17] Well, I guess the ones that have already been looking at my patches, if they have anything [20:21:40] :-) [20:21:52] Well I think coleman & seamus looked at yours? [20:22:07] seamus is with the Australian Green party & Coleman is core [20:22:15] yep [20:24:11] I just looked at seamus's & hit this https://github.com/civicrm/civicrm-core/pull/11447 [20:24:25] Looking at that one right now! [20:24:39] though it seems you've already commented [20:25:13] yeah - by my criteria a unit test that passes is good to go [20:26:01] monishdeb, jitendra & mattwire are also fairly engaged with review [20:37:05] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: add token for address without extra lines - https://phabricator.wikimedia.org/T184647#3891206 (Eileenmcnaughton) [20:51:29] (PS9) Eileen: Add extension to change contact types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) [20:57:59] (CR) Ejegg: "Nice re-use and standardization! One nitpick. Also, is the contact_type stuff here still in progress?" (3 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/403098 (owner: Eileen) [20:58:11] looking at PS9 eileen [20:58:51] ps9? [20:59:09] of the contact type extn [21:01:28] oh right patch set 9 [21:01:38] I'm not sure I've address all your points yet [21:01:44] ok, the details logged in the activity look good now. [21:01:50] just the obvious one of things not doing what they say they should! [21:02:23] ah yeah, still blocking when a relationship exists that's valid for all contact types [21:02:35] (not that any of those exist in a default install) [21:03:54] ah ok - yeah I'll check that then [21:04:03] (CR) Eileen: CRM-21634 Stdise search fields as they relate to contacts (2 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/403098 (owner: Eileen) [21:07:11] (PS2) Eileen: CRM-21634 Stdise search fields as they relate to contacts [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/403098 [21:07:21] ejegg: I just fixed that tpl - contact type field was wrongly nested [21:07:35] ah, got it [21:22:03] Fundraising-Backlog, FR-Ingenico, Fr-backlog-cleanup-Q3_2017-18, FR-Email: Spike: Stop spamming donors who have pending donations - https://phabricator.wikimedia.org/T162476#3891369 (DStrine) [21:22:50] Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18: Spike: investigate odd safari behaviors - https://phabricator.wikimedia.org/T150792#3891373 (DStrine) [21:23:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] new round of common dedupe conflicts - https://phabricator.wikimedia.org/T153019#3891377 (DStrine) Open>Resolved [21:23:49] Fundraising-Backlog, FR-Adyen, Fr-backlog-cleanup-Q3_2017-18, MediaWiki-extensions-DonationInterface: Orphan rectifier for Adyen - https://phabricator.wikimedia.org/T145708#3891378 (DStrine) [21:24:03] Fundraising-Backlog, FR-Astropay, Fr-backlog-cleanup-Q3_2017-18, MediaWiki-extensions-DonationInterface, Epic: [EPIC] Rename AstroPay to dLocal - https://phabricator.wikimedia.org/T144835#3891382 (DStrine) [21:24:22] Fundraising-Backlog, FR-Ingenico, Fr-backlog-cleanup-Q3_2017-18: Switching card types causes "No processors available" message on donation form - https://phabricator.wikimedia.org/T144870#3891383 (DStrine) [21:25:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: Add "mobile" to list of phone type options on a contact record - https://phabricator.wikimedia.org/T89017#3891384 (DStrine) [21:25:16] Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18: Weird CIVI result for FIND CONTRIB - https://phabricator.wikimedia.org/T130965#3891385 (DStrine) [21:25:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, Fr-backlog-cleanup-Q3_2017-18, and 2 others: [Epic] Rename GlobalCollect to Ingenico in code - https://phabricator.wikimedia.org/T122420#3891386 (DStrine) [21:25:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico, FR-Smashpig, and 2 others: Rename all references to GlobalCollect in code, to Ingenico. Determine if we need to update old database entries - https://phabricator.wikimedia.org/T123249#3891389 (DStrine) [21:26:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18, Epic: [epic] Improvements to Contact page - https://phabricator.wikimedia.org/T118354#3891390 (DStrine) [21:26:26] Fundraising-Backlog, FR-Paypal, Fr-backlog-cleanup-Q3_2017-18, Recurring-Donations: Paypal recurring are sometimes added with currency=null - https://phabricator.wikimedia.org/T107378#3891406 (DStrine) [21:27:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: Deprecate wmf_unsubscribe module - https://phabricator.wikimedia.org/T115066#3891408 (DStrine) [21:27:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: Fix blank no_thank_you - https://phabricator.wikimedia.org/T97684#3891409 (DStrine) [21:27:38] Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18, Zero: Disable fundraising banners for zero rated devices - https://phabricator.wikimedia.org/T105816#3891411 (DStrine) [21:28:22] Fundraising Sprint House of Pain, Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18: Backfill donor language information from logs? - https://phabricator.wikimedia.org/T94670#3891413 (DStrine) [21:29:12] Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18: Do not log CC exp date - https://phabricator.wikimedia.org/T86234#3891414 (DStrine) [21:29:24] Fundraising-Backlog, Epic: [EPIC] Amazon post campaign ready - https://phabricator.wikimedia.org/T112817#3891415 (DStrine) Open>Resolved [21:30:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: Dear God - please help us find another way to compile the donor list for the annual report - https://phabricator.wikimedia.org/T118822#3891417 (DStrine) [21:33:22] hey ejegg, if the token expires, what should the status be? canceled or complete or pending? would it already be rectified by the audit? [21:34:50] mepps I think we can't tell in that case [21:35:06] We should just delete the record from the pending DB [21:35:40] hmm okay [21:44:59] (PS10) Eileen: Add extension to change contact types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) [21:50:46] (CR) jerkins-bot: [V: -1] Add extension to change contact types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [21:59:58] i'm going to start rebooting some eqiad servers now, going to do everything besides master queue and db chaos monkey style [22:01:44] cwd wanna stop some jobs first? [22:02:15] yeah not a bad idea, that would affect civi1001 and ...? [22:03:13] yeah, just civi1001 [22:04:34] cool, i'll do the others first [22:08:56] (PS11) Eileen: Add extension to change contact types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) [22:10:44] ah i seem to remember kicking the read db can also make a job or two fail? [22:10:56] cwd oh right, good thought [22:17:50] heading off for tonight fr-tech [22:17:55] night! [22:17:57] catch you all tomorrow [22:17:58] o/ [22:17:58] Have a good one [22:18:02] so long jgleeson [22:18:11] ejegg: I think I got the relationship bit right now [22:20:39] eileen: cool! checking again [22:25:35] ahh, now I see what that $required... var was used for [22:25:46] didn't notice it was used in the getsingle call [22:37:59] (CR) Ejegg: "This works! One typo, and some nitpicking on the details logged to the activity." (5 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [22:43:44] ejegg: how about the banner log host? could that disrupt any jobs? [22:43:59] cwd I think that's OK [22:45:01] (PS12) Eileen: Add extension to change contact types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) [22:45:19] cool [22:46:52] nm it's ubuntu anyway [22:47:45] (CR) Ejegg: [C: 2] "Looks great, thanks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/398176 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [22:48:28] yay - thanks ejegg - will roll that one out! [22:48:43] gonna head back to the apt while it's not raining or hailing here... [22:48:48] thank you eileen ! [22:50:22] btw - I fixed that tpl if too [22:51:03] (CR) Ejegg: [C: 2] "Hooray for consistency!" (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/403098 (owner: Eileen) [22:51:36] eileen: I was a bit confused - I expected that array would have to contain all the contact types [22:52:00] anyway, gonna get on my bike [22:53:23] (CR) Eileen: CRM-21634 Stdise search fields as they relate to contacts (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/403098 (owner: Eileen) [22:56:27] (Merged) jenkins-bot: CRM-21634 Stdise search fields as they relate to contacts [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/403098 (owner: Eileen) [23:25:03] (PS1) Eileen: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/403554 [23:26:25] (CR) Eileen: [C: 2] Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/403554 (owner: Eileen) [23:27:24] (PS7) Eileen: Allow Benevity currencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/399252 (https://phabricator.wikimedia.org/T182808) [23:27:26] (PS4) Eileen: WIP Citibank import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/401819 [23:28:23] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/401644 (owner: Eileen) [23:31:22] (CR) jerkins-bot: [V: -1] WIP stock upgrade to 4.7.30 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/401644 (owner: Eileen) [23:31:42] (PS1) Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403555 [23:31:44] (PS1) Eileen: Add Citibank International to payment instruments on new installs. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403556 [23:31:46] (PS1) Eileen: Re-save any contacts without a display name. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403557 (https://phabricator.wikimedia.org/T179118) [23:34:00] (CR) Eileen: [C: 2] CiviCRM submodule update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403555 (owner: Eileen) [23:34:11] (CR) Eileen: [C: 2] Add Citibank International to payment instruments on new installs. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403556 (owner: Eileen) [23:34:24] (CR) Eileen: [C: 2] Re-save any contacts without a display name. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403557 (https://phabricator.wikimedia.org/T179118) (owner: Eileen) [23:35:52] (PS1) Eileen: Add extension to change contact types [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403558 (https://phabricator.wikimedia.org/T156193) [23:36:13] (PS1) Eileen: Update CiviCRM submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403559 [23:36:48] (CR) Eileen: [C: 2] Add extension to change contact types [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403558 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [23:37:33] (Merged) jenkins-bot: CiviCRM submodule update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403555 (owner: Eileen) [23:37:38] (Merged) jenkins-bot: Add Citibank International to payment instruments on new installs. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403556 (owner: Eileen) [23:37:41] (CR) Eileen: [C: 2] Update CiviCRM submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403559 (owner: Eileen) [23:38:18] (Merged) jenkins-bot: Re-save any contacts without a display name. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403557 (https://phabricator.wikimedia.org/T179118) (owner: Eileen) [23:39:13] (Merged) jenkins-bot: Add extension to change contact types [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403558 (https://phabricator.wikimedia.org/T156193) (owner: Eileen) [23:39:48] (Merged) jenkins-bot: Update CiviCRM submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403559 (owner: Eileen) [23:44:05] eileen: did you have to do a cherry-pick? [23:44:41] ejegg: not 100% sure [23:44:49] I mean - I didn't recognise 2 commits [23:44:59] & so I cherry-picked [23:45:03] ah, ok [23:45:04] (I thought no-one was around to check with) [23:45:35] if you want me to I'll merge those 2 now & deploy them [23:45:41] looking [23:45:59] ah, the average processing times and the composer test script [23:46:12] nah, might as well deploy those tomorrow while Jack's around [23:47:49] cool [23:48:13] we had a few hiccups recently that felt like it was in similar code so I felt a bit shy on them [23:48:19] yeah [23:50:24] !log civicrm revision changed from 429a5c5385 to 354f32fe8a, deploy contact change, contact search fixes, install cleanup [23:50:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log