[00:39:54] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403874 [00:39:56] (PS1) Eileen: Add civitoken extension. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/403875 (https://phabricator.wikimedia.org/T184647) [15:59:59] hey jgleeson and ejegg! [16:00:21] hi mepps [16:00:34] hey mepps & ejegg :) [16:06:41] (PS5) Mepps: Use SmashPig FinalStatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403757 [16:07:35] (PS5) Mepps: WIP: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) [16:08:46] (CR) jerkins-bot: [V: -1] Use SmashPig FinalStatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403757 (owner: Mepps) [16:09:16] (CR) jerkins-bot: [V: -1] WIP: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) (owner: Mepps) [16:09:59] (PS6) Mepps: WIP: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) [16:11:38] (CR) jerkins-bot: [V: -1] WIP: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) (owner: Mepps) [16:24:30] (PS6) Mepps: Use SmashPig FinalStatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403757 [16:26:26] (PS7) Mepps: WIP: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) [16:28:21] ejegg the build is finally passing for the FinalStatus patch [16:28:34] (CR) jerkins-bot: [V: -1] WIP: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) (owner: Mepps) [16:28:38] great! [16:28:43] that ought to be a quick review [16:32:42] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint Uptight Piano, and 6 others: Registering test in impressions - https://phabricator.wikimedia.org/T176334#3897018 (AndyRussG) >>! In T176334#3870139, @And... [16:34:10] ejegg: you down to meet? [16:39:31] dstrine: oh shoot! [16:43:06] (PS8) Mepps: WIP: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) [16:56:54] going to bring ye olde payments site down for a few [17:06:35] !log disabled process-control jobs [17:06:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:06:50] !log disabled payments/civi/listener [17:07:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:28:51] !log re-enabled payments,civi,listener,p-c [17:29:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:34:57] all seems to have gone fine [17:35:00] no fail mail even [17:47:21] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, Fundraising-Backlog: Track fundraising failmail volume in prometheus - https://phabricator.wikimedia.org/T179704#3733571 (cwdent) This was trivial to add to the existing syslog pa... [17:56:01] (CR) Ejegg: [C: 1] "Looks great! Let's just update the SmashPig lib again to 0.5.2, unless you were planning to do that in the next patch" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403757 (owner: Mepps) [18:01:18] cwd thanks for adding the fr-tech mail tracking! [18:03:16] jgleeson: you bet. i called it frtech mail to be a little less conspicuous [18:09:26] speaking of failmail, lemme see what's up with those silverpop fetches [18:10:16] fr-tech, can anyone see what I'm doing wrong here... earlier I tagged 1.4.1 of stats-collector here https://github.com/jackgleeson/stats-collector/releases but packagist just won't pull in the changes https://packagist.org/packages/jackgleeson/stats-collector via hook or manual update [18:10:59] jgleeson odd, that sure looks right [18:11:39] travis CI failed at first, so I rerun the job and it passed so I expected it to fix itself [18:11:55] I'm not sure what mepps had done earlier, but it seemed like packagist didn't know about a new SmashPig tag eaither, till I hit the update button on the 'edit' package page [18:12:07] reran* [18:12:20] yeah I thought the manual update would restore order but no such luck [18:14:20] I guess I could temporarily override the repo in composer [18:16:37] cwd, does that new graph filter give us coverage of _ALL_ failmail? [18:17:24] if so, that's even better than what we were hoping for. Initially we were just gonna track SmashPig(PHP) specific failmail [18:17:46] jgleeson: it's just anything civi1001 sends to fr-tech@ [18:17:54] i believe that's just failmail [18:18:14] it's possible we could regexp the message to get more granularity [18:19:02] I think we're happy with the broad filter [18:19:13] if I understand it right [18:19:42] yep, noise is noise [18:19:47] great! [18:19:49] :) [18:25:34] hmmm [18:26:02] even overriding the repo isn't resolving it. Composer can only seen earlier version apparently [18:31:37] ahhhhhhhh [18:31:43] facepalm [18:31:56] v(.)1.4.1 [18:32:09] I seem to have dropped a period in before the version number [18:32:21] so it's actually version v.1.4.1 [18:32:37] I take back all the angry ranting to pagagist and composer [18:32:51] packagist* [18:37:14] huh, don't know how that happened, but the 'download done' file exists while the supposedly downloaded file is missing [18:37:37] i'll try deleting the semaphore and see if it just re-downloads [18:53:33] (PS7) Mepps: Use SmashPig FinalStatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403757 [19:19:01] !log disabled Omnimail recipient load backfill job [19:19:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:19:44] (PS8) Ejegg: Use SmashPig FinalStatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403757 (owner: Mepps) [19:19:57] (CR) Ejegg: [C: 2] "Thanks for the code de-dupe!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403757 (owner: Mepps) [19:22:10] (Merged) jenkins-bot: Use SmashPig FinalStatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403757 (owner: Mepps) [19:22:37] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Omnimail recipient load tripping over non-downloaded file - https://phabricator.wikimedia.org/T184823#3897611 (Ejegg) [19:38:28] (PS6) Jgleeson: Added DonationStatsCollector class to record stats across Donation Queue Consumer. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/403305 [19:41:33] fr-tech, I'm calling it a day. Have a great evening and weekend. Catch up with you next week! [20:21:11] ejegg|afk: or mepps do you know if the proximity search in civi was ever working? I feel like it was but I only seem to get error messages [20:21:36] it's where you have to put in longitude and latitude and a radius [20:28:05] I've never used it, but I hadn't heard that it was broken [20:31:11] ok [20:33:45] taking a peek now [20:37:21] me too [20:38:13] worked for me dstrine [20:38:17] what errors are you seeing? [20:38:32] dstrine: I got some results back too, just took a little while [20:39:22] I looked up longitude and latitude of oakland. I added them in with a radius of 10 miles and selected the 5k+ group just so it wasn't huge. I got an error. gimme a second to repro... [20:40:16] https://www.irccloud.com/pastebin/cPOvfNQ4/ [20:41:21] are you adding lon and lat with the degree sign or without? [20:41:24] ah, I hadn't tried with a group [20:41:34] no, lat and long as decimals [20:42:01] ok so Oakland is: 37.8044° N, 122.2711° W [20:42:01] you can pull those out of the url on most map sites [20:42:13] the latitude is -122.2711 then [20:42:19] asdlkfjsadklfj [20:42:20] right [20:43:10] ok it's spinning now. waiting for results [20:45:54] ok I got a result without using a group. I'm trying a group now... [20:46:10] cool [20:46:34] would be dope to have a location picker with a map [20:49:10] I can't seem to get anything from smart groups. I stay on the page with the proximity form but get a "none found" message [20:52:05] do we know why we use lat and long? i looked at a demo site and it uses addresses [20:52:20] also i'm trying with a group and it's pretty slow so far [20:53:37] mepps: which group did you choose. It's instantly returning "none foudn" for me. It's like it's not even looking [20:53:45] sorry typos [20:54:22] i tried 250 in past 3 years [20:55:06] i eventually got none found [20:57:43] (CR) Ejegg: [C: 2] "Oh wow, you pushed the timer all the way up into the library!" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/403305 (owner: Jgleeson) [20:58:48] mepps the default Civi install uses a Google service to geocode addresses [20:59:06] And we don't want to send Google anything [20:59:11] ah gotcha [20:59:23] So we found our own db mapping zip codes to lat/long [20:59:38] and we have a hook on address save to geocode US addresses with that db [21:00:21] I think we just need to rewrite the access to that table as a geocoding service [21:00:36] then we could probably just attach it to the search form too [21:03:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Rewrite our zip code table access as a Civi geocoding service - https://phabricator.wikimedia.org/T184830#3897812 (Ejegg) [21:03:37] (Merged) jenkins-bot: Added DonationStatsCollector class to record stats across Donation Queue Consumer. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/403305 (owner: Jgleeson) [21:05:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Rewrite large donation notifications as a standard Civi extension - https://phabricator.wikimedia.org/T184831#3897822 (Ejegg) [21:05:33] mepps: what's your comfort level with creating angular UIs for Civi extensions? [21:06:08] i haven't done much with extensions since the switch to angular, but i'd love to do it! [21:06:21] I was looking at doing the large donation notifications as a standard Civi extension, [21:06:45] but we need to store an indefinite number of notification levels, each with an indefinite list of addresses [21:07:30] I guess it's not the angular bit per se that I got stumped on, it was how to save that back to Civi in a standard way... [21:08:58] hmm, you could create a new db table [21:11:02] ah yeah, was I trying to avoid making them full-fledged entities or something? [21:11:09] sorry, that was a while ago [21:11:53] haha yeah i know that feeling [21:19:43] ejegg did you ever think of adding this feature in to scheduled reminders/ [21:20:41] hmm, and broaden the name to 'notifications' or the like? [21:21:01] That would be a logical grouping! [21:21:59] yeah that's basically how scheduled reminders operate--you just can't currently filter by donation amount, which i bet would be helpful [21:22:58] where's the menu for that again? [21:23:30] ah, communications [21:23:50] the add screen seems to be broken for us though [21:24:16] * mepps but you can check it out on this demo site: https://demo.circle-interactive.co.uk/civicrm/admin/scheduleReminders?reset=1 [21:24:29] huh i did not mean to add a / [21:31:55] ah, interesting, so that could potentially be less disruptive to big imports, if the scheduled reminder job runs on cron instead of checking during each contribution save [21:32:37] mepps so an additional action_conditions table or something [22:02:49] I'm going to step out for a bit... BRB [22:08:17] that makes sense ejegg [22:08:22] I can [22:08:36] Want to create a phab ticket? [22:11:02] Or is there one? [22:26:58] mepps oops [22:27:13] I made this one: T184831#3897822 (Ejegg) [22:27:13] T184831: Rewrite large donation notifications as a standard Civi extension - https://phabricator.wikimedia.org/T184831 [22:27:41] but feel free to rewrite it to suit the other approach [23:08:34] XenoRyet: can I help with that 'privacy policy flash' ticket in any way? [23:11:58] ejegg: Na, I just need to quit procrastinating and actually work on it for a while. I keep letting myself wander off and look at other things. [23:12:47] I'll get back to it so we can close it out.