[03:24:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Task for 1 Jan (or thereabouts) adjust CiviCRM search range - https://phabricator.wikimedia.org/T132540#3901885 (Eileenmcnaughton) I just updated this to be 8 years for 2018 [14:41:45] hhey fr-tech :) [15:53:20] hey jgleeson [15:53:33] :) [16:09:17] dstrine you're up early [16:09:43] I'm on about this time most days. I may not be sending emails all the time [16:19:54] how was your weekend jgleeson? [16:20:12] ah not so great [16:20:22] was unwell so missed the wikimedia uk meet [16:20:33] i always seem to get ill on weekends [16:22:11] aww i'm sorry [16:25:36] i started getting a cold over the weekend myself :(, i think your body waits for you to relax [16:26:55] yup [16:29:09] hey mepps maybe you can help me, I've setup xdebug on my local paymentswiki install and it works great but I am struggling to get the unit tests for the donation interface running. I've pulled in all the updates I can see from the payments wiki upstream and it's remotes and also run mwscript update.php. However when I run the tests I'm getting lots of this in the output, Error: 1146 Table 'drupal.unittest_contribution_tracking' doesn't [16:29:09] exist [16:29:16] morningsies [16:29:22] hey AndyRussG :) [16:29:27] jgleeson: hey :) [16:30:15] hmm jgleeson i don't think you should be getting a drupal error for donation interface, want to screen share in 5? [16:31:35] yeah I can't find any record of drupal across the payments wiki code or its extensions, nothing that would indicate a problem [16:31:39] hmmm [16:32:35] I'm in a coffee shop at the moment, and my bluetooth is not working since firmware upgrade yesterday so I can't convenient chat via voice [16:33:01] I started off initially following this [16:33:14] https://www.mediawiki.org/wiki/Fundraising_tech#Running_PHPUnit_tests_under_vagrant [16:33:46] which failed, as the checkout of the payments wiki had no tests [16:33:54] i then had to update the remote info and pull down master [16:34:39] My guess is that it's something to do with the contribution tracking extension, it appears to contain sql updates which I don't have in my local db [16:35:11] hmm so you can run tests for donation interface without running contribution tracking [16:35:18] is there a way to independently patches for an extension, outside of the mwscript update.php stuff [16:35:45] ah [16:36:07] i definitely don't have that table locally [16:36:23] i usually just run the unittests with the group flag for DonationInterface [16:36:38] I wonder if the flag is being ignored [16:36:58] do you use, php phpunit.php --wiki paymentswiki --group DonationInterface [16:38:12] i don't use the wiki flag [16:38:36] i think the default vagrant install setups up two installs of wiki [16:38:47] sorry that's not correct [16:39:05] the vagrant fundraising role, installs a second wiki called paymentswiki (mediawiki-fr) [16:43:01] ah okay [16:43:07] and where do you run phpunit.php from? [16:43:18] i run it within paymentswiki itself so i don't need the flag [16:43:28] i don't know the vagrant setup well though since it never worked for me [16:44:44] running it from wiki/tests/phpunit [16:48:07] could you run it directly within the paymentswiki directory? that's where i do it, without the flag [16:48:18] hey mepps, what revision hash do you have checked out for DonationInterface [16:48:20] I see the following [16:48:22] +07d5efbc9c811094bbd5647705e84f04c6f32769 extensions/DonationInterface (v2.1.0-2860-g07d5efbc) [16:49:07] e9e2ca71850409ec4ee768773addd496289f71f8 [16:50:57] do we have a similar convention around removing tests for extensions? [16:53:19] what do you mean? [16:53:26] we remove tests for deployment but not in master [16:53:44] yeah just trying to understand why the tests don't exist in the version I'm lookng at [16:55:24] so I think there is some weirdness going on deployment test related [16:55:55] I just checked the log message for the latest version of donation interface (6ddd13b) [16:56:19] on this project, and it is a "merging master into deployment" commit message [16:58:02] umm that sounds like you're on the deployment branch [17:01:01] yup [17:01:05] that would make sense [17:02:57] :) [17:14:03] so from what I can work out, it looks like when you use the vagrant fundraising role, it installs this version of mediawiki https://github.com/wikimedia/mediawiki/tree/fundraising/REL1_27 [17:14:19] which includes deployment versions of the extensions maybe [17:30:28] makes sense--that's the deployed branch [17:41:10] sorry mepps I forgot to ask, how was your weekend? [17:47:36] jgleeson, overall not too bad although i'm slightly getting a cold [17:49:52] :< [17:50:01] hope it's not round for long [17:50:18] me too! are you feeling better? [19:17:23] yeah ditto jgleeson, that patch above stopped me for a bit just because i thought i'd altered a file but couldn't find it in git [20:02:35] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, and 2 others: CentralNotice: Consolidate typical analytics queries (for example, for impression r... - https://phabricator.wikimedia.org/T178930#3903999 [20:31:29] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Ingenico cc-vmaj form does not have expected order of card types - https://phabricator.wikimedia.org/T185035#3904098 (Pcoombe) [20:49:18] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog: Remove ccogdill from Large Donation Bot emails - https://phabricator.wikimedia.org/T183977#3904139 (Eileenmcnaughton) @CCogdill_WMF am assuming this worked & we can close? [20:50:02] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: pull numbers on manual merges - https://phabricator.wikimedia.org/T183943#3904140 (Eileenmcnaughton) Open>Resolved @DStrine good to close? [20:50:23] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog: Add formatting capabilities (?) to Details field of an Activity - https://phabricator.wikimedia.org/T183389#3904145 (Eileenmcnaughton) @CaitVirtue is this good to close now? [20:51:44] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix to unsubscribe screen - emails not displaying when contacts not found - https://phabricator.wikimedia.org/T183884#3904147 (Eileenmcnaughton) Open>Resolved [20:54:11] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Patch-For-Review: thank you letter update - https://phabricator.wikimedia.org/T181093#3904149 (mepps) Open>Resolved a:mepps [21:05:52] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog: Remove ccogdill from Large Donation Bot emails - https://phabricator.wikimedia.org/T183977#3904186 (DStrine) Open>Resolved [21:06:37] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog: Add formatting capabilities (?) to Details field of an Activity - https://phabricator.wikimedia.org/T183389#3904188 (DStrine) @LeanneS can you help check if this is resolved? [21:07:27] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changing contact records from individual records to organization records - https://phabricator.wikimedia.org/T156193#3904194 (DStrine) @Lea... [21:10:02] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Patch-For-Review: Bugfix: remove duplicate Prometheus metric keys output from DonationStats .prom file output - https://phabricator.wikimedia.org/T183153#3904222 (jgleeson) Open>Resolved [21:11:05] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, MediaWiki-Vagrant: Replace upstart with systemd unit in crm::dash - https://phabricator.wikimedia.org/T154264#3904227 (jgleeson) Open>Resolved [21:11:07] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Failing job AntifraudQueueConsumer.php on risk_score format - https://phabricator.wikimedia.org/T183102#3904229 (Eileenmcnaughton) Open>Reso... [21:11:20] Fundraising-Backlog, Epic: EPIC: Prometheus Metric Suggestions - https://phabricator.wikimedia.org/T179179#3904238 (jgleeson) [21:11:23] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, Fundraising-Backlog: Track fundraising failmail volume in prometheus - https://phabricator.wikimedia.org/T179704#3904237 (jgleeson) Open>Resolved [21:12:46] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Winter Wanderland, Fundraising-Backlog: Check alpha channel docs for "show stopper" issues - https://phabricator.wikimedia.org/T182032#3904242 (DStrine) Open>Resolved [21:12:57] hey bd808 [21:13:06] how goes it? :) [21:16:47] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, FR-Amazon, and 3 others: Amazon errors showing up as [Object object] - https://phabricator.wikimedia.org/T183477#3904250 (Ejegg) Open>Resolved [21:16:59] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog, FR-Amazon, FR-Smashpig, and 3 others: Deal better with Amazon auth/capture timing out - https://phabricator.wikimedia.org/T183429#3904251 (Ejegg) Open>Resolved p:Triage>Normal a:Ejegg [21:18:07] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Ingenico cc-vmaj form does not have expected order of card types - https://phabricator.wikimedia.org/T185035#3904257 (mepps) a:mepps [21:21:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Lat/long radius lookup in civi not working with smart groups - https://phabricator.wikimedia.org/T185039#3904268 (DStrine) [21:21:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: Remove tests from CRM deployment - https://phabricator.wikimedia.org/T88378#3904278 (Eileenmcnaughton) [21:24:46] Fundraising-Backlog: check_recurring_gc_jobs_required > 6000 - https://phabricator.wikimedia.org/T183882#3866101 (DStrine) Open>Resolved [21:26:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Double check if we missed a donation - https://phabricator.wikimedia.org/T185041#3904304 (Eileenmcnaughton) [21:28:31] Fundraising Sprint B 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Lat/long radius lookup in civi not working with smart groups - https://phabricator.wikimedia.org/T185039#3904319 (DStrine) [21:28:34] Fundraising Sprint B 2018, Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18: add tasks to #fr-backlog-cleanup-q3_2017-18 - https://phabricator.wikimedia.org/T185007#3904321 (DStrine) [21:28:36] Fundraising Sprint B 2018, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Ingenico cc-vmaj form does not have expected order of card types - https://phabricator.wikimedia.org/T185035#3904320 (DStrine) [21:28:38] Fundraising Sprint B 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Omnimail recipient load tripping over non-downloaded file - https://phabricator.wikimedia.org/T184823#3904322 (DStrine) [21:28:40] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: add ability to filter by contact type to contribution search - https://phabricator.wikimedia.org/T184496#3904324 (DStrine) [21:28:42] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: add token for address without extra lines - https://phabricator.wikimedia.org/T184647#3904323 (DStrine) [21:28:44] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising-Backlog: Make phab tasks for Kafkatee changes - https://phabricator.wikimedia.org/T183978#3904326 (DStrine) [21:28:46] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising-Backlog: Add formatting capabilities (?) to Details field of an Activity - https://phabricator.wikimedia.org/T183389#3904327 (DStrine) [21:28:48] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising-Backlog: Document severity of the various forms of outage - https://phabricator.wikimedia.org/T183293#3904328 (DStrine) [21:28:50] Fundraising Sprint B 2018, Fundraising-Backlog, Patch-For-Review: Handle timeout in PaypalEC Orphan Rectifier and enable job - https://phabricator.wikimedia.org/T184284#3904325 (DStrine) [21:28:52] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, and 2 others: reassess tasks leading up to internal test in ingenico reintegration - https://phabricator.wikimedia.org/T183290#3904329 (DStrine) [21:28:54] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Patch-For-Review: Bugfix: Prometheus serving old data in the absence of new data, to Grafana - https://phabricator.wikimedia.org/T183275#3904330 (DStrine) [21:28:56] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, and 2 others: Different currencies for Benevity import - https://phabricator.wikimedia.org/T182808#3904331 (DStrine) [21:28:59] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, and 3 others: Fatal error in Amount formatting - https://phabricator.wikimedia.org/T182737#3904332 (DStrine) [21:29:02] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: make a wiki page for CN status codes - https://phabricator.wikimedia.org/T181652#3904335 (DStrine) [21:29:05] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Stat1005 BH data issue? - https://phabricator.wikimedia.org/T181811#3904334 (DStrine) [21:29:08] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Winter Wanderland, and 6 others: Amazon code should allow specifiying proxy parameters in configuration - https://phabricator.wikimedia.org/T180168#3904336 (DStrine) [21:29:10] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, and 2 others: Prometheus: Add seconds diff metric report [donation message enqueued => donation saved to ci... - https://phabricator.wikimedia.org/T179173#3904339 [21:29:12] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, and 2 others: Track rate of new donations added to civicrm by the donations queue consumer, in prometheus - https://phabricator.wikimedia.org/T179214#3904338 (... [21:29:15] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, and 3 others: CentralNotice: Consolidate typical analytics queries (for example, for impression rates) into ... - https://phabricator.wikimedia.org/T178930#3904340 [21:29:22] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, and 7 others: Registering test in impressions - https://phabricator.wikimedia.org/T176334#3904342 (DStrine) [21:29:24] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint B 2018, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, and 2 others: Changing contact records from individual records to organization records - https://phabricator.wikimedia.org/T156193#3904343 (DStrine) [21:49:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fee amount / net amount error - https://phabricator.wikimedia.org/T185045#3904428 (Eileenmcnaughton) p:Triage>Normal [21:50:15] Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Thank you letter from civi mangles non-$ currencies - https://phabricator.wikimedia.org/T151957#3904444 (Eileenmcnaughton) Open>R... [21:52:21] hey fr-tech, gonna call it day. Today has been mostly about xdebug debugging the ingenico stuff on paymentswiki (working) and then battling with the DonationInterface tests on the same paymentswiki install (not working), on the vagrant instance. Tomorrow will be fixing of the latter, and releasing the outstanding Prometheus patches due to be deployed. Have a great day and catch you all tomorrow. [22:15:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced Search needs an OR operator - https://phabricator.wikimedia.org/T115900#3904497 (Eileenmcnaughton) I feel like this is something in Advanced search - not sure it's a requirement still? We did reorg the page a little to make it more prominent [22:16:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: Advanced Search needs an OR operator - https://phabricator.wikimedia.org/T115900#3904501 (Eileenmcnaughton) [22:26:56] Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Lat/long radius lookup in civi not working with smart groups - https://phabricator.wikimedia.org/T185039#3904268 (Eileenmcnaughton) a:Eileenmcnaughton [22:36:46] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising-Backlog: Add formatting capabilities (?) to Details field of an Activity - https://phabricator.wikimedia.org/T183389#3904538 (CaitVirtue) Yes, looks great!! Thank you! [22:37:08] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising-Backlog: Add formatting capabilities (?) to Details field of an Activity - https://phabricator.wikimedia.org/T183389#3904540 (DStrine) Open>Resolved [22:39:46] Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Omnimail recipient load tripping over non-downloaded file - https://phabricator.wikimedia.org/T184823#3897611 (Eileenmcnaughton) a:Eileenmcnaughton [22:42:20] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Possibility to create bad query from dedupe by fishin... - https://phabricator.wikimedia.org/T182251#3818010 [22:48:16] Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Lat/long radius lookup in civi not working with smart groups - https://phabricator.wikimedia.org/T185039#3904568 (Eileenmcnaughton) Ideally add proximity to advanced search [22:48:37] Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add proximity search to advanced search - https://phabricator.wikimedia.org/T185047#3904569 (Eileenmcnaughton) [22:49:04] Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Rewrite our zip code table access as a Civi geocoding service - https://phabricator.wikimedia.org/T184830#3904580 (Eileenmcnaughton) [22:56:03] huh, icinga-wm has run off again [23:02:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: add Partner field to summary field in donor record - https://phabricator.wikimedia.org/T185048#3904602 (DStrine) [23:02:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: add Partner field to summary section in donor record - https://phabricator.wikimedia.org/T185048#3904613 (DStrine) [23:03:27] Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Rewrite our zip code table access as a Civi geocoding service - https://phabricator.wikimedia.org/T184830#3897812 (Eileenmcnaughton) a:Eileenmcnaughton [23:03:37] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: improve MG mailing process - https://phabricator.wikimedia.org/T179882#3904619 (Eileenmcnaughton) [23:03:39] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: add ability to filter by contact type to contribution search - https://phabricator.wikimedia.org/T184496#3904618 (... [23:03:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Epic: Dedupe V2: resolve top conflicts - https://phabricator.wikimedia.org/T143057#3904621 (Eileenmcnaughton) [23:03:53] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising Sprint Winter Wanderland, Fundraising-Backlog, and 2 others: Changing contact records from individual records to or... - https://phabricator.wikimedia.org/T156193#3904620 [23:14:41] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising Sprint Winter Wanderland, Fundraising-Backlog, and 2 others: Changing contact records from individual records to or... - https://phabricator.wikimedia.org/T156193#3904641 [23:42:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: add ability to search for 'has email' to contribution search - https://phabricator.wikimedia.org/T185053#3904713 (Eileenmcnaughton) [23:43:19] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: spike into using scheduled reminders to send out the letters or have conditional blocks so only one template needed - https://phabricator.wikimedia.org/T185054#3904723 (Eileenmcnaughton)