[01:47:27] cwd when was it we might go to php 7? [01:48:54] eileen: no time soon, our mw version is supported for another year+ [01:49:09] but that's not to say we can't do it sooner [01:49:20] ah ok - trying to use a library that is only php 7+ :-( [01:49:45] well heck if you all want to prioritize it it's trivial from an ops perspective [01:49:52] and probably good for security [01:49:58] hmm interesting.... [01:50:17] & possible better peformance [01:50:43] hrm actually i am not seeing a jessie candidate [01:50:51] i thought there was one [01:51:12] not a blocker but a slower down maybe [01:51:19] we are going to start updating to stretch anyhow [01:55:10] basically I have a choice between an out of date package or the php 7 version - but I'm just trying to use the php 7 & remove the special features (mostly a lot of type hinting) [01:56:07] yeah well i think it's a reasonable thing for us to do in the near term [01:56:19] ok - good to know [01:56:33] the package isn't a hugely important part of this - it's mostly for structure [05:35:27] Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog: Remove ccogdill from Large Donation Bot emails - https://phabricator.wikimedia.org/T183977#3905296 (CCogdill_WMF) Yes, thank you! Le mar. 16 janv. 2018 à 13:05, DStrine a écrit : > DStrine closed thi... [14:28:46] hi jgleeson ! [14:28:49] Want to do that deploy? [14:29:21] https://gerrit.wikimedia.org/r/#/c/403305/ [14:30:02] so we can start to map over our grafana data sources [14:30:20] or convert to labels, to be more precise [14:31:15] Cool! that one's merged to master and ready to put on the deployment branch [14:32:06] ok thanks I'll create the patch now [14:35:09] I'll have to check out the civicrm project separately as I've had to ditch my vagrant environment and start again after running into problems yesterday [14:41:39] ah, right, the 'zend' role disappearance? [14:42:08] not exactly [14:42:18] that was a follow-on discovery [14:42:33] anything I can do to help? [14:43:01] maybe, wanna jump on chat and I can talk you through what I did and what I'm doing now to resolve it? [14:43:26] sure! [14:43:57] ok, I'm in the chat [14:47:27] morningz! [14:54:12] (PS9) Mepps: WIP: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) [14:54:18] ejegg see above ^^ [14:54:20] (CR) jerkins-bot: [V: -1] WIP: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) (owner: Mepps) [14:54:50] it's still wip because i don't know how to handle the case where a live user hits an expired token (if that's likely--maybe they reload a page much later?) [14:56:31] (PS10) Mepps: WIP: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) [14:56:39] (CR) jerkins-bot: [V: -1] WIP: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) (owner: Mepps) [14:59:23] (PS11) Mepps: WIP: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) [15:04:35] (PS1) Jgleeson: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/404682 [15:12:57] (PS2) Jgleeson: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/404682 [15:23:00] (PS1) Jgleeson: Added stats collector 1.4.1 [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/404686 [15:25:00] (CR) Jgleeson: [V: 2 C: 2] Added stats collector 1.4.1 [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/404686 (owner: Jgleeson) [15:32:24] (Merged) jenkins-bot: Added stats collector 1.4.1 [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/404686 (owner: Jgleeson) [15:43:23] mepps thanks! I'll take a look once we've got this deploy out [15:48:23] (PS1) Jgleeson: Updated vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/404693 [15:49:26] (CR) Jgleeson: [V: 2 C: 2] Updated vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/404693 (owner: Jgleeson) [16:00:22] (CR) Jgleeson: [C: 2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/404682 (owner: Jgleeson) [16:03:17] (Merged) jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/404682 (owner: Jgleeson) [16:03:47] (Merged) jenkins-bot: Updated vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/404693 (owner: Jgleeson) [16:05:48] !log turned off donations queue consumer process-control job [16:05:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:13:28] !log updated civicrm from 354f32fe8a to c70f01cd83 [16:13:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:29:22] mornings AndyRussG & mepps [16:34:33] hello jgleeson! how are you feeling? [16:35:01] ah still not so great, had a headache all day [16:44:09] :( [16:44:11] hey all I will be missing standup due to other meetings. Also I forgot I have an appointment lunch lunch. I'll send an email on this too just in case. [16:44:28] lunch lunch? that should be around lunch [16:44:33] :P [16:50:32] is that second lunch dstrine? [16:51:29] I mean.. I'd be ok with that. I am hungry right now. Is there such a thing as a Freudian typo? [16:59:45] :) [17:00:36] jgleeson: hey :) [17:50:48] dstrine--maybe you should study freudian typos :) [17:51:38] mepps: I'll add it to the backlog [17:55:23] hey ejegg, how do i access a form with a specific variant? [17:55:29] in donation interface [17:56:29] wait just noticed in the link [17:56:47] hey mepps, I'm guessing but maybe the URL's added here can help you get specific types of ingenico forms https://gerrit.wikimedia.org/r/#/c/402404/3/puppet/modules/payments/files/Main_Page.wiki [17:57:35] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising Sprint Winter Wanderland, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: make a wiki page for CN stat... - https://phabricator.wikimedia.org/T181652#3906763 [18:01:34] mepps sorry - did you get the variant? [18:01:42] yup [18:01:48] you need to have the variant defined in config in the first place... [18:01:52] ok, cool! [18:02:16] I'm going to turn off that other silverpop job till we figure out why cURL is timing out [18:02:20] maybe a new ip? [18:04:54] jgleeson thanks for reminding me that vagrant patch is still unmerged. Did it look good to you? [18:05:02] I can rebase and self-merge if so [18:08:29] !log turned off main silverpop recipient data fetch job [18:08:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:10:30] oh huh, it's only sporadic failures [18:11:40] so what url would that be... [18:27:31] fr-tech any news for scrum of scrums? [18:27:53] None here [18:34:30] XenoRyet: did you say that vagrant patch was working for you? https://gerrit.wikimedia.org/r/402404 [18:34:38] I can merge if so [18:36:57] ejegg, I couldn't actually test the ingenico process with the sandbox details due to the issues we discussed, I didn't get that far [18:37:05] although the content (links) all looked fine [18:39:18] ok, cool, I'll hold off for now [18:39:40] ejegg: I think vagrant got flaky on me before I got all the way through that one. [18:40:17] I've worked out what is up with the missing package [18:40:24] bd808, has removed it [18:40:41] once he is available I'll chat with him to see why [18:40:48] what did I break? [18:40:54] :) [18:41:50] hey Bryan, good to meet you! Nothing major. I ran into some issues yesterday building vagrant using the fundraising role due to changes here: [18:41:51] * bd808 sees "missing package" in backscroll [18:42:40] https://github.com/wikimedia/mediawiki-vagrant/commit/09ddf4ac12d75a7ceb7954d7539245bba70a5c45#diff-f865dc8a1635dd16c6fe3936ce528fe1 [18:42:54] line 20 was removed [18:43:12] also I think the same commit removes the zend vagrant role for enabling debugging [18:43:19] fundraising probably hasn't been tested with the new Stretch base image... see https://lists.wikimedia.org/pipermail/wikitech-l/2018-January/089412.html for the announce and some instructions about how to set your VM back to Jessie is needed. [18:43:24] which I wasn't quite sure why, unless you add it in by default? [18:43:46] I think I can patch it easily enough for Stretch [18:43:50] Stretch uses PHP7 by default and moved hhvm to a role instead [18:44:15] does the upgrade to PHP7 also enable xdebug by default/ [18:44:18] libffi-dev getting dropped there is probably a merge problem :/ [18:44:32] jgleeson: yeah it should be there on port 9000 out of the box now [18:44:59] I haven't actually tested using xdebug, but I did make sure the module was loaded [18:45:10] ahhh great, I guessed that would be the case but I haven't had a chance to confirm/test it yet [18:45:49] the TL;DR of that announce email is that everything is different and some stuff is probably busted :) [18:46:26] but bug reports stopped coming in so I merged the giant change so we can finish up fixing things ;) [18:47:59] ok great, I think I can patch the immediate blocker to allow me to test other functionality [18:48:07] and then confirm whether or not xdebug works out of the box [18:49:08] awesome. y'all should feel officially empowered to fix all of the bugs you find by the MediaWiki-Vagrant "maintainer". I here by deputize you and authorize all self-merges. ;) [18:49:46] :) [18:55:46] (CR) VolkerE: [C: 1] Use findItemFromData instead getItemFromData [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/400467 (https://phabricator.wikimedia.org/T76630) (owner: Prtksxna) [18:55:53] hey bd808, did you intentionally remove the root_password puppet variable here https://github.com/wikimedia/mediawiki-vagrant/commit/09ddf4ac12d75a7ceb7954d7539245bba70a5c45#diff-2481de6e9a6b6a1b6e2c7f04dbb67c67 [18:56:28] I ask because puppet is complaning that it can't find it during the build [18:56:33] jgleeson: yes, for a very interesting reason. The new mariadb setup does not have a root password. [18:56:42] ah cool! [18:56:58] the root user uses auth based on uid of the calling process [18:57:34] this all ended up looking like a horrible mess in the merge sadly [18:58:18] there was a premature merge which we reverted and then when the revert was reverted as part of the merge all of the history on master was lost :/ [18:58:59] sounds tricky [18:59:03] the lost history is buried in https://gerrit.wikimedia.org/r/#/q/status:merged+project:mediawiki/vagrant+branch:stretch-migration [18:59:28] mariadb changes were in https://gerrit.wikimedia.org/r/#/c/399565/ [19:00:27] and this followup -- https://gerrit.wikimedia.org/r/#/c/400119/ [19:00:32] what are the current rspec feature tests testing? and would it be feasable to test the success of a vagrant provision command by role? [19:00:51] I'm thinking that could be something useful if possible [19:01:25] jgleeson: yeah! see https://gerrit.wikimedia.org/r/#/c/399965/ for some info [19:01:40] its too slow right now to test all the things at once [19:01:56] it takes like 20 minutes to run all the roles through it [19:02:47] that will test that Puppet doesn't barf, but it doesn't actually test that the end result services work [19:04:47] I wonder if we could optimise the test execution by parallelising it [19:05:10] looks to be a few implementations, one here: https://github.com/grosser/parallel_tests [19:06:04] for now running the individual role tests is sufficient for me to test fixes for Stretch [19:07:24] actually that might not work [19:07:43] oh no, it should [19:08:37] I was mixing up the sequential nature of puppet builds with parallelising different roles being executed independently, although I'm not sure you could share single VM across multiple tests [19:55:08] (PS1) MaxSem: Archive this extension [extensions/ContributionReporting] - https://gerrit.wikimedia.org/r/404781 (https://phabricator.wikimedia.org/T185062) [19:56:01] (CR) jerkins-bot: [V: -1] Archive this extension [extensions/ContributionReporting] - https://gerrit.wikimedia.org/r/404781 (https://phabricator.wikimedia.org/T185062) (owner: MaxSem) [20:20:41] ejegg|air are you online? [20:20:44] hi eileen! [20:21:26] Fundraising-Backlog, fundraising-tech-ops: Prometheus 2 breaking change - https://phabricator.wikimedia.org/T185134#3907258 (cwdent) [20:23:55] mepps: hi [20:25:45] how's your morning eileen? [20:26:06] a bit wet actually - & the kids are back after a couple of days of quiet [20:26:22] I'm having to work from the bedroom [20:31:30] aww, where were they? [20:33:41] they went to my parents for a couple of days [20:34:18] (Abandoned) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/398939 (owner: Mepps) [20:34:19] My youngest, Luke, loves 'jump hugs' - ie. he leaps of a chair or something at me for a hug - the further the better [20:34:46] (Jack is a bit big for that now - he used to but he'd probably knock me over now) [20:34:47] oh man that sounds sweet but also terrifying [20:35:07] how is life in Baltimore [20:35:10] that's great that your parents will take them for a bit [20:35:21] mostly good, although i've been teetering on the edge of losing my voice [20:35:35] it's a little better today but last night it was almost completely gone [20:36:42] I lost my voice when the kids were little - I couldn't yell at them! [20:37:52] haha [20:43:07] Fundraising-Backlog, fundraising-tech-ops: Prometheus 2 breaking change - https://phabricator.wikimedia.org/T185134#3907330 (cwdent) [20:43:10] fundraising-tech-ops: EPIC: migrate fundraising hosts to Debian Stretch - https://phabricator.wikimedia.org/T185013#3907329 (cwdent) [20:44:15] i'm not sure if what i did makes sense [20:44:24] with the parent task relationship [20:44:38] but it's a blocker to moving anything to stretch [20:45:49] cwd perhaps you should add jack as a subscriber on that - I feel like he has the knowledge on prometheus [20:46:24] yeah sounds good [20:47:04] /nick XenoRyet|food [20:47:26] there are some things to hate about prometheus [20:49:39] cwd: there was a lot of grumbling in the halls at KubeCon about that Promethius2 change but in theory the perf boost is huge for the new system [20:51:06] bd808: interesting, i'll have to check out the nature of it [20:51:52] the storage system has already been the biggest bother for me, it's pretty unreadable and brittle and up to the user to make it resilient [20:58:00] (PS1) Mepps: Seems inelegant but reorders credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/404802 (https://phabricator.wikimedia.org/T185035) [21:14:45] (PS1) Mepps: Add logging for errors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/404806 (https://phabricator.wikimedia.org/T184284)