[13:55:12] <wikibugs>	 (CR) Seb35: "The tests could pass here but composer.lock is not sync with composer.json, independantly of this change. Probably linked to T131264." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388353 (owner: Legoktm)
[14:00:07] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Write browser tests for DonationInterface - https://phabricator.wikimedia.org/T176765#3635945 (Seb35) Duplicate of T99955 ?
[14:40:00] <jgleeson>	 afternoon fr-tech
[14:54:41] <mepps>	 Hey jgleeson!
[14:54:46] <jgleeson>	 :)
[18:18:26] <mepps>	 hey ejegg, based on your comments here: https://gerrit.wikimedia.org/r/#/c/403745/, do you think we shouldn't print errors on the drupal side?
[18:19:16] <ejegg>	 mepps when there's an actual error in the process, we definitely should
[18:19:35] <mepps>	 you think we shouldn't handle the timeout like another error?
[18:19:39] <ejegg>	 I just wasn't sure we should consider the expired session an error
[18:20:48] <mepps>	 hmm so we should just return a new empty instead? i guess since this is expected for some of the older records it makes sense
[18:21:45] <wikibugs>	 (PS14) Mepps: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284)
[18:22:21] <mepps>	 should we do any kind of non-error logging on the donationinterface side?
[18:23:01] <mepps>	 also did you see my fixme note? should we be adding any additional handling for when the token expires and we have a live user or is the current error handling sufficient?
[18:35:55] <ejegg>	 mepps I think for a live user we can show the donation error page
[18:36:16] <ejegg>	 they have to actually make it back to our site with a live token for us to complete the donation
[18:36:44] <ejegg>	 slightly different from the ingenico version
[18:37:16] <ejegg>	 where we can push the payment through via orphan rectifier even if they don't make it back to us
[18:37:24] <ejegg>	 errr... yeah, i think
[18:41:38] <wikibugs>	 (PS15) Ejegg: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) (owner: Mepps)
[18:41:42] <wikibugs>	 (CR) Ejegg: [C: 2] Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) (owner: Mepps)
[18:42:52] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Write browser tests for DonationInterface - https://phabricator.wikimedia.org/T176765#3918061 (Ejegg) Thanks, Seb35, I'll merge them
[18:43:16] <wikibugs>	 (Merged) jenkins-bot: Add catch statement to processDonorReturn, use timeout status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/403745 (https://phabricator.wikimedia.org/T184284) (owner: Mepps)
[18:43:42] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Write browser tests for DonationInterface - https://phabricator.wikimedia.org/T176765#3918064 (Ejegg)
[19:53:08] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-FR-Tech-Systems: Imposible to select languages on CentralNotice - https://phabricator.wikimedia.org/T185524#3918304 (MarcoAurelio)
[19:53:48] <Hauskatze>	 that ^^ is UBN! now
[20:01:35] <ejegg>	 AndyRussG: are you following that? ^^^
[20:01:57] <ejegg>	 I'm taking a look
[20:03:47] <Hauskatze>	 thanks ejegg
[20:08:55] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-FR-Tech-Systems: Imposible to select languages on CentralNotice - https://phabricator.wikimedia.org/T185524#3918284 (Ejegg) Let's see, I am seeing a warning in the console when I use the OOjs widget to deselect all:  JQMIGRATE: jQuery...
[20:14:34] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-FR-Tech-Systems: Imposible to select languages on CentralNotice - https://phabricator.wikimedia.org/T185524#3918620 (Ejegg) The hidden <select> is still getting updated when I use the OOUI widget to deselect all, then select language...
[20:15:59] <Hauskatze>	 ejegg: so the bug is valid?
[20:16:11] <Hauskatze>	 oojs instead of centralnotice maybe?
[20:16:29] <Hauskatze>	 just spotted this on CentralNotice, that's why I filed the task in that component
[20:29:21] <AndyRussG>	 ejegg: afkatze hi! just saw that, checking....
[20:29:25] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fee amount / net amount error - https://phabricator.wikimedia.org/T185045#3918685 (Eileenmcnaughton) Check https://github.com/civicrm/civicrm-core/pull/11485
[20:37:50] <wikibugs>	 Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-FR-Tech-Systems: Imposible to select languages on CentralNotice - https://phabricator.wikimedia.org/T185524#3918701 (DStrine)
[20:42:34] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Error message when no bank selected for iDEAL could be more helpful - https://phabricator.wikimedia.org/T185338#3913355 (DStrine)
[20:43:08] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Allow different order of credit cards on different country forms - https://phabricator.wikimedia.org/T185224#3918722 (DStrine)
[20:44:20] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Port back delete patch from search change - https://phabricator.wikimedia.org/T185183#3918726 (DStrine)
[20:44:39] <wikibugs>	 Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Port back delete patch from search change - https://phabricator.wikimedia.org/T185183#3908532 (DStrine)
[20:47:05] <wikibugs>	 Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-FR-Tech-Systems: Imposible to select languages on CentralNotice - https://phabricator.wikimedia.org/T185524#3918284 (AndyRussG) I was able to remove all t...
[20:48:04] <AndyRussG>	 afkatze: I fixed the test campaign hackily... I think this may be a known bug that happens with removing all or most of the elements in one of those widgets. Looking for existing tasks...
[20:49:56] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: add Partner field to summary section in donor record - https://phabricator.wikimedia.org/T185048#3918737 (DStrine)
[20:50:43] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fee amount / net amount error - https://phabricator.wikimedia.org/T185045#3918739 (Eileenmcnaughton) a:mepps>None
[20:52:02] <wikibugs>	 Fundraising Sprint Bermuda Rhombus (where things dissappear then reappear), Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Double check if we missed a donation - https://phabricator.wikimedia.org/T185041#3918742 (DStrine)
[21:19:35] <jgleeson>	 fr-tech I'm gonna jump off a little earlier than usual tonight to spend a few hours with family as I am up early tomorrow for the journey. Catch up with you all tomorrow, in person :) and hope you have a great day today!
[21:21:07] <cwd>	 safe travels jgleeson
[21:21:21] <jgleeson>	 thanks cwd, catch you later!
[21:29:35] <wikibugs>	 (PS2) Ejegg: Add __toString method for PaymentTransactionResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/376585
[22:29:10] <wikibugs>	 (PS5) Mepps: Batch look up order status for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/328858 (owner: Ejegg)
[22:29:15] <wikibugs>	 (CR) Mepps: [C: 2] Batch look up order status for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/328858 (owner: Ejegg)
[22:29:57] <wikibugs>	 (PS4) Mepps: Ignore invalid country codes from query string [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/324789 (https://phabricator.wikimedia.org/T152026) (owner: Ejegg)
[22:29:59] <wikibugs>	 (CR) Mepps: [C: 2] Ignore invalid country codes from query string [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/324789 (https://phabricator.wikimedia.org/T152026) (owner: Ejegg)
[22:31:15] <wikibugs>	 (Merged) jenkins-bot: Batch look up order status for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/328858 (owner: Ejegg)
[22:31:28] <ejegg>	 thanks mepps!
[22:31:39] <wikibugs>	 (CR) Mepps: [C: 2] Add __toString method for PaymentTransactionResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/376585 (owner: Ejegg)
[22:31:51] <wikibugs>	 (Merged) jenkins-bot: Ignore invalid country codes from query string [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/324789 (https://phabricator.wikimedia.org/T152026) (owner: Ejegg)
[22:33:28] <wikibugs>	 (Merged) jenkins-bot: Add __toString method for PaymentTransactionResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/376585 (owner: Ejegg)
[23:06:53] <AndyRussG>	 dstrine: hey... Here is the duplicate task: https://phabricator.wikimedia.org/T160819
[23:07:19] <ejegg>	 thanks for tracking that down AndyRussG !
[23:07:38] <AndyRussG>	 ejegg: thanks also for starting to check it out :)
[23:07:41] <ejegg>	 Have you had any luck understanding the code issue?
[23:07:47] <ejegg>	 I'm stumped so far
[23:07:54] <AndyRussG>	 ejegg: just getting to it....
[23:08:05] <ejegg>	 On that page, it looks like the submit button is a real form submit, not a JS thing
[23:08:19] <ejegg>	 and I can't see why the hidden select isn't making it into the POST fields
[23:09:18] <wikibugs>	 Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-FR-Tech-Systems: Imposible to select languages on CentralNotice - https://phabricator.wikimedia.org/T185524#3919083 (MarcoAurelio)
[23:09:21] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Campaign Settings - Multiselects - If all items selected and saved, further attempts to make changes to selection are not saved. - https://phabricator.wikimedia.org/T160819#3919087 (MarcoAurelio)
[23:11:05] <AndyRussG>	 ^ heh looks like someone else also found it!
[23:11:54] <AndyRussG>	 dstrine: the new task just got closed as a duplicate... I'll bring the other one into the sprint then?
[23:12:39] <dstrine>	 ok
[23:13:01] <TabbyCat>	 hey folks, that's me
[23:13:21] <TabbyCat>	 I was quietly watching and decided to merge my dupe task into the already existing one
[23:13:39] <TabbyCat>	 hope that you can find a fix soon :)
[23:14:09] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Use Composer merge plugin for payments-wiki - https://phabricator.wikimedia.org/T185547#3919124 (Ejegg) p:Triage>Normal
[23:14:55] <AndyRussG>	 TabbyCat: yep looking into it :)
[23:14:58] <AndyRussG>	 thx!
[23:15:05] <TabbyCat>	 :)
[23:15:24] <TabbyCat>	 if you excuse me, it's bed time here
[23:17:14] <AndyRussG>	 TabbyCat: cya!
[23:18:57] <AndyRussG>	 ejegg: in the POST data there's no language param sent when that happens
[23:19:12] <ejegg>	 right, which is confusing
[23:19:27] <ejegg>	 because the project_languages[] select element still does exist in the form
[23:19:34] <wikibugs>	 Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Campaign Settings - Multiselects - If all items selected and saved, further attempts to make changes to se... - https://phabricator.wikimedia.org/T160819#3919144
[23:20:01] <ejegg>	 it's hidden b/c of the OO widget, but it seems to have the right state, i.e. one option selected
[23:20:16] <ejegg>	 so I can't figure out where it's being stripped out on submit
[23:24:29] <AndyRussG>	 ejegg: which OO widget?
[23:32:10] <ejegg>	 AndyRussG: the multiselect that hides the original unstyled selector
[23:32:38] <AndyRussG>	 Ah K
[23:32:54] <AndyRussG>	 Mmmm thought u meant oojs
[23:33:45] <ejegg>	 oh, is that multiselector not OOjs, just jquery?
[23:35:20] <wikibugs>	 (PS1) Ejegg: WIP remove vendor submodule [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/405817 (https://phabricator.wikimedia.org/T185547)
[23:39:07] <wikibugs>	 (PS1) Ejegg: WIP: Remove vendor dir [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/405818 (https://phabricator.wikimedia.org/T185547)
[23:40:43] <wikibugs>	 (CR) jerkins-bot: [V: -1] WIP: Remove vendor dir [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/405818 (https://phabricator.wikimedia.org/T185547) (owner: Ejegg)
[23:48:45] <wikibugs>	 (PS2) Ejegg: WIP: Remove vendor dir [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/405818 (https://phabricator.wikimedia.org/T185547)
[23:50:13] <wikibugs>	 (CR) jerkins-bot: [V: -1] WIP: Remove vendor dir [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/405818 (https://phabricator.wikimedia.org/T185547) (owner: Ejegg)
[23:55:44] <wikibugs>	 (PS1) Ejegg: WIP merged vendor dirs for payments-wiki [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/405822 (https://phabricator.wikimedia.org/T185547)
[23:57:13] <wikibugs>	 (CR) jerkins-bot: [V: -1] WIP merged vendor dirs for payments-wiki [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/405822 (https://phabricator.wikimedia.org/T185547) (owner: Ejegg)