[00:05:18] (CR) Ejegg: [C: -1] "Aha, SysLogHandler defaults to sending UDP to localhost. I guess we need to allow it to use address=/dev/log." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/406417 (owner: Awight) [00:05:36] ejegg: my CI is failing on some composer yuckiness [00:05:38] https://integration.wikimedia.org/ci/job/wikimedia-fundraising-crm-composer-php56-jessie/1395/console [00:05:45] 23:50:05 - The requested package wikimedia/donation-interface dev-master exists as wikimedia/donation-interface[dev-REL1_25, dev-REL1_26, dev-REL1_27, dev-REL1_28, dev-REL1_29, dev-REL1_30, dev-amazon, dev-deploy-payments_1.22, dev-deployment, dev-drupal, dev-formsRefactor, dev-payWithAmazon, dev-pending_db_orphan_rectifier, dev-wmf/1.31.0-wmf.15, dev-wmf/1.31.0-wmf.16, dev-wmf/1.31.0-wmf.17, v2.1.0] but these are reje [00:05:45] cted by your constraint. [00:09:34] oh weird [00:15:10] eileen: so it's ignoring composer.lock now? [00:16:25] ejegg: hmmm [00:16:51] it's doing some special test - perhaps of composer.json validity? [00:20:16] hmm, that seems to pass with warnings, then it moves on to the next script [00:20:41] ah, it's composer update, so it's not going to respect composer.lock [00:23:49] ug [00:24:27] ejegg: fyi - I think you & Jack removed this file from our CiviCRM repo because it was not passing lint - I found out how to exclude it upstream - https://github.com/civicrm/civicrm-core/pull/11613 [00:25:10] ah, nice [00:27:09] (PS1) Eileen: Temp hack fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406965 [00:30:07] (CR) jerkins-bot: [V: -1] Temp hack fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406965 (owner: Eileen) [00:33:33] ejegg: so the issue is something in flux on that repo - I can ignore for now I think [00:33:34] (PS2) Eileen: Temp hack fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406965 [00:33:49] that commit was blocking me but Temp hack fix has sorted it for now [00:35:45] the OptionValue exception downgrade is necessary too? [00:37:11] (CR) jerkins-bot: [V: -1] Temp hack fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406965 (owner: Eileen) [00:39:59] ejegg: the OptionValue exception is temp [00:40:27] it gets the tests past the issue around the double mgd file [00:40:44] ie. https://gerrit.wikimedia.org/r/#/c/406959/ is needed to make the tests pass [00:40:58] but the temp hack allows me to get past that to the next bug for now - I ope [00:41:23] ah, got it [00:41:40] yep - brand new failures :-) https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/5930/console [00:41:46] gotta go meet a friend, but maybe I can take another look at the CI later [00:42:01] ejegg: well it's not blocking me now so just when it suits [00:42:45] k, thanks! [07:05:13] (PS1) Eileen: [wip]Remove freeResult [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406980 [07:08:49] (CR) jerkins-bot: [V: -1] [wip]Remove freeResult [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406980 (owner: Eileen) [10:58:39] (PS2) Eileen: [wip]Remove freeResult [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406980 [11:02:23] (CR) jerkins-bot: [V: -1] [wip]Remove freeResult [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406980 (owner: Eileen) [15:21:04] hey ejegg|afk, let me know when you're around [15:21:12] also good morning fr-tech! [15:29:28] morning mepps :) [15:29:38] how's it going jgleeson? [15:30:25] pretty good. Making some progress on the vagrant front [15:30:52] got a working build, and just added a patch to make dupral/civi work on php7 [15:31:09] although our payments wiki is still complaining so working on that now [15:31:37] patch for the vagrant build using master is here if you wanna try it out at your end https://gerrit.wikimedia.org/r/#/c/406953/ [15:35:29] sure though i think my issue is more my local machine [15:36:07] yeah i have the same issue [15:45:06] anything I can help with? [15:45:42] I'm gonna boot up my windows machine and test the latest round of patches on the windows build at some point today/tomorrow [15:46:03] I don't have access to a mac so that will have to slip through the net this time [15:46:19] ...actually I do have a very old macbook pro which I've just remembered [15:46:34] running snow leopard! [15:46:39] so that might be an option [15:46:50] oh nice! [15:47:04] it's seems to be a weird virtualbox issue that i'm running into [15:47:20] it says it could not create the imported medium [15:47:40] oh, not come across that one [15:48:06] haha yeah i don't know why but my machine just hates virtualbox, each time i've tried to get this going i've run into a new issue [15:49:05] are you running windows? [15:49:33] ans if so, what version [15:49:37] and* [15:49:46] no i'm running ubuntu [15:50:03] ah! [15:50:09] well that's frustrating then [15:50:50] I assumed Windows as the google results all appear to include windows paths [15:51:05] indeed jgleeson :), yeah ditto which has made the google results very unhelpful [15:54:42] hey ejegg [15:59:25] mepps: what computer do you have? [15:59:29] x1? [15:59:54] hi mepps [16:00:33] if so there is a bios setting i had to twiddle to get virtualization to work [16:01:23] lenovo thinkpad [16:01:33] mepps did your vagrant work right up till they switched to the new base OS? [16:01:36] Fundraising-Backlog: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3934278 (jgleeson) [16:01:49] no ejegg [16:01:53] it's never worked for me [16:02:00] ah, ok [16:02:17] definitely worth checking the bios! [16:02:47] oh cwd thanks, i think i looked at that a whlie ago [16:03:01] ejegg i was thinking of deploying my paypal orphan rectifier fix [16:03:35] mepps cool! [16:03:56] also there is the kernel module... virtualbox-dkms [16:04:10] let's check on the pending table [16:04:31] make sure there's not a ton of old stuff there [16:04:38] it looks like there's a bunch of commits on DonationInterface [16:05:42] mepps want to deploy thag too, or just deploy crm + donation interface lib? [16:06:01] oh hmm good idea ejegg--how do i do that again? [16:06:05] update it in packagist? [16:06:18] does di use version tags like smashpig? [16:06:45] mepps sadly not versioned yet [16:06:59] though we might have to [16:07:41] crm CI was giving funny composer errors yesterday that looked like the dev-master was the problem [16:08:31] want to try just updating dev-master first tho? [16:08:34] i saw something from packagist complaining about d-i [16:08:56] yeah it's saying it's broken [16:09:57] i'm seeing this for dev-master on packagist: Skipped branch master, Invalid package information: [16:09:58] License "GPL-2.0" is a deprecated SPDX license identifier, use "GPL-2.0-only" or "GPL-2.0-or-later" instead [16:12:00] ejegg ^^ it won't even let me update dev-master [16:12:55] ohhh [16:13:21] should i change the composer.json to use one of those? [16:13:24] well, let's update that to -or-later [16:13:44] cool [16:14:22] (PS1) Mepps: Update GPL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407024 [16:14:27] ejegg ^ [16:17:01] hellosies! [16:17:20] (CR) Ejegg: [C: 2] Update GPL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407024 (owner: Mepps) [16:17:22] hi AndyRussG! [16:17:29] hey AndyRussG :) [16:17:33] hello! [16:18:00] mepps: jgleeson ejegg :) [16:19:18] (Merged) jenkins-bot: Update GPL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407024 (owner: Mepps) [16:23:09] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Campaign Settings - Mu... - https://phabricator.wikimedia.org/T160819#3934414 [16:42:17] (PS1) Mepps: Update donationinterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407026 [16:42:35] (CR) jerkins-bot: [V: -1] Update donationinterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407026 (owner: Mepps) [16:46:26] (PS2) Mepps: Update donationinterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407026 [16:47:25] ejegg, did you resolve the missing drush package problem or did you have to postpone? [16:51:34] (CR) jerkins-bot: [V: -1] Update donationinterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407026 (owner: Mepps) [17:10:41] Fundraising-Backlog: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3934515 (jgleeson) drupal/civi patched to work with PHP7 [17:12:10] Fundraising-Backlog: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3934520 (jgleeson) Fixes added to jessie-compat branch to get build working [17:13:41] Fundraising-Backlog: Upstream link between deleted contact and merged contact - https://phabricator.wikimedia.org/T186013#3934522 (mepps) @Eileenmcnaughton can we schedule time to discuss this? [17:15:01] (CR) Ejegg: [C: -1] "Sadly, the errors are a bit useless in their provided form" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/404806 (https://phabricator.wikimedia.org/T184284) (owner: Mepps) [17:17:32] (PS3) Mepps: Update donationinterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407026 [17:19:43] (CR) jerkins-bot: [V: -1] Update donationinterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407026 (owner: Mepps) [17:32:28] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi credential for Guillaume - https://phabricator.wikimedia.org/T185953#3934579 (DStrine) I wasn't involved. Someone else usually pings her. [17:35:28] fr-tech, if you want to run the jessie-compat branch of mediawiki/vagrant, you should be able to pull down this patch over the latest branch and `vagrant up`, `vagrant role enable fundraising`, `vagrant provision` ... then be good to go. The jenkins bot is failing the build due for this to a flaky unrelated bundler dependency which I think has been introduced with the updates to stretch so I am ignoring it for [17:35:28] now. This branch and patch is kinda temporary until we get full compatibility with the latest version of master running php7 across the fr-tech stack [17:36:21] s/this patch/this patch https://gerrit.wikimedia.org/r/#/c/407031/ [18:07:31] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi credential for Guillaume - https://phabricator.wikimedia.org/T185953#3934708 (cwdent) Date: Wed, 31 Jan 2018 09:49:58 -0800 From: Lisa Gruwell To: Ca... [18:17:28] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Disappearing address info in Civi - https://phabricator.wikimedia.org/T185960#3934743 (NNichols) @Eileenmcnaughton I corrected most of them. Let me find some time today to do another once ov... [19:15:07] PROBLEM - check_puppetrun on frpm1001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:15:09] PROBLEM - check_puppetrun on pay-lvs1001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:15:09] PROBLEM - check_puppetrun on frqueue1002 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:15:09] PROBLEM - check_puppetrun on thulium is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:15:09] PROBLEM - check_puppetrun on frdb1002 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:16:19] -_- [19:20:07] PROBLEM - check_puppetrun on pay-lvs1001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:20:08] PROBLEM - check_puppetrun on frqueue1002 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:20:08] PROBLEM - check_puppetrun on frpm1001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:20:09] PROBLEM - check_puppetrun on frauth1001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:20:09] PROBLEM - check_puppetrun on civi1001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:20:10] PROBLEM - check_puppetrun on thulium is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:20:10] PROBLEM - check_puppetrun on frdb1002 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:20:11] PROBLEM - check_puppetrun on payments1001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:20:11] PROBLEM - check_puppetrun on frdev1001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:20:12] PROBLEM - check_puppetrun on frlog1001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:20:17] PROBLEM - check_puppetrun on frdb1001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [19:20:30] :) [19:20:49] (PS1) Jgleeson: PHP7 fix: only define DATE_RFC7231 if not already set [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/407043 [19:25:24] ejegg i don't know why it's not finding the FinalStatus class here: https://gerrit.wikimedia.org/r/#/c/407026/ [19:30:07] RECOVERY - check_puppetrun on frauth1001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [19:35:07] RECOVERY - check_puppetrun on frpm1001 is OK: OK: Puppet is currently enabled, last run 18 seconds ago with 0 failures [19:35:09] RECOVERY - check_puppetrun on payments1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [19:35:29] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi credential for Guillaume - https://phabricator.wikimedia.org/T185953#3934973 (cwdent) Cert sent! [19:35:55] Fundraising-Backlog: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3934975 (jgleeson) [19:36:06] Fundraising-Backlog: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3934278 (jgleeson) [19:40:07] RECOVERY - check_puppetrun on frqueue1002 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [19:40:08] RECOVERY - check_puppetrun on civi1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [19:40:08] RECOVERY - check_puppetrun on thulium is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [19:40:09] RECOVERY - check_puppetrun on frdb1002 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [19:45:07] RECOVERY - check_puppetrun on frlog1001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [19:45:08] RECOVERY - check_puppetrun on frdev1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [19:45:17] RECOVERY - check_puppetrun on frdb1001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [19:50:07] RECOVERY - check_puppetrun on pay-lvs1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [19:58:03] Jeff_Green, cwd I'm putting all my changes relating to vagrant patches in one place for now until their approved / complete. If you spot anything obvious that I'm doing wrong with puppet, feel free to shout https://phabricator.wikimedia.org/T186119#3934520 [19:58:15] they're* [19:58:27] cool! [19:58:29] will check it out [19:59:42] jgleeson: cool [20:01:05] I know you don't use vagrant much but I figure you will know more than me about puppet and in particular the weird scope thingy with hiera that I keep tripping myself up on [20:01:44] we actually don't use hiera in FR :S [20:02:49] ah [20:02:50] lol [20:03:43] mostly because of weird scope thingies :) [20:04:34] one thing I am unsure on is fixes to specific projects to provide support for PHP7, that we only benefit from or see in a development environment. I wonder what fr-tech in general thing about this and whether we should be "polluting" the code with fixes that aren't required in production, at least until we move to php7 [20:04:52] think* [20:06:24] i do not think it's too early to start enumerating that stuff [20:06:45] i think we can be on php7 by the next fundraiser [20:07:00] barring unforeseen complications [20:08:52] are there other areas of the foundation running php7? [20:10:40] this is an excellent question [20:11:32] :) just asked in operations [20:11:33] my guess is we're probably starting to work with it on peripheral services, but afaik mediawiki is still on hiphop [20:11:52] * Jeff_Green watches there curiously... [20:13:00] * Jeff_Green is perturbed by hhvm vs hiphop vs hphpc [20:14:18] well the good news is that it's dead [20:38:28] calling it a night fr-tech. Bye all [20:44:21] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi credential for Guillaume - https://phabricator.wikimedia.org/T185953#3935215 (Eileenmcnaughton) He should have his account email now [20:57:40] mepps: re merge activities. I'm trying to get us onto latest release now - I think maybe we should discuss that one next week or even the following one - once our code is nice & close again [21:07:43] ejegg you around? [21:13:48] hi, sorry! [21:15:08] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi credential for Guillaume - https://phabricator.wikimedia.org/T185953#3935305 (gpaumier) Yep, everything looks good. Thank you everyone! [21:22:55] hey, i'm pretty stuck on this crm deploy [21:23:04] i'm not sure why it can't find the final status class [21:24:54] mepps taking a look [21:27:24] mepps ohhhh, we need to point that test at the SmashPig version! [21:27:45] it's no longer in DonationInterface / global namespace [21:29:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: help with PDF letter formatting - https://phabricator.wikimedia.org/T186159#3935377 (Eileenmcnaughton) [21:30:06] (PS4) Ejegg: Update donationinterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407026 (owner: Mepps) [21:31:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: help with PDF letter formatting - https://phabricator.wikimedia.org/T186159#3935392 (Eileenmcnaughton) [21:31:54] ejegg i think i did that [21:32:18] oh wait hmm, maybe it's that i didn't include the \ before SmashPig? [21:32:20] There was one place using the class within a CRM test [21:32:31] you took care of everything in DonationInterface [21:32:36] ohhhh [21:32:39] this is a crm test? [21:32:42] got ti [21:32:42] yah [21:32:44] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Add w2khtml pdf generator to CiviCRM server - https://phabricator.wikimedia.org/T186160#3935393 (Eileenmcnaughton) [21:33:20] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi credential for Guillaume - https://phabricator.wikimedia.org/T185953#3935405 (Eileenmcnaughton) great & welcome! [21:33:28] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi credential for Guillaume - https://phabricator.wikimedia.org/T185953#3935406 (Eileenmcnaughton) Open>Resolved a:Eileenmcnaughton [21:34:17] (PS5) Mepps: Update donationinterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407026 [21:34:58] sorry, i had rushed in and submitted another identical revision [21:43:04] mepps build succeeded! [21:43:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Process greeings for Major Gifts contacts - https://phabricator.wikimedia.org/T186162#3935425 (Eileenmcnaughton) [21:50:21] this one is review ready - https://gerrit.wikimedia.org/r/#/c/404329/ [21:51:22] (CR) Ejegg: [C: 2] Update donationinterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407026 (owner: Mepps) [21:54:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add yearly totals to WMF donor table - https://phabricator.wikimedia.org/T186165#3935472 (DStrine) [21:55:03] (Merged) jenkins-bot: Update donationinterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407026 (owner: Mepps) [21:56:02] (PS1) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/407154 [21:56:44] (CR) Mepps: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/407154 (owner: Mepps) [21:58:08] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/407154 (owner: Mepps) [21:58:45] ejegg i'm thinking of going ahead and deploying that crm update but i'm only around for the next half an hour [21:59:12] mepps I can keep an eye out for errors and roll back if needed [21:59:24] let's check on that pending table... [22:04:16] !log updated civicrm from c70f01cd83 to 63c918837c [22:04:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:05:14] mepps ah shoot, vendor submodule update missing? [22:05:58] ahh [22:07:02] where did you see that ejegg? [22:07:12] ejegg: mepps can I put reviewing adding Civitoken on one of your to-do lists since it seems to be OK by MG https://gerrit.wikimedia.org/r/#/dashboard/self [22:07:18] (or XenoRyet [22:07:21] yup! [22:07:27] eileen ^ [22:07:33] thanks mepps [22:07:47] mepps I just didn't see the update in the IRC feed [22:08:02] ejegg ? [22:08:05] what do you mean [22:08:09] the github for the extension is here - https://github.com/eileenmcnaughton/nz.co.fuzion.civitoken [22:08:49] i rolledback because i thought you were reporting an error ejgg [22:08:52] ejegg [22:09:14] mepps we need to update the dependencies in the vendor submodule [22:09:26] because we changed the composer.lock [22:10:10] So on the deploy branch, composer install --no-dev [22:10:18] then in vendor, check in all the changes [22:10:43] (if dev stuff is left over, you may want to nuke the submodule and re-init it first) [22:10:44] hmm it's not registering a git directory in vendor, do i need to add one? [22:11:03] mepps so, vendor submodule only exists on the deploy branch [22:11:15] yeah i'm on the deployment branch [22:11:23] huh [22:11:39] maybe nuke vendor and do a composer submodule update --init [22:12:24] it looks like doing that with git submodule update --init is working :) [22:12:32] ah, great! [22:14:09] i'm getting a message that i'm unauthorized to open a review for crm/vendor [22:15:21] checking permissions [22:16:09] weird, it says "Rights Inherit From: wikimedia/fundraising/crm" [22:16:37] maybe it's checked out anonymous because of being a submodule? [22:16:48] I can push the change if you just want to get on with the deploy [22:17:12] (PS1) Ejegg: Update DI and SmashPig libs [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/407156 [22:17:21] maybe ejegg--it keeps asking me for my username and password--but yeah sure [22:17:32] mepps want to test your +2 on that? [22:17:43] (CR) Mepps: [C: 2] Update DI and SmashPig libs [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/407156 (owner: Ejegg) [22:17:49] looks like i can do that [22:22:32] (Merged) jenkins-bot: Update DI and SmashPig libs [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/407156 (owner: Ejegg) [22:24:47] (PS1) Eileen: Add module_load_include to the DonationQueueTest & OrphanSlayerTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407158 [22:24:49] (PS1) Eileen: Call parent::setUp before AddressTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407159 [22:25:16] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/406959 (https://phabricator.wikimedia.org/T148955) (owner: Eileen) [22:25:23] (PS1) Ejegg: Update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/407160 [22:25:27] (PS1) Mepps: Updated vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/407161 [22:25:29] (CR) Ejegg: [C: 2] Update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/407160 (owner: Ejegg) [22:25:38] oh haha i saw you already got there ejegg [22:25:43] oops, I collided again mepps! [22:26:33] (Merged) jenkins-bot: Update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/407160 (owner: Ejegg) [22:28:20] log !updated civicrm from c70f01cd83 to 849bba4186 [22:28:23] oops [22:28:33] !log updated civicrm from c70f01cd83 to 849bba4186 [22:28:43] okay ejegg i gotta run [22:28:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:29:07] I'll keep an eye on things [22:29:16] see ya mepps! [22:30:16] XenoRyet: want to look over the civitoken extension in a live session? [22:30:50] Could be a nice study for other civi-ization of our drupal stuff [22:31:16] I have some very trivial changes that it would be good to get merged - affecting tests [22:31:35] ejegg: let me know if you want me to join that session [22:31:39] https://gerrit.wikimedia.org/r/#/c/407158/ [22:31:51] https://gerrit.wikimedia.org/r/#/c/406959/ [22:32:04] https://gerrit.wikimedia.org/r/#/c/407159/ [22:32:23] cool, that test one seems straightforward [22:34:05] (CR) Ejegg: [C: 2] Add module_load_include to the DonationQueueTest & OrphanSlayerTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407158 (owner: Eileen) [22:36:09] (PS4) Ejegg: Remove redundant files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/406959 (https://phabricator.wikimedia.org/T148955) (owner: Eileen) [22:36:20] (PS2) Ejegg: Add module_load_include to the DonationQueueTest & OrphanSlayerTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407158 (owner: Eileen) [22:36:30] (CR) Ejegg: [C: 2] Remove redundant files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/406959 (https://phabricator.wikimedia.org/T148955) (owner: Eileen) [22:38:18] (PS2) Ejegg: Call parent::setUp before AddressTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407159 (owner: Eileen) [22:39:19] (CR) Ejegg: [C: 2] Call parent::setUp before AddressTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407159 (owner: Eileen) [22:40:06] (Merged) jenkins-bot: Remove redundant files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/406959 (https://phabricator.wikimedia.org/T148955) (owner: Eileen) [22:40:18] thanks ejegg [22:40:40] ty for the fixes! [22:41:27] (Merged) jenkins-bot: Add module_load_include to the DonationQueueTest & OrphanSlayerTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407158 (owner: Eileen) [22:41:35] some of those things I've been hacking around for a whiel now :-) - the module load include stuff has hit me locally & I've just deleted the tests to run locally rather than fixing [22:42:27] huh, I guess we autoloaded them with the phpunit xml maybe? [22:42:58] (Merged) jenkins-bot: Call parent::setUp before AddressTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407159 (owner: Eileen) [22:43:16] it's something to do with the drupal registry [22:43:48] but if they aren't in the registry it may not find them - for some reason orphanslayer wasn't even after clear caches [22:44:22] (PS3) Eileen: [wip]Remove freeResult [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406980 [22:46:49] https://files.mastodon.social/media_attachments/files/002/737/164/original/c91174a2b70dcb77.png [22:47:37] :-) [22:50:10] (PS1) Ejegg: Add library dependency [wikimedia/fundraising/crm/drush] - https://gerrit.wikimedia.org/r/407167 [22:50:17] (CR) Ejegg: [C: 2] Add library dependency [wikimedia/fundraising/crm/drush] - https://gerrit.wikimedia.org/r/407167 (owner: Ejegg) [22:50:27] (CR) Ejegg: [V: 2 C: 2] Add library dependency [wikimedia/fundraising/crm/drush] - https://gerrit.wikimedia.org/r/407167 (owner: Ejegg) [22:50:49] ohh that's exciting - I got the tests passing on the latest civi (with some temp hacks still in play but…) [22:51:01] nice! [22:51:02] others removed…