[00:11:37] slow query by user 181 [04:15:05] (Abandoned) Eileen: Temp debug [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406956 (owner: Eileen) [04:15:19] (Abandoned) Eileen: Temp hack fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406965 (owner: Eileen) [04:15:25] Fundraising-Backlog, MediaWiki-Vagrant: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3936108 (bd808) [04:16:07] (PS2) Eileen: Stock civicrm 4.7.31(rc) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406955 [04:16:13] (PS1) Eileen: CRM-19798 fix memory leak on EntityTag.get [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407195 [04:18:28] (Abandoned) Eileen: [wip]Remove freeResult [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406980 (owner: Eileen) [04:19:36] (CR) jerkins-bot: [V: -1] Stock civicrm 4.7.31(rc) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406955 (owner: Eileen) [04:21:30] (CR) jerkins-bot: [V: -1] CRM-19798 fix memory leak on EntityTag.get [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407195 (owner: Eileen) [04:30:03] (PS1) Eileen: Temp hack fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407196 [04:32:56] (CR) jerkins-bot: [V: -1] Temp hack fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407196 (owner: Eileen) [07:03:39] (PS1) Legoktm: Use SPDX 3.0 license identifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) [07:03:58] (PS2) Legoktm: Use SPDX 3.0 license identifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) [07:04:32] (CR) Legoktm: "Is this supposed to be GPL-2.0-only? I would have thought it would be -or-later, as most WMF-developed extensions are." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [07:05:27] (PS1) Legoktm: Use SPDX 3.0 license identifier [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/407291 (https://phabricator.wikimedia.org/T183858) [07:05:35] (PS1) Legoktm: Use SPDX 3.0 license identifier [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/407292 (https://phabricator.wikimedia.org/T183858) [07:05:38] (PS1) Legoktm: Use SPDX 3.0 license identifier [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/407293 (https://phabricator.wikimedia.org/T183858) [07:13:14] (PS1) Legoktm: Use SPDX 3.0 license identifier [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/407343 (https://phabricator.wikimedia.org/T183858) [07:51:46] (CR) jerkins-bot: [V: -1] Use SPDX 3.0 license identifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [08:18:48] (PS1) Eileen: Apply drupal formatting to DonationQueueTest.php [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407387 [08:27:51] (PS1) Eileen: Adjust test to not create duplicate option values. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407389 [08:29:08] (PS1) Eileen: Apply drupal formatting (using IDE) to BaseWmfDrupalPhpUnitTestCase.php [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407390 [10:39:22] (CR) Thiemo Kreuz (WMDE): [C: 2] Use SPDX 3.0 license identifier [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/407291 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [10:39:23] (CR) Thiemo Kreuz (WMDE): [C: 2] Use SPDX 3.0 license identifier [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/407293 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [10:42:28] (CR) Thiemo Kreuz (WMDE): [C: 2] Use SPDX 3.0 license identifier [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/407343 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [10:55:51] (CR) Thiemo Kreuz (WMDE): [C: 2] Use SPDX 3.0 license identifier [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/407292 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [11:28:21] (Merged) jenkins-bot: Use SPDX 3.0 license identifier [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/407291 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [11:28:45] (Merged) jenkins-bot: Use SPDX 3.0 license identifier [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/407293 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [11:35:14] (Merged) jenkins-bot: Use SPDX 3.0 license identifier [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/407343 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [12:02:05] (Merged) jenkins-bot: Use SPDX 3.0 license identifier [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/407292 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [12:43:33] Fundraising-Backlog, MediaWiki-Vagrant: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3937240 (jgleeson) [12:45:13] Fundraising-Backlog, MediaWiki-Vagrant: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3934278 (jgleeson) [12:58:33] Fundraising-Backlog, MediaWiki-Vagrant: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3937311 (jgleeson) p:Triage>Normal [13:07:09] Fundraising-Backlog, MediaWiki-Vagrant: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3937325 (jgleeson) [13:07:45] Fundraising-Backlog, MediaWiki-Vagrant: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3934278 (jgleeson) [15:13:56] Fundraising-Backlog, MediaWiki-Vagrant: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3937689 (jgleeson) [15:22:00] Wikimedia-Fundraising-Campaigns, Wikimedia-CentralNotice-Administration (Q1-2018): WMF Fundraising 2017-18 - Sweden banners (6 Feb - 6 Mar) - https://phabricator.wikimedia.org/T186223#3937712 (Pcoombe) [15:22:51] Wikimedia-Fundraising-Campaigns, Wikimedia-CentralNotice-Administration (Q1-2018): WMF Fundraising 2017-18 - Italy banners (28 Feb - 28 Mar) - https://phabricator.wikimedia.org/T186224#3937723 (Pcoombe) [15:30:25] (CR) Mepps: [C: 1] "This mostly looks pretty straightforward but see a couple notes in the wmf_civicrm install script." (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/404329 (https://phabricator.wikimedia.org/T184647) (owner: Eileen) [15:39:31] (CR) Mepps: [C: 2] Apply drupal formatting (using IDE) to BaseWmfDrupalPhpUnitTestCase.php [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407390 (owner: Eileen) [15:52:11] ejegg|afk, i'm doing more review of this outage documentation, and i'm curious, do you mind if i just edit it or should i keep putting my notes in etherpad for now? [16:21:32] Wikimedia-Fundraising: Create translated versions of new Thank You page - https://phabricator.wikimedia.org/T185333#3937942 (schoenbaechler) I created a [multilingual TY page template](https://wikimediafoundation.org/w/index.php?title=Template:Thank_You_2018&action=edit) and a corresponding [English translat... [16:30:13] fr-tech dstrine-away looks like standup overlaps with a FR retro? [16:30:20] also, morningsies! [16:40:09] Fundraising-Backlog: centralnotice_analytics: Complete inline documentation - https://phabricator.wikimedia.org/T186232#3937999 (AndyRussG) [16:43:31] Fundraising-Backlog: centralnotice_analytics: simple Hive integration - https://phabricator.wikimedia.org/T186233#3938026 (AndyRussG) [16:46:03] Fundraising-Backlog: centralnotice_analytics: tests and sample data - https://phabricator.wikimedia.org/T186234#3938039 (AndyRussG) [16:58:38] Wikimedia-Fundraising: Create translated versions of new Thank You page - https://phabricator.wikimedia.org/T185333#3938065 (schoenbaechler) ... also adding @kaythaney to the discussion here! 👋 [16:59:53] Fundraising-Backlog: Create Phabricator task for Fundraising analytics tasks - https://phabricator.wikimedia.org/T186236#3938082 (AndyRussG) [17:08:05] AndyRussG: Katie and I cannot attend standup or the retro [17:08:26] Annual planning meeting thing [17:08:34] ah k have fun!! [17:08:46] thx! [17:17:53] (CR) Mepps: [C: 2] Apply drupal formatting to DonationQueueTest.php [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407387 (owner: Eileen) [17:21:25] (Merged) jenkins-bot: Apply drupal formatting to DonationQueueTest.php [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407387 (owner: Eileen) [17:28:09] (CR) Mepps: Adjust test to not create duplicate option values. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407389 (owner: Eileen) [19:30:52] cwd: Can I get your opinion on some… code? [19:30:53] https://gerrit.wikimedia.org/r/#/c/406417/5/process/log.py [19:30:56] line 56 [19:31:50] you know i've always got opinions! [19:32:00] Python defaults to udp://localhost:514, how is frack set up though? [19:32:05] lol [19:32:26] For dev machines it’s easiest to use the /dev/log FIFO [19:33:12] I seem to remember frack uses TCP, though? Should we make this configurable? [19:33:13] for what now? syslog? [19:33:17] yup [19:33:32] ah, lessee [19:34:42] yeah 6514/tcp [19:35:50] I think my net frozez, brb [19:42:32] cwd: OK cool, that settles it. This will have to be configurable. [19:44:30] awight: are you gonna use p-c outside of fundraising? [19:44:43] nah, although I kind of like it [19:45:03] I did just write another job queue for a side project. Felt pretty stupid [19:45:22] pgsql backing, deduplication for (user, job_name) [19:45:32] prioritization, queue_at_time [19:45:33] ugh [19:45:55] Libraries felt too heavyweight until I actually started writing tha durn thing [19:46:52] (CR) Awight: "I agree, let's make it configurable." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/406417 (owner: Awight) [19:47:02] cwd: The syslog Qs are for a random atonement thing: https://gerrit.wikimedia.org/r/#/projects/wikimedia/fundraising/tools,dashboards/default [19:49:10] ejegg: o/ [19:49:15] nice man [19:49:26] yeah p-c is still working great for us [19:49:29] Making the syslog address configurable is begging all kinds of questions... [19:49:31] thanks awight ! [19:49:39] cwd: hehe anything is better than Jerkins [19:51:18] My biggest question is, if there’s global configuration across fr-tools apps, maybe we should be merging multiple config files? [19:52:28] I guess it doesn’t matter much for production, since everything is templated. [19:53:00] The fastest change is that I just drop in a syslog address config key [19:53:41] How much stuff is even being used in fr-tools? Time to wipe the cruft? [19:54:01] it's down to just a few things [19:54:14] banner_screenshot, civicrm, fundraising_ab_tests, google, live_analysis [19:54:16] I think the audit downloaders are used across a few gateways [19:54:16] yeeeah… [19:54:27] and paypal audit parser [19:54:35] lessee, that plus the silverpop exporter [19:54:37] hargh, I thought that had a stupid PHP port [19:55:00] (the paypal audit parser) [19:55:09] nope, it's the only one that doesn't [19:55:36] hmm, maybe the stats gen too? [19:56:55] K, I’ll put less effort into these patches ;-) [19:57:17] yep, that too. So: audit downloads, paypal audit parse, public stats export, and silverpop [19:57:24] IMO we should git rm -r anything that’s unused [19:57:52] yeah [19:59:21] Or, anything that’s going to stay alive long-term should be its own repo and require a utils package [19:59:42] * awight is secretly here to erase tech debt with rm -rf :p [20:00:02] oh dang, I have a meeting right now about how my pay is being cut 58% [20:00:04] biab [20:00:09] good luck [20:00:21] ! [20:20:21] * awight hollers into the wind for a bit [20:21:36] (CR) Ejegg: [C: 2] PHP7 fix: only define DATE_RFC7231 if not already set [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/407043 (owner: Jgleeson) [20:28:06] (Merged) jenkins-bot: PHP7 fix: only define DATE_RFC7231 if not already set [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/407043 (owner: Jgleeson) [20:29:16] (PS2) Eileen: Adjust test to not create duplicate option values. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407389 [20:29:40] (CR) Eileen: "Good point - in fact it turns out there was some value in one of them so I tweaked for that" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407389 (owner: Eileen) [20:30:07] (PS2) Eileen: Apply drupal formatting (using IDE) to BaseWmfDrupalPhpUnitTestCase.php [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/407390 [20:34:13] (CR) Eileen: Add civitoken extension. (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/404329 (https://phabricator.wikimedia.org/T184647) (owner: Eileen) [20:36:08] mepps I'm going to talk to Leanne later on about formatting her pdf letters - just wondering if you used to recommend tables at agh or got by with 'normal' formatting. I managed to enable 'justify' in ckeditor - so we can align the date right so I might try without tables first [20:36:45] (PS2) Mepps: Add civitoken extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/404329 (https://phabricator.wikimedia.org/T184647) (owner: Eileen) [20:36:47] (CR) Mepps: [C: 2] Add civitoken extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/404329 (https://phabricator.wikimedia.org/T184647) (owner: Eileen) [20:37:45] we usually did fine with the "normal" formatting eileen [20:40:20] (Merged) jenkins-bot: Add civitoken extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/404329 (https://phabricator.wikimedia.org/T184647) (owner: Eileen) [20:41:54] mepps: thansk [20:41:56] thanks [20:50:06] awight: https://www.nytimes.com/2018/02/01/world/americas/perus-nazca-lines-damaged.html [20:52:47] :( [20:54:19] Fundraising-Backlog, MediaWiki-Vagrant: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3939142 (jgleeson) [20:58:21] needs to quit drinking so much [21:15:37] hey fr-tech, I figured out why we couldn't get the payments forms to load on the successful vagrant builds, it was to do with the wiki's stepping on each other due to not starting the builds from a clean state. I've added some more notes here: https://phabricator.wikimedia.org/T186119. Summary of today is... Jessie is working end-to-end with payment forms! Stretch is not.. but I know why so will pick up [21:15:37] tomorrow and fix. We should then be able to run php7 locally and xdebug should work out of the box. I'm calling it a day, catch you all tomorrow o/ [21:16:33] woohoo! [21:18:26] (PS6) Awight: Deprecate weird custom logging, leave shim [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/406417 [21:18:57] * awight takes a sink shower after that patch [21:44:00] (CR) Ejegg: [C: 1] "Totally works with /dev/log and TCP! TCP output is a little ugly, looking for a workaround." (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/406417 (owner: Awight) [21:45:10] ejegg: At this point, we might as well configure logging with a dict and cut as much as possible from the CLI helper? [21:45:32] cli helper? [21:45:37] you mean process-control? [21:45:55] https://docs.python.org/2/library/logging.config.html#logging.config.dictConfig [21:46:07] I mean fr-tools/process/log.py [21:46:21] although… generally friends don’t let friends rely on python logging.config [21:46:34] really? [21:46:59] is django's logging config just that, or is it dressed up some? [21:48:24] awight: hmm, yeah, if we're standardizing logging, let's go with standard config too! [21:50:35] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/407561 [21:51:39] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/407561 (owner: Ejegg) [21:51:50] ejegg: Yeah AFAIK Django’s logging is logging.config.dictConfig [21:52:01] cool, I’ll try that patch [21:52:04] cool, that's not too horrid [21:52:15] What do you think about the CLI hacks, though [21:52:30] e.g. emitting to stdout only if stdout is a tty? [21:52:36] oh, you mean the output to console? [21:52:56] Yeah, I was shooting for a no-op, but if you say the word I’ll just tear out the cruft [21:53:16] looking to see if we use the 'quiet' flag anywhere [21:54:12] hehe [21:54:23] I feel like it’s set everywhere [21:54:53] seems like no... [21:55:14] so yeah, we can just put the console handler in the config dict [21:55:49] aha ok [21:56:02] or... can we tell it to hit stdout? hmm [21:56:32] yep: stream: ext://sys.stdout [21:56:49] yah I have some copypasta dough sitting nearby [21:57:08] thanks again! [21:57:15] :D [21:57:52] (PS1) Ejegg: Update SmashPig library [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/407562 [21:58:03] (CR) Ejegg: [C: 2] Update SmashPig library [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/407562 (owner: Ejegg) [21:59:58] (CR) Ejegg: [V: 2 C: 2] Update SmashPig library [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/407562 (owner: Ejegg) [22:00:17] ejegg: One thing in case I forget it. We’re prepending app name in order to tickle custom regexes in rsyslog. That might have to be kludged into each app’s formatter config. [22:00:26] (PS2) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/407561 [22:00:55] awight: OK, roger that. I'll take it into account for deploy [22:01:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Add w2khtml pdf generator to CiviCRM server - https://phabricator.wikimedia.org/T186160#3939384 (Jgreen) There are Debian packages for this, none look terribly new: Jessie 0.12.1-2 Stretch 0.12.3.2-3 civi1001 is Jessie,... [22:02:03] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/407561 (owner: Ejegg) [22:03:06] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/407561 (owner: Ejegg) [22:04:07] mepps: I'm about to deploy some DonationInterface changes, including your update to the PayPal express return handling [22:05:51] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407563 [22:06:11] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407563 (owner: Ejegg) [22:06:24] oops, that needs a rebase [22:07:19] ah, no, that was a conflicts-with, not a depends-on [22:07:27] it's good [22:11:06] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407563 (owner: Ejegg) [22:16:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Add w2khtml pdf generator to CiviCRM server - https://phabricator.wikimedia.org/T186160#3939395 (Eileenmcnaughton) I think that would be fine - we've been using this for years on non-wmf servers so must have been using old vers... [22:17:58] (PS1) Ejegg: Use ValidationAction constants from SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407564 (https://phabricator.wikimedia.org/T163868) [22:22:48] (PS7) Awight: Deprecate weird custom logging, leave shim [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/406417 [22:22:56] (PS1) Ejegg: Use PaymentError from SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407565 (https://phabricator.wikimedia.org/T163868) [22:23:36] That felt good [22:23:52] Sort of like working a wooden stake back and forth in the logging code [22:24:41] (PS4) Awight: Refactor log usage to normal Python library [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/406480 [22:24:43] (PS5) Awight: Remove logging shim [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/406481 [22:24:55] :) [22:26:18] Any roadmapping for AI antifraud? [22:26:33] heh, just came up in a meeting today, actually [22:26:45] O_O [22:26:57] might have to cut down on minfraud use for EU data privacy [22:27:09] and I was suggesting the old machine learning on our own thing [22:27:24] but it's still pie in the sky [22:27:34] till there's some legal urgency [22:28:57] Most of the stuff you’d need is available off the shelf, and IMO there’s a good argument for Scoring Platform to generalize our service, so you wouldn’t be on your own. [22:29:06] :) [22:29:16] (PS2) Ejegg: Use PaymentError from SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407565 (https://phabricator.wikimedia.org/T163868) [22:30:00] (PS1) Ejegg: Use ValidationError from SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407566 (https://phabricator.wikimedia.org/T163868) [22:33:06] Small change that would probably improve the fr-tools config: merge /config/*.yaml with /etc/fundraising/common.yaml with /etc/fundraising//*.yaml [22:33:14] Most of all, I just want to type “fundraiding” every time [22:33:36] gtg o/ [22:33:40] see ya! [22:37:30] !log updated payments-wiki from 40145892e7 to 341cb573a1 [22:37:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:40:39] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Ingenico cc-vmaj form does not have expec... - https://phabricator.wikimedia.org/T185035#3904098 [22:42:49] XenoRyet: T160819 might be a good entry point into CentralNotice [22:42:49] T160819: CentralNotice: Campaign Settings - Multiselects - If all items selected and saved, further attempts to make changes to selection are not saved. - https://phabricator.wikimedia.org/T160819 [22:43:15] pretty small fix for the issue at hand, but it branches off into a few other things you could tackle to get a feel for the repo [22:47:10] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Winter Wanderland, and 2 others: make a wiki page f... - https://phabricator.wikimedia.org/T181652#3939519 [22:54:37] (CR) Ejegg: [C: 2] "Does the trick!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/406417 (owner: Awight) [22:55:06] (Merged) jenkins-bot: Deprecate weird custom logging, leave shim [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/406417 (owner: Awight) [23:01:48] (CR) Ejegg: [C: -1] "Doesn't seem to work correctly. I think the logging.getLogger calls have to come after the load_config calls now." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/406480 (owner: Awight) [23:09:06] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/407569 [23:09:53] ejegg: mepps XenoRyet Leanne has tested https://gerrit.wikimedia.org/r/#/c/399252/ on staging & says it is good so if anyone is up to review at some point [23:10:16] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/407569 (owner: Eileen) [23:11:14] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/407569 (owner: Eileen) [23:11:35] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Winter Wanderland, and 3 others: Different currenci... - https://phabricator.wikimedia.org/T182808#3939571 [23:12:57] !log update civicrm revision changed from 849bba4186 to 71b1e35b99 (deploy civitoken) [23:13:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:17:10] eileen: Sure, I can take a look now [23:26:31] ejegg: thanks - no pressure [23:26:59] it's been there a while & Leanne doesn't have a file yet - but I was holding off seeking review until she tested [23:27:52] (which she has done now) [23:30:47] eileen: so the USD Total and Original Currency Total are the totals for the whole spreadsheet? [23:38:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Process greeings for Major Gifts contacts - https://phabricator.wikimedia.org/T186162#3939633 (Eileenmcnaughton) [23:38:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: improve MG mailing process - https://phabricator.wikimedia.org/T179882#3939632 (Eileenmcnaughton) [23:38:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Add w2khtml pdf generator to CiviCRM server - https://phabricator.wikimedia.org/T186160#3939635 (Eileenmcnaughton) [23:38:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: improve MG mailing process - https://phabricator.wikimedia.org/T179882#3739248 (Eileenmcnaughton) [23:40:15] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: help with PDF letter formatting - https://phabricator.wikimedia.org/T186159#3939636 (Eileenmcnaughton) [23:41:04] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: help with PDF letter formatting - https://phabricator.wikimedia.org/T186159#3935377 (Eileenmcnaughton) we got right align - but the image upload needs a look [23:41:12] ejegg: yep they are [23:41:32] it doesn't verify but it uses them to calc exchange rate [23:42:01] (by verify I mean - it's doesn't check the total against it - might be nice but not in scope here) [23:47:03] (CR) Ejegg: [C: -1] "Nicely done! One breaking typo, some optional stuff and suggestions for later." (7 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/399252 (https://phabricator.wikimedia.org/T182808) (owner: Eileen)