[00:04:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Add ability to create labels to contribution search - https://phabricator.wikimedia.org/T186282#3939699 (Eileenmcnaughton) [00:08:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: add ability to search for 'has email' to contribution search - https://phabricator.wikimedia.org/T185053#3939714 (Eileenmcnaughton) And / or add ability to suppress address block if email present [00:20:40] (PS8) Eileen: Allow Benevity currencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/399252 (https://phabricator.wikimedia.org/T182808) [00:20:55] (CR) Eileen: "Thanks - I've fixed all the easy things...." (5 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/399252 (https://phabricator.wikimedia.org/T182808) (owner: Eileen) [01:45:13] PROBLEM - check_ssl on civi1001 is CRITICAL: SSL CRITICAL - Certificate civicrm.wikimedia.org valid until 2018-02-09 01:41:03 +0000 (expires in 6 days) [01:45:14] PROBLEM - check_ssl on mintaka is CRITICAL: SSL CRITICAL - Certificate civicrm.wikimedia.org valid until 2018-02-09 01:41:03 +0000 (expires in 6 days) [01:50:04] PROBLEM - check_ssl on civi1001 is CRITICAL: SSL CRITICAL - Certificate civicrm.wikimedia.org valid until 2018-02-09 01:41:03 +0000 (expires in 6 days) [01:50:13] PROBLEM - check_ssl on mintaka is CRITICAL: SSL CRITICAL - Certificate civicrm.wikimedia.org valid until 2018-02-09 01:41:03 +0000 (expires in 6 days) [01:55:13] PROBLEM - check_ssl on civi1001 is CRITICAL: SSL CRITICAL - Certificate civicrm.wikimedia.org valid until 2018-02-09 01:41:03 +0000 (expires in 6 days) [01:55:14] PROBLEM - check_ssl on mintaka is CRITICAL: SSL CRITICAL - Certificate civicrm.wikimedia.org valid until 2018-02-09 01:41:03 +0000 (expires in 6 days) [02:00:13] PROBLEM - check_ssl on civi1001 is CRITICAL: SSL CRITICAL - Certificate civicrm.wikimedia.org valid until 2018-02-09 01:41:03 +0000 (expires in 6 days) [02:00:23] PROBLEM - check_ssl on mintaka is CRITICAL: SSL CRITICAL - Certificate civicrm.wikimedia.org valid until 2018-02-09 01:41:03 +0000 (expires in 6 days) [02:05:03] PROBLEM - check_ssl on civi1001 is CRITICAL: SSL CRITICAL - Certificate civicrm.wikimedia.org valid until 2018-02-09 01:41:03 +0000 (expires in 6 days) [02:05:23] PROBLEM - check_ssl on mintaka is CRITICAL: SSL CRITICAL - Certificate civicrm.wikimedia.org valid until 2018-02-09 01:41:03 +0000 (expires in 6 days) [02:05:44] ACKNOWLEDGEMENT - check_ssl on mintaka is CRITICAL: SSL CRITICAL - Certificate civicrm.wikimedia.org valid until 2018-02-09 01:41:03 +0000 (expires in 6 days) Casey Dentinger we know [02:06:18] ACKNOWLEDGEMENT - check_ssl on civi1001 is CRITICAL: SSL CRITICAL - Certificate civicrm.wikimedia.org valid until 2018-02-09 01:41:03 +0000 (expires in 6 days) Casey Dentinger thanks will update [04:36:19] (PS3) Eileen: Stock civicrm 4.7.31(rc) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406955 [04:36:20] (PS1) Eileen: Accumulated WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407579 [04:40:00] (CR) jerkins-bot: [V: -1] Stock civicrm 4.7.31(rc) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406955 (owner: Eileen) [04:42:54] (CR) jerkins-bot: [V: -1] Accumulated WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407579 (owner: Eileen) [04:57:48] (PS1) Eileen: Try redirect hook (with guzzle) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407581 [05:01:30] (CR) jerkins-bot: [V: -1] Try redirect hook (with guzzle) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407581 (owner: Eileen) [13:52:23] Fundraising-Backlog, MediaWiki-Vagrant: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3940940 (jgleeson) [15:03:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: improve MG mailing process - https://phabricator.wikimedia.org/T179882#3941014 (Jgreen) [15:03:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Add w2khtml pdf generator to CiviCRM server - https://phabricator.wikimedia.org/T186160#3941012 (Jgreen) Open>Resolved >>! In T186160#3939395, @Eileenmcnaughton wrote: > I think that would be fine - we've been using thi... [15:56:36] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Ingenico cc-vmaj form does not have expec... - https://phabricator.wikimedia.org/T185035#3941119 [16:09:32] fundraising-tech-ops, Operations, monitoring: ssl monitoring: add civicrm.wikimedia.org to icinga - https://phabricator.wikimedia.org/T186328#3941156 (RobH) p:Triage>High [16:13:24] hey ejegg, currently reading https://www.mediawiki.org/wiki/Manual:Developing_extension. I've been stepping through the payments wiki/donations interface extension stuff to see how it comes together. Working through the files outlined in extension.json files at the moment, any tips? [16:13:38] Wikimedia-Fundraising: Create translated versions of new Thank You page - https://phabricator.wikimedia.org/T185333#3941184 (Pcoombe) Thanks @schoenbaechler. I'm happy with working from the current content. Also appreciating how you cunningly made all the text center aligned, so that right-to-left language... [16:20:40] jgleeson_: So, DI is at heart a 'special page' extension [16:21:10] e.g. one that adds some special purpose pages rather than changing how the wiki works in other ways [16:22:06] you can see those pages registered at the top of the json file [16:22:36] where the page title is the key and the class is the value [16:23:39] each of those classes extends UnlistedSpecialPage (basically SpecialPage) [16:24:36] and overrides the 'execute' function to render the page text [16:27:28] there's one special page that just exists to choose a gateway based on payment parameters [16:27:35] that one eventually just serves a redirect [16:28:15] then basically all the other special pages are gateway-specific implementations of the abstract class GatewayPage [16:28:48] we've mostly gotten rid of the duplicated code that used to be in the gateway-specific pages, at the cost of inflating GatewayPage a bit [16:29:27] it's got code to handle both initial-view pages (like the ones that send you to a processor's form) [16:29:58] as well as to handle return-view pages (i.e. when you've filled out your info with the processor and they redirect you back to our site) [16:30:11] So that's a potential thing to split up [16:31:00] we use the mediawiki framework to add js and css to the page [16:31:29] see the $out->addModuleStyles, $out->addModules calls on lines 95-96 of GatewayPage [16:32:04] This is handled by a chunk of mediawiki code called ResourceLoader, which does a lot of minification and cache optimization [16:32:16] it can handle both static js/css [16:32:34] as well as dynamically generated modules [16:33:14] for an example of the dynamically generated stuff, see CurrencyRatesModule in the modules folder [16:34:21] So the bulk of the code is in the gateway adapters [16:35:41] They're responsible for orchestrating the flow of collecting user data and making the right API calls to collect a donation, then displaying the result to the user [16:36:52] tons of stuff happens in the constructor (see https://gerrit.wikimedia.org/r/342553/ for an attempt to cut that down) [16:37:20] including collecting all the data from the get, post, and session [16:37:31] as well as defining all the transaction structures [16:37:45] and generating contribution tracking rows and an order ID [16:38:40] a lot of declarative stuff, like lists of accepted currencies and required fields per country [16:38:57] is read out of yaml files in each gateway's config folder [16:39:45] those are basically just dumped into associative arrays under the gateway class's $config variable [16:40:04] though there are specific accessors for a lot of them [16:41:31] good time to bookmark https://wm-bot.wmflabs.org/logs/%23wikimedia-fundraising/ [16:41:40] hehe, yeah! [16:42:46] i'll just link that as 'Documentation' under all our pages on mediawiki.org and call it a day [16:44:58] :) [16:45:07] with "...search for" [16:45:37] this log stood out to me https://wm-bot.wmflabs.org/browser/index.php?start=02%2F02%2F2013&end=02%2F02%2F2018&display=%23lotro-wiki [16:45:58] I played lotro for some time [16:46:15] heh, huh [16:49:57] (PS3) Ejegg: Use SPDX 3.0 license identifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [16:50:45] (PS4) Ejegg: Use SPDX 3.0 license identifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [16:51:12] (CR) Ejegg: [C: 2] "Thanks Lego! Updated to -or-later to match what we just added to composer.json" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [16:52:32] (CR) jerkins-bot: [V: -1] Use SPDX 3.0 license identifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [16:58:31] (CR) jerkins-bot: [V: -1] Use SPDX 3.0 license identifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [17:00:20] (Draft2) Jayprakash12345: Removed deprecated position statements from resource loader module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/407676 (https://phabricator.wikimedia.org/T184257) [17:05:12] ejegg: you down for standup? [17:08:45] dstrine: oops, be there in a sec! [17:54:27] (CR) WMDE-Fisch: [C: 2] Removed deprecated position statements from resource loader module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/407676 (https://phabricator.wikimedia.org/T184257) (owner: Jayprakash12345) [17:58:54] (PS1) Ejegg: Autodiscover extension unittests [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407689 [17:58:56] (PS1) Ejegg: momentjs: Hack around bug in node/browser compat wrapper in locale files [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407690 (https://phabricator.wikimedia.org/T145382) [17:58:59] (PS1) Ejegg: Override momentjs's digit transform logic with MW's [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407691 (https://phabricator.wikimedia.org/T123999) [17:59:02] (PS1) Ejegg: Don't override all Moment locales to English [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407692 (https://phabricator.wikimedia.org/T135462) [17:59:05] (PS1) Ejegg: resources: Bump moment.js from 2.8.4 to 2.15.0 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407693 [17:59:08] (PS1) Ejegg: resources: Bump moment.js from 2.15.0 to 2.19.3 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407694 (https://phabricator.wikimedia.org/T161732) [17:59:11] (PS1) Ejegg: Copy in Field changes from Id8963924f036e9ed3fcdde3a8e54b7126b72356e [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407695 (https://phabricator.wikimedia.org/T160298) [17:59:14] (PS1) Ejegg: Make FormatMetadata::flattenArrayReal() work for an associative array [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407696 (https://phabricator.wikimedia.org/T87572) [17:59:29] (CR) Ejegg: [C: 2] Make FormatMetadata::flattenArrayReal() work for an associative array [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407696 (https://phabricator.wikimedia.org/T87572) (owner: Ejegg) [17:59:34] (CR) Ejegg: [C: 2] Autodiscover extension unittests [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407689 (owner: Ejegg) [17:59:40] (CR) Ejegg: [C: 2] momentjs: Hack around bug in node/browser compat wrapper in locale files [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407690 (https://phabricator.wikimedia.org/T145382) (owner: Ejegg) [17:59:43] (CR) Ejegg: [C: 2] Override momentjs's digit transform logic with MW's [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407691 (https://phabricator.wikimedia.org/T123999) (owner: Ejegg) [17:59:48] (CR) Ejegg: [C: 2] Don't override all Moment locales to English [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407692 (https://phabricator.wikimedia.org/T135462) (owner: Ejegg) [17:59:51] (CR) Ejegg: [C: 2] resources: Bump moment.js from 2.8.4 to 2.15.0 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407693 (owner: Ejegg) [17:59:56] (CR) Ejegg: [C: 2] resources: Bump moment.js from 2.15.0 to 2.19.3 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407694 (https://phabricator.wikimedia.org/T161732) (owner: Ejegg) [18:00:00] (CR) Ejegg: [C: 2] Copy in Field changes from Id8963924f036e9ed3fcdde3a8e54b7126b72356e [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407695 (https://phabricator.wikimedia.org/T160298) (owner: Ejegg) [18:00:20] Wikimedia-Fundraising-Banners: Block donations over maximum gift amount (10000 USD) from banners - https://phabricator.wikimedia.org/T186336#3941470 (Pcoombe) [18:00:24] (Merged) jenkins-bot: Removed deprecated position statements from resource loader module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/407676 (https://phabricator.wikimedia.org/T184257) (owner: Jayprakash12345) [18:00:32] fr-tech just keeping our REL1_27 branch up to date with the parent one ^^^ [18:00:56] nice [18:01:48] ~_~ [18:03:12] ejegg, that reminds me. In order to pull down the versions of DI and other extensions with tests, I need to swap out a few things dont I [18:03:55] jgleeson_: there are a couple of ways to do that [18:04:15] you can just go into the extensions/DonationInterface (etc) directory and check out the master branch [18:04:46] or you can create a whole alternate extensions dir with symlinks to your permanent project directories [18:04:57] I was thinking about using this, git submodule foreach --recursive git checkout master [18:05:01] and switch between extensions.dev and regular extensions [18:05:12] oh hey, that would probably work [18:05:25] and then to revert [18:05:37] I think I can just do git submodule update --recursive [18:05:45] yeah, that sounds like it should work! [18:05:58] I'll give it a go and let you know how I get on [18:07:54] (Merged) jenkins-bot: Autodiscover extension unittests [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407689 (owner: Ejegg) [18:08:43] (Merged) jenkins-bot: momentjs: Hack around bug in node/browser compat wrapper in locale files [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407690 (https://phabricator.wikimedia.org/T145382) (owner: Ejegg) [18:12:12] (Merged) jenkins-bot: Override momentjs's digit transform logic with MW's [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407691 (https://phabricator.wikimedia.org/T123999) (owner: Ejegg) [18:12:15] (Merged) jenkins-bot: Don't override all Moment locales to English [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407692 (https://phabricator.wikimedia.org/T135462) (owner: Ejegg) [18:12:18] (Merged) jenkins-bot: resources: Bump moment.js from 2.8.4 to 2.15.0 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407693 (owner: Ejegg) [18:12:20] (Merged) jenkins-bot: resources: Bump moment.js from 2.15.0 to 2.19.3 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407694 (https://phabricator.wikimedia.org/T161732) (owner: Ejegg) [18:12:24] (Merged) jenkins-bot: Copy in Field changes from Id8963924f036e9ed3fcdde3a8e54b7126b72356e [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407695 (https://phabricator.wikimedia.org/T160298) (owner: Ejegg) [18:12:26] (Merged) jenkins-bot: Make FormatMetadata::flattenArrayReal() work for an associative array [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/407696 (https://phabricator.wikimedia.org/T87572) (owner: Ejegg) [18:50:43] Fundraising-Backlog: Ingenico audit issue: transactions not in Civi - https://phabricator.wikimedia.org/T178081#3941654 (Ejegg) Open>Resolved a:Ejegg Thanks for the verification! [19:01:59] (PS1) Ejegg: Update license string, add Maggie to authors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/407722 [19:02:58] mepps: is 'Maggie Epps' how you'd prefer to be credited? ^^^ [19:03:13] works for me ejegg! [19:03:20] great! [19:03:39] (CR) Ejegg: [C: 2] Update license string, add Maggie to authors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/407722 (owner: Ejegg) [19:04:11] there was an opportunity to be creative with the naming choice there mepps that I feel was missed [19:04:27] jgleeson what should i have called myself? [19:04:46] ninja penguin was the first thing that came to mind [19:04:58] (Merged) jenkins-bot: Update license string, add Maggie to authors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/407722 (owner: Ejegg) [19:04:59] fair enough, i'm happy to be credited as ninja penguin [19:05:05] :) [19:05:19] though i think it would have to be awkward yoga penguin [19:05:44] actually awkward yoga cat would probably be how those who know me would recognize me [19:05:50] * jgleeson_ googling for penguins doing yoga [19:06:15] it's a thing, https://fitisafeministissue.files.wordpress.com/2014/02/penguin_yoga_by_natdatnl-d4r5ois.jpg?w=663 [19:06:24] this cat is better at yoga than i am: https://albawabacdn-albawabamiddleea.netdna-ssl.com/sites/default/files/imagecache/article_headline_node_big//sites/default/files/im/Sport/cat_yoga.jpg [19:06:29] ha! [19:06:39] LOL the cat [19:13:34] AndyRussG XenoRyet, was looking at outstanding patches for CN, and it looks like they almost all have merge conflicts? [19:15:14] there are a lot of olllld ones still hanging out [19:18:13] ejegg these seem to all be from Jan 30 [19:18:29] oh huh [19:19:05] looks like some are wip or don't merge [19:19:21] this is where i'm looking https://gerrit.wikimedia.org/r/#/q/centralnotice [19:19:53] mepps: ejegg yeah there is a lot of cleanup to do there... I'd just focus for now on tickets in "review"... [19:20:22] weird, I don't see what was updated on a lot of those [19:20:29] gotcha, XenoRyet, are you looking at a particular ticket? [19:20:33] they do say Updated: 3 days ago [19:20:45] but the history has nothing recent [19:20:58] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: order id suffix incremented between pending and donations queues - https://phabricator.wikimedia.org/T184291#3941724 (mepps) a:mepps [19:21:18] mepps: Not yet. Whatever is up for grabs [19:21:25] cool XenoRyet [19:21:27] oh, maybe just taking awight off the reviews list [19:21:32] *reviewers [19:21:40] ahh haha ejegg [19:23:58] ejegg i'm seeing a weird error in the paypal orphan rectifiier: Internal error: no [19:23:58] results yet. [19:24:08] err [19:24:10] huh [19:24:16] no results yet? [19:24:22] yeah... [19:24:36] i'm pretty sure it's set to only grab records more than 30 minutes ago [19:24:42] unless something is going wrong with that [19:24:50] ohh, that's what a newEmpty looks like! [19:25:09] ohhhhhh [19:25:38] I thought that was something special, but I guess it's just a variety of 'failed' [19:25:56] ah okay, glad to hear it's working as expected! [19:26:14] though it means it registers as an error [19:26:29] yeah :( [19:27:36] mepps: ejegg XenoRyet yea sorry about the mess of outstanding patches there.... a bunch of stuff should be just Gerrit-abandonded I think.... I'll try to clean up this dark corner!!! [19:36:49] fr-tech, is everyone using phpstorm? [19:36:54] (for php) [19:37:03] I am, I don't think all of us do though. [19:37:12] i am jgleeson! though haven't totally mastered all the advanced features yet [19:37:13] jgleeson_: I am [19:38:54] jgleeson_: I use Eclipse [19:39:18] hmm ejegg, could we consider the timeout response a success? that seems to be the only way to avoid an error state, the other option is use a refresh [19:40:46] yeah, I guess a success is right. Then if we want to log differently, we can query the adapter's finalStatus [19:40:53] since you've added one for Timeout [19:42:35] Thanks all. I'm adding some notes on using xdebug with PHP7 on MediaWiki vagrant as there's no documentation on it at the moment, but I'm conscious my IDE instructions assume everyone is on phpstorm. mepps, re:phpstorm, my favourite features are double shift for "search everywhere", ctrl+shirt up/down to move functions around, alt+insert to generate getters/setters/parent/construct method bodies and shortcuts [19:42:35] like `pubf` tab, `prif` tab, `prof` tab for function body templates generation. [19:42:54] Hey folks, something just cropped up and I have to step out for a bit to handle it. Be back in a couple of hours probably. [19:43:04] bye XenoRyet|afk [19:55:50] ejegg do we have any tests or any prototypes for a test (in other adapters) that could help catch https://phabricator.wikimedia.org/T184291 [19:56:21] Fundraising-Backlog, MediaWiki-Vagrant: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3941820 (jgleeson) **============= xDebug on PHP7 (Stretch) =============** PhpStorm setup https://confluence.jetbrains.com/display/PhpStorm/Debugging+PHP+CLI+scripts+with... [19:56:49] mepps: good question, I don't think so though [20:02:43] (PS1) Mepps: Update return from timeout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407738 (https://phabricator.wikimedia.org/T184284) [20:02:53] ejegg would this work? ^^ [20:02:57] i can also do a newSuccess [20:04:34] hey fr-tech anyone interested in using xdebug with php7 on MediaWiki vagrant, I've added notes here https://phabricator.wikimedia.org/T186119. They *should* work with phpstorm and eclipse. I'm kinda using this ticket as my scratchpad at the moment for this exercise so when it's done I'll see if there's anything useful that can go over to the main mediawiki documentation and clear it off. [20:05:00] mepps maybe newSuccess is clearer? [20:05:32] hmm my only concern ejegg is that it's technically not a success is it? unless success is that we got a response back [20:05:39] and on that note, I'm head off. Have a great weekend all! catch you monday. [20:05:57] see ya jgleeson_ ! [20:06:00] have a good one [20:06:22] mepps: right, that's what I thought 'Empty' was a good stand-in for [20:06:48] but apparently not [20:06:59] i was thinking that fromResults would return the finalStatus and the actual response back? [20:09:59] ahh, unfortunately it only looks at the finalStatus and response to decide what kind of PaymentResult to return [20:10:11] and PaymentResult doesn't contain all that detail [20:12:26] ah [20:13:30] (PS2) Mepps: Update return from timeout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407738 (https://phabricator.wikimedia.org/T184284) [20:15:19] (CR) Zoranzoki21: [C: 1] "Looks good to me" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407738 (https://phabricator.wikimedia.org/T184284) (owner: Mepps) [20:35:08] PROBLEM - check_ssl on thulium is CRITICAL: SSL CRITICAL - Certificate payments-listener.wikimedia.org valid until 2018-02-09 20:31:03 +0000 (expires in 6 days) [20:35:08] PROBLEM - check_ssl on saiph is CRITICAL: SSL CRITICAL - Certificate payments-listener.wikimedia.org valid until 2018-02-09 20:31:03 +0000 (expires in 6 days) [20:37:48] ACKNOWLEDGEMENT - check_ssl on thulium is CRITICAL: SSL CRITICAL - Certificate payments-listener.wikimedia.org valid until 2018-02-09 20:31:03 +0000 (expires in 6 days) Casey Dentinger new certs on the way [20:38:18] ACKNOWLEDGEMENT - check_ssl on saiph is CRITICAL: SSL CRITICAL - Certificate payments-listener.wikimedia.org valid until 2018-02-09 20:31:03 +0000 (expires in 6 days) Casey Dentinger yep [21:17:39] ejegg i'm reading the comments for defineOrderIdMeta, and it says: * 'ct_id' => boolean value. If True, when generating order ID use [21:17:39] * the contribution tracking ID with the sequence number appended [21:17:51] what is the sequence number and where is that determined? [21:19:05] mepps since we let people try a few times on the same contribution tracking ID before giving up and resetting the whole session [21:19:18] the sequence number is supposed to be which payment attempt they're on [21:20:20] it's initialized to 1 in generateOrderID [21:20:31] and stored in the session key 'sequence' [21:20:59] then various adapters call incrementSequenceNumber at different parts in the process [21:21:28] but apparently the ingenico adapter does it an extra time [21:21:46] hmm why do we call incrementSequenceNumber in do_transaction for createHostedCheckout in the ingenico adapter? it doesn't look like we do the same in globalcollect [21:21:46] it SHOULD only increment if we're trying to set up a new hosted checkout session [21:22:12] yeah, globalcollect uses this weird old format involving a random number [21:22:46] so, if we create a second hosted checkout session, we want it to have a different merchant reference [21:23:03] since the donor could plausibly have changed amount or something in the meantime [21:23:44] i'm wondering if we accidentally run through it twice to cause T184291 [21:23:45] T184291: Ingenico Connect: order id suffix incremented between pending and donations queues - https://phabricator.wikimedia.org/T184291 [21:24:00] mepps definitely possible! [21:24:54] has adyen ever had this issue? it's calling increment sequence number in a weird place [21:25:04] I don't think so [21:27:42] oh weird [21:28:05] so it looks like adyen doesn't run through it for donate because it breaks before it gets there ,but there are no other transactions? https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/adyen_gateway/adyen.adapter.php#L213 [21:28:49] mepps: ahh, good catch [21:29:17] we should move that up into the 'donate' case [21:29:25] just in case we do add any other txns [21:39:40] mepps: can I get you to look at this again https://gerrit.wikimedia.org/r/#/c/407389/ (I addressed your comments) - curious to see if other things pass once it's merged [21:46:04] fundraising-tech-ops, Operations, monitoring: ssl monitoring: add civicrm.wikimedia.org to icinga - https://phabricator.wikimedia.org/T186328#3942204 (RobH) a:RobH>Jgreen [21:54:21] fundraising-tech-ops, Operations, monitoring: ssl monitoring: add civicrm.wikimedia.org to icinga - https://phabricator.wikimedia.org/T186328#3942207 (RobH) it was there and someone else (not me) acked it. not a good idea since im the one generating and purchasing certs ;] [21:57:55] fundraising-tech-ops, Operations, monitoring: ssl monitoring: add civicrm.wikimedia.org to icinga - https://phabricator.wikimedia.org/T186328#3942209 (RobH) Open>declined [22:21:27] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, and 3 others: add token for address without extra... - https://phabricator.wikimedia.org/T184647#3942246