[00:26:09] (PS1) Eileen: Add invoice_number to ignored fields when comparing expected array with actual [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408472 [00:29:39] (PS1) Eileen: Use wmf_civicrm_ensure_option_value_exists rather than create duplicate values from test SetUp. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408473 [00:30:50] (PS1) Eileen: Apply drupal formatting to ImportMessageTest (through IDE) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408474 [00:40:19] a couple of trivial test changes if anyone wants to push them through https://gerrit.wikimedia.org/r/408473 [00:50:06] RECOVERY - check_ssl on civi1001 is OK: SSL OK - Certificate civicrm.wikimedia.org valid until 2019-02-09 01:41:03 +0000 (expires in 368 days) [00:50:16] RECOVERY - check_ssl on mintaka is OK: SSL OK - Certificate civicrm.wikimedia.org valid until 2019-02-09 01:41:03 +0000 (expires in 368 days) [02:55:51] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Prevent autofill of mu... - https://phabricator.wikimedia.org/T185816#3948124 [05:43:01] (PS1) AndyRussG: Impression events via EventLogging [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408488 (https://phabricator.wikimedia.org/T185932) [05:45:35] (CR) jerkins-bot: [V: -1] Impression events via EventLogging [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408488 (https://phabricator.wikimedia.org/T185932) (owner: AndyRussG) [06:02:06] (PS2) AndyRussG: Impression events via EventLogging [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408488 (https://phabricator.wikimedia.org/T185932) [06:07:18] (PS3) AndyRussG: Impression events via EventLogging [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408488 (https://phabricator.wikimedia.org/T185932) [09:28:42] (CR) Hashar: "recheck" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327792 (owner: Ejegg) [10:28:08] (PS1) MarcoAurelio: Add link to banner history on SpecialCentralNoticeBanners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408519 (https://phabricator.wikimedia.org/T132732) [10:30:05] (CR) jerkins-bot: [V: -1] Add link to banner history on SpecialCentralNoticeBanners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408519 (https://phabricator.wikimedia.org/T132732) (owner: MarcoAurelio) [10:35:36] (PS2) MarcoAurelio: Add link to banner history on SpecialCentralNoticeBanners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408519 (https://phabricator.wikimedia.org/T132732) [10:37:27] AndyRussG: hi - I've uploaded a patch for T132732 at https://gerrit.wikimedia.org/r/#/c/408519/ -- could you please have a look at it when you've got a minute? Thanks :) [10:37:28] T132732: Add history link for banners - https://phabricator.wikimedia.org/T132732 [12:02:45] hello fr-tech o/ [14:52:19] hello jgleeson! [14:58:05] hi awight! [14:58:25] mepps: bonjour! fr-tech doesn’t miss a beat, I see [14:58:50] awight, are you requesting that we distract you? or suggesting that you are distracted with your status? [15:00:36] LOL distraction is always welcome. [15:01:11] how's Peru today? and you know, your family and life there [15:01:27] But it’s becasue my work day is shredded by a side thing, and Michelle ran off to help deliver a baby. So I figured I’d be honest about the potential for actual work. [15:01:42] ahh that makes sense [15:01:47] wow, go Michelle! [15:01:49] It’s been awesome, we just moved into a house without a refrigerator :) [15:02:05] and no running water in the shared kitchen today [15:02:05] haha, wow, you're brave [15:02:10] going full-on hippie style [15:03:03] wow, you guys are into extreme parenting [15:03:06] I ransacked the house CDs to find something that didn’t make my atheist skin crawl, I did manage to score some shamanic jungle chants [15:03:08] and living too of course [15:03:11] hehe [15:03:18] haha nice! [15:03:49] good luck with work today! sounds like there's plenty there to distract :) [15:03:52] Don’t worry, I made up for it by taking a bunch of taxis this morning and am now sitting in the best wifi lounge in town, ordering fancy juice mixes [15:04:00] :) holler if you need counter-distraction [15:04:59] ha! oh good, i was picturing you in your hippie bungalow, using some sort of contraption for internet :) [15:08:24] awight|distract: hey so now I'm not alone in the club of the fridge-less [15:08:32] O_O [15:08:43] (hoping to exit that society sooooon) [15:08:46] You stopped paying for electricity? [15:09:07] no, I moved from the fully-furnished apartment into an unfurnished one [15:09:13] haven't gotten a fridge yet [15:09:30] Aha okay, I was going to ask whether you still live in one of the biggest metropoli in the world :p [15:09:40] the corner stores are doing a good business selling me ice [15:09:42] yes [15:10:02] not going anywhere where my kids aren't.... [15:10:04] haha I have a fondness for the ice chest style [15:10:07] right! [15:10:16] Unfortunately, ice hasn’t made it to this town, yet. [15:10:20] ohnoes [15:10:27] hmmm [15:11:01] well, fresh daily groceries are a thing I guess :) [15:11:04] are you planning to stay a while in Peru still? [15:11:33] It’s practically like http://trenecuador.com/es/comunidad/el-ultimo-hielero/ [15:11:51] Just a month, then we’re crashing ejegg|away’s couch. He might not know it yet ;-) [15:12:46] nice! [15:14:02] awight|distract: which of his couches, in which city? [15:14:37] (CR) Awight: "> Patch Set 4: Code-Review-1" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/406480 (owner: Awight) [15:16:26] AndyRussG: hehehe, he’s a man of many couches [15:18:11] almost reminds me of the itinerant street musician lifestyle... tho not quite! [15:18:29] maybe when my kids are grown I could ramble about again like that [15:19:56] AndyRussG: hey, your name came up yesterday in a Scoring Platform discussion…. I’ve been hearing that the ML antifraud thing might get a second glance. We could do some restructuring of the base “revscoring” repo, to score things other than revs. [15:20:41] If this hypothetical situation came to pass, I thought you might have fun working with our awesome contractor codezee… [15:21:23] Just thought I would say this all a few times, until everyone forgets that it’s not actually a thing, and lets us get away with it. [15:22:07] * awight|distract side-eyeballs PM’s account ;-) [15:27:54] awight|distract: ah hmmm.... I haven't dealt much with antifraud, mepps and jgleeson have poked at it tho, I think [15:28:14] mostly I've just remained in the CentralNotice corner... facing the wall ;p [15:28:28] I can imagine! That’s a whole lot of PHP and JS to shepherd [15:29:06] The `revscoring` side of it is just juggling code structure though, nothing particularly ML’y or antifraud-specific… [15:29:19] * awight|distract increases the offer by 10% :) [15:29:30] 0 x 110%? [15:30:05] hopefully some of the recent CN research could lead to some CN rewrites... [15:30:40] lol [15:30:41] lolol [15:32:54] Kra*gle that tower of cards and join us in the salt marshes :) [15:33:04] heheh [15:33:28] awight|distract: thanks :) I'm happy to take a look for less than half of that, thanks for the totally undeserved shout-out :) [15:34:01] (undeserved in the sense of not worthy thereof) [15:34:02] You might be horrified by the duck-typiness of it all… [15:34:47] heh over the years I've gradually drifted from that old Java mindset [15:36:01] hahaha PHP is amazing for letting us enforce types about 1/4 of the time we might need to. [15:36:13] sounds like you're having fun with the marshes' saltiness, really good to hear :) [15:38:37] I am. I’m mostly the deployment trebuchier [15:40:13] My job is to write long reports about how we were naughty but promise to do better next semester. [15:40:25] https://wikitech.wikimedia.org/wiki/Incident_documentation/20171120-Ext:ORES [15:56:29] awight|distract: heheh [15:56:45] cool! [17:16:56] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/408561 [17:17:25] fr-tech dstrine putting accumulated minor CN patches on today's Mediawiki deploy train now [17:17:40] nice [17:19:17] ejegg: heh should get to this more often! [17:19:30] toot toot [17:25:58] (CR) AndyRussG: [C: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/408561 (owner: AndyRussG) [17:26:59] Neat, thanks AndyRussG. Just a reminder that we're launching Sweden banners today (hopefully at 18 UTC) so will you be able to watch the deploy for any issues there? [17:33:13] pcoombe: sure, thanks for the heads-up! On the MW train deploys, the new code gets to meta on Wednesday and the Wikipedias on Thursday [17:34:30] I just checked that there's nothing odd in there... these are mainly minor patches... actually your "Don't load CentralNotice on history or diff pages" patch will finally go out now, apologies for the delay!!! [17:34:38] ah okay. Wasn't sure if it worked the same for Centralnotice [17:34:58] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/408561 (owner: AndyRussG) [17:34:58] yes I checked to see if that one was there :) thanks! [17:35:55] pcoombe: thanks likewise :) yeah we can put stuff on the train, which just means merging so that the train deployment pushes it out to production, and sometimes we do SWAT deploys, or get a special slot [18:39:15] (CR) Krinkle: Impression events via EventLogging (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408488 (https://phabricator.wikimedia.org/T185932) (owner: AndyRussG) [19:43:51] (PS1) Mepps: Move ensureUniqueOrder id to prevent incrementing of order_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/408591 (https://phabricator.wikimedia.org/T184291) [19:44:15] ejegg: this fixes the bug ^^ but is there any reason not to move that? [19:44:37] taking a look [19:45:11] oops i'll delete the extra logging statement [19:45:33] (PS2) Mepps: Move ensureUniqueOrder id to prevent incrementing of order_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/408591 (https://phabricator.wikimedia.org/T184291) [19:45:35] ok, trying to determine if we still need the 'incrementSequenceNumber' bit [19:46:11] i was curious about that too [19:47:45] what's currently happening is that becaues it increments in the createhostedcheckout transaction, when it loops back through ensureUniqueId on the next call, it increments the order_id [19:55:53] right. [19:56:46] also side note fr-tech: my cat is currently curled up inside my wikimedia sweatshirt while i wear it [20:05:21] ejegg i think we do want to incrementSequence there [20:08:13] i tried it without that and exactly what we don't want happened--where i had the same order_id for two different payment attempts [20:10:59] I have a couple of pretty trivial test patches https://gerrit.wikimedia.org/r/#/c/408473/ (as I try to find my way to getting latest Civi passing for us) [20:12:38] (CR) Mepps: [C: 2] Use ValidationError from SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407566 (https://phabricator.wikimedia.org/T163868) (owner: Ejegg) [20:19:39] (PS1) Eileen: CRM-21737 loosen option value validation to support language option group [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408606 [20:22:03] Don't try reviewing the ones against civicrm (only crm) though - although the failing tests will make them untempting :-) [20:23:23] (PS2) Mepps: Use ValidationAction constants from SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407564 (https://phabricator.wikimedia.org/T163868) (owner: Ejegg) [20:23:28] (CR) Mepps: [C: 2] Use ValidationAction constants from SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407564 (https://phabricator.wikimedia.org/T163868) (owner: Ejegg) [20:24:39] (PS3) Mepps: Use PaymentError from SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407565 (https://phabricator.wikimedia.org/T163868) (owner: Ejegg) [20:24:43] (CR) Mepps: [C: 2] Use PaymentError from SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407565 (https://phabricator.wikimedia.org/T163868) (owner: Ejegg) [20:25:07] (CR) Mepps: [C: 2] Add invoice_number to ignored fields when comparing expected array with actual [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408472 (owner: Eileen) [20:25:54] thansk mepps [20:28:31] (CR) jerkins-bot: [V: -1] CRM-21737 loosen option value validation to support language option group [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408606 (owner: Eileen) [20:29:10] (Merged) jenkins-bot: Add invoice_number to ignored fields when comparing expected array with actual [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408472 (owner: Eileen) [20:35:19] PROBLEM - check_mysql on payments2003 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) [20:35:19] PROBLEM - check_mysql on payments2002 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) [20:38:08] (PS3) Ejegg: Move ensureUniqueOrder id to prevent incrementing of order_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/408591 (https://phabricator.wikimedia.org/T184291) (owner: Mepps) [20:38:16] (CR) Ejegg: [C: 2] Move ensureUniqueOrder id to prevent incrementing of order_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/408591 (https://phabricator.wikimedia.org/T184291) (owner: Mepps) [20:40:19] RECOVERY - check_mysql on payments2002 is OK: Uptime: 523 Threads: 1 Questions: 97 Slow queries: 0 Opens: 17 Flush tables: 1 Open tables: 80 Queries per second avg: 0.185 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [20:40:19] RECOVERY - check_mysql on payments2003 is OK: Uptime: 519 Threads: 1 Questions: 97 Slow queries: 0 Opens: 17 Flush tables: 1 Open tables: 80 Queries per second avg: 0.186 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [20:41:00] (PS1) Eileen: Apply drupal formatting to wmf_civicrm (through IDE) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408614 [20:59:28] (CR) Mepps: [C: 2] Use wmf_civicrm_ensure_option_value_exists rather than create duplicate values from test SetUp. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408473 (owner: Eileen) [21:00:08] OH mepps - 2 formatting patches [21:00:13] follow on from that [21:02:57] (Merged) jenkins-bot: Use wmf_civicrm_ensure_option_value_exists rather than create duplicate values from test SetUp. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408473 (owner: Eileen) [21:52:32] (PS1) Eileen: CRM-21738 fix transfer of view_only custom data. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408690 [21:56:31] (CR) jerkins-bot: [V: -1] CRM-21738 fix transfer of view_only custom data. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408690 (owner: Eileen) [22:05:10] hey ejegg, I've moved the vagrant branch from WIP to complete so when you get some time I think that's good to be merged. https://gerrit.wikimedia.org/r/#/c/406953/ [22:05:25] great! [22:05:28] looking [22:06:22] turns out I didn't need the sudo prefix after all, not entirely sure why as I can't replicate the error now which is frustration so I'm gonna put it down to environment craziness. Things got a lot more consistent after I start using git clean -xffd before each build [22:06:37] frustrating* [22:06:51] well, that was the only thing stopping me from +2 [22:07:01] approved! [22:07:18] that related drupal patch is merged too [22:08:19] PROBLEM - Host bellatrix is DOWN: PING CRITICAL - Packet loss = 100% [22:08:21] yeah I wasn't happy with that either, considering it's technically not required as puppet runs the exec blocks as root as bd808 pointed out. Anyway it seems to work without now so guess it goes away as a problem @_@ for now [22:13:29] RECOVERY - Host bellatrix is UP: PING OK - Packet loss = 0%, RTA = 36.22 ms [22:13:40] (PS1) Eileen: Add handling to Omnimail tests for unset __PEAR error globals. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408696 [22:14:57] one more pretty trivial test fix if anyone is up to look [22:14:59] ^^ [22:15:29] looking [22:16:07] eileen: oh man, that looks like a rabbit hole [22:16:21] since it's just in a test, I'll take your word for it [22:16:52] ejegg: yep - it has hurt my brain a lot - no need to hurt yours [22:18:11] (CR) Ejegg: [C: 2] "looks good" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408474 (owner: Eileen) [22:19:54] calling it a night, catch you all tomorrow o/ [22:20:01] so long! [22:21:04] mepps, I'll try and catch up with you tomorrow to go over ingenico. I'm gonna have a read over the feasibility tickets available here and see if one stands out https://phabricator.wikimedia.org/tag/fr-ingenico-integration_2017-18/ [22:21:52] I'll be on about 5am-1pm EST so if you're around before/after lunch I'll bug you then :) [22:22:00] (Merged) jenkins-bot: Apply drupal formatting to ImportMessageTest (through IDE) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408474 (owner: Eileen) [22:23:32] (CR) Ejegg: [C: 2] Apply drupal formatting to wmf_civicrm (through IDE) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408614 (owner: Eileen) [22:24:24] (CR) Ejegg: [C: 2] "Taking your word for it!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408696 (owner: Eileen) [22:25:32] (CR) Ejegg: Move ensureUniqueOrder id to prevent incrementing of order_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/408591 (https://phabricator.wikimedia.org/T184291) (owner: Mepps) [22:25:41] (CR) Ejegg: [C: 2] "retest" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/408591 (https://phabricator.wikimedia.org/T184291) (owner: Mepps) [22:26:45] (PS1) Ejegg: Update Amazon SDK for TCP proxy [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408707 [22:27:00] (CR) Ejegg: [C: 2] Update Amazon SDK for TCP proxy [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408707 (owner: Ejegg) [22:27:11] (Merged) jenkins-bot: Apply drupal formatting to wmf_civicrm (through IDE) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408614 (owner: Eileen) [22:30:24] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/408708 [22:32:10] (PS1) Ejegg: Update Amazon library for TCP proxy [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/408710 [22:32:15] (CR) Ejegg: [C: 2] Update Amazon library for TCP proxy [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/408710 (owner: Ejegg) [22:33:01] (PS2) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/408708 [22:33:26] (Merged) jenkins-bot: Update Amazon SDK for TCP proxy [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408707 (owner: Ejegg) [22:35:05] (Merged) jenkins-bot: Move ensureUniqueOrder id to prevent incrementing of order_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/408591 (https://phabricator.wikimedia.org/T184291) (owner: Mepps) [22:35:31] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/408708 (owner: Ejegg) [22:37:21] (CR) Ejegg: [V: 2 C: 2] Update Amazon library for TCP proxy [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/408710 (owner: Ejegg) [22:37:57] (CR) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/408708 (owner: Ejegg) [22:38:49] (CR) Ejegg: [C: 2] "recheck" [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/408708 (owner: Ejegg) [22:38:51] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/408708 (owner: Ejegg) [22:40:11] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/408708 (owner: Ejegg) [22:42:04] !log updated SmashPig standalone from 778e8f87b4 to 1f56978c0c [22:42:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:45:25] ugh, that didn't fix it [22:46:16] okay, turned the TCP proxy back off [22:46:24] the underlying code deploy was fine [22:47:27] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog: Create Phabricator tag for Fundraising analytics tasks - https://phabricator.wikimedia.org/T186236#3950826 (DStrine) @AndyRussG I have created #FR-Tech-Analytics It should show up in type heads when adding tags. [22:47:52] dstrine: ^ thanks!!! :) [22:48:45] heading out for a couple hours [22:48:51] ejegg: cya :) [22:50:19] (CR) jerkins-bot: [V: -1] Add handling to Omnimail tests for unset __PEAR error globals. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408696 (owner: Eileen) [22:50:37] AndyRussG: NP! [22:51:16] (CR) Krinkle: Add handling to Omnimail tests for unset __PEAR error globals. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408696 (owner: Eileen) [22:51:48] (PS2) Eileen: Add handling to Omnimail tests for unset __PEAR error globals. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408696 [22:52:22] (CR) Eileen: [C: 2] "putting back the code review as it's basically unchanged from when added" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408696 (owner: Eileen) [22:52:27] AndyRussG: that is a very general "systems" tag. I have another set of tags we can use for specific milestones or epics. This way we can search for the larger category above and/or a specific projects [22:58:27] (Merged) jenkins-bot: Add handling to Omnimail tests for unset __PEAR error globals. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408696 (owner: Eileen) [22:59:11] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408690 (owner: Eileen) [22:59:24] dstrine: ah OK cool [22:59:53] dstrine: also, is there any doc or other content I should read, or anything else I should prepare, for tomorrow's meeting about translations? [23:00:45] AndyRussG: I don't think so. This is going to be a super high level conversation [23:01:58] oki cool [23:03:30] (PS5) Eileen: Citibank import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/401819 (https://phabricator.wikimedia.org/T179339) [23:04:34] I just put the citibank import into review - I'm inclined to think it needs 'light review' as the 'real' file has not come through yet & follow up patches based on actually using it can be looked at when that happens [23:05:08] (CR) jerkins-bot: [V: -1] CRM-21738 fix transfer of view_only custom data. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408690 (owner: Eileen) [23:08:26] (PS1) Eileen: Fix another place where global resetting can lead to e-notice [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/408715 [23:08:50] sigh - another place for those crazy globals e-notices :-) ^^ [23:09:07] hmm that face was not meant to be smiling!