[00:18:09] (PS1) Ejegg: Add mapping for Ingenico payment status codes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408955 (https://phabricator.wikimedia.org/T176502) [00:18:43] (PS1) Ejegg: Add phpDoc strings [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408956 [00:22:15] (CR) jerkins-bot: [V: -1] Add mapping for Ingenico payment status codes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408955 (https://phabricator.wikimedia.org/T176502) (owner: Ejegg) [00:23:23] (PS2) Ejegg: Add mapping for Ingenico payment status codes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408955 (https://phabricator.wikimedia.org/T176502) [01:14:00] (PS1) Eileen: CRM-21749 fix obscure regression :Mailing api no longer respecting '_skip_evil_bao_auto_schedule_' [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408960 [01:14:39] I had to issue [01:14:44] git push eileen evil [01:14:54] to get that pr up to github :-) [01:36:21] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Disappearing address info in Civi - https://phabricator.wikimedia.org/T185960#3954730 (NNichols) I've corrected the contacts with the missing addresses. However, @Eileenmcnaughton is there a... [02:15:01] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/408964 [02:17:34] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/408964 (owner: Eileen) [02:18:43] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/408964 (owner: Eileen) [02:20:00] !log Update CiviCRM civicrm revision changed from 71b1e35b99 to 61acc9175e (deploy citibank, benevity import updates) [02:20:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:21:08] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Winter Wanderland, and 3 others: Different currenci... - https://phabricator.wikimedia.org/T182808#3835068 [02:29:05] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Disappearing address info in Civi - https://phabricator.wikimedia.org/T185960#3954748 (Eileenmcnaughton) @NNichols here is a list of contact ids with '#NA' as a suffix - 25 of them. We shoul... [02:30:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Clean up unused suffixes - https://phabricator.wikimedia.org/T186770#3954750 (Eileenmcnaughton) [02:38:14] (Abandoned) Eileen: Accumulated WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407579 (owner: Eileen) [02:43:10] (Abandoned) Eileen: CRM-21737 loosen option value validation to support language option group [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408444 (owner: Eileen) [02:43:20] (Abandoned) Eileen: CRM-21737 loosen option value validation to support language option group [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408606 (owner: Eileen) [02:47:26] (Abandoned) Eileen: Try redirect hook (with guzzle) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407581 (owner: Eileen) [02:48:01] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/404330 (https://phabricator.wikimedia.org/T182251) (owner: Eileen) [02:49:08] (PS4) Eileen: Stock civicrm 4.7.31(rc) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406955 [02:49:10] (PS2) Eileen: CRM-21738 fix transfer of view_only custom data. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408690 [02:49:12] (PS2) Eileen: CRM-21749 fix obscure regression :Mailing api no longer respecting '_skip_evil_bao_auto_schedule_' [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408960 [02:49:15] (PS2) Eileen: CRM-19798 fix memory leak on EntityTag.get [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407195 [02:52:14] (CR) jerkins-bot: [V: -1] CRM-21749 fix obscure regression :Mailing api no longer respecting '_skip_evil_bao_auto_schedule_' [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408960 (owner: Eileen) [02:52:36] (CR) jerkins-bot: [V: -1] Stock civicrm 4.7.31(rc) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406955 (owner: Eileen) [02:54:23] (CR) jerkins-bot: [V: -1] CRM-21738 fix transfer of view_only custom data. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408690 (owner: Eileen) [02:54:34] (CR) jerkins-bot: [V: -1] CRM-19798 fix memory leak on EntityTag.get [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407195 (owner: Eileen) [03:09:27] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407195 (owner: Eileen) [03:13:04] (CR) jerkins-bot: [V: -1] CRM-19798 fix memory leak on EntityTag.get [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407195 (owner: Eileen) [04:15:48] (CR) Ejegg: "let's leave the vendor/.htaccess file in there" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406955 (owner: Eileen) [04:16:50] (CR) Eileen: "yeah - I'm gonna put others over the top - although I would prefer to add that through deployment I think" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406955 (owner: Eileen) [05:27:50] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog: configure Civi with wk2pdf - https://phabricator.wikimedia.org/T186474#3954814 (Eileenmcnaughton) a:Eileenmcnaughton [05:28:34] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Port back delete patch from search change - https://phabricator.wikimedia.org/T185183#3954816 (Eileenmcnaughton)... [14:57:58] Fundraising-Backlog: AUD minimum donation amount error on mobile form? - https://phabricator.wikimedia.org/T183191#3955763 (Pcoombe) Open>Resolved a:Pcoombe I've reverted the behaviour to not round up the minimum. [Diff](https://meta.wikimedia.org/w/index.php?title=MediaWiki:FundraisingBanners/Co... [15:31:06] Fundraising-Backlog: Civi dedupe: lost contrib? 2/4/2018 - https://phabricator.wikimedia.org/T186806#3955827 (MBeat33) [15:45:01] sigh fr-tech, just realized i can't log in to civi without my work computer [15:45:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico, FR-Smashpig, Fr-Ingenico-integration_2017-18: Donation queue consumer: support alternate ID for pending row - https://phabricator.wikimedia.org/T163951#3955871 (jgleeson) a:jgleeson [15:45:22] ah that sucks mepps [15:45:36] supposedly it's likely i'll get the computer back today at least [15:46:15] and in good news, i jsut learned the distinction between office wiki and collab [15:46:21] how are you jgleeson? [15:46:28] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico, and 2 others: Donation queue consumer: support alternate ID for pending row - https://phabricator.wikimedia.org/T163951#3215946 (jgleeson) [15:47:56] ah I'm ok, a little bit frustrated with my knowledge gaps on mediawiki as I'm trying to fix some tests [15:48:32] also torn between putting this particular task down and finishing what I started [15:49:03] I've reduced the failed tests down from 207 to 3 for donation interface, so it feels wrong to walk away now [15:49:38] mepps: what did you do with the computer?? [15:49:59] cwd i took it to a local lenovo partner [15:50:39] jgleeson, how are you fixing the tests? that sounds tricky [15:50:55] why are they failing--is it environment? [15:51:01] the failing tests are relating the cli environment - yeah [15:52:09] cwd my other option was to mail it in and wait at least a week---how are you handling the recall? [15:52:24] but the components which build up the values are pretty difficult to just edit without the wider context of what their doing [15:52:40] so I'm trying to step through and get a deeper understanding [15:52:45] but it's a huge time sink [15:52:45] mepps: well there is no one to fix it closer than denver (6 hours) [15:52:51] yeah that sounds tricky [15:52:57] cwd that sucks [15:53:15] oit will send you a loaner if you need one [15:53:16] so i guess i will look into shipping it, but i am skeptical that any carrier will take a known defective lipo [15:53:41] you have to jump through tons of hoops to ship a known good lipo [15:53:43] cwd, lenovo will send you a box i think and handle that part [15:53:57] that's what they told me when i called [15:54:02] ok cool, i was on hold with lenovo for an hour yesterday and gave up [15:54:11] yeah it took me forever too [15:54:22] what a PITA [15:54:31] and they keep interrupting the music to tell you you're still on hold [15:54:31] i'm on my old computer now but it's...old [15:54:35] haha yeah [15:54:36] ditto [15:54:41] and i have nothing set up [15:55:00] sigh [15:55:05] so it'll be a documentation kind of day! [15:55:55] thinking about the fire danger, they only have 3 in the wild so far but it's a very new computer and stands to reason more will fail as time goes on [15:56:14] an increasing rate of failure [15:57:17] yeah that makes sense [15:58:21] * cwd kicks rock [15:58:37] jgleeson, i imagine you're learning something through this at least! [15:58:46] cwd at least none of his had a random computer fire! [15:59:03] that would have been a fun excuse for lack of progress.... [16:49:52] hey fr-tech I'm going to an annual planning meeting and will miss standup. Let me know if you need anything. I'll be free at 10. [16:57:53] (PS2) Ejegg: Admin UI: Disable autocomplete on multiselects and all campaign detail [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/406547 (https://phabricator.wikimedia.org/T185816) (owner: AndyRussG) [16:58:00] (CR) Ejegg: [C: 2] Admin UI: Disable autocomplete on multiselects and all campaign detail [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/406547 (https://phabricator.wikimedia.org/T185816) (owner: AndyRussG) [17:00:39] (Merged) jenkins-bot: Admin UI: Disable autocomplete on multiselects and all campaign detail [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/406547 (https://phabricator.wikimedia.org/T185816) (owner: AndyRussG) [17:27:29] PROBLEM - Host americium is DOWN: PING CRITICAL - Packet loss = 100% [17:28:16] ^^^ americium is expected, rebooting for kernel config [17:30:29] RECOVERY - Host americium is UP: PING OK - Packet loss = 0%, RTA = 0.38 ms [17:33:21] ejegg: ^ thanks! [17:57:46] Wikimedia-Fundraising-Banners: Block donations over maximum gift amount (10000 USD) from banners - https://phabricator.wikimedia.org/T186336#3956221 (Pcoombe) Added this to banner validation ([diff](https://meta.wikimedia.org/w/index.php?title=MediaWiki:FundraisingBanners/CoreJS-2017.js&diff=17719438&oldid=1... [17:58:44] (PS1) Jgleeson: Fixed tests not working due to vagrant envioment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/409094 [18:00:03] ah man, I misspelt environment! [18:01:27] (PS2) Jgleeson: Fixed unit tests not working on vagrant environment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/409094 [18:03:15] cwd: Whoa, I just did this for a friend and it was the scariest thing that hasn’t actually involved bursting into flame… https://www.ifixit.com/Guide/iPhone+6+Battery+Replacement/29363#s69548 [18:03:47] (CR) jerkins-bot: [V: -1] Fixed unit tests not working on vagrant environment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/409094 (owner: Jgleeson) [18:03:55] The battery was mangled and I had multiple, deep floss cuts by the time I defeated the airplane glue [18:08:03] :O [18:08:35] i've only done one successful mobile device repair ever, everything else I have destroyed trying [18:09:48] awight: brutal [18:10:18] yeah i just tried lenovo again and they aren't even answering [18:10:36] it was just like, circuit full, error code xxx [18:11:29] meanwhile my old computer requires like 3 hours a day of futzing with the wifi [18:11:54] i forgot how much i hate this [18:13:00] anyway i am positive that if someone can show me what screw it is i can fix it because it is actually not bad in there [18:20:12] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Winter Wanderland, and 3 others: Different currenci... - https://phabricator.wikimedia.org/T182808#3956266 [18:31:46] Jeff_Green: Yeah, I suggest not skimming that repair guide…. Apple is in full planned obscelence mode, and they’re putting screws with 0.1mm length differences right next to each other. If you swap them, the circuit boards die. [18:32:01] x-| [18:32:49] that's terrible [18:33:40] Plus, everything is glued, including miniature gold foil contacts [18:35:03] Hehe did I mention that most of the phones I’ve opened have multiple loose screws rattling around... [18:38:33] last time i tried to work on an apple computer i tried to replace the CD drive with an SSD and stripped so many screws that i failed [19:12:20] signing off for today fr-tech. Catch you all tomorrow o. [19:12:23] o/* [21:07:15] (PS1) Ejegg: Add some 'throws' tags [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/409156 [21:07:36] (CR) Ejegg: [C: 2] Add some 'throws' tags [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/409156 (owner: Ejegg) [21:07:42] self-merging trivial doc thing [21:15:15] (CR) Mepps: Fixed unit tests not working on vagrant environment (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/409094 (owner: Jgleeson) [21:15:55] (CR) Mepps: [C: 2] Add phpDoc strings [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408956 (owner: Ejegg) [21:16:03] fr-tech did everybody get their 2 cents in on https://collab.wikimedia.org/wiki/Fundraising/Engineering/Outages ? [21:18:37] (Merged) jenkins-bot: Add phpDoc strings [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408956 (owner: Ejegg) [21:18:42] (Merged) jenkins-bot: Add some 'throws' tags [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/409156 (owner: Ejegg) [21:19:56] I didn't actually make any changes, but I'm comfortable with where it's at right now. [21:20:16] ejegg does this also affect the new ingenico integration: https://collab.wikimedia.org/wiki/Fundraising/Engineering/Outages#Implications_of_a_WX_Parser_Outage [21:20:32] i'm still making a couple small style tweaks, but nothing major [21:22:02] mepps yeah, I think it does. The async methods are still async with the new API [21:24:08] perhaps we should also update this: https://collab.wikimedia.org/wiki/Fundraising/Engineering/Outages#Foundation_Wiki [21:29:33] (PS2) Ejegg: Admin UI: Fix multiselects by selecting options using prop() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/406598 (https://phabricator.wikimedia.org/T160819) (owner: AndyRussG) [21:31:16] ejegg did you see that this build failed? https://gerrit.wikimedia.org/r/#/c/408346/ it otherwise looks good to go1 [21:33:59] (CR) Mepps: "Mostly looks straightforward--I made one comment." (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408955 (https://phabricator.wikimedia.org/T176502) (owner: Ejegg) [21:35:11] (CR) Ejegg: [C: 2] "Reproduced the problem locally, and this patch fixes it!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/406598 (https://phabricator.wikimedia.org/T160819) (owner: AndyRussG) [21:36:14] mepps odd, let's see if recheck is the answer [21:36:31] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/408346 (owner: Ejegg) [21:38:33] (PS3) Ejegg: Add mapping for Ingenico payment status codes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408955 (https://phabricator.wikimedia.org/T176502) [21:39:50] mepps hmm, I guess if the thank-you pages go down that's about as bad as the payment forms going down [21:40:11] as far as making people think their donation failed and they need to try again [21:43:19] that seems like another argument for moving those payment-related pages to donatewiki [21:43:26] one fewer point of failure [21:43:38] (Merged) jenkins-bot: Admin UI: Fix multiselects by selecting options using prop() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/406598 (https://phabricator.wikimedia.org/T160819) (owner: AndyRussG) [21:44:25] mepps: added some notes [21:57:13] meps: and also clarified those variable names in the status code patch [21:58:00] (CR) Mepps: [C: 1] "Even more minor comment!" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408955 (https://phabricator.wikimedia.org/T176502) (owner: Ejegg) [21:58:40] mepps how about just finalStatus? [21:59:17] ejegg i was thinking of suggesting that too--only thought is whether it'd be confusing with $status? [21:59:37] but i could see finalStatus working [22:00:12] and it's shorter! [22:13:03] (PS4) Ejegg: Add mapping for Ingenico payment status codes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408955 (https://phabricator.wikimedia.org/T176502) [22:14:18] ok mepps, one more variation ^^^ [22:14:24] maybe more confusing though [22:15:06] (PS5) Mepps: Add mapping for Ingenico payment status codes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408955 (https://phabricator.wikimedia.org/T176502) (owner: Ejegg) [22:15:09] (CR) Mepps: [C: 2] Add mapping for Ingenico payment status codes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408955 (https://phabricator.wikimedia.org/T176502) (owner: Ejegg) [22:15:17] no i think it looked good [22:15:40] oh just saw ingenicoStatuses after approving, but i think it's more consistent [22:16:24] it could also be ingenicoStatusArray? but i think statuses is okay--it's mostly just a messy word [22:16:30] (Merged) jenkins-bot: Add mapping for Ingenico payment status codes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/408955 (https://phabricator.wikimedia.org/T176502) (owner: Ejegg) [22:19:21] now the question is where to use that mapping [22:19:53] we've been passing the whole JSON response back up to DonationInterface [22:20:24] hmm, though we do parse errors that show up at the root level [22:20:47] (in the SmashPig Ingenico\Api class) [22:21:21] hmm so maybe we could at least sanitize the status? [22:21:46] i've been thinking about how we could start pulling more out of DI, but then i traded in my work computer, so it's become completely theoretical :) [22:21:55] so, now that we've pushed PaymentError down into SmashPig we could do a bunch more of the work there [22:23:19] so where would those red-flag error codes like 'card reported stolen' show up in the response... [22:23:39] mepps maybe theoretical is the way to go! [22:24:09] staring at that code for too long makes it feel inevitable [22:24:24] or.. unchangeable, or something [22:25:10] free yourself from the inertia and let your refactoring dreams fly! [22:26:07] haha, will do! maybe refactoring on hard paper is the way to go ;) [22:26:13] ok, that yaml typo fix has a V+2 now: https://gerrit.wikimedia.org/r/408346 [22:26:28] okay gotta run for the day, nice! i'll +2 as my last act (for today, not ever) [22:26:35] (PS2) Mepps: Remove stray semicolons from yaml [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/408346 (owner: Ejegg) [22:26:38] (CR) Mepps: [C: 2] Remove stray semicolons from yaml [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/408346 (owner: Ejegg) [22:27:39] see ya, and thanks! [22:29:09] (Merged) jenkins-bot: Remove stray semicolons from yaml [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/408346 (owner: Ejegg) [22:42:45] XenoRyet: digging into any interesting code? [22:44:08] Ejegg: Actually my lappy started doing a weird thing that I'm trying to sort out. [22:44:23] Every time I try to start firefox the whole thing just hangs. It's weird. [22:44:43] blargh [22:45:12] Oh huh. Just figured out it starts ok from the command line. [22:45:18] Just starting from the sidebar is borked. [22:45:32] Wonder what that's about. [23:11:41] hmm, now i'm getting a killer sql query just clicking the individual fishing net rule [23:13:10] XenoRyet: have you been looking at the civi patches? [23:13:46] I updated my db to 4.7.31 before testing the fishing net limit fix [23:14:03] I looked at the new import one yesterday. Hadn't looked at the fishing net one yet. [23:14:22] so I'm wondering if I'm getting that failure because of some missing core patches that I should re-apply [23:14:57] Possible [23:15:21] you're still on civi 4.7.21, right? [23:15:57] I believe so. I could take a look, see if I get the same thing. [23:16:02] sure [23:16:14] it wouldn't be a db killer if you've got a tiny number of contacts [23:16:37] but if you turn on mysql logging you should be able to check if you get a query like this one: [23:17:47] https://phabricator.wikimedia.org/P6673 [23:21:19] ok, also seeing Notice: Undefined index: civicrm_address in CRM_Dedupe_BAO_Rule->sql() (line 96 of /home/elliott/src/php/fundraising/crm/civicrm/CRM/Dedupe/BAO/Rule.php). [23:22:48] Yea, let me get some stuff set up and I'll see if I run into any of that. [23:24:48] hmm, maybe the rule got mangled in the db update? [23:25:17] restoring oldcivi [23:40:58] i just repooled payments1003 after changing some stuff [23:41:24] bonded ethernet and changes to kernel modules [23:48:34] well, gonna call it a night. [23:48:37] see ya!