[12:06:48] (PS3) Jgleeson: Fixed unit tests not working on vagrant environment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/409094 [12:34:44] (CR) Jgleeson: ">" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/409094 (owner: Jgleeson) [12:37:03] (CR) Jgleeson: Fixed unit tests not working on vagrant environment (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/409094 (owner: Jgleeson) [14:35:46] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog: Unintended recurring: pull list and help automate refunds - https://phabricator.wikimedia.org/T186883#3958378 (Ejegg) [14:36:06] fr-tech ^^^ could be a multi-person task [14:42:04] fundraising-tech-ops, Operations, netops: bonded/redundant network connections for fundraising hosts - https://phabricator.wikimedia.org/T171962#3958405 (Jgreen) [14:42:45] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog: Unintended recurring: pull list and help automate refunds - https://phabricator.wikimedia.org/T186883#3958408 (Ejegg) [14:44:06] fundraising-tech-ops, Operations, netops: bonded/redundant network connections for fundraising hosts - https://phabricator.wikimedia.org/T171962#3958412 (Jgreen) We've done all hosts but civi1001, frdb1001, and frdb1001 which require fundraising downtime. [14:44:15] fundraising-tech-ops, Operations, netops: bonded/redundant network connections for fundraising hosts - https://phabricator.wikimedia.org/T171962#3958413 (Jgreen) Open>Resolved [15:26:38] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog: Unintended recurring: pull list and help automate refunds - https://phabricator.wikimedia.org/T186883#3958500 (Ejegg) p:Triage>High [16:17:38] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog: Unintended recurring: pull list and help automate refunds - https://phabricator.wikimedia.org/T186883#3958807 (Ejegg) Banner list: ('B1718_113016_en6C_ipd_p1_lg_txt_awk', 'B1718_113016_en6C_ipd_p1_lg_txt_awkdead', 'B1718_11301... [16:24:43] fr-tech yet again I am pulled into another early meeting. I will miss standup. I will be online after 10. Probably just writing and lining up meetings and stuff [16:24:51] ok [16:26:23] ejegg: there is a list of changes for the LATAM countries in an email from ppena can I ping you later to sort them? I think you had already answered some of them. I want to process them [16:27:05] dstrine: ah, I thought those were changes that needed to be made in the banners [16:27:16] do we need to change what's on the forms? [16:27:42] I thought it also mean forms. I can clarify [16:27:46] *meant [17:10:54] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog: Unintended recurring: pull list and help automate refunds - https://phabricator.wikimedia.org/T186883#3958378 (mepps) Look at paypal legacy api for how to batch cancel Also look at scripts--in global_collect/scripts [17:49:44] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Weird entries in CN Banner content log - https://phabricator.wikimedia.org/T186905#3958960 (spatton) [17:50:44] yoiks, that looks weird! ^^ [17:50:55] maybe has to do with the autofill? [17:50:59] ejegg|food: yeah I was just going to say that [17:51:21] Andy's not here today. Is anyone able to look at this? [17:51:38] at least he told me he would be OOO [17:52:08] I could take a look at that, if it's more urgent than the unintended recurring stuff [17:53:14] well I could use help understanding severity [17:53:25] wow, that's like hundreds of rows, and totally unrelated stuff in the summary column [17:53:27] I'm in a meeting but I'll be out in 5ish minues [17:53:30] minutes [17:53:42] hoping it's just a display thing, and the actual table has good data [17:54:32] huh, oldest seems to be Jan 10th. Is the banner content change log that new? [17:56:21] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Weird entries in CN Banner content log - https://phabricator.wikimedia.org/T186905#3958976 (Pcoombe) Weird! Looks like the same issue is happening on the translatable banner messages log: https://meta.wikimedia.org/wiki/Special:CentralNoticeLogs?lo... [17:59:38] ejegg|food: yeah I'd want to know if it's display or not. I'm guessing we'd have to look into this if the actual data is being affected. [18:00:04] recurring can wait if it's really bad. But I'm interested in more info [18:01:34] weird, I can't even see the bannercontent log on my local box [18:33:51] This is super weird. I don't think it's UBN for our workflow (we don't rely on those logs too much) but if it's messing up the tables that seems dangerous [18:34:34] Even if it's just the display, what happens e.g. if there's a comment that should have been deleted/suppressed and is still visible in these logs? [19:23:46] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Weird entries in CN Banner content log - https://phabricator.wikimedia.org/T186905#3958960 (Anomie) My fault, in {a3e8074f9b}. IndexPager wants `getQueryInfo()` to return `$ret['join_conds']` for the join conditions, but I named it `$ret['joins']`... [19:27:58] (PS1) Anomie: IndexPager wants 'join_conds', not 'joins' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/409420 (https://phabricator.wikimedia.org/T186905) [19:28:43] ^ woohoo! [19:42:26] ahh, there's some schema migration to do before I would be getting that issue locally [19:53:31] (CR) Ejegg: [C: 2] "Looks good!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/409420 (https://phabricator.wikimedia.org/T186905) (owner: Anomie) [20:00:06] (Merged) jenkins-bot: IndexPager wants 'join_conds', not 'joins' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/409420 (https://phabricator.wikimedia.org/T186905) (owner: Anomie) [20:00:48] fr-tech just asking in #wikimedia-operations about deploy strategies [20:04:29] (PS1) Ejegg: IndexPager wants 'join_conds', not 'joins' [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/409430 (https://phabricator.wikimedia.org/T186905) [20:05:02] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Weird entries in CN Banner content log - https://phabricator.wikimedia.org/T186905#3958960 (Ejegg) @Anomie's fix does the trick! folks in wm-operations say go ahead and deploy, so... here goes! [20:07:13] fr-tech just refreshing my memory on how to deploy to the main cluster [20:07:30] but when I'm ready, want to follow along on a screenshare? [20:16:17] (CR) Ejegg: [C: 2] IndexPager wants 'join_conds', not 'joins' [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/409430 (https://phabricator.wikimedia.org/T186905) (owner: Ejegg) [20:18:59] (Merged) jenkins-bot: IndexPager wants 'join_conds', not 'joins' [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/409430 (https://phabricator.wikimedia.org/T186905) (owner: Ejegg) [20:21:12] fr-tech this is what I'm re-reading: https://wikitech.wikimedia.org/wiki/How_to_deploy_code [20:22:01] ejegg are you doing a deploy today? [20:22:54] mepps yeah, it's a pretty trivial change [20:23:10] and it's either deploy 2 lines of php to actually fix the problem [20:23:39] or deploy a settings line to totally disable the CN logs today, then Monday roll that back & deploy the fix [20:24:01] Folks in -operations said go ahead and deploy [20:26:44] cool ejegg--i'd be interested in screen sharing if you're doing it now [20:26:54] ejegg: core submodule pointer should now be pointed to the updated wmf_deploy branch commit [20:27:21] AndyRussG: yep, just waiting for the pointer update to merge [20:27:50] https://gerrit.wikimedia.org/r/409436 [20:27:54] mepps ^^^ [20:28:24] So, CentralNotice is one of the special snowflake extensions that requires this step [20:29:10] ejegg: yes... But note that you won't need a full Scap, since there are no i18n changes [20:29:12] And today is actually a convenient day to deploy CentralNotice because all of the wikis are on the same version [20:29:22] Mmmmm hmmmmmmmm ;) [20:29:24] AndyRussG: ah right, thanks for the reminder! [20:30:02] fr-tech any other day of the week we might have some wikis on e.g. 1.31.0-wmf19 and others on 1.31.0-wmf20 [20:30:03] ejegg i'm going to walk home from this coffee shop in the meantime--i'll be back in 10 [20:30:16] mepps cool [20:40:22] mepps the core change just merged, lmk when you're back [20:40:36] XenoRyet: wanna do a ride-along on a main cluster deploy? [20:41:03] we got an actual fix for the CN log issue, and it's about as trivial as deploying a blacklist would be [20:41:56] Sure. I don't think I've ever seen a main cluster deploy. [20:43:58] XenoRyet: I'll be following the instructions here: https://wikitech.wikimedia.org/wiki/How_to_deploy_code [20:44:09] with the exception for the Core submodule update [20:45:52] I'll start up a screenshare in the usual hangout [20:46:05] Cool, I'll hop in [20:52:33] ejegg jumping in now [21:17:41] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Weird entries in CN Banner content log - https://phabricator.wikimedia.org/T186905#3959565 (Ejegg) OK, this is deployed! [21:19:14] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Weird entries in CN Banner content log - https://phabricator.wikimedia.org/T186905#3959580 (Ejegg) p:Triage>High [21:20:04] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Weird entries in CN Banner content log - https://phabricator.wikimedia.org/T186905#3958960 (Ejegg) And it did turn out to be just a display issue. [21:20:13] ok, back to the unintended recurring thing [21:20:57] XenoRyet: this is the other unplanned sprint work we're focusing on right now: T186883 [21:21:03] T186883: Unintended recurring: pull list and help automate refunds - https://phabricator.wikimedia.org/T186883 [21:21:05] are you deep into something else? [21:36:27] ejegg: fr-tech deploy all good then? [21:36:43] thanks much for doing that!! [21:40:29] XenoRyet: ?? [21:42:19] Oh, didn't see the first bink. No, I'm not super deep in anything at the moment, but I do need to eat. [21:42:33] I'll see if I can get into that once I've crammed some food in my gob. [21:43:00] ok, after that if you feel like pulling the email list, i haven't had a chance to do that yet [21:43:08] 10-4 [21:43:09] mepps is looking at the code side of things [21:43:16] Good times [21:46:25] Yay those CN logs look pretty!! [21:47:23] heheh banners still show, too, or at least one does [21:47:25] thanks again! [21:54:05] thanks all for helping with this!! [22:16:06] ok, going to hit the road. Have a great weekend, all!