[00:10:26] !log disabled p-c jobs for reboot [00:10:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:19:58] come on puppet [00:24:38] !log re-enabled p-c [00:24:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:28:32] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Disappearing address info in Civi - https://phabricator.wikimedia.org/T185960#3965892 (NNichols) @Eileenmcnaughton Much appreciated! I've removed the #N/A suffix from all of these listed. [03:36:07] (CR) Krinkle: Impression events via EventLogging (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408488 (https://phabricator.wikimedia.org/T185932) (owner: AndyRussG) [07:00:10] PROBLEM - check_procs on frdev1001 is CRITICAL: PROCS CRITICAL: 1572 processes [07:05:10] RECOVERY - check_procs on frdev1001 is OK: PROCS OK: 278 processes [12:28:39] Hey fr-tech. We have a bunch of tests marked as skipped due to not being implemented across the donation interface extension. Are these test serving as starting points for things to come, as in a TDD methodology or is there another explanation for their existence? [13:44:18] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Credit card logos alignment in payments form - https://phabricator.wikimedia.org/T187130#3967239 (Pcoombe) a:Pcoombe [13:46:31] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Credit card logos alignment in payments form - https://phabricator.wikimedia.org/T187130#3967249 (Pcoombe) Thanks @TSkaff. Just to clarify, that's part of the payments form. Only this bit is the iframe: {F13712801} I'll take a look at this soon! [13:53:16] jgleeson: they're mostly in the new ingenico adapter [13:53:27] and once it's all done, they should pass [13:53:47] they're all adapted from the old globalcollect tests [13:53:59] since the new adapter should be able to do anything the old one does [13:55:12] oh ok, so it's similar to tdd [13:55:25] with more of a refactor emphasis [13:55:33] yep! [14:21:34] fr-tech hey! [14:30:52] hi AndyRussG ! [14:34:48] ejegg: :) [14:50:51] hi AndyRussG! [14:52:11] hi ejegg [14:52:58] mepps: :) [14:57:17] hi mepps! [15:14:30] hey AndyRussG mepps :) [15:19:19] hey jgleeson, are you done with travel for a bit? [15:32:33] fr-tech my power just went out [15:34:00] uh oh [15:34:16] mepps, done with long drives for a while [15:34:22] pretty taxing [15:35:29] jgleeson: hi! :) [15:37:01] mepps oh jeez, weather related? [15:37:21] no probably construction [15:42:12] Fundraising Sprint Kickstopper, Wikimedia-Fundraising-CiviCRM, FR-Paypal, FR-WMF-Audit: Follow up with Paypal on audit regeneration, enable parser - https://phabricator.wikimedia.org/T167828#3967762 (Ejegg) Open>Resolved Closing this, as we've gone a good time without this particular brea... [15:47:14] (CR) Ejegg: "Looking good so far, just a little unclear on the distinction between impression-event-sample-rate and impression-events-sample-rate." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408488 (https://phabricator.wikimedia.org/T185932) (owner: AndyRussG) [15:51:42] (PS6) AndyRussG: Impression events via EventLogging [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408488 (https://phabricator.wikimedia.org/T185932) [15:53:49] (CR) AndyRussG: "Task for making this easier: T187207" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408488 (https://phabricator.wikimedia.org/T185932) (owner: AndyRussG) [15:55:54] (CR) AndyRussG: "> Looking good so far, just a little unclear on the distinction between impression-event-sample-rate" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408488 (https://phabricator.wikimedia.org/T185932) (owner: AndyRussG) [16:01:07] power restored! for now at least [16:01:53] (PS7) AndyRussG: Impression events via EventLogging [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408488 (https://phabricator.wikimedia.org/T185932) [16:02:04] mepps: how did you keep your internet? phone tethered? [16:02:13] yup AndyRussG [16:02:29] cool [16:02:57] Heh back in the day when I first started working here, I bought a UPS for my DSL modem [16:03:00] which didn't work [16:04:35] then I got a special USB dongle with a data-only SIM card [16:04:54] didn't help much when we had to submit code review using stone tablets, tho [16:07:34] lots of power outages from dinosaurs trying to eat the power lines [16:09:37] lol [16:13:02] Wikimedia-Fundraising-Banners: Desktop small banners have incorrect appearance on non-English Main Pages - https://phabricator.wikimedia.org/T187074#3967926 (Pcoombe) Open>Resolved Okay, fixed in current best ([diff](https://meta.wikimedia.org/w/index.php?title=MediaWiki:Centralnotice-template-B1718_... [16:13:40] heading up to the co-working space [16:30:00] haha AndyRussG [16:54:30] fr-tech, i was just prepping myself for standup before remembering that it's tuesday... [16:54:51] :) [16:58:30] good morning XenoRyet! [16:58:37] hi XenoRyet ! [17:02:38] o/ [17:13:24] 'mornin all [17:36:56] Fundraising-Backlog: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039#3968355 (Pcoombe) Hi @Ejegg, just wanted to flag this again. Would it be possible to look into this? It would be super useful data to have, and I think we could tolerate a few hours scheduled downtime... [17:37:22] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Winter Wanderland, and 3 others: Different currenci... - https://phabricator.wikimedia.org/T182808#3968356 [17:38:47] Fundraising-Backlog: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039#3968360 (MBeat33) +1 thank you @Pcoombe [17:43:17] Fundraising-Backlog: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039#3810789 (cwdent) My $0.02: $0.01 - we should be careful with user agent and save some sort of fuzzy version because it is vulnerable to browser fingerprinting: https://en.wikipedia.org/wiki/Device_fin... [17:47:02] hay so ingenico is actually turning off tlsv1.0 [17:48:36] XenoRyet: hi :) [17:49:21] looks like the hammer is finally coming down on the PCI [17:49:34] to turn off the aged ciphers [17:51:33] hey fr-tech, I'm having some issues getting a successful sandbox transaction on ingenico. I'm trying to use the card details here for testing https://epayments.developer-ingenico.com/documentation/testcases/. Has anyone had success with the details listed there yourselves? [18:22:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi dedupe: lost contrib? 2/4/2018 - https://phabricator.wikimedia.org/T186806#3968486 (DStrine) [18:52:44] Fundraising-Backlog: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039#3968556 (Ejegg) OK, I'll bring this up in sprint planning today [19:05:56] Fundraising-Backlog: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039#3968626 (Ejegg) Looks like we DO have the full useragent in our fraud logs for anyone who gets far enough to run a minFraud check. That's not useful for the non-cc methods, though. [19:41:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: fix 'recurring donations by payment method + date range' search - https://phabricator.wikimedia.org/T131094#3968877 (MBeat33) Open>Resolved a:MBeat33 [19:57:26] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Winter Wanderland, and 3 others: Different currenci... - https://phabricator.wikimedia.org/T182808#3968937 [20:01:40] hmm - so if anyone like me has forgotten valentines day it's not v-day there yet so you have a day's warning! [20:03:35] hehe, thanks! [20:07:43] * XenoRyet will probably still forget. [20:09:39] I'm hoping R forgot = he's still dropping kids off so I don't know yet [20:25:54] wtf, my local wiki instance isn't even loading the di.form.core module any more [20:30:38] Fundraising-Backlog: fill out PCI SAQ A - https://phabricator.wikimedia.org/T187246#3969088 (DStrine) [20:53:56] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog: Create Phabricator tag for Fundraising analytics tasks - https://phabricator.wikimedia.org/T186236#3969134 (DStrine) Open>Resolved [20:54:21] Fundraising-Backlog, FR-Ingenico, Fr-Ingenico-integration_2017-18, Epic: EPIC: Ingenico reintegration internal test - https://phabricator.wikimedia.org/T183289#3969136 (mepps) [20:54:23] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Fr-Ingenico-integration_2017-18, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review: Ingenico Connect: order id suffix incremented betwee... - https://phabricator.wikimedia.org/T184291#3969135 [20:55:18] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog: Document severity of the various forms of outage - https://phabricator.wikimedia.org/T183293#3969138... [20:55:50] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Vaporwerewolf, and 7 others: Amazon code should all... - https://phabricator.wikimedia.org/T180168#3969140 [20:56:08] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Winter Wanderland, and 4 others: Fatal error in Amo... - https://phabricator.wikimedia.org/T182737#3969143 [20:56:21] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog: Ingenico Production API key expiring - https://phabricator.wikimedia.org/T185614#3969145 (Ejegg) Open>Resolved a:Ejegg [20:56:23] Fundraising-Backlog, FR-Ingenico, Fr-Ingenico-integration_2017-18, Epic: EPIC: Ingenico reintegration internal test - https://phabricator.wikimedia.org/T183289#3969148 (Ejegg) [20:56:39] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Winter Wanderland, and 2 others: make a wiki page f... - https://phabricator.wikimedia.org/T181652#3969149 [20:58:14] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Weird entries in CN Banner content log - https://phabricator.wikimedia.org/T186905#3969152 (AndyRussG) Open>Resolved [20:59:03] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Weird entries in CN Banner content log - https://phabricator.wikimedia.org/T186905#3958960 (AndyRussG) Thanks, all, for fixing this!!! 😺 [21:00:01] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, FR-Tech-Analytics: Create a Gerrit repository for centralnotice_analytics - https://phabricator.wikimedia.org/T186052#3969155 (DStrine) [21:07:13] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Epic: [Epic] Kafkatee changes - https://phabricator.wikimedia.org/T183978#3969182 (DStrine) [21:07:58] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Winter Wanderland, and 3 others: reassess tasks lea... - https://phabricator.wikimedia.org/T183290#3969191 [21:08:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: " Could we also update the tokens for the labels? Currently addressee doesn't show up (nor contact first and last/org name). Thank you kindly!" - https://phabricator.wikimedia.org/T187248#3969192 (Eileenmcnaughton) [21:09:00] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, and 3 others: add token for address without extra... - https://phabricator.wikimedia.org/T184647#3969207 [21:09:28] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Disappearing address info in Civi - https://phabricator.wikimedia.org/T185960#3969212 (Eileenmcnaughton) OK to close @NNichols ? [21:09:31] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Winter Wanderland, and 2 others: Stat1005 BH data i... - https://phabricator.wikimedia.org/T181811#3969214 [21:10:49] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: help with PDF letter formatting - https://phabricator.wikimedia.org/T186159#3935377 (Eileenmcnaughton) @LeanneS is this OK to close? We have follow ons to sort out so all MG contacts have gre... [21:11:05] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Disappearing address info in Civi - https://phabricator.wikimedia.org/T185960#3969229 (NNichols) @Eileenmcnaughton yes! Thanks again for your help [21:12:25] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog: configure Civi with wk2pdf - https://phabricator.wikimedia.org/T186474#3969247 (Eileenmcnaughton) @LeanneS I stuck another pdf engine in play. Our experiments so far is that it was REALLY slow for a single pdf - however, we s... [21:13:46] Fundraising-Backlog: investigate: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039#3969250 (DStrine) [21:14:19] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Disappearing address info in Civi - https://phabricator.wikimedia.org/T185960#3969264 (Eileenmcnaughton) Open>Resolved [21:15:58] Fundraising-Backlog: investigate: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039#3969268 (Ejegg) Here's a user-agent parser we could use: https://github.com/woothee/woothee-php [21:16:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Investigate getting output to word option to work better - https://phabricator.wikimedia.org/T187251#3969283 (Eileenmcnaughton) [21:26:07] Fundraising-Backlog: investigate: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039#3969317 (Ejegg) @Pcoombe and @MBeat33: Recarding @cwdent's point 1, if we were to parse the user-agent and store the info as a few discrete fields, how much of that info would you need? E... [21:26:30] Fundraising Sprint D 2018, Fundraising-Backlog: fill out PCI SAQ A - https://phabricator.wikimedia.org/T187246#3969328 (DStrine) [21:26:35] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog: Unintended recurring: pull list and help automate refunds - https://phabricator.wikimedia.org/T186883#3969332 (DStrine) [21:26:37] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog: configure Civi with wk2pdf - https://phabricator.wikimedia.org/T186474#3969334 (DStrine) [21:26:39] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Process greetings for Major Gifts contacts - https://phabricator.wikimedia.org/T186162#3969335 (DStrine) [21:26:41] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: help with PDF letter formatting - https://phabricator.wikimedia.org/T186159#3969336 (DStrine) [21:26:43] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog, FR-Tech-Analytics: Create a Gerrit repository for centralnotice_analytics - https://phabricator.wikimedia.org/T186052#3969338 (DStrine) [21:26:45] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog: Donatewiki: use EventLogging to log pageloads - https://phabricator.wikimedia.org/T185933#3969340 (DStrine) [21:26:48] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog, MediaWiki-Vagrant, Patch-For-Review: Fix vagrant bugs affecting fundraising tech role - https://phabricator.wikimedia.org/T186119#3969337 (DStrine) [21:26:50] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Double check if we missed a donat... - https://phabricator.wikimedia.org/T185041#3969344 [21:26:52] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add proximity search to advanced ... - https://phabricator.wikimedia.org/T185047#3969343 [21:26:55] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: use EventLogging instead of custom beacon - https://phabricator.wikimedia.org/T185932#3969341 (DStrine) [21:26:58] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog, and 2 others: CentralNotice: Prevent autofill of multiple selection ... - https://phabricator.wikimedia.org/T185816#3969342 [21:27:00] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog, and 2 others: Omnimail recipient load tripping over non-downloaded f... - https://phabricator.wikimedia.org/T184823#3969348 [21:27:02] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Lat/long radius lookup in civi no... - https://phabricator.wikimedia.org/T185039#3969345 [21:27:04] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upgrade CiviCRM to latest point version now that BE is over - https://phabricator.wikimedia.org/T184955#3969346 (DStrine) [21:27:06] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Rewrite our zip code table access... - https://phabricator.wikimedia.org/T184830#3969347 [21:27:08] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog: Document severity... - https://phabricator.wikimedia.org/T183293#3969351 [21:27:10] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, Fundraising-Backlog, and 2 others: Handle timeout in PaypalEC Orphan Rectifier and enable... - https://phabricator.wikimedia.org/T184284#3969350 [21:27:12] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, and 4 others: add token for address without... - https://phabricator.wikimedia.org/T184647#3969349 [21:27:14] Fundraising Sprint D 2018, Fundraising-Backlog: investigate: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039#3969353 (DStrine) [21:27:18] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, and 3 others: Possibility to create bad que... - https://phabricator.wikimedia.org/T182251#3969352 [21:27:23] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, and 5 others: CentralNotice: Consolidate ty... - https://phabricator.wikimedia.org/T178930#3969357 [21:27:24] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint D 2018, and 9 others: Registering test in impressio... - https://phabricator.wikimedia.org/T176334#3969356 [21:43:07] this is a minor one for review https://gerrit.wikimedia.org/r/#/c/404330/ [21:44:19] eileen: ah, I was trying to review that and getting an unrestricted query just from clicking the normal 'fishing net' button on a contact page. [21:44:53] not sure if it's my weird data, or if something happened to the rule while I was updating civi to the latest RC [21:45:40] ejegg: the fishing net button should stick some criteria in the url [21:45:48] but it won't work on the 'raw' rc [21:45:55] ohhh [21:46:03] https://github.com/civicrm/civicrm-core/pull/11658 [21:46:17] I need to compile all those together into our review q [21:46:29] I think I'm gonna do raw rc + a string of patches [21:46:32] k, i'll pull down that bit and try again [21:46:50] You can wait for me to compile the string of patches if you prefer [21:47:08] - that one works on our existing - but if you are already on the rc you might prefer to wait [21:47:57] I'll have that string by the end of today [21:48:08] ah, cool, that would be easier! [21:49:30] woohoo! [21:49:34] I can donate [21:49:43] rockin! [21:50:32] you were right, I just needed to update the credentials [21:50:46] I was also a little confused about the amount unit being cents [21:51:02] but all working now! [21:51:03] ah yeah, that's definitely a quirk [21:51:53] I'm heading off, catch you all tomorrow! [22:01:58] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Campaign Settings - Mu... - https://phabricator.wikimedia.org/T160819#3969510 [22:05:35] hello, has https://gerrit.wikimedia.org/r/#/c/406598/ been deployed already? [22:05:53] I have to make changes to a banner and I'm unable to because of that [22:06:17] Hauskatze: no, not yet. [22:06:57] ejegg: can we cherry-pick to wmf.20 or is there any reason not to? [22:08:19] Hauskatze: CentralNotice is a bit funny - it doesn't get its own wmf.X branch, but uses a wmf_deploy branch that we usually deploy to all wiki families at the same time [22:08:37] AndyRussG: any opposition to merging the latest fixes into wmf_deploy and putting them on the train? [22:09:17] ah [22:09:27] sorry, still learning :) [22:10:05] yah, it's one of I think only two extensions that don't follow the normal deploy logic [22:10:52] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People... - https://phabricator.wikimedia.org/T184647#3969519 [22:11:45] funny sprint names too :P :) [22:12:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: improve MG mailing process - https://phabricator.wikimedia.org/T179882#3969522 (Eileenmcnaughton) [22:12:09] hah, they just keep getting longer... [22:12:09] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People... - https://phabricator.wikimedia.org/T184647#3969521 [22:12:43] AndyRussG: Looks like it's just the autocomplete/multiselect fixes plus some translation updates [22:14:22] (PS1) Ejegg: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/410345 [22:17:46] so, wmf-deploy is the live version of the wikis? [22:17:55] Hauskatze: yep! [22:18:14] ok, so once merged it'll go live, right? [22:18:26] Ah no, not quite [22:18:43] I think the next train is somewhat soon though [22:19:15] right, it takes the merge to wmf_deploy, plus an update to the submodule pointer in the core wmf.X branch [22:19:31] then the train team has to actually do the deploy [22:19:58] AndyRussG: Just looked over those patches again and I'm feeling pretty good about them [22:20:59] (PS2) Ejegg: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/410345 [22:21:09] (CR) Ejegg: [C: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/410345 (owner: Ejegg) [22:21:43] Hauskatze: ah, but in this case we only need to update the submodule pointer on the version that's about to be deployed to metawiki [22:21:51] since it's a change that only affects the admin UI [22:22:03] ah, good [22:22:03] and doesn't have to coordinate with anything on the subscribing wikis [22:22:09] so will I have it like... today? [22:22:38] assuming the core submodule thing merges before the train deploy, looks like it [22:24:12] <3 [22:27:37] Hauskatze: hmm, schedule says the train deploy should be over by now, but there will be another tomorrow [22:28:01] okay, no problem [22:28:13] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/410345 (owner: Ejegg) [22:33:42] ejegg: thanks! [22:33:47] Hauskatze: ok, the submodule update is in the Jenkins gate-and-submit queue. It should go out tomorrow with wmf.21 between 20:00 and 22:00 UTC [22:34:21] ejegg: Hauskatze: mmm not sure, I think if we miss day 1 of the train deploy we miss it all [22:34:31] Normall has to be on by Tuesday morning [22:34:39] ohhh [22:34:51] oh wait, meta isn't on .21 yet [22:35:08] ah, there's a blocker listed for the train deploy [22:35:18] T183960 [22:35:18] T183960: 1.31.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T183960 [22:35:19] Right, but I don't think they merge additional stuff into the deploy branch automatically... only what was merged in before day 1 [22:35:43] Oh hmmm [22:35:56] We could also put stuff on a SWAT deploy [22:35:56] AndyRussG: I submitted a submodule pointer update to 1.31.0-wmf.21 [22:36:40] ejegg: where did u do that? [22:37:14] https://gerrit.wikimedia.org/r/410346 [22:37:18] just by merging into wmf_deploy only updates the pointer for core master [22:37:34] Ah I see [22:37:38] Ok that might work :) [22:37:56] I'll check with Operations tomorrow morning before the train leaves :) [22:38:06] There was another one that we might merge in [22:38:24] A link to banners' on-wiki history pages... [22:38:30] oh, that 'blockers' ticket is just a placeholder, doesn't actually list anything blocking [22:38:36] Ah hmmm [22:38:37] K [22:38:44] AndyRussG: fwiw I'd like to know who to ask for a patch review I made for central notice [22:38:48] also ejegg [22:38:52] ...and comments show the scaps are underway [22:39:00] Hauskatze: you're asking the right folks :) [22:39:06] (though other people could do it too) [22:39:14] trying to get to it :) [22:39:31] Hauskatze: what's your gerrit username? [22:39:34] feel free to remind folks, or ask anyone else also, any time, of course :) [22:39:49] MarcoAurelio [22:39:54] let me fetch the patch [22:40:10] https://gerrit.wikimedia.org/r/#/c/408519/ [22:40:12] aha, that's the one you just mentioned AndyRussG, right? [22:40:17] Also ejegg merging into the deploy branch after the train has left (on the first day) may be frowned upon by Ops... They may prefer such for SWAT deploys [22:40:35] yes indeed! [22:40:54] Hauskatze: thanks much for working on that BTW!!!! [22:41:04] oops... right, that's the point of a train [22:41:20] lemme cancel that submodule pointer update and let's do this swat-style [22:41:33] I'm not sure if what I did would work btw. I'm still learning the ropes... slowly [22:41:46] sometimes falling into bottomless pits of tar [22:41:49] :) [22:42:02] ah, hmm, already merged into .21 [22:43:09] well, I'll put it into the swat link [22:43:23] AndyRussG: would you be around in 1.25 hrs to watch the swat? [22:45:39] ejegg: I'd much prefer the morning SWAT tomorrow (18:00 hrs UTC, 10:00 hrs PST) [22:45:53] OK, I'll put it there [22:45:55] (Kids are arriving in 2 hrs, gotta get some stuff ready) [22:46:01] ejegg: thanks!!! cool beans :) [22:47:53] (PS3) MarcoAurelio: Add link to banner history on SpecialCentralNoticeBanners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408519 (https://phabricator.wikimedia.org/T132732) [22:48:16] ejegg: Hauskatze ^ I can check that one out a little later todayz [22:48:36] :) [22:48:53] :) :) [22:48:58] ;) [22:53:22] fr-tech plz put your tickets in the correct columns in Dinosaur Cookies [23:00:22] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, and 2 others: CentralNo... - https://phabricator.wikimedia.org/T160819#3969653 [23:01:25] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Donation queue consumer: support alternate ID for pen... - https://phabricator.wikimedia.org/T163951#3969656 [23:02:01] ok, heading out for now [23:02:07] ejegg: cya! [23:02:12] have a good evening, all! [23:02:17] :)