[01:27:43] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People... - https://phabricator.wikimedia.org/T176334#3621826 [01:50:59] I think we were too lovey dovey & our sprint name should have been Dinosaur cookies ATE all the gingerbread people [03:35:37] (PS1) Eileen: Stock 4.7.31-rc For CiviCRM [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410373 [04:06:38] (PS2) Eileen: Stock 4.7.31-rc For CiviCRM [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410373 [05:13:31] (PS3) Eileen: Stock 4.7.31-rc For CiviCRM [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410373 [05:13:33] (PS1) Eileen: wmf: CRM-10700 use DELETE FROM instead of TRUNCATE [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410375 [05:13:35] (PS1) Eileen: wmf: CRM-17158 block empty searches unless deliberate [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410376 [05:13:37] (PS1) Eileen: wmf-sunset patch add extra columns to contribution recur tab [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410377 [05:13:39] (PS1) Eileen: Merge from master :Include custom fields in default export [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410378 (https://phabricator.wikimedia.org/T105918) [05:13:41] (PS1) Eileen: Return more rows per query and use unbuffered query to manage the memory [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410379 (https://phabricator.wikimedia.org/T120892) [05:13:43] (PS1) Eileen: Increase time out while doing exports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410380 (https://phabricator.wikimedia.org/T120892) [05:13:45] (PS1) Eileen: Hack out version & extension checks. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410381 (https://phabricator.wikimedia.org/T138334) [05:20:56] (Abandoned) Eileen: CRM-21749 fix obscure regression :Mailing api no longer respecting '_skip_evil_bao_auto_schedule_' [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408960 (owner: Eileen) [05:21:08] (Abandoned) Eileen: CRM-19798 fix memory leak on EntityTag.get [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/407195 (owner: Eileen) [05:21:22] (Abandoned) Eileen: Stock civicrm 4.7.31(rc) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/406955 (owner: Eileen) [05:21:35] (Abandoned) Eileen: CRM-21738 fix transfer of view_only custom data. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/408690 (owner: Eileen) [05:28:13] (PS1) Eileen: CRM-19752 Fix slow query on contribution dash. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410382 (https://phabricator.wikimedia.org/T152936) [05:34:49] (PS1) Eileen: Do not give validation error on address with no location_type. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410383 (https://phabricator.wikimedia.org/T152426) [05:38:37] (PS1) Eileen: Temporary WMF fix on CRM-20905 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410384 (https://phabricator.wikimedia.org/T170900) [05:43:11] (PS1) Eileen: When undelete is true, add new contact as assignee for merged contact activity record [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410385 (https://phabricator.wikimedia.org/T178003) [05:46:48] (PS1) Eileen: Packages updates: retry on deadlock, log details for queries [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/410386 [14:39:33] good morning jgleeson! [14:39:49] morning mepps :) [14:39:53] and ejegg|brb [14:44:46] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog: investigate: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039#3971893 (Pcoombe) @Ejegg If we need to parse it, then family and major version for both browser and OS should be... [14:45:22] PROBLEM - check_minfraud_secondary on payments2003 is CRITICAL: connect to address minfraud-us-west.maxmind.com and port 443: Network is unreachable [14:50:22] RECOVERY - check_minfraud_secondary on payments2003 is OK: HTTP OK: Status line output matched 200,301,302 - 385 bytes in 1.752 second response time [14:55:29] (CR) Thiemo Kreuz (WMDE): Fix undefined variable (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/410045 (owner: Ejegg) [15:04:55] hi jgleeson and mepps [15:05:37] (CR) Ejegg: "Ah, I like the quotes so the message is still clear if someone passes an empty string by mistake" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/410045 (owner: Ejegg) [15:10:58] fr-tech morningz!! [15:21:11] AndyRussG: hello! [15:23:05] good day [15:35:59] Hauskatze: hi! [15:36:03] ejegg: :) [15:54:06] Seddon: We just chatted about your “self-help” banners, and like the idea. Can you write a brief task in Phabricator? [15:54:51] awight: Will do! [16:14:10] hi AndyRussG! [16:14:11] Jeff_Green: hey :) [16:14:11] awight: boo! [16:14:12] yipes! [16:14:13] yurpz! [16:14:15] Seddon: sorry to bother again but there's another 'complex' (my POV) banner request at Meta [16:14:18] Hauskatze: Hey! [16:14:18] (nb: anything not using the community_banner_v2 template or that deviates a line from it is complex to me) [16:14:18] hi [16:14:18] Hauskatze: which request can I help with? [16:14:18] Seddon: https://meta.wikimedia.org/wiki/Meta:Requests_for_help_from_a_sysop_or_bureaucrat#CentralNotice_request_open [16:14:20] Hauskatze: The competition doesn't run until March [16:14:21] Hauskatze: I don't understand the need for the urgency from them [16:14:21] Seddon: 20nd February 2018 → 25th March 2018 [16:14:21] are we looking at the same banner? [16:14:21] :) [16:14:21] Oh right yeah.... [16:14:21] hmmmm [16:14:21] ejegg: wrt Admin UI, it's being fixed on today's MediaWiki train, right? [16:14:21] I'll respond [16:14:21] Hauskatze: actually the SWAT deploy a few hours before the train [16:14:22] so 2 hrs from now [16:14:22] ejegg: awesome; I had to deactivate a campaign due to the languages thing [16:14:22] I'll reenable it later [16:25:12] PROBLEM - check_puppetrun on pay-lvs2002 is CRITICAL: CRITICAL: Puppet has 23 failures. Last run 5 minutes ago with 23 failures. Failed resources (up to 3 shown) [16:26:03] hmm [16:27:52] uh oh [16:30:05] PROBLEM - check_puppetrun on pay-lvs2002 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [16:35:14] RECOVERY - check_puppetrun on pay-lvs2002 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [16:35:14] PROBLEM - check_puppetrun on pay-lvs2001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [16:36:28] cwd: curious, are you investigating the misbehaving puppets? [16:36:33] fr-tech my computer might be on the operating table during standup [16:37:27] ejegg: don't puncture the battery with any screws eh [16:40:06] Jeff_Green: yeah... [16:40:09] i don't get it [16:40:14] PROBLEM - check_puppetrun on pay-lvs2001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [16:40:21] i did just update heka [16:40:40] oh, did puppetmaster reload? [16:41:59] it did [16:42:11] i legit see lvs2* missing from nodes.pp [16:42:13] what the heck [16:43:19] huh, well that sounds like my fault from last week's shuffling [16:43:57] why did they take so long to alert though [16:44:05] that's what i'm wondering [16:45:05] RECOVERY - check_puppetrun on pay-lvs2001 is OK: OK: Puppet is currently enabled, last run 40 seconds ago with 0 failures [16:49:16] cwd i fixed nodes.pp [16:51:13] Jeff_Green: ty [16:51:27] i think this lends credence to the idea that puppet is not running on a predictable schedule :P [16:51:52] hrm [16:52:06] maybe the nagios check is just mfd broken [18:07:08] (CR) AndyRussG: [C: 2] "Great!! Thanks much :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408519 (https://phabricator.wikimedia.org/T132732) (owner: MarcoAurelio) [18:09:28] (Merged) jenkins-bot: Add link to banner history on SpecialCentralNoticeBanners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408519 (https://phabricator.wikimedia.org/T132732) (owner: MarcoAurelio) [18:12:03] AndyRussG: I cannot believe I actually made that thing [18:16:17] HausAFKatze welcome to the surreal feeling of writing code that impacts millions... though with CN banners you've already been there... [18:16:39] BTW the fix for the language and other selectors should go out to production within the hour [18:16:45] but wikitext is different... there's a 'preview' button :-) [18:16:57] Heheh here the will be too! It's the beta cluster [18:17:38] should be there any minute... [18:18:53] https://meta.wikimedia.beta.wmflabs.org/wiki/Special:CentralNoticeBanners/edit/fundraising_test_2018_02_07_mob_sm [18:30:11] fr-tech any Scrum-of-Scrums news? [18:30:14] I have rights on the beta cluster, I'll see if the change worked [18:30:24] deploymentwiki or metawiki? [18:30:56] HausAFKatze: metawiki on beta, see above link [18:31:17] true, sorry, mis-looked [18:31:23] ejegg: None here, thanks. [18:32:03] OMG I cannot really believe the code worked [18:32:19] I did something useful for once [18:32:34] I'm going to award myself the right to eat a chocolate [18:39:50] hmm, that admin UI fix to select multiple things and work isn't working on beta [18:40:21] wait, it does [18:40:37] however if you unselect everything it'll quietly fail [18:40:51] you need at least one project and one language [18:41:26] ahh, so we fixed the front-end bug, but I think there's another (server-side) thing to fix [18:47:40] so what's left is that the ui has to warn you if you leave any or both of the fields (projects/languages) empty [18:47:56] HausAFKatze: https://phabricator.wikimedia.org/T185873 [18:48:19] exactly that one :) [18:51:42] fr-tech anyone want to take a look at the donation queue consumer? [18:51:47] Guessing there's a deadlock [18:52:26] HausAFKatze: apologies, the fix hasn't gone out... There was a scheduling problem with this morning's deploy slot, I'm afraid [18:53:13] Since the submodule update is merged to wmf.21, might it go out with the train deploy? [18:53:27] or does that strictly go to group 1 hosts? [18:53:38] /wikis [18:53:46] ejegg: It might, but I should warn the train deployerz about it [18:53:47] meta is group 1 so it should go [18:53:51] ah yeah [18:54:09] or didn't group0 went out yesterday? [18:54:12] in any case, not standard procedure... [18:54:17] yeah group 0 went yesterday [18:54:29] so group1 is everything else except the 'pedias [18:54:36] correct [18:55:00] it's a bit silly the group0 thing, should be group{1,2,3} [18:55:13] but! RelEng dictates and I abide [18:55:14] programmers always count from 0 ! [18:59:51] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog: Unintended recurring: pull list and help automate refunds - https://phabricator.wikimedia.org/T186883#3973029 (MBeat33) @XenoRyet thanks for the list.... [19:00:34] heheh I have trouble counting from 1 now for some things [19:01:14] mepps: I just noticed a PayPal email from 5 hours ago acknowledging issues on the sandbox site [19:03:45] back in a bit [19:20:29] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog: Unintended recurring: pull list and help automate refunds - https://phabricator.wikimedia.org/T186883#3973107 (XenoRyet) @MBeat33 Yep, it's a database... [19:21:51] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog: investigate: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039#3973115 (Ejegg) Thanks for the link @Pcoombe ! @Cwdent, any ideas for a non-contribution-tracking place this mig... [20:01:10] should anyone be interested there is a discussion on civicrm mailing lists about adding guzzle (or guzzle + httplug) to CiviCRM vendor - https://lists.civicrm.org/lists - you have to go into dev-list & choose archive (the primary use-case is a slightly obscure one of ours that actually uses a psr-7 interface) [20:06:16] fr-tech thanks eileen [20:10:15] (this is the PR https://github.com/civicrm/civicrm-core/pull/11519 & it's so we can redirect after merge from the fishing net rule since depending which way you merge the wrong cid might be in the url) [20:15:44] (PS1) Eileen: [WIP] add geocoder [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/410552 [20:19:14] ejegg: I have a soft theory that removing all the instances of CRM_Core_DAO::freeResult()) might help with those half-rollbacks on deadlock. https://github.com/civicrm/civicrm-core/pull/11615#issuecomment-362465231 [20:19:21] (CR) jerkins-bot: [V: -1] [WIP] add geocoder [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/410552 (owner: Eileen) [20:19:52] although - I think outside of 'merge' we maybe had removed those freeResults so maybe not [20:19:54] interesting [20:20:41] yeah - I'm hoping to test performance on staging with & without that patch - not expecting much difference though [20:21:16] freeResult broke our unit tests which is what sent me down the rabbit hole [20:28:44] k, my curiousity is piqued, just need to step through some more stuff in CentralNotice [20:29:05] ejegg: ? [20:31:34] AndyRussG: I'm going over the EL Impression stuff some more before I dive into CiviCRM db stuff [20:32:09] ejegg: ah fantastic thx!! :) [20:34:27] AndyRussG: we can probably get rid of a lot of the cookie-migrating code in CN soon, right? [20:34:43] ejegg: we should really use it, too.......... [20:35:08] use what now? [20:41:25] ejegg: sorry I think we were referring to different things [20:41:44] There's some general cookie-slurping code that I think we've never really used [20:41:50] that's what I thought u meant [20:42:25] but I think maybe u meant some other more specific cookie migrating code [20:42:32] well that'd be appropriate for this sprint [20:42:34] so yes [20:42:38] we should get rid :) [20:43:29] ah, I was looking at things like 'campaignCategoryUsesLegacy' in the beacon URL [20:43:48] and thinking that would be false for everything these days [20:47:30] looks like that Admin UI fix just went out [20:47:41] AndyRussG: wierd, what's this 'shared_lock' campaign? [20:48:23] ejegg: which one is that? [20:48:37] at the bottom of the list, with that name [20:48:49] no projects or languages selected, but it's enabled [20:48:52] yeah just saw it [20:48:56] weird indeed [20:49:10] not currently active because of start and end dates [20:49:15] still bears checking out [20:49:27] ejegg: I have to run to pick up my kids in like 1 minute [20:49:37] k [20:49:47] In the taxi on the way back I can tether in [20:49:59] (that'd be around 20 past the hour or so) [20:50:08] actually can do so on the way to go get them, too [20:51:30] ejegg: K so you'll be around I guess? thanks and apologies [21:01:53] ejegg: thanks... yeah looks all good :) [21:44:45] k so seems like all good with the CN deploy, thanks! [22:11:31] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog: investigate: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039#3973781 (cwdent) Maybe a new table with a key to c_t? I'm not real familiar with schema best practices there, b... [22:47:02] (CR) Ejegg: [C: 1] "This looks good and works great so far locally. I'd love to get one more vote of confidence from Krinkle / perf team." (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408488 (https://phabricator.wikimedia.org/T185932) (owner: AndyRussG) [22:47:20] (PS1) Eileen: Update extended reports to latest version [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/410609 (https://phabricator.wikimedia.org/T187387) [23:03:59] (PS1) Ejegg: Clean up stray OldCookieEpoch settings [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/410614