[00:07:55] dstrine: I forgot to make sure you were aware that I have to go to school camp next week [00:14:32] eileen: ah ok [01:01:22] (CR) Eileen: "mepps lets look together tomorrow - I have gotten it ok on staging now" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/410552 (https://phabricator.wikimedia.org/T184830) (owner: Eileen) [05:29:42] (PS1) Prtksxna: Use findSelectedItem instead of getSelectedItem [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/414935 (https://phabricator.wikimedia.org/T76630) [09:07:33] Fundraising-Backlog, fundraising-tech-ops: add primary keys or unique indexes to some tables in civicrm, drupal, and pgehres databases - https://phabricator.wikimedia.org/T176631#4005235 (jcrespo) There is no reason to change how PK are done because of ROW, while it depends on each table, there is no nee... [10:34:35] (CR) Zfilipin: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/413181 (https://phabricator.wikimedia.org/T99955) (owner: Zfilipin) [10:39:03] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Browser-Tests, Patch-For-Review, and 2 others: Write browser tests for DonationInterface - https://phabricator.wikimedia.org/T99955#4005404 (zeljkofilipin) Looks like CI is having trouble with DonationInterface. From [[ https://integrat... [10:54:30] (PS3) Zfilipin: WIP Selenium test example [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/413181 (https://phabricator.wikimedia.org/T99955) [10:58:45] (CR) Zfilipin: "#PS 3 checks if fundraising mediawiki-vagrant role is properly configured by checking for "powered by drupal" element in the footer." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/413181 (https://phabricator.wikimedia.org/T99955) (owner: Zfilipin) [11:04:26] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Browser-Tests, Patch-For-Review, and 2 others: Write browser tests for DonationInterface - https://phabricator.wikimedia.org/T99955#4005473 (zeljkofilipin) a:zeljkofilipin>None Please see [[ https://gerrit.wikimedia.org/r/#/c/41... [12:02:55] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: Support 3d Secure transactions - https://phabricator.wikimedia.org/T176512#3628078 (jgleeson) https://epayments.developer-ingenico.com/best-practices/services/3d-secure [12:50:35] (PS4) Zfilipin: WIP Selenium test example [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/413181 (https://phabricator.wikimedia.org/T99955) [12:51:34] (CR) Zfilipin: "PS #4 updates README file" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/413181 (https://phabricator.wikimedia.org/T99955) (owner: Zfilipin) [13:12:07] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: Support 3d Secure transactions - https://phabricator.wikimedia.org/T176512#4005771 (jgleeson) a:jgleeson [14:33:24] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Browser-Tests, Patch-For-Review, and 2 others: Write browser tests for DonationInterface - https://phabricator.wikimedia.org/T99955#4006066 (hashar) DonationInterface test environment is differentthan the other jobs. It targets mediawik... [16:12:54] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Browser-Tests, Patch-For-Review, and 2 others: Write browser tests for DonationInterface - https://phabricator.wikimedia.org/T99955#4006457 (Ejegg) Thanks so much for all the help! We might have to wait till June for the Gerrit integrat... [16:15:26] (PS1) Ejegg: Turn on Diners and JCB for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/415031 (https://phabricator.wikimedia.org/T188036) [16:53:31] (CR) VolkerE: [C: 1] Use findSelectedItem instead of getSelectedItem [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/414935 (https://phabricator.wikimedia.org/T76630) (owner: Prtksxna) [16:55:45] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: Support 3d Secure transactions - https://phabricator.wikimedia.org/T176512#4006629 (jgleeson) We're gonna ask Ingenico to enable the payment method 'Maestro'... [16:55:54] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: Support 3d Secure transactions - https://phabricator.wikimedia.org/T176512#4006630 (jgleeson) Open>stalled [16:56:36] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Wikimedia-Fundraisin... - https://phabricator.wikimedia.org/T185041#4006632 [16:57:02] ejegg, I'm not sure if this ticket needs further action before closing it off, could you check it out and advise? https://phabricator.wikimedia.org/T163951 [16:59:06] jgleeson_: I think we can close it [16:59:22] thanks [17:00:28] Fundraising-Backlog, FR-Ingenico, Fr-Ingenico-integration_2017-18, Epic: EPIC: Ingenico reintegration internal test - https://phabricator.wikimedia.org/T183289#4006666 (jgleeson) [17:00:30] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Donation queue consumer: support alternate ID for pen... - https://phabricator.wikimedia.org/T163951#4006664 [17:09:20] MBeat Hi! You around? Just wanted to let you know we're launching Italy momentarily. [17:09:37] great, thanks for the heads-up, tskaff [17:10:43] MBeat Cool, thanks! [17:15:20] hey fr-tech|dstrine, I can't see an obvious ticket in the 'Feasibility test' column to pick up here https://phabricator.wikimedia.org/tag/fr-ingenico-integration_2017-18/. Can you recommend one? The 3d secure ticket I picked up earlier is on hold so gonna jump on something else. [17:20:59] jgleeson_: Since we are about to do sprint planning, is there anything you can help close out? review anything else for others? [17:21:43] I've had a look through some of the civi and CN tickets but due to my gaps on them two areas, there's not much I can add [17:21:55] tickets in review* [17:29:11] jgleeson_: just submitted a little feedback on your latest vagrant patch. [17:29:22] thanks will take a look [17:30:30] good spot! [17:59:27] hey ejegg, I've corrected the 8 instances of the 'builtkit' typo, doh. I'm now reprovisioning to make sure everything still works before pushing. I'm wondering if the second point is related to the updates I added here https://gerrit.wikimedia.org/r/#/c/410253/4/puppet/modules/crm/manifests/drupal.pp@142 to allow vagrant to access the template_c files, do you think I should expand this to give vagrant access to [17:59:27] all sub-dirs of /sites/default/files? [18:00:49] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4006959 (Pcoombe) [18:01:29] jgleeson_: oh, interesting, how exactly does that block set the permissions? [18:01:43] it changes vagrant to the group [18:02:10] Ahh, so maybe we need to also ensure they're g+w ? [18:03:02] I think that happens earlier on [18:03:15] let me check [18:05:12] yeah ejegg, line 50 on the same file sets the files dir perms to 775 [18:05:30] so I take advantage lower down by making vagrant the group so we can run the tests [18:05:38] from the cli [18:05:43] jgleeson_: oh weird, maybe it's a local issue. I'll set it to re-provision while I get some lunch [18:05:58] ah ok, did you run into problems locally ? [18:06:03] in any case, that patch is totally worth merging as is [18:06:20] yeah, I had a whole mess of 'cannot write to file' errors referring to templates_c [18:06:42] hmmm, that was the original issue I hoped we'd fixed [18:06:45] even after deleting the org.wikimedia.crm dir, destroying and reprovisioning [18:08:07] I'll push the updates to fix my typos and then see how you get on with your reprovision. If the problems still persists then I'll dig into it [18:08:14] thanks! [18:49:31] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4007242 (TSkaff) [19:10:14] (CR) Jforrester: [C: 2] Use findSelectedItem instead of getSelectedItem [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/414935 (https://phabricator.wikimedia.org/T76630) (owner: Prtksxna) [19:15:49] (Merged) jenkins-bot: Use findSelectedItem instead of getSelectedItem [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/414935 (https://phabricator.wikimedia.org/T76630) (owner: Prtksxna) [19:26:52] ejegg, out of interest. If you run vagrant provision again, after your failure and reattempt to run the tests does it work as expected? [19:28:07] I'm wondering if the order of permissions changes is playing a part. I think the permissions use the "subscribe" meta-attribute which tracks changes to certain resources and reapplys updates if changes are made overwriting them [19:32:15] ah lemme see [19:32:22] you mean without deleting anything? [19:32:40] yeah [19:33:11] also just to double check [19:33:41] you're running `vagrant up`, then `vagrant role enable fundraising` followed by `vagrant provision`, in that order? [19:33:52] ah, there is a bunch of output about changes to those dirs [19:34:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Civi dedupe: Skip & Go To Next Pair button - https://phabricator.wikimedia.org/T188430#4007467 (MBeat33) [19:34:50] acutally keeping the role enabled the whole time, from vagrant destroy & clean through vagrant up again [19:35:03] ah that might be it [19:37:46] I'm not 100% sure why but you do need a clean vagrant up, before you then apply a specific role and run vagrant provision [19:38:04] https://www.mediawiki.org/w/index.php?title=MediaWiki-Vagrant#When_to_enable_roles [19:38:10] huh, ok. everything else seemed to work OK [19:38:13] but that's good to know [19:38:41] anyway, when I run the tests after a second 'provision', the permissions are good [19:39:07] ok, sounds like the patch is good to go then [19:39:16] great! [19:40:17] maybe bd808 can help explain why it's necessary for a clean `vagrant up` to run before applying a vagrant role and provisioning? [19:44:26] ejegg, when you ran the crm testsuite. Did you get a handful of failures and errors? [19:45:10] yeah, still getting a dozen or so of those [19:45:17] haven't looked into them all just yet [19:47:59] is that a new thing - often the test suite doesn't clean up that well so a but of truncating helps... [19:48:01] okay so it's not just me. I'll chip through the failures and see if I can get it working. [19:49:00] I think there's always been a handful failing on crm, I run the following when testing: ./vendor/bin/phpunit --disallow-test-output --testdox [19:49:15] in vagrant that is [19:49:26] right [19:50:26] ERRORS! [19:50:26] Tests: 321, Assertions: 2731, Errors: 12, Failures: 9. [19:50:36] hopefully that will be straightforward enough to patch [19:50:39] not that many [19:52:58] jgleeson: what is failing - I probably know them all :-) [19:53:27] mepps I'm in your hood now … on staging [19:53:40] & I set up proximity search there & you are not alone [19:55:27] eileen, I'll see if I can get a user friendly list [19:57:29] hmmm [19:57:35] Tests: 321, Assertions: 1510, Errors: 14, Failures: 94, Risky: 1. [19:57:39] second time round [19:58:04] oh man, that's odd [19:58:15] I knew we weren't cleaning up after ourselves so well [19:58:29] but that's worse than I see on my non-vagrant repeated tests [19:58:39] running it again [19:58:51] less failures this time so far [19:59:01] hmm - yeah if I don't get any failures it runs ok repeatedly local - although I have a small farm of sample contacts afterwards [19:59:37] I did find my contribution-tracking table was the problem last time - had contributions in it not in contribution table [19:59:57] (PS2) Mepps: WIP: initial test for Ingencio Hosted Payments Rejection Status [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/413786 (https://phabricator.wikimedia.org/T176502) (owner: Jgleeson) [19:59:59] (PS1) Mepps: Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) [20:00:16] ok I think I've found something [20:00:17] Failure in api call for RelationshipType create: fopen(/vagrant/srv/org.wikimedia.civicrm/drupal/sites/default/files/civicrm/ConfigAndLog/CiviCRM.7e55389f89c7b52dd50d1307.log): failed to open stream: Permission denied [20:00:27] which links back to your point ejegg [20:01:05] that last (3rd) run was Tests: 321, Assertions: 1510, Errors: 14, Failures: 94, Risky: 1. [20:01:07] (CR) jerkins-bot: [V: -1] Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) (owner: Mepps) [20:01:08] jgleeson that's likely a permissions error between your local user and web server error [20:01:09] ah yeah, so we need to add the rest of those files subdirs to the perms fix [20:01:10] (CR) jerkins-bot: [V: -1] WIP: initial test for Ingencio Hosted Payments Rejection Status [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/413786 (https://phabricator.wikimedia.org/T176502) (owner: Jgleeson) [20:01:40] yeah mepps we fixed some of that in the latest vagrant patch but wondered if other files would be affecting, turns out there is! [20:01:57] ejegg, yup. Will look at that now and rerun tests [20:02:11] affected* [20:02:49] jgleeson: the latest vagrant patch? [20:03:07] yeah, the one you just reviewed :) [20:03:14] mediawiki-vagrant* [20:06:26] (PS2) Mepps: Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) [20:06:36] (CR) jerkins-bot: [V: -1] Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) (owner: Mepps) [20:07:57] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4007628 (TSkaff) [20:08:33] so it looks like the tests are creating new directories [20:08:44] which would explain the permissions issue [20:09:21] jgleeson: ok, so we should pre-create the ConfigAndLog dir, etc, and give those g+ws? [20:09:43] that could work [20:09:48] (PS3) Mepps: WIP: initial test for Ingencio Hosted Payments Rejection Status [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/413786 (https://phabricator.wikimedia.org/T176502) (owner: Jgleeson) [20:09:50] (PS3) Mepps: Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) [20:10:05] I'll give the vagrant user access the the affected directories and see how many tests pass as a result [20:10:58] (CR) jerkins-bot: [V: -1] WIP: initial test for Ingencio Hosted Payments Rejection Status [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/413786 (https://phabricator.wikimedia.org/T176502) (owner: Jgleeson) [20:11:22] (CR) jerkins-bot: [V: -1] Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) (owner: Mepps) [20:16:30] so this time (4th run after setting permissions). [20:16:31] I see: [20:16:46] Tests: 321, Assertions: 1510, Errors: 14, Failures: 94, Risky: 1. [20:17:03] after adding permissions on the log folder etc? [20:17:06] same result I think although the errors are different [20:17:06] yeah [20:18:21] I now see Failure in api call for RelationshipType create: DB Error: already exist [20:18:51] right, I'll run again and capture output, tidy up the format so we can see the failing test and the failure reason [20:19:28] phpunit needs a --simple-failures-list flag [20:28:56] eileen currently saving a new address for myself on stage and it has frozen on me--just seeing the spinning wheel and the address greyed out [20:30:08] mepps hmm - was ok yesterday - will look [20:30:33] eileen it eventually saved [20:30:36] jgleeson: I like using —stop-on-failure [20:30:40] mepps hmm [20:31:39] retrying the proximity search [20:32:35] hmm - other geocoders got enabled again [20:33:29] eileen, I don't want to run that 94 times though :) [20:33:29] I think I have a regex to pull them out for us to look at [20:34:10] mepps: ok - just the one geocoder enabled again [20:34:43] Fundraising-Backlog, FR-Adyen: Spike: setup Netherlands Adyen form with IDEAL - https://phabricator.wikimedia.org/T188035#4007716 (DStrine) [20:53:22] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: saved field mapping Fraud Detection not exporting properly - https://phabricator.wikimedia.org/T187903#4007769 (mepps) Open>Resolved [20:54:59] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: " Could we also update the tokens for the labels? Currently addressee doesn't show up (nor contact first and last/org name). Than... - https://phabricator.wikimedia.org/T187248#4007773 [20:55:26] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Process greetings for Major Gifts contacts - https://phabricator.wikimedia.org/T186162#3935425 (Eileenmcnaughton) @... [20:55:33] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, and 2 others: CentralNo... - https://phabricator.wikimedia.org/T160819#4007777 [20:55:38] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upgrade CiviCRM to latest point version now that BE is over - https://phabricator.wikimedia.org/T184955#4007778 (Eil... [20:55:49] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review: Prefer Express Checkout for pay... - https://phabricator.wikimedia.org/T187512#4007779 [20:56:17] (PS20) Mepps: Add geocoder extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/410552 (https://phabricator.wikimedia.org/T184830) (owner: Eileen) [20:56:25] (CR) Mepps: [C: 2] "Worked well for me on staging!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/410552 (https://phabricator.wikimedia.org/T184830) (owner: Eileen) [20:56:34] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: EPIC: CentralNotice: Tracking: Issues related to old JS widgets in Admin UI - https://phabricator.wikimedia.org/T172024#4007782 (AndyRussG) [20:56:40] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, and 2 others: CentralNo... - https://phabricator.wikimedia.org/T160819#4007781 [20:57:57] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: EPIC: CentralNotice: Tracking: Issues related to old JS widgets in Admin UI - https://phabricator.wikimedia.org/T172024#3483215 (AndyRussG) [20:58:00] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, and 2 others: CentralN... - https://phabricator.wikimedia.org/T185816#4007787 [20:59:35] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: help with PDF letter formatting - https://phabricator.wikimedia.org/T186159#4007802 (Eileenmcnaughton) Open>... [21:00:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: enable the Preview results to be sorted by other columns than the default email address - https://phabricator.wikimedia.org/T188439#4007803 (DStrine) [21:00:16] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People... - https://phabricator.wikimedia.org/T182251#4007815 [21:01:31] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People... - https://phabricator.wikimedia.org/T184647#4007827 [21:01:33] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: " Could we also update the tokens for the labels? Currently addressee doesn't show up (nor contact first and last/org name). Than... - https://phabricator.wikimedia.org/T187248#4007826 [21:01:53] (Merged) jenkins-bot: Add geocoder extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/410552 (https://phabricator.wikimedia.org/T184830) (owner: Eileen) [21:02:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: improve MG mailing process - https://phabricator.wikimedia.org/T179882#4007831 (Eileenmcnaughton) [21:02:10] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Process greetings for Major Gifts contacts - https://phabricator.wikimedia.org/T186162#4007830 (Eileenmcnaughton) ... [21:09:45] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog: configure Civi with wk2pdf - https://phabricator.wikimedia.org/T186474#4007858 (DStrine) Open>declined [21:17:26] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: saved field mapping Fraud Detection not exporting properly - https://phabricator.wikimedia.org/T187903#4007905 (JCuriel) Yes, thank you for fixing this @Eileenmcnaughton. [21:28:27] Fundraising-Backlog, FR-Adyen, Patch-For-Review: add JCB to adyen Japan Form - https://phabricator.wikimedia.org/T188036#3994048 (DStrine) @Ppena did you want diners club too? [21:28:45] Fundraising-Backlog, Fr-Ingenico-integration_2017-18, MediaWiki-extensions-DonationInterface: Plan best way to use Civi tables for Ingenico recurring - https://phabricator.wikimedia.org/T188448#4008051 (Ejegg) [21:30:03] (CR) Mepps: [C: 1] "Looks good, assuming we want Diner's Club" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/415031 (https://phabricator.wikimedia.org/T188036) (owner: Ejegg) [21:30:33] Fundraising-Backlog, Fr-Ingenico-integration_2017-18, MediaWiki-extensions-DonationInterface: Plan best way to use Civi tables for Ingenico recurring - https://phabricator.wikimedia.org/T188448#4008039 (Ejegg) [21:31:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Spike: Can the engage import dedupe on import? - https://phabricator.wikimedia.org/T181090#4008060 (DStrine) [22:15:22] fr-tech, I'm calling it a night. Have a good rest of your day and catch you all tomorrow o/ [22:22:34] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Process greetings for Major Gifts contacts - https://phabricator.wikimedia.org/T186162#4008339 (LeanneS) Yes, thank... [23:32:54] (PS1) Eileen: Update phpWord per merged to master [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/415185