[00:05:55] I have just been looking at the change from that pr ^^ with leannes & I have some screenshots I can demo the diff with [00:06:09] (don't really want to store them anywhere but could do a screenshare) [00:15:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: spike into using scheduled reminders to send out the letters or have conditional blocks so only one template needed - https://phabricator.wikimedia.org/T185054#4008768 (Eileenmcnaughton) Ideally for the scheduled reminders we would send an ema... [00:16:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: spike into using scheduled reminders to send out the letters or have conditional blocks so only one template needed - https://phabricator.wikimedia.org/T185054#4008772 (Eileenmcnaughton) Phase 2 might be to allow a pdf to be sent to one person... [00:50:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: spike into using scheduled reminders to send out the letters or have conditional blocks so only one template needed - https://phabricator.wikimedia.org/T185054#4008842 (Eileenmcnaughton) For group one we can limit to this group "MG emailable d... [01:21:26] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Investigate getting output to word option to work bett... - https://phabricator.wikimedia.org/T187251#4008890 [01:39:20] (PS2) Eileen: Update phpWord per merged to master [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/415185 (https://phabricator.wikimedia.org/T187251) [13:05:09] Fundraising-Backlog, MediaWiki-extensions-Other, I18n: [[MediaWiki:Apihelp-di amazon bill-param-currency/fr]] i18n issue - https://phabricator.wikimedia.org/T166317#4010100 (Amire80) Open>Invalid This message doesn't seem to be used any longer. [14:38:51] morning jgleeson AndyRussG! [14:43:15] hey mepps :) [15:45:13] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: Support 3d Secure transactions - https://phabricator.wikimedia.org/T176512#4010761 (jgleeson) [15:46:05] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Fr-Ingenico-integration_2017-18, Patch-For-Review: Ingenico adapter: parse response errors - https://phabricator.wikimedia.org/T176502#4010785 (jgleeson) [15:46:17] mepps, I just moved out ticket into the sprint [15:46:34] looks like we need to carry the left over tickets from the last one [15:46:44] our* [15:51:52] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: Support 3d Secure transactions - https://phabricator.wikimedia.org/T176512#4010797 (Ejegg) Just sent email asking for them to enable Maestro on sandbox [15:52:40] fr-tech I can start looking into iframe stuff for ingenico (whether 3rd party cookies are needed & how to fix the styling) [15:55:11] in that a mobile safari specific thing ejegg ? [15:55:48] I'll try to recreate the no-cookies thing in another browser [16:07:23] Fundraising-Backlog: Pare down list of extensions on Donatewiki - https://phabricator.wikimedia.org/T188522#4010839 (Ejegg) [16:16:20] ejegg why is CI on php 5.5, isn't prod on 5.6? i ask because it's causing me issues [16:16:48] mepps oh, for which project? [16:16:56] SmashPig [16:17:02] https://integration.wikimedia.org/ci/job/composer-php55-docker/288/console [16:17:42] mepps ah, our composer.json just lists 5.4 as the base requirement [16:17:59] if i move it up, will it use 5.6? [16:18:29] but I guess it would make sense to bump that up if everything under 5.6 is EOl [16:18:41] hmm, I think we'll have to update a CI file too [16:18:44] lemme see [16:19:31] mepps try cloning this repo: ssh://@gerrit.wikimedia.org:29418/integration/config [16:21:22] ooh, interesting, I don't see anything php version-specific in the layout.yaml for SmashPig [16:21:32] so yeah, maybe it does just read the composer.json [16:21:48] (PS4) Mepps: Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) [16:22:11] (CR) jerkins-bot: [V: -1] Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) (owner: Mepps) [16:23:20] (PS5) Mepps: Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) [16:24:37] (CR) jerkins-bot: [V: -1] Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) (owner: Mepps) [16:25:23] mepps it looks like composer-test is specifically php5.5 [16:26:02] but there is a composer-php56, or at least a composer-php56-docker [16:26:21] huh ejegg [16:26:29] we should add tests for composer-php7[012] while we're at it! [16:26:41] lemme try a standalone patch just updating that [16:32:51] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People... - https://phabricator.wikimedia.org/T183293#4010897 [16:32:55] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, and 2 others: CentralNotice: use Even... - https://phabricator.wikimedia.org/T185932#4010898 [16:32:57] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, FR-Adyen, Patch-For-Review: add JCB to adyen Japan Form - https://phabricator.wikimedia.org/T188036#4010899 (DStrine) [16:33:08] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, FR-Adyen: Spike: setup Netherlands Adyen form with IDEAL - https://phabricator.wikimedia.org/T188035#4010902 (DStrine) [16:33:16] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog: fill out PCI SAQ A - https://phabricator.wikimedia.org/T187246#4010904 (DStrine) [16:33:18] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never inte... - https://phabricator.wikimedia.org/T185047#4010905 [16:33:20] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never inten... - https://phabricator.wikimedia.org/T185039#4010906 [16:33:22] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never inte... - https://phabricator.wikimedia.org/T184830#4010907 [16:33:25] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, and 2 others: Omnimail recipient l... - https://phabricator.wikimedia.org/T184823#4010908 [16:33:27] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never inten... - https://phabricator.wikimedia.org/T184284#4010909 [16:33:34] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Spike: Can the engage import dedupe on import? - https://phabricator.wikimedia.org/T181090#4010910 (DStrine) [16:33:37] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People... - https://phabricator.wikimedia.org/T178930#4010911 [16:33:43] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People... - https://phabricator.wikimedia.org/T176334#4010912 [16:33:50] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Patch-For-Review: Unintended recu... - https://phabricator.wikimedia.org/T186883#4010915 [16:34:01] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog: Donatewiki: use EventLogging to log p... - https://phabricator.wikimedia.org/T185933#4010916 [16:34:03] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Update Ingenico hosted style to match new payments form CSS - https://phabricator.wikimedia.org/T184288#4010917 (DStrine) [16:36:15] mepps: asking for review over in #wikimedia-releng [16:36:23] awesome ejegg [16:36:38] I think this patch should move the tests from 5.5 to 5.6 and 7.0 (didn't see 7.1/2 available yet) [16:36:57] https://gerrit.wikimedia.org/r/415085 [16:37:44] hey ejegg you just sent my patch, but i see it down in releng [16:37:54] the right one is in releng i mean [16:38:00] ah, oops [16:38:28] right, https://gerrit.wikimedia.org/r/415325 [16:41:51] ejegg should i +2 or wait for releng to do it? [16:42:44] (CR) Jgleeson: [C: 1] "tests passing for me :)" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) (owner: Mepps) [16:45:48] ejegg i'm once again wondering why we don't want to use the ingenico php sdk? just curious because it seems to handle error/response processing well [16:46:52] mepps the original idea was that we could use the same logging and http request handling across all the processors [16:47:06] and that we would standardize the errors for the next level up [16:47:26] mepps if you have +2 on that repo please go ahead [16:47:47] it looks like i do not ejegg [16:48:00] yeah, I don't think I do either [16:55:20] (CR) Mepps: "Hmm Jgleeson, your points are taken--I'm wondering if maybe we should keep checkErrors more response agnostic and I could create a specifi" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) (owner: Mepps) [16:57:53] fr-tech, be a few minutes late to standup [17:36:03] (CR) MarcoAurelio: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [17:39:11] (CR) Hashar: "Umherirrender wrote:" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [17:48:01] (CR) Ejegg: "recheck" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) (owner: Mepps) [17:48:51] (CR) jerkins-bot: [V: -1] Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) (owner: Mepps) [17:49:57] mepps looks like the tests are passing, it's just failing on phpcs ^^^ [17:50:54] hmm, got some phpunit deprecations warnings. those oughtta be pretty easy to fix... [17:59:27] (PS6) Mepps: Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) [18:00:28] (CR) jerkins-bot: [V: -1] Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) (owner: Mepps) [18:05:01] (PS7) Mepps: Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) [18:06:07] (CR) jerkins-bot: [V: -1] Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) (owner: Mepps) [18:07:55] (PS8) Mepps: Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) [18:12:41] (CR) jerkins-bot: [V: -1] Use SPDX 3.0 license identifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [18:14:44] fr-tech that's me for today. Catch you all tomorrow! [18:14:52] finally got build passing ejegg, jgleeson_ now for cleanup [18:14:59] awesome [18:30:09] fr-tech any news for scrum of scrums? [18:42:01] ejegg: nothing here, thx! [18:45:03] fr-tech can anyone confirm the Japanese ingenico form has diners club as an option? [18:47:34] dstrine looks like no, just VMAJ [18:47:44] thanks! [18:48:10] ejegg: this means we don't need diners on the adyen form. Updating task now... [18:48:21] ok, cool [18:48:50] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, FR-Adyen, Patch-For-Review: add JCB to adyen Japan Form - https://phabricator.wikimedia.org/T188036#4011395 (DStrine) we do not need diners club on this form. [18:50:28] (PS2) Ejegg: Turn on JCB for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/415031 (https://phabricator.wikimedia.org/T188036) [18:54:08] (PS3) Ejegg: Turn on JCB for Adyen/Japan [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/415031 (https://phabricator.wikimedia.org/T188036) [18:56:00] ejegg: Let me know when you're done adjusting that one and I'll throw some quick review at it. [18:56:24] XenoRyet: should be all set, just whittled it down to only JCB & only JP [18:56:49] Cool [18:57:24] (CR) XenoRyet: [C: 2] Turn on JCB for Adyen/Japan [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/415031 (https://phabricator.wikimedia.org/T188036) (owner: Ejegg) [18:57:41] Easy peasy [18:59:18] (Merged) jenkins-bot: Turn on JCB for Adyen/Japan [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/415031 (https://phabricator.wikimedia.org/T188036) (owner: Ejegg) [19:54:07] hi AndyRussG [19:54:24] ejegg: helloz [19:54:49] i'm in the usual hangout, in case you want to talk about the donatewiki stuffs [19:56:25] ejegg: k :) [20:36:36] ejegg: MBeat awight are you about? [20:36:50] eileen: sure, what's up? [20:36:53] hola [20:37:15] my old GSOC student has an interest in doing a GSOC project on machine learning - best I can think of is on the fraud side [20:37:33] heh, cool [20:37:38] I thought if you guys were available I'd invite him on here to see if we can flesh out something projecty [20:37:54] neat [20:38:02] I think awight might have some more interesting projects, but he's moving house today [20:38:25] happy to share access to google docs, as there’s no PII in them but lots of data [20:38:29] yeah that's why I pinged him in hope [20:39:03] ok - I've told him to jump on so we should see him in a sec [20:39:16] hi eileen [20:39:22] saurabh: this is Michael Beattie (mbeat) [20:39:28] who works in donor services [20:39:46] hey mbeat [20:39:48] & Elliott ejegg who is in fundraising tech [20:39:51] hi saurabh [20:39:58] & various others who might pipe up :-) [20:39:58] hi saurabh ! [20:40:03] hello! [20:40:43] So saurabh did GSOC in 2016 & then worked for google last summer & is considering applying again for 2018 [20:40:49] CiviCRM has places in the programme [20:41:02] i think wmf applied too right [20:41:15] If we can scope out an appropriate project we could get him a place [20:41:24] I'm just trying to think how it might look / work [20:41:54] Wikimedia-Fundraising: Create translated versions of new Thank You page - https://phabricator.wikimedia.org/T185333#4011748 (Pcoombe) Okay I've looked at all these and can't see any obvious problems or missing translations. Made a few changes to the template: - You should specify a "language" parameter (up... [20:41:56] ccccccddfrjhujnefigghlkvktntkcvujjkieklkujrc [20:41:59] ack [20:42:19] I don't know machine learning well but I assume that it would take the data set of names / emails / addresses & 'look for patterns' of those marked as fraudsters [20:42:35] in some separate DB instance ? [20:43:03] eileen: yeah, we've at least got things marked as chargebacks [20:43:03] yup, that's fairly accurate [20:43:11] and ml need not be a big part of it [20:43:16] & then provide a page displaying suggestions of who else is a fraudster for manual review [20:43:46] i was in london in jan and visited Palantir's office [20:43:49] I don't know the PI on our including ip addresses in that mix [20:43:55] they're really big on this kind of stuff [20:44:02] oh nice - although cold in London in Jan [20:44:40] they use mostly rule-based fraud detection techniques as opposed to ml techniques [20:44:50] from what i could gather [20:45:04] unrelated though, please continue your train of thought [20:45:43] saurabh: our current fraud detectiom is all rule-based as well. We were thinking a bit of ML could at least help us tune the values for those filters [20:46:16] we use an external service for that & we configure the rules I believe [20:46:32] alright [20:46:43] ejegg: is awight down there with you later this week? [20:46:53] eileen: he shows up tonight! [20:47:13] cool - I wonder if we can plan a chat with him & saurabh later [20:47:48] i bet so... [20:48:04] why don't we try to do that & co-ordinate a hangout [20:48:26] saurabh: can go to bed now :-) [20:48:26] sure! [20:49:03] 2AM is like evening time in college tbh :-) [20:49:08] lol [20:49:25] plus i have exams to deal with [20:49:55] deadline to apply for gsoc is 12 March [20:50:18] yeah i think we can come up with something before that [20:50:34] so ejegg if you talk to Adam when you see him we can try to line up to talk at a time that suits him? [20:50:43] sure thing eileen [20:50:54] also, it'd be great if we could start up a mail thread for this [20:51:18] going back, reading through irc logs can get a bit cumbersome :-) [20:51:54] ok - I'll send an email out. I [20:52:13] thanks! signing out, have a great day [20:52:20] (PS11) Mepps: Script for Paypal refunds [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/411386 (https://phabricator.wikimedia.org/T186883) [20:52:47] XenoRyet, want to review that ^^ for testing? [20:53:10] Will do [20:55:36] (CR) XenoRyet: [C: 2] Script for Paypal refunds [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/411386 (https://phabricator.wikimedia.org/T186883) (owner: Mepps) [20:57:12] (Merged) jenkins-bot: Script for Paypal refunds [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/411386 (https://phabricator.wikimedia.org/T186883) (owner: Mepps) [20:58:35] mepps: I've gotta go grab some food, but let me know if that file looks ok and if you want to push some tests through let me know how that goes. [20:58:39] I'll be back in a while. [20:59:21] ejegg eileen, how do i update code only on staging? [20:59:37] oh wait, i guess there is no formal staging for paymentswiki [20:59:46] but could i update the code on frdev but not on prod? [21:01:09] mepps: hmm, frdev might be a nice place to put staging-payments [21:01:29] but yeah, unfortunately there is no staging-payments just yet [21:02:27] mepps if you want to update the crm code on frdev you can just use git commands [21:05:27] mepps: ^^ what he said :-) [21:05:53] hmm i guess there is no payments wiki code on frdev [21:06:05] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/415388 [21:06:30] oh - would someone like to hangout & I can show screenshots related to this one https://gerrit.wikimedia.org/r/#/c/415185/ - atlhough it may not have any actual review impact since the patch is just updating a composer package [21:08:17] eileen i can do that [21:09:24] mepps on the queen? [21:09:49] yup eileen, i'm there [21:10:09] lol [21:37:31] (CR) Mepps: [C: 2] Update phpWord per merged to master [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/415185 (https://phabricator.wikimedia.org/T187251) (owner: Eileen) [21:43:50] (Merged) jenkins-bot: Update phpWord per merged to master [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/415185 (https://phabricator.wikimedia.org/T187251) (owner: Eileen) [21:44:29] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/415388 (owner: Ejegg) [21:45:19] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/415388 (owner: Ejegg) [21:50:36] (CR) Mepps: [C: 2] Vendor update (add geocoding update) [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/414835 (owner: Eileen) [21:54:07] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/415458 [21:54:17] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/415458 (owner: Ejegg) [21:56:38] (Merged) jenkins-bot: Vendor update (add geocoding update) [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/414835 (owner: Eileen) [21:58:47] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/415458 (owner: Ejegg) [22:00:58] !log updated payments-wiki from 1acfc4a9a0 to 498f49a758 [22:01:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:09:26] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, FR-Adyen: Spike: setup Netherlands Adyen form with IDEAL - https://phabricator.wikimedia.org/T188035#4012053 (XenoRyet) a:XenoRyet [22:29:58] ejegg: I'm going to roll out the geocoder extension shortly [22:30:15] ok, cool. [22:30:25] I feel like I have mitigated risk of performance degredation - but wonder if we should take some before & after stats [22:30:59] as an aside - I did not cache postal code lookup results - but wondered if it made sense to [22:31:24] on one hand it's a big table & if we are effectively caching the whole thing then we should do that consciously [22:31:45] OTOH there may be some postal codes heavily used [22:32:12] eileen: what was the idea behind not doing the geocoding in _pre? [22:32:41] ejegg: well switching to the way CiviCRM actually expects geocoding to be done [22:32:56] (which also is available to the form) [22:33:02] I feel like the donors whose addresses are edited manually might be the same ones the we care about geo-searching for [22:33:16] oh, ok, so the geocoder will still kick in there [22:33:26] practically it's similar to pre - in the sense that that's when the format fn is called [22:33:48] but it's ALSO called from the search form - e.g if you want to enter a postal code rather than look up the stats [22:33:49] & it [22:33:58] is basically more standardised [22:34:16] if you look at the extension it's kinda a big solution that i want to encourage the community to use [22:34:53] ok, I didn't get too good a look at it, but I'll take some time on that [22:35:19] (PS1) Eileen: CiviCRM vendor update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/415472 [22:35:37] ok https://github.com/eileenmcnaughton/org.wikimedia.geocoder/blob/master/README.md [22:37:31] (CR) Eileen: [C: 2] CiviCRM vendor update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/415472 (owner: Eileen) [22:38:03] ejegg: I'll hold back on deploying it & give you a little time. [22:40:21] ok, I'm going to relocate (this office is emptying out) but I'll pick it back up from the apt [22:41:20] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Omnimail recipient load tripping over non-download... - https://phabricator.wikimedia.org/T184823#4012136 [22:42:10] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Spike: Can the engage import dedupe on import? - https://phabricator.wikimedia.org/T181090#4012138 (Eileenmcnaughton) a:Eileenmcnaughton [22:42:25] (Merged) jenkins-bot: CiviCRM vendor update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/415472 (owner: Eileen) [22:44:36] (PS1) Eileen: a5aee6d Vendor update (add geocoding update) [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/415473 [22:44:37] (PS1) Eileen: CiviCRM vendor update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/415474 [22:45:38] I'm deploying a minor civicrm update & the vendor update for geocoders (only) - will wait for ejegg[m] before deploying rest of geocoders but feel getting vendor out reduces risk of me deploying the other without it later [22:45:49] (CR) Eileen: [C: 2] CiviCRM vendor update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/415474 (owner: Eileen) [22:46:01] (CR) Eileen: [C: 2] a5aee6d Vendor update (add geocoding update) [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/415473 (owner: Eileen) [22:46:58] fundraising-tech-ops, Operations, ops-eqiad: rack frpig1001 - https://phabricator.wikimedia.org/T187365#4012153 (cwdent) @cmjohnson this server also needs the management pass reset [22:47:02] (Merged) jenkins-bot: a5aee6d Vendor update (add geocoding update) [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/415473 (owner: Eileen) [22:47:05] fundraising-tech-ops, Operations, ops-eqiad: rack frdata1001 - https://phabricator.wikimedia.org/T187364#4012154 (cwdent) @cmjohnson this server also needs the management pass reset [22:47:09] fundraising-tech-ops, Operations, ops-eqiad: rack frbast1001 - https://phabricator.wikimedia.org/T187363#4012155 (cwdent) @cmjohnson this server also needs the management pass reset [22:48:37] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Improve speed in creating pdfs by fixing the attempt to load css by http - https://phabricator.wikimedia.org/T188560#4012158 (Eileenmcnaughton) [22:50:12] Fundraising-Backlog: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4012170 (CCogdill_WMF) p:Triage>Normal [22:54:01] Fundraising-Backlog: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4012191 (CCogdill_WMF) [23:14:57] eileen: getting an api error: DB Error: no such table [23:15:04] when updb-ing locally [23:15:14] hmm [23:15:17] looking into what table that might be [23:15:48] thx [23:27:53] !log civicrm revision changed from a47eafcbad to 341c734a79, config revision is 62631813fc (update civicrm submodule & vendor but not geocoder extension as yet) [23:28:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:34:26] eileen: well, I figured out what table it's complaining about at least: Table 'civicrm.log_civicrm_geocoder' doesn't exist [23:35:41] looks like it created a trigger that tries to insert into that table [23:35:51] ejegg: hmm I guess that makes sense - ie. locally it creates a trigger [23:36:11] when deploying on live it would not until next generation [23:36:16] you want to do something to disable log tables for civicrm_geocoder? [23:36:26] well I think that table is small [23:36:41] we just maybe need to turn logging off & one when we deploy so the table is created [23:36:47] ah, so something should have created that log table? [23:36:51] & then next time we reload triggers it will be picked up [23:36:58] yeah = sequencing I think [23:37:01] like during the last civi db update? [23:37:15] ie. some refresh should have happened to reconcile the tables [23:37:27] ok, I'll turn it off and on again :) [23:37:28] & we tried to use if before it had [23:37:50] on staging / live the fact the triggers lag would have prevented that from being seen [23:37:51] that table's part of core tho, right? [23:37:56] no - it's new [23:38:01] ahh, gotcha [23:38:20] so, is that a bug in how logging interacts with extensions? [23:41:36] fr-tech: going afk, back in a bit! [23:43:16] if it creates the triggers but not the log tables? [23:48:11] ejegg: it should be an order thing - but it's a bit odd [23:49:02] so on an instance less screwy than my dev civi, someone could install the geocoder extn and then use it without problems? [23:49:20] well on live it will not create the triggers until ops do it for us [23:49:43] but yeah I think for others it would be ok because that's a core issue not something to do with the extension [23:51:43] so if you have logging enabled, and install an extension that creates an extra table [23:52:06] in theory it SHOULD create the log tables before the triggers.... [23:52:08] it should create both the extra log table and the triggers [23:52:19] but it seems to be doing it wrong for you [23:52:24] yeah [23:52:52] maybe this [23:52:53] https://github.com/civicrm/civicrm-core/pull/9896 [23:53:02] it's creating the trigger and trying to insert into it before the log table is there [23:53:09] turning logging off and on DID help [23:53:18] *fix the problem [23:54:42] hmm, I didn't see if it was doing the inserts via rebiuldMenuAndCaches, but maybe [23:55:47] eileen: yep, totally has that fn call in the trace [23:56:09] yeah - its annoying - but question is how much we should dig on it [23:56:37] Well, I'll add my 2 cents on that JIRA ticket and keep looking at the rest of the code [23:57:59] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Investigate getting output to word option to work bett... - https://phabricator.wikimedia.org/T187251#3969283 [23:58:13] ejegg: yeah I think so - we can leave solving that [23:59:45] cool, just wanted to understand if it was something with core or with my local instance, and whether it was known