[00:00:02] ejegg re your last patch [00:00:07] we want the paypalexpress adapter [00:00:14] because all the calls go through paypal express [00:00:29] ok, but you wanted that to be a command-line option, right? [00:00:36] so with --express it'll use that one [00:00:42] yes but it would only change the payment method [00:00:44] not the adapter [00:00:44] and without it'll use the normal one? [00:00:52] no, it should use express either way [00:00:57] ah, but the payment method should be 'paypal' for both [00:01:04] should it? [00:01:09] it's just the gateway code that changes from paypal to paypal_ec [00:01:11] then we can delete the express flag [00:01:21] ok [00:01:38] so with requireExtension [00:01:45] i was getting an error that that method didn't exist [00:01:53] yeah, it doesn't in 1.27 [00:02:25] Once I realized that, I made the other patch that XenoRyet merged [00:02:38] to make those calls conditional on the method existing [00:02:43] Are we thinking we'd want to actually do the refunds on Friday? If that seems like not a Friday thing either, there's probably not a huge push to get the thing deployed. [00:02:44] got it [00:02:52] Though I guess running some more small tests tomorrow might be nice. [00:03:12] XenoRyet, the testing revealed a lot so i'd like to keep testing tomorrow [00:03:19] in case we hit another blocker [00:03:43] Cool [00:04:24] I am here for another hour, so I can take a look and deploy if it's ready for that. [00:05:12] Well, slightly under an hour. I've got a hard out today. [00:05:24] i think so, ejegg? [00:06:20] mepps it should run, just would need the --express flag [00:06:33] or it'll try with the legacy adapter [00:06:38] I can undo that bit... [00:06:57] oh yeah, i can do that too ejegg if you'd prefer [00:07:30] sure! [00:08:05] my sister and her friend just showed up, think I'll sign off [00:08:15] have a good evening, all [00:08:21] See ya [00:12:21] (PS6) Mepps: Fixes after testing with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/415752 (https://phabricator.wikimedia.org/T186883) [00:12:38] okay XenoRyet, should be ready for review [00:12:52] 10-4, looking. [00:15:00] Oh, looks like the conditional around the requiredExtension call got undone. Probably need that back. [00:15:43] Otherwise looks good. [00:19:41] grr for some reason it didn't pull it in the commit--adding it [00:19:52] Figured it was something like that. [00:20:06] (PS7) Mepps: Fixes after testing with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/415752 (https://phabricator.wikimedia.org/T186883) [00:20:34] added ^^ [00:20:41] 10-4 [00:24:57] Ok yea, that's looking good. [00:25:47] Once jenkins slaps the V2 on, I'll do the C2 [00:26:00] After that, you want to deploy or should I? [00:26:12] (CR) XenoRyet: [C: 2] Fixes after testing with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/415752 (https://phabricator.wikimedia.org/T186883) (owner: Mepps) [00:26:23] go for it XenoRyet [00:26:29] Ok, will do. [00:32:59] (Merged) jenkins-bot: Fixes after testing with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/415752 (https://phabricator.wikimedia.org/T186883) (owner: Mepps) [01:10:29] (PS2) Eileen: Attempt to track file_get_contents [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/415500 [01:11:05] (Abandoned) Eileen: Attempt to track file_get_contents [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/415499 (owner: Eileen) [01:13:55] (CR) jerkins-bot: [V: -1] Attempt to track file_get_contents [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/415500 (owner: Eileen) [11:11:51] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4017141 (schoenbaechler) [11:14:48] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4017142 (schoenbaechler) Updated Desktop large ([[ https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/Edit/robin_20180302_dsk_lg_rtl_issues | Edit ]] | [[ https://he.wikip... [11:19:46] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4017157 (schoenbaechler) [11:24:14] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4017170 (schoenbaechler) @Pcoombe Re: “All - Shekel sign should be placed left of the amount (on PTF & "Donate with" CTA)” is that something you’ll handle via one of the core JS fi... [12:14:50] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4017329 (schoenbaechler) [13:28:19] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4017520 (schoenbaechler) [13:28:51] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4006959 (schoenbaechler) [13:29:20] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4006959 (schoenbaechler) [13:48:40] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4017617 (schoenbaechler) [13:56:36] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4017638 (schoenbaechler) [15:12:02] (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/415860 [15:17:10] (CR) Mepps: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/415860 (owner: Mepps) [15:18:08] (PS2) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/415860 [15:19:15] (PS1) Mepps: Updated refund script in DI [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/415866 [15:19:52] fr-tech doing a tiny deploy of the refund script changes only ^^ should not affect any other system [15:24:49] ok mepps hope all goes smooth :) [15:26:47] (PS2) Mepps: Updated refund script in DI [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/415866 [15:28:58] (CR) Mepps: [C: 2] Updated refund script in DI [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/415866 (owner: Mepps) [15:34:49] (CR) Mepps: [C: 1] Updated refund script in DI [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/415866 (owner: Mepps) [15:34:51] (CR) Mepps: [C: 2] Updated refund script in DI [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/415866 (owner: Mepps) [15:36:45] (Merged) jenkins-bot: Updated refund script in DI [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/415866 (owner: Mepps) [15:40:06] hmm it all went well up until the last minute, might have to wait on ejegg to figure this out [15:56:13] mepps: wha happen? [15:58:13] sorry, here I am! [15:58:25] mepps, what's the issue? [16:06:01] I'm told yesterday's staff community time was especially relevant for remoties, watching now... [16:32:08] fr-tech, be 1 minute late [16:32:15] well, 3 technically [16:48:22] dstrine / mepps / XenoRyet: meeting? [16:59:10] sorry fr-tech, i missed that it was earlier [17:00:08] mepps: we're still there, started quite late infact [17:06:26] (CR) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/415860 (owner: Mepps) [17:06:34] (CR) Mepps: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/415860 (owner: Mepps) [17:15:27] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/415860 (owner: Mepps) [17:22:56] !log updated payments-wiki 498f49a758 to ce68e8e80b [17:23:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:24:06] (PS2) Ejegg: Enable Adyen for CC in Netherlands [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/408347 [18:03:51] (PS1) Jgleeson: T176502: WIP add tests for hosted payment rejections* [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 [18:12:50] mepps, I've updated the error parsing test I mentioned on standup here https://gerrit.wikimedia.org/r/415907. Just waiting on for Ingenico to come back with the full list of event code descriptions and then I'll wrap it up. [18:15:59] have a great weekend fr-tech, catch you all next week o/ [18:20:12] (CR) Jgleeson: T176502: WIP add tests for hosted payment rejections* (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [19:25:20] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Patch-For-Review: Unintended recu... - https://phabricator.wikimedia.org/T186883#4018948 [20:39:25] (CR) Mepps: "JGleeson, I'm not sure I understand the purpose of PaymentStatusOutput since the response from Ingenico includes the message." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson)