[06:35:14] (CR) Legoktm: "Wow, I can't even vote +1 on this branch." [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/416196 (owner: Reedy) [07:48:29] (CR) Thiemo Kreuz (WMDE): [C: -1] Use SPDX 3.0 license identifier (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [14:00:24] (CR) Reedy: "Just fix it in gerrit so you can ;)" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/416196 (owner: Reedy) [15:00:50] (CR) Jgleeson: "mepps, my thinking behind adding the constant class (PaymentStatusOutput) was to give us a more convenient reference point for mapping eve" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [15:12:16] (CR) Mepps: "JGleeson, I can see that, but it seems more like documentation than useful code to me. Ejegg, what do you think?" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [15:26:53] (CR) Jgleeson: "I figured it might have value (outside its current test use case) as the failure code could be potentially important for future purposes s" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [15:58:29] hey fr-tech, is there a clean way to access and install an "in-progress" (unmerged) gerrit patch from composer? I guess I could branch & push to the remote but I wondered if there was a "nicer" way? [16:00:24] mepps, I'm wanting to test out in DI, the changes we've made in the Smashpig [16:00:39] to see if adding the errors key is all we need [16:00:47] or whether there's more work needed in the DI [16:01:23] hi jgleeson, in the short term since it's only one file right now--you could just manually place those changes in--not the cleanest but will work fine for testing [16:01:24] in relation to the journey outlined here https://etherpad.wikimedia.org/p/error-parsing [16:01:42] ah yeah, good idea! [16:01:50] thanks mepps [16:04:52] jgleeson: I'll often replace the dir in vendor with a symlink to the SmashPig working dir [16:05:08] cool, thanks [16:05:12] useful to know [16:05:12] not exactly clean, but gets all the changes without much work [16:06:48] good idea ejegg! [16:09:11] (PS1) Mepps: Push message to recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/416461 (https://phabricator.wikimedia.org/T186883) [16:11:16] (CR) jerkins-bot: [V: -1] Push message to recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/416461 (https://phabricator.wikimedia.org/T186883) (owner: Mepps) [16:13:06] (PS2) Mepps: Push message to recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/416461 (https://phabricator.wikimedia.org/T186883) [16:26:48] (CR) Ejegg: [C: -1] "Looks like we'd need some more code to make this work. There's nothing in the DI codebase just yet that deals with subscription start / en" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/416461 (https://phabricator.wikimedia.org/T186883) (owner: Mepps) [16:29:53] (CR) Ejegg: "I would tend to agree with mepps on this one. Consts for different codes might be useful programatically, but I'd prefer to have the varia" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [16:33:12] (CR) Jgleeson: "okay fair enough. I'll remove the class and its test. I'll replace the references in the tests with literal values and codes." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [16:50:06] (PS2) Jgleeson: T176502: WIP add tests for hosted payment rejections* [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 [18:03:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Missing sql fn gives a warning whenever we edit a comment - https://phabricator.wikimedia.org/T188931#4024426 (Ejegg) [18:04:10] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Missing sql fn gives a warning whenever we edit a comment - https://phabricator.wikimedia.org/T188931#4024437 (Ejegg) p:Triage>Normal a:Ejegg [18:05:13] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface, Patch-For-Review: Require PayPal account for EC donations - https://phabricator.wikimedia.org/T188671#4015712 (Ejegg) p:Triage>Normal a:... [18:07:22] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Missing sql fn gives a warning whenever we edit a comment - https://phabricator.wikimedia.org/T188931#4024452 (Ejegg) Looks like we're missing permissions on civicrm_strip_non_numeric. App... [18:32:11] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Create DonationInterface fraud filter that applies arbitrary regexes to arbitrary fields - https://phabricator.wikimedia.org/T188938#4024590 (Ejegg) [19:01:57] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Missing sql fn gives a warning whenever we edit a comment - https://phabricator.wikimedia.org/T188931#4024666 (cwdent) @Eileenmcnaughton should the grant for this be output in the trigger... [20:47:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: would drupal's x-autoload help our civi performance? - https://phabricator.wikimedia.org/T188573#4024996 (DStrine) [20:49:33] Fundraising-Backlog, fundraising-tech-ops: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4025005 (DStrine) [21:28:26] Fundraising-Backlog, fundraising-tech-ops: fr-tech needs some www-data access on payments to run scripts - https://phabricator.wikimedia.org/T188787#4019446 (Ejegg) Would be great to get sudo -u www-data for a few things. These are the scripts we might need to run, all under $IP/extensions/DonationInter... [21:31:52] Fundraising-Backlog: Spike: Automated Donation Tests (front-end) - https://phabricator.wikimedia.org/T188951#4025101 (jgleeson) [21:38:45] ejegg, mepps looks like we are gonna catch up tomorrow so I'm gonna call it a night. Have a great once fr-tech, catch you tomorrow! [21:38:56] see you in the morning! [22:09:48] ejegg: you are gonna run these on payments1004 then? [22:10:47] cwd yep! [22:43:55] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, FR-Adyen: Spike: setup Netherlands Adyen form with IDEAL - https://phabricator.wikimedia.org/T188035#4025288 (XenoRyet) Our current Adyen integration is currently only set up to handle credit card donations, so there wo... [23:38:52] (PS1) Ejegg: Add shebang and chmod +x for maintenance scripts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/416605