[14:04:35] Fundraising-Backlog, fundraising-tech-ops: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4038154 (Jgreen) >>! In T188561#4036898, @DStrine wrote: > @Jgreen or @cwdent do you have any thoughts here? Nope, let's add the other teams to the task to start the security rev... [15:31:18] (CR) Ejegg: [C: 2] "Grr, timestamp format flap..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/417701 (owner: Libraryupgrader) [15:37:24] (CR) Ejegg: [C: 1] "Looks good, just curious why we need to create a new adapter instance to cancel." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/417366 (https://phabricator.wikimedia.org/T186883) (owner: Mepps) [15:39:04] (CR) Ejegg: [C: 2] Update SPDX licenses [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/416196 (owner: Reedy) [15:39:29] (CR) Ejegg: [C: 2] "Thanks Reedy and Legoktm!" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/416196 (owner: Reedy) [15:43:50] ejegg: When that's merged... Should be good to do the DonationInterface patch too [15:45:15] nice, thanks again! [15:48:48] (Merged) jenkins-bot: Update SPDX licenses [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/416196 (owner: Reedy) [15:50:56] (PS5) Reedy: Use SPDX 3.0 license identifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [16:25:05] (PS4) Mepps: Add profile_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/417366 (https://phabricator.wikimedia.org/T186883) [16:36:06] (CR) Ejegg: [C: 2] Use SPDX 3.0 license identifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [16:38:44] (Merged) jenkins-bot: Use SPDX 3.0 license identifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/407275 (https://phabricator.wikimedia.org/T183858) (owner: Legoktm) [16:39:02] (PS5) Ejegg: Add profile_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/417366 (https://phabricator.wikimedia.org/T186883) (owner: Mepps) [16:39:11] (CR) Ejegg: [C: 2] Add profile_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/417366 (https://phabricator.wikimedia.org/T186883) (owner: Mepps) [16:44:02] (Merged) jenkins-bot: Add profile_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/417366 (https://phabricator.wikimedia.org/T186883) (owner: Mepps) [16:52:41] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never inten... - https://phabricator.wikimedia.org/T184284#4038619 [16:58:05] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, and 2 others: Unintended recurring: p... - https://phabricator.wikimedia.org/T186883#4038628 [17:29:04] Fundraising-Backlog, fundraising-tech-ops: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4038700 (DStrine) @Jgreen and @cwdent Can you please loop in the appropriate teams? [17:46:08] (Abandoned) Mepps: Push message to recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/416461 (https://phabricator.wikimedia.org/T186883) (owner: Mepps) [17:46:19] (Abandoned) Mepps: Add logging for errors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/404806 (https://phabricator.wikimedia.org/T184284) (owner: Mepps) [18:27:41] Fundraising-Backlog, fundraising-tech-ops: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4038876 (cwdent) Adding @JBennett @MoritzMuehlenhoff for review [19:20:02] (PS1) Imarlier: ext.CentralNotice.geoIP.tests: Make sure we don't hit fallback logic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/418026 (https://phabricator.wikimedia.org/T189325) [19:20:46] (CR) Mepps: [C: 1] "Read through this and it looks good but I definitely don't know enough about this code base to approve." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/408488 (https://phabricator.wikimedia.org/T185932) (owner: AndyRussG) [20:01:40] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice geoIP tests may fail, depending on client configuration - https://phabricator.wikimedia.org/T189325#4039145 (AndyRussG) [20:02:27] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice geoIP tests may fail, depending on client configuration - https://phabricator.wikimedia.org/T189325#4039023 (AndyRussG) @Imarlier thanks for this!!!! [20:02:49] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance-Team, Patch-For-Review: CentralNotice geoIP tests may fail, depending on client configuration - https://phabricator.wikimedia.org/T189325#4039149 (AndyRussG) [20:03:08] mepps: ^ thanks for the CR! :) [22:34:17] (PS1) Anomie: Update CommentStore usage [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/418147 [22:34:19] (PS1) Anomie: Update for the actor table change [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/418148 (https://phabricator.wikimedia.org/T167246) [23:20:24] have a good weekend fr-tech!