[01:21:14] (CR) Krinkle: [C: 2] ext.CentralNotice.geoIP.tests: Make sure we don't hit fallback logic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/418026 (https://phabricator.wikimedia.org/T189325) (owner: Imarlier) [01:21:51] (CR) Krinkle: [C: 1] ext.CentralNotice.geoIP.tests: Make sure we don't hit fallback logic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/418026 (https://phabricator.wikimedia.org/T189325) (owner: Imarlier) [02:48:00] (PS1) Eileen: Wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419097 [02:48:02] (PS1) Eileen: Fix code to handle comma in formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419098 (https://phabricator.wikimedia.org/T189259) [02:50:21] (CR) jerkins-bot: [V: -1] Wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419097 (owner: Eileen) [02:51:15] (CR) jerkins-bot: [V: -1] Fix code to handle comma in formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419098 (https://phabricator.wikimedia.org/T189259) (owner: Eileen) [02:52:50] (PS2) Eileen: Fix code to handle comma in formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419098 (https://phabricator.wikimedia.org/T189259) [02:52:52] (PS2) Eileen: Wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419097 [02:54:46] (CR) jerkins-bot: [V: -1] Wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419097 (owner: Eileen) [06:22:41] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Winter Wanderland, and 4 others: Centra... - https://phabricator.wikimedia.org/T171987#3482312 [10:16:30] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Winter Wanderland, and 4 others: Centra... - https://phabricator.wikimedia.org/T171987#4045906 [15:50:10] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Remove Santander from Brazil payment methods - https://phabricator.wikimedia.org/T189602#4046973 (Ejegg) [15:52:04] (PS1) Ejegg: Remove Santander from Brazil / Bank Transfer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/419210 (https://phabricator.wikimedia.org/T189602) [15:54:30] fr-tech, anyone want to review the Ingenico hosted iframe to move https://phabricator.wikimedia.org/T184288 along? [15:54:42] i can do that ejegg [15:54:50] thanks! [15:54:54] beat me to it :) [15:55:05] ejegg is there a patch? [16:00:00] mepps nope, it was all via the durn in-browser editor [16:00:02] :( [16:00:28] which loves to log you out in the middle of an editing session... [16:00:48] ahh ejegg--if it's what i'm seeing locally, it looks great1 [16:01:02] cool! [16:01:41] Fundraising-Backlog: frdev1001 and MySQL access for Guillaume - https://phabricator.wikimedia.org/T189247#4036531 (cwdent) Hi @gpaumier, can you please: - generate a new ssh key for fundraising access and post the public key on this task - email me the output of a couple yubikey presses And I will get yo... [16:05:17] morning XenoRyet! [16:05:37] did you paste that contribution_recur SQL someplace? [16:05:44] I'd be happy to look it over [16:06:07] I couldn't decide where the best place to put it would be. Etherpad maybe? [16:06:20] sure, or as a Phab paster [16:06:23] *paste [16:06:45] those get syntax highlighting [16:07:01] Right, I forgot Phab did that. [16:07:09] Gimme one second, I'll put it up. [16:10:03] Our table names and such aren't sensitive, are they? Don't need to make this private? [16:10:31] no, table names aren't [16:11:05] https://phabricator.wikimedia.org/P6842 [16:11:14] There you go. [16:12:44] looks like a missing close-quote after the date (thanks, syntax-highlight!) [16:13:11] On cancel date? Saw that as I pasted, should be fixed now. [16:13:42] I had that as now() but decided a specific datetime would make these identifiable if we ever needed to do that. [16:14:00] good call [16:27:42] OK, XenoRyet, looks good to me. [16:31:19] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Update Ingenico hosted style to match new payments form CSS - https://phabricator.wikimedia.org/T184288#4047121 (mepps) Open>Resolved Looks great! [16:37:37] https://amdflaws.com/ [16:37:50] (CR) XenoRyet: [C: 2] Remove Santander from Brazil / Bank Transfer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/419210 (https://phabricator.wikimedia.org/T189602) (owner: Ejegg) [16:37:58] (i'll believe it when I see some CVEs) [16:38:29] who is CTS-Labs ? [16:39:15] apparently something with a large marketing dept [16:39:38] (Merged) jenkins-bot: Remove Santander from Brazil / Bank Transfer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/419210 (https://phabricator.wikimedia.org/T189602) (owner: Ejegg) [16:50:15] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Winter Wanderland, and 2 others: Stat1005 BH data i... - https://phabricator.wikimedia.org/T181811#4047200 [16:53:12] dstrine: finally commented on the BH issue task... many apologies!!!!!!! [16:53:44] and many thx for the multiple reminders......... [16:55:14] AndyRussG: so, how do we test the CN event logging stuff on beta? [16:57:00] ejegg: easy peasey for the client side... activate it via the mixin on any campaign [16:57:27] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Fr-Ingenico-integration_2017-18, Patch-For-Review: Ingenico adapter: parse response errors - https://phabricator.wikimedia.org/T176502#4047222 (jgleeson) So it looks like we already have the general layer of excepti... [16:59:15] ejegg: I dunno if it's worth trying to test anything serer-side on beta... I guess maybe not worth testing the rate since it's on a scale orders of magnitude different than production. I guess at least on beta there should be a way to test that the data is validated and ingressed onto whatever EL systems there are there [17:18:05] hey all. Was stuck in crazy crazy traffic. going offline again for a quick second but will be on for the 11am meeting some of you are invited to. brb [17:22:01] AndyRussG: I just enabled the EL tracking on aa.wikipedia.beta.wmflabs.org [17:22:36] I see the banner, and the logging seems to fire (i can step in to the navigator.sendBeacon call) [17:22:50] but it never shows up in ff developer tools network tab [17:23:00] do you see sendBeacon stuff in the network tab? [17:23:12] Or is that just a weird omission in the logging? [17:28:03] ejegg: hmmm you should see it [17:28:18] for a time you didn't, but I'm pretty sure that bug was fixt [17:28:42] FundraiserLandingPages seems pretty straightforward [17:28:49] :) [17:29:10] huh, yeah, I see the request in dev tools under chromium [17:30:55] I guess it's a POST to keep any intermediate boxes from caching it? [17:32:34] we got a new puppy :S https://sadbastard.org/photo/shy.jpg [17:32:53] just wandered in ? [17:32:59] v cute [17:33:14] cwd: awwww [17:33:39] (PS1) XenoRyet: Cancel unintended Ingenico subscriptios [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419232 (https://phabricator.wikimedia.org/T186883) [17:33:41] one of our neighbors brought home a stray that got knocked up by another stray here and had 9 of these [17:33:53] oh wow [17:34:15] ejegg: huh.... dunno, in truth. BTW when I was testing I do recall initially running into something like that on FF, but eventually being able to see the requests there, too.... Don't reacall the reason [17:34:24] I can peek [17:34:32] ejegg: ^ there's that civicrm.install patch with the query [17:34:42] eh, no worries, I can test in chromium AndyRussG [17:34:55] (CR) jerkins-bot: [V: -1] Cancel unintended Ingenico subscriptios [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419232 (https://phabricator.wikimedia.org/T186883) (owner: XenoRyet) [17:34:55] yep XenoRyet, taking a look [17:35:31] got some tabs instead of the drupally 2 spaces we're trying to use, but other than that looks it looks good! [17:35:49] Sure, I can fix the tabs thing. [17:36:05] oops, syntax error too! [17:36:22] i spoke too soon [17:36:47] no worries [17:37:00] looks like just a double close-brace on the last line [17:37:02] ejegg: ok thx! [17:38:32] I bet I know what that was. Got this new mechanical keyboard and it's got a super light activation pressure. If I even think about hitting a key, it types. [17:39:28] what switches? [17:40:00] mine favorite: https://deskthority.net/wiki/Cherry_MX_Clear [17:40:31] Cherry MX Speed on this one [17:40:52] I was using the blues for a while, but I like these a bit better. [17:41:10] blues are fun at first [17:41:21] but annoying in the long run [17:41:22] imo [17:41:27] Yea, same here. [17:41:29] Fundraising-Backlog: frdev1001 and MySQL access for Guillaume - https://phabricator.wikimedia.org/T189247#4047388 (gpaumier) Public key: ``` ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC0QEKBKbjJmBXND7vcohpw4dyMwEQ8bgWy/HbbiKPF9/ZjdovdNjauuX9yVKDcHf9xXAQBuW6GlhmxEbzsgMCvcQnWqu6QCopgAadnJqlKV4w2r3z3WImXAXhU1flh/PZ... [17:46:44] (PS2) XenoRyet: Cancel unintended Ingenico subscriptios [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419232 (https://phabricator.wikimedia.org/T186883) [17:58:47] (PS3) Ejegg: Cancel unintended Ingenico subscriptios [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419232 (https://phabricator.wikimedia.org/T186883) (owner: XenoRyet) [17:59:05] (CR) Ejegg: [C: 2] Cancel unintended Ingenico subscriptios [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419232 (https://phabricator.wikimedia.org/T186883) (owner: XenoRyet) [18:03:59] (Merged) jenkins-bot: Cancel unintended Ingenico subscriptios [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419232 (https://phabricator.wikimedia.org/T186883) (owner: XenoRyet) [18:18:36] XenoRyet: want to do the merge & deploy on that one? [18:19:20] Listening to the last bit of this meeting, but yea. [18:35:32] (PS1) XenoRyet: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/419249 [18:35:48] (CR) XenoRyet: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/419249 (owner: XenoRyet) [18:37:07] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/419249 (owner: XenoRyet) [18:39:44] !log updated civicrm from 8652db05f5 to c8458c4a2f [18:39:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:42:00] Fundraising-Backlog: RML email source yielding only email addresses - https://phabricator.wikimedia.org/T189612#4047550 (MBeat33) [18:48:49] fr-tech dstrine-brb following up on discussion with K4-713 (dunno if others have talked about this? maybe I missed something somewhere?) it seems we need a rough timeline for completing all the different pieces of the new Kafka/EventLogging pipeline... OK if I make a task for that? Or maybe there's already a timeline somewhere I didn't see? thx!!!!!! [18:49:18] No existing timeline that I know of, and a task seems like a great idea to me. [18:49:34] agreed! [18:53:07] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, and 2 others: Unintended recurring: p... - https://phabricator.wikimedia.org/T186883#4047602 [18:53:39] AndyRussG: Thanks for diving in to that. I don't have a timeline doc yet, so I think you're clear to start fresh. [18:55:20] K4-713 XenoRyet mepps K thanks! [19:08:40] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Skope: Ingenico Connect: if we need 3rd-party cookies in their iframe, implement same thing as we have with Adyen - https://phabricator.wikimedia.org/T184289#4047645 (Ejegg) a:Ejegg [19:12:15] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Skope: Ingenico Connect: if we need 3rd-party cookies in their iframe, implement same thing as we have with Adyen - https://phabricator.wikimedia.org/T184289#4047659 (Ejegg) Investigated... [19:14:03] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface, and 2 others: Require PayPal account for EC donations - https://phabricator.wikimedia.org/T188671#4047666 (Ejegg) Open>Resolved [19:14:39] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface, and 2 others: Require PayPal account for EC donations - https://phabricator.wikimedia.org/T188671#4015712 (Ejegg) @ppena this is up in production, w... [19:14:50] Fundraising-Backlog: Make a rough timeline/roadmap for Kafkatee changes - https://phabricator.wikimedia.org/T189613#4047669 (AndyRussG) [19:15:36] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Epic: [Epic] Kafkatee changes - https://phabricator.wikimedia.org/T183978#4047682 (AndyRussG)... [19:15:56] K done ^ [19:25:12] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, FR-Adyen: Spike: setup Netherlands Adyen form with IDEAL - https://phabricator.wikimedia.org/T188035#4047700 (XenoRyet) Open>Resolved [19:29:18] AndyRussG: so, the CN / EL stuff looks fine on beta as far as I can tell [19:29:42] just not sure where to find the eventlogging output [19:48:43] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, FR-Adyen, MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Patch-For-Review: add JCB to adyen Japan Form - https://phabricator.wikimedia.org/T188036#4047755 (Ejegg) Open>Resolved a:Ejegg [19:50:11] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, and 2 others: CentralNotice: use Even... - https://phabricator.wikimedia.org/T185932#4047760 [19:59:39] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: EpicCan the engage import dedupe on import? - https://phabricator.wikimedia.org/T181090#4047780 (DStrine) [20:00:04] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Epic: Can the engage import dedupe on import? - https://phabricator.wikimedia.org/T181090#3779233 (DStrine) [20:03:33] https://i.imgur.com/ckg4AcQ.png [20:04:18] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Step 1 and 2 of engage import - https://phabricator.wikimedia.org/T189617#4047790 (DStrine) [20:04:46] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Step 1 , 2 and 3 of engage import - https://phabricator.wikimedia.org/T189617#4047790 (DStrine) [20:06:08] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never inten... - https://phabricator.wikimedia.org/T184284#4047807 [20:16:04] MBeat: if your new staff member doesn't have the account email he can request a new one from the front page [20:16:36] ah, thank you eileen - he’ll check his spam folder & request if it’s not there [20:20:24] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: try one internal transaction for new ingenico - https://phabricator.wikimedia.org/T189622#4047879 (DStrine) [20:23:04] Re the paypal cancel recurring - that functionality IS in core but I've been trying to figure out whether it works in the long attempts to clarify this ticket https://issues.civicrm.org/jira/browse/CRM-20800 [20:27:46] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People... - https://phabricator.wikimedia.org/T183293#4047912 [20:27:50] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint F 2018, and 3 others: CentralNotice: us... - https://phabricator.wikimedia.org/T185932#4047913 [20:27:57] Fundraising Sprint F 2018, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: try one internal transaction for new ingenico - https://phabricator.wikimedia.org/T189622#4047915 (DStrine) [20:28:01] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint F 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Step 1 , 2 and 3 of engage import - https://phabricator.wikimedia.org/T189617#4047916 (DStrine) [20:28:04] Fundraising Sprint F 2018, Fundraising-Backlog: Make a rough timeline/roadmap for Kafkatee changes - https://phabricator.wikimedia.org/T189613#4047917 (DStrine) [20:28:10] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint F 2018, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Remove Santander from Brazil payment methods - https://phabricator.wikimedia.org/T189602#4047918 (DStrine) [20:28:26] Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint F 2018, Fundraising-Backlog, and 2 others: Omnimail recipient load tripping over non-downloaded f... - https://phabricator.wikimedia.org/T184823#4047921 [20:28:28] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People... - https://phabricator.wikimedia.org/T178930#4047922 [20:28:41] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People... - https://phabricator.wikimedia.org/T176334#4047923 [20:28:44] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint F 2018, and 5 others: CentralNotice: Sa... - https://phabricator.wikimedia.org/T171987#4047924 [20:28:47] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint F 2018, and 6 others: XSS in central no... - https://phabricator.wikimedia.org/T175900#4047925 [20:29:11] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint F 2018, and 3 others: Unintended recurr... - https://phabricator.wikimedia.org/T186883#4047927 [20:29:13] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint F 2018, Fundraising-Backlog: Donate... - https://phabricator.wikimedia.org/T185933#4047929 [20:29:23] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint F 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Missing sql fn gives a warning whenever we edit a comment - https://phabricator.wikimedia.org/T188931#4047930 (DStrine) [20:29:25] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint F 2018, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Skope: Ingenico Connect: if we need 3rd-party cookies in their iframe, implement same thing as we have with... - https://phabricator.wikimedia.org/T184289#4047931 [20:29:28] Fundraising Sprint F 2018, Fundraising-Backlog, FR-Ingenico, FR-Smashpig, Fr-Ingenico-integration_2017-18: Implement Ingenico Connect API calls for tokenized payments - https://phabricator.wikimedia.org/T163953#4047932 (DStrine) [21:00:10] https://www.azara.io/jobs/ [21:00:39] weed retailer software written in haskell written in javascript written in boulder [21:00:48] the future is weird [21:06:08] luvit [21:07:28] lol [21:07:33] heading off, bye all! [21:14:20] (PS3) Ejegg: Fix code to handle comma in formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419098 (https://phabricator.wikimedia.org/T189259) (owner: Eileen) [21:15:30] (CR) Ejegg: [C: 2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419098 (https://phabricator.wikimedia.org/T189259) (owner: Eileen) [21:20:26] (Merged) jenkins-bot: Fix code to handle comma in formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419098 (https://phabricator.wikimedia.org/T189259) (owner: Eileen) [21:34:45] (PS2) Ejegg: $wgJsMimeType is deprecated [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/416218 (owner: MaxSem) [21:35:25] (CR) Ejegg: [C: 2] "Thanks for the cleanup MaxSem!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/416218 (owner: MaxSem) [21:35:46] XenoRyet: want to put that CRM update out? There's another little patch from eileen just merged [21:36:26] The one with the update query? It's already out. [21:36:37] oh, rockin! [21:36:47] Yea, query looks like it ran fine. [21:37:32] (PS1) Ejegg: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/419313 [21:37:55] AndyRussG: Let me know if that merge looks too big -- I'll do a cherry-pick if you'd prefer [21:37:58] ^^^ [21:39:13] (CR) jerkins-bot: [V: -1] $wgJsMimeType is deprecated [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/416218 (owner: MaxSem) [21:39:55] (CR) jerkins-bot: [V: -1] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/419313 (owner: Ejegg) [21:40:34] ejegg: Oki thanks, I have to AFK for about 1hr or so, I'll check it out when I get back!! :) [21:41:15] (CR) jerkins-bot: [V: -1] $wgJsMimeType is deprecated [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/416218 (owner: MaxSem) [21:42:49] (CR) MaxSem: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/416218 (owner: MaxSem) [21:44:31] ejegg: regarding those potential non-US currencies - I think the comma is being added when MG handles the csv file - ie. when I looked at it they were not present [21:44:44] ahh, ok [21:45:03] in the parent mungeMessage method, we deal with the commas for the generic 'gross' field [21:45:56] we just can't move the stuff up trivially because the Benevity file has its special currency conversion [21:46:14] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Step 1 , 2 and 3 of engage import - https://phabricator.wikimedia.org/T189617#4048110 (Eileenmcna... [22:03:03] (PS2) Ejegg: Clean up stray OldCookieEpoch settings [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/410614 [22:03:06] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/419318 [22:03:49] (PS10) Ejegg: Rename some impressionDiet variables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319003 (https://phabricator.wikimedia.org/T121178) [22:04:13] (CR) Ejegg: "recheck" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/419313 (owner: Ejegg) [22:06:12] ejegg: yeah I should get to those tooooooo ^ [22:06:29] heh, thanks! [22:09:57] likewise! [22:12:16] (PS3) Ejegg: ext.CentralNotice.geoIP.tests: Make sure we don't hit fallback logic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/418026 (https://phabricator.wikimedia.org/T189325) (owner: Imarlier) [22:12:52] (CR) Ejegg: [C: 2] "Looks correct, fixes JS tests for me locally when I've got the GeoIP module set in LocalSettings." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/418026 (https://phabricator.wikimedia.org/T189325) (owner: Imarlier) [22:13:40] AndyRussG: hitting the road, but let's try to get the EventLogging thing ready for tomorrow. I'll check back in later this evening. [22:15:19] (Merged) jenkins-bot: ext.CentralNotice.geoIP.tests: Make sure we don't hit fallback logic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/418026 (https://phabricator.wikimedia.org/T189325) (owner: Imarlier) [22:33:56] ejegg|away: ok! [22:38:53] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/419318 (owner: Eileen) [22:40:03] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/419318 (owner: Eileen) [22:52:08] !log civicrm revision changed from c8458c4a2f to 9e79d63426, config revision is 08b7e6216e (Benevity comma fix) [22:52:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:55:51] Fundraising-Backlog, fundraising-tech-ops: frdev1001 and MySQL access for Guillaume - https://phabricator.wikimedia.org/T189247#4048290 (cwdent) a:cwdent [23:11:10] interesting comments from Tim (on chat.civicrm.org) - he has been testing redis instead of civicrm_prevnext_cache table & found it faster [23:19:30] oooh [23:19:34] that sounds nice [23:43:31] (PS1) Eileen: Dedupe Engage imports when email+name matchable, or when anonymous. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419331 (https://phabricator.wikimedia.org/T189617) [23:43:46] cwd yeah - kind of interesting huh [23:44:09] I don't have that much experience with Reddis personally but I know we've been looking at it a bit [23:44:40] It's actually already possible to use reddis caching instead of php static caching I believe [23:46:58] I've just pushed up the first patch for Engage matching - https://gerrit.wikimedia.org/r/#/c/419331/ - it's got a couple of questions on it [23:47:15] many I should note them on the phab to get @leannes input [23:48:19] (CR) jerkins-bot: [V: -1] Dedupe Engage imports when email+name matchable, or when anonymous. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419331 (https://phabricator.wikimedia.org/T189617) (owner: Eileen) [23:49:16] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Step 1 , 2 and 3 of engage import - https://phabricator.wikimedia.org/T189617#4048441 (Eileenmcna... [23:49:47] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Step 1 , 2 and 3 of engage import - https://phabricator.wikimedia.org/T189617#4048442 (Eileenmcna... [23:51:50] (PS2) Eileen: Dedupe Engage imports when email+name matchable, or when anonymous. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419331 (https://phabricator.wikimedia.org/T189617) [23:56:32] (CR) jerkins-bot: [V: -1] Dedupe Engage imports when email+name matchable, or when anonymous. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419331 (https://phabricator.wikimedia.org/T189617) (owner: Eileen)