[14:17:09] mepps, ejegg|afk would be great to get your views on the *latest* attempts to progress ingenico error handling. I've added some notes here outlining the latest changes https://phabricator.wikimedia.org/T176502#4057627 [14:36:25] jgleeson, i've been looking a bit this morning, still thinking about it [14:49:20] also, how was your weekend jgleeson? [15:01:34] mepps, it was pretty exhausting. A friend of mine is getting married next week so we had a bachelor party for him. I also decided to try and bring my garden back to life now that the worst of the cold weather is passed so coffee is my friend today [15:02:05] how about you? [15:03:56] I just realised my irc cloak has finally kicked in! [15:15:28] that's exciting about your garden! [15:26:04] hi mepps / jgleeson ! [15:26:09] looking at that latest code... [15:26:19] hey ejegg [15:27:42] (CR) Mepps: T176502 WIP: Updated Ingenico error handling (8 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [15:28:05] jgleeson/ejegg ^^ my impressions [15:28:16] definitely improvement jgleeson!! [15:28:51] (especially over my patch ;) ) [15:31:51] thanks will take a look shortly, brb! [15:43:41] (CR) Mepps: [C: 2] Call tokenize payment API [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/419950 (https://phabricator.wikimedia.org/T163953) (owner: Ejegg) [15:44:07] (Merged) jenkins-bot: Call tokenize payment API [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/419950 (https://phabricator.wikimedia.org/T163953) (owner: Ejegg) [15:44:53] (CR) Mepps: [C: 2] Delete phpoffice samples from vendor [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/418967 (owner: Ejegg) [15:52:53] (Merged) jenkins-bot: Delete phpoffice samples from vendor [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/418967 (owner: Ejegg) [16:03:15] ejegg should we close this https://phabricator.wikimedia.org/T189521? [16:03:55] o/ same question about this one: https://phabricator.wikimedia.org/T188787 [16:06:01] mepps sure! [16:06:11] cwd sounds good too [16:06:21] ty [16:06:32] Fundraising-Backlog, fundraising-tech-ops: fr-tech needs some www-data access on payments to run scripts - https://phabricator.wikimedia.org/T188787#4061661 (cwdent) Open>Resolved a:cwdent [16:07:24] Fundraising-Backlog, fundraising-tech-ops: frdev1001 and MySQL access for Guillaume - https://phabricator.wikimedia.org/T189247#4061667 (cwdent) Open>Resolved [16:09:53] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Missing sql fn gives a warning whenever we edit a comment - https://phabricator.wikimedia.org/T188931#4024426 (mepps) @Eileenmcna... [16:13:29] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", an... - https://phabricator.wikimedia.org/T186883#4061705 [16:39:26] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", an... - https://phabricator.wikimedia.org/T186883#4061749 [17:03:47] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Missing sql fn gives a warning whenever we edit a comment - https://phabricator.wikimedia.org/T188931#4061851 (cwdent) Since the... [17:17:27] (CR) Jgleeson: T176502 WIP: Updated Ingenico error handling (5 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [17:33:28] Fundraising-Backlog, fundraising-tech-ops: Update ccogdill's yubikey (Help, I lost mine!) - https://phabricator.wikimedia.org/T189905#4061955 (DStrine) [17:54:11] (CR) Mepps: T176502 WIP: Updated Ingenico error handling (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [17:56:31] ejegg would love your thoughts on the Ingenico error handling [18:00:22] mepps looks like a good way to go forward! [18:10:27] mepps, I am not overly happy about how it is working at the moment. I don't like the idea of an API client knowing too much about the response so I'm gonna move a few things around [18:11:10] I also don't like the naming conventions I introduced as they're not relevant to the domain in hindsight [18:11:41] we have an errors key which is populated, triggers an exception... but then we enrich the repsonse with the same key, if we find a "lower-level" error [18:11:49] just feels confusing [18:12:17] if populated* [18:17:36] (CR) Jgleeson: "As mentioned on IRC. I'm going to do some refactoring around this and get rid of the messy check errors stuff in the api client and instea" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [18:18:37] jgleeson: totally agreed [18:18:58] each of the things that uses the API should know where to look for those lower-level errors [18:19:19] for the specific types of payment [18:19:34] that's what I'm thinking [18:47:50] jgleeson so if i'm understanding what you're thinking--you'll move the lowlevel error search to the specific api call that would return that error, not to DI right? [18:48:23] mepps that's where I'd hope to have it [18:48:35] ejegg which is where you'd hope to have it? [18:48:57] the specific api call? [18:49:03] the HostedCheckoutProvider, e.g. [18:49:20] would check for the specific errors under createdPaymentOutput [18:49:58] that would make sense to me [18:50:03] ^^ [18:50:10] okay cool [18:51:17] fundraising-tech-ops: Give civi staging mysql user access to fredge - https://phabricator.wikimedia.org/T189787#4062183 (cwdent) [18:51:19] Fundraising-Backlog, fundraising-tech-ops: CiviCRM sql user has access to fredge on live but not staging - https://phabricator.wikimedia.org/T189760#4062185 (cwdent) [18:51:45] and then it means the try/catch block can just look for what was previously known as top level error, which will now become ErrorResponse based on something similar to this. https://github.com/Ingenico-ePayments/connect-sdk-php/blob/master/src/Ingenico/Connect/Sdk/Domain/Errors/ErrorResponse.php [18:53:17] fr-tech, gotta pop out to pick up my family. Back soon! [18:53:27] nick jgleeson|afk [18:53:29] lol [18:53:32] try again. [18:54:23] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Missing sql fn gives a warning whenever we edit a comme... - https://phabricator.wikimedia.org/T188931#4062195 [19:38:08] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Step 1 , 2 and 3 of engage import - https://phabricator.wikimedia.org/T189617#4062326 (Eileenmcnaughton) I think I... [19:38:20] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, and 2 others: Create job on americium to deliver ... - https://phabricator.wikimedia.org/T189820#4062327 [19:43:14] Fundraising-Backlog, fundraising-tech-ops: Update ccogdill's yubikey (Help, I lost mine!) - https://phabricator.wikimedia.org/T189905#4062343 (cwdent) Open>Resolved a:cwdent [19:43:45] Fundraising-Backlog: CPS report of high donation volume in IT - https://phabricator.wikimedia.org/T189697#4062345 (DStrine) @Mpany can you share any more detail on this? Can you share the data you are looking at or the query you ran? [19:45:30] Fundraising-Backlog, Wikimedia-Fundraising: Move fundraising support pages to donate.wikimedia.org - https://phabricator.wikimedia.org/T189668#4049417 (DStrine) @Pcoombe do you need anything from fr-tech on this? [19:46:17] Fundraising-Backlog, Wikimedia-Fundraising: Move fundraising thank you pages to donate.wikimedia.org - https://phabricator.wikimedia.org/T189664#4049347 (DStrine) @Pcoombe let us know if you need anything from fr-tech [19:50:10] PROBLEM - check_puppetrun on frpm1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Exec[pbuilder create --distribution jessie] [19:50:40] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Winter Wanderland, and 2 others: Stat1005 BH data i... - https://phabricator.wikimedia.org/T181811#4062383 [19:55:10] RECOVERY - check_puppetrun on frpm1001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [20:21:34] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Missing sql fn gives a warning whenever we edit a comme... - https://phabricator.wikimedia.org/T188931#4062479 [20:24:05] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Add Banner Guidelines link to banner edit screen - https://phabricator.wikimedia.org/T190089#4062486 (DStrine) [20:25:58] Fundraising-Backlog, Wikimedia-Fundraising: Move fundraising support pages to donate.wikimedia.org - https://phabricator.wikimedia.org/T189668#4062498 (Pcoombe) @DStrine Not until we've moved the pages. Then we'll need help for the changes to DonationInterface and the Thank You email. [20:39:03] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", an... - https://phabricator.wikimedia.org/T186883#4062515 [20:45:04] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Step 1 , 2 and 3 of engage import - https://phabricator.wikimedia.org/T189617#4062520 (LeanneS) I see a few error m... [20:48:20] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Step 1 , 2 and 3 of engage import - https://phabricator.wikimedia.org/T189617#4062536 (Eileenmcnaughton) Hmm error... [22:39:31] Fundraising-Backlog: Ingenico audit wobble? March 13 refunds not in Civi - https://phabricator.wikimedia.org/T190098#4062989 (MBeat33) [22:55:06] Fundraising-Backlog, FR-Smashpig, MediaWiki-extensions-DonationInterface: Break DonationInterface fraud filters off into service - https://phabricator.wikimedia.org/T190099#4063016 (Ejegg) [22:57:33] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Option to enforce CSP on banner previews and flag errors - https://phabricator.wikimedia.org/T190100#4063031 (Ejegg)