[00:21:09] eileen: civi restore is going on 11 hours now [00:21:30] i granted perms for dev_fredge earlier...that one should only take a sec, once this finishes [00:23:50] cwd thanks [00:25:21] i will let you know when it's done :) [00:31:20] eileen: did you see jeff's comments? https://phabricator.wikimedia.org/T188931 [00:31:50] i feel pretty positive i saw those grants in place already but it was late... [00:35:03] cwd I think it IS possible it's been broken a while [00:35:33] because it only affects records WITH a number & most don't have one [00:38:11] eileen: have you tried again since he ran the grants? [00:38:56] if it works i'll chalk it up to me being confused [00:42:17] yep re-saved civicrm/contact/view?reset=1&cid=2256175 (who has a phone) & no message [00:42:35] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Missing sql fn gives a warning whenever we edit a conta... - https://phabricator.wikimedia.org/T188931#4071464 [00:43:14] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Fix issues with Geocoder extension enabling disa... - https://phabricator.wikimedia.org/T190119#4063508 [00:43:16] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Step 1 , 2 and 3 of engage import - https://phabricator.wikimedia.org/T189617#4071471 (Eileenmcnaughton) [00:44:58] eileen: ugh sorry i somehow missed that [00:47:34] cwd all good now [00:48:59] maybe flush privileges was never run [00:49:07] although i'd think restarting the db would do that [00:49:30] i just am sure i saw these grants in place on the master [00:49:54] i pasted it into irc [00:50:35] oh well [10:16:05] Fundraising-Backlog, Google-Summer-of-Code (2018): GSOC proposal - Machine learning fraud detection - https://phabricator.wikimedia.org/T190103#4063066 (saurabhbatra96) @srishakatux @Eileenmcnaughton duly noted. Thanks for the info; I'll try and do a draft on phab (and also Civi's gitlab) by EOD. [10:30:16] Fundraising-Backlog, Google-Summer-of-Code (2018): GSOC proposal - Machine learning fraud detection - https://phabricator.wikimedia.org/T190103#4072224 (Eileenmcnaughton) @saurabhbatra96 - I added the project to the WMF page - https://www.mediawiki.org/wiki/Google_Summer_of_Code/2018 [12:55:07] (CR) Jgleeson: "Ah ok, the dot-delimiter path felt easier to work with for me, especially for deep multi-dimensional arrays with paths that you can't easi" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [13:38:57] (PS17) Jgleeson: T176502 WIP: Updated Ingenico error handling [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 [14:38:55] hi jgleeson, just looked at your patch if you have a second [14:39:20] hey mepps, sure [14:39:43] so my thought wasn't actually the dot delimiter or that it wasn't a constant [14:40:39] yeah, I interpreted your not as pass in a consistent array for both calls? [14:40:44] was that not what you meant? [14:40:49] your note* [14:40:55] it was that since the path to errors for hosted checkout will be the same as within the payment provider, with the only difference being that the payment object is wrapped in createdPaymentOutput [14:41:28] you could always assume the location of the errors within the payment object and just pass that from hostedCheckoutProvider [14:41:42] rather than have to worry about setting the path to errors at all [14:42:18] does that make sense, or have you found somewhere where there is no payment object (other than createHostedCheckout which just has the high level errors anyways) [14:42:50] oh you mean extract the errors array at the higher level and pass it down? [14:44:22] so i mean assume that you know the path within the payment object and then only pass the payment object to hasErrors but if this isn't making sense it's okay [14:44:22] I guess I avoided that because it means checks in the top level provider calls to inspect the contents of the array [14:44:43] no i don't mean do it in the higher level calls, sorry [14:45:13] we have to make the check, as the key isn't present unless there's an error [14:46:28] let's hop on a call jgleeson [14:46:34] might be easier to throw down some pseudo code in an etherpad? [14:46:46] ah, I can't really talk now I'm in a noisey cafe with headphones on [14:47:36] actually [14:47:36] I can listen [14:47:40] be in queen mary in 2 minutes [14:48:06] let me see if i can explain it with pseudocode--just ran into and out of a room where i could talk :) [14:49:01] ok, I have sound now [15:01:55] fr-tech: to whom it may concern, civi staging restore is done [15:03:30] takes somewhere around 15-20 hours by now [15:12:44] ejegg|afk, when you're around can you msg me. I'm trying to add a tmp file log stream on smashpig for testing and wondered if you had any thoughts [15:16:51] jgleeson: only to tear out the custom logging and use monolog :) [15:17:09] cwd thanks! [15:17:20] does that include all the dbs? [15:24:06] i wonder if we should separate out the civi log tables [15:28:51] ejegg|afk: civi, drupal, and fredge [15:42:22] (PS18) Jgleeson: T176502 WIP: Updated Ingenico error handling [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 [15:43:39] mepps, I've updated the patch to what I think is a good middle ground of our points [15:43:56] take a look when you get a minute and let me know if it's what you are expecting [15:44:38] I need to move to somewhere quieter for stand-up! back shortly fr-tech [16:00:38] (CR) AndyRussG: "Looks great, and works as advertised!!!" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319003 (https://phabricator.wikimedia.org/T121178) (owner: Ejegg) [16:30:11] (CR) Mepps: [C: 1] "Just about there--two comments though I'm ready to +2 if ejegg is!" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [16:40:09] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", an... - https://phabricator.wikimedia.org/T186883#4073252 [16:54:25] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4073341 (BBlack) Yeah I do have concerns here. It's going to take some time before I can loop back and explain them, but I just wanted to put the not... [16:55:12] (PS11) Ejegg: Rename some impressionDiet variables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319003 (https://phabricator.wikimedia.org/T121178) [16:55:56] (CR) Ejegg: "Thanks for the comments AndyRussG, definitely an improvement!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319003 (https://phabricator.wikimedia.org/T121178) (owner: Ejegg) [17:05:46] mepps I added my notes on the payment processor table in civi here: https://www.mediawiki.org/wiki/Talk:Fundraising_tech/Ingenico_Connect [17:24:55] great ejegg! [17:26:30] (CR) AndyRussG: [C: 2] "Cool, thanks!!!!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/410614 (owner: Ejegg) [17:29:58] (Merged) jenkins-bot: Clean up stray OldCookieEpoch settings [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/410614 (owner: Ejegg) [17:39:16] (CR) Ejegg: "Code looks good! Just a couple of questions on intent." (6 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419331 (https://phabricator.wikimedia.org/T189617) (owner: Eileen) [17:43:53] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4073507 (CCogdill_WMF) [17:44:15] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4012170 (CCogdill_WMF) Updating task as I want to update the subdomain in the request. [17:56:58] mepps: OK to merge your 'Test passing, clean up' patch? [17:57:21] sure ejegg [17:58:10] I was thinking it might make sense to squash with the next, since there's some work done & undone [17:58:13] but... [17:58:20] the next one is already big enough [18:02:59] (CR) Ejegg: [C: 2] "Thanks for the version updates and new tests! Merging with the understanding that some of the changes are undone in the next patch." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) (owner: Mepps) [18:03:33] (Merged) jenkins-bot: Tests passing, clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415085 (https://phabricator.wikimedia.org/T176502) (owner: Mepps) [20:26:17] Seddon: about https://phabricator.wikimedia.org/T190346, I found out what was the problem: the cookies settings, you need to permit third-party cookies (and I did not). [20:26:28] It was obvious in hindsight but it didn't spring to mind, after you told me you confirmed the problem I assumed it had nothing to do with my settings. [20:26:54] ahhhh, yeah. If only we hosted everything on one domain... :) [20:27:10] I verified that by default, even in Seamonkey, all cookies are allowed. [20:27:33] ok, that's a relief (for our purposes, at least...) [20:29:13] So in the end no one else experienced it, right? I had the impression that Seddon did, in his own tests (and that's mostly why it didn't occur to me to look at such an obvious thing) [20:29:17] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", ... - https://phabricator.wikimedia.org/T185933#4074050 [20:29:52] Gabrolf: I'm not exactly how Seddon was testing. I wasn't able to reproduce the problem outside of private mode [20:30:08] *I'm not sure exactly [20:30:32] Ok, we probably misunderstood each other [20:32:20] As far as I'm concernced, the bug can be closed. Should I write a note myself on it (I got registered at phabricator)? [20:32:55] Gabrolf: sure, that would be great! [20:33:07] Ok [20:36:22] BTW, not great this thing that you need to allow third-party cookies (I think it's common these days to disallow them, and I haven't encountered any other problem in years with blocking all of them -I mean the third party ones-), there are several things that could be done to improve the situation, but I'll probably discuss that in some other place. Once you know there's this thing is fairly easy to cope with it, though [20:36:45] just for a moment, they're not deleted if you then change back the setting). [20:38:23] Gabrolf: we'd love to hear suggestions for other ways to achieve the same thing! [20:39:03] Just a moment, I write the thing on phabricator first [21:02:22] Fundraising-Backlog: Thank you cookies not setting on non-chrome browsers - https://phabricator.wikimedia.org/T190346#4070754 (Gabrolf) I'm the donor mentioned above, I subsequently found out that I had simply blocked third-party cookies (which are of course required for this to work) in the browser. I'm so... [21:03:17] Ok, done. I've not changed the bug's status yet (I probably can't even do it myself). [21:03:57] thanks again Gabrolf ! [21:11:45] AndyRussG: are you a moderator on cn-admins list? [21:12:07] I just sent a reply about translateable messages, already a few days late... [21:13:50] oh hmm, I suppose I could have added a link to https://meta.wikimedia.org/wiki/Help:CentralNotice#MediaWiki_messages as well [21:19:17] anyway, my reply is awaiting moderation [21:19:53] ejegg: So, one simple and quick thing to improve the situation (I believe it's not uncommon to block third-pary cookies these days) would be to put a notice about this on https://wikimediafoundation.org/wiki/Thank_You , and possibly even in the thank-you mail. [21:20:00] I'd say something like: "After making this donation you should not see fundraising banners for the current campaign anymore. If you keep seeing them, look for possible problems that might come up and solutions" would be a link to a page exposing the possible problems and solutions. Alternatively, even easier, you could just write everything in the https://wikimediafoundation.org/wiki/Thank_You page. [21:20:07] The notice should be made very prominent, most people will see "Thank you" and close the page right away, without reading anything else, if there's nothing else outstanding in the page. [21:20:40] OK, I'll pass that along to the folks that design that page [21:25:08] PROBLEM - check_puppetrun on pay-lvs2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[pybal] [21:27:22] Of course that would make more people aware of the banner-blocking cookie, and there'd be an higher risk that people who have not donated use it. So it's in part a political decision. Personally I thing there would be nothing wrong, when someone gets so annoyed by the banners to search the web for how to hide them, he already made up his mind as to whether donate or not. [21:30:08] RECOVERY - check_puppetrun on pay-lvs2001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [21:36:00] Gabrolf: yeah, we're not trying to keep it a big secret [21:36:14] Good to hear [21:36:14] and we're working hard to show fewer banners each year [21:41:24] Well, I hate to say it that's not really what comes through. This year's campaign is the most obnoxious thing I've seen on the web in, possibly, 15 years (ok, admittedly I see very few obnoxious things with the settings and extensions I use). [21:41:34] "it but that's" [21:42:58] I have to leave, I have a couple of other things to ask but I'll defer that to tomorrow. Thank you for everything. [21:43:10] thanks for all the feedback! [21:45:08] PROBLEM - check_puppetrun on pay-lvs1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 4 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[pybal] [21:50:08] PROBLEM - check_puppetrun on pay-lvs1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 1 minute ago with 1 failures. Failed resources (up to 3 shown): Package[pybal] [21:51:04] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", an... - https://phabricator.wikimedia.org/T186883#4074358 [22:00:08] PROBLEM - check_puppetrun on pay-lvs1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 4 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[pybal] [22:05:08] RECOVERY - check_puppetrun on pay-lvs1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [22:06:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Weird language code crashes dq consumer - https://phabricator.wikimedia.org/T190467#4074398 (Ejegg) [22:17:47] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", ... - https://phabricator.wikimedia.org/T185933#4074454 [22:22:47] (CR) Ejegg: T176502 WIP: Updated Ingenico error handling (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [23:45:49] ejegg|afk: hey, lemme check... Maaaaaaaaaaaybe