[09:01:14] Fundraising-Backlog: Thank you cookies not setting on non-chrome browsers - https://phabricator.wikimedia.org/T190346#4075120 (Jseddon) Open>Resolved [11:01:18] (CR) Jgleeson: T176502 WIP: Updated Ingenico error handling (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [11:13:21] (CR) Jgleeson: "Added tests checking the response. Fixed WS issue (I think)" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [11:14:56] (PS19) Jgleeson: T176502 WIP: Updated Ingenico error handling [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 [11:18:44] (CR) Jgleeson: T176502 WIP: Updated Ingenico error handling (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [11:57:53] (PS20) Jgleeson: T176502 WIP: Updated Ingenico error handling [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 [11:58:44] man that was one tangled branch [11:59:02] should now be merge-able ! [12:00:04] right fr-tech, gonna jump off now and be back around about 2:30pm UTC [14:09:09] jlgeeson|away when you get back, want to remove the WIP from your patch? [14:12:19] Fundraising-Backlog, Google-Summer-of-Code (2018): [GSoC 2018] Machine Learning for Fraud Detection - https://phabricator.wikimedia.org/T190523#4075836 (saurabhbatra96) [14:12:53] fundraising-tech-ops: build & deploy latest pybal for frack - https://phabricator.wikimedia.org/T176260#4075849 (Jgreen) a:Jgreen [14:14:52] Fundraising-Backlog, Google-Summer-of-Code (2018): GSOC proposal - Machine learning fraud detection - https://phabricator.wikimedia.org/T190103#4075873 (saurabhbatra96) Shifted the content and subscribers to T190523. @Eileenmcnaughton it might be okay to close this now. [15:44:56] (CR) AndyRussG: [C: 2] "Woohoo! Good stuff :) Thanks!!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319003 (https://phabricator.wikimedia.org/T121178) (owner: Ejegg) [15:46:36] hello fr-tech :) [15:46:48] (CR) Mepps: "A couple questions, but if all is working then it's fine for now." (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [15:46:52] hi jgleeson [15:47:36] hi jgleeson [15:48:08] (Merged) jenkins-bot: Rename some impressionDiet variables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319003 (https://phabricator.wikimedia.org/T121178) (owner: Ejegg) [15:50:07] mepps, do you mean log the errors separately, in your second comment? [15:50:30] https://gerrit.wikimedia.org/r/#/c/415907/20/PaymentProviders/Ingenico/Api.php@84 [15:51:09] or something else, I don't quite understand what you mean [15:52:21] also, can you confirm all is working at your end, I'd be worried if it wasn't tested before merging by multiple parties [15:52:59] mepps: you mean that we're going to log the exception someplace anyway? And that it seems redundant to also log the errors before throwing? [15:54:15] this was my summary of the logging addition, https://phabricator.wikimedia.org/T176502#4056183 [15:54:24] last paragraph [15:55:24] ejegg, to my understanding the individual errors are not logged at any point if present [15:55:41] to be more specific, the indivdual payment status errors [15:55:56] within smashpig [15:59:48] (CR) Jgleeson: T176502 WIP: Updated Ingenico error handling (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [16:00:25] ejegg that was what i meant but maybe i'm misunderstanding something? [16:01:08] jgleeson: oh, right, I think we were looking at the logging for the root-level API errors [16:02:19] https://gerrit.wikimedia.org/r/#/c/415907/20/PaymentProviders/Ingenico/Api.php@84 [16:02:54] ejegg/jgleeson, meeting? [16:03:01] coming! [16:04:19] also XenoRyet [16:05:48] oops, one sec! [16:42:13] ejegg, mepps I think I see what you mean about the logging in the core api [16:42:34] I actually think that was originally logging the payment status errors [16:42:44] and I've missed it when porting changing it around! [16:43:45] I wanted to ask you both originially whether you thought there was any value in logging the payment status errors in smashpig, my thoughts were that they might have some value [16:43:57] what do you think ejegg mepps ? [16:44:44] I don;t think it'll hurt anything [16:45:06] might as well leave it in for this version, and take it out if it looks excessive [16:45:24] anyway, i'm happy with the externally-visible parts of the change [16:46:03] I mean it we don't get any value from the status errors, I can omit it [16:46:12] it's easy either way for me [16:46:22] don't wanna add fluff that we need to rip out later [16:46:29] if it's not adding value [16:46:51] nah, let's leave it in and see if they're easier to grep for in the logs [16:46:57] 0k cool! [16:47:03] that was a good typo [16:47:11] 0k [16:47:12] :) [16:47:15] heh, nice [17:03:34] (Abandoned) Ejegg: Report consumer run time and drush startup time [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381856 (owner: Ejegg) [17:03:41] (Abandoned) Ejegg: Only report age of messages from payments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382858 (https://phabricator.wikimedia.org/T176920) (owner: Ejegg) [17:27:59] (PS1) Umherirrender: Use namespaced PHPUnit\Framework\TestCase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421586 (https://phabricator.wikimedia.org/T188166) [17:36:52] (CR) Jforrester: [C: 2] Use namespaced PHPUnit\Framework\TestCase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421586 (https://phabricator.wikimedia.org/T188166) (owner: Umherirrender) [17:44:16] (Merged) jenkins-bot: Use namespaced PHPUnit\Framework\TestCase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421586 (https://phabricator.wikimedia.org/T188166) (owner: Umherirrender) [18:17:29] (CR) Ejegg: T176502 WIP: Updated Ingenico error handling (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [18:20:24] AndyRussG: i left a little feedback on the landing page EL schema in the ticket: https://phabricator.wikimedia.org/T185933 [18:30:59] ejegg: yeah I saw that! thanks :) [18:31:59] I guess the "required" bit boils down to where we want to see an error if a field is missing--in our janky python script, or in some EL validation error log [18:32:06] (not sure where that lives) [18:34:39] wrt article, I was gonna ask if that's definitely used? [18:34:51] (as in, in queries/data analysis) [18:35:57] (CR) Jgleeson: T176502 WIP: Updated Ingenico error handling (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [18:39:29] AndyRussG: good question re usage [18:45:34] (CR) Jgleeson: T176502 WIP: Updated Ingenico error handling (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [18:47:30] ejegg: I mean, if it's already being slurped, I guess now is not the time to change it... But in a privacy-by-design world, we otta prolly be purging fields if they're eventually found not to be especially inspiring [18:51:03] so regarding fields required according to the script, you agree they should also be set to required in the EL schema? [18:51:53] I think there's not much chance of data loss by doing so, in that the full webrequest log of the EL event request will remain in Hive 3 months, and there's nothing we'd get that isn't there [19:31:22] AndyRussG: yeah, let's try to keep the stuff valid all the way up [20:03:44] (PS21) Jgleeson: T176502 WIP: Updated Ingenico error handling [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 [20:07:35] (PS22) Jgleeson: T176502 WIP: Updated Ingenico error handling [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 [20:12:42] (CR) Jgleeson: "@ejegg / @mepps" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/415907 (owner: Jgleeson) [20:56:13] (PS2) Ejegg: WIP Ingenico: tokenize recurring payments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) [20:57:51] (CR) jerkins-bot: [V: -1] WIP Ingenico: tokenize recurring payments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) (owner: Ejegg) [21:21:43] (PS3) Ejegg: WIP Ingenico: tokenize recurring payments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) [21:23:29] (CR) jerkins-bot: [V: -1] WIP Ingenico: tokenize recurring payments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) (owner: Ejegg) [21:26:16] (PS4) Ejegg: WIP Ingenico: tokenize recurring payments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) [22:37:05] (PS1) Ejegg: WIP insert records (mostly dummy) for processors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/421663 (https://phabricator.wikimedia.org/T165695) [22:51:53] (PS1) Ejegg: WIP API call to tokenize old GC recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421665 (https://phabricator.wikimedia.org/T169357) [22:53:46] (CR) jerkins-bot: [V: -1] WIP API call to tokenize old GC recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421665 (https://phabricator.wikimedia.org/T169357) (owner: Ejegg) [22:55:39] (PS2) Ejegg: WIP API call to tokenize old GC recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421665 (https://phabricator.wikimedia.org/T169357) [23:18:11] Fundraising-Backlog, FR-Adyen: Adyen audit wobble: 3/16 refunds & chargeback not in Civi - https://phabricator.wikimedia.org/T190594#4077742 (MBeat33) [23:30:12] PROBLEM - check_puppetrun on pay-lvs2001 is CRITICAL: CRITICAL: Puppet last ran 8 hours ago [23:30:36] heading out for the weekend. have a good one, fr-tech! [23:32:05] See you next week [23:35:12] RECOVERY - check_puppetrun on pay-lvs2001 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures