[10:14:06] (PS1) Gopavasanth: Change http://www.mediawiki.org/ to https://www.mediawiki.org/ [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423457 (https://phabricator.wikimedia.org/T189687) [10:23:43] (CR) Zoranzoki21: [C: 1] "Thank you very much!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423457 (https://phabricator.wikimedia.org/T189687) (owner: Gopavasanth) [12:38:09] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4096850 (schoenbaechler) [12:40:46] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4096851 (schoenbaechler) [14:38:51] morningz! [14:51:48] morning AndyRussG! [14:53:41] (PS2) Ejegg: Change http://www.mediawiki.org/ to https://www.mediawiki.org/ [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423457 (https://phabricator.wikimedia.org/T189687) (owner: Gopavasanth) [14:53:47] (CR) Ejegg: [C: 2] Change http://www.mediawiki.org/ to https://www.mediawiki.org/ [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423457 (https://phabricator.wikimedia.org/T189687) (owner: Gopavasanth) [14:56:48] (Merged) jenkins-bot: Change http://www.mediawiki.org/ to https://www.mediawiki.org/ [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423457 (https://phabricator.wikimedia.org/T189687) (owner: Gopavasanth) [14:57:56] hi AndyRussG! hi mepps! [14:58:22] hi ejegg! [14:58:39] mepps: ejegg: :) [14:59:14] why does the first tab-complete in IRC add a colon on the end of the nickname, but the remaining ones don't? [14:59:23] It's always irked me [14:59:32] I guess we should all switch to Skype [14:59:38] heh [15:00:14] no? [15:00:23] or ICQ [15:00:41] Heh I remember being amazed when that one first came out [15:00:55] aww, man, yeah, I was a big fan of that one [15:01:12] not sure why, i felt like i was way cooler than the dweebs using aim [15:02:42] I bet IRC predates them tho [15:07:36] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4097246 (Ejegg) @XenoRyet LMK when you're available, I'll show you how to suture those two f... [15:07:54] heh indeed, IRC is from 1988 [15:12:11] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Drupal security release dropping on 28 March - https://phabricator.wikimedia.org/T190347#4097258 (Ejegg) Open>Resolved p:Triage>High a:Eileenmcnaughton [15:17:17] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Drupal security release dropping on 28 March - https://phabricator.wikimedia.org/T190347#4097268 (Ejegg) @Eileenmcnaughton the .htaccess changes look fine - just allowing access to the .well-known directory, a... [15:36:14] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", and... - https://phabricator.wikimedia.org/T185933#4097396 [15:43:48] Fundraising-Backlog, Analytics, MediaWiki-extensions-CentralNotice: Make banner impression counts available somewhere public - https://phabricator.wikimedia.org/T115042#4097441 (Milimetric) p:Normal>Triage [16:17:38] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", and... - https://phabricator.wikimedia.org/T185933#4097599 [16:21:05] (PS6) Ejegg: WIP Ingenico: tokenize recurring payments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) [16:26:24] (CR) jerkins-bot: [V: -1] WIP Ingenico: tokenize recurring payments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) (owner: Ejegg) [16:29:15] (PS7) Ejegg: WIP Ingenico: tokenize recurring payments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) [16:30:31] (PS8) Ejegg: Ingenico: tokenize recurring payments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) [16:32:21] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, Unplanned-Sprint-Work: Option to enforce CSP on banner previews and flag errors - https://phabricator.wikimedia.org/T190100#4097637 (DStrine) [16:37:01] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4097664 (CCogdill_WMF) Just noting I'm still on standby re: emails. When are we thinking of... [16:57:19] d'oh, phpstorm is saying my license is about to expire... [16:57:57] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4097726 (XenoRyet) @CCogdill_WMF We should have the GlobalCollect side ready to refund in th... [17:00:16] pcoombe do you know if any pages on donatewiki other than Special:LandingPage are actually still in use as landing pages? thx!!! [17:00:28] I didn't know the licences they let us use did that. [17:00:53] XenoRyet: once I updated to the 2018.1 version it popped up an expiry notice [17:01:02] Huh [17:01:03] they still want a bit of your soul now and again [17:01:44] I guess I'll stay on 2017.3 for now. [17:02:51] Anyway ejegg, if you want to show me that file surgery magic again, I've got about an hour right now. [17:03:12] ok, after standup? [17:03:32] Oh sure. I didn't know you were in that one. [17:03:59] it's basically just using the 'cut' and 'paste' commands [17:04:08] if you want to start by reading the man pages on those [17:04:16] Yea I'll do that. [17:04:30] I probably could've figured it out on Thursday, but I got distracted with other stuff. [17:27:07] XenoRyet: ok, I'll be in the usual hangout in a minute [17:27:13] fr-tech is the ContributionTracking Mediawiki extension used anywhere other than Donatewiki? [17:27:25] AndyRussG: it's on paymentswiki [17:27:29] k, be there in a minute as well [17:27:36] and really shouldn't need to be on donatewiki [17:27:49] but it's a dependency of donationinterface [17:27:57] and pyamentswiki uses donationinterface messages [17:29:31] ejegg: yeah hrm... FundraiserLandingPage extension uses https://donate.wikimedia.org/wiki/Special:FundraiserMaintenance [17:29:44] just hardcoded in there [17:29:51] blah [17:30:20] https://github.com/wikimedia/mediawiki-extensions-FundraiserLandingPage/blob/master/FundraiserLandingPage.body.php#L22 [17:31:20] also, it seems that a lot of JS for FR forms on Donatewiki is just in Mediawiki:Common.js [17:34:59] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Add Banner Guidelines link to banner edit screen - https://phabricator.wikimedia.org/T190089#4097843 (DStrine) Please use the page below. @Seddon is working to differentiate usage guidelines... [17:40:59] Fundraising-Backlog: Spike: assess pitpay as a new processor - https://phabricator.wikimedia.org/T191220#4097863 (DStrine) [17:58:02] gonna get some lunch, back soon [18:21:00] ccogdill: You around? The GC refunds are ready to run. I had one more question for ejegg when he gets back from lunch but then we're ready to go. [18:21:13] awesome, thanks! [18:21:35] Did you want to send that email first, or should I just go ahead and do it after I talk to ejegg? [18:21:38] I checked in with MBeat and he's cool for me to send the email anytime after you process them [18:21:53] PP is the one where we want to get the emails out beforehand [18:22:08] Yep, GC is easier. Or at least quieter. [18:22:15] Ok, me first. I'll let you know when it's done. [18:38:29] XenoRyet|brb: what's your question? [18:39:50] ty XenoRyet|brb [18:51:08] ejegg: Mepps was saying that the GC script might need an unsubscribe flag, but wasn't sure if that was actually necessary given that we've already canceled the subscriptions. [18:51:44] right, that part of the code didn't actually achieve the desired result anyway [18:52:08] Ok, so I'll just run the script on our file without that flag. [18:52:13] cool [18:52:24] Anything else tricky about it, or should I just run it? [18:52:26] good idea to run in under 'screen' [18:52:37] in case you get disconnected [18:52:47] Ah, ok. [18:53:01] you familiar with that one? [18:53:17] No, but I'll read up real quick. [18:53:51] Unless it's easy and you can give me a tl;dr [18:54:03] you can just type 'screen' to start it [18:54:11] then run commands as normal [18:54:52] then if you get disconnected it'll keep running the command (instead of killing it as otherwise happens) [18:55:03] Good times [18:55:03] and you can log back on and type 'screen -r [18:55:05] ' [18:55:08] to reconnect [18:55:15] cool [18:55:24] Ok, I'll go run the thing. [18:55:38] cool [18:55:40] oh hey [18:55:43] XenoRyet: [18:55:50] ? [18:56:08] you could also redirect the output to a file, if you wanted to have that for posterity [18:56:14] Good call [19:24:17] (PS1) Matěj Suchánek: Replace some Linker::link() usages with LinkRenderer [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423521 (https://phabricator.wikimedia.org/T149346) [19:24:29] (CR) jerkins-bot: [V: -1] Replace some Linker::link() usages with LinkRenderer [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423521 (https://phabricator.wikimedia.org/T149346) (owner: Matěj Suchánek) [19:31:28] (PS10) Matěj Suchánek: Replace Linker::link() with LinkRenderer [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336010 (https://phabricator.wikimedia.org/T149346) [19:31:30] (PS2) Matěj Suchánek: Replace some Linker::link() usages with LinkRenderer [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423521 (https://phabricator.wikimedia.org/T149346) [19:31:44] (PS3) Ejegg: API call to tokenize old GC recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421665 (https://phabricator.wikimedia.org/T169357) [19:32:06] fr-tech another piece of the ingenico connect puzzle ^^ [19:32:12] that, plus the parent patch [19:32:31] great ejegg! [19:33:45] (PS3) Matěj Suchánek: Replace some Linker::link() usages with LinkRenderer [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423521 (https://phabricator.wikimedia.org/T149346) [19:33:58] Fundraising-Backlog: Spike: assess bitpay as a new processor - https://phabricator.wikimedia.org/T191220#4098288 (DStrine) [19:34:27] AndyRussG: meeting? [19:36:48] dstrine: coming! [19:36:51] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog: Spike: assess bitpay as a new processor - https://phabricator.wikimedia.org/T191220#4097863 (DStrine) [19:44:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: normalize sort names for Civi agents - https://phabricator.wikimedia.org/T190335#4098321 (MBeat33) Open>Resolved a:MBeat33 That worked, I can filter for them by //last name, first name// now - thank you. [19:44:52] Fundraising-Backlog, FR-Amazon, Fr-backlog-cleanup-Q3_2017-18: Amazon interstitial page - https://phabricator.wikimedia.org/T121698#4098338 (Ejegg) Open>Resolved a:Ejegg Looks like this was resolved [19:44:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi notes field is not WYSIWYG - https://phabricator.wikimedia.org/T190872#4098341 (DStrine) [20:04:28] Fundraising-Backlog, Wikimedia-Fundraising: Move fundraising thank you pages to donate.wikimedia.org - https://phabricator.wikimedia.org/T189664#4098403 (DStrine) bumping this Fr-tech assumes this is a task for the banner team. We are not watching this task at this time. [20:12:30] cwd: and Jeff_Green we have at least one topic for you. want to join us for a chat? [20:13:34] sure [20:16:53] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4085619 (mepps) @MBeat33 @CCogdill_WMF we should coordinate on when the paypal refunds will... [20:19:11] yup [20:45:33] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4098591 (XenoRyet) GC side is complete. Subscriptions have been canceled and transactions r... [21:19:28] Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, and 8 others: Mediawiki namespace pages, including CentralNotice banners, are slow to sa... - https://phabricator.wikimedia.org/T158084#3026116 [21:29:33] (PS2) Ejegg: WIP emit CSP headers on banner previews [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/420754 (https://phabricator.wikimedia.org/T190100) [21:32:31] (CR) jerkins-bot: [V: -1] WIP emit CSP headers on banner previews [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/420754 (https://phabricator.wikimedia.org/T190100) (owner: Ejegg) [21:36:30] MBeat: hey - do you want to talk fraud report today? [21:37:18] hi eileen tomorrow might be better if you have the time, I’m digging out from last week [21:38:23] MBeat: ok sure [21:38:37] thank you [21:45:02] ejegg: regarding this change to recording total amount per year instead of yes/no - what is your opinion on using triggers? [21:45:42] eileen: I sure wouldn't reject it out of hand [21:46:41] My suspicion is that it's more efficient & there is no way it can be bypassed [21:46:43] Oh, we should probably exempt that table from logging, as it's calculated [21:47:21] ejegg: there is one non calculated field… but I was thinking to add a new custom data set [21:47:36] & then once we are happy we can remove those fields in that set [21:47:49] & the new set can be non-logged from the start [21:47:54] eileen: ok, any worries about the extra join? [21:48:16] extra joins with 2 sets? [21:48:34] it would mean adding another table, right? [21:48:39] yeah [21:48:55] in general we should try to pass in 'return' when calling api etc [21:49:03] to not join more tables than we need to [21:49:05] right [21:49:28] but in terms of numbers we are not in a bad place with custom field groups [21:50:00] it's just that we should in general avoid calling contact.get etc without 'return' [21:50:14] there is a v4 api in progress that won't return as much by default [21:50:15] ok [21:51:34] in terms of table name - I'd prefer to be closer to the civi convention than wmf_donor is [21:51:55] but, if we want to be able to hard-code the table name we could go with civicrm_value_donor_totals [21:51:58] heh, was that some incomprehensible numbers? [21:52:16] It would be nice to have something memorable [21:52:29] (& not have the number at the end - which would be inconsistent across dev vs live) [21:53:59] yah, exactly [22:07:12] ah ejegg there are a few fields to keep in the existing set so I guess I will add there but I'd rather move do_not_solicit out of there [22:07:28] & then they would be all read only [22:07:32] eileen: yeah, it's a bit of an odd one out [22:40:28] (PS3) Ejegg: Emit CSP headers on banner previews [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/420754 (https://phabricator.wikimedia.org/T190100) [22:41:01] AndyRussG: That patch does the thing... not especially beautifully, but does it ^^^ [22:41:34] ejegg: fantastic! I'll check it out :) thx!!!! [22:43:19] AndyRussG: ah, I should note the event I'm depending on isn't well supported in Firefox :( [22:43:29] almost every other browser does have it [22:43:35] including Chromium [22:44:21] FF 59 adds it [22:44:27] but behind an about:config var [22:44:35] https://developer.mozilla.org/en-US/docs/Web/API/SecurityPolicyViolationEvent#compatNote_1 [22:52:16] (PS4) Ejegg: Emit CSP headers on banner previews [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/420754 (https://phabricator.wikimedia.org/T190100) [22:52:24] noted... [22:54:57] Ah hmm okok [23:16:33] phew, bitpay looks like a pretty full-on integration [23:16:44] includes IPNs and all [23:16:59] well, I'mma head out for now [23:17:03] see you later, all!