[05:16:38] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add yearly totals to WMF donor table - https://phabricator.wikimedia.org/T186165#3935472 (Eileenmcnaughton) I've been trying to check the queries that currently take place to ensure we get the rig... [09:31:16] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", and... - https://phabricator.wikimedia.org/T185933#4100024 [09:47:01] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: need new ct_id after successful donation - https://phabricator.wikimedia.org/T190871#4100038 (jgleeson) Open>stalled [09:47:58] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: need new ct_id after successful donation - https://phabricator.wikimedia.org/T190871#4086175 (jgleeson) Email on subject: Hi Elliott I managed to track down the duplicate ct_... [09:53:08] Fundraising-Backlog, Wikimedia-Fundraising: Move fundraising thank you pages to donate.wikimedia.org - https://phabricator.wikimedia.org/T189664#4100080 (Pcoombe) a:Pcoombe Yes, I'll take care of this and will just need tech's help to change the payments config at the end. [10:09:56] Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, and 8 others: Mediawiki namespace pages, including CentralNotice banners, are slow to sa... - https://phabricator.wikimedia.org/T158084#3026116 [10:27:14] (CR) Jgleeson: [C: 1] "Tested with manual submission and worked as expected. Looks like we handle any potential errors sent back at the API level so no need for " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) (owner: Ejegg) [12:25:33] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-Ingenico-integration_2017-18, Patch-For-Review: Store recurring tokens in Civi's payment_token table - https://phabricator.wikimedia.org/T165695#3274065 (jgleeson) a:jgleeson [14:31:10] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-Ingenico-integration_2017-18, Patch-For-Review: Store recurring tokens in Civi's payment_token table - https://phabricator.wikimedia.org/T165695#4100706 (jgleeson) Should we be updating... [15:10:00] Fundraising-Backlog: Question: environment to help automate email stats collection? - https://phabricator.wikimedia.org/T191084#4092938 (cwdent) If the code was published somewhere (gerrit?) we could potentially get Security to review it and package it up like we do with other libs. However since no PII is... [15:12:10] Fundraising-Backlog: Question: environment to help automate email stats collection? - https://phabricator.wikimedia.org/T191084#4100832 (DStrine) @Ejegg did you have anything else to add? [15:19:56] fr-tech, be back in around an hour, gonna go pick up family! [16:31:24] hi ejegg, when you get a chance could you checkout https://phabricator.wikimedia.org/T190871#4100038 and https://phabricator.wikimedia.org/T165695 please. [16:31:36] s/checkout/take a look/ [16:36:45] ejegg, I also have a couple of questions around the distinction between the subscr_id, and the civicrm_payment_token id [16:53:32] jgleeson: taking a look! [16:53:53] jgleeson: think we should just use one message field? [16:54:02] and decide where to store it based on the gateway? [16:57:29] ok that leads on to my other question [16:57:40] is the subscr_id short for subscription_id ? [16:58:39] jgleeson: yeah [16:58:53] seems to have been named for the field in the paypal IPN messages [16:59:37] ok [17:00:16] so that is the alias for the civicrm_contribution_recur trxn_id [17:00:27] which holds the payment_token_id [17:01:50] jgleeson: so far, we haven't had any payment tokens at all [17:02:01] ah ok [17:02:05] so this is new ground [17:02:11] yeah [17:04:22] is the current subscription/recurring behaviour is limited to paypal? [17:04:39] paypal and globalcollect recurring [17:04:52] the old style globalcollect recurring IS initiated on our side [17:05:04] but we use the same order ID over and over [17:05:10] rather than a distinct 'token' [17:05:24] we just increment the 'effort id' each time [17:05:53] the 'token' stuff is a bit more standard across credit card processors [17:06:12] and i think is the way we would go forward with android / apple pay too [17:06:18] it's like a stand-in for a CC # [17:06:30] yeah that makes sense [17:06:33] that's tied to a particular merchant [17:06:42] I've used tokens before [17:07:02] I was just struggling to bridge our subscription / recurring / token relations [17:07:25] right, we've got a bunch of weird old non-standard stuff right now [17:08:13] do you think it would be too big of a job to ditch the label subscription, and move everything over to recurring/token [17:08:32] no, not at all [17:08:47] well.... [17:09:02] I don't want to totally refactor all the paypal stuff just to get this done [17:09:21] but for the NEW code, let's definitely not mention 'subscription' [17:10:36] hmm, so we will put something in the civicrm_contribution_recur table's transaction_id column, though [17:10:59] trxn_id, that is [17:11:03] wouldn't that be the initial payment id [17:11:11] yeah, that sounds right [17:11:24] and then we just work off the token/recurring value for the rest [17:11:32] right, sounds good [17:12:07] ok I'll go from there. [17:15:09] Oh hey, regarding the error stuff from last month [17:15:24] I think we need something like this test for the new adapter: [17:15:27] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/tests/phpunit/Adapter/GlobalCollect/GlobalCollectTest.php#L447 [17:15:52] It looks at the specific error codes returned in the depths of that paymentOutput object [17:16:11] and makes sure we don't retry on some of the really gnarly auth decline reasons [17:16:35] I can make that test if you're happily in recurring-land [17:18:01] hmm, we should make the Ingenico tests look at the arguments sent to the SmashPig adapter, too [17:21:10] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4101369 (XenoRyet) PayPal transaction list is fixed, new file is on frdev. [19:22:56] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Investigate/fix malformed payments-init message - https://phabricator.wikimedia.org/T191336#4101926 (Ejegg) [19:24:39] (PS8) Ejegg: Add an output file showing which contacts resulted in new contacts being created [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419639 (https://phabricator.wikimedia.org/T189617) (owner: Eileen) [19:25:20] (CR) Ejegg: [C: 2] "Code is pretty straightforward, feature could be handy!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419639 (https://phabricator.wikimedia.org/T189617) (owner: Eileen) [19:30:01] (Merged) jenkins-bot: Add an output file showing which contacts resulted in new contacts being created [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419639 (https://phabricator.wikimedia.org/T189617) (owner: Eileen) [20:22:46] !log disabled thank you mail sender [20:22:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:43:56] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4102201 (CCogdill_WMF) Cool! We should coordinate more closely for the PayPal emails to dono... [21:30:09] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog: Spike: assess bitpay as a new processor - https://phabricator.wikimedia.org/T191220#4102406 (Ejegg) @ppena, the integrations described in the links look pretty hefty, with front-end form logic and IPN listeners. Did you say there w... [21:31:41] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4102409 (XenoRyet) @CCogdill_WMF Yea, we should be able to fire of the script at or about a... [21:54:52] (PS1) Ejegg: Delay TY letters for imported contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/423799 (https://phabricator.wikimedia.org/T191338) [21:55:13] eileen: I think ^^^ should do it [21:55:53] would want to see how that changed the time taken [21:56:00] for that query [22:29:11] ok, relocating... [23:08:37] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4102813 (MBeat33) Thanks y'all. Earlier in the day EST if possible would be great for DS. [23:19:27] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4102832 (CCogdill_WMF) How about 8am PST / 11am EST? @XenoRyet is the file with email addre... [23:26:03] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4102838 (MBeat33) That works nicely. [23:34:45] ejegg: I talked with MBeat about the fraud report & he is keen for deploy+keep+tweaking - the only think preventing me from trying to push through review & deploy is a hesitation as there is a patch in core for it & the next rc will drop tomorrow - so I'm inclined to deploy that rather than push that patch into our review. There are no upgrade commands of any significance in the update (a field is added to the membership t [23:34:46] able) so we don't need to have an outage etc although it would be good to check there are no critical things we co-incide with [23:35:30] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4102856 (XenoRyet) @CCogdill_WMF @MBeat33 I'm not online quite that early tomorrow and it's... [23:47:39] lol https://despair.com/